lib-storage: mail_storage_service_lookup*() - Stop reading settings

The caller is now expected to have read them already.

global: Stop assuming mail_storage_service_lookup*() is going to read settings

lib-storage: mail_storage_service_init_settings() - Stop reading settings

The settings should already have been read. Just access them.

lmtp: Replace mail_storage_service_read_settings() with master_service_settings_instance_new()

There's no need to actually read the settings, since they're already read.
LMTP client just needs a settings instance.

quota-status: Replace mail_storage_service_read_settings() with master_service_settings_read_simple()

lib-master: Use settings_parse_keyvalue_nodup()

lib-settings: Add settings_parse_keyvalue_nodup()

lib-settings: Remove internal code for multiple settings roots

lib-settings, global: Replace settings_parser_get_root_set() with settings_parser_get_set()

There is only one root now, so the root parameter isn't necessary.

lib-settings: Remove ability to use multiple roots in setting_parser_context

lib-storage: Unwrap set_keyval() wrapper function

It had become a very small wrapper, and the code is clearer without it.

lib-master, global: master_service_set() - Remove error handling

This function can no longer fail.

lib-master, lib-storage: Remove unused fields from master_service_settings_input

The username, local_ip and remote_ip are now looked up with the
master_service_settings_get() calls rather than at this early stage.

mail-crypt: Stop reading settings

The settings can now be accessed without reading them again.

doveadm: Stop reading per-connection settings

This is no longer necessary. The filtering is done by
master_service_settings_get()

doveadm: Add local_ip and remote_ip fields to connection event

These will be required to preserve support for local {) and remote {}
config filters after the following change.

login-common: Stop reading per-connection settings

This is no longer necessary. The filtering is done by
master_service_settings_get().

This commit also adds "local_name" field to client's event when TLS SNI is
used.

lib-storage: Remove mail_storage_vfuncs.get_setting_parser_info()

This is no longer necessary.

lib-storage, global: Remove "settings roots"

These were no longer used for anything.

lib-master, global: Remove "settings roots"

It's no longer necessary to know what settings the process will use.

lib-master: Delay settings parsing until master_service_settings_*get()

lib-master: Change master_service_settings_find() to be static

lib-master, lib-storage: Move key+=append and plugin/ handling to lib-master

This is necessary because all settings roots won't be known after following
changes. The plugin/ handling should eventually go away once all plugin
settings have been converted.

lib-master, lib-storage: Move -o parameter checks inside master_service_set()

lib-master: Split master_settings_mmap parsing from applying the settings

lib-master: Store filters in struct master_settings_mmap

lib-master: Remove unused config_cache_size setting

config: old-set-parser - Move imap_id_log handling to removed_settings[]

config: old-set-parser - Move login_access_sockets handling to removed_settings[]

config: old-set-parser - Merge "key is no longer needed" settings into "key has been removed" settings

There's not much of a difference between these.

config: old-set-parser - Move removed settings into an removed_settings[] array

lib-master, global: Prepare master_service_set() for type parameter

lib-master, global: Introduce master_service_settings_instance

This commit mainly consists of renaming "settings parser" to "settings
instance" in various variables and function names. The following commits
make it more useful.

lib-storage: Remove unused mail_storage_service_user_set_setting()

global: Replace mail_storage_service_user_set_setting() calls with master_service_set()

lib-storage: Don't keep mail_user.set_parser referenced

It's always just a direct pointer to service_userr->set_parser, so the
reference isn't needed. Also the following changes will change this to
a non-reference counted "settings instance", which makes this change
necessary.

lib-storage, global: mail_storage_service_read_settings() - Return duplicated parser

This will simplify following changes.

doveadm, lmtp: Use mail_storage_service_user_set_setting()

lib-storage: Replace direct settings-parser API calls with lib-master API

lib-master: Add master_service_settings_find()

lib-master: Change master_service_set() API

It wasn't currently used by core, and this API makes it close to what we
want it to be eventually.

lib-master: Remove unused master_service_get_settings_parser()

lib-settings: Remove unused settings_parse_is_valid_key()

lib-storage: Avoid separate settings_parse_is_valid_key() call

The same information can be found with settings_parse_get_value().
This will simplify the following changes.

lib-storage: Use mail_storage_service_user_set_setting() where possible

lib-storage: Fail if userdb returns key+=value for non-string

Previously an error was logged, but the user initialization didn't fail.
However, it's safer to fail since it's a bad configuration.

lib-storage: Cleanup - Change set_keyvalue() to return error_r

lib-storage: Cleanup - parse userdb settings with settings_parse_keyvalue()

lib-settings: Don't allocate settings error from parser pool

This avoids wasting memory if caller wants to ignore errors and continue
parsing.

lib-storage: Rename unexpanded_set_parsers to set_parsers

The settings are no longer expanded inside set_parsers, so they're always
unexpanded.

lib-storage: Don't duplicate mail_user.set_parser

It's always a pointer to mail_storage_service_user.set_parser, which is
already user-specific.

lmtp: Rename unexpanded_lda_set to lda_set

Also expand them, although there are currently no STR_VARS settings to be
expanded.

lib-storage: Remove unused mail_user_var_expand()

lib-storage, global: Move settings expansion out of mail_user_init()

master_service_settings_parser_get() calls can now decide whether to expand
settings or not.

lib-storage: Get mail_storage_settings with master_service_settings_parser_get()

This also changes the %variable expansion to happen via the mail_user event.

lib-storage: Remove explicit check for missing mail_home in plugin setting expansion

The %{home} expansion will now fail clearly even without this check.

lib-storage: Remove unused mail_user.unexpanded_set

lib-storage: Initialize mail_user.set immediately from service_user.set

This also simplifies accessing mail_home setting during mail_user
initialization, since the mail_home setting is already expanded.

lib-storage: Change mail_user.set to be const

imap: test-imap-client-hibernate - Avoid changing mail_user.set

The following commit prevents this by changing settings to be const.

lib-storage, global: Move mail_user_settings.{plugin_envs|namespaces} to mail_storage_settings

The following commits change %{home} to stop working in mail_user_settings.
Also, it makes more sense that namespaces are storage-related settings.

lib-storage: Remove mail_namespace.user_set

The idea was at some point to allow namespaces to override some settings.
This wasn't actually used currently, and following changes will make this
method obsolete.

lib-storage: Remove mail_storage_service_privileges.{home|chroot}

lib-storage: Handle home & chroot updating already when looking up service_user

lib-storage: Split off mail_storage_service_update_chroot()

lib-storage: set_keyval() - Remove ctx parameter

It's accessible via the user parameter.

lib-storage: Expand mail_log_prefix %variables only once

lib-storage: Expand mail_storage_service_user.user_set using master_service_settings_parser_get()

Since the settings are now expanded early, the initialization code becomes
simplified since we no longer need to expand specific settings explicitly.

lib-storage: unit tests - Fix home directory setting

The directory ended with /username/username twice. This didn't seem to
matter though.

lib-storage, util: mail_storage_service_restrict_setenv() - Remove ctx parameter

It can be accessed via the user parameter.

lib-storage: Replace settings_parser_get_root_set() with master_service_settings_parser_get()

mbox: Remove unused mbox_mailbox_list.set

maildir: Remove unused maildir_mailbox_list_context.set

imapc: Move settings initialization to imapc_storage_client_create()

lib-storage: Remove mail_storage_settings.hostname

It exists also in mail_user_settings, which is a better place for it.

lib-lda: Get hostname via mail_user_settings

It's the same value as via mail_storage_settings, but easier to get.

lib-storage: Remove mail_user.unexpanded_set_parser and related code

Use mail_storage_service_user.set_parser instead.

lib-storage: mail-storage-service - Use master_service_settings_parser_get()

lib-storage: mail_storage_service_lookup_real() - Move event creation earlier

lib-storage, doveadm: mail_storage_service_user_get_set() - Return mail_user_settings always

lmtp: Move lmtp_local_deliver_context.lda_set to lmtp_local_recipient

This simplifies the settings lookup when checking if user is over quota.

lib-storage: Remove unused mail_storage_service_user_get_ssl_settings()

lib-storage, global: Replace mail_user_init_ssl_client_settings() with mail_user.ssl_set

The ssl settings are used all over the place, so it's easier to just add
them to mail_user directly.

doveadm: Replace mail_storage_service_user_get_ssl_settings() with mail_storage_service_user_init_ssl_client_settings()

lib-storage: Add mail_storage_service_user_init_ssl_client_settings()

lib-storage: Remove unused mail_storage_service_user_get_mail_set()

lmtp: Replace mail_storage_service_user_get_mail_set() with master_service_settings_parser_get()

pop3: Use better ways of accessing mail_storage_settings

lib-storage: Remove mail_user.mail_debug

It's still available via mail_user.set.mail_debug, although shouldn't
normally be used anymore.

lib-storage: lua - Remove mail_user.mail_debug

lib-storage: Move mail_storage_settings.mail_debug to mail_user_settings

global: Replace mail_debug checks with event_want_debug()

imapc: Replace mail_debug usage with event_want_debug()

submission, mail-lua: Remove unnecessary mail_debug checks from debug logging

These aren't necessary, and they also prevent more specific debug filters
with log_debug.

lib-storage: mail_storage_service_user - Add missing %{hostname}

This existed for mail_user already.

lib-storage: Remove unused mail_storage_service_save_userdb_fields()

doveadm: Replace mail_storage_service_save_userdb_fields() with  mail_storage_service_user_get_userdb_fields()

This is much less kludgy.

lib-storage: Add mail_storage_service_user_get_userdb_fields()

lda: Use master_service_settings_parser_get()

lib-master: Remove unused master_service_settings_get_root_set[_dup]()