]> git.ipfire.org Git - thirdparty/dhcpcd.git/log
thirdparty/dhcpcd.git
6 years agoRelease dhcpcd-7.1.1 v7.1.1
Roy Marples [Thu, 7 Feb 2019 21:20:41 +0000 (21:20 +0000)] 
Release dhcpcd-7.1.1

6 years agoNot using c++11, go back to attribute
Roy Marples [Wed, 6 Feb 2019 20:07:53 +0000 (20:07 +0000)] 
Not using c++11, go back to attribute

6 years agoFix __fallthrough directive on non GNUC
Roy Marples [Wed, 6 Feb 2019 20:05:52 +0000 (20:05 +0000)] 
Fix __fallthrough directive on non GNUC

6 years agogcc: appease gcc-7's implicit fallthrough warning
Roy Marples [Wed, 6 Feb 2019 19:39:00 +0000 (19:39 +0000)] 
gcc: appease gcc-7's implicit fallthrough warning

We now need to define __fallthrough for one part because
cpp strips comments from preprocessed code and I don't want to
enforce needing -C in CFLAGS to avoid this.

6 years agoIP4: No need to set a variable to arp announce the address
Roy Marples [Wed, 6 Feb 2019 19:38:01 +0000 (19:38 +0000)] 
IP4: No need to set a variable to arp announce the address

6 years agoARP: make the announce address a constant
Roy Marples [Wed, 6 Feb 2019 19:36:36 +0000 (19:36 +0000)] 
ARP: make the announce address a constant

6 years agolink: introduce LINK_DOWN_IFFUP
Roy Marples [Wed, 30 Jan 2019 22:40:12 +0000 (22:40 +0000)] 
link: introduce LINK_DOWN_IFFUP

Set this state so when we preserve config on carrier loss.
This allows us to remove config if the interface is then brought down.

6 years agoFreeBSD: avoid kernel panics when adding on-link IPv6 routes
Roy Marples [Sat, 26 Jan 2019 02:13:29 +0000 (02:13 +0000)] 
FreeBSD: avoid kernel panics when adding on-link IPv6 routes

Also warn that OS does not support IPv6 address sharing.

6 years agossid is not NULL terminated anymore.
Roy Marples [Sat, 26 Jan 2019 00:16:09 +0000 (00:16 +0000)] 
ssid is not NULL terminated anymore.

6 years agoBSD: treat LINK_STATE_UNKNOWN as DOWN if media is invalid
Roy Marples [Sat, 26 Jan 2019 00:08:43 +0000 (00:08 +0000)] 
BSD: treat LINK_STATE_UNKNOWN as DOWN if media is invalid

On BSD, some interfaces might emit RTM_IFINFO before the link state
has initialised. Mainly wireless cards.
If the intial carrier call says media state change is valid,
we need to treat LINK_STATE_UNKNOWN as LINK_DOWN rather than
LINK_UP.

6 years agoIP6ND: Remove #defines for functions when INET6 is disabled
Roy Marples [Wed, 23 Jan 2019 13:50:34 +0000 (13:50 +0000)] 
IP6ND: Remove #defines for functions when INET6 is disabled

This allows us to optimise the code better and hopefully
become less error prone.

6 years agoBSD: Remove silly guards
Roy Marples [Wed, 23 Jan 2019 13:05:12 +0000 (13:05 +0000)] 
BSD: Remove silly guards

6 years agoDHCP6: Remove #defines for functions when DHCP6 is disabled
Roy Marples [Wed, 23 Jan 2019 13:01:19 +0000 (13:01 +0000)] 
DHCP6: Remove #defines for functions when DHCP6 is disabled

This allows us to optimise the code better and hopefully
become less error prone.

6 years agoIP4: Remove #defines for functions when INET is disabled
Roy Marples [Wed, 23 Jan 2019 11:43:11 +0000 (11:43 +0000)] 
IP4: Remove #defines for functions when INET is disabled

This allows us to optimise the code better and hopefully
become less error prone.

6 years agoDHCP: Remove #defines for functions when INET is disabled
Roy Marples [Wed, 23 Jan 2019 11:37:37 +0000 (11:37 +0000)] 
DHCP: Remove #defines for functions when INET is disabled

This allows us to optimise the code better and hopefull
become less error prone.

6 years agoIPv4LL: Remove #defines for functions when IPv4LL is disabled
Roy Marples [Wed, 23 Jan 2019 11:28:59 +0000 (11:28 +0000)] 
IPv4LL: Remove #defines for functions when IPv4LL is disabled

This allows us to optimise the code better and hopefully
become less error prone.

6 years agoIPv4LL: Fix build if not enabled.
Roy Marples [Tue, 22 Jan 2019 21:21:25 +0000 (21:21 +0000)] 
IPv4LL: Fix build if not enabled.

6 years agoRelease dhcpcd-7.1.0 v7.1.0
Roy Marples [Tue, 22 Jan 2019 14:53:45 +0000 (14:53 +0000)] 
Release dhcpcd-7.1.0

6 years agoBSD: Turn on SO_RERROR for all sockets
Roy Marples [Tue, 22 Jan 2019 14:51:42 +0000 (14:51 +0000)] 
BSD: Turn on SO_RERROR for all sockets

So we can detect IPv6ND or DHCPv6 overflow as well as route(4)
overflow.

6 years agoIPv4LL: prior prior commit for non NetBSD OS's
Roy Marples [Thu, 17 Jan 2019 11:49:52 +0000 (11:49 +0000)] 
IPv4LL: prior prior commit for non NetBSD OS's

6 years agoIPv4LL: Preserve address when carrier drops
Roy Marples [Thu, 17 Jan 2019 11:44:08 +0000 (11:44 +0000)] 
IPv4LL: Preserve address when carrier drops

Apple Conformance testing now requires this.
However, if associated SSID changes on wireless networks,
any remembered address is reset.

6 years agoBSD: Fix UP/DOWN for interfaces which dont' report media changes
Roy Marples [Mon, 14 Jan 2019 12:57:37 +0000 (12:57 +0000)] 
BSD: Fix UP/DOWN for interfaces which dont' report media changes

Carrier UP/DOWN state is handled by media change events on BSD.
When the carrier state changes, it's always to LINK_STATE_DOWN or
LINK_STATE_UP.
If we receive LINK_STATE_UNKNOWN from RTM_IFINFO it means the
interface doesn't change media change events and as such won't
report carrier state changes. In this instance, we can only rely
on IFF_UP being set, which is the same condition dhcpcd needs
for LINK_STATE_UP.

6 years agoFreeBSD: Fix bogus RTM_DELADDR messages from affecting DHCP lease
Roy Marples [Sat, 12 Jan 2019 13:36:01 +0000 (13:36 +0000)] 
FreeBSD: Fix bogus RTM_DELADDR messages from affecting DHCP lease

6 years agoconfigure: --with-udev explicity requires libudev to be present
Roy Marples [Fri, 11 Jan 2019 12:39:33 +0000 (12:39 +0000)] 
configure: --with-udev explicity requires libudev to be present

6 years agoconfigurfe: Remove extra --includedir. It's not hit anyway.
Roy Marples [Fri, 11 Jan 2019 12:30:46 +0000 (12:30 +0000)] 
configurfe: Remove extra --includedir. It's not hit anyway.

6 years agoip6: Install not on link routes with a gateway of the router
Roy Marples [Sun, 6 Jan 2019 10:10:59 +0000 (10:10 +0000)] 
ip6: Install not on link routes with a gateway of the router

This allows a secondary router to broadcast prefixes it controls
without being a default router itself.

6 years agoip6: Implement IPv6 address sharing
Roy Marples [Sat, 5 Jan 2019 11:42:12 +0000 (11:42 +0000)] 
ip6: Implement IPv6 address sharing

This allows the same IPv6 address to exist on more than one
interface. Whenever dhcpcd address an IPv6 address, it will
advertise it along with the hardware address of the preferred
interface.

This is heavliy reliant on the kernel supporting this as it's the
kernel that handle the Duplicate Address Detection.
In a nutshell it needs to support RFC 7527 and ignore NA packets
from any hardware address the host owns.

Currently the only known kernel that fully supports this is
NetBSD-8.99.27

6 years agodhcpcd(8): note that --waitip needs = when specifying a protocol
Roy Marples [Wed, 2 Jan 2019 16:33:29 +0000 (16:33 +0000)] 
dhcpcd(8): note that --waitip needs = when specifying a protocol

6 years agoWelcome to 2019!
Roy Marples [Tue, 1 Jan 2019 17:16:18 +0000 (17:16 +0000)] 
Welcome to 2019!

6 years agodhcp: Don't ARP announce bound addresses when testing
Roy Marples [Sun, 30 Dec 2018 19:25:05 +0000 (19:25 +0000)] 
dhcp: Don't ARP announce bound addresses when testing

6 years agoBSD: SIOCSRTRFLUSH_IN6 and SIOCSPFXFLUSH_IN6 require in6_ifreq
Roy Marples [Sun, 16 Dec 2018 08:56:06 +0000 (08:56 +0000)] 
BSD: SIOCSRTRFLUSH_IN6 and SIOCSPFXFLUSH_IN6 require in6_ifreq

and not a character array of the interface name.
This only worked previously because the first member of in6_ifreq
is the interface name.

6 years agoRemove .arcconfig as I've abandoned Phabricator.
Roy Marples [Sat, 1 Dec 2018 18:13:31 +0000 (18:13 +0000)] 
Remove .arcconfig as I've abandoned Phabricator.

6 years agoFix prior logic.Doh!
Roy Marples [Fri, 30 Nov 2018 03:58:28 +0000 (03:58 +0000)] 
Fix prior logic.Doh!

6 years agoBSD: Always set RTA_IFP for routes
Roy Marples [Fri, 30 Nov 2018 03:50:23 +0000 (03:50 +0000)] 
BSD: Always set RTA_IFP for routes

Unless we are OpenBSD adding INET6 routes without a gateway.
this should work, but doesn't.
No biggie as no OS currently supports sharing IPv6 addresses on
more than one interface.

6 years agoFreeBSD: Mark INET6 addresses as tentative when adding them
Roy Marples [Fri, 30 Nov 2018 03:38:06 +0000 (03:38 +0000)] 
FreeBSD: Mark INET6 addresses as tentative when adding them

This is kind of odd really because the kernel should do this if
we're sending DaD probes.

6 years agoBSD: don't listen to own route messages
Roy Marples [Fri, 30 Nov 2018 03:27:57 +0000 (03:27 +0000)] 
BSD: don't listen to own route messages

This makes the code a lot simpler and reduces the changes
of overflowing the route socket.

6 years agoRemove supurfluous an.
Masanobu SAITOH [Thu, 8 Nov 2018 06:52:59 +0000 (06:52 +0000)] 
Remove supurfluous an.

6 years agoBSD: Use SO_RERROR on the route(4) socket.
Roy Marples [Wed, 7 Nov 2018 18:57:20 +0000 (18:57 +0000)] 
BSD: Use SO_RERROR on the route(4) socket.

This allows NetBSD to receive ENOBUFS again so it can detect
route(4) overflow.
This was recently defaulted to off globably, but is now settable
per socket.

6 years agoLinux: Use NETLINK_BROADCAST_ERROR
Roy Marples [Sun, 4 Nov 2018 13:01:15 +0000 (13:01 +0000)] 
Linux: Use NETLINK_BROADCAST_ERROR

This should allow dhcpcd to detect overflow on netlink, just
like NetBSD and OpenBSD.

6 years agohooks: shell [ ] only supports 4 parameters
Roy Marples [Tue, 30 Oct 2018 05:52:48 +0000 (05:52 +0000)] 
hooks: shell [ ] only supports 4 parameters

Using a fifth paramter or more is unspecified.

6 years agoOpenBSD: Allow dhcpcd to work alongside slaacd
Roy Marples [Wed, 26 Sep 2018 12:27:37 +0000 (13:27 +0100)] 
OpenBSD: Allow dhcpcd to work alongside slaacd

Not that you should be doing this, but it appears some people want
two daemons handling the RA.

6 years agoduid: test that we actually have a uuid on Linux
Roy Marples [Wed, 19 Sep 2018 08:07:58 +0000 (09:07 +0100)] 
duid: test that we actually have a uuid on Linux

6 years agoMerge pull request #5 from dhgutteridge/master
Roy Marples [Mon, 17 Sep 2018 19:08:20 +0000 (20:08 +0100)] 
Merge pull request #5 from dhgutteridge/master

Some more man page tweaks

6 years agodhcpcd.conf.5.in: One more minor grammar fix
David H. Gutteridge [Mon, 17 Sep 2018 16:17:27 +0000 (12:17 -0400)] 
dhcpcd.conf.5.in: One more minor grammar fix

Add a definite article to a phrase I'd revised.

6 years agodhcpcd.conf.5.in: A couple more minor tweaks
David H. Gutteridge [Sat, 15 Sep 2018 23:59:24 +0000 (19:59 -0400)] 
dhcpcd.conf.5.in: A couple more minor tweaks

Make all articles preceding 'RFC' consistent, and fix a formatting issue I inadvertently introduced.

6 years agodhcpcd.conf.5.in: Fix various typos, add more markup, etc.
David H. Gutteridge [Sat, 15 Sep 2018 23:49:00 +0000 (19:49 -0400)] 
dhcpcd.conf.5.in: Fix various typos, add more markup, etc.

Fix some minor spelling and grammar issues, add more markup in places to help contextualize terms, add a touch more detail to 'Defining new options', make acronym formatting more consistent, etc.

6 years agodhcpcd.8.in: More minor style tweaks
David H. Gutteridge [Sat, 15 Sep 2018 23:41:27 +0000 (19:41 -0400)] 
dhcpcd.8.in: More minor style tweaks

Use a consistent format for RFC references: a space between RFC and the ID number, as this is the most commonly-used format in man pages, and indeed in the RFCs themselves. Also, a few minor grammatical fixes.

6 years agoFix prior - always return if lease is invalid.
Roy Marples [Mon, 10 Sep 2018 13:57:49 +0000 (14:57 +0100)] 
Fix prior - always return if lease is invalid.

6 years agodhcp6: always move to the DISCOVER phase if the offered lease is invalid
Roy Marples [Mon, 10 Sep 2018 11:02:55 +0000 (12:02 +0100)] 
dhcp6: always move to the DISCOVER phase if the offered lease is invalid

6 years agodhcp6: only send dhcp6 to an interface if it has a send object.
Roy Marples [Fri, 7 Sep 2018 13:01:36 +0000 (14:01 +0100)] 
dhcp6: only send dhcp6 to an interface if it has a send object.

6 years agodhcp6: write RECONFIGURE6 here to match other places
Roy Marples [Fri, 7 Sep 2018 12:56:20 +0000 (13:56 +0100)] 
dhcp6: write RECONFIGURE6 here to match other places

6 years agodhcp6: don't log an error here.
Roy Marples [Fri, 7 Sep 2018 12:38:07 +0000 (13:38 +0100)] 
dhcp6: don't log an error here.

6 years agoMerge pull request #4 from dhgutteridge/master
Roy Marples [Tue, 4 Sep 2018 13:08:19 +0000 (14:08 +0100)] 
Merge pull request #4 from dhgutteridge/master

dhcpcd.8.in: Fix typos and minor grammatical issues

6 years agodhcpcd.8.in: Fix typos and minor grammatical issues
David H. Gutteridge [Mon, 3 Sep 2018 16:39:32 +0000 (12:39 -0400)] 
dhcpcd.8.in: Fix typos and minor grammatical issues

6 years agoMerge pull request #3 from sevan/usage
Roy Marples [Mon, 27 Aug 2018 17:20:25 +0000 (18:20 +0100)] 
Merge pull request #3 from sevan/usage

Update usage() to match documented flags

6 years agoUpdate usage() to match documented flags
Sevan Janiyan [Mon, 27 Aug 2018 13:37:18 +0000 (14:37 +0100)] 
Update usage() to match documented flags

6 years agoRelease dhcpcd-7.0.8 v7.0.8
Roy Marples [Mon, 20 Aug 2018 10:37:17 +0000 (11:37 +0100)] 
Release dhcpcd-7.0.8

6 years agoRemove redundant assignment
Roy Marples [Sun, 19 Aug 2018 20:07:09 +0000 (21:07 +0100)] 
Remove redundant assignment

6 years agoConsistency
Roy Marples [Sun, 19 Aug 2018 20:05:39 +0000 (21:05 +0100)] 
Consistency

6 years agoBSD: Silence debug when address no longer exists when getting flags
Roy Marples [Fri, 17 Aug 2018 16:38:28 +0000 (17:38 +0100)] 
BSD: Silence debug when address no longer exists when getting flags

6 years agoWorkaround NetBSD-7 sending an invalid bcast address in RTM_NEWADDR
Roy Marples [Fri, 17 Aug 2018 16:29:30 +0000 (17:29 +0100)] 
Workaround NetBSD-7 sending an invalid bcast address in RTM_NEWADDR

6 years agoNetBSD-7 has an incomplete IP_PKTINFO implementation.
Roy Marples [Fri, 17 Aug 2018 16:21:40 +0000 (17:21 +0100)] 
NetBSD-7 has an incomplete IP_PKTINFO implementation.

It only works for receiving data, not sending it.
We only need it to send, so pretend it doesn't exist.

6 years agoipv4: add broadcast address to RTM_NEWADDR debug
Roy Marples [Fri, 17 Aug 2018 16:18:56 +0000 (17:18 +0100)] 
ipv4: add broadcast address to RTM_NEWADDR debug

7 years agoFix a promotion caught with gcc -fsanitize=undefined.
Kamil Rytarowski [Wed, 25 Jul 2018 00:35:52 +0000 (01:35 +0100)] 
Fix a promotion caught with gcc -fsanitize=undefined.

7 years agoRelease dhcpcd-7.0.7 v7.0.7
Roy Marples [Tue, 24 Jul 2018 07:49:00 +0000 (08:49 +0100)] 
Release dhcpcd-7.0.7

7 years agoMake config.h more pretty
Roy Marples [Tue, 24 Jul 2018 07:44:17 +0000 (08:44 +0100)] 
Make config.h more pretty

7 years agoSome systems mark a host route using RTF_HOST and some use an
Roy Marples [Sun, 15 Jul 2018 13:20:16 +0000 (14:20 +0100)] 
Some systems mark a host route using RTF_HOST and some use an
all-ones netmask.

For the former, only test netmask for equality if both routes
lack the RTF_HOST marking.

7 years agolinux: set RTF_HOST correctly when reading kernel routes.
Roy Marples [Mon, 2 Jul 2018 21:36:44 +0000 (22:36 +0100)] 
linux: set RTF_HOST correctly when reading kernel routes.

Linux has no real concept of host routes, but dhcpcd does purely
for describing them.
As such, mark them has host routes if the netmask if all ones.

7 years agolinux: fix adding host routes
Roy Marples [Sun, 1 Jul 2018 19:46:03 +0000 (20:46 +0100)] 
linux: fix adding host routes

7 years agoip6: use vlanid if present in working out stable private addresses
Roy Marples [Sat, 23 Jun 2018 20:06:40 +0000 (21:06 +0100)] 
ip6: use vlanid if present in working out stable private addresses

dhcpcd doesn't allow address sharing currently, so this is a
needed change for vlan users.

7 years agoRelease dhcpcd-7.0.6 v7.0.6
Roy Marples [Thu, 21 Jun 2018 11:35:46 +0000 (12:35 +0100)] 
Release dhcpcd-7.0.6

7 years agoFix my dumb mistake with the compile fixes which caused dhcpcd to
Roy Marples [Fri, 15 Jun 2018 08:10:55 +0000 (09:10 +0100)] 
Fix my dumb mistake with the compile fixes which caused dhcpcd to
ignore carrier loss on IPv4 addresses.

7 years agoduid: Implement RFC 6355
Roy Marples [Tue, 5 Jun 2018 10:36:33 +0000 (11:36 +0100)] 
duid: Implement RFC 6355

If no duid file is present and a system UUID exists, use that for
a DUID-UUID, otherwise proceed as before.

7 years agodhcp: Fix more fallout for builds without IPv4LL v7.0.5b
Roy Marples [Mon, 4 Jun 2018 16:30:16 +0000 (17:30 +0100)] 
dhcp: Fix more fallout for builds without IPv4LL

7 years agobuild: Allow a suffix to be specified on the dist tarball. v7.0.5a
Roy Marples [Mon, 4 Jun 2018 09:25:59 +0000 (10:25 +0100)] 
build: Allow a suffix to be specified on the dist tarball.

7 years agoFix compile without INET6
Roy Marples [Sun, 3 Jun 2018 11:19:15 +0000 (12:19 +0100)] 
Fix compile without INET6

7 years agoRelease dhcpcd-7.0.5 v7.0.5
Roy Marples [Sat, 2 Jun 2018 09:29:29 +0000 (10:29 +0100)] 
Release dhcpcd-7.0.5

7 years agoip6: if forked from ia callback, don't run ia handlers
Roy Marples [Sat, 2 Jun 2018 09:27:45 +0000 (10:27 +0100)] 
ip6: if forked from ia callback, don't run ia handlers

It's pointless and resolves an issue where the handler would try
and listen to an address when not in master mode, but it's already
listened to in the child.

7 years agodhcp6: Stop non delegated addresses being delegated
Roy Marples [Thu, 10 May 2018 17:51:56 +0000 (18:51 +0100)] 
dhcp6: Stop non delegated addresses being delegated

This was caused by allowing matching iaids and should now be resolved.

7 years agodhcp6: fix a memory issue with prior patch
Roy Marples [Tue, 8 May 2018 11:39:26 +0000 (12:39 +0100)] 
dhcp6: fix a memory issue with prior patch

Don't allocate memory for T1 or T2 timers when requesting
IA_TA addresses.

7 years agodhcp6: match IA type with request
Roy Marples [Tue, 8 May 2018 11:27:42 +0000 (12:27 +0100)] 
dhcp6: match IA type with request

So we don't send IA_NA, IA_TA and IA_PD addresses in the
IA_NA request if they all share the same IAID.

While here, fix a bug where IA_TA addresses would append
the DHCP6 unknown option 0 by mistakenly trying to put T1
and T2 timers in where there should be none.

7 years agodhcp6: IAID is now unique for IA type
Roy Marples [Mon, 7 May 2018 20:20:26 +0000 (21:20 +0100)] 
dhcp6: IAID is now unique for IA type

RFC3315 is a bit ambigious about this. At the start it says that
IAID is supposed to be unique across the client, but futher down
it starts to mention that the IAID number space is unqiuie to the
IA type.

RFC3315bis clarifies it's unique for the client and IA type, so
you can now have ia_na 1 and ia_pd 1.

7 years agodhcp: Clarify range checks in valid UDP packets
Roy Marples [Mon, 7 May 2018 14:01:46 +0000 (15:01 +0100)] 
dhcp: Clarify range checks in valid UDP packets

7 years agodhcp: checksum failure could be IP header too
Roy Marples [Sun, 6 May 2018 15:50:35 +0000 (16:50 +0100)] 
dhcp: checksum failure could be IP header too

7 years agobpf: add braces to clarify intent of sizeof
Roy Marples [Sun, 6 May 2018 15:28:33 +0000 (16:28 +0100)] 
bpf: add braces to clarify intent of sizeof

7 years agoarp: clarify that we check ar_hln in the BPF filter
Roy Marples [Sun, 6 May 2018 15:26:11 +0000 (16:26 +0100)] 
arp: clarify that we check ar_hln in the BPF filter

While here, re-arrange it a little to match the structure.

7 years agobpf: Clarify ip_hl check.
Roy Marples [Sun, 6 May 2018 09:11:44 +0000 (10:11 +0100)] 
bpf: Clarify ip_hl check.

7 years agobpf: BIOCIMMEDIATE argument is an unsigned int.
Roy Marples [Fri, 4 May 2018 14:17:45 +0000 (15:17 +0100)] 
bpf: BIOCIMMEDIATE argument is an unsigned int.

7 years agoDocument fqdn none.
Roy Marples [Thu, 3 May 2018 21:29:05 +0000 (22:29 +0100)] 
Document fqdn none.

7 years agoRelease dhcpcd-7.0.4 v7.0.4
Roy Marples [Wed, 2 May 2018 21:49:11 +0000 (22:49 +0100)] 
Release dhcpcd-7.0.4

7 years agodhcp6: Softwire Address and Port-Mapped Clients, RFC7598
Roy Marples [Wed, 2 May 2018 21:28:31 +0000 (22:28 +0100)] 
dhcp6: Softwire Address and Port-Mapped Clients, RFC7598

Add support for these options.
Untested, should work aside from the documented issue, patches welcome.

7 years agoipv6nd: use bools here
Roy Marples [Wed, 2 May 2018 21:03:25 +0000 (22:03 +0100)] 
ipv6nd: use bools here

7 years agoipv6nd: warn if router lifetime is set to zero
Roy Marples [Wed, 2 May 2018 21:01:18 +0000 (22:01 +0100)] 
ipv6nd: warn if router lifetime is set to zero

7 years agoDon't abort if recv returns an error.
Roy Marples [Tue, 1 May 2018 18:55:02 +0000 (19:55 +0100)] 
Don't abort if recv returns an error.

7 years agoauth: allow different tokens for send and receive
Roy Marples [Sun, 29 Apr 2018 20:38:58 +0000 (21:38 +0100)] 
auth: allow different tokens for send and receive

It was silly of me to assume that the same key would be used for
both sending and receiving. Because token protocol is not digested,
replace the digest argument with 0x123/0x456 where 0x123 is the
sending key and 0x456 is the receiving key.
Receiving key defaults to sending key, sending key defaults to zero.
This should allow existing configurations to work as is.

7 years agoauth: allow zero value replay detection data
Roy Marples [Sun, 29 Apr 2018 20:28:15 +0000 (21:28 +0100)] 
auth: allow zero value replay detection data

It seems one ISP doesn't use Replay Data and always sets it to zero.
See the comment in the commit as to why this is technically legal,
even if it goes against the intent of the RFC.

7 years agodhcpcd(8): document some servers might filter based on ClientID
Roy Marples [Sun, 29 Apr 2018 08:31:18 +0000 (09:31 +0100)] 
dhcpcd(8): document some servers might filter based on ClientID

Note that the DUID file might need to be edited as well.

7 years agoRFC 3315 21.4.4.1 says that SOLICT and DELAYED authentication
Roy Marples [Thu, 26 Apr 2018 18:35:43 +0000 (19:35 +0100)] 
RFC 3315 21.4.4.1 says that SOLICT and DELAYED authentication
should set RDM and replay data to zero.
draft-ietf-dhc-dhcpv6-clarify-auth-01 (expired) suggests that
INFORMATION REQ should be zero in this case as well.

As it's coming from a very similar angle, I agree.

7 years agologerr -> logerrx
Roy Marples [Thu, 19 Apr 2018 20:44:41 +0000 (21:44 +0100)] 
logerr -> logerrx

7 years agorouting: Fix case when cloning route changes but needs to be replaced.
Roy Marples [Thu, 19 Apr 2018 12:06:07 +0000 (13:06 +0100)] 
routing: Fix case when cloning route changes but needs to be replaced.