]> git.ipfire.org Git - thirdparty/openssl.git/log
thirdparty/openssl.git
41 hours agofuzz/provider.c: Add check for OPENSSL_malloc() to avoid potential NULL pointer deref... master
Jiasheng Jiang [Thu, 8 Jan 2026 03:01:27 +0000 (03:01 +0000)] 
fuzz/provider.c: Add check for OPENSSL_malloc() to avoid potential NULL pointer dereference

Add check for the return value of OPENSSL_malloc() to avoid potential NULL pointer dereference.

Fixes: f3b988d ("Add provider fuzzer")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27868)

2 days agoDocument the EVP_PKEY_asn1* removed functions
Matt Caswell [Mon, 15 Dec 2025 17:25:38 +0000 (17:25 +0000)] 
Document the EVP_PKEY_asn1* removed functions

For every function that was removed we add an entry to
ossl-removed-api.pod

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29405)

2 days agoUpdate the documentation to remove referenceds to EVP_PKEY_ASN1_METHOD
Matt Caswell [Mon, 15 Dec 2025 17:12:46 +0000 (17:12 +0000)] 
Update the documentation to remove referenceds to EVP_PKEY_ASN1_METHOD

Now that EVP_PKEY_ASN1_METHODs have been removed from the public API we
need to update the documentation accordingly. They still exist internally
and so some references are still appropriate in the internal documetnation.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29405)

2 days agoRemove the ability to create a custom EVP_PKEY_ASN1_METHOD
Matt Caswell [Mon, 15 Dec 2025 17:02:36 +0000 (17:02 +0000)] 
Remove the ability to create a custom EVP_PKEY_ASN1_METHOD

Now that the ability to register a custom EVP_PKEY_ASN1_METHOD has
been removed in an earlier commit, we can now remove the functions that
are used to create a custom EVP_PKEY_ASN1_METHOD.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29405)

2 days agoRemove the ability to query the internal EVP_PKEY_ASN1_METHODs
Matt Caswell [Mon, 15 Dec 2025 16:18:13 +0000 (16:18 +0000)] 
Remove the ability to query the internal EVP_PKEY_ASN1_METHODs

Previously there were a few functions where you could obtain a handle
on registered EVP_PKEY_ASN1_METHODs and query information about them.
We remove the capability.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29405)

2 days agoRemove EVP_PKEY_asn1_add0()
Matt Caswell [Mon, 15 Dec 2025 15:31:08 +0000 (15:31 +0000)] 
Remove EVP_PKEY_asn1_add0()

We remove the ability to add application defined EVP_PKEY_ASN1_METHODs
via the `EVP_PKEY_asn1_add0()` function. We also remove the related function
`EVP_PKEY_asn1_add_alias()`.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29405)

2 days agoAdd a test to ensure that instantiation of drbgs work
Neil Horman [Wed, 7 Jan 2026 14:34:51 +0000 (09:34 -0500)] 
Add a test to ensure that instantiation of drbgs work

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29560)

2 days agofetch macctx while fetching digest when creating HMAC-DRBG
Neil Horman [Tue, 6 Jan 2026 17:08:40 +0000 (12:08 -0500)] 
fetch macctx while fetching digest when creating HMAC-DRBG

Somewhere in our conversion from .c files to .inc files for our rand
providers, we created code in drbg_hmac_set_ctx_params_locked to fetch
our digest and hmac when creating the rand instance.  However, the
function drbg_fetch_algs_from_prov only fetched our digest for this rand
type, not the hmac, and returned 1 while doing so, indicating success.
This is problematic because it means that we never wind up fetching an
HMAC for this rand type.  As a result we never compute the strength of
the DRBG and so any attempt to seed it fails.

Ensure that, if we load a digest for this DRBG, we also fetch an HMAC,
and fail if we can't do so, so the HMAC-DRBG is useful.

Fixes openssl/private#853

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29560)

2 days agoClean up some unnecessary inclusions
Matt Caswell [Wed, 7 Jan 2026 11:54:05 +0000 (11:54 +0000)] 
Clean up some unnecessary inclusions

After the deadcode removal there were varios include files being used
that are no longer necessary. We remove them.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29460)

2 days agoRemove some legacy fields from the EVP_MD_CTX structure
Matt Caswell [Fri, 19 Dec 2025 13:42:23 +0000 (13:42 +0000)] 
Remove some legacy fields from the EVP_MD_CTX structure

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29460)

2 days agoCleanup the EVP_MD structure
Matt Caswell [Fri, 19 Dec 2025 11:49:25 +0000 (11:49 +0000)] 
Cleanup the EVP_MD structure

Remove fields that are no longer needed.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29460)

2 days agoRemove legacy method deadcode for EVP_MD implementations
Matt Caswell [Fri, 19 Dec 2025 11:32:23 +0000 (11:32 +0000)] 
Remove legacy method deadcode for EVP_MD implementations

Remove the legacy EVP_MD implementation functions. These are no longer
used due to providers. This code is now unreachable due to the removal of
the functions related to custom EVP_MD methods.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29460)

3 days agoMinGW does not know __int64, we can rely on int64_t provided by <stdint.h>
Alexandr Nedvedicky [Tue, 6 Jan 2026 07:10:17 +0000 (08:10 +0100)] 
MinGW does not know __int64, we can rely on int64_t provided by <stdint.h>

<stdint.H> is part of libraries which come with C99 compiler.

Fixes: #29548
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29553)

3 days agoFix util/mkinstallvars.pl to treat LIBDIR and libdir correctly
Richard Levitte [Sat, 3 Jan 2026 12:19:49 +0000 (13:19 +0100)] 
Fix util/mkinstallvars.pl to treat LIBDIR and libdir correctly

OpenSSL's build file (Makefile) handles library directories via two
variables, 'LIBDIR' and 'libdir', where the former is empty when the
path given through ./Configure's '--libdir' is absolute.

This was forgotten when treating the resulting values in,
util/mkinstallvars.pl, which got libdir in exporters/libcrypto.pc
to not be quite right if .Configure was called with a '--libdir'
with an absolute path.

The fix turns out to be quite easy.

Resolves: https://github.com/openssl/openssl/issues/28779

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29540)

3 days agoFix a possible crash in ASN1_generate_nconf
Bernd Edlinger [Mon, 5 Jan 2026 13:27:15 +0000 (14:27 +0100)] 
Fix a possible crash in ASN1_generate_nconf

Due to an out of memory error, the i2d_ASN1_TYPE might fail
and cause a segfault.
This adds a missing check for NULL pointer and a test case
that exercises IMPLICIT and EXPLICT tagging in generate_v3,
since there was no test coverage at all for this code section.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 10:13:43 2026
(Merged from https://github.com/openssl/openssl/pull/29545)

3 days agoctx_simd and ctx_ref must be freed in error path
Alexandr Nedvedicky [Mon, 5 Jan 2026 12:18:46 +0000 (13:18 +0100)] 
ctx_simd and ctx_ref must be freed in error path

CID 1679597
CID 1679599

Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
MergeDate: Thu Jan  8 10:10:49 2026
(Merged from https://github.com/openssl/openssl/pull/29543)

3 days agoCleanup in cryptlib.h.
Frederik Wedel-Heinen [Thu, 25 Dec 2025 07:46:24 +0000 (08:46 +0100)] 
Cleanup in cryptlib.h.

Remove unused ossl_crypto_ex_data_get_ossl_lib_ctx() and memdbg_lock.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
MergeDate: Thu Jan  8 10:08:08 2026
(Merged from https://github.com/openssl/openssl/pull/29500)

3 days agoCorrectly handle the cases where SSL_dup fails.
Frederik Wedel-Heinen [Mon, 22 Dec 2025 14:36:24 +0000 (15:36 +0100)] 
Correctly handle the cases where SSL_dup fails.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
MergeDate: Thu Jan  8 10:06:48 2026
(Merged from https://github.com/openssl/openssl/pull/29485)

3 days agoRemove unnecessary argc assign
JohnnySavages [Fri, 19 Dec 2025 04:50:54 +0000 (23:50 -0500)] 
Remove unnecessary argc assign

Found by Linux Verification Center (linuxtesting.org) with SVACE.

CLA:trivial

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
MergeDate: Thu Jan  8 10:03:55 2026
(Merged from https://github.com/openssl/openssl/pull/29457)

3 days agoX509_VERIFY_PARAM_set_flags.pod: fix doc of NULL param to X509_VERIFY_PARAM_set1_emai...
Dr. David von Oheimb [Mon, 21 Apr 2025 10:04:41 +0000 (12:04 +0200)] 
X509_VERIFY_PARAM_set_flags.pod: fix doc of NULL param to X509_VERIFY_PARAM_set1_email() and X509_VERIFY_PARAM_set1{,_ip}()

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 09:56:15 2026
(Merged from https://github.com/openssl/openssl/pull/29150)

3 days agoX509_VERIFY_PARAM_set_flags.pod: remove heavily outdated texts on X509_V_FLAG_NO_ALT_...
Dr. David von Oheimb [Fri, 11 Apr 2025 18:01:38 +0000 (20:01 +0200)] 
X509_VERIFY_PARAM_set_flags.pod: remove heavily outdated texts on X509_V_FLAG_NO_ALT_CHAINS; other small fixes

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 09:56:14 2026
(Merged from https://github.com/openssl/openssl/pull/29150)

3 days agoX509_VERIFY_PARAM_set_flags.pod: add hint on joint use of X509_VERIFY_PARAM_set1_host...
Dr. David von Oheimb [Fri, 11 Apr 2025 18:00:21 +0000 (20:00 +0200)] 
X509_VERIFY_PARAM_set_flags.pod: add hint on joint use of X509_VERIFY_PARAM_set1_host() and SSL_set_tlsext_host_name()

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 09:56:12 2026
(Merged from https://github.com/openssl/openssl/pull/29150)

3 days agoapps: ocsp.c: fix null dereference in ocsp_response
Anton Moryakov [Wed, 29 Oct 2025 18:21:39 +0000 (21:21 +0300)] 
apps: ocsp.c: fix null dereference in ocsp_response

Report of the static analyzer:
Function 'OCSP_cert_to_id' may return NULL on allocation failure,
but its return value is dereferenced in 'OCSP_id_issuer_cmp'
without prior NULL check at ocsp.c:1088. This can lead to a null
pointer dereference and cause a segmentation fault, resulting
in a denial-of-service (DoS) condition. Although such failures
are rare, an attacker could potentially trigger them under memory
pressure. All other calls to 'OCSP_cert_to_id' in the codebase
(e.g., add_ocsp_cert, add_ocsp_serial) properly check for NULL,
making this instance a clear omission.

Correct explained:
Added a NULL check after calling OCSP_cert_to_id() when creating
'ca_id' inside the issuer lookup loop. If the allocation fails, the
function now safely returns an internal error response instead of
risking a crash. This change aligns the code with existing
error-handling patterns in the same file and improves robustness
against resource exhaustion attacks.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 09:01:09 2026
(Merged from https://github.com/openssl/openssl/pull/29033)

3 days agoRemove unused Data::Dumper from cmake exporter
Andreas Aigner [Wed, 12 Jun 2024 07:27:36 +0000 (09:27 +0200)] 
Remove unused Data::Dumper from cmake exporter

* Remove additional dependency for old build boxes (in particular centos)

CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
MergeDate: Thu Jan  8 08:55:10 2026
(Merged from https://github.com/openssl/openssl/pull/24632)

(cherry picked from commit df0a0fd613cb36a252ea20076d86408a5da2bd43)

4 days agoapps/cmp.c: fix handling of passwords when loading pubkey from possibyl password...
Dr. David von Oheimb [Mon, 14 Apr 2025 18:57:48 +0000 (20:57 +0200)] 
apps/cmp.c: fix handling of passwords when loading pubkey from possibyl password-protected container

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/28477)

4 days agoapps/cmp.c: refactor load_key_pwd() and load_cert_pwd() params for clarity w.r.t...
Dr. David von Oheimb [Mon, 14 Apr 2025 18:58:57 +0000 (20:58 +0200)] 
apps/cmp.c: refactor load_key_pwd() and load_cert_pwd() params for clarity w.r.t. password source vs. actual password

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/28477)

4 days agoapps/lib/apps.c: fix load_certs_multifile() and load_certstore() w.r.t. password...
Dr. David von Oheimb [Mon, 14 Apr 2025 19:00:35 +0000 (21:00 +0200)] 
apps/lib/apps.c: fix load_certs_multifile() and load_certstore() w.r.t. password source vs. actual password

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/28477)

4 days agoapps/lib/apps.c load_key_certs_crls() refactor uidata use and tweak error message
Dr. David von Oheimb [Mon, 14 Apr 2025 19:01:25 +0000 (21:01 +0200)] 
apps/lib/apps.c load_key_certs_crls() refactor uidata use and tweak error message

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/28477)

5 days agoAdd new test test_base64_simdutf to .gitignore file
Neil Horman [Mon, 5 Jan 2026 18:26:53 +0000 (13:26 -0500)] 
Add new test test_base64_simdutf to .gitignore file

the test_base64_simdutf test is commonly built but not ignored by our
.gitignore file, fix that up

Fixes #29529

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29551)

5 days agoprevent large latency in base64_simdutf test
Neil Horman [Sun, 4 Jan 2026 22:42:33 +0000 (17:42 -0500)] 
prevent large latency in base64_simdutf test

The base64_simdutf test has a printf statement inside a double for loop
that causes a huge amount of latency when run under our perl scripts.
Average run time on my system is about 1min 58 seconds.

We shouldn't be using a printf statement there anyway (likely TEST_info
instead), but we don't need that either, so just remove the printf
entirely.  This decreases the run time to around a second to complete.

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29542)

5 days agotest: use runtime FIPS detection instead of compile-time check
Anatolii Ohorodnyk [Wed, 31 Dec 2025 20:40:11 +0000 (20:40 +0000)] 
test: use runtime FIPS detection instead of compile-time check

Replace #ifdef FIPS_MODULE with OSSL_PROVIDER_available() runtime check
in ecdsatest.c. The compile-time check is not meaningful for test cases
as the test binary may be compiled without FIPS_MODULE but run with the
FIPS provider loaded.

Fixes #28255

CLA: trivial

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29527)

5 days agoapps.c: fix next_item() to correctly handle space(s) before comma separators
Dr. David von Oheimb [Mon, 8 Sep 2025 06:23:58 +0000 (08:23 +0200)] 
apps.c: fix next_item() to correctly handle space(s) before comma separators

* Modified the parsing logic to handle space-followed-by-comma patterns
* Updated the separator skipping logic to process at most one comma while allowing multiple spaces
* Added a test case with a mixed DNS and IP SAN entry that includes the problematic spacing pattern

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28471)

5 days agoFix a memory leak in sctp code
Bernd Edlinger [Sun, 4 Jan 2026 18:52:15 +0000 (19:52 +0100)] 
Fix a memory leak in sctp code

There is a memory leak of the addrinfo struct when
`./openssl s_server -dtls -sctp -accept 127.0.0.1:4433`
is used, but `sysctl -w net.sctp.auth_enable=1`
is not done before.
Additionally this fixes an oversight, when
`./openssl s_client -dtls -sctp -connect localhost:4433`
is used to connect to above server.
The first connect attempt is to IPv6 ::1, which might fail,
but the second attempt might still succeed, so continue to
try all addesses even when the SCTP socket fails for one of them.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29541)

6 days agoUI_new.pod: fix doc of UI_add_user_data()
Dr. David von Oheimb [Mon, 14 Apr 2025 19:08:28 +0000 (21:08 +0200)] 
UI_new.pod: fix doc of UI_add_user_data()

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28475)

6 days agoFix possible null pointer dereference.
Frederik Wedel-Heinen [Fri, 2 Jan 2026 17:36:39 +0000 (18:36 +0100)] 
Fix possible null pointer dereference.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/29537)

7 days agoFix dead code/constant expression in simdutf test
Neil Horman [Wed, 31 Dec 2025 14:19:42 +0000 (09:19 -0500)] 
Fix dead code/constant expression in simdutf test

Coverity issues:
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677828
and
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677827

caught some dead code in the simdutf test.

The total variable is defined as an int, which is tested against <=
INT_MAX, and > INT_MAX, which will always be true, and false
respectively, making the <= test needless, and the condition the latter
bounds dead code

Clean that up.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

7 days agoFix overflow in EVP_EncodeFinal
Neil Horman [Tue, 30 Dec 2025 19:52:08 +0000 (14:52 -0500)] 
Fix overflow in EVP_EncodeFinal

https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677829

With recent changes, evp_encodeblock_int may return a negative value,
which EVP_EncodeFinal does not anticipate.  As the latter sets out[ret]
to "\0" where ret is the return value of evp_encodeblock_int, we may
underflow the array index and access invalid memory locations.

Only update the output buffer if the return value is greater or equal to
zero.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

7 days agoFix constant bounds checking in evp_encodeblock_int
Neil Horman [Tue, 30 Dec 2025 19:11:56 +0000 (14:11 -0500)] 
Fix constant bounds checking in evp_encodeblock_int

https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677830

Reports that several locations in the above function bound for loops
with a check for
ret <= INT_MAX

Given that ret is defined as an int, it can never be larger than
INT_MAX, and so is always true.

We can just remove the check for this variable.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

7 days agoFix more dead code in b64_write
Neil Horman [Tue, 30 Dec 2025 18:52:38 +0000 (13:52 -0500)] 
Fix more dead code in b64_write

https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677831

reports more dead code in b64_write

ret is incremented by inl in b64_write prior to being tested for zero.
Since inl is previously tested for being <= 0, and returns if it is, ret
must be at least 1 during the test, making the trinary test dead code.

Just return -1 here.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

7 days agocheck for null returns in test_base64_simdutf.c
Neil Horman [Tue, 30 Dec 2025 17:19:05 +0000 (12:19 -0500)] 
check for null returns in test_base64_simdutf.c

We derferences two pointers in this code which we fail to check for null
first.  reported by:

https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677832

Just move the null check a bit higher

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

7 days agoRemove dead code in b64_write
Neil Horman [Tue, 30 Dec 2025 16:39:41 +0000 (11:39 -0500)] 
Remove dead code in b64_write

recent updates triggered this coverity issues:
https://scan5.scan.coverity.com/#/project-view/60762/10222?selectedIssue=1677834

Because ret is initalized to zero, and checked prior to any further
update, the first return statement in this change is unreachable

Further the return ret == 0 ? i : ret statement makes teh setting of
buf_len and buf_off unreachable.

Remove all of this unreachable code

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29525)

8 days agoRemove the ASN1_STRING_FLAG_X509_TIME flag
Bob Beck [Fri, 21 Nov 2025 00:06:11 +0000 (17:06 -0700)] 
Remove the ASN1_STRING_FLAG_X509_TIME flag

It's only use was to do some somewhat confused cruftery
inside of ossl_asn1_time_to_tm as a special case to
implement ASN1_TIME_set_string_X509.

As it turns out, you don't need the cruftery of a special
case inside of ossl_asn1_time_to_tm to implement this
function, so the flag is completely unnecessary.

This removes flag, and simplifies this to work without it.

It removes the cruft only from ossl_asn1_time_to_tm,
minimally. This function really needs some cleanup and
makes my eyes bleed but I am resisting the temptation
to do that with this PR and making this a the minimal
change needed for review. I will clean up that function
in a follow on pr.

As tests on the behaviour of ASN1_TIME_set_string_X509
were added with it, Beyonce dances happily for me and I
only need to pass the existing tests, not write as bunch
of new ones.. .

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29187)

11 days agoFix register save/restore issue in ppc
Neil Horman [Wed, 31 Dec 2025 21:38:21 +0000 (16:38 -0500)] 
Fix register save/restore issue in ppc

Recently, the addition of some vector register save restore logic from:
https://github.com/openssl/openssl/pull/28990

Triggered an issue in our quic_multistream_test, notably causing a
connection shutdown with error code 1, rather than successful
completion.

The problem has been root caused to an error in how the ppc aes code
saves and restores vector registers.

The aes gcm code uses VSR instructions (vsldoi, etc), to maniuplate
vector registers, which only operate on the upper half of the vector
register file (VS32-63), and operands are implicitly offset to do this.
(i.e. <instr> v31 actually operates on register vs63).

However, the SAVE/RESTORE macros which save and restore those values use
stxv/lxv instructions to do the save and restore, which are VSX
instructions that have access to the full vector register file, and so
by restoring V1, rather than V33, etc, we actuall restore values to the
wrong registers, causing various issues (most notably the above
misconfiguration of the quic SSL shutdown event, which sets the error
code erroneously to 1 instead of the expected 0 value).

Fix it by offsetting the SAVE_REGS and RESTORE_REGS macros to reference
the proper registers when doing save and restore.

Fixes #29516

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29528)

11 days agorun-checker-daily.yml: heartbeats cannot be enabled anymore
Tomas Mraz [Tue, 30 Dec 2025 09:49:46 +0000 (10:49 +0100)] 
run-checker-daily.yml: heartbeats cannot be enabled anymore

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29517)

11 days agobss_acpt.c: Free strings returned from previous BIO_ADDR_hostname_string() calls
609bob [Fri, 19 Dec 2025 02:27:06 +0000 (10:27 +0800)] 
bss_acpt.c: Free strings returned from previous BIO_ADDR_hostname_string() calls

CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29452)

11 days agoSM4-CBC performance improvement on RISC-V
zhoulu [Fri, 19 Dec 2025 02:08:02 +0000 (10:08 +0800)] 
SM4-CBC performance improvement on RISC-V

Modify the IV update method to further improve the performance of
SM4-CBC encryption on the RISC-V architecture.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29451)

11 days agoSM3: Performance optimized with RISC-V Vector Crypto
xxcui [Sat, 29 Nov 2025 01:56:10 +0000 (09:56 +0800)] 
SM3: Performance optimized with RISC-V Vector Crypto

RISC-V Cryptographic Vector Extension provides ZVK instructions which
can be used to accelerate SM3 computing.

By calculating SHA512 performance on C930 FPGA, it is proven that sm3
speed is improved from 120695K to 323844K.

Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29264)

11 days agoAdd explicit error queue instructions in d2i_X509(3) and SSL_get_error(3)
Richard Levitte [Thu, 14 Aug 2025 12:44:40 +0000 (14:44 +0200)] 
Add explicit error queue instructions in d2i_X509(3) and SSL_get_error(3)

Co-authored-by: Tomáš Mráz <tm@t8m.info>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28264)

11 days agoFix typo in hex_prin() and make it static
Frederik Wedel-Heinen [Tue, 23 Dec 2025 17:53:50 +0000 (18:53 +0100)] 
Fix typo in hex_prin() and make it static

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/29493)

12 days agoThis PR performs further optimization based on the already merged "Implement Montgome...
fengpengbo [Fri, 19 Dec 2025 03:00:59 +0000 (11:00 +0800)] 
This PR performs further optimization based on the already merged "Implement Montgomery multiplication assembly optimization for RV64GC" (#28012).
The key improvements include:code formatting unification、instruction scheduling optimization、register allocation strategy update、updates to addition/subtraction carry and borrow flag handling.
These enhancements aim to improve both the code maintainability and its execution performance, particularly on out-of-order RISC-V cores.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29438)

2 weeks agodemos/bio/sconnect.c: Add check for BIO_new()
Jiasheng Jiang [Fri, 27 Jun 2025 18:38:19 +0000 (18:38 +0000)] 
demos/bio/sconnect.c: Add check for BIO_new()

Add check for the return value of BIO_new() to guarantee the success.

Fixes: 0f113f3ee4 ("Run util/openssl-format-source -v -c .")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27919)

2 weeks agotest/evp_extra_test.c: Add check for BIO_new()
Jiasheng Jiang [Tue, 8 Jul 2025 22:39:31 +0000 (22:39 +0000)] 
test/evp_extra_test.c: Add check for BIO_new()

Add check for the return value of BIO_new() to avoid NULL pointer dereference.

Fixes: fd19fc4c27 ("Test that a key is usable after an EVP_PKEY_fromdata call")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27994)

2 weeks agoAdd ci test to run against minimal gcc version we support
Neil Horman [Sun, 21 Dec 2025 19:40:45 +0000 (14:40 -0500)] 
Add ci test to run against minimal gcc version we support

We currently support gcc 9 as a minimum compiler version.  We should run
at least one ci job against that minimal version to make sure we don't
break anything.

Most notably this will help us catch errors if we attempt to use
intrinsics that aren't supported by that compiler.

Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29482)

2 weeks agoFix register usage comment in ARMv8 Montgomery sqr asm.
fengpengbo [Thu, 18 Dec 2025 06:45:39 +0000 (14:45 +0800)] 
Fix register usage comment in ARMv8 Montgomery sqr asm.
In the bn_sqr8x_mont function, a comment describing the accumulation step for the partial product a[1]*a[0] incorrectly referenced the low part ('lo') of the product. The value being added to the temporary register t[2] is actually the high part ('hi') of that multiplication.
Correct the comment from "t[2]+lo(a[1]*a[0])" to "t[2]+hi(a[1]*a[0])".

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29436)

2 weeks agoSSL3 documentation nits
Andrew Dinh [Thu, 18 Dec 2025 17:12:06 +0000 (00:12 +0700)] 
SSL3 documentation nits

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoAdd no-ssl3 back as a no-op
Andrew Dinh [Tue, 16 Dec 2025 20:44:18 +0000 (00:44 +0400)] 
Add no-ssl3 back as a no-op

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoAdd entry to CHANGES.md
Andrew Dinh [Fri, 12 Dec 2025 20:33:57 +0000 (00:33 +0400)] 
Add entry to CHANGES.md

Explain the changes to configure

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoRemove sslv3 flags from x86 CI jobs
Andrew Dinh [Wed, 10 Dec 2025 05:15:15 +0000 (05:15 +0000)] 
Remove sslv3 flags from x86 CI jobs

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoUpdate documentation using enable-ssl3 Configure flags
Andrew Dinh [Thu, 11 Sep 2025 07:39:39 +0000 (17:39 +1000)] 
Update documentation using enable-ssl3 Configure flags

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoAllow enabling deprecated flags that haven't been removed yet
Andrew Dinh [Mon, 22 Sep 2025 08:50:42 +0000 (18:50 +1000)] 
Allow enabling deprecated flags that haven't been removed yet

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoDeprecate SSL3 Configure flags
Andrew Dinh [Mon, 8 Sep 2025 13:43:01 +0000 (23:43 +1000)] 
Deprecate SSL3 Configure flags

Show a deprecated warning if users attempt to run Configure script with
no-ssl3, no-ssl, or no-ssl3-method. Also adds a fix to the Configure
script preventing users from enabling deprecated flags.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoRename SSL3 error codes to TLS equivalents
Andrew Dinh [Thu, 11 Sep 2025 07:06:59 +0000 (17:06 +1000)] 
Rename SSL3 error codes to TLS equivalents

Updated error code names and references from SSL3 to TLS in error definitions and error strings. Legacy error codes are preserved in sslerr_legacy.h for backward compatibility

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoAddress SSLv3 removal nits
Andrew Dinh [Thu, 4 Sep 2025 15:09:09 +0000 (22:09 +0700)] 
Address SSLv3 removal nits

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoRemove unused SSLv3 specific error codes
Andrew Dinh [Wed, 10 Sep 2025 14:17:35 +0000 (00:17 +1000)] 
Remove unused SSLv3 specific error codes

Also remove the SSL_TXT_SSLV3 name.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoRemove support for SSLv3
Kurt Roeckx [Tue, 15 Jul 2025 09:38:21 +0000 (11:38 +0200)] 
Remove support for SSLv3

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29338)

2 weeks agoConstify return value of X509_get_X509_PUBKEY()
Bob Beck [Mon, 29 Sep 2025 21:16:33 +0000 (15:16 -0600)] 
Constify return value of X509_get_X509_PUBKEY()

You really should not be mutating this.

Part of #28654
Fixes: https://github.com/openssl/project/issues/1771
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29428)

2 weeks agoConstify the return value of X509_get0_pubkey_bitstr()
Bob Beck [Mon, 29 Sep 2025 21:32:39 +0000 (15:32 -0600)] 
Constify the return value of X509_get0_pubkey_bitstr()

Part of #28654
Fixes: https://github.com/openssl/project/issues/1772
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29434)

2 weeks agoInterop: c_rehash was removed; don't look for it
Norbert Pocs [Sat, 20 Dec 2025 14:17:27 +0000 (15:17 +0100)] 
Interop: c_rehash was removed; don't look for it

Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29474)

2 weeks agoSHA512 performance optimized by RISCV RVV
xxcui [Sat, 29 Nov 2025 01:46:04 +0000 (09:46 +0800)] 
SHA512 performance optimized by RISCV RVV

This patch is dedicated to improve SHA512 speed with RISCV
Cryptographic Vector Extension.

Below performance output is calculated by Xuantie C930 FPGA with VLEN256.
  - sha512 speed might be improved from 197032K to 1010986KB

Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29263)

2 weeks agoAdded AVX2 encoding + scalar improvements
Nick Nuon [Thu, 6 Nov 2025 00:32:25 +0000 (19:32 -0500)] 
Added AVX2 encoding + scalar improvements

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/29178)

3 weeks agoRemove BIO_f_reliable() as it is broken
Tomas Mraz [Thu, 18 Dec 2025 16:07:44 +0000 (17:07 +0100)] 
Remove BIO_f_reliable() as it is broken

It was broken since the OpenSSL 3.0 release and
nobody complained. Apparently nobody is using it.
It would be practically impossible to reimplement
it with the provided EVP_MDs in backwards-compatible
manner.

Fixes #29413

Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29445)

3 weeks agoAdd ASN1_BIT_STRING_get_length()
Theo Buehler [Thu, 11 Dec 2025 15:38:53 +0000 (08:38 -0700)] 
Add ASN1_BIT_STRING_get_length()

From tb@openbsd.org with tests adapted by beck for OpenSSL.

Fixes: https://github.com/openssl/openssl/issues/29184
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29387)

3 weeks agoUpdate doc/man3/OPENSSL_init_crypto.pod
Sashan [Tue, 16 Dec 2025 09:50:53 +0000 (10:50 +0100)] 
Update doc/man3/OPENSSL_init_crypto.pod

Co-authored-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks agoUpdate NEWS.md
Sashan [Mon, 15 Dec 2025 15:33:35 +0000 (16:33 +0100)] 
Update NEWS.md

Co-authored-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks agoUpdate CHANGES.md
Sashan [Mon, 15 Dec 2025 15:33:17 +0000 (16:33 +0100)] 
Update CHANGES.md

Co-authored-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks ago- update NEWS.md
sashan [Mon, 15 Dec 2025 10:34:13 +0000 (11:34 +0100)] 
- update NEWS.md

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks ago- fix CHANGES.md style
sashan [Mon, 15 Dec 2025 09:57:59 +0000 (10:57 +0100)] 
- fix CHANGES.md style

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks ago- fix .cstyle
sashan [Mon, 15 Dec 2025 09:56:57 +0000 (10:56 +0100)] 
- fix .cstyle

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks agoIntroduce OPENSSL_ATEXIT_CLEANUP env. variable.
Alexandr Nedvedicky [Mon, 24 Nov 2025 16:05:26 +0000 (17:05 +0100)] 
Introduce OPENSSL_ATEXIT_CLEANUP env. variable.

libcrypto does not arm OPENSSL_cleanup() function as atexit(3) handler by default.
If application/user wants libcrypto to install OPENSSL_cleanup() as atexit handler,
then OPENSSL_ATEXIT_CLEANUP env. variable must be set.

If platform's libc does not provide atexit(3), then OPENSSL_ATEXIT_CLEANUP has no effect.

The OPENSSL_atexit() is wrapper of atexit(3) provided by libc now.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29385)

3 weeks agoBIO_send/recvmmsg(): Pass msgs_processed to the return callback
Tomas Mraz [Mon, 15 Dec 2025 10:41:38 +0000 (11:41 +0100)] 
BIO_send/recvmmsg(): Pass msgs_processed to the return callback

This avoids crash if a legacy BIO callback is set and
BIO_sendmmsg() or BIO_recvmmsg() is used.

Reported by Stanislav Fort (Aisle Research)

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29395)

3 weeks agowin-makefile.tmpl: Fix program install check
Norbert Pocs [Wed, 17 Dec 2025 20:04:53 +0000 (21:04 +0100)] 
win-makefile.tmpl: Fix program install check

When the array is empty then copy.pl fails, because there is nothing to
copy. The empty check was done on a different variable.

Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29427)

3 weeks agoRemove the c_rehash script
Norbert Pocs [Wed, 17 Dec 2025 16:28:06 +0000 (17:28 +0100)] 
Remove the c_rehash script

The `openssl rehash` should be used instead.

Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29427)

3 weeks agotest/run_tests.pl: Ensure that all HARNESS_VERBOSE values are respected
Richard Levitte [Thu, 18 Dec 2025 13:11:30 +0000 (14:11 +0100)] 
test/run_tests.pl: Ensure that all HARNESS_VERBOSE values are respected

... with perl truthiness in mind

Most of all, this means not having undue expectations that its value
is numerical (this is particularly true when HARNESS_VERBOSE isn't given
by the user, and this script's default is "yes").

We do this by ensuring that $tap_verbosity is turned into an appropriate
number if HARNESS_VERBOSE's value isn't numerical.

Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29443)

3 weeks agoppc64le: Restore VSX registers in AES/GCM ppc64le encrypt/decrypt
Danny Tsen [Thu, 23 Oct 2025 20:51:05 +0000 (16:51 -0400)] 
ppc64le: Restore VSX registers in AES/GCM ppc64le encrypt/decrypt

The implementation failed to restore VSX vector registers from vs14-vs22.

Re-implemented based on Linux kernel version.

Fixes #28961

Signed-off-by: Danny Tsen <dtsen@us.ibm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28990)

3 weeks agoAdd engine stubs test
Milan Broz [Tue, 16 Dec 2025 10:53:27 +0000 (11:53 +0100)] 
Add engine stubs test

This test tries to use all stub macros and compare return values
to verify that OPENSSL_ENGINE_STUBS define works.

Fixes openssl/project#1762

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29414)

3 weeks agoRemove ossl_err_load_ENGINE_strings from stubs
Milan Broz [Tue, 16 Dec 2025 13:34:14 +0000 (14:34 +0100)] 
Remove ossl_err_load_ENGINE_strings from stubs

This was an internal function and should not be here.

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29414)

3 weeks agoFix stub definitions for no-deprecated config
Milan Broz [Tue, 16 Dec 2025 11:41:09 +0000 (12:41 +0100)] 
Fix stub definitions for no-deprecated config

Used types are only available if OPENSSL_NO_DEPRECATED_3_0
is not defined.

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29414)

3 weeks agoFix typo in engine.h stub
Milan Broz [Tue, 16 Dec 2025 10:52:47 +0000 (11:52 +0100)] 
Fix typo in engine.h stub

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29414)

3 weeks agoHarden digest context deserialization
Simo Sorce [Mon, 15 Dec 2025 16:23:57 +0000 (11:23 -0500)] 
Harden digest context deserialization

The deserialization functions for SHA2 and SHA3 digest contexts did not
sufficiently validate the incoming data. Corruption in transmission or
on saved disk data could cause a out-of-bounds memory access if buffer
sizes did not match expected values.

Add sanity checks to the SHA2 and SHA3 deserialization functions to validate
buffer-related fields before they are used. The serialization format for these
digests has been changed to place these critical fields early in the stream to
enable this validation.

Additionally, add a note to the EVP_DigestInit man page to warn users that
deserialization should only be performed on trusted data. The checks we
implement are not meant to address processing of untrusted data
maliciously crafted by an attacker.

Application that need to store data or transmit it through untrusted
media SHOULD implement proper encryption and message authentication
on their own using things like CMS or other appropriate secure message
containers.

These check have been added also to quiet a bit security researchers
that try to find any way to claim CVE bounties even in completely
unlikely or invalid scenarios.

Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/29404)

3 weeks agoevp_test Fix tests that were always skipped
slontis [Tue, 15 Jul 2025 04:28:14 +0000 (14:28 +1000)] 
evp_test Fix tests that were always skipped

The "Verify-Message" type looks for private keys only,
which meant anything using a public key got skipped.
Changed the entries to "Verify-Message-Public" which tries the public
key first.
This uncovered one test that needed to be removed since ECDSA-MD5 is not
a valid fetchable algorithm (in any OpenSSL provider).

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28040)

3 weeks agoutil: add reformat-patches script
Eugene Syromiatnikov [Tue, 9 Dec 2025 15:42:38 +0000 (16:42 +0100)] 
util: add reformat-patches script

A small script that tries to perform reformatting of a patch set.

Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29356)

3 weeks agoUse 'codespell:ignore' where justifiable
Richard Levitte [Thu, 18 Dec 2025 08:52:11 +0000 (09:52 +0100)] 
Use 'codespell:ignore' where justifiable

There's this one random string where we have the word "Hellow".  It's a
random string, "correct" spelling is really not important, so we tell
codespell to just ignore that line.

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29437)

3 weeks agoFix legitimate spelling errors
Richard Levitte [Thu, 18 Dec 2025 08:51:36 +0000 (09:51 +0100)] 
Fix legitimate spelling errors

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29437)

3 weeks agoAdjust .codespellrc
Richard Levitte [Thu, 18 Dec 2025 08:17:15 +0000 (09:17 +0100)] 
Adjust .codespellrc

- add 'external/*' to the list of patterns to skip
- add '*.csr' to the list of patterns to skip

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29437)

3 weeks agoAdd new public API for checking certificate times.
Bob Beck [Fri, 14 Nov 2025 20:36:56 +0000 (13:36 -0700)] 
Add new public API for checking certificate times.

Fixes: #1631
This changes the previously internal ossl_x509_check_certificate_times()
to be the public X509_check_certificate_times(). It adds documentation
for the new function and marks X509_cmp_time, X509_cmp_timeframe,
and X509_cmp_current_time as deprecated in 4.0, as discussed in #1631.

Since the function is now public, we can replace the remaining
uses of deprecated stuff with this function.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29152)

3 weeks agoFix silent failure in ASYNC_start_job when size is 0
Weizhi Ao [Thu, 11 Dec 2025 13:06:23 +0000 (21:06 +0800)] 
Fix silent failure in ASYNC_start_job when size is 0

When ASYNC_start_job is called with args != NULL but size == 0,
OPENSSL_malloc(0) is called. Depending on the libc implementation,
malloc(0) may return NULL, causing a silent failure.

This patch modifies the logic to skip allocation if size is 0.

CLA: trivial

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29377)

3 weeks agoEnsure path to libcrypto can be resolved on AIX.
Matthias Kraft [Wed, 10 Dec 2025 16:02:54 +0000 (17:02 +0100)] 
Ensure path to libcrypto can be resolved on AIX.

On AIX, the environment of the test executable for test_includes doesn't
contain a resolvable search path to the just built libcrypto. Setup
LIBPATH to point to the build results.

Fixes #29352.

Signed-off-by: Matthias Kraft <Matthias.Kraft@ibm.com>
Reviewed-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29375)

3 weeks agoAdd documentation for X509_V_FLAG_OCSP_RESP_CHECK and X509_V_FLAG_OCSP_RESP_CHECK_ALL
martin [Sun, 7 Dec 2025 14:15:07 +0000 (15:15 +0100)] 
Add documentation for X509_V_FLAG_OCSP_RESP_CHECK and X509_V_FLAG_OCSP_RESP_CHECK_ALL

Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29327)

3 weeks agoapps/x509.c: factor out add_object() for handling -addtrust and -addreject options
Dr. David von Oheimb [Thu, 28 Aug 2025 16:38:18 +0000 (18:38 +0200)] 
apps/x509.c: factor out add_object() for handling -addtrust and -addreject options

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/28371)

3 weeks agoAdd mention of OPENSSL_ENGINE_STUBS to openssl_user_macros(7)
Milan Broz [Wed, 17 Dec 2025 10:31:30 +0000 (11:31 +0100)] 
Add mention of OPENSSL_ENGINE_STUBS to openssl_user_macros(7)

Fixes openssl/project#1743
Fixes openssl/project#1744

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29424)