]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/log
thirdparty/sqlalchemy/sqlalchemy.git
2 years agoMerge "add explicit REGCONFIG, pg full text functions" into main
mike bayer [Fri, 16 Dec 2022 15:08:00 +0000 (15:08 +0000)] 
Merge "add explicit REGCONFIG, pg full text functions" into main

2 years agoMerge "Improved error message in orm annotated declarative" into main
mike bayer [Fri, 16 Dec 2022 15:01:06 +0000 (15:01 +0000)] 
Merge "Improved error message in orm annotated declarative" into main

2 years agoMerge "Improve v2 documentation" into main
mike bayer [Thu, 15 Dec 2022 22:32:15 +0000 (22:32 +0000)] 
Merge "Improve v2 documentation" into main

2 years agoadd explicit REGCONFIG, pg full text functions
Mike Bayer [Wed, 14 Dec 2022 01:07:14 +0000 (20:07 -0500)] 
add explicit REGCONFIG, pg full text functions

Added support for explicit use of PG full text functions with asyncpg and
psycopg (SQLAlchemy 2.0 only), with regards to the ``REGCONFIG`` type cast
for the first argument, which previously would be incorrectly cast to a
VARCHAR, causing failures on these dialects that rely upon explicit type
casts. This includes support for :class:`_postgresql.to_tsvector`,
:class:`_postgresql.to_tsquery`, :class:`_postgresql.plainto_tsquery`,
:class:`_postgresql.phraseto_tsquery`,
:class:`_postgresql.websearch_to_tsquery`,
:class:`_postgresql.ts_headline`, each of which will determine based on
number of arguments passed if the first string argument should be
interpreted as a PostgreSQL "REGCONFIG" value; if so, the argument is typed
using a newly added type object :class:`_postgresql.REGCONFIG` which is
then explicitly cast in the SQL expression.

Fixes: #8977
Change-Id: Ib36698a984fd4194bd6e0eb663105f790f3db7d3

2 years agoFix equality comparison between a PG Range and a different class instance
Lele Gaifax [Thu, 15 Dec 2022 09:27:03 +0000 (04:27 -0500)] 
Fix equality comparison between a PG Range and a different class instance

This fixes issue #8984, making the method `Range.__eq__` return `NotImplemented` when the argument is an instance of a different class.

Closes: #8985
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8985
Pull-request-sha: b8f601f038a2203af02a99ab190ebbc1c489549a

Change-Id: Iaf0b651a22a9f346c8f18b3a53e3339bf61bb33f

2 years agoMerge "warn when backref will replace existing userland descriptor" into main
mike bayer [Wed, 14 Dec 2022 22:35:51 +0000 (22:35 +0000)] 
Merge "warn when backref will replace existing userland descriptor" into main

2 years agoImprove v2 documentation
Federico Caselli [Fri, 9 Dec 2022 18:08:19 +0000 (19:08 +0100)] 
Improve v2 documentation

Fixes: #7659
Change-Id: Ic9b758c7eed568f33dd0a745031f96de7666baf1

2 years agoImproved error message in orm annotated declarative
Federico Caselli [Wed, 14 Dec 2022 21:18:58 +0000 (22:18 +0100)] 
Improved error message in orm annotated declarative

Fixes: #8980
Change-Id: I32c4cf8715ee43fa8415f0102394ddd43b1fee0a

2 years agoMerge "catch all BaseException in pool and revert failed checkouts" into main
mike bayer [Wed, 14 Dec 2022 20:40:48 +0000 (20:40 +0000)] 
Merge "catch all BaseException in pool and revert failed checkouts" into main

2 years agowarn when backref will replace existing userland descriptor
Mike Bayer [Wed, 14 Dec 2022 18:49:11 +0000 (13:49 -0500)] 
warn when backref will replace existing userland descriptor

A warning is emitted if a backref name used in :func:`_orm.relationship`
names an attribute on the target class which already has a method or
attribute assigned to that name, as the backref declaration will replace
that attribute.

Fixes: #4629
Change-Id: I0059b35ce60f43b0f3d8be008f12411154484ea1

2 years agocheck index_list pragma for number of columns returned
Mike Bayer [Mon, 12 Dec 2022 23:05:07 +0000 (18:05 -0500)] 
check index_list pragma for number of columns returned

Fixed regression caused by new support for reflection of partial indexes on
SQLite added in 1.4.45 for :ticket:`8804`, where the ``index_list`` pragma
command in very old versions of SQLite (possibly prior to 3.8.9) does not
return the current expected number of columns, leading to exceptions raised
when reflecting tables and indexes.

Fixes: #8969
Change-Id: If317cdcfc6782f7e180df329b6ea0ddb48ce2269

2 years agocatch all BaseException in pool and revert failed checkouts
Mike Bayer [Mon, 12 Dec 2022 18:47:27 +0000 (13:47 -0500)] 
catch all BaseException in pool and revert failed checkouts

Fixed a long-standing race condition in the connection pool which could
occur under eventlet/gevent monkeypatching schemes in conjunction with the
use of eventlet/gevent ``Timeout`` conditions, where a connection pool
checkout that's interrupted due to the timeout would fail to clean up the
failed state, causing the underlying connection record and sometimes the
database connection itself to "leak", leaving the pool in an invalid state
with unreachable entries. This issue was first identified and fixed in
SQLAlchemy 1.2 for :ticket:`4225`, however the failure modes detected in
that fix failed to accommodate for ``BaseException``, rather than
``Exception``, which prevented eventlet/gevent ``Timeout`` from being
caught. In addition, a block within initial pool connect has also been
identified and hardened with a ``BaseException`` -> "clean failed connect"
block to accommodate for the same condition in this location.
Big thanks to Github user @niklaus for their tenacious efforts in
identifying and describing this intricate issue.

Fixes: #8974
Change-Id: I95a0e1f080d0cee6f1a66977432a586fdf87f686

2 years agoType annotations for sqlalchemy.ext.horizontal_shard
Gleb Kisenkov [Thu, 8 Dec 2022 22:48:55 +0000 (17:48 -0500)] 
Type annotations for sqlalchemy.ext.horizontal_shard

The horizontal sharding extension is now pep-484 typed. Thanks to Gleb
Kisenkov for their efforts on this.

Closes: #8948
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8948
Pull-request-sha: e40e768492685aa9ce57c4762c571f935e3fd3c7

Change-Id: I2374e174c9433846c453c20a37ec5e5584fd3b31

2 years agoadd color directives
Mike Bayer [Sun, 11 Dec 2022 20:47:25 +0000 (15:47 -0500)] 
add color directives

See https://tox.wiki/en/latest/faq.html#tox-4-known-regressions

Change-Id: I3c7291a660dc167bce3151e02cd123edc4707ca1

2 years agoadjust for tox changes to passenv
Mike Bayer [Sun, 11 Dec 2022 16:13:58 +0000 (11:13 -0500)] 
adjust for tox changes to passenv

Fixed issue in tox.ini file where changes in the tox 4.0 series to the
format of "passenv" caused tox to not function correctly, in particular
raising an error as of tox 4.0.6.

Change-Id: I659c8fc523a71deaa02a89103c9e7241cf81d831
References: https://github.com/tox-dev/tox/issues/2676

2 years agocherry-pick changelog update for 1.4.46
Mike Bayer [Sat, 10 Dec 2022 18:51:43 +0000 (13:51 -0500)] 
cherry-pick changelog update for 1.4.46

2 years agocherry-pick changelog from 1.4.45
Mike Bayer [Sat, 10 Dec 2022 18:51:42 +0000 (13:51 -0500)] 
cherry-pick changelog from 1.4.45

2 years agolook out for extras=None in freeze
Mike Bayer [Fri, 9 Dec 2022 20:56:15 +0000 (15:56 -0500)] 
look out for extras=None in freeze

Fixed issue where :meth:`_engine.Result.freeze` method would not work for
textual SQL using either :func:`_sql.text` or
:meth:`_engine.Connection.exec_driver_sql`.

Fixes: #8963
Change-Id: Ia131c6ac41a4adf32eb1bf1abf23930ef395f16c

2 years agofix typo
Mike Bayer [Fri, 9 Dec 2022 19:51:24 +0000 (14:51 -0500)] 
fix typo

Change-Id: I09d1d1c9505c1cad8ed21b675a105b0dbbb02e00

2 years agoMerge "Better syncronize async result docs with plain ones." into main
mike bayer [Fri, 9 Dec 2022 19:49:41 +0000 (19:49 +0000)] 
Merge "Better syncronize async result docs with plain ones." into main

2 years agoBetter syncronize async result docs with plain ones.
Federico Caselli [Thu, 8 Dec 2022 18:34:49 +0000 (19:34 +0100)] 
Better syncronize async result docs with plain ones.

Removed non-functional method ``merge`` from :class:`_asyncio.AsyncResult`.
This method was non-functional and non-testes since the first introduction
of asyncio in SQLAlchemy.

Fixes: #7158
Fixes: #8952
Change-Id: Ibc3d17be8a8b7cab9bf2074f0408f74b4c4b161d

2 years agoSpecify view columns in HasTableTest
Gord Thompson [Fri, 9 Dec 2022 16:55:34 +0000 (09:55 -0700)] 
Specify view columns in HasTableTest

Fixes: #8960
Avoid test errors on databases that do not
support CREATE VIEW vv AS SELECT * FROM

Change-Id: Ic9e892aa4466030b9b325c11228dad15cf59a258

2 years agofix construct_params() for render_postcompile; add new API
Mike Bayer [Thu, 8 Dec 2022 16:00:31 +0000 (11:00 -0500)] 
fix construct_params() for render_postcompile; add new API

The :meth:`.SQLCompiler.construct_params` method, as well as the
:attr:`.SQLCompiler.params` accessor, will now return the
exact parameters that correspond to a compiled statement that used
the ``render_postcompile`` parameter to compile.   Previously,
the method returned a parameter structure that by itself didn't correspond
to either the original parameters or the expanded ones.

Passing a new dictionary of parameters to
:meth:`.SQLCompiler.construct_params` for a :class:`.SQLCompiler` that was
constructed with ``render_postcompile`` is now disallowed; instead, to make
a new SQL string and parameter set for an alternate set of parameters, a
new method :meth:`.SQLCompiler.construct_expanded_state` is added which
will produce a new expanded form for the given parameter set, using the
:class:`.ExpandedState` container which includes a new SQL statement
and new parameter dictionary, as well as a positional parameter tuple.

Fixes: #6114
Change-Id: I9874905bb90f86799b82b244d57369558b18fd93

2 years agoMerge "disable polymorphic adaption in most cases" into main
mike bayer [Thu, 8 Dec 2022 00:25:34 +0000 (00:25 +0000)] 
Merge "disable polymorphic adaption in most cases" into main

2 years agodisable polymorphic adaption in most cases
Mike Bayer [Mon, 5 Dec 2022 21:11:59 +0000 (16:11 -0500)] 
disable polymorphic adaption in most cases

Improved a fix first made in version 1.4 for :ticket:`8456` which scaled
back the usage of internal "polymorphic adapters", that are used to render
ORM queries when the :paramref:`_orm.Mapper.with_polymorphic` parameter is
used. These adapters, which are very complex and error prone, are now used
only in those cases where an explicit user-supplied subquery is used for
:paramref:`_orm.Mapper.with_polymorphic`, which includes only the use case
of concrete inheritance mappings that use the
:func:`_orm.polymorphic_union` helper, as well as the legacy use case of
using an aliased subquery for joined inheritance mappings, which is not
needed in modern use.

For the most common case of joined inheritance mappings that use the
built-in polymorphic loading scheme, which includes those which make use of
the :paramref:`_orm.Mapper.polymorphic_load` parameter set to ``inline``,
polymorphic adapters are now no longer used. This has both a positive
performance impact on the construction of queries as well as a
substantial simplification of the internal query rendering process.

The specific issue targeted was to allow a :func:`_orm.column_property`
to refer to joined-inheritance classes within a scalar subquery, which now
works as intuitively as is feasible.

ORM context, mapper, strategies now use ORMAdapter in all cases
instead of straight ColumnAdapter; added some more parameters
to ORMAdapter to make this possible.  ORMAdapter now includes a
"trace" enumeration that identifies the use path for the
adapter and can aid in debugging.

implement __slots__ for the ExternalTraversal hierarchy up
to ORMAdapter.  Within this change, we have to change the
ClauseAdapter.wrap() method, which is only used in one polymorphic
codepath, to use copy.copy() instead of
`__dict__` access (apparently `__reduce_ex__` is implemented for
objects with `__slots__`), and we also remove pickling ability,
which should not be needed for adapters (this might have been needed
for 1.3 and earlier in order for Query to be picklable, but none
of that state is present within Query / select() / etc. anymore).

Fixes: #8168
Change-Id: I3f6593eb02ab5e5964807c53a9fa4894c826d017

2 years agoOracle COLUMN_VALUE is a column name, not a keyword
Mike Bayer [Wed, 7 Dec 2022 20:54:59 +0000 (15:54 -0500)] 
Oracle COLUMN_VALUE is a column name, not a keyword

Fixed issue in Oracle compiler where the syntax for
:meth:`.FunctionElement.column_valued` was incorrect, rendering the name
``COLUMN_VALUE`` without qualifying the source table correctly.

Fixes: #8945
Change-Id: Ia04bbdc68168e78b67a74bb3834a63f5d5000627

2 years agomove more Session weakref tests to test_memusage
Mike Bayer [Wed, 7 Dec 2022 19:23:45 +0000 (14:23 -0500)] 
move more Session weakref tests to test_memusage

py311 may be more sensitive here, or maybe the machines are
acting differently these days, in any case move
memory  / GC sensitive tests to test_memusage.

Change-Id: I218295150efc2f7ea88da9960ff10fda63dc60b1

2 years agosort materialize view names in test
Mike Bayer [Tue, 6 Dec 2022 21:31:30 +0000 (16:31 -0500)] 
sort materialize view names in test

saw this fail on CI with views in reverse order

Change-Id: I953f379f36924673a49b94cf5e7f54d071044113

2 years agotake mariadb-connector out of dbapi main job
Mike Bayer [Tue, 6 Dec 2022 14:08:55 +0000 (09:08 -0500)] 
take mariadb-connector out of dbapi main job

mariadb-connector seems to have their release situation "fixed",
but for 1.1.5post3 they are requiring mariadb-connector-c 3.3.1, Fedora 36
which is quite bleeding edge only has 3.2.7.    There's no way we
can easily have a version specifier that will look at underlying
client libraries.

since mariadb-connector's main branch seems to work way ahead of
where we will normally have client libraries set up, it's not really
worth testing in CI right now.

Change-Id: Idcb034da6d06620b5e212582bbc63a246a9fe58b

2 years agoVersion 2.0.0b5 placeholder
Mike Bayer [Mon, 5 Dec 2022 23:21:33 +0000 (18:21 -0500)] 
Version 2.0.0b5 placeholder

2 years ago- 2.0.0b4 rel_2_0_0b4
Mike Bayer [Mon, 5 Dec 2022 23:14:49 +0000 (18:14 -0500)] 
- 2.0.0b4

2 years agoMerge "Add tests for issue #8168; slight internal adjustments" into main
mike bayer [Mon, 5 Dec 2022 23:11:10 +0000 (23:11 +0000)] 
Merge "Add tests for issue #8168; slight internal adjustments" into main

2 years agoAdd tests for issue #8168; slight internal adjustments
Mike Bayer [Sun, 4 Dec 2022 17:02:37 +0000 (12:02 -0500)] 
Add tests for issue #8168; slight internal adjustments

The issue in #8168 was improved, but not completely fixed,
by #8456.

This includes some small changes to ORM context that
are a prerequisite for getting ORM adaptation to be
better.   Have these in 2.0.0b4 so that we have at
least a better starting point.

References: #8168
Change-Id: I51dbe333b156048836d074fbba1d850f9eb67fd2

2 years agochangelog updates
Mike Bayer [Mon, 5 Dec 2022 22:16:32 +0000 (17:16 -0500)] 
changelog updates

prep for 2.0.0b4

Change-Id: I2bf7249f6ed0c120b9d04d81eaecdf8593729c83
(cherry picked from commit 42876aabb5f893e1922676eb809e6b37c0519ed8)

2 years agorename some GitHub actions to use test names as prefix, as introduced in rel_1_4...
Jonathan Vanasco [Mon, 5 Dec 2022 22:08:10 +0000 (17:08 -0500)] 
rename some GitHub actions to use test names as prefix, as introduced in rel_1_4 (#8933)

Change-Id: I7f3aa96447ade605becbdef01bc19f3b78dbd6d1

2 years agoMerge "Add compatibility properties to Range; implement pep-484" into main
mike bayer [Mon, 5 Dec 2022 19:32:15 +0000 (19:32 +0000)] 
Merge "Add compatibility properties to Range; implement pep-484" into main

2 years agoAdd compatibility properties to Range; implement pep-484
Lele Gaifax [Mon, 5 Dec 2022 01:51:13 +0000 (20:51 -0500)] 
Add compatibility properties to Range; implement pep-484

This adds a bunch of properties to new PG Range class for compatibility
with other implementations, providing a more similar API to access
emptiness and bounds status.

The naming conventions here derive from PostgreSQL itself,
see https://www.postgresql.org/docs/9.3/functions-range.html .

pep-484 also implemented by Mike, as this is a pretty type-intensive
module.

Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com>
Closes: #8927
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8927
Pull-request-sha: 8b9e7b7e3345673b43aeabd7ec88b88dc3cfa7eb

Change-Id: I0b1d49311517ee1cc1377a974ed0a860ea5756e4

2 years agoMerge "Rewrite positional handling, test for "numeric"" into main
mike bayer [Mon, 5 Dec 2022 16:29:52 +0000 (16:29 +0000)] 
Merge "Rewrite positional handling, test for "numeric"" into main

2 years agoRewrite positional handling, test for "numeric"
Federico Caselli [Fri, 2 Dec 2022 16:58:40 +0000 (11:58 -0500)] 
Rewrite positional handling, test for "numeric"

Changed how the positional compilation is performed. It's rendered by the compiler
the same as the pyformat compilation. The string is then processed to replace
the placeholders with the correct ones, and to obtain the correct order of the
parameters.
This vastly simplifies the computation of the order of the parameters, that in
case of nested CTE is very hard to compute correctly.

Reworked how numeric paramstyle behavers:
- added support for repeated parameter, without duplicating them like in normal
positional dialects
- implement insertmany support. This requires that the dialect supports out of
order placehoders, since all parameters that are not part of the VALUES clauses
are placed at the beginning of the parameter tuple
- support for different identifiers for a numeric parameter. It's for example
possible to use postgresql style placeholder $1, $2, etc

Added two new dialect based on sqlite to test "numeric" fully using
both :1 style and $1 style. Includes a workaround for SQLite's
not-really-correct numeric implementation.

Changed parmstyle of asyncpg dialect to use numeric, rendering with its native
$ identifiers

Fixes: #8926
Fixes: #8849
Change-Id: I7c640467d49adfe6d795cc84296fc7403dcad4d6

2 years agoType annotations for sqlalchemy.ext.automap
Gleb Kisenkov [Mon, 5 Dec 2022 13:45:25 +0000 (08:45 -0500)] 
Type annotations for sqlalchemy.ext.automap

An attempt to annotate `lib/sqlalchemy/ext/automap.py` with type hints (issue [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810#issuecomment-1127062951)).

More info on how I approach it could be found in [the earlier PR](https://github.com/sqlalchemy/sqlalchemy/pull/8775).

This pull request is:

- [ ] A documentation / typographical error fix
  - Good to go, no issue or tests are needed
- [ ] A short code fix
  - please include the issue number, and create an issue if none exists, which
    must include a complete example of the issue. one line code fixes without an
    issue and demonstration will not be accepted.
  - Please include: `Fixes: #<issue number>` in the commit message
  - please include tests. one line code fixes without tests will not be accepted.
- [x] A new feature implementation
  - please include the issue number, and create an issue if none exists, which must
    include a complete example of how the feature would look.
  - Please include: `Fixes: #<issue number>` in the commit message
  - please include tests.

**Have a nice day!**

Closes: #8874
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8874
Pull-request-sha: 834d58d77c2cfd09ea874f01eb7b75a2ea0db7cd

Change-Id: Ie64b2be7a51ddc83ef8f23385fb63db5b5c1bc17

2 years agoMerge "adjustments for unreliable gc" into main
mike bayer [Mon, 5 Dec 2022 14:01:12 +0000 (14:01 +0000)] 
Merge "adjustments for unreliable gc" into main

2 years agoMerge "Fixed an invalid syntax in an except statement" into main
mike bayer [Mon, 5 Dec 2022 13:54:51 +0000 (13:54 +0000)] 
Merge "Fixed an invalid syntax in an except statement" into main

2 years agoMerge "Fix grammar (whatsnew_20.rst)" into main
mike bayer [Mon, 5 Dec 2022 13:54:37 +0000 (13:54 +0000)] 
Merge "Fix grammar (whatsnew_20.rst)" into main

2 years agoFixed an invalid syntax in an except statement
wiseaidev [Mon, 5 Dec 2022 13:44:35 +0000 (08:44 -0500)] 
Fixed an invalid syntax in an except statement

### Description

As the title suggests, I have fixed an invalid syntax in the docs for an `except` statement while reading the unusual.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [x] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #8715
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8715
Pull-request-sha: e8be2bc4a5401ab2a5a0fc1d2e50d41fa437ae80

Change-Id: If8512bf1853f7cdb1ae655f0945cd922fff6fbce

2 years agodoc change - Add new external dialect for openGauss
j00356287 [Mon, 5 Dec 2022 13:44:09 +0000 (08:44 -0500)] 
doc change - Add new external dialect for openGauss

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
<!-- Describe your changes in detail -->
Added new external dialect for [openGauss](https://www.opengauss.org/en/).

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [x] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #8803
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8803
Pull-request-sha: ca5a7f1310b2ce93ce33618e0609abe23b41a3da

Change-Id: Ia8ca38f98f346fa3cc910ceb7af47f8c903eb587

2 years agoFix grammar (whatsnew_20.rst)
Sam Bull [Mon, 5 Dec 2022 13:43:50 +0000 (08:43 -0500)] 
Fix grammar (whatsnew_20.rst)

None

Closes: #8835
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8835
Pull-request-sha: 7488c752d90ce305076ba06b7a4077dc67c0ea66

Change-Id: Iad959dcff21bd1aa593793c4a38cb795529468e8

2 years agoadjustments for unreliable gc
Mike Bayer [Mon, 5 Dec 2022 04:25:14 +0000 (23:25 -0500)] 
adjustments for unreliable gc

sporadic (and at the moment persistent) test failures
related to aiosqlite seem to have in common that Python
gc stops working fully when we run a lot of tests with
aiosqlite.  The failures are not limited to aiosqlite
as they are more involving places where we assume or
expect gc.collect() to get rid of things, and it doesn't.

Identify (based on reproducible case on the d3 CI runner)
the spots where this happens and add fixes.

test/orm/test_transaction.py test_gced_delete_on_rollback
has always been a very sensitive test with a lot of issues,
so here we move it to the test_memusage suite and limit
it only to when the memusage suite is running.

Change-Id: I683412d0effe8732c45980b40722e5bb63431177

2 years agoMerge "disallow same-named columns, unchecked replacement in Table" into main
mike bayer [Sun, 4 Dec 2022 17:25:44 +0000 (17:25 +0000)] 
Merge "disallow same-named columns, unchecked replacement in Table" into main

2 years agodisallow same-named columns, unchecked replacement in Table
Mike Bayer [Sat, 3 Dec 2022 14:11:14 +0000 (09:11 -0500)] 
disallow same-named columns, unchecked replacement in Table

Fixed issue where table reflection using :paramref:`.Table.extend_existing`
would fail to deduplicate a same-named column if the existing
:class:`.Table` used a separate key. The
:paramref:`.Table.autoload_replace` parameter would allow the column to be
skipped but under no circumstances should a :class:`.Table` ever have the
same-named column twice.

Additionally, changed deprecation warnings to exceptions
as were implemented in I1d58c8ebe081079cb669e7ead60886ffc1b1a7f5 .

Fixes: #8925
Change-Id: I83d0f8658177a7ffbb06e01dbca91377d1a98d49

2 years agoMerge "Order_by and group_by accept labels" into main
mike bayer [Sun, 4 Dec 2022 15:00:46 +0000 (15:00 +0000)] 
Merge "Order_by and group_by accept labels" into main

2 years agoSome test pipeline updates
Federico Caselli [Thu, 1 Dec 2022 21:29:50 +0000 (22:29 +0100)] 
Some test pipeline updates

Add back pypy, python 3.12

Change-Id: Ie3b3b890d75b3939b3d5f684ec7eadadfe06a5ea

2 years agoOrder_by and group_by accept labels
Federico Caselli [Sat, 3 Dec 2022 16:39:55 +0000 (17:39 +0100)] 
Order_by and group_by accept labels

Improve typing to accept labels in ordey_by mand group_by.

Change-Id: I33e5d6f64633d39a220108d412ef84d6478b25e6

2 years agoadd spaces, leading underscore to oracle checks
Mike Bayer [Fri, 2 Dec 2022 22:00:10 +0000 (17:00 -0500)] 
add spaces, leading underscore to oracle checks

Expand the test suite from #8708 which unfortunately did
not exercise the bound parameter codepaths completely.

Continued fixes for Oracle fix :ticket:`8708` released in 1.4.43 where
bound parameter names that start with underscores, which are disallowed by
Oracle, were still not being properly escaped in all circumstances.

Fixes: #8708
Change-Id: Ic389c09bd7c53b773e5de35f1a18ef20769b92a7

2 years agoadd backports for 2.0/ 1.4 changes
Mike Bayer [Fri, 2 Dec 2022 21:36:42 +0000 (16:36 -0500)] 
add backports for 2.0/ 1.4 changes

Change-Id: I5aab8b25337f67385fc998954ab1fa883c175cc2

2 years agoMerge "Fix positional compiling bugs" into main
mike bayer [Fri, 2 Dec 2022 14:31:17 +0000 (14:31 +0000)] 
Merge "Fix positional compiling bugs" into main

2 years agoMerge "disable setinputsizes only for true DBAPI executemany" into main
mike bayer [Fri, 2 Dec 2022 14:09:05 +0000 (14:09 +0000)] 
Merge "disable setinputsizes only for true DBAPI executemany" into main

2 years agoFix positional compiling bugs
Federico Caselli [Sat, 19 Nov 2022 19:39:10 +0000 (20:39 +0100)] 
Fix positional compiling bugs

Fixed a series of issues regarding positionally rendered bound parameters,
such as those used for SQLite, asyncpg, MySQL and others. Some compiled
forms would not maintain the order of parameters correctly, such as the
PostgreSQL ``regexp_replace()`` function as well as within the "nesting"
feature of the :class:`.CTE` construct first introduced in :ticket:`4123`.

Fixes: #8827
Change-Id: I9813ed7c358cc5c1e26725c48df546b209a442cb

2 years agoMerge "add new pattern for single inh column override" into main
mike bayer [Thu, 1 Dec 2022 21:41:21 +0000 (21:41 +0000)] 
Merge "add new pattern for single inh column override" into main

2 years agodisable setinputsizes only for true DBAPI executemany
Mike Bayer [Thu, 1 Dec 2022 21:03:58 +0000 (16:03 -0500)] 
disable setinputsizes only for true DBAPI executemany

Fixed regression caused by the combination of :ticket:`8177`, re-enable
setinputsizes for SQL server unless fast_executemany + DBAPI executemany is
used for a statement, along with :ticket:`6047`, implement
"insertmanyvalues", which bypasses DBAPI executemany in place of a custom
DBAPI execute for INSERT statements. setinputsizes would incorrectly not be
used for a multiple parameter-set INSERT statement that used
"insertmanyvalues" if fast_executemany were turned on, as the check would
incorrectly assume this is a DBAPI executemany call.  The "regression"
would then be that the "insertmanyvalues" statement format is apparently
slightly more sensitive to multiple rows that don't use the same types
for each row, so in such a case setinputsizes is especially needed.

The fix repairs the fast_executemany check so that it only disables
setinputsizes if true DBAPI executemany is to be used.

Fixes: #8917
Change-Id: I78895606a99848d4f92ecf38ded92dc5d6d48c6f

2 years agoget aiosqlite to run on python 3 but not 3.11, attempt 2
Mike Bayer [Thu, 1 Dec 2022 00:41:15 +0000 (19:41 -0500)] 
get aiosqlite to run on python 3 but not 3.11, attempt 2

Change-Id: Iee0077f8c662da59ee63fa73296cb04ab1b09551

2 years agouse python 3.11 current, dont use aiosqlite on py311
Mike Bayer [Wed, 30 Nov 2022 23:57:07 +0000 (18:57 -0500)] 
use python 3.11 current, dont use aiosqlite on py311

Py 3.11 is released so I assume we can remove "rc" qualifiers
here

aiosqlite is causing python 3.11 crashes, so I assume this is
due to https://github.com/python/cpython/issues/99205.

I'm only guessing the syntax here, so there may be subsequent
commits if this doesnt work

Change-Id: I6f2ead3e0aca933a972efadf3891edbcdd83501c

2 years agoadd new pattern for single inh column override
Mike Bayer [Thu, 17 Nov 2022 17:03:46 +0000 (12:03 -0500)] 
add new pattern for single inh column override

Added a new parameter :paramref:`_orm.mapped_column.use_existing_column` to
accommodate the use case of a single-table inheritance mapping that uses
the pattern of more than one subclass indicating the same column to take
place on the superclass. This pattern was previously possible by using
:func:`_orm.declared_attr` in conjunction with locating the existing column
in the ``.__table__`` of the superclass, however is now updated to work
with :func:`_orm.mapped_column` as well as with pep-484 typing, in a
simple and succinct way.

Fixes: #8822
Change-Id: I2296a4a775da976c642c86567852cdc792610eaf

2 years agoMerge "[sqlite] Reflect DEFERRABLE and INITIALLY options for foreign keys" into main
mike bayer [Wed, 30 Nov 2022 22:36:22 +0000 (22:36 +0000)] 
Merge "[sqlite] Reflect DEFERRABLE and INITIALLY options for foreign keys" into main

2 years agoAdd "compare" on dataclass fields
Simon Schiele [Wed, 30 Nov 2022 13:40:50 +0000 (08:40 -0500)] 
Add "compare" on dataclass fields

Added :paramref:`_orm.mapped_column.compare` parameter to relevant ORM
attribute constructs including :func:`_orm.mapped_column`,
:func:`_orm.relationship` etc. to provide for the Python dataclasses
``compare`` parameter on ``field()``, when using the
:ref:`orm_declarative_native_dataclasses` feature. Pull request courtesy
Simon Schiele.

Added an additional case for associationproxy into
test_dc_transforms.py -> test_attribute_options

Fixes: #8905
Closes: #8906
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8906
Pull-request-sha: ea9a53d2ca60befdd0c570013c0e57a78c11dd4a

Change-Id: I390d043b06c1d668242325ef86e2f7b7dbfac442

2 years ago[sqlite] Reflect DEFERRABLE and INITIALLY options for foreign keys
Michael Gorven [Tue, 29 Nov 2022 23:36:19 +0000 (18:36 -0500)] 
[sqlite] Reflect DEFERRABLE and INITIALLY options for foreign keys

Added support for the SQLite backend to reflect the "DEFERRABLE" and
"INITIALLY" keywords which may be present on a foreign key construct. Pull
request courtesy Michael Gorven.

Fixes: #8903
Closes: #8904
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8904
Pull-request-sha: 52aa4cf77482c4051899e21bea75b9830e4c3efa

Change-Id: I713906db1a458d8f1be39625841ca3bbc03ec835

2 years agoMerge "Improve support for enum in mapped classes" into main
mike bayer [Wed, 30 Nov 2022 16:35:41 +0000 (16:35 +0000)] 
Merge "Improve support for enum in mapped classes" into main

2 years agoMerge "annotated / DC forms for association proxy" into main
mike bayer [Wed, 30 Nov 2022 14:04:34 +0000 (14:04 +0000)] 
Merge "annotated / DC forms for association proxy" into main

2 years agoannotated / DC forms for association proxy
Mike Bayer [Fri, 25 Nov 2022 19:29:30 +0000 (14:29 -0500)] 
annotated / DC forms for association proxy

Added support for the :func:`.association_proxy` extension function to
take part within Python ``dataclasses`` configuration, when using
the native dataclasses feature described at
:ref:`orm_declarative_native_dataclasses`.  Included are attribute-level
arguments including :paramref:`.association_proxy.init` and
:paramref:`.association_proxy.default_factory`.

Documentation for association proxy has also been updated to use
"Annotated Declarative Table" forms within examples, including type
annotations used for :class:`.AssocationProxy` itself.

Also modernized documentation examples in sqlalchemy.ext.mutable,
which was not up to date even for 1.4 style code.

Corrected typing for relationship(secondary) where "secondary"
accepts a callable (i.e. lambda) as well

Fixes: #8878
Fixes: #8876
Fixes: #8880
Change-Id: Ibd4f3591155a89f915713393e103e61cc072ed57

2 years agoMerge "Add value-level hooks for SQL type detection; apply to Range" into main
mike bayer [Tue, 29 Nov 2022 23:35:16 +0000 (23:35 +0000)] 
Merge "Add value-level hooks for SQL type detection; apply to Range" into main

2 years agoImprove support for enum in mapped classes
Federico Caselli [Sun, 27 Nov 2022 17:11:34 +0000 (18:11 +0100)] 
Improve support for enum in mapped classes

Add a new system by which TypeEngine objects have some
say in how the declarative type registry interprets them.
The Enum datatype is the primary target for this but it is
hoped the system may be useful for other types as well.

Fixes: #8859
Change-Id: I15ac3daee770408b5795746f47c1bbd931b7d26d

2 years agoAdd value-level hooks for SQL type detection; apply to Range
Lele Gaifax [Sun, 27 Nov 2022 16:28:51 +0000 (11:28 -0500)] 
Add value-level hooks for SQL type detection; apply to Range

Added additional type-detection for the new PostgreSQL
:class:`_postgresql.Range` type, where previous cases that allowed the
psycopg2-native range objects to be received directly by the DBAPI without
SQLAlchemy intercepting them stopped working, as we now have our own value
object. The :class:`_postgresql.Range` object has been enhanced such that
SQLAlchemy Core detects it in otherwise ambiguous situations (such as
comparison to dates) and applies appropriate bind handlers. Pull request
courtesy Lele Gaifax.

Fixes: #8884
Closes: #8886
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8886
Pull-request-sha: 6e95e08a30597d3735ab38f2f1a2ccabd968852c

Change-Id: I3ca277c826dcf4b5644f44eb251345b439a84ee4

2 years agoupdate for mypy 1.0 dev
Federico Caselli [Sun, 27 Nov 2022 17:11:34 +0000 (18:11 +0100)] 
update for mypy 1.0 dev

As I need dmypy to work without facing [1], I am
running the latest build of mypy which seems so far
to finally not have that issue.

update constructs that latest mypy is being more picky
about, including better typing for the _NONE_NAME
symbol used in constraints (porting those elements
from the Enum patch at
I15ac3daee770408b5795746f47c1bbd931b7d26d)

[1] https://github.com/python/mypy/issues/12744

Change-Id: Ib3f56787fa65ea9bb2e6a0bccc4d99f54c516dad

2 years agoAdd PyAthena Dialect (#8898)
Jason Myers [Tue, 29 Nov 2022 18:12:12 +0000 (12:12 -0600)] 
Add PyAthena Dialect (#8898)

* Add PyAthena Dialect

* Changing order

2 years agoMerge "add partial index predicate to SQLiteDialect.get_indexes() result" into main
mike bayer [Tue, 29 Nov 2022 16:17:47 +0000 (16:17 +0000)] 
Merge "add partial index predicate to SQLiteDialect.get_indexes() result" into main

2 years agoadd partial index predicate to SQLiteDialect.get_indexes() result
Tobias Pfeiffer [Mon, 28 Nov 2022 12:52:31 +0000 (07:52 -0500)] 
add partial index predicate to SQLiteDialect.get_indexes() result

Added support for reflection of expression-oriented WHERE criteria included
in indexes on the SQLite dialect, in a manner similar to that of the
PostgreSQL dialect. Pull request courtesy Tobias Pfeiffer.

Fixes: #8804
Closes: #8806
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8806
Pull-request-sha: 539dfcb372360911b69aed2a804698bb1a2220b1

Change-Id: I0e34d47dbe2b9c1da6fce531363084843e5127a3

2 years agoMerge "identify unresolvable Mapped types" into main
mike bayer [Mon, 28 Nov 2022 19:43:09 +0000 (19:43 +0000)] 
Merge "identify unresolvable Mapped types" into main

2 years agoidentify unresolvable Mapped types
Mike Bayer [Mon, 28 Nov 2022 15:58:49 +0000 (10:58 -0500)] 
identify unresolvable Mapped types

Fixed issue where use of an unknown datatype within a :class:`.Mapped`
annotation for a column-based attribute would silently fail to map the
attribute, rather than reporting an exception; an informative exception
message is now raised.

tighten up iteration of names on mapped classes to more fully
exclude a large number of underscored names, so that we can avoid trying
to look at annotations for them or anything else.  centralize the
"list of names we care about" more fully within _cls_attr_resolver
and base it on underscore conventions we should usually ignore,
with the exception of the few underscore names we want to see.

Fixes: #8888
Change-Id: I3c0a1666579fe67b3c40cc74fa443b6f1de354ce

2 years agoRectify PG Range.__bool__, inverting previous logic
Lele Gaifax [Sun, 27 Nov 2022 19:44:13 +0000 (14:44 -0500)] 
Rectify PG Range.__bool__, inverting previous logic

The boolness of the range was defined to be equal to its emptiness. As this has been identified as a typo rather than the intended, this inverts the logic, to match common Python behaviour as well as how other popular PG drivers do.

Closes: #8885
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8885
Pull-request-sha: 5670cdb920692a62f77b7b6ea312784033de83d9

Change-Id: I6f4a40168b2f037c578e84f7550370411bd42160

2 years agoMerge "improve column targeting issues with query_expression" into main
mike bayer [Sun, 27 Nov 2022 16:36:32 +0000 (16:36 +0000)] 
Merge "improve column targeting issues with query_expression" into main

2 years agoMerge "Add recommendation for URL.create() re: escaping" into main
mike bayer [Sun, 27 Nov 2022 16:32:53 +0000 (16:32 +0000)] 
Merge "Add recommendation for URL.create() re: escaping" into main

2 years agoAdd recommendation for URL.create() re: escaping
Gord Thompson [Thu, 24 Nov 2022 17:38:20 +0000 (10:38 -0700)] 
Add recommendation for URL.create() re: escaping

Let users know that URL.create() can build the
whole connection URL instead of making them
escape things like passwords ad-hoc.

includes some general cleanup of URL docstring
by mike

Change-Id: Ic71bb0201fecf30e1db11e006c269f2d041b5439

2 years agoImplement ScalarValue
Federico Caselli [Tue, 8 Nov 2022 21:12:47 +0000 (22:12 +0100)] 
Implement ScalarValue

Added :class:`_expression.ScalarValues` that can be used as a column
element allowing using :class:`_expression.Values` inside IN clauses
or in conjunction with ``ANY`` or ``ALL`` collection aggregates.
This new class is generated using the method
:meth:`_expression.Values.scalar_values`.
The :class:`_expression.Values` instance is now coerced to a
:class:`_expression.ScalarValues` when used in a ``IN`` or ``NOT IN``
operation.

Fixes: #6289
Change-Id: Iac22487ccb01553684b908e54d01c0687fa739f1

2 years agoadd new variation helper
Mike Bayer [Sat, 26 Nov 2022 16:03:45 +0000 (11:03 -0500)] 
add new variation helper

I'm using a lot of @testing.combinations with either
a boolean True/False, or a series of string names, each indicating
some case to switch on.  I want a descriptive name in the test
run (not True/False) and I don't want to compare strings.

So make a new helper around @combinations that provides an
object interface that has booleans inside of it, prints nicely
in the test output, raises an error if you name the case
incorrectly.

Before:

test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-False-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-False-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-False-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-True-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-True-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[False-True-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-False-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-False-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-False-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-True-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-True-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[True-True-name] PASSED

After:

test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-deferred-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-deferred-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-deferred-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-not_deferred-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-not_deferred-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[not_use_add_property-not_deferred-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-deferred-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-deferred-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-deferred-name] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-not_deferred-both] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-not_deferred-key] PASSED
test/orm/declarative/test_typed_mapping.py::MappedColumnTest::test_separate_name[use_add_property-not_deferred-name] PASSED

Change-Id: Idde87632581ee69e0f47360966758583dfd8baab

2 years agoAdd new script to sync test files adding future annotation
Federico Caselli [Sat, 26 Nov 2022 18:24:49 +0000 (19:24 +0100)] 
Add new script to sync test files adding future annotation

Create a new test file test_tm_future_annotations_sync.py that's obtained
from test_tm_future_annotations.py by using the new script sync_test_files.
This files includes the ``from __future__ import annotations``

It also turns out we had some bugs in there and we can also support some
additional typing things

Change-Id: Iac005df206d45a55345d9d88d67a80ce799d449f

2 years agosort for addresess relationship in new merge test
Mike Bayer [Sat, 26 Nov 2022 15:14:02 +0000 (10:14 -0500)] 
sort for addresess relationship in new merge test

saw a random failure under py2 on 1.4, will backport

Change-Id: I3e2b037bf4211be44e28f85f5e51ffdc218eeb5a

2 years agoMerge "assert unique constraints received back" into main
mike bayer [Sat, 26 Nov 2022 02:32:20 +0000 (02:32 +0000)] 
Merge "assert unique constraints received back" into main

2 years agoimprove column targeting issues with query_expression
Mike Bayer [Fri, 25 Nov 2022 21:49:28 +0000 (16:49 -0500)] 
improve column targeting issues with query_expression

Fixed issues in :func:`_orm.with_expression` where expressions that were
composed of columns within a subquery being SELECTed from, or when using
``.from_statement()``, would not render correct SQL **if** the expression
had a label name that matched the attribute which used
:func:`_orm.query_expression`, even when :func:`_orm.query_expression` had
no default expression. For the moment, if the :func:`_orm.query_expression`
**does** have a default expression, that label name is still used for that
default, and an additional label with the same name will be ignored.
Overall, this case is pretty thorny so further adjustments might be
warranted.

Fixes: #8881
Change-Id: Ie939b1470cb2e824717384be65f4cd8edd619942

2 years agoadd "merge" to viewonly cascades; propagate NO_RAISE when merging
Mike Bayer [Wed, 23 Nov 2022 15:58:28 +0000 (10:58 -0500)] 
add "merge" to viewonly cascades; propagate NO_RAISE when merging

Fixed bug where :meth:`_orm.Session.merge` would fail to preserve the
current loaded contents of relationship attributes that were indicated with
the :paramref:`_orm.relationship.viewonly` parameter, thus defeating
strategies that use :meth:`_orm.Session.merge` to pull fully loaded objects
from caches and other similar techniques. In a related change, fixed issue
where an object that contains a loaded relationship that was nonetheless
configured as ``lazy='raise'`` on the mapping would fail when passed to
:meth:`_orm.Session.merge`; checks for "raise" are now suspended within
the merge process assuming the :paramref:`_orm.Session.merge.load`
parameter remains at its default of ``True``.

Overall, this is a behavioral adjustment to a change introduced in the 1.4
series as of :ticket:`4994`, which took "merge" out of the set of cascades
applied by default to "viewonly" relationships. As "viewonly" relationships
aren't persisted under any circumstances, allowing their contents to
transfer during "merge" does not impact the persistence behavior of the
target object. This allows :meth:`_orm.Session.merge` to correctly suit one
of its use cases, that of adding objects to a :class:`.Session` that were
loaded elsewhere, often for the purposes of restoring from a cache.

Fixes: #8862
Change-Id: I8731c7810460e6a71f8bf5e8ded59142b9b02956

2 years agoassert unique constraints received back
Mike Bayer [Thu, 24 Nov 2022 14:52:12 +0000 (09:52 -0500)] 
assert unique constraints received back

in #8867 we can see our existing uq reflection test is
broken, not detecting a failure to detect constraints

Change-Id: Icada02bc0547c5a3d8c471b80a78a2e72f02647d

2 years agoflake8 has very courteously referred us to another pyqca project and closed all comme...
Mike Bayer [Wed, 23 Nov 2022 22:44:30 +0000 (17:44 -0500)] 
flake8 has very courteously referred us to another pyqca project and closed all comments, thank you!  I'll get on that right away

pyqca/flake8-import-order does not seem to have a release or a commit
in the past two years, so while I have created an issue and PR [1] [2],
for now vendor our fork so we can get on with things.

Also fix one issue for flake8 6.0

[1] https://github.com/PyCQA/flake8-import-order/issues/189
[2] https://github.com/PyCQA/flake8-import-order/pull/190

Change-Id: I53045f65b8716cceaf2104fccc1d26f80b398fef
References: https://github.com/PyCQA/flake8/issues/1751

2 years agoimprove docs for event listening with asyncio
Mike Bayer [Wed, 23 Nov 2022 18:08:59 +0000 (13:08 -0500)] 
improve docs for event listening with asyncio

add examples, including how to listen on an async_sessionmaker

Change-Id: I1d68324458c23bc830508c8ebfd3224d434c16a5

2 years agoMerge "ensure implicit_returning is checked on a Table instance" into main
mike bayer [Tue, 22 Nov 2022 23:30:36 +0000 (23:30 +0000)] 
Merge "ensure implicit_returning is checked on a Table instance" into main

2 years agoensure implicit_returning is checked on a Table instance
Mike Bayer [Wed, 16 Nov 2022 17:45:54 +0000 (12:45 -0500)] 
ensure implicit_returning is checked on a Table instance

Fixed regression where flushing a mapped class that's mapped against a
subquery, such as a direct mapping or some forms of concrete table
inheritance, would fail if the :paramref:`_orm.Mapper.eager_defaults`
parameter were used.

mapper.local_table can still be a non-table instance.
correct the check first added in 466ed5b53a3.

Fixes: #8812
Change-Id: I1bb2b83c31b910fbd96fcd3ac43e789b657aebf7

2 years agoMerge "Type annotations for sqlalchemy.ext.mutable" into main
mike bayer [Tue, 22 Nov 2022 16:42:45 +0000 (16:42 +0000)] 
Merge "Type annotations for sqlalchemy.ext.mutable" into main

2 years agoMerge "fix optionalized forms for dict[]" into main
mike bayer [Tue, 22 Nov 2022 16:07:49 +0000 (16:07 +0000)] 
Merge "fix optionalized forms for dict[]" into main

2 years agoType annotations for sqlalchemy.ext.mutable
Gleb Kisenkov [Wed, 16 Nov 2022 15:23:06 +0000 (10:23 -0500)] 
Type annotations for sqlalchemy.ext.mutable

The ``sqlalchemy.ext.mutable`` extension is now fully pep-484 typed. Huge
thanks to Gleb Kisenkov for their efforts on this.

Fixes: #8667
Closes: #8775
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8775
Pull-request-sha: b907888ec67facc12dbdbccd6f2d9cd533b08a50

Change-Id: Id9224e03201e6970b1ec56eb546ece4b2f3e0edd

2 years agofix optionalized forms for dict[]
Mike Bayer [Mon, 21 Nov 2022 14:46:43 +0000 (09:46 -0500)] 
fix optionalized forms for dict[]

Fixed a suite of issues involving :class:`.Mapped` use with dictionary
types, such as ``Mapped[dict[str, str] | None]``, would not be correctly
interpreted in Declarative ORM mappings. Support to correctly
"de-optionalize" this type including for lookup in type_annotation_map has
been fixed.

Fixes: #8777
Change-Id: Iaba90791dea341d00eaff788d40b0a4e48dab02e

2 years agoAdd security warning to serializer extension
Federico Caselli [Mon, 21 Nov 2022 23:07:53 +0000 (00:07 +0100)] 
Add security warning to serializer extension

Change-Id: I5c7c076bc93fc250c05f7996e83359d19d1f3214

2 years agoMerge "Fix inferred type of async_sessionmaker" into main
mike bayer [Mon, 21 Nov 2022 21:24:11 +0000 (21:24 +0000)] 
Merge "Fix inferred type of async_sessionmaker" into main

2 years agoMerge "add common base class for all SQL col expression objects" into main
mike bayer [Mon, 21 Nov 2022 21:23:12 +0000 (21:23 +0000)] 
Merge "add common base class for all SQL col expression objects" into main