]> git.ipfire.org Git - thirdparty/open-vm-tools.git/log
thirdparty/open-vm-tools.git
6 years agoDue to a quirk the way patches were generated, the 'coomon-agent' directory was not...
Oliver Kurth [Fri, 30 Aug 2019 00:13:05 +0000 (17:13 -0700)] 
Due to a quirk the way patches were generated, the 'coomon-agent' directory was not removed as intended, but just contained empty files

6 years agotools.conf example: add vss.disableAppQuiescing
Oliver Kurth [Thu, 29 Aug 2019 22:47:06 +0000 (15:47 -0700)] 
tools.conf example: add vss.disableAppQuiescing

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Thu, 29 Aug 2019 22:47:06 +0000 (15:47 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoSupporting HGFS large IO/packet size
Oliver Kurth [Thu, 29 Aug 2019 22:47:06 +0000 (15:47 -0700)] 
Supporting HGFS large IO/packet size

Tools side changes to take advantage of a negotiated larger HGFS IO
buffer when available in the Fusion or Workstation host.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Thu, 29 Aug 2019 22:47:05 +0000 (15:47 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years ago[OVT] Update copyright year to 2019.
Oliver Kurth [Thu, 29 Aug 2019 22:47:04 +0000 (15:47 -0700)] 
[OVT] Update copyright year to 2019.

A new version of VMware Tools 11.0.0 will be released in 2019.  All
applicable files need to stamped with a 2019 copyright year.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoTrack recent VMware Tools version numbers used for 10.3.x patches
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Track recent VMware Tools version numbers used for 10.3.x patches

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoMore Coverity annotations for open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
More Coverity annotations for open-vm-tools.

Add Coverity annotations for four additional issues so that Coverity
scans of open-vm-tools will automatically classify these issues as
"intentional."  Such annotations are useful both for internal use as
well as for partners who run Coverity scans of open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFlipped the default value of config option "hgfs.packetSize.large" to TRUE
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Flipped the default value of config option "hgfs.packetSize.large" to TRUE

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:38 +0000 (12:55 -0700)] 
Common header file change not directly applicable to open-vm-tools.

6 years agoAdd more Coverity annotations to open-vm-tools source.
Oliver Kurth [Tue, 27 Aug 2019 19:55:37 +0000 (12:55 -0700)] 
Add more Coverity annotations to open-vm-tools source.

Add Coverity annotations for three issues so that Coverity scans of
open-vm-tools will automatically classify these issues as
"Intentional."  These annotations are useful both for internal
use as well as for partners who run Coverity scans on open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools
Oliver Kurth [Tue, 27 Aug 2019 19:55:37 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools

6 years agoGet rid of PhysMem's thread registration calls for most threads.
Oliver Kurth [Tue, 27 Aug 2019 19:55:37 +0000 (12:55 -0700)] 
Get rid of PhysMem's thread registration calls for most threads.

A previous change eliminated the need to register threads before doing
a PPN to BPN conversion on them.  This change removes some of the
remaining infrastructure.

6 years agoAddress Coverity issues reported in bora/lib/file/file.c.
Oliver Kurth [Tue, 27 Aug 2019 19:55:37 +0000 (12:55 -0700)] 
Address Coverity issues reported in bora/lib/file/file.c.

Fix a minor memory leak in the function File_ExpandAndCheckDir.
Also add annotations for unchecked return values in functions
GetOldMachineID and File_MoveTree, so that Coverity scans of
open-vm-tools will automatically classify these issues as
"Intentional".  These annotations are useful both for internal
use as well as for partners who run Coverity scans on open-vm-tools.

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
Common header file change not directly applicable to open-vm-tools.

6 years agoDo not treat AsyncSocketState as a boolean
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
Do not treat AsyncSocketState as a boolean

AsyncSocketState is an enum.  Storing it into boolean
results in unexpected and undefined behavior.

6 years agoBool type may not be a char (1 bytes).
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
Bool type may not be a char (1 bytes).

Change structures exposed to the guest to not use Bool -
 - while currently Bool is defined as char, we might use C's
   _Bool or C++'s bool for booleans - and neither standard
   mandates _Bool/bool to be 1 byte.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoopen-vm-tools: add vm_valgrind.h
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
open-vm-tools: add vm_valgrind.h

To build open-vm-tools with valgrind enabled we need this file.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Tue, 27 Aug 2019 19:55:36 +0000 (12:55 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoAdd Coverity annotations.
Oliver Kurth [Tue, 27 Aug 2019 19:55:35 +0000 (12:55 -0700)] 
Add Coverity annotations.

Add source code annotations so that Coverity scans will automatically
classify certain issues as "intentional."  These annotations serve to
memorialize these classifications in open-vm-tools source, both for
internal reference as well as for partners like Red Hat who run their
own Coverity scans on open-vm-tools.

6 years agoEnable the guest OS disk mapping feature as default.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Enable the guest OS disk mapping feature as default.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFix broken command: vmtoolsd --cmd info-get | info-set
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Fix broken command: vmtoolsd --cmd info-get | info-set

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoBumping HGFS_LARGE_IO_MAX_PAGES to 127 and defining the legacy values
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Bumping HGFS_LARGE_IO_MAX_PAGES to 127 and defining the legacy values

This change bumps up HGFS_LARGE_IO_MAX_PAGES to 127 and define the
legacy values of HGFS_LARGE_IO_MAX_PAGES, HGFS_LARGE_IO_MAX and
HGFS_LARGE_PACKET_MAX.  A switch is also added to make sure we still
use the legacy value unless "hgfs.packetSize.large" is set to "TRUE" in vmx.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFix crash in nicinfo/nicInfoPosix.c:PrintResolverNSInfo
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Fix crash in nicinfo/nicInfoPosix.c:PrintResolverNSInfo

SIGSEGV trying to access resp->_u._ext.nsaddrs[i]->sin6_family in
PrintResolverNSInfo.

Fix: zero out the struct __res_state memory before calling res_ninit().

6 years agoChanges to common source files not directly applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

Backout previous changes to these files.

6 years agoChanges to common source files not directly applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

6 years agoAvoid freezing mount points for same device.
Oliver Kurth [Fri, 2 Aug 2019 18:07:21 +0000 (11:07 -0700)] 
Avoid freezing mount points for same device.

Loopback device setup could cause a cyclic dependency
between 2 mount points. In order to break the cycle,
avoid freezing the mount points to the same device.

This change also skips some system mount points for 'tmpfs'
and 'cgroup' etc as those share the same device/FS name.
This is fine because we can't quiese those mount points
anyway (system mount points don't support quiescing).

6 years agoConvert linux to __linux__ in preprocessor statements.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Convert linux to __linux__ in preprocessor statements.

Linux ABI uses __linux__, not linux (deprecated).

6 years agoAdd RpcChannel_SendOneRawPriv()
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Add RpcChannel_SendOneRawPriv()

Send privileged guest RPC "guestStore.connect" with it after the
vmsvc RPC channel falls back to backdoor.

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not directly applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoAdd an example configuration tools.conf file for tools
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Add an example configuration tools.conf file for tools

This adds an example tools.conf file. Settings are shown in the
file with default values, but commented out with documentation.

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not directly applicable to open-vm-tools.

6 years agoConvert linux to __linux__ in preprocessor statements.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Convert linux to __linux__ in preprocessor statements.

Linux ABI uses __linux__, not linux (deprecated).

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoRemove residual data when the DNS nameserver configuration changes.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Remove residual data when the DNS nameserver configuration changes.

If the list of DNS nameservers available should shorten or both IPv4 and
IPv6 entries are present, residual data can still be available for display.
This change to nicInfoPosix.c corrects the problem.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:20 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoConvert linux to __linux__ in preprocessor statements.
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Convert linux to __linux__ in preprocessor statements.

Linux ABI uses __linux__, not linux (deprecated).

6 years agoFix gcc 9.1 build error in vmblocktest.c
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Fix gcc 9.1 build error in vmblocktest.c

GCC 9.1 in Ubuntu eoan (19.10) failed to build open-vm-tools:
error: '__builtin_strncpy' specified bound 4096 equals destination
size [-Werror=stringop-truncation]

6 years agoFix two issues reported by Coverity in vixTools.c:
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Fix two issues reported by Coverity in vixTools.c:

 - a superfluous NULL pointer check in VixToolsRunScript
 - a potential NULL pointer dereference in VixToolsValidateCredentials

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 2 Aug 2019 18:07:19 +0000 (11:07 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years ago[TOOLS] Fix dnd text from Linux guest
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
[TOOLS] Fix dnd text from Linux guest

Gtk::Widget::drag_dest_find_target() returns different values from GDK_NONE
on Gtk2 and Gtk3.

On Gtk2, it returns an empty string. It matches the existing code.
On Gtk3, it returns "NONE". The current logic breaks.

To overcome this issue, use Gdk::AtomString::to_cpp_type(GDK_NONE) to
replace the current empty string. This works on both Gtk2 and Gtk3.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoRecord VMware Tools version 10.3.20 as TOOLS_VERSION_JACKHAMMER_UPDATE3
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Record VMware Tools version 10.3.20 as TOOLS_VERSION_JACKHAMMER_UPDATE3

6 years agoChanges to common header files not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Changes to common header files not applicable to open-vm-tools.

6 years agoBump the development version of tools to 11.1.0.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Bump the development version of tools to 11.1.0.

6 years agoNo JSON disk array termination needed, if partition count is zero.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
No JSON disk array termination needed, if partition count is zero.

In the unlikely case of a VM with zero disks, a jsonPerDiskFmtFooterLast
should not be emitted.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:20 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoPartial change linux -> __linux__, Tools edition
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Partial change linux -> __linux__, Tools edition

Linux ABI uses __linux__, not linux (deprecated).

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFix the memory leak in procMgr library.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Fix the memory leak in procMgr library.

In a specific code path, procCmdAbsPath attribute is ovewritten
with the new memory. This leads to a memory leak for the previously
allocated memory.

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Common header file change not directly applicable to open-vm-tools.

6 years agoMake DEBUG_ONLY work with toplevel commas (Change part 3)
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Make DEBUG_ONLY work with toplevel commas (Change part 3)

Now that all the C pre-processors in use support variadic macros, make
DEBUG_ONLY work with toplevel commas (i.e. commas which are outside of
any parentheses pair). This is useful in at least 2 ways:

In C code, to easily pass debug arguments to functions in debug builds
without any overhead in non-debug builds.

  void
  foo(DEBUG_ONLY(int debugArg,) // IN
  int nonDebugArg)          // IN
  {
  ASSERT(DebugFunc(debugArg));
  NonDebugFunc(nonDebugArg);
  }

  foo(DEBUG_ONLY(debugArg,) nonDebugArg);

In asm code.

  DEBUG_ONLY(mov x0, #0)

6 years agoUse two new inline functions to replace most of the uses of
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Use two new inline functions to replace most of the uses of
HGFS_LARGE_IO_MAX and HGFS_LARGE_PACKET_MAX macros.

In preparation to bump up HGFS_LARGE_IO_MAX and HGFS_LARGE_PACKET_MAX,
replace most uses of the two macro constants with inline functions that
can return either the new limits or the older defaults based on the
configuration.

6 years ago[Tools/dndcp] Fix two coverity issues reported by a customer.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
[Tools/dndcp] Fix two coverity issues reported by a customer.

6 years agoUpdate VMware Tools version numbers for historical information.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Update VMware Tools version numbers for historical information.

6 years agoLOG variadic: Part 2
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
LOG variadic: Part 2

- do/while blocks removed.
- LogLevel_LookUpVar removed.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFix return value in AsyncTCPSocketDoOneMsg
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
Fix return value in AsyncTCPSocketDoOneMsg

Trivial fix to a bug in AsyncTCPSocketDoOneMsg where ASOCKERR_SUCCESS is
returned inadvertently instead of ASOCKERR_TIMEOUT when there is a timeout.

6 years agoGuestInfo: fix memory leak in GuestInfoGetPrimaryIP()
Oliver Kurth [Sun, 21 Jul 2019 00:15:19 +0000 (17:15 -0700)] 
GuestInfo: fix memory leak in GuestInfoGetPrimaryIP()

"ipstr" was not free'ed when it was not being used.

6 years agoAdd definition for "debian11" and "debian11-64" to vmx.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Add definition for "debian11" and "debian11-64" to vmx.

6 years agoAvoid emitting a trailing comma in the GuestInfoSendDiskInfoV1 JSON RPC
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Avoid emitting a trailing comma in the GuestInfoSendDiskInfoV1 JSON RPC

Although currently accepted by the JSMN library that we are using
in VMX, that superfluous comma is strictly invalid according to the
JSON standard - ECMA-404.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoMake LOG macro variadic: do the obviously-safe stuff first
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Make LOG macro variadic: do the obviously-safe stuff first

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoChanges to common source files; not directly applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:18 +0000 (17:15 -0700)] 
Changes to common source files; not directly applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Sun, 21 Jul 2019 00:15:17 +0000 (17:15 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoFix a Coverity issue reported in vgauth/serviceImpl/verify.c
Oliver Kurth [Wed, 3 Jul 2019 21:28:56 +0000 (14:28 -0700)] 
Fix a Coverity issue reported in vgauth/serviceImpl/verify.c

6 years agoFix process command name for special linux processes.
Oliver Kurth [Wed, 3 Jul 2019 21:28:56 +0000 (14:28 -0700)] 
Fix process command name for special linux processes.

While listing down the processes in a linux guest, the existing
procMgr library reads /proc/<PID>/cmdline file and parses the
content.  While reading this, an assumption is made that there is
a null terminating character at the end of the file content.
This holds true for most of the processes.  But for few special processes,
the cmdline file doesn't have the terminating null character.

Proper content from cmdline file:

/usr/lib/systemd/systemd\0--switched-root\0--system\0--deserialize\021\0
/usr/sbin/vmtoolsd\0
sshd: root@pts/2\0\0\0

Example cmdline file where NUL terminator is missing:

avahi-daemon: running [linux.local]
avahi-daemon: chroot helper

6 years agoFix the command name for few linux processes.
Oliver Kurth [Wed, 3 Jul 2019 21:28:56 +0000 (14:28 -0700)] 
Fix the command name for few linux processes.

ProcMgr library publishes the 'command name' attribute for
each process while listing down all the processes.  For doing this,
the commandline is first parsed from /proc/<PID>/cmdline file
and the part starting from the right-most '/' is considered as the
command name.  This is OK only if we have an absolute path for the
command binary.  Other wise, this may result in incorrect results.

For example:
sshd: root@pts/1
gdm-session-worker [pam/gdm-autologin]

Fixed the code to ignore the parsing if we do not have an absolute
path.

Note: There are two ways how the command name is retrieved for each
process.

1. /proc/<PID>/cmdline is parsed.

If (1) fails for some reason, then

2. /proc/<PID>/status is parsed.

There is no issue with (2). This changeset fixes the parsing issue only
with (1) approach mentioned above.

6 years agoAdd support for NVMe disks; IDE and SATA disk devices in 3.x Linux kernels
Oliver Kurth [Wed, 3 Jul 2019 21:28:56 +0000 (14:28 -0700)] 
Add support for NVMe disks; IDE and SATA disk devices in 3.x Linux kernels

Support has been added for virtual disks attached to an NVMe
controller.  The device "label" will provide the "nvme<n>" for the
controller.  The disk unit is provided in the device "nsid" file.
An earlier implementation (Linux 2.6 kernels) provided the unit
number as the final digit group in the device node name.

The Linux 3.x kernel has some differences in the layout of IDE and
SATA disk devices in the sysfs filesystem.  The differences from the
sysfs in a 2.6 Linux kernel are:
 - The IDE "class" file and SATA "class" and "label" files are in a
   different directory.
 - IDE controller and SATA device nodes begin with "ata" where "host"
   was used in earlier kernel sysfs filesystems.

GuestInfoGetDevClass() has been modfied to check in two possible
locations for the "class" file.   The directory located will also
contain the "label" file for SCSI, SAS, and SATA disk devices.

GuestInfoGetIdeSataDev() has been modified to search for either
ata<n> or host<n> directories in the sysfs tree for the disk device.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoTruncate oversize partition names
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Truncate oversize partition names

Truncate disk partition names if they are too large, rather than just
skipping all the disk information for the guest. Closes
https://github.com/vmware/open-vm-tools/issues/346 .

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoSuppress possible NULL pointer deref in a debug message.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Suppress possible NULL pointer deref in a debug message.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoChanges to common header files not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Changes to common header files not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:55 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:54 +0000 (14:26 -0700)] 
Common header file change not applicable to open-vm-tools.

6 years agoCommon header file change not directly applicable to open-vm-tools.
Oliver Kurth [Wed, 3 Jul 2019 21:26:54 +0000 (14:26 -0700)] 
Common header file change not directly applicable to open-vm-tools.