]>
git.ipfire.org Git - thirdparty/suricata.git/log
Juliana Fajardini [Mon, 24 Oct 2022 00:58:42 +0000 (21:58 -0300)]
pgsql: add test for parameter status parser
Since we've done some changes to how the parameters are parsed, add one
more test case to check that.
Bug #5579
Juliana Fajardini [Wed, 7 Sep 2022 19:41:48 +0000 (16:41 -0300)]
pgsql: move database into opt parameters list
For StartupMessages, the database parameter is optional. This moves the
parameter into the optional_parameters list.
Bug #5579
Juliana Fajardini [Wed, 7 Sep 2022 18:52:42 +0000 (15:52 -0300)]
eve/schema: pgsql - allow flexible parameters list
Pgsql's parameters - for message types like StartupMessage and
ParameterStatus, for instance, don't have a finite, definitive set, as
per their documentation. Our json schema was allow expecting a fixed set
of parameters, though, resulting in SV tests failing if different, valid
parameters appeared.
Bug #5579
Philippe Antoine [Fri, 26 Aug 2022 12:02:16 +0000 (14:02 +0200)]
pgsql: support empty parameter values
Bug #5579
Philippe Antoine [Fri, 26 Aug 2022 12:00:40 +0000 (14:00 +0200)]
pgsql: support out of order parameters for startup message
As user can be not the first parameter
Bug #5579
Alice Akaki [Sat, 22 Oct 2022 17:07:04 +0000 (13:07 -0400)]
detect-icmp-id: convert unittests to FAIL/PASS APIs
Task: #4042
Haleema Khan [Fri, 21 Oct 2022 02:16:45 +0000 (07:16 +0500)]
detect-itype: Convert unittests to new FAIL/PASS API
Bug: #5589
dependabot[bot] [Thu, 13 Oct 2022 19:33:12 +0000 (19:33 +0000)]
github-actions: bump actions/cache from 3.0.10 to 3.0.11
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.10 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.10...
9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7 )
---
updated-dependencies:
- dependency-name: actions/cache
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Simeon Miteff [Wed, 28 Sep 2022 23:38:07 +0000 (09:38 +1000)]
profiling: Make rule_perf.log JSON output newline-delimited
Adding a newline makes the output valid JSON when multiple sortings of
the rules profile object are written to the log.
Jeff Lucovsky [Sat, 22 Oct 2022 16:59:22 +0000 (12:59 -0400)]
doc/netmap: Describe Netmap IPS usage
Issue: 5512
This commit summarizes Netmap usage with Suricata's IPS mode.
Jason Ish [Tue, 13 Sep 2022 15:36:01 +0000 (09:36 -0600)]
doc/userguide: update bittorrent-dht eve examples
Update the bittorrent-dht examples using real log records with peers
and nodes broken down into objects.
Jason Ish [Thu, 8 Sep 2022 18:08:26 +0000 (12:08 -0600)]
eve/schema: bittorrent-dht updates
Some values that were previously strings are now parsed down into
objects.
Jason Ish [Thu, 8 Sep 2022 17:15:38 +0000 (11:15 -0600)]
bittorrent-dht: parse and log node6 lists
Node6 lists are just like node lists, but for IPv6 addresses.
Jason Ish [Thu, 8 Sep 2022 18:39:31 +0000 (12:39 -0600)]
bittorrent-dht: remove tests that are no longer valid
Jason Ish [Thu, 8 Sep 2022 16:42:15 +0000 (10:42 -0600)]
bittorrent-dht: fix values decoding, as a list of peers
The "values" field is not a string, but instead peer information in
compact format. Decode this properly and then properly format in the
log.
Jason Ish [Thu, 8 Sep 2022 16:41:10 +0000 (10:41 -0600)]
jsonbuilder: add append_hex - add hex to array
New method, append_hex to add a byte array to a JSON array in hex
encoding.
Jason Ish [Thu, 8 Sep 2022 14:59:11 +0000 (08:59 -0600)]
bittorrent-dht: parse token and target as byte values
Jason Ish [Wed, 7 Sep 2022 22:46:20 +0000 (16:46 -0600)]
bittorrent-dht: only attempt to parse dht messages
The bittorrent flow is shared with transport messages as well as dht
messages. Only attempt to parse dht message as dht, ignore the rest.
Jason Ish [Wed, 7 Sep 2022 14:51:28 +0000 (08:51 -0600)]
bittorrent-dht: decode node data structures
Instead of decoding the nodes field into a blog of bytes, decode it into
an array of node info objects, each with a node id, IP address and port.
Jason Ish [Wed, 17 Aug 2022 23:20:00 +0000 (17:20 -0600)]
bittorrent-dht: convert some fields to byte arrays
Some fields that were previously strings are not always value UTF-8
data, instead the protocol specification refers to them as strings of
bytes, so in other words byte arrays.
Currently fields converted are:
- client_version
- info_hash
- response.id
- request.id
- nodes
- token
Jason Ish [Fri, 12 Aug 2022 16:30:00 +0000 (10:30 -0600)]
doc: rename bittorrent-dht to bittorrent_dht in eve output
Jason Ish [Fri, 12 Aug 2022 16:27:45 +0000 (10:27 -0600)]
bittorrent-dht/eve: log as bittorrent_dht
Jason Ish [Fri, 12 Aug 2022 16:03:58 +0000 (10:03 -0600)]
eve-schema: add bittorrent-dht
Jason Ish [Wed, 10 Aug 2022 23:06:51 +0000 (17:06 -0600)]
bittorrent-dht: register a pattern for protocol detection
Removes the port based probing which takes a long time to register for
ports 1024-65535 and instead use pattern based protocol detection.
Jason Ish [Wed, 10 Aug 2022 17:49:06 +0000 (11:49 -0600)]
bittorrent-dht: set parser to unidirectional
This parser does not match up responses with requests so flag it as
unidirectional.
Jason Ish [Wed, 10 Aug 2022 17:42:42 +0000 (11:42 -0600)]
userguide/eve-log: remove mentions of requiring Rust
Rust is required to build now.
Jason Ish [Wed, 10 Aug 2022 15:49:19 +0000 (09:49 -0600)]
bittorrent: updates for new event handling
Fixes anomaly events.
Aaron Bungay [Fri, 12 Feb 2021 01:22:11 +0000 (01:22 +0000)]
docs: update for bittorrent-dht app-layer
Aaron Bungay [Fri, 5 Jun 2020 04:17:36 +0000 (00:17 -0400)]
bittorrent-dht: add bittorrent-dht app layer
Parses and logs the bittorrent-dht protocol.
Note: Includes some compilation fixups after rebase by Jason Ish.
Feature: #3086
Jason Ish [Thu, 13 Oct 2022 21:51:10 +0000 (15:51 -0600)]
dnp3: fixups to work with unified json tx logger
Update DNP3 to work with a single TX logger, and just register one
logger instead of 2.
This primarily creates a TX per message instead of correlating replies
to requests, which fits the DNP3 model better, but we didn't really have
this concept nailed down when DNP3 was written.
Victor Julien [Thu, 27 Oct 2022 11:00:25 +0000 (13:00 +0200)]
dpdk: set new running flag at thread startup
Victor Julien [Thu, 27 Oct 2022 10:17:11 +0000 (12:17 +0200)]
threads: count thread types after all initialized
To avoid double counting in case a thread took longer than
expected to start up.
Alice Akaki [Tue, 25 Oct 2022 19:41:56 +0000 (15:41 -0400)]
detect-icmp-seq: convert unittests to FAIL/PASS APIs
Task: #4043
Haleema Khan [Sat, 15 Oct 2022 04:17:42 +0000 (09:17 +0500)]
dns/eve: add 'HTTPS' type logging
Add a new DNS record type to represent HTTPS
Ticket: #4751
Haleema Khan [Mon, 24 Oct 2022 15:39:08 +0000 (20:39 +0500)]
detect-itype: remove unittests
Ticket: #5590
Gabriel Lima Luz [Mon, 24 Oct 2022 14:04:31 +0000 (11:04 -0300)]
detect-replace: Convert unittests to FAIL/PASS API
Ticket: 4054
Philippe Antoine [Fri, 13 May 2022 12:52:06 +0000 (14:52 +0200)]
security: prevents process creation
with setrlimit NPROC.
So that, if Suricata wants to execve or such to create a new process
the OS will forbid it so that RCE exploits are more painful to write.
Ticket: #5373
Jason Ish [Thu, 13 Oct 2022 15:06:11 +0000 (09:06 -0600)]
profiling: sort LoggerId's in same order as defined
Sort the LoggerId's in the order they are define in suricata-common.h.
Jason Ish [Wed, 5 Oct 2022 21:06:53 +0000 (15:06 -0600)]
loggers: all json tx loggers can share the same loggerid
This is to avoid the tx logging code that doesn't support LoggerId
values over 31 at this time. The simplest fix for now is to just have
all JSON (eve) loggers use the same ID.
DNP3 is left as-is for now as it needs some extra support in the parser.
Richard McConnell [Tue, 4 Oct 2022 16:18:05 +0000 (17:18 +0100)]
workflow: add systemd integration and check
Intergration of systemd is a feature that enables notification of
a running service to the service manager. The workflow now ensures
compilation with systemd and checks the binary has been built against
libsystemd.
Richard McConnell [Tue, 4 Oct 2022 16:16:40 +0000 (17:16 +0100)]
doc/systemd: add documentation for sd_notify
Richard McConnell [Tue, 4 Oct 2022 16:15:21 +0000 (17:15 +0100)]
suricata: add sd_notify support
Upon all threads reaching a running state the system generates
a notification for systems running and configured for systemd
Implements feature 5384
(https://redmine.openinfosecfoundation.org/issues/5384)
Richard McConnell [Tue, 4 Oct 2022 16:13:01 +0000 (17:13 +0100)]
source: add THV_RUNNING flag to notify of running state
Each module (thread) updates its status to indicate running.
Main thread awaits for all threads to be in a running state
before continuing the initialisation process
Implements feature 5384
(https://redmine.openinfosecfoundation.org/issues/5384)
Eric Leblond [Mon, 22 Aug 2022 21:46:01 +0000 (23:46 +0200)]
doc: add reference to ipaddr in IP matching
Eric Leblond [Fri, 15 Jul 2022 10:33:09 +0000 (12:33 +0200)]
datasets: don't exit on invalid data
Eric Leblond [Sun, 10 Jul 2022 18:31:00 +0000 (20:31 +0200)]
detect: doc link for ip.src and ip.dst
Eric Leblond [Sun, 10 Jul 2022 17:05:18 +0000 (19:05 +0200)]
doc: add ip.dst and ip.src doc
Eric Leblond [Sat, 4 Jun 2022 21:00:14 +0000 (23:00 +0200)]
doc: document new dataset types
Feature: #5383
Eric Leblond [Tue, 31 May 2022 16:53:17 +0000 (18:53 +0200)]
datasets: introduce new IPv6 type
This patch also simplifies IPv6 parsing.
Feature: #5383
Eric Leblond [Tue, 31 May 2022 15:43:24 +0000 (17:43 +0200)]
detect: add ip.dst keyword as sticky buffer
Feature: #5383
Eric Leblond [Sat, 11 Jun 2022 21:28:37 +0000 (23:28 +0200)]
detect: add ip.src keyword
It is a sticky buffer matching on src_ip.
Feature: #5383
Eric Leblond [Sun, 15 May 2022 10:39:01 +0000 (12:39 +0200)]
datasets: introduce ipv4 type
This patch introduce the IPv4 type for dataset so Suricata commandmatch
on a set of IPv4 addresses. This is meant to complement iprep feature
for people that needs more flexibility such as settings the IP on
the packet path.
Feature: #5383
Eric Leblond [Tue, 19 Jan 2021 21:00:54 +0000 (22:00 +0100)]
datasets: factorize serialised operations
Ticket: #5184
Eric Leblond [Mon, 18 Jan 2021 22:41:55 +0000 (23:41 +0100)]
doc: document dataset-lookup
Ticket: #5184
Eric Leblond [Tue, 26 Jan 2021 20:29:07 +0000 (21:29 +0100)]
suricatasc: add dataset-lookup command
Ticket: #5184
Eric Leblond [Mon, 18 Jan 2021 22:39:09 +0000 (23:39 +0100)]
datasets: add dataset-lookup command
Ticket: #5184
Eric Leblond [Mon, 18 Jan 2021 21:55:31 +0000 (22:55 +0100)]
doc: add dataset-clear command
Ticket: #5184
Eric Leblond [Mon, 18 Jan 2021 21:48:47 +0000 (22:48 +0100)]
suricatasc: add dataset-clear command
Ticket: #5184
Eric Leblond [Mon, 18 Jan 2021 21:11:15 +0000 (22:11 +0100)]
datasets: add dataset-clear command
Ticket: #5184
Eric Leblond [Tue, 5 Jan 2021 21:03:52 +0000 (22:03 +0100)]
doc: document dataset-dump command
Ticket: #5184
Eric Leblond [Mon, 28 Dec 2020 23:43:01 +0000 (00:43 +0100)]
datasets: add dump via unix socket
This patch adds a dataset-dump command to the list of unix socket
commands. Implementation is not optimal as we are locking the
datasets when doing the dump. But if we consider that the current
alternative from an implementation point of view is to stop Suricata
then this is far better than current state.
Ticket: #5184
Shivani Bhardwaj [Wed, 26 Oct 2022 11:09:22 +0000 (16:39 +0530)]
release: 7.0.0-beta1; update changelog
Victor Julien [Fri, 21 Oct 2022 19:22:23 +0000 (21:22 +0200)]
packet: turn tunnel lock into spinlock
Lock is only held to update/check ints, so spin lock will be more
efficient.
Place the member of Packet in a new "persistent" area to make it
clear this is not touched by the PacketReinit logic.
Ticket: #5592.
Victor Julien [Tue, 25 Oct 2022 07:21:04 +0000 (09:21 +0200)]
stream/tcp: remove obsolete and commented out tests
Victor Julien [Tue, 25 Oct 2022 07:18:47 +0000 (09:18 +0200)]
decode/vxlan/tests: don't memset new packet
Victor Julien [Tue, 25 Oct 2022 07:16:27 +0000 (09:16 +0200)]
decode/mpls/tests: improve pkt handling; cleanups
Victor Julien [Tue, 25 Oct 2022 07:15:46 +0000 (09:15 +0200)]
app-layer/tests: don't memset new packet
Victor Julien [Tue, 25 Oct 2022 07:07:58 +0000 (09:07 +0200)]
doc/devguide: update packet (de)alloc in unittests
Victor Julien [Tue, 25 Oct 2022 07:05:17 +0000 (09:05 +0200)]
decode/geneve/tests: don't memset packet
Packet is already initialized.
Victor Julien [Sat, 22 Oct 2022 12:33:05 +0000 (14:33 +0200)]
threading: improve/add thread queues explanations
Victor Julien [Fri, 21 Oct 2022 19:21:28 +0000 (21:21 +0200)]
eve/alert: remove tunnel locking
Tunnel lock is only used to sync verdict logic.
Victor Julien [Fri, 21 Oct 2022 18:54:24 +0000 (20:54 +0200)]
decode: alloc packets using calloc
Victor Julien [Fri, 21 Oct 2022 18:53:17 +0000 (20:53 +0200)]
packetpool: remove PKT_ALLOC flag
Use Packet::pool instead. If Packet::pool is non-NULL the packet is
owned by a pool. Otherwise it is allocated and should be freed after
use.
Victor Julien [Fri, 21 Oct 2022 10:05:06 +0000 (12:05 +0200)]
runmodes: remove dead error check
Victor Julien [Fri, 21 Oct 2022 09:38:36 +0000 (11:38 +0200)]
smtp/mime: no error logging in packet path
Victor Julien [Fri, 21 Oct 2022 09:38:10 +0000 (11:38 +0200)]
defrag: no error logging in packet path
Victor Julien [Mon, 24 Oct 2022 18:20:30 +0000 (20:20 +0200)]
applayer: make sure to use correct ipproto
Victor Julien [Mon, 24 Oct 2022 12:28:50 +0000 (14:28 +0200)]
eve/alert: use flow proto to avoid crash on ICMP
Alice Akaki [Sat, 22 Oct 2022 13:30:28 +0000 (09:30 -0400)]
detect-filemd5: convert unittests to FAIL/PASS APIs
Task: #4035
Alice Akaki [Sat, 22 Oct 2022 13:14:23 +0000 (09:14 -0400)]
detect-filesha256: convert unittests to FAIL/PASS APIs
Task: #4038
dependabot[bot] [Fri, 21 Oct 2022 20:00:34 +0000 (20:00 +0000)]
github-actions: bump actions/upload-artifact from 3.1.0 to 3.1.1
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/
3cea5372237819ed00197afe530f5a7ea3e805c8 ...
83fd05a356d7e2593de66fc9913b3002723633cb )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Fri, 21 Oct 2022 20:00:29 +0000 (20:00 +0000)]
github-actions: bump actions/download-artifact from 3.0.0 to 3.0.1
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/
fb598a63ae348fa914e94cd0ff38f362e927b741 ...
9782bd6a9848b53b110e712e20e42d89988822b7 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Alice Akaki [Fri, 14 Oct 2022 04:06:31 +0000 (00:06 -0400)]
rust: fix lint warnings about mixed case hex literals
Ticket: #4593
Gabriel Lima Luz [Fri, 14 Oct 2022 16:17:31 +0000 (13:17 -0300)]
rust: fix lint warnings about if same then else
Ticket: 4609
Kristina Jefferson [Thu, 13 Oct 2022 19:28:15 +0000 (14:28 -0500)]
rust: fix lint warnings about ptr_arg
Ticket: #4599
Jason Ish [Fri, 14 Oct 2022 17:59:20 +0000 (11:59 -0600)]
rust: fix clippy lint for unneeded late initialization
Jason Ish [Fri, 14 Oct 2022 17:54:07 +0000 (11:54 -0600)]
rust: fix clippy lint for cmp_null is debug code
Ticket: 5577
Jason Ish [Fri, 14 Oct 2022 17:42:22 +0000 (11:42 -0600)]
rust: fix clippy lints for unneeded reference in debug code
Jason Ish [Fri, 14 Oct 2022 17:38:20 +0000 (11:38 -0600)]
rust: fix clippy lints for is_empty in debug code
Jason Ish [Thu, 6 Oct 2022 18:23:24 +0000 (12:23 -0600)]
github-ci: running clippy with all features
Without it, it own't see the usage of variables in SCDebugLog macros,
etc.
Jason Ish [Wed, 5 Oct 2022 15:36:45 +0000 (09:36 -0600)]
rust: don't allow fixed up clippy lints
Jason Ish [Wed, 5 Oct 2022 15:30:54 +0000 (09:30 -0600)]
rust: clippy fix for bitwise or with 0
Jason Ish [Wed, 5 Oct 2022 15:07:07 +0000 (09:07 -0600)]
rust: fix clippy lints for clippy::unnecessary_cast
Jason Ish [Wed, 5 Oct 2022 15:06:01 +0000 (09:06 -0600)]
rust: fix clippy lints for clippy::redundant_static_lifetimes
Jason Ish [Wed, 5 Oct 2022 15:05:45 +0000 (09:05 -0600)]
rust: fix clippy lints for clippy::redundant_pattern_matching
Jason Ish [Wed, 5 Oct 2022 15:05:12 +0000 (09:05 -0600)]
rust: fix clippy lints for clippy::nonminimal_bool
Jason Ish [Wed, 5 Oct 2022 15:02:39 +0000 (09:02 -0600)]
rust: fix clippy lints for clippy::map_flatten
Jason Ish [Wed, 5 Oct 2022 15:02:21 +0000 (09:02 -0600)]
rust: fix clippy lints for clippy::manual_find
Jason Ish [Wed, 5 Oct 2022 15:00:21 +0000 (09:00 -0600)]
rust: fix clippy lints for clippy::collapsible_if
Jason Ish [Wed, 5 Oct 2022 15:00:04 +0000 (09:00 -0600)]
rust: fix clippy lints for clippy::collapsible_else_if