]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Aki Tuomi [Tue, 15 Nov 2022 11:44:46 +0000 (13:44 +0200)]
lib: event-filter - Ensure 0 can be matched correctly in filters
Allow matching fields with > 0, priorly this would have always been
treated as string equality / wildcard match, instead we now want
to match it as number. Forgotten in
61cb32860f5237c5d928a7fed8a89f783c2f9b30
This fixes a signal 11 crash with equality comparison with a
non-wildcard value. Broken in
aefe4941c14c6001a9d09fbc3122aca1417d00a8
Aki Tuomi [Tue, 15 Nov 2022 11:22:16 +0000 (13:22 +0200)]
lib: event-filter - Fix matching duration field
If duration field is used in event filter, it cannot be matched
here as no such field exists. We need to actually synthesize the
field here for matching.
Stephan Bosch [Thu, 10 Nov 2022 01:50:02 +0000 (02:50 +0100)]
lib-http: http-url - Make sure url->have_ssl is properly initialized in http_url_request_target_parse().
This fixes the problem that the HTTP server does not yield proper HTTPS urls for
incoming requests.
Aki Tuomi [Wed, 2 Nov 2022 13:56:54 +0000 (15:56 +0200)]
lib-oauth2: jwt - Allow missing 'typ' field
Aki Tuomi [Thu, 28 May 2020 12:05:08 +0000 (15:05 +0300)]
lib-oauth2: test-oauth2-jwt - Ensure we ignore 'none' algorithm
Karl Fleischmann [Fri, 21 Oct 2022 15:32:29 +0000 (17:32 +0200)]
lib-storage: Tolerate but warn about unknown special_use labels
Aki Tuomi [Fri, 4 Nov 2022 10:27:11 +0000 (12:27 +0200)]
lib-ssl-iostream: Do not unref DH parameters too soon
SSL_CTX_set0_tmp_dh_pkey moves references to SSL_CTX which
frees the DH parameters itself.
Broken by
124c491aa688eec146c21718f0d98aec9ae03294
Timo Sirainen [Thu, 3 Nov 2022 15:40:28 +0000 (17:40 +0200)]
dsync: Skip autocreated mailboxes that haven't been created yet
Timo Sirainen [Fri, 4 Nov 2022 12:01:14 +0000 (14:01 +0200)]
imapc: Fix listing INBOX when INBOX is already the namespace prefix
This especially caused problems when using dsync with imapc, resulting in
"Remote lost mailbox GUID" errors.
Dimitry Andric [Wed, 14 Sep 2022 10:26:50 +0000 (12:26 +0200)]
lib-index/test-mail-index-transaction-update.c: Cleanup timezone instances
In
1a7b1f66fe the non-standard extern timezone was partially removed,
but some instances were left. Since the test is supposed to run with
TZ=UTC, and timezone would have been zero anyway, remove them all.
Aki Tuomi [Thu, 3 Nov 2022 11:46:11 +0000 (13:46 +0200)]
lib-dcrypt: Remove pointless else-if
Aki Tuomi [Thu, 3 Nov 2022 11:44:48 +0000 (13:44 +0200)]
lib-dcrypt: Initialize EVP_PKEY when loading JWK key
Satisfies static analysers
Aki Tuomi [Wed, 26 Oct 2022 16:42:17 +0000 (19:42 +0300)]
TODO: Remove mention on GnuTLS
Aki Tuomi [Wed, 26 Oct 2022 12:38:56 +0000 (15:38 +0300)]
m4: ssl.m4 - Drop unused checks
Aki Tuomi [Wed, 26 Oct 2022 11:53:25 +0000 (14:53 +0300)]
lib-crypto: Slightly reformat test-crypto.c
Aki Tuomi [Wed, 26 Oct 2022 09:21:59 +0000 (12:21 +0300)]
lib-dcrypt: Add OpenSSLv3 support
Aki Tuomi [Wed, 26 Oct 2022 09:20:58 +0000 (12:20 +0300)]
lib-dcrypt: test-crypto - Allow newline at end of PEM output
Aki Tuomi [Wed, 26 Oct 2022 09:18:52 +0000 (12:18 +0300)]
lib-dcrypt: test-crypto - Add missing x9.62 roundtrip test
Aki Tuomi [Wed, 26 Oct 2022 09:15:47 +0000 (12:15 +0300)]
lib-dcrypt: Rename dcrypt-openssl.c to dcrypt-openssl1.c
Aki Tuomi [Tue, 1 Nov 2022 11:11:28 +0000 (13:11 +0200)]
lib-dcrypt: Add asserts to key ID and Usage accessors
Aki Tuomi [Tue, 1 Nov 2022 10:55:36 +0000 (12:55 +0200)]
lib-dcrypt: Make error_r required
Aki Tuomi [Tue, 1 Nov 2022 10:54:11 +0000 (12:54 +0200)]
global: Call dcrypt always with error_r
Aki Tuomi [Tue, 1 Nov 2022 11:02:22 +0000 (13:02 +0200)]
lib-dcrytp: istream-decrypt - Report DER decoding issues
Fixes possibility of DER object decode error being reported
as truncation.
Aki Tuomi [Tue, 1 Nov 2022 10:29:40 +0000 (12:29 +0200)]
lib-dcrypt: Improve OpenSSL error handling
Will now try to get the error more thoroughly and handles out of memory
correctly.
Aki Tuomi [Mon, 24 Oct 2022 11:05:46 +0000 (14:05 +0300)]
lib-ssl-iostream: Fix compability with OpenSSL 3.0
Aki Tuomi [Mon, 31 Oct 2022 09:08:49 +0000 (11:08 +0200)]
lib-ssl-iostream: Do not attempt to load empty DH parameters
OpenSSL3 complains about empty DH parameters.
Aki Tuomi [Mon, 31 Oct 2022 09:00:43 +0000 (11:00 +0200)]
lib-ssl-iostream: Use EVP_PKEY to wrap DH parameters
Simplifies OpenSSL 3.0 compability
Aki Tuomi [Mon, 31 Oct 2022 08:59:29 +0000 (10:59 +0200)]
lib-ssl-iostream: Remove support for pre-1.0.2 OpenSSL
Aki Tuomi [Mon, 24 Oct 2022 11:05:16 +0000 (14:05 +0300)]
m4: Update ssl.m4
Aki Tuomi [Wed, 26 Oct 2022 16:25:37 +0000 (19:25 +0300)]
lib-ssl-iostream: Add test DH parameters
Timo Sirainen [Tue, 1 Nov 2022 09:23:44 +0000 (11:23 +0200)]
replicator: Fix crash when removing user from queue and debug logging is enabled
Broken by
4b5337667cea6dea3d684540ee79f26292f9b42d
Timo Sirainen [Tue, 1 Nov 2022 09:21:34 +0000 (11:21 +0200)]
replicator: Fix crash when importing user not listed by userdb iteration
Broken by
31545b4f38ea85615f0111a33d630a03d92d22ab
Timo Sirainen [Mon, 31 Oct 2022 20:39:25 +0000 (22:39 +0200)]
dsync: ns_mailbox_try_alloc() - Don't set errstr_r when mailbox wasn't found
It's unnecessary and confusing, since the callers can't really use it
anyway.
Timo Sirainen [Mon, 31 Oct 2022 20:37:34 +0000 (22:37 +0200)]
dsync: Revert logging a more detailed reason why mailbox was lost
This code can't actually work, because the mailbox allocation is attempted
in multiple namespaces. The error would just come from the last namespace,
which might not have been the correct one.
Reverts
cdf981514af4eb8af5a459d8e68bed2cccd7f37c
Timo Sirainen [Fri, 28 Oct 2022 10:00:03 +0000 (13:00 +0300)]
dsync: Remove unnecessary DSYNC_MAILBOX_IMPORT_FLAG_DEBUG
The debug status comes from the parent event.
Timo Sirainen [Fri, 28 Oct 2022 09:58:56 +0000 (12:58 +0300)]
dsync: Remove unnecessary DSYNC_MAILBOX_TREES_SYNC_FLAG_DEBUG
The debug status comes from the parent event.
Timo Sirainen [Fri, 28 Oct 2022 09:58:43 +0000 (12:58 +0300)]
dsync: Use event_want_debug() rather than checking for debug flag
Timo Sirainen [Fri, 28 Oct 2022 09:57:13 +0000 (12:57 +0300)]
dsync: Remove unused DSYNC_MAILBOX_TREES_SYNC_FLAG_MASTER_BRAIN
Timo Sirainen [Thu, 27 Oct 2022 22:17:48 +0000 (01:17 +0300)]
dsync: Remove duplicate "brain" log prefix
Broken by
3ddb802f3e6faaac4fbeae1b33043bf0046138f4
Timo Sirainen [Thu, 27 Oct 2022 21:56:29 +0000 (00:56 +0300)]
maildir: If mailbox create fails, don't try to apply mailbox_update changes
This was especially causing problems with mailbox GUID mismatches in dsync.
The mismatch wasn't automatically fixed, because mailbox_create() incorrectly
kept updating the mailbox GUID for the already existing mailbox.
Fixes errors such as:
Remote lost mailbox GUID ... (maybe it was just deleted?)
Timo Sirainen [Thu, 27 Oct 2022 22:21:48 +0000 (01:21 +0300)]
dsync: Log a more detailed reason why mailbox was lost
Although usually the reason is just that it wasn't found.
Timo Sirainen [Thu, 27 Oct 2022 22:20:43 +0000 (01:20 +0300)]
doveadm-server: Log dsync's "desync" message with debug level
Previously this was logged only by the CLI doveadm tool as a warning.
Timo Sirainen [Thu, 27 Oct 2022 19:45:24 +0000 (22:45 +0300)]
replicator: Log dsync error code in debug message
Timo Sirainen [Thu, 27 Oct 2022 19:33:59 +0000 (22:33 +0300)]
lib-doveadm, doveadm: Change hardcoded exit code 2 to DOVEADM_EX_CHANGED
This also gives it a "CHANGED" error code in the doveadm protocol.
Aki Tuomi [Tue, 16 Jan 2018 10:21:15 +0000 (12:21 +0200)]
aggregator: Provide name for notify connection
Aki Tuomi [Tue, 16 Jan 2018 10:20:11 +0000 (12:20 +0200)]
aggregator: Add debug logging
Aki Tuomi [Wed, 10 Jan 2018 14:06:52 +0000 (16:06 +0200)]
replicator: Add debug logging
Timo Sirainen [Thu, 27 Oct 2022 08:54:29 +0000 (11:54 +0300)]
replicator: Add "replication" category to events
Timo Sirainen [Mon, 31 Oct 2022 09:23:00 +0000 (11:23 +0200)]
replication plugin: Use "replication: " log prefix for all log messages
Some of the messages were missing the prefix. Some were using
"replication(user): " as the prefix, which was unnecessary since the
mail_log_prefix already contains the username.
Timo Sirainen [Thu, 27 Oct 2022 08:05:46 +0000 (11:05 +0300)]
replication plugin: Add "replication" category to events
Timo Sirainen [Tue, 16 Aug 2022 20:42:51 +0000 (23:42 +0300)]
replicator: Add unit test to replicator-queue
Timo Sirainen [Fri, 28 Oct 2022 14:57:03 +0000 (17:57 +0300)]
replicator: Add replicator_queue_count() and replicator_queue_peek()
These will be useful for the following unit test.
Timo Sirainen [Tue, 25 Oct 2022 12:39:39 +0000 (15:39 +0300)]
replicator: Add "next sync secs" field to doveadm replicator status
Timo Sirainen [Tue, 25 Oct 2022 10:27:23 +0000 (13:27 +0300)]
replicator: Make sure to prevent request starvation
This synchronizes how priority queue is ordered vs what
replicator_queue_want_sync_now() returns. The mismatch might have caused
request starvation in some situations because they behaved differently.
Also this change makes sure that higher priority requests don't infinitely
block lower priority requests. Instead, they get a temporary boost time
(hardcoded 15-45 minutes). Afterwards lower priority requests are started
to be handled as well.
Timo Sirainen [Tue, 25 Oct 2022 10:11:37 +0000 (13:11 +0300)]
replicator: Don't update user's last_update if priority doesn't change
This didn't actually matter, since it was only used to check if importing
should update an existing user. However, importing is only run at startup
when all users have last_update=0 anyway.
The following changes bring new use cases for last_update.
Timo Sirainen [Tue, 25 Oct 2022 10:08:36 +0000 (13:08 +0300)]
replicator: Change replicator_queue_add_sync_callback() to take user struct
This is just to clean up the API to match the previous change.
Timo Sirainen [Tue, 25 Oct 2022 09:49:03 +0000 (12:49 +0300)]
replicator: Fix user placement in replication queue
Especially replicator queue importing and NOTIFY command could have
placed the user to wrong place in the queue, because they modified the
last sync timestamps afterwards.
Fixed by splitting replicator_queue_add() into get/update/add(), so all
the necessary changes can be done before replicator_queue_add() is used
to place the user into the queue.
Aki Tuomi [Thu, 27 Oct 2022 07:26:01 +0000 (10:26 +0300)]
quota: Drop rquota-pragmas.h
Aki Tuomi [Thu, 27 Oct 2022 07:25:15 +0000 (10:25 +0300)]
quota: quota-fs - Ignore boolean errors with rquota.h
Aki Tuomi [Thu, 27 Oct 2022 07:24:29 +0000 (10:24 +0300)]
quota: Fix rquota generation rules
Timo Sirainen [Wed, 26 Oct 2022 23:56:45 +0000 (02:56 +0300)]
lib-storage: mailbox_attribute_get*() - Fail early on with empty key lookup
This fixes using mail_attribute_dict with dict-sql.
Marco Bettini [Mon, 10 Oct 2022 08:46:46 +0000 (08:46 +0000)]
stats: Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 28 Sep 2022 08:10:39 +0000 (08:10 +0000)]
replication: replicator - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 6 Oct 2022 12:52:40 +0000 (12:52 +0000)]
replication: struct replicator_queue - Move to replicator-queue-private.h
Marco Bettini [Tue, 27 Sep 2022 14:33:24 +0000 (14:33 +0000)]
replication: aggregator - Replace i_<log>() with e_<log>()
Marco Bettini [Mon, 19 Sep 2022 13:19:39 +0000 (13:19 +0000)]
pop3: Replace i_<log>() with e_<log>()
Marco Bettini [Fri, 14 Oct 2022 09:33:19 +0000 (09:33 +0000)]
pop3: struct client - Add event
Marco Bettini [Thu, 13 Oct 2022 14:43:59 +0000 (14:43 +0000)]
master: Replace i_<log>() with e_<log>()
This reverts commit
4c6bd967436db31b5a050a55a3a35d83c70e299c .
Marco Bettini [Thu, 13 Oct 2022 14:44:09 +0000 (14:44 +0000)]
master: Replace service_error() with e_error()
This reverts commit
e9ea9531521abf1e1a8456b30bf9d3668186b26a .
Marco Bettini [Fri, 30 Sep 2022 15:33:44 +0000 (15:33 +0000)]
master: Add struct service.event, struct service_list.event
Marco Bettini [Thu, 6 Oct 2022 08:29:59 +0000 (08:29 +0000)]
login-common: Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 6 Oct 2022 09:31:33 +0000 (09:31 +0000)]
log: Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 5 Oct 2022 13:18:12 +0000 (13:18 +0000)]
lda: Replace i_<log>() with e_<log>()
Marco Bettini [Mon, 10 Oct 2022 10:32:17 +0000 (10:32 +0000)]
imap-urlauth: Replace i_<log>() with e_<log>()
Marco Bettini [Fri, 7 Oct 2022 13:58:12 +0000 (13:58 +0000)]
imap: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 27 Sep 2022 13:43:45 +0000 (13:43 +0000)]
auth: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 4 Oct 2022 14:59:44 +0000 (14:59 +0000)]
lib-sql: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 4 Oct 2022 15:04:47 +0000 (15:04 +0000)]
lib-program-client: Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 12 Oct 2022 10:52:39 +0000 (10:52 +0000)]
lib-mail: istream-attachment-extractor - Return read failure on unexpected errors
If the istream content unexpectedly changes or there are any syscall failures, the
istream reading should fail rather than handle it the same as if the base64 input
was invalid.
The way astream_part_finish() reports errors been modified:
Instead of returning -1 (failure) and 0(success) now it returns
-1 (failure, propagate *error and abort), 0 (invalid base64), 1(success)
Marco Bettini [Wed, 5 Oct 2022 08:06:35 +0000 (08:06 +0000)]
lib-ldap: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 11 Oct 2022 13:46:53 +0000 (13:46 +0000)]
lib-ldap: struct ldap_client_settings - Add event
Marco Bettini [Wed, 5 Oct 2022 08:10:52 +0000 (08:10 +0000)]
lib-lda: Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 5 Oct 2022 13:08:09 +0000 (13:08 +0000)]
lib-index: Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 6 Oct 2022 14:39:03 +0000 (14:39 +0000)]
lib-imap-urlauth: imap_urlauth_fetch_local() - Reformat code
Marco Bettini [Wed, 28 Sep 2022 14:47:26 +0000 (14:47 +0000)]
lib-imap-urlauth: Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 29 Sep 2022 14:25:37 +0000 (14:25 +0000)]
lib-imap-client: Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 6 Oct 2022 14:05:30 +0000 (14:05 +0000)]
lib-imap-client: Expose struct imapc_connection.event
Marco Bettini [Wed, 5 Oct 2022 13:14:17 +0000 (13:14 +0000)]
lib-http: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 11 Oct 2022 12:38:09 +0000 (12:38 +0000)]
lib-fts: Update error message for the case where a stopword list is empty.
Now this condition is no longer allowed.
Marco Bettini [Thu, 6 Oct 2022 10:12:57 +0000 (10:12 +0000)]
lib-dict-backend: ldap_dict_lookup_callback() - Reformat code
Marco Bettini [Tue, 4 Oct 2022 15:37:58 +0000 (15:37 +0000)]
lib-dict-backend: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 11 Oct 2022 13:44:15 +0000 (13:44 +0000)]
lib-dict-backend: struct ldap_dict - Add event
Marco Bettini [Wed, 5 Oct 2022 12:53:46 +0000 (12:53 +0000)]
lib-login: Replace i_<log>() with e_<log>()
Marco Bettini [Fri, 7 Oct 2022 14:04:07 +0000 (14:04 +0000)]
lib-login: struct login_server_connection - Move to header file and add event field
Marco Bettini [Tue, 4 Oct 2022 15:02:06 +0000 (15:02 +0000)]
lib-master: Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 11 Oct 2022 11:03:41 +0000 (11:03 +0000)]
lib-auth: auth_user_fields_parse() - Fail on parse errors rather than just log it
Marco Bettini [Thu, 13 Oct 2022 14:09:43 +0000 (14:09 +0000)]
login-common: Remove access-lookup.[ch]
leftover from
97815ea9
Marco Bettini [Wed, 28 Sep 2022 09:16:54 +0000 (09:16 +0000)]
global: Remove stray whitespaces
Karl Fleischmann [Tue, 18 Oct 2022 06:39:43 +0000 (08:39 +0200)]
imap-login: Amend ID cmd response with trust-state
Timo Sirainen [Fri, 21 Oct 2022 07:49:53 +0000 (10:49 +0300)]
lib-storage: Finish renaming mail_stream_opened to mail_stream_accessed in comment
Forgotten in
d7b8c4097185e2ab40acf43524f48fcde80f615d