Willem Toorop [Fri, 13 Jul 2012 12:42:11 +0000 (12:42 +0000)]
Some initial fixes from coverity analysis:
10535 remove unused pointer in ldns-signzone.c:678
10534 remove unused pointer in drill/chasetrace.c:121
10533 remove unreachable code in drill/securetrace.c:395
10532 ldns-update only show tsig data when given in examples/ldns-update.c:312
10499 wrong sizeof argument in net.c:672
10492 replace call to random() with something better ldns-notify.c:253
Willem Toorop [Fri, 13 Jul 2012 08:35:57 +0000 (08:35 +0000)]
Bugfix 457: add two functions to use EVP_PKEY_assign_DSA and EVP_PKEY_assign_RSA (to prevent memory leaks/unnecessary allocations):
* ldns_key_assign_dsa_key
* ldns_key_assign_rsa_key
and use those in ldns_key_new_frm_algorithm.
Willem Toorop [Thu, 12 Jul 2012 14:31:56 +0000 (14:31 +0000)]
* memory handling fixes and the python3/ldns-signzone.py examples script contribution from Karel Slany.
* Memroy leak fix for ldns_key_new_frm_algorithm from Michael Sheldon.
Willem Toorop [Fri, 1 Jun 2012 14:41:38 +0000 (14:41 +0000)]
New -0 option for ldns-read-zone to replace inception, expiration and signature rdata fields with (null). Thanks Paul Wouters.
New -p option for ldns-read-zone to prepend-pad SOA serial to take up ten characters.
Willem Toorop [Tue, 22 May 2012 09:10:56 +0000 (09:10 +0000)]
bugfix #448: Copy nameserver value (in stead of reference) of the answering nameserver to the answer packet in ldns_send_buffer, so the original value may be deep freed with the ldns_resolver struct.
Thanks Michael Meisel.
Willem Toorop [Fri, 18 May 2012 15:09:22 +0000 (15:09 +0000)]
Final code reviews
- Potential uninitialized variable usage in dnssec.c
- Freeing of temporarily allocated ldns_zone in ldns_dnssec_zone_new_frm_fp_l
- Clarify defaults for -i and -e options to ldns-verify-zone
Willem Toorop [Fri, 11 May 2012 08:31:26 +0000 (08:31 +0000)]
Code review from Matthijs and Wouter.
- Check and respond on faulty returns in
- drill/dnssec.c/ldns_nsec3_exact_match
- drill/dnssec.c/ldns_nsec3_closest_encloser
- Removal of unused arguments of static functions in
- examples/ldns-compare-zones.c/usage
- Removal of an unused static function:
- examples/ldns-signzone.c/usage_openssl
- Turn unused return value into void in
- examples/ldns-signzone.c/find_or_create_pubkey
- Move new error messages from examples/ldns-verify-zone to error.c and ldns/error.h (although only used in ldns-verify-zone)
- More specific error return code in
- examples/ldns-verify-zone.c/read_key_file
- Replaced result = result ? result : status with update_error(&result, status) to update result with more specific errors when possible.
- Removed /* TODO */ comment line as the result of NSEC3 opt-out detection is now cached.
- Be really silent when verbosity == 0
- Updated comments for FASTER_DNSSEC_ZONE_NEW_FRM_FP define
- Carefull casting for rfc 1982 Serial Number Arithmetic in
- -rrsig_check_time_margins
Willem Toorop [Tue, 6 Mar 2012 20:57:05 +0000 (20:57 +0000)]
- ldns-verify-zone error messages to stderr
- ldns-verify-zone errors on empty key files
- make Makefile in examples subdir work for ldns-verify-zone
- make lint test pass (at least on open)
Willem Toorop [Mon, 13 Feb 2012 20:53:40 +0000 (20:53 +0000)]
Bugfix #431, #432 and #433 from Jerry Lundström
#431: Error message for the LDNS_STATUS_INVALID_B32_EXT return code
#432: Use LDNS_MALLOC and LDNS_FREE whenever possible
, but use free() when memory was not allocated with LDNS_MALLOC
(such as with strdup and with i2d_DSA_SIG)
#433: Use ldns_rdf_new in stead of filling the structure ourselve in
ldns_dname_label
Willem Toorop [Tue, 17 Jan 2012 11:18:30 +0000 (11:18 +0000)]
Code review fixes.
Clarify -S option in ldns-read-zone manpage
Fix spelling of dnssec_trust_tree in doxygen documentation in dnssec_verify.h
Use rfc1982 serial arithmetics when comparing soa serial numbers in ldns_rrsig_check_timestamps, ldns_soa_serial_datecounter and ldns_soa_serial_unixtime.
Thanks Wouter!
Add AC-FORK test to main configure.ac that makes ldns-testns forked more work.
Add LIB=libldns.la so that dependencies work in Makefile, LIB was empty.
Willem Toorop [Mon, 2 Jan 2012 15:06:50 +0000 (15:06 +0000)]
Updated Changelog
Exit with error message from configure and make when trying to build drill and examples from the root of the source directory when ./configure has been used in the drill and examples subdirectories.
Documentation for soa serial increment functions.
Willem Toorop [Mon, 5 Dec 2011 13:55:19 +0000 (13:55 +0000)]
make examples/ldns-dpa work by:
- Proper order of include file testing
- Only include the possibly extra includes with ldns-dpa.c (via ldns-dpa.h)
- Linking the pcap library only when linking ldns-dpa