Jim Meyering [Thu, 22 Jan 2004 21:03:13 +0000 (21:03 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant
assignments.
Jim Meyering [Thu, 22 Jan 2004 21:02:22 +0000 (21:02 +0000)]
(initialize_exit_failure): New inline function.
Include exitfail.h here, since we refer to exit_failure.
All callers changed to not include exitfail.h.
(EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT): New enum values.
Jim Meyering [Thu, 22 Jan 2004 20:55:26 +0000 (20:55 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant
assignments.
Don't include <assert.h>.
(SORT_OUT_OF_ORDER, SORT_FAILURE): Now enums, not macros.
(usage): Don't use 'assert'.
(main): Remove redundant assignment to exit_failure.
Jim Meyering [Thu, 22 Jan 2004 20:53:55 +0000 (20:53 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Likewise, to SETUIDGID_FAILURE.
(SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
for consistency with other programs here. All uses changed.
(main): Use 'error' to exit rather than invoking 'exit' here.
Jim Meyering [Thu, 22 Jan 2004 20:51:09 +0000 (20:51 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(print_numbers): Now returns void, not (zero) int.
All callers changed.
(main): Remove unused local variable 'errs'. Always exit successfully
if we reach the end.
Jim Meyering [Thu, 22 Jan 2004 20:48:38 +0000 (20:48 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(remove_parents): Don't set 'fail' to a negative number.
(main): Avoid integer overflow when seeing whether errors occurred.
Jim Meyering [Thu, 22 Jan 2004 20:44:15 +0000 (20:44 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than setting
exit_failure directly; this optimizes away redundant assignments.
(PRINTENV_FAILURE): New constant.
(main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
command-line syntax problems.
Jim Meyering [Thu, 22 Jan 2004 19:49:47 +0000 (19:49 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(FATAL_ERROR, main): Exit with status EXIT_FAILURE, not 2, on errors.
Jim Meyering [Thu, 22 Jan 2004 08:09:38 +0000 (08:09 +0000)]
(.x.1): Invoke our own (tweaked) copy of help2man.
Use --info-page='coreutils PROG' option.
Now, readlink.1 refers the user to `info coreutils readlink'
rather than to `info readlink'. Reported by Matt Swift.
Jim Meyering [Wed, 21 Jan 2004 23:31:33 +0000 (23:31 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.
(main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
rather than roll-your-own symbols or integers.
(NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
changed to EXIT_CANNOT_INVOKE.
Jim Meyering [Wed, 21 Jan 2004 23:30:09 +0000 (23:30 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(main): Exit with status 1, not 2, on errors detected by nl proper.
Jim Meyering [Wed, 21 Jan 2004 23:28:19 +0000 (23:28 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.
(main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
on error; this is in case EXIT_FAILURE is unusual.
Jim Meyering [Wed, 21 Jan 2004 23:21:17 +0000 (23:21 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(main): Use int, not size_t, to store boolean int.
Jim Meyering [Wed, 21 Jan 2004 23:10:54 +0000 (23:10 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(usage): Don't bother normalizing exit status
since the arg is already the correct exit status now.
(main): Don't assume EXIT_FAILURE == 1, as POSIX doesn't require it.
(problems): Now a boolean int, not a counter,
so that we don't have to worry about int overflow. All uses changed.
Jim Meyering [Wed, 21 Jan 2004 23:02:45 +0000 (23:02 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant assignments.
(EXPR_FAILURE): Renamed from EXPR_ERROR, for
consistency with the other programs' naming conventions.
All uses changed.
Jim Meyering [Wed, 21 Jan 2004 22:59:14 +0000 (22:59 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(main): Initialize exit_failure to EXIT_FAIL.
(main): Use initialize_exit_failure rather than
setting exit_failure directly; this optimizes away redundant
assignments.
(main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
rather than roll-your-own symbols or integers.
(main): Exit with status 1, not 2, on errors detected by env proper.
Jim Meyering [Wed, 21 Jan 2004 22:53:49 +0000 (22:53 +0000)]
(usage): Use EXIT_SUCCESS, not 0, for clarity.
(dd_copy): Exit with status EXIT_FAILURE, not 2, on errors.
(write_output, skip, dd_copy): Don't assume EXIT_FAILURE == 1,
as POSIX doesn't require it.
Jim Meyering [Wed, 21 Jan 2004 19:57:35 +0000 (19:57 +0000)]
* tests/touch/relative: Test only year/month/day, not hours/min/sec,
so as to avoid problems with systems using TAI clocks.
Although it's no longer necessary, set TZ=UTC0 also for the
initial touch command. Reported by Paul Jarc here:
http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/1504
Jim Meyering [Tue, 20 Jan 2004 09:19:37 +0000 (09:19 +0000)]
Use TZ=UTC0, not TZ=utc (which isn't portable).
Problem reported by Christian Krackowizer. Also, use
+0000 rather than +0 to specify a time zone, as the documentation
requires four digits.