]>
git.ipfire.org Git - thirdparty/kea.git/log
Thomas Markwalder [Fri, 15 Mar 2019 14:34:38 +0000 (10:34 -0400)]
[#401,!254] Implemented CfgOption::replace
src/lib/dhcpsrv/cfg_option.*
CfgOption::replace() - new method to update an OptionDescriptor
CfgOption::createDescriptorOption() - new returns a bool indicating
whether or not the option_ instance was replaced
Thomas Markwalder [Fri, 15 Mar 2019 12:26:35 +0000 (08:26 -0400)]
[#401,!254] Options are now created when merging subnets
src/lib/dhcpsrv/cfg_subnets4.*
CfgSubnets4::merge() - added cfg_def, now
creates options for each subnet and their pools.
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4() - passes merged option defs
into subnets merge.
src/lib/dhcpsrv/subnet.h
Subnet::getPoolsWritable() - changed to public.
Thomas Markwalder [Thu, 14 Mar 2019 17:54:41 +0000 (13:54 -0400)]
[#401,!254] Options are now created when merging shared-network4s
src/lib/dhcpsrv/cfg_option.*
CfgOption::createOptions(CfgOptionDefPtr cfg_def) -
new function which creates options for all of a cfg's
descriptors
CfgOption::merge() - calls createOptions()
src/lib/dhcpsrv/cfg_shared_networks.*
CfgSharedNetworks4::merge() - added cfg_def parameter and
call to populate the "other" networks' options
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4() - passes merged option definitions
into shared network merge.
Thomas Markwalder [Sat, 9 Mar 2019 00:37:26 +0000 (19:37 -0500)]
Merge branch '401-merge-dhcpv4-options-fetched-from-the-cb-into-the-configuration' of gitlab.isc.org:isc-projects/kea into 401-merge-dhcpv4-options-fetched-from-the-cb-into-the-configuration
Thomas Markwalder [Fri, 8 Mar 2019 21:39:19 +0000 (16:39 -0500)]
[#401,!24] Addressed most review comments
This commit addresse the more trivial review
comments, it does not include option creation
for networks,subnets, or pools.
Will rebase and address remaining comments.
Thomas Markwalder [Wed, 6 Mar 2019 18:26:01 +0000 (13:26 -0500)]
[#401,!254] kea-dhcp4 now merges in options from config backend
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge() - new function which merges a given set
of option descriports into the existing set
CfgOption::createDescriptorOption - new function that uses an
option definition factory to create a descriptor's option instance
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, validMerge)
TEST_F(CfgOptionTest, invalidMerge) - new tests
Thomas Markwalder [Mon, 4 Mar 2019 15:54:53 +0000 (10:54 -0500)]
[#401,!254] kea-dhcp4 now merges CB options into current config
Basic merging works, need to add validation against definitions.
src/bin/dhcp4/tests/config_backend_unittest.cc
TEST_F(Dhcp4CBTest, mergeOptions) - enabled and updated
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge(CfgOption& other) - new method, conformant
to others, that merges/updates a config option from another
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4(SrvConfig& other) - modified to
merge configured options
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, merge) - new test
Thomas Markwalder [Fri, 8 Mar 2019 21:39:19 +0000 (16:39 -0500)]
[#401,!24] Addressed most review comments
This commit addresse the more trivial review
comments, it does not include option creation
for networks,subnets, or pools.
Will rebase and address remaining comments.
Francis Dupont [Sat, 2 Mar 2019 02:12:59 +0000 (03:12 +0100)]
[499-global-keywords-entries] Added global parameter lists
Marcin Siodelski [Thu, 7 Mar 2019 13:51:45 +0000 (14:51 +0100)]
[master] Added ChangeLog entry for #488.
Marcin Siodelski [Wed, 6 Mar 2019 16:29:53 +0000 (17:29 +0100)]
[#488,!259] Updated get_config_unittests for v4.
Marcin Siodelski [Wed, 6 Mar 2019 15:47:00 +0000 (16:47 +0100)]
[#488,!259] Parse siaddr, sname and boot-file-name in shared network parser.
Marcin Siodelski [Wed, 6 Mar 2019 15:44:29 +0000 (16:44 +0100)]
[#488,!259] Rename parameters in the base network parser.
Marcin Siodelski [Wed, 6 Mar 2019 15:44:07 +0000 (16:44 +0100)]
[#488,!259] Test authoritative flag in MySQL CB.
Marcin Siodelski [Wed, 6 Mar 2019 13:31:55 +0000 (14:31 +0100)]
[#488,!259] Added support for boot file, next_server and sname to MySQL CB.
Marcin Siodelski [Wed, 6 Mar 2019 11:26:36 +0000 (12:26 +0100)]
[#488,!259] Added sname, next-server and boot-file-name to MySQL schema.
Marcin Siodelski [Wed, 6 Mar 2019 11:15:04 +0000 (12:15 +0100)]
[#488,!259] Subnet's and Network's toElement do not output optionals.
Marcin Siodelski [Wed, 6 Mar 2019 08:10:19 +0000 (09:10 +0100)]
[#488,!259] Extracted common parsing functions to a new class.
Marcin Siodelski [Tue, 5 Mar 2019 19:43:24 +0000 (20:43 +0100)]
[#488,!259] Regenerated get_config_unittests for v4 and corrected issues.
Marcin Siodelski [Tue, 5 Mar 2019 11:03:45 +0000 (12:03 +0100)]
[#488,!259] Correct unit tests failing after recent code updates.
Marcin Siodelski [Mon, 4 Mar 2019 19:06:04 +0000 (20:06 +0100)]
[#488,!259] Added support for authoritative flag in MySQL CB.
Marcin Siodelski [Mon, 4 Mar 2019 17:33:54 +0000 (18:33 +0100)]
[#488] Shared network parser stores parsed parameters in the object.
Marcin Siodelski [Mon, 4 Mar 2019 11:02:39 +0000 (12:02 +0100)]
[#488] DHCP subnet and network parsers allow unspecified parameters.
Marcin Siodelski [Thu, 7 Mar 2019 12:59:24 +0000 (13:59 +0100)]
[master] Removed trailing comma in the default kea-dhcp-ddns config.
Okayed on jabber.
Michal Nowikowski [Thu, 7 Mar 2019 11:18:03 +0000 (12:18 +0100)]
improved Sandbox class comments
Michal Nowikowski [Thu, 7 Mar 2019 11:08:16 +0000 (12:08 +0100)]
removed unnecessary includes
Marcin Siodelski [Thu, 7 Mar 2019 10:52:08 +0000 (11:52 +0100)]
[#357,!258] Added space after return.
Michal Nowikowski [Thu, 7 Mar 2019 09:56:14 +0000 (10:56 +0100)]
replaced throwing exception in destructor with a trace and exit(1)
Michal Nowikowski [Thu, 7 Mar 2019 09:30:08 +0000 (10:30 +0100)]
changes after review: updated comments and did other small improvements
Michal Nowikowski [Tue, 5 Mar 2019 05:40:15 +0000 (06:40 +0100)]
Changed location of unit socket in unit tests
Previously it was stored in TEST_DATA_BUILDDIR which resides inside repo sources.
Due to the fact that when repo was located in deep patch creating socket was
failing as max socket patch is about 100 characters. Now it is located
in temp folder managed by Sandbox class. The sandbox directory is created
in test constructor and deleted in destructor. As the temp directory
is in form /tmp/kea-XXXXXX the lnegth is always lower than 1000, so running
the unit tests never fails.
Francis Dupont [Wed, 6 Mar 2019 20:24:38 +0000 (21:24 +0100)]
[478-improve-error-message-database-backend-mysql] Reviewed changes and addressed comments
Tomek Mrugalski [Wed, 6 Mar 2019 18:46:59 +0000 (19:46 +0100)]
[#478,!249] Added extra log error message.
Francis Dupont [Thu, 28 Feb 2019 14:44:55 +0000 (15:44 +0100)]
[478-improve-error-message-database-backend-mysql] Better message for not built lease database type
Thomas Markwalder [Wed, 6 Mar 2019 18:26:01 +0000 (13:26 -0500)]
[#401,!254] kea-dhcp4 now merges in options from config backend
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge() - new function which merges a given set
of option descriports into the existing set
CfgOption::createDescriptorOption - new function that uses an
option definition factory to create a descriptor's option instance
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, validMerge)
TEST_F(CfgOptionTest, invalidMerge) - new tests
Tomek Mrugalski [Wed, 6 Mar 2019 11:42:30 +0000 (12:42 +0100)]
[#471] Hammer docs updated
Tomek Mrugalski [Wed, 6 Mar 2019 14:18:53 +0000 (15:18 +0100)]
[#480] ChangeLog updated
Francis Dupont [Wed, 6 Mar 2019 12:10:54 +0000 (13:10 +0100)]
[480-shellcheck] Addressed SC2231 extra warnings
Tomek Mrugalski [Wed, 6 Mar 2019 11:23:19 +0000 (12:23 +0100)]
Fixed execution of find command
Tomek Mrugalski [Wed, 6 Mar 2019 11:09:52 +0000 (12:09 +0100)]
! -z replaced with -n
Tomek Mrugalski [Wed, 6 Mar 2019 11:09:34 +0000 (12:09 +0100)]
Removed SC2046 disables and added nested double quotes instead.
Tomek Mrugalski [Wed, 6 Mar 2019 10:54:32 +0000 (11:54 +0100)]
Another ! -z replaced with -n
Tomek Mrugalski [Wed, 6 Mar 2019 10:53:42 +0000 (11:53 +0100)]
Replaced ! -z with -n
Tomek Mrugalski [Wed, 6 Mar 2019 10:35:48 +0000 (11:35 +0100)]
Converted sysrepo_config: bash -> sh
Tomek Mrugalski [Wed, 6 Mar 2019 10:34:41 +0000 (11:34 +0100)]
Copyright headers added. Addressed 3 remaining shellcheck issues.
Tomek Mrugalski [Wed, 6 Mar 2019 10:27:50 +0000 (11:27 +0100)]
Remaining warnings in kea-admin and keactrl addressed.
Francis Dupont [Mon, 4 Mar 2019 22:12:50 +0000 (23:12 +0100)]
[480-shellcheck] Updated copyright years
Tomek Mrugalski [Mon, 4 Mar 2019 19:17:23 +0000 (20:17 +0100)]
List of scripts to check fixed.
Tomek Mrugalski [Mon, 4 Mar 2019 19:13:29 +0000 (20:13 +0100)]
sysrepo_config cleaned up
Tomek Mrugalski [Mon, 4 Mar 2019 18:46:58 +0000 (19:46 +0100)]
cql_config cleaned up
Tomek Mrugalski [Mon, 4 Mar 2019 18:27:25 +0000 (19:27 +0100)]
kea-admin fixed
Tomek Mrugalski [Mon, 4 Mar 2019 18:06:08 +0000 (19:06 +0100)]
Disabled one more warning.
Tomek Mrugalski [Mon, 4 Mar 2019 17:35:48 +0000 (18:35 +0100)]
More shellcheck fixes
Tomek Mrugalski [Mon, 4 Mar 2019 15:00:27 +0000 (16:00 +0100)]
Reverted removal of prefix variable.
Tomek Mrugalski [Mon, 4 Mar 2019 14:44:41 +0000 (15:44 +0100)]
More quotes!
Tomek Mrugalski [Mon, 4 Mar 2019 14:34:57 +0000 (15:34 +0100)]
local variables declared and initialized separately
Tomek Mrugalski [Mon, 4 Mar 2019 14:32:23 +0000 (15:32 +0100)]
More quotes
Tomek Mrugalski [Mon, 4 Mar 2019 14:12:31 +0000 (15:12 +0100)]
Warning about local variables disabled
Tomek Mrugalski [Mon, 4 Mar 2019 14:12:08 +0000 (15:12 +0100)]
local directiver restored
Tomek Mrugalski [Mon, 4 Mar 2019 11:26:01 +0000 (12:26 +0100)]
More quotes
Tomek Mrugalski [Sat, 2 Mar 2019 02:34:40 +0000 (03:34 +0100)]
[#480,!245] More fixes
Tomek Mrugalski [Thu, 28 Feb 2019 21:13:43 +0000 (22:13 +0100)]
[#480,!245] Some more shell fixes
Tomek Mrugalski [Tue, 26 Feb 2019 19:46:15 +0000 (20:46 +0100)]
[#480,!245] Some bugs in scripts fixed.
Tomek Mrugalski [Tue, 26 Feb 2019 19:24:36 +0000 (20:24 +0100)]
gitlab-ci simplified
Tomek Mrugalski [Tue, 26 Feb 2019 19:11:03 +0000 (20:11 +0100)]
apt changed to apt-get
Tomek Mrugalski [Tue, 26 Feb 2019 19:05:00 +0000 (20:05 +0100)]
Stage defined explicitly as test
Tomek Mrugalski [Tue, 26 Feb 2019 18:53:21 +0000 (19:53 +0100)]
attempt #6
Tomek Mrugalski [Tue, 26 Feb 2019 18:50:56 +0000 (19:50 +0100)]
attempt #5
Tomek Mrugalski [Tue, 26 Feb 2019 18:35:35 +0000 (19:35 +0100)]
[#480,!245] Attempt #4
Tomek Mrugalski [Tue, 26 Feb 2019 18:33:06 +0000 (19:33 +0100)]
[#480,!245] Attempt #3
Tomek Mrugalski [Tue, 26 Feb 2019 18:24:41 +0000 (19:24 +0100)]
[#480,!245] yml random fix attempt
Tomek Mrugalski [Tue, 26 Feb 2019 18:20:59 +0000 (19:20 +0100)]
[#480,!245] Using debian image now
Tomek Mrugalski [Tue, 26 Feb 2019 18:04:15 +0000 (19:04 +0100)]
[#480,!245] First gitlab-ci added
Michal Nowikowski [Tue, 5 Mar 2019 05:35:36 +0000 (06:35 +0100)]
updated changelog about hammer changes
Michal Nowikowski [Mon, 4 Mar 2019 10:36:57 +0000 (11:36 +0100)]
hammer: added checking vagrant version, removed hammer from EXTRA_DIST
Thomas Markwalder [Mon, 4 Mar 2019 15:54:53 +0000 (10:54 -0500)]
[#401,!254] kea-dhcp4 now merges CB options into current config
Basic merging works, need to add validation against definitions.
src/bin/dhcp4/tests/config_backend_unittest.cc
TEST_F(Dhcp4CBTest, mergeOptions) - enabled and updated
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge(CfgOption& other) - new method, conformant
to others, that merges/updates a config option from another
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4(SrvConfig& other) - modified to
merge configured options
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, merge) - new test
Marcin Siodelski [Mon, 4 Mar 2019 15:13:37 +0000 (16:13 +0100)]
[master] Added ChangeLog for #489.
Marcin Siodelski [Mon, 4 Mar 2019 12:05:19 +0000 (13:05 +0100)]
[#489,!250] Drop constraints on dhcp6_[pd]_pool prior to rename.
Marcin Siodelski [Mon, 4 Mar 2019 11:45:36 +0000 (12:45 +0100)]
[#489,!250] Addressed review comments.
Marcin Siodelski [Fri, 1 Mar 2019 14:53:52 +0000 (15:53 +0100)]
[#489,!250] Updated MySQL admin tests for new percent parameters.
Marcin Siodelski [Fri, 1 Mar 2019 14:28:39 +0000 (15:28 +0100)]
[#489,!250] Extended MySQL backend to store floating values in shared nets.
Marcin Siodelski [Fri, 1 Mar 2019 14:06:25 +0000 (15:06 +0100)]
[#489,!250] Extend MySQL backend to store floating point values.
Marcin Siodelski [Thu, 28 Feb 2019 09:28:27 +0000 (10:28 +0100)]
[#489] Updated MySQL CB to handle unspecified subnet and network values.
Tomek Mrugalski [Thu, 28 Feb 2019 14:55:11 +0000 (15:55 +0100)]
Changelog updated
Tomek Mrugalski [Thu, 28 Feb 2019 14:44:28 +0000 (15:44 +0100)]
Minor clarification with LFC
Suzanne Goldlust [Mon, 25 Feb 2019 15:11:43 +0000 (10:11 -0500)]
Update dhcp6-srv.xml to fix small grammatical errors lines 1158-1162
Tomek Mrugalski [Mon, 25 Feb 2019 14:14:13 +0000 (15:14 +0100)]
[#362] Corrected escaped examples.
Tomek Mrugalski [Mon, 25 Feb 2019 14:02:05 +0000 (15:02 +0100)]
[#362] Clarified when an option is sent
Tomek Mrugalski [Mon, 25 Feb 2019 13:57:17 +0000 (14:57 +0100)]
[#362] Unicast address binding example in v6
Suzanne Goldlust [Fri, 22 Feb 2019 15:11:26 +0000 (10:11 -0500)]
Update dhcp4-srv.xml to add missing "a" in line 499
Suzanne Goldlust [Fri, 22 Feb 2019 15:10:43 +0000 (10:10 -0500)]
Update dhcp6-srv.xml to add missing "a" in line 629
Tomek Mrugalski [Fri, 22 Feb 2019 13:04:41 +0000 (14:04 +0100)]
[#362,!182] Added clarification about Cassandra connection failure handling
Tomek Mrugalski [Fri, 22 Feb 2019 12:57:10 +0000 (13:57 +0100)]
[#362,!182] Example of hosts-database added.
Tomek Mrugalski [Fri, 22 Feb 2019 10:01:42 +0000 (11:01 +0100)]
[#362,!182] Links to on-line ARM replaced with local references
Tomek Mrugalski [Fri, 22 Feb 2019 09:52:47 +0000 (10:52 +0100)]
[#362,!182] Added missing <command>s in recently added text
Tomek Mrugalski [Fri, 22 Feb 2019 09:40:40 +0000 (10:40 +0100)]
[#362,!182] comment review: move lease-expiration params to beginning of the charter
Tomek Mrugalski [Fri, 22 Feb 2019 08:50:18 +0000 (09:50 +0100)]
[#362,!182] Added clarification what it means to enable lease affinity
Tomek Mrugalski [Thu, 21 Feb 2019 21:55:21 +0000 (22:55 +0100)]
[#362,!182] Removed obsolete libdhcp secton
Suzanne Goldlust [Wed, 20 Feb 2019 20:03:00 +0000 (15:03 -0500)]
Update dhcp6-srv.xml to incorporate Stephen's comments
Suzanne Goldlust [Wed, 20 Feb 2019 20:02:16 +0000 (15:02 -0500)]
Update dhcp4-srv.xml to add minor text corrections from Stephen
Suzanne Goldlust [Wed, 20 Feb 2019 19:52:38 +0000 (14:52 -0500)]
Update dhcp4-srv.xml to add Stephen's recommended change (copying lines 525-533 from dhcp6-srv.xml)