samples: Move the config examples to samples/config/

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

configure: Delete legacy test artifacts

The legacy tests (now located in the libcgroup-tests)
repository have been moved to
https://github.com/libcgroup/libcgroup-tests/tree/main/examples
and are no longer being run.  Remove all references to
the tests from the configure.ac file.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

python/setup.py: make it PEP8 compliant

Make setup.py PEP-8 compliant, it fixes the following two issues
reported by flake8:
- E128 continuation line under-indented for visual indent
- E251 unexpected spaces around keyword/parameter equals

also, adopt single quotes for strings.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

README.md: Add python code quality badge

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

README.md: Update the LGTM link

The LGTM badge linked to a comparison of libcgroup with
other open source projects.  Change the link to go directly
to libcgroup's alerts.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

api.c: Fix TOCTOU race cgroup_get_cg_type()

Fix a TOCTOU race condition, that checks for file existence versus file
open in cgroup_get_cg_type() by opening the file and check for errno for
file existence.

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

api.c: fix a comparison error in cgroup_delete_cgroup_ext()

Fix a comparison logic in the first_errno assignment, that would
never get executed in the case of first_errno == ECGNONEMPTY in
cgroup_delete_cgroup_ext().

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

api: make cgroup_get_subsys_mount_point_end() more useful

Currently cgroup_get_subsys_mount_point_end(), does nothing more than
returning zero, it was caught by LGTM altering:
"This expression has no effect (because
cgroup_get_subsys_mount_point_end has no external side effects)."

make the function more useful like other *_end() functions by including
the check for cgroup_initialized and assigning NULL to the handle used
for iterating over controller mount points.

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

wrapper: remove false checks for snprintf

LGTM, reported that the negative value checks for snprintf() will
always be false.  The reason being the snprintf() are used to print
into a character buffer, hence chances of stream error or wide
characters encoding error are not valid here. Remove the negative
return value check across the file done after snprintf().

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

tools/cgsnapshot: rename FILE *of to output_f

LGTM, complained about using FILE *of as shorthand for the output file
and recommended using something descriptive. Rename usage of with
output_f, to keep it happy.

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Introduce vim modeline for python sources

Introduce vim modeline to python source files. This sets up the
vim editor to PEP-8 recommend editing style. The vim modeline added:
"# vim: set et ts=4 sw=4:"

'et' converts the tabs to spaces, 'ts' set the tabs indentation/tabstop
to 4 characters and 'sw' sets the shiftwidth to 4 characters.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

docs: add library version updates to release process

Add step to update Major, Minor and Release versions in configure.ac to
both release documents.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #94 from drakenclimber/issues/emptycgcreate

Add support for creating an empty cgroup v2 cgroup

python: Add support to create a cgroup on-disk

Add support to the python bindings to create a cgroup
on disk.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgcreate, tools: Allow cgroup creation with no controllers attached

Add support for creating a cgroup with no controllers attached.  This
is only supported on cgroup v2.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c: Refactor cgroup_create_cgroup()

Non-functional change to refactor cgroup_create_cgroup().  Move
the contents of this "for" loop to its own function:
for (k = 0; k < cgroup->index; k++)

This will be used as a building block for the next commit to allow
the creation of cgroups with no controllers attached.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c: fix the buffer size to read /proc/cgroups

In cgroup_init(), the first line/header of /proc/cgroups helps in
interpreting the values in the remaining of the file.  We are interested
in the rest of the file and a temporary buffer of size FILENAME_MAX is
allocated/deallocated after reading the header. The length of the header
is only 56 characters in length, excluding the newline. This patch
reduces it to LL_MAX a.k.a 100 characters.

LL_MAX is used instead of introducing another new length macro.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

libcgroup-internal.h: remove FIXME comment

As per Linux Kernel uidgid.h file, that represents internal Kernel types
for uids/gids. Initialized invalid uids/gids to -1:

  #define INVALID_UID KUIDT_INIT(-1)
  #define INVALID_GID KGIDT_INIT(-1)

initializing them to -1 is a valid, remove the FIXME comment that says
otherwise.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

api.c: add return value check for strdup()

In function cg_build_path_locked(), check for return value from
strdup(). This fixes, one of the long pending FIXME.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

error.h: make errno number reading easier

Trying to match error number with enum requires manual effort. Make it
easier by adding a comment with errno for every enum value.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

git: tools: Ignore cgxget and cgxset

Git ignore the executables cgxget and cgxset

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

github: Add a code coverage action

Add a code coverage action to the Github workflow.  As part
of this code coverage action, ignore the C file that is
auto-generated from the Cython code.  Also ignore a couple Python
header files that were confusing lcov.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

python: Add python bindings using Cython

Add python bindings via the --enable-python configure flag.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

libcgroup.so: Add a function to get the library version

Add a function, cgroup_version(), that returns the current
version of the libcgroup library.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxset: libcgroup.so: Add cgroup_cgxset() to library

Add cgroup_cgxset() to libcgroup.so.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxget: libcgroup.so: Add cgroup_cgxget() to library

Add cgroup_cgxget() to libcgroup.so.  Create a new header
file, libcgroup/tools.h, to hold C APIs that are exported
from the tools folder.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

python: Delete old python bindings

Remove the old python bindings.  They will be replaced with Cython
bindings in a subsequent commit.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

github: Skip test 38 (cpuset) on VMs hosted by Github Actions

Skip test #38 - 038-cgxget-cpuset_settings.py - on servers hosted
by Github Actions.  Test #38 sets/clears the cpuset exclusive bit
and this is not allowed on Github's servers.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add unmappable cpuset cgroup v1 settings

Add several unmappable cpuset settings.  As the name implies, these
settings have no equivalent in cgroup v2:
cpuset.mem_exclusive
cpuset.mem_hardwall
cpuset.memory_migrate
cpuset.memory_pressure
cpuset.mem_pressure_enabled
cpuset.memory_spread_page
cpuset.memory_spread_slab
cpuset.sched_load_balance
cpuset.sched_relax_domain_level

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxset: Add a flag to ignore settings that can't be converted

Add a flag, "-i", to cgxset to ignore settings that can't be
converted from cgroup v1 to cgroup v2 or vice versa.

Some cgroup v1 settings, e.g. cpuset.sched_relax_domain_level,
don't have a cgroup v2 equivalent and likely never will.  This
flag allows users to ignore errors from these unconvertable
settings.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxget: Add a flag to ignore settings that can't be converted

Add a flag, "-i", to cgxget to ignore settings that can't be
converted from cgroup v1 to cgroup v2 or vice versa.

Some cgroup v1 settings, e.g. cpuset.sched_relax_domain_level,
don't have a cgroup v2 equivalent and likely never will.  This
flag allows users to ignore errors from these unconvertable
settings.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add (currently) unmappable cpu.stat

Add an unmappable mapping for the cpu.stat setting.  While
the filename, cpu.stat, maps perfectly from v1 <-> v2, the
contents do not.  At this time, let's set this as unmappable
and revisit it when we've thought through the best way to
map the contents.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add support for unmappable settings

Add a function to explicitly handle settings that cannot
be mapped from v1 to v2 or vice versa.  This function returns
ECGNOVERSIONCONVERT which cgxget, cgxset, etc. can then
monitor and if requested by the user, ignore.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add cpuset.cpu_exclusive <-> cpuset.cpus.partition mapping

Add custom functions to map cpuset.cpu_exclusive <->
cpuset.cpus.partition.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add cpuset.{cpus,mems} <-> cpuset.{cpus,mems} mapping

Add a passthrough mapping for:
cpuset.cpus <-> cpuset.cpus
cpuset.mems <-> cpuset.mems

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add cpuset.effective_{cpus,mems} <-> cpuset.{cpus,mems}.effective mapping

Add a name-only mapping to convert:
cpuset.effective_cpus <-> cpuset.cpus.effective
cpuset.effective_mems <-> cpuset.mems.effective

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add cpu.cfs_{quota,period}_us <-> cpu.max mapping

Add custom functions to map cpu.cfs_quota_us <-> cpu.max and
cpu.cfs_period_us <-> cpu.max.  These mappings can be 1->N or
N->1 and utilize custom values for limits, "-1" in cgroup v1
and "max" in cgroup v2.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

wrapper: Add function to remove name/value pair from a controller

Add a function to remove a name/value settings pair from
a cgroup_controller instance.  As part of this change, I did a small
refactor on cgroup_free_controllers() to make the code more reusable
throughout libcgroup.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c: Add const qualifier to parameters in cgroup_read_value_begin()

Make two string parameters passed into cgroup_read_value_begin()
fully constant, i.e. const char * const.  These parameters,
controller and name, are only used as read-only variables
within cgroup_read_value_begin() and are not intended to be
modified.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c/wrapper/abstraction: Save previous setting name in control_value

When there's an N->1 mapping, the abstraction layer needs
to know which "1" setting to map back to.  Add a field to
struct control_value that saves off the original setting,
so that the abstraction layer can know how to map back from
an N->1 setting.

A good example of this is cpu.max/cpu.cfs_quota_us.  The
abstraction layer will map cpu.cfs_quota_us to cpu.max.
During the return conversion, the abstraction layer needs
to know whether to map cpu.max to cfs_quota_us or
cfs_period_us.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add passthrough function

Add a passthrough function for settings/values that require
no conversion.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add name conversion function

Add a function to the abstraction layer that can convert from
one cgroup setting name to another setting name.  The values are
not adjusted by this function.  For example, this can be used for
conversions like cpuset.effective_cpus to cpuset.cpus.effective.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxset: Introduce cgxset

Add a new libcgroup tool - cgxset.  cgxset is based upon cgset,
but it supports converting from cgroup version to another.

For example, a request like the following will work on a system
running the cgroup v1 cpu controller or the cgroup v2 cpu
controller.
            $ cgxset -2 -r cpu.weight=42 MyCgroup

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

cgxget: Introduce cgxget

Add a new libcgroup tool - cgxget.  cgxget is based upon cgget,
but it supports converting from cgroup version to another.

For example, a request like the following will work on a system
running the cgroup v1 cpu controller or the cgroup v2 cpu controller.
$ cgxget -2 -r cpu.weight MyCgroup

The return value to the user will match the cgroup version requested.
If the user requests a v1 setting, the return value will be a cgroup
v1 setting.  If the user requests a v2 setting, the return value will
be a cgroup v2 setting.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction-map: Add cpu.shares <-> cpu.weight mapping

Add a mapping from cpu.shares <-> cpu.weight.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add function to convert from one cgroup version to another

Add a function - cgroup_convert_cgroup() - that can convert from
one cgroup version to another.  This function will be the building
block for the libcgroup abstraction layer.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add integer conversion function

Add a function to the abstraction layer that can convert from
one integer setting to another.  For example, this can be used
for simple conversions like cpu.shares to cpu.weight and vice
versa.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add mapping tables

Add a table for cgroup v1 to v2 conversions -
cgroup_v1_to_v2_map[]

Add a table for cgroup v2 to v1 conversions -
cgroup_v2_to_v1_map[]

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

abstraction: Add cgroup_strtol()

Add two new files, abstraction-common.[ch], and within them add
a function, cgroup_strtol(), that can convert a string to a long.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c: Remove static from cgroup_copy_controller_values()

Remove static from cgroup_copy_controller_values() in api.c
so that other files within libcgroup can invoke it.  It will
be used by the abstraction layer code in a subsequent commit.

Also, declare *dst as a const pointer and *src as a const *
const pointer.  Subsequent abstraction layer checkins make
heavy use of const and without these changes, warnings (which
continuous integration converts to errors) are thrown.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

wrapper.c: Store the version in struct cgroup_controller

Store the cgroup version in struct cgroup_controller.  Each
controller can be mounted separately, and thus the cgroup
version is applicable at the controller level.

Note that this commit requires cgroup_init() to be called by
cgconfigparser.  Storing the version in the cgroup_controller
struct requires the cg_mount_table[] to be populated.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

groups.h: Move cg_version_t to groups.h

Move cg_version_t to libcgroup/groups.h from libcgroup-internal.h.
Introduce CGROUP_DISK version to indicate the cgroup version in
sysfs.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

automake: Don't go over 80-character lines

Nonfunctional change to line wrap lines that were 80+
characters long.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

configure: set version numbers for releases only

Let's set the version for releases only and set the development/main
branch version to 0.0.0, that differentiate between development and
releases.

Suggested-by: Tom Hromatka <tom.hromatka@oracle.com>
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #92 from drakenclimber/issues/finalize

On some pull requests, I have observed that the coveralls summary sometimes runs before all the jobs have completed.  Let's see if this fixes it.

github: Always run the finalize job

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

api.c: add support for cgroup.threads

cgroup_build_tasks_procs_path(), that builds the proc path for moving
the tid, doesn't check for the cgroup type and appends cgroup.procs for
both cgroup v1/v2.  With cgroup v2, this results in building a wrong
proc path if the cgroup type is threaded. This patch adds support to
check for the cgroup v2 type and build the proc path according to the
below table:

cgroup.type     | proc file      | Description                        |
----------------+----------------+------------------------------------+
domain          | cgroup.procs   | regular cgroup, all threads gets   |
                |                | moved to the cgroup.               |
domain threaded | cgroup.procs   | root of threaded subtree, all      |
                |                | threads gets moved to the cgroup.  |
threaded        | cgroup.threads | cgroup under threaded subtree,     |
|  | single threads with matching tid,  |
|  | gets moved to the cgroup.          |
domain invalid  | N/A            | invalid state of a cgroup under the|
                |                | threaded subtree.                  |

Closes: https://github.com/libcgroup/libcgroup/issues/64
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #86 from drakenclimber/issues/lgtm

ENH: Add LGTM badge to README.md

README.md: Add LGTM badge

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

Merge pull request #85 from drakenclimber/issues/codeql

ENH: Add Security Features

api.c: Fix TOCTOU race in cgroup_get_procs()

codeql flagged a potential race between the time-of-check
and time-of-use (CWE-367) of the cgroup.procs file in
cgroup_get_procs().

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

github: Add a code security scan

Add a code security scan, CodeQL to the Github Actions
continuous integration.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

SECURITY.md: Add security file

Add a SECURITY.md file that outlines the process for handling
security-related vulnerabilities.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

api.c: cache cgrules with CGFLAG_USECACHE flag

pam_cgroup.so plugin uses /etc/cgrules.conf to assign processes
to the requested cgroup.  This works well with active
cgrulesengd but in the instances where cgrulesengd is disabled,
the rules are not read and cached by default. Fix this is by
reloading and caching the rules when called with CGFLAG_USECACHE
flag.

Fixes: https://github.com/libcgroup/libcgroup/issues/84
Reported-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
TJH: Minor commit comment changes

Merge pull request #83 from drakenclimber/issues/doxygen_badge

README.md: Add Doxygen badge

README.md: Add Doxygen badge

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal kamalesh.babulal@oracle.com

github: Move Doxygen Folder

After Doxygen is built, move the html folder under doc/.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #79 from drakenclimber/issues/doxygen

github: Add Doxyfile and github doxygen action

github: Add Doxyfile and github doxygen action

Add a default Doxyfile and a doxygen action.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

Initialize cgroup version for named V1 hierarchy

Commit 3aac9889 added the 'version' field in cg_mount_table_s and
initializes it in cgroup_process_v1_mnt(). The same initialization is
required in a second place dealing with named hierarchies.

Signed-off-by: Ingo van Lil <inguin@gmx.de>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #74 from drakenclimber/issues/73

api.c: Allow reading/writing from cgroup.* files in cgroup v2

api.c: Allow reading/writing from cgroup.* files in cgroup v2

Allow reading/writing from cgroup.* files (such as cgroup.type
and cgroup.procs) on cgroup v2 filesystems.

Closes: https://github.com/libcgroup/libcgroup/issues/73
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

Merge pull request #76 from drakenclimber/issues/71

github: Force a fresh clone on all self-hosted runners

github: Force a fresh clone on all self-hosted runners

The cgroup v2 job is being run on a self-hosted runner that
re-uses the workspace.  Delete the local workspace on all
self-hosted runners prior to cloning the repo.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #75 from drakenclimber/issues/71v2

tests: Update submodule to the latest commit on libcgroup-tests main

tests: Update submodule to the latest commit on libcgroup-tests main branch

Closes: https://github.com/libcgroup/libcgroup/issues/71
Reported-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

automake: idiomatically mark test libraries as convenience libraries

Instead of installing then deleting, mark the libraries which are only
used at build time and should not be installed as noinst, so they don't
get installed at all.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

automake: Don't install testing libraries

libcgset and libcgfortesting are libraries that are used by the
unit test framework and are not intended to be installed when
`make install` is invoked.  Delete them from the install path.

Closes: https://github.com/libcgroup/libcgroup/issues/62
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

automake: Link libcgset with libcgroup

When linking with the -Wl,--no-undefined flag enabled, libcgset
fails due to undefined symbols.  Fix this by enabling this flag
and linking with libcgroup.la

Closes: https://github.com/libcgroup/libcgroup/issues/66
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

README: fix typos across the file

Fix a couple of typos across the file.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

cgclassify: fix error message

Fix the typo in the error message, while trying to parse the cgroup to
place the task.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

github: re-arrange workflow run commands

The current workflow executes the functional tests from the make check
called at the top-level source directory. Though this runs the tests
case, it also has an unintended side effect of re-running gunit tests
for every functional test combination in the workflow. Fix it, by
re-arranging the function test run commands, to change into
tests/ftests directory before executing make check.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

configure.ac: check for the library containing fts_open

The musl C library doesn't provide fts.h[1], so libcgroup doesn't
compile with musl. However, there is a standalone implementation of fts
for musl users[2] which can be used.

Use AC_SEARCH_LIBS to search for fts_open, which will check if it is part
of libc, and if not look in libfts, then set LIBS if needed.

[1] https://wiki.musl-libc.org/faq.html
[2] https://github.com/void-linux/musl-fts

Closes #61.

Signed-off-by: Ross Burton <ross.burton@arm.com>
[TJH: minor formatting changes to match existing configure.ac]
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #59 from drakenclimber/issues/mainbadge

README.md: Display status of main branch in build status badge

README.md: Display status of main branch in build status badge

The master branch was renamed to main, but the build status
badge wasn't updated as part of this change.  Display the
build status of the main branch in README.md

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #57 from drakenclimber/issues/fixmerge

github: Fix merge collision in v1/v2 code coverage

github: Fix merge collision in v1/v2 code coverage

Fix merge collision in the gathering of the v1/v2
code coverage metrics.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #56 from drakenclimber/issues/improvecodecov

github: Improve code coverage collection

github: Improve code coverage collection

Improve code coverage collection by utilizing the "-i" flag
prior to the run.  This allows coverage on #ifdef'ed code.

Also, archive the code coverage files for later analysis if
desired.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #54 from drakenclimber/issues/removetestsdir

github: Delete the tests folder before bootstrap

github: Delete the tests folder before bootstrap

On self-hosted github machines, the working directory for
libcgroup is reused from one run to the next.  This is fine
for the root of the directory as the proper git clean/reset
commands are issues.  But this is problematic for the git
submodules like the tests/ folder because clean/reset is nott
run there.

Remove the tests/ directory entirely and rely on ./bootstrap.sh
to recreate and populate it.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #53 from drakenclimber/pull/45

Replace __BEGIN_DECLS and __END_DECLS with extern "C".

Replace __BEGIN_DECLS and __END_DECLS with extern "C".

The macros __BEGIN_DECLS and __END_DECLS are a GNU-ism found in
glibc and uClibc, but not musl.  We replace them by the more general
extern "C" { ... } block exposed only if we have __cplusplus.

Forward ported from a patch by Anthony G. Basile <blueness@gentoo.org>.

Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #52 from drakenclimber/issues/cgv2-tests

github: Add self-hosted runner

github: Add self-hosted runner

Add a self-hosted runner to test full v2 functionality

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #51 from drakenclimber/issues/contributing

docs: Add CONTRIBUTING.md

docs: Add CONTRIBUTING.md

Add a document that outlines the steps to contribute to
libcgroup.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Merge pull request #49 from drakenclimber/issues/delete-cgclear

cgclear: Delete cgclear

Merge pull request #48 from drakenclimber/issues/apt-update

github: Run apt update before apt install

github: Run apt update before apt install

Run apt update before apt install

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>