]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Alan T. DeKok [Mon, 23 Nov 2020 21:00:22 +0000 (16:00 -0500)]
use UTC for date to string, too.
Manual port of
7ea17db2d2 from v3.0.x
James Jones [Sat, 21 Nov 2020 16:16:00 +0000 (10:16 -0600)]
Make sure fr_sbuff_extend_file() NUL terminates the extended sbuff (#3756)
We include a test in sbuff_tests.c that exercises this.
Terry Burton [Sat, 21 Nov 2020 16:12:20 +0000 (16:12 +0000)]
CI: Upload clang scan analysis artifacts upon failure (#3758)
Moved actions from ci/build.sh into distinct steps in the job.
ci/build.sh retained for now so that Jenkins can be refreshed.
Jorge Pereira [Fri, 20 Nov 2020 21:35:04 +0000 (18:35 -0300)]
Typo
Alan T. DeKok [Thu, 19 Nov 2020 19:27:27 +0000 (14:27 -0500)]
don't initialize until *after* the NULL check
Arran Cudbard-Bell [Thu, 19 Nov 2020 15:23:55 +0000 (09:23 -0600)]
Fix duplicate
Arran Cudbard-Bell [Thu, 19 Nov 2020 14:55:09 +0000 (08:55 -0600)]
Fixup dictionary debugging functions
Terry Burton [Thu, 19 Nov 2020 03:13:45 +0000 (03:13 +0000)]
CI: Add GitHub Super-Linter (#3747)
Performs a full run on push to the "linter" branch, otherwise only lints
changed files.
Arran Cudbard-Bell [Thu, 19 Nov 2020 00:07:33 +0000 (18:07 -0600)]
Fix test framework to deal with the error stack being in a new order
Arran Cudbard-Bell [Wed, 18 Nov 2020 23:45:39 +0000 (17:45 -0600)]
Move common acutest helps out into a separate header
Invert fr_strerror_pop order
Arran Cudbard-Bell [Wed, 18 Nov 2020 20:06:19 +0000 (14:06 -0600)]
Another way of quieting clang scan
Alan T. DeKok [Wed, 18 Nov 2020 19:28:06 +0000 (14:28 -0500)]
fix as per changed behavior
Arran Cudbard-Bell [Wed, 18 Nov 2020 19:13:59 +0000 (13:13 -0600)]
Quick hack to get `%(func:<discreet args>)` working
Arran Cudbard-Bell [Wed, 18 Nov 2020 18:47:08 +0000 (12:47 -0600)]
Remove da_has_ref and fix group default references
Arran Cudbard-Bell [Wed, 18 Nov 2020 18:25:40 +0000 (12:25 -0600)]
Helps to initialise the marker
Alan T. DeKok [Wed, 18 Nov 2020 18:22:29 +0000 (13:22 -0500)]
no idea why this was committed
Alan T. DeKok [Wed, 18 Nov 2020 18:13:57 +0000 (13:13 -0500)]
update comment
Alan T. DeKok [Wed, 18 Nov 2020 18:11:41 +0000 (13:11 -0500)]
quote nothing means output nothing
and test *in for encoding, as "in" will always be non-NULL
Alan T. DeKok [Wed, 18 Nov 2020 18:10:53 +0000 (13:10 -0500)]
no input means an error
Arran Cudbard-Bell [Wed, 18 Nov 2020 18:05:05 +0000 (12:05 -0600)]
Passing a NULL box pointer to a box printing function is an error
Arran Cudbard-Bell [Wed, 18 Nov 2020 18:02:31 +0000 (12:02 -0600)]
Check to see if the list head contains boxes, not whether we were passed a list head
jsonquote shouldn't error out on NULL input
Alan T. DeKok [Wed, 18 Nov 2020 17:42:47 +0000 (12:42 -0500)]
if there's no value box, add an empty string
Alan T. DeKok [Wed, 18 Nov 2020 17:41:28 +0000 (12:41 -0500)]
don't print zero data
Arran Cudbard-Bell [Wed, 18 Nov 2020 17:28:39 +0000 (11:28 -0600)]
Add new OID processing functions
Alan T. DeKok [Wed, 18 Nov 2020 16:51:25 +0000 (11:51 -0500)]
document stuff!
Alan T. DeKok [Tue, 17 Nov 2020 20:55:38 +0000 (15:55 -0500)]
add tests for IPv6 prefix
Nick Porter [Wed, 18 Nov 2020 14:28:54 +0000 (14:28 +0000)]
v4: Replace fr_pair_t * with fr_pair_list_t in structures (#3754)
* Alter request control and state fr_pair_t * to fr_pair_list_t
* Alter rc_request filter to be fr_pair_list_t
* Amend rs_request_t link_vps to be fr_pair_list_t
* Amend rs filter_request_vps and filter_response_vps to fr_pair_list_t
* Ament mschapv2_opaque_t mppe_keys and repy to be fr_pair_list_t
* Amend peap_tunnel_t soh_reply_vps to be fr_pair_list_t
* Amend udp_request_s extra to be fr_pair_list_t
* Amend rlm_isc_dhcp_info_s options to be fr_pair_list_t
* Replace fr_pair_t ** with fr_pair_list_t * in tmpl.h structures
* Amend fr_trigger_t vps to be fr_pair_list_t
* Amend fr_pool_s trigger_args to be fr_pair_list_t
* Amend PAIR_LIST check and reply to be fr_pair_list_t
* Amend listen_socket_t cert_vps to be fr_pair_list_t
* Amend exfile_s trigger_args to be fr_pair_list_t
* Ament fr_radius_packet_t vps to be fr_pair_list_t
* Amend unlang_frame_state_foreach_t vps to be fr_pair_list_t
and format tidy
* Amend unlang_frame_state_tmpl_t vps to be fr_pair_list_t
No initialisation is done as vps is passed in to unlang_tmpl_push when
structure is created.
* Amend fr_redis_cluster trigger_args to be fr_pair_list_t
Nick Porter [Wed, 18 Nov 2020 01:25:38 +0000 (01:25 +0000)]
V4: replace instances of fr_pair_t * on the stack, that represent a list, with fr_pair_list_t (#3743)
* s/fr_pair_t */fr_pair_list_t/ in radsniff.c
* s/fr_pair_t */fr_pair_list_t/ in unit_test_attribute.c
* s/fr_pair_t */fr_pair_list_t/ in unit_test_module.c
* s/fr_pair_t */fr_pair_list_t/ in curl/base.c
* s/fr_pair_t */fr_pair_list_t/ in eap/base.c
* s/fr_pair_t */fr_pair_list_t/ in eap_aka_sim/decode.c
* Correct return type of fr_pair_add_by_da() and fr_pair_update_by_da()
* s/fr_pair_t */fr_pair_list_t/ in eap_aka_sim/state_machine.c
* s/fr_pair_t */fr_pair_list_t/ in ldap/map.c
* s/fr_pair_t */fr_pair_list_t/ in redis/cluster.c
* s/fr_pair_t */fr_pair_list_t/ in server/exec.c
* s/fr_pair_t */fr_pair_list_t/ in server/exfile.c
* s/fr_pair_t */fr_pair_list_t/ in server/map.c
* s/fr_pair_t */fr_pair_list_t/ in server/map_async.c
* s/fr_pair_t */fr_pair_list_t/ in server/snmp.c
* s/fr_pair_t */fr_pair_list_t/ in server/state.c
* s/fr_pair_t */fr_pair_list_t/ in server/tmpl_eval.c
* s/fr_pair_t */fr_pair_list_t/ in server/trigger.c
* s/fr_pair_t */fr_pair_list_t/ in server/users_file.c
* s/fr_pair_t */fr_pair_list_t/ in tls/validate.c
* s/fr_pair_t */fr_pair_list_t/ in unlang/foreach.c
* s/fr_pair_t */fr_pair_list_t/ in unlang/xlat_builtin.c
* s/fr_pair_t */fr_pair_list_t/ in util/pair_print.c
* s/fr_pair_t */fr_pair_list_t/ in util/struct.c
* s/fr_pair_t */fr_pair_list_t/ in proto_radius_load.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_attr_filter.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_cache.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_client.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_csv.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_dhcpv4.c
* s/fr_pair_t */fr_pair_list_t/ in eap_fast.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_eap_fast.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_eap_mschapv2.c
* s/fr_pair_t */fr_pair_list_t/ in peap.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_eap_ttls/ttls.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_exec.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_files.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_json.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_ldap/groups.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_radius_udp.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_rest/rest.c
* s/fr_pair_t */fr_pair_list_t/ in rlm_sql.c
* s/fr_pair_t */fr_pair_list_t/ in dhcpv4/packet.c
* s/fr_pair_t */fr_pair_list_t/ in dhcpv6/decode.c
* s/fr_pair_t */fr_pair_list_t/ in dhcpv6/encode.c
* s/fr_pair_t */fr_pair_list_t/ in radius/decode.c
* s/fr_pair_t */fr_pair_list_t/ in radius/packet.c
Arran Cudbard-Bell [Wed, 18 Nov 2020 01:19:30 +0000 (19:19 -0600)]
Notes on fr_pair_alloc
Arran Cudbard-Bell [Wed, 18 Nov 2020 00:31:23 +0000 (18:31 -0600)]
Revert "RPM: Disable rlm_curl (and rlm_rest) in RHEL < 8."
This reverts commit
80e28bf77e633850ec830f55683ae64b8d57a96a .
Arran Cudbard-Bell [Wed, 18 Nov 2020 00:31:07 +0000 (18:31 -0600)]
7.24 is the bare minimum libcurl version we need
Terry Burton [Tue, 17 Nov 2020 22:19:40 +0000 (22:19 +0000)]
RPM: Set SELinux tunable radius_use_jit=1 after installation (#3751)
Terry Burton [Tue, 17 Nov 2020 21:03:38 +0000 (21:03 +0000)]
RPM: Disable rlm_curl (and rlm_rest) in RHEL < 8.
cURL >= 7.45 is not available until CentOS 8.
Terry Burton [Tue, 17 Nov 2020 20:10:27 +0000 (20:10 +0000)]
Docker CentOS build: Install a recent version of make from SCL
Required since
fbb6e762650259009ce65f8ba6122684f50680ec
Alan T. DeKok [Tue, 17 Nov 2020 20:37:40 +0000 (15:37 -0500)]
fix prefix length encoding / decoding
by adding a function to do the dirty work
Alan T. DeKok [Tue, 17 Nov 2020 20:37:22 +0000 (15:37 -0500)]
more tests for commit
eb807ffa
Alan T. DeKok [Sun, 15 Nov 2020 15:11:44 +0000 (10:11 -0500)]
align hex output
Arran Cudbard-Bell [Tue, 17 Nov 2020 19:37:34 +0000 (13:37 -0600)]
Fix issue with sigtran.authorize
Arran Cudbard-Bell [Tue, 17 Nov 2020 19:31:28 +0000 (13:31 -0600)]
Fix crash on exit for certain virtual servers
Arran Cudbard-Bell [Tue, 17 Nov 2020 19:30:47 +0000 (13:30 -0600)]
Formatting
Arran Cudbard-Bell [Tue, 17 Nov 2020 18:56:33 +0000 (12:56 -0600)]
Don't attempt to deploy on PR
Jorge Pereira [Tue, 17 Nov 2020 01:49:20 +0000 (22:49 -0300)]
:tool: Update acutest.h to the latest version (#3748)
* Suppress leak warnings in tzset() on OSX
* Update acutest.h to the latest version
It was updated to the latest `
b89ea78 ` revision from
oficial repo https://github.com/mity/acutest/commits/master
* Rename 's/test_verbose_level__/test_verbose_level_/g'
It is necessary to use the latest acutest.h
Arran Cudbard-Bell [Mon, 16 Nov 2020 17:04:14 +0000 (11:04 -0600)]
IA-PD-Prefix-IPv6-Prefix should be a prefix type
The DHCPv6 standard changes the encoding based on whether it's a struct field or an option, which is why it was a fixed length v6 address before. Unfortunately none of the modules in FreeRADIUS will work with a prefix value split into its components
Arran Cudbard-Bell [Mon, 16 Nov 2020 14:50:17 +0000 (08:50 -0600)]
Add vendor-specific equivalent to DHCP-Error-Message
Arran Cudbard-Bell [Sun, 15 Nov 2020 18:06:19 +0000 (12:06 -0600)]
Add value for Do-Not-Respond
Arran Cudbard-Bell [Sun, 15 Nov 2020 17:58:59 +0000 (11:58 -0600)]
add mode for printing out values
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:57:06 +0000 (10:57 -0600)]
Get a valid cpu/wallclock offset in the test utilities
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:49:00 +0000 (10:49 -0600)]
Attributes contain unix time, not internal time
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:13:58 +0000 (10:13 -0600)]
Remove junk from tests
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:09:17 +0000 (10:09 -0600)]
Stupid symbol auto-complete
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:08:08 +0000 (10:08 -0600)]
Revert "Hex doesn't need to extend"
This reverts commit
ec61b5763e140c225223f199238d18dc8ff01c67 .
Arran Cudbard-Bell [Sun, 15 Nov 2020 16:02:29 +0000 (10:02 -0600)]
Fix leaked marker
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:55:38 +0000 (09:55 -0600)]
Simplify relay encoder
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:53:30 +0000 (09:53 -0600)]
dbuff: Copy ahead/behind macros from sbuffs
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:53:15 +0000 (09:53 -0600)]
Fixup fr_dhcpv6_encode to return the correct length
Fix magic numbers
Make code more concise
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:43:27 +0000 (09:43 -0600)]
Hex doesn't need to extend
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:43:16 +0000 (09:43 -0600)]
Split out tests
Arran Cudbard-Bell [Sun, 15 Nov 2020 15:42:05 +0000 (09:42 -0600)]
Add FR_VALUE_BOX_TO_NETWORK_RETURN
Alan T. DeKok [Sat, 14 Nov 2020 20:41:05 +0000 (15:41 -0500)]
add function to pretty-print DHCPv6 packets as hex
Alan T. DeKok [Sat, 14 Nov 2020 19:50:06 +0000 (14:50 -0500)]
We need <sys/wait.h> on Linux
Alan T. DeKok [Sat, 14 Nov 2020 19:32:25 +0000 (14:32 -0500)]
try to work around libkqueue issues on Linux
Arran Cudbard-Bell [Sat, 14 Nov 2020 17:46:10 +0000 (11:46 -0600)]
Just return slen
Arran Cudbard-Bell [Sat, 14 Nov 2020 17:32:28 +0000 (11:32 -0600)]
simplify fr_value_box_to_network
Alan T. DeKok [Sat, 14 Nov 2020 14:40:06 +0000 (09:40 -0500)]
update for whitespace changes
Alan T. DeKok [Sat, 14 Nov 2020 13:49:52 +0000 (08:49 -0500)]
there is a trailing space after the length
Alan T. DeKok [Sat, 14 Nov 2020 13:24:12 +0000 (08:24 -0500)]
typo
Alan T. DeKok [Sat, 14 Nov 2020 13:12:06 +0000 (08:12 -0500)]
add relay reply test
Alan T. DeKok [Sat, 14 Nov 2020 13:08:16 +0000 (08:08 -0500)]
<sigh> Header fields are NOT OPTIONAL
if there's no VP for the header field, we MUST encode SOMETHING.
Doing anything else is utterly ridiculous
Alan T. DeKok [Sat, 14 Nov 2020 13:05:15 +0000 (08:05 -0500)]
if no original, fall through to encoding the header from VPs
Alan T. DeKok [Sat, 14 Nov 2020 13:04:19 +0000 (08:04 -0500)]
added debugging
Arran Cudbard-Bell [Sat, 14 Nov 2020 00:59:57 +0000 (18:59 -0600)]
Process extents lifo style
Arran Cudbard-Bell [Sat, 14 Nov 2020 00:57:08 +0000 (18:57 -0600)]
Allocate from the correct ctx in subrequest.c
Terry Burton [Sat, 14 Nov 2020 00:45:57 +0000 (00:45 +0000)]
CI: Only trigger scheduled coverity scans from main repo (#3746)
Arran Cudbard-Bell [Sat, 14 Nov 2020 00:29:04 +0000 (18:29 -0600)]
Formatting
Arran Cudbard-Bell [Fri, 13 Nov 2020 23:38:01 +0000 (17:38 -0600)]
Fix edge case in fr_dict_attr_common_parent
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:59:45 +0000 (16:59 -0600)]
For proxied requests don't filer reply attributes by protocol
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:59:27 +0000 (16:59 -0600)]
Only print attributes of... the actual protocol!
Do as the name suggests. Only took three years...
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:20:51 +0000 (16:20 -0600)]
Have the DHCPv6 state machine the work of creating the canned reply
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:12:56 +0000 (16:12 -0600)]
Formatting
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:12:49 +0000 (16:12 -0600)]
Allow limits to be set on the number of attributes copied
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:12:09 +0000 (16:12 -0600)]
Sort
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:12:01 +0000 (16:12 -0600)]
Add doxygen headers for request_data_add
It's annoying to try and puzzle out what all the arguments mean.
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:09:07 +0000 (16:09 -0600)]
More indenting
Arran Cudbard-Bell [Fri, 13 Nov 2020 22:06:59 +0000 (16:06 -0600)]
Indent pair lists by default
Alan T. DeKok [Fri, 13 Nov 2020 21:00:56 +0000 (16:00 -0500)]
remove unused printf arg
Arran Cudbard-Bell [Fri, 13 Nov 2020 19:39:28 +0000 (13:39 -0600)]
Fix fr_pair_list_log to print nested attributes with indentation
Alan T. DeKok [Fri, 13 Nov 2020 18:09:44 +0000 (13:09 -0500)]
make the virtual servers call app_process bootstrap / instantiate
so that the proto_* modules don't need to do it.
and now that the app_process pointer is cached, each 'type = foo'
app_process handler is bootstrapped / instantiated only once,
instead of multiple times as before.
Alan T. DeKok [Fri, 13 Nov 2020 17:50:44 +0000 (12:50 -0500)]
cache the entire dl_module_inst_t* for packet types
which means that we can not only get the process function by name
as before, but we also have full access to the data for calling
bootstrap, instantiate, etc.
Alan T. DeKok [Fri, 13 Nov 2020 17:38:24 +0000 (12:38 -0500)]
rename variable
Alan T. DeKok [Fri, 13 Nov 2020 16:07:46 +0000 (11:07 -0500)]
move proto name argument to be a little cleaner
Alan T. DeKok [Fri, 13 Nov 2020 16:05:12 +0000 (11:05 -0500)]
remove code_allowed[code]. It's redundant with type_submodule_by_code
Alan T. DeKok [Fri, 13 Nov 2020 16:01:19 +0000 (11:01 -0500)]
move settings of type_submodule_by_name to the type_parse function
Alan T. DeKok [Thu, 12 Nov 2020 20:46:07 +0000 (15:46 -0500)]
pull necessary work from fr_app_process_type_parse()
in preparation for drastically simplifying the booting process
Alan T. DeKok [Thu, 12 Nov 2020 20:38:15 +0000 (15:38 -0500)]
initialize "code"
Alan T. DeKok [Thu, 12 Nov 2020 20:27:20 +0000 (15:27 -0500)]
we don't use recv/send sections for control sockets
so might as well nuke them
Alan T. DeKok [Thu, 12 Nov 2020 20:23:16 +0000 (15:23 -0500)]
remove unused code
Alan T. DeKok [Thu, 12 Nov 2020 20:17:25 +0000 (15:17 -0500)]
remove unused files
Arran Cudbard-Bell [Fri, 13 Nov 2020 18:39:10 +0000 (12:39 -0600)]
Return the reply packet type
Arran Cudbard-Bell [Fri, 13 Nov 2020 18:13:46 +0000 (12:13 -0600)]
Helps to set the extent
Arran Cudbard-Bell [Fri, 13 Nov 2020 18:10:37 +0000 (12:10 -0600)]
fr_pair_list_copy should append not prepend