]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/log
thirdparty/foundation/foundation-sites.git
7 years agofix: toggle dropdown if there is no focusable element inside 11123/head
Daniel Ruf [Tue, 3 Apr 2018 21:54:24 +0000 (23:54 +0200)] 
fix: toggle dropdown if there is no focusable element inside

7 years agoMerge pull request #11116 from ncoden/fix/abide-permissive-url-regexp-9180
Nicolas Coden [Tue, 3 Apr 2018 17:25:25 +0000 (19:25 +0200)] 
Merge pull request #11116 from ncoden/fix/abide-permissive-url-regexp-9180

fix: use more permissive URL pattern for Abide #9180

7 years agoMerge pull request #11090 from ncoden/chore/various-travis-tests-improvments
Nicolas Coden [Tue, 3 Apr 2018 09:42:04 +0000 (11:42 +0200)] 
Merge pull request #11090 from ncoden/chore/various-travis-tests-improvments

chore: various Travis tests improvements

7 years agofeat: add SFTP & FTPS to Abide valid urls protocols 11116/head
Nicolas Coden [Tue, 3 Apr 2018 09:29:59 +0000 (11:29 +0200)] 
feat: add SFTP & FTPS to Abide valid urls protocols

7 years agodocs: remove line added by accident in Abide regex docs
Nicolas Coden [Tue, 3 Apr 2018 09:26:48 +0000 (11:26 +0200)] 
docs: remove line added by accident in Abide regex docs

7 years agoMerge pull request #11106 from ncoden/fix/fix-reveal-extend-in-mediaquery
Nicolas Coden [Tue, 3 Apr 2018 09:23:33 +0000 (11:23 +0200)] 
Merge pull request #11106 from ncoden/fix/fix-reveal-extend-in-mediaquery

fix: Reveal sass error with @extend within mediaquery

7 years agoMerge remote-tracking branch 'zurb/develop' into chore/various-travis-tests-improvments 11090/head
Nicolas Coden [Tue, 3 Apr 2018 09:22:37 +0000 (11:22 +0200)] 
Merge remote-tracking branch 'zurb/develop' into chore/various-travis-tests-improvments

7 years agoMerge pull request #11117 from ncoden/fix/xy-grid-cell-width-overridden-10468
Nicolas Coden [Tue, 3 Apr 2018 09:20:26 +0000 (11:20 +0200)] 
Merge pull request #11117 from ncoden/fix/xy-grid-cell-width-overridden-10468

fix: fix cell widths overridden by readjusted smaller breakpoints in XY Grid #10468

7 years agoMerge pull request #11114 from ncoden/feat/tooltip-disable-for-touch-9995
Nicolas Coden [Tue, 3 Apr 2018 06:25:01 +0000 (08:25 +0200)] 
Merge pull request #11114 from ncoden/feat/tooltip-disable-for-touch-9995

feat: add back official `disableForTouch` option for Tooltip #9995

7 years agoMerge pull request #11120 from ncoden/fix/prevent-commit-with-failing-tests
Nicolas Coden [Mon, 2 Apr 2018 21:10:42 +0000 (23:10 +0200)] 
Merge pull request #11120 from ncoden/fix/prevent-commit-with-failing-tests

fix: prevent push/commit with falling tests with Husky

7 years agofix: prevent push/commit with falling tests with Husky 11120/head
Nicolas Coden [Mon, 2 Apr 2018 19:46:24 +0000 (21:46 +0200)] 
fix: prevent push/commit with falling tests with Husky

7 years agoMerge pull request #11111 from DanielRuf/tests/use-husky
Nicolas Coden [Mon, 2 Apr 2018 15:14:59 +0000 (17:14 +0200)] 
Merge pull request #11111 from DanielRuf/tests/use-husky

tests: use husky to run tests before commits and pushes

7 years agofix: force color mode for gulp and husky scripts 11111/head
Daniel Ruf [Sun, 1 Apr 2018 23:54:49 +0000 (01:54 +0200)] 
fix: force color mode for gulp and husky scripts

7 years agofix: force color mode of mocha, remove code test output in husky scripts
Daniel Ruf [Sun, 1 Apr 2018 23:44:03 +0000 (01:44 +0200)] 
fix: force color mode of mocha, remove code test output in husky scripts

7 years agofix: fix wrong script for husky prepush hook
Nicolas Coden [Sun, 1 Apr 2018 21:58:20 +0000 (23:58 +0200)] 
fix: fix wrong script for husky prepush hook

7 years agochore: update package-lock.json
Nicolas Coden [Sun, 1 Apr 2018 21:53:14 +0000 (23:53 +0200)] 
chore: update package-lock.json

7 years agochore: change prepush script to use the new script
Daniel Ruf [Sun, 1 Apr 2018 20:28:44 +0000 (22:28 +0200)] 
chore: change prepush script to use the new script

7 years agochore: use Node.js for precommit and prepush output
Daniel Ruf [Sun, 1 Apr 2018 20:26:26 +0000 (22:26 +0200)] 
chore: use Node.js for precommit and prepush output

7 years agochore: add message for about Husky at precommit & prepush
Nicolas Coden [Sun, 1 Apr 2018 16:24:53 +0000 (18:24 +0200)] 
chore: add message for about Husky at precommit & prepush

7 years agotests: use husky to run tests before commits and pushes
Daniel Ruf [Fri, 30 Mar 2018 22:10:47 +0000 (00:10 +0200)] 
tests: use husky to run tests before commits and pushes

7 years agofix: fix cell widths overridden by readjusted smaller breakpoints in XY Grid #10468 11117/head
Nicolas Coden [Sun, 1 Apr 2018 21:30:26 +0000 (23:30 +0200)] 
fix: fix cell widths overridden by readjusted smaller breakpoints in XY Grid #10468

With margin gutters, a cell width is defined with its gutter. This is why we have to readjust all sizes and not only `.cell` when applying the new gutter in a bigger breakpoint. This must include all sizes for smaller breakpoints too.

Before this commit there was an optimization that prevent gutters for smaller breakpoints without a new gutter defined to be regenerated. This can seems logical since no gutter was generated for this breakpoint so there is nothing to readjust.

However, because the gutter is defined _with the width/height_, the readjusted width/height of readjusted gutters (with a custom gutter) overrides the width/height of bigger non-readjusted (without a custom gutter) breakpoint.

Changes:
* Readjust gutters for all breakpoints even without new gutter defined
* Add explainaitions

Closes https://github.com/zurb/foundation-sites/issues/10468

7 years agofix: use more permissive URL pattern for Abide #9180
Nicolas Coden [Sun, 1 Apr 2018 18:20:04 +0000 (20:20 +0200)] 
fix: use more permissive URL pattern for Abide #9180

Note: the new RegExp is close to an "Standard URL validation" and allow a lot of valid URLs that may have to be forbidden on the end website (intrants, local domains, utf8 & unicode characters...).
For more restrictive RegExps, see https://mathiasbynens.be/demo/url-regex.

Closes https://github.com/zurb/foundation-sites/issues/9180
From https://github.com/talyssonoc/CommonRegexJS/blob/e2901b9f57222bc14069dc8f0598d5f412555411/lib/commonregex.js#L76

7 years agoMerge pull request #11108 from DanielRuf/fix/slider-input-change-event-enter-11096
Nicolas Coden [Sat, 31 Mar 2018 20:06:58 +0000 (22:06 +0200)] 
Merge pull request #11108 from DanielRuf/fix/slider-input-change-event-enter-11096

fix: listen for the enter key and trigger a change to emulate change …

7 years agofeat: add back official `disableForTouch` option for Tooltip #9995 11114/head
Nicolas Coden [Sat, 31 Mar 2018 16:09:53 +0000 (18:09 +0200)] 
feat: add back official `disableForTouch` option for Tooltip #9995

Changes:
* Add documentation for the `disableForTouch` option
* Prevent any event to be triggerd on touch with `disableForTouch`, including mouse enter/leave and focus events

Closes https://github.com/zurb/foundation-sites/issues/9995

7 years agoMerge pull request #10978 from JasonMiller/breakpoint-mixin-max-width-values
Nicolas Coden [Fri, 30 Mar 2018 21:51:09 +0000 (23:51 +0200)] 
Merge pull request #10978 from JasonMiller/breakpoint-mixin-max-width-values

Breakpoint Mixin `max-width` Values

7 years agofix: revert to Sass default 5-digit precision for breakpoint gutters 10978/head
Nicolas Coden [Fri, 30 Mar 2018 21:02:15 +0000 (23:02 +0200)] 
fix: revert to Sass default 5-digit precision for breakpoint gutters

I was wrong, Sass actually has a default precision of 5 digits. Bootstrap-sass uses 8 digits but require to update the Sass compiler options.
See: https://github.com/twbs/bootstrap-sass#sass-number-precision

Note: this also update breakpoint tests

7 years agoMerge pull request #10600 from marcelox/patch-1
Nicolas Coden [Fri, 30 Mar 2018 20:38:07 +0000 (22:38 +0200)] 
Merge pull request #10600 from marcelox/patch-1

Set border-width variable on button-base mixin

7 years agoMerge pull request #11091 from ncoden/fix/dropdown-menu-closing-on-scroll-9823
Nicolas Coden [Fri, 30 Mar 2018 19:46:59 +0000 (21:46 +0200)] 
Merge pull request #11091 from ncoden/fix/dropdown-menu-closing-on-scroll-9823

fix: fix dropdownMenu closing on touch scroll #9823

7 years agoMerge pull request #11103 from zurb/andycochran/9268-breakpoint-error-message
Nicolas Coden [Fri, 30 Mar 2018 14:33:25 +0000 (16:33 +0200)] 
Merge pull request #11103 from zurb/andycochran/9268-breakpoint-error-message

more accurate -zf-zero-breakpoint error message

7 years agoMerge remote-tracking branch 'zurb/develop' into fix/dropdown-menu-closing-on-scroll... 11091/head
Nicolas Coden [Thu, 29 Mar 2018 21:44:32 +0000 (23:44 +0200)] 
Merge remote-tracking branch 'zurb/develop' into fix/dropdown-menu-closing-on-scroll-9823

7 years agofix: properly indent lines 11108/head
Daniel Ruf [Thu, 29 Mar 2018 21:32:26 +0000 (23:32 +0200)] 
fix: properly indent lines

7 years agofix: deduplicate the code for the event listeners
Daniel Ruf [Thu, 29 Mar 2018 21:26:19 +0000 (23:26 +0200)] 
fix: deduplicate the code for the event listeners

7 years agoMerge pull request #10930 from ncoden/fix/fix-es6-plugins-webpack-build-2
Nicolas Coden [Thu, 29 Mar 2018 21:18:42 +0000 (23:18 +0200)] 
Merge pull request #10930 from ncoden/fix/fix-es6-plugins-webpack-build-2

chore: UMD module bundling

7 years agoMerge pull request #11099 from DanielRuf/fix/apply-menubar-aria-role-11097
Nicolas Coden [Thu, 29 Mar 2018 21:17:27 +0000 (23:17 +0200)] 
Merge pull request #11099 from DanielRuf/fix/apply-menubar-aria-role-11097

fix: apply menubar aria role instead of menu

7 years agofix: listen for the enter key and trigger a change to emulate change event in IE
Daniel Ruf [Thu, 29 Mar 2018 19:08:13 +0000 (21:08 +0200)] 
fix: listen for the enter key and trigger a change to emulate change event in IE

7 years agofix: move extend outside of mediaquery for sass compatibility 11106/head
Nicolas Coden [Thu, 29 Mar 2018 17:30:58 +0000 (19:30 +0200)] 
fix: move extend outside of mediaquery for sass compatibility

Libsass 3.5 does not support using `@extend` inside the same mediaquery as the placeholder. `@extend` must be used outside of any mediequery.

See https://github.com/zurb/foundation-sites/pull/11094

7 years agoMerge pull request #10889 from ncoden/feat/sticky-static-height-option-10846-2
Nicolas Coden [Wed, 28 Mar 2018 21:04:45 +0000 (23:04 +0200)] 
Merge pull request #10889 from ncoden/feat/sticky-static-height-option-10846-2

feat: add `dynamicHeight` option on Sticky to control container height changes #10846 (2)

7 years agoMerge pull request #10907 from ncoden/feat/code-typography-components
Nicolas Coden [Wed, 28 Mar 2018 21:03:39 +0000 (23:03 +0200)] 
Merge pull request #10907 from ncoden/feat/code-typography-components

feat: add `code-inline` and `code-block` typography helpers #9614

7 years agoMerge remote-tracking branch 'zurb/develop' into fix/fix-es6-plugins-webpack-build-2 10930/head
Nicolas Coden [Wed, 28 Mar 2018 21:00:24 +0000 (23:00 +0200)] 
Merge remote-tracking branch 'zurb/develop' into fix/fix-es6-plugins-webpack-build-2

7 years agotests: use all browsers from the compatibility list for BrowserStack tests
Nicolas Coden [Wed, 28 Mar 2018 20:49:32 +0000 (22:49 +0200)] 
tests: use all browsers from the compatibility list for BrowserStack tests

7 years agomore accurate -zf-zero-breakpoint error message 11103/head
Andy Cochran [Wed, 28 Mar 2018 16:40:05 +0000 (12:40 -0400)] 
more accurate -zf-zero-breakpoint error message

7 years agoMerge pull request #11093 from ncoden/fix/nested-reveal-deep-link-history-8012
Nicolas Coden [Tue, 27 Mar 2018 21:58:37 +0000 (23:58 +0200)] 
Merge pull request #11093 from ncoden/fix/nested-reveal-deep-link-history-8012

fix: fix history browsing with nested Reveal and deep-linking

7 years agofix: apply menubar aria role instead of menu 11099/head
Daniel Ruf [Tue, 27 Mar 2018 20:07:42 +0000 (22:07 +0200)] 
fix: apply menubar aria role instead of menu

7 years agoMerge pull request #11084 from VoltiSubito/variables-for-callout-padding
Nicolas Coden [Tue, 27 Mar 2018 18:30:48 +0000 (20:30 +0200)] 
Merge pull request #11084 from VoltiSubito/variables-for-callout-padding

feat(?): Adds variables for padding of large and small callouts

7 years agoMerge pull request #11083 from DanielRuf/chore/remove-deprecated-responsive-embed...
Nicolas Coden [Mon, 26 Mar 2018 19:08:20 +0000 (21:08 +0200)] 
Merge pull request #11083 from DanielRuf/chore/remove-deprecated-responsive-embed-mixins

chore: remove deprecated mixins

7 years agoMerge pull request #11077 from ncoden/fix/on-load-listeners
Nicolas Coden [Mon, 26 Mar 2018 17:48:46 +0000 (19:48 +0200)] 
Merge pull request #11077 from ncoden/fix/on-load-listeners

fix: fix "load" actions in dynamically added components

7 years agoMerge pull request #10856 from ncoden/chore/sort-sass-components-by-specificity
Nicolas Coden [Mon, 26 Mar 2018 17:47:21 +0000 (19:47 +0200)] 
Merge pull request #10856 from ncoden/chore/sort-sass-components-by-specificity

chore: sort Sass components in categories

7 years agoMerge remote-tracking branch 'zurb/develop' into chore/sort-sass-components-by-specif... 10856/head
Nicolas Coden [Mon, 26 Mar 2018 17:46:51 +0000 (19:46 +0200)] 
Merge remote-tracking branch 'zurb/develop' into chore/sort-sass-components-by-specificity

7 years agotests: add visual tests for nested Reveal with deep-linking 11093/head
Nicolas Coden [Mon, 26 Mar 2018 08:12:08 +0000 (10:12 +0200)] 
tests: add visual tests for nested Reveal with deep-linking

See https://github.com/zurb/foundation-sites/issues/8012#issuecomment-372816984

7 years agofix: prevent Reveal opening with its hash already set to add history entry
Nicolas Coden [Mon, 26 Mar 2018 08:11:32 +0000 (10:11 +0200)] 
fix: prevent Reveal opening with its hash already set to add history entry

7 years agofix: update history when closing Reveal with `replaceState` #8012
Nicolas Coden [Mon, 26 Mar 2018 08:08:31 +0000 (10:08 +0200)] 
fix: update history when closing Reveal with `replaceState` #8012

When closing a Reveal with `replaceState: true`, push a new entry to reset the hash. So going back to the history reopen the modals opened before in reverse order.

Closes https://github.com/zurb/foundation-sites/issues/8012

7 years agoMerge pull request #11086 from ncoden/chore/normalize-8
Nicolas Coden [Sun, 25 Mar 2018 18:25:49 +0000 (20:25 +0200)] 
Merge pull request #11086 from ncoden/chore/normalize-8

chore: drop `normalize-scss` and upgrade to normalize.css v8.0.0

7 years agofix: prevent dropdownMenu to reopen after being closed on touch
Nicolas Coden [Sun, 25 Mar 2018 17:32:52 +0000 (19:32 +0200)] 
fix: prevent dropdownMenu to reopen after being closed on touch

When a dropdownMenu is closed by taping on its item, a timeout to open the dropdown on hover after a delay is still set, and the dropdown will reopen.

Changes:
* clean the active item `_delay` when the dropdownMenu is closed

7 years agofix: remove dropdownMenu Touch body listener on destroy
Nicolas Coden [Sun, 25 Mar 2018 17:28:15 +0000 (19:28 +0200)] 
fix: remove dropdownMenu Touch body listener on destroy

7 years agorefactor: rely on Touch plugin for dropdownMenu tap event
Nicolas Coden [Sun, 25 Mar 2018 17:26:54 +0000 (19:26 +0200)] 
refactor: rely on Touch plugin for dropdownMenu tap event

7 years agoMerge remote-tracking branch 'zurb/develop' into abdullahsalem/fix-issue-9823
Nicolas Coden [Sun, 25 Mar 2018 15:51:19 +0000 (17:51 +0200)] 
Merge remote-tracking branch 'zurb/develop' into abdullahsalem/fix-issue-9823

7 years agofix: use 6-decimal precision between breakpoint
Nicolas Coden [Sun, 25 Mar 2018 15:39:19 +0000 (17:39 +0200)] 
fix: use 6-decimal precision between breakpoint

6 decimals is an arbitrary choice. Big enough to give sub-pixels renderd widths in mose use cases and small enough to not being round by browsers.

7 years agofix: ensure that headless-chrome tests run in all environments
Nicolas Coden [Sun, 25 Mar 2018 01:25:02 +0000 (03:25 +0200)] 
fix: ensure that headless-chrome tests run in all environments

Bug with the Linux sandbox SUID can appear or not depending on the Kernel version on the runner. https://gist.github.com/ncoden/6e79cef6f62608fd9443ea2a601806bc

Using `no-sandbox` with chrome is generally not recommended for security reasons, but recommended in this case by Travis.

See:
* https://docs.travis-ci.com/user/chrome#Sandboxing
* https://github.com/travis-ci/travis-ci/issues/8836
* https://github.com/GoogleChrome/puppeteer/issues/515

7 years agochore: move browserstack tests to its own travis job
Nicolas Coden [Sat, 24 Mar 2018 23:41:24 +0000 (00:41 +0100)] 
chore: move browserstack tests to its own travis job

Prevent browserstack tests to be started in all Travis jobs and start it only in its dedicated job.

7 years agochore: add missing dev dependency browserstack-runner
Nicolas Coden [Sat, 24 Mar 2018 23:35:33 +0000 (00:35 +0100)] 
chore: add missing dev dependency browserstack-runner

`browserstack-runner` is not only usable in travis but also with
`npm run test:javascript:browserstack`.

7 years agochore: use ENV for browserstack authentification
Nicolas Coden [Sat, 24 Mar 2018 23:33:24 +0000 (00:33 +0100)] 
chore: use ENV for browserstack authentification

7 years agoMerge pull request #10952 from ncoden/fix/make-toggler-target-an-option-10892
Nicolas Coden [Sat, 24 Mar 2018 20:45:12 +0000 (21:45 +0100)] 
Merge pull request #10952 from ncoden/fix/make-toggler-target-an-option-10892

fix: make Toggler target an option #10892

7 years agochore: remove deprecated grid-column-uncollapse and grid-col-uncollapse mixins 11083/head
Daniel Ruf [Sat, 24 Mar 2018 16:05:30 +0000 (17:05 +0100)] 
chore: remove deprecated grid-column-uncollapse and grid-col-uncollapse mixins

7 years agoMerge pull request #11065 from DanielRuf/fix/reveal-overflow-11064
Nicolas Coden [Sat, 24 Mar 2018 14:31:30 +0000 (15:31 +0100)] 
Merge pull request #11065 from DanielRuf/fix/reveal-overflow-11064

fix: do not add the scrollbar by default

7 years agoMerge pull request #11085 from DanielRuf/fix/xy-grid-frame-scrollbar-10793
Nicolas Coden [Fri, 23 Mar 2018 22:27:15 +0000 (23:27 +0100)] 
Merge pull request #11085 from DanielRuf/fix/xy-grid-frame-scrollbar-10793

fix: add missing vertical scrollbar in xy-grid frame

7 years agochore: drop `normalize-scss` and upgrade to normalize.css v8.0.0 11086/head
Nicolas Coden [Fri, 23 Mar 2018 22:14:36 +0000 (23:14 +0100)] 
chore: drop `normalize-scss` and upgrade to normalize.css v8.0.0

`normalize-scss` is not maintained and actually pollute the Sass namespace. Move back to a as-hard-to-maintain approach with a Sass mixin hosting the normalize.css code.

Note: `/* */` comments where replaced by `//` comments to not being output.

7 years agostyle: sort Sass components inside each category alphabetically
Nicolas Coden [Fri, 23 Mar 2018 19:01:12 +0000 (20:01 +0100)] 
style: sort Sass components inside each category alphabetically

Note:
* forms & typograph has been moved to global styles, as they apply properties on tags and not custom components
* Accodtion/Drilldrown/Dropdown menus must be after `menu`

7 years agoMerge remote-tracking branch 'zurb/develop' into chore/sort-sass-components-by-specif...
Nicolas Coden [Fri, 23 Mar 2018 18:42:47 +0000 (19:42 +0100)] 
Merge remote-tracking branch 'zurb/develop' into chore/sort-sass-components-by-specificity

7 years agoMerge remote-tracking branch 'zurb/develop' into fix/on-load-listeners 11077/head
Nicolas Coden [Fri, 23 Mar 2018 09:08:20 +0000 (10:08 +0100)] 
Merge remote-tracking branch 'zurb/develop' into fix/on-load-listeners

7 years agofix: refactor the `onLoad` uility to allow to unbind the created listenner
Nicolas Coden [Fri, 23 Mar 2018 09:01:56 +0000 (10:01 +0100)] 
fix: refactor the `onLoad` uility to allow to unbind the created listenner

7 years agoSwaps specific callout padding size variables for a map of size to padding 11084/head
Jason Schindler [Fri, 23 Mar 2018 03:31:11 +0000 (22:31 -0500)] 
Swaps specific callout padding size variables for a map of size to padding

7 years agofix: add missing vertical scrollbar in xy-grid frame 11085/head
Daniel Ruf [Thu, 22 Mar 2018 20:46:58 +0000 (21:46 +0100)] 
fix: add missing vertical scrollbar in xy-grid frame

7 years agoAdds variables for padding of large and small callouts
Jason Schindler [Thu, 22 Mar 2018 15:23:28 +0000 (10:23 -0500)] 
Adds variables for padding of large and small callouts

7 years agochore: remove deprecated responsive embed mixins
Daniel Ruf [Thu, 22 Mar 2018 13:38:31 +0000 (14:38 +0100)] 
chore: remove deprecated responsive embed mixins

7 years agoMerge pull request #11076 from ncoden/fix/magellan-href-reference
Nicolas Coden [Wed, 21 Mar 2018 21:29:17 +0000 (22:29 +0100)] 
Merge pull request #11076 from ncoden/fix/magellan-href-reference

fix: fix reference to component in `Magellan._events`

7 years agodocs: update & improve Js installation docs for UMD modules
Nicolas Coden [Wed, 21 Mar 2018 20:52:38 +0000 (21:52 +0100)] 
docs: update & improve Js installation docs for UMD modules

Changes:
* remove section about "dist vs source files": only dist files should be imported for now
* add import examples for ESM, AMD & CommonJS
* simplify section about HTML imports

7 years agoMerge pull request #11073 from DanielRuf/chore/move-from-bower-to-npm
Nicolas Coden [Tue, 20 Mar 2018 22:29:36 +0000 (23:29 +0100)] 
Merge pull request #11073 from DanielRuf/chore/move-from-bower-to-npm

chore: move from bower to npm

7 years agoMerge branch 'develop' into fix/fix-es6-plugins-webpack-build-2
Nicolas Coden [Tue, 20 Mar 2018 22:11:28 +0000 (23:11 +0100)] 
Merge branch 'develop' into fix/fix-es6-plugins-webpack-build-2

7 years agochore: use UMD bundling in customizer
Nicolas Coden [Tue, 20 Mar 2018 21:54:42 +0000 (22:54 +0100)] 
chore: use UMD bundling in customizer

Note: this also ensure that no ES6 code is used in JavaScript gulp task

7 years agoclean: remove unecessary `npm.js` entry
Nicolas Coden [Tue, 20 Mar 2018 21:47:39 +0000 (22:47 +0100)] 
clean: remove unecessary `npm.js` entry

The main bundle `foundation.js` is now compatible with ES6 imports. `npm.js` was there only was that and is now useless.

7 years agoMerge pull request #11012 from ncoden/chore/and-js-min-sourcefiles-10999
Nicolas Coden [Tue, 20 Mar 2018 10:45:53 +0000 (11:45 +0100)] 
Merge pull request #11012 from ncoden/chore/and-js-min-sourcefiles-10999

chore: add sourcemaps for JS and minified files #10999

7 years agoMerge branch 'develop' into chore/and-js-min-sourcefiles-10999 11012/head
Nicolas Coden [Tue, 20 Mar 2018 08:40:02 +0000 (09:40 +0100)] 
Merge branch 'develop' into chore/and-js-min-sourcefiles-10999

7 years agofix: remove useless manual sourcemaps prefixing in gulp "deploy:dist" task
Nicolas Coden [Tue, 20 Mar 2018 08:37:55 +0000 (09:37 +0100)] 
fix: remove useless manual sourcemaps prefixing in gulp "deploy:dist" task

Sourcemaps output names are resolved at writting once source files are already renamed with the `.min` prefix.

7 years agoMerge pull request #11056 from ncoden/fix/tooltip-a11y-11054
Nicolas Coden [Mon, 19 Mar 2018 23:01:52 +0000 (00:01 +0100)] 
Merge pull request #11056 from ncoden/fix/tooltip-a11y-11054

fix: fix Tooltip cleaning on destroy #11054

7 years agoMerge pull request #11067 from DanielRuf/chore/tooltip-remove-deprecated-position...
Nicolas Coden [Mon, 19 Mar 2018 07:13:36 +0000 (08:13 +0100)] 
Merge pull request #11067 from DanielRuf/chore/tooltip-remove-deprecated-position-class-11066

chore: remove the deprecated positionClass in tooltip

7 years agofix: fix reference to component in `Magellan._events` 11076/head
Nicolas Coden [Sun, 18 Mar 2018 20:36:06 +0000 (21:36 +0100)] 
fix: fix reference to component in `Magellan._events`

Bug introduced in https://github.com/zurb/foundation-sites/pull/10988 (6371c6da3de11adf3dce181ec5b7cd5959fe5f8d)

7 years agofix: fix various component listeners on page load when the page is already loaded
Nicolas Coden [Sun, 18 Mar 2018 20:27:26 +0000 (21:27 +0100)] 
fix: fix various component listeners on page load when the page is already loaded

Prevent bugs in Accordion, Magellan, OffCanvas, Reveal, Sticky, Tabs and trigger utilities when the component is dynamically added because the window `load` event they rely on would never be triggered.

Note: In addition to the bug fix, the following behaviors are changed:
* Accordion now smoothly scroll to the opened pane when the hash is changed

7 years agofeat: add `onLoad` utility to wait for page load even after it is already loaded
Nicolas Coden [Sun, 18 Mar 2018 20:16:11 +0000 (21:16 +0100)] 
feat: add `onLoad` utility to wait for page load even after it is already loaded

7 years agochore: move from bower to npm 11073/head
Daniel Ruf [Sun, 18 Mar 2018 19:51:03 +0000 (20:51 +0100)] 
chore: move from bower to npm

7 years agoMerge pull request #11052 from DanielRuf/fix/toggler-aria-expanded-on-trigger-11049
Nicolas Coden [Sat, 17 Mar 2018 22:21:52 +0000 (23:21 +0100)] 
Merge pull request #11052 from DanielRuf/fix/toggler-aria-expanded-on-trigger-11049

fix: add aria-expanded to the toggler trigger

7 years agotests: replace duplicate code in the toggler test 11052/head
Daniel Ruf [Sat, 17 Mar 2018 19:29:33 +0000 (20:29 +0100)] 
tests: replace duplicate code in the toggler test

7 years agoMerge remote-tracking branch 'zurb/develop' into fix/fix-es6-plugins-webpack-build-2
Nicolas Coden [Sat, 17 Mar 2018 15:10:34 +0000 (16:10 +0100)] 
Merge remote-tracking branch 'zurb/develop' into fix/fix-es6-plugins-webpack-build-2

7 years agochore: prevent the main JS bundle to be exported as an unused external
Nicolas Coden [Sat, 17 Mar 2018 15:10:22 +0000 (16:10 +0100)] 
chore: prevent the main JS bundle to be exported as an unused external

Only export "core" and plugins bundles as externals (in the global `__FOUNDATION_EXTERNAL__` object).

7 years agoMerge pull request #10968 from alliclemens/alliclemens-dropdown-unit-tests
Nicolas Coden [Fri, 16 Mar 2018 21:37:49 +0000 (22:37 +0100)] 
Merge pull request #10968 from alliclemens/alliclemens-dropdown-unit-tests

Unit Tests added for dropdown

7 years agochore: remove the deprecated positionClass in tooltip 11067/head
Daniel Ruf [Thu, 15 Mar 2018 21:42:37 +0000 (22:42 +0100)] 
chore: remove the deprecated positionClass in tooltip

7 years agoMerge pull request #11036 from colin-marshall/chore/update-eslint-to-v4
Nicolas Coden [Thu, 15 Mar 2018 21:14:41 +0000 (22:14 +0100)] 
Merge pull request #11036 from colin-marshall/chore/update-eslint-to-v4

chore: update eslint/gulp-eslint to v4

7 years agofix: do not add the scrollbar by default 11065/head
Daniel Ruf [Thu, 15 Mar 2018 20:14:12 +0000 (21:14 +0100)] 
fix: do not add the scrollbar by default

7 years agofix: correctly clear tooltip classes on destroy 11056/head
Nicolas Coden [Thu, 15 Mar 2018 08:07:47 +0000 (09:07 +0100)] 
fix: correctly clear tooltip classes on destroy

Changes:
* remove the `triggerClass` option instead of `.has-tip`
* remove `.bottom`

7 years agofix: remove invalid attribute `aria-haspopup` for tooltip
Nicolas Coden [Thu, 15 Mar 2018 08:04:49 +0000 (09:04 +0100)] 
fix: remove invalid attribute `aria-haspopup` for tooltip

See:
* https://github.com/zurb/foundation-sites/issues/11054
* https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup

7 years agofix: apply aria-expanded to the toggler triggers in _updateARIA
Daniel Ruf [Tue, 13 Mar 2018 22:18:33 +0000 (23:18 +0100)] 
fix: apply aria-expanded to the toggler triggers in _updateARIA