]> git.ipfire.org Git - thirdparty/vuejs/core.git/log
thirdparty/vuejs/core.git
2 years agoci: cache chromium binary
Evan You [Mon, 14 Nov 2022 10:47:08 +0000 (18:47 +0800)] 
ci: cache chromium binary

2 years agobuild: suppress rollup external warnings
Evan You [Mon, 14 Nov 2022 10:35:09 +0000 (18:35 +0800)] 
build: suppress rollup external warnings

2 years agobuild: bump jest, puppeteer and use official rollup terser plugin
Evan You [Mon, 14 Nov 2022 10:21:58 +0000 (18:21 +0800)] 
build: bump jest, puppeteer and use official rollup terser plugin

2 years agofix(shared): toNumber should only coerce strings
Evan You [Mon, 14 Nov 2022 09:50:56 +0000 (17:50 +0800)] 
fix(shared): toNumber should only coerce strings

2 years agofix(types): allow assigning wider SetupContext type (#2818)
翠 / green [Mon, 14 Nov 2022 09:33:29 +0000 (18:33 +0900)] 
fix(types): allow assigning wider SetupContext type (#2818)

fix #2362

2 years agofix(reactivity): track hasOwnProperty
Evan You [Mon, 14 Nov 2022 09:17:35 +0000 (17:17 +0800)] 
fix(reactivity): track hasOwnProperty

fix #2619
close #2621

2 years agochore: fix assertNumber for undefined value
Evan You [Mon, 14 Nov 2022 08:57:44 +0000 (16:57 +0800)] 
chore: fix assertNumber for undefined value

2 years agofix(custom-elements): use strict number casting
Evan You [Mon, 14 Nov 2022 08:20:12 +0000 (16:20 +0800)] 
fix(custom-elements): use strict number casting

close #4946
close #2598
close #2604

This commit also refactors internal usage of previous loose
implementation of `toNumber` to the stricter version where applicable.
Use of `looseToNumber` is preserved for `v-model.number` modifier to
ensure backwards compatibility and consistency with Vue 2 behavior.

2 years agorefactor: use Number constructor when coercing array length
Evan You [Mon, 14 Nov 2022 08:10:05 +0000 (16:10 +0800)] 
refactor: use Number constructor when coercing array length

2 years agofix(reactivity-transform): prohibit const assignment at compile time (#6993)
三咲智子 Kevin Deng [Mon, 14 Nov 2022 07:54:41 +0000 (15:54 +0800)] 
fix(reactivity-transform): prohibit const assignment at compile time (#6993)

close #6992

2 years agofix(v-model): ensure v-model listener casing is consistent with manual v-on listener...
三咲智子 Kevin Deng [Mon, 14 Nov 2022 07:21:29 +0000 (15:21 +0800)] 
fix(v-model): ensure v-model listener casing is consistent with manual v-on listener (#7067)

fix #7066

2 years agochore(compiler-core): missing space in v-slot mixed usage error message (#7076)
Cédric Exbrayat [Mon, 14 Nov 2022 07:06:24 +0000 (08:06 +0100)] 
chore(compiler-core): missing space in v-slot mixed usage error message (#7076)

2 years agofix(compiler-core): typeof should be allowed in browser expression validation (#7037)
Samuel Rigaud [Mon, 14 Nov 2022 06:50:35 +0000 (07:50 +0100)] 
fix(compiler-core): typeof should be allowed in browser expression validation (#7037)

2 years agochore(types): remove unnecessary type assertions (#7032)
webfansplz [Mon, 14 Nov 2022 06:44:06 +0000 (14:44 +0800)] 
chore(types): remove unnecessary type assertions (#7032)

2 years agofix(runtime-core): set scope id before props (#6948)
Zollero [Mon, 14 Nov 2022 03:53:46 +0000 (11:53 +0800)] 
fix(runtime-core): set scope id before props (#6948)

close #6923
Also ensure consistency with Vue 2

2 years agobuild(deps): upgrade rollup@2 to rollup@3 (#6990)
JayFate [Mon, 14 Nov 2022 03:48:52 +0000 (11:48 +0800)] 
build(deps): upgrade rollup@2 to rollup@3 (#6990)

* build(deps): upgrade rollup@2 to rollup@3

Signed-off-by: JayFate <37610029@qq.com>
* build(rollup): move rollup.config.js to rollup.config.mjs

Signed-off-by: JayFate <37610029@qq.com>
Signed-off-by: JayFate <37610029@qq.com>
2 years agochore: snapshot
Evan You [Mon, 14 Nov 2022 03:41:44 +0000 (11:41 +0800)] 
chore: snapshot

2 years agofix(reactivity-transform): fix $$ escape edge cases
Evan You [Mon, 14 Nov 2022 03:36:24 +0000 (11:36 +0800)] 
fix(reactivity-transform): fix $$ escape edge cases

fix #6312
close #6944

2 years agodocs: add notes on more scripts in contribution guide
Evan You [Mon, 14 Nov 2022 02:22:43 +0000 (10:22 +0800)] 
docs: add notes on more scripts in contribution guide

2 years agoworkflow: adjust scripts to avoid reliance on implicit pre-scripts
Evan You [Mon, 14 Nov 2022 02:22:20 +0000 (10:22 +0800)] 
workflow: adjust scripts to avoid reliance on implicit pre-scripts

pnpm does not support implicit pre/post scripts without config

2 years agoworkflow: ensure dev-sfc script build necessary deps if not present
Evan You [Mon, 14 Nov 2022 02:14:12 +0000 (10:14 +0800)] 
workflow: ensure dev-sfc script build necessary deps if not present

2 years agodocs(contributing): change dependencies graph to mermaid (#6901)
Flávio Reis [Mon, 14 Nov 2022 01:48:58 +0000 (01:48 +0000)] 
docs(contributing): change dependencies graph to mermaid (#6901)

2 years agotest(Transition): events with arguments (#6823)
被雨水过滤的空气-Rairn [Mon, 14 Nov 2022 01:45:44 +0000 (09:45 +0800)] 
test(Transition): events with arguments (#6823)

2 years agorefactor(compiler-core): make ast.helpers a Set (#6774)
三咲智子 Kevin Deng [Mon, 14 Nov 2022 01:44:02 +0000 (09:44 +0800)] 
refactor(compiler-core): make ast.helpers a Set (#6774)

2 years agofix(compiler): add `hgroup` to supported `HTML_TAGS` (#6321)
Tamay Eser Uysal [Mon, 14 Nov 2022 01:28:56 +0000 (05:28 +0400)] 
fix(compiler): add `hgroup` to supported `HTML_TAGS` (#6321)

close #6313

2 years agofix(types/effectScope): re-expose `active` as readonly property (#6187)
webfansplz [Mon, 14 Nov 2022 01:27:52 +0000 (09:27 +0800)] 
fix(types/effectScope): re-expose `active` as readonly property (#6187)

close #6186

2 years agorefactor(compiler-sfc): drop Function prop type when no static default value (#7125)
三咲智子 Kevin Deng [Mon, 14 Nov 2022 01:15:17 +0000 (09:15 +0800)] 
refactor(compiler-sfc): drop Function prop type when no static default value (#7125)

2 years agochore(runtime-core): add `isRegExp` to check `RegExp` (#6041)
webfansplz [Mon, 14 Nov 2022 01:14:28 +0000 (09:14 +0800)] 
chore(runtime-core): add `isRegExp` to check `RegExp` (#6041)

2 years agotypes(runtime-core): support plugin options type inference (#3969)
Tony Trinh [Mon, 14 Nov 2022 01:13:32 +0000 (19:13 -0600)] 
types(runtime-core): support plugin options type inference (#3969)

2 years agofix(compiler-sfc): always generate runtime prop type for Function (#7112)
三咲智子 Kevin Deng [Mon, 14 Nov 2022 00:36:03 +0000 (08:36 +0800)] 
fix(compiler-sfc): always generate runtime prop type for Function (#7112)

fix #7111

2 years agoUpdate migration build link (#7109)
Scott Bedard [Fri, 11 Nov 2022 21:25:09 +0000 (15:25 -0600)] 
Update migration build link (#7109)

2 years agorelease: v3.2.45 v3.2.45
Evan You [Fri, 11 Nov 2022 09:35:27 +0000 (17:35 +0800)] 
release: v3.2.45

2 years agotest: test case for #6966
Evan You [Fri, 11 Nov 2022 09:06:50 +0000 (17:06 +0800)] 
test: test case for #6966

2 years agofix(custom-elements): custom element should re-instantiate when inserted again (...
ysy945 [Fri, 11 Nov 2022 09:06:21 +0000 (17:06 +0800)] 
fix(custom-elements): custom element should re-instantiate when inserted again (#6966)

fix #6934

2 years agofix(custom-elements): respect slot props in custom element mode
Evan You [Fri, 11 Nov 2022 08:05:07 +0000 (16:05 +0800)] 
fix(custom-elements): respect slot props in custom element mode

2 years agofix(custom-elements): define declared properties in constructor (#5328)
Thorsten Lünborg [Fri, 11 Nov 2022 07:46:01 +0000 (08:46 +0100)] 
fix(custom-elements): define declared properties in constructor (#5328)

2 years agofix(custom-elements): fix number type props casting check
Evan You [Fri, 11 Nov 2022 07:18:46 +0000 (15:18 +0800)] 
fix(custom-elements): fix number type props casting check

fix #5793
adapted from #5794

2 years agofix(custom-elements): properties set pre-upgrade should not show up in $attrs
Evan You [Fri, 11 Nov 2022 06:42:42 +0000 (14:42 +0800)] 
fix(custom-elements): properties set pre-upgrade should not show up in $attrs

2 years agofix(custom-elements): should not reflect non-decalred properties set before upgrade
Evan You [Fri, 11 Nov 2022 06:14:55 +0000 (14:14 +0800)] 
fix(custom-elements): should not reflect non-decalred properties set before upgrade

2 years agofix(custom-elements): fix event emitting for async custom elements (#5601)
Thorsten Lünborg [Fri, 11 Nov 2022 04:33:17 +0000 (05:33 +0100)] 
fix(custom-elements): fix event emitting for async custom elements (#5601)

fix #5599

2 years agofix(custom-elements): also dispatch hyphenated version of emitted events (#5378)
Thorsten Lünborg [Fri, 11 Nov 2022 04:01:10 +0000 (05:01 +0100)] 
fix(custom-elements): also dispatch hyphenated version of emitted events (#5378)

fix #5373

2 years agofix(custom-elements): ensure custom elements can inherit provides from ancestors...
Thorsten Lünborg [Fri, 11 Nov 2022 02:33:17 +0000 (03:33 +0100)] 
fix(custom-elements): ensure custom elements can inherit provides from ancestors (#5098)

fix #5096

2 years agorefactor: more concise bitwise operations for flag removal (#7092)
花果山大圣 [Fri, 11 Nov 2022 01:15:37 +0000 (09:15 +0800)] 
refactor: more concise bitwise operations for flag removal (#7092)

2 years agochore: escape html tag in change log (#7089) [ci skip]
Daniel Khalil [Fri, 11 Nov 2022 01:12:40 +0000 (02:12 +0100)] 
chore: escape html tag in change log (#7089) [ci skip]

2 years agofix(runtime-core): fix move/removal of static fragments containing text nodes (#6858)
被雨水过滤的空气(Rairn) [Thu, 10 Nov 2022 10:03:10 +0000 (18:03 +0800)] 
fix(runtime-core): fix move/removal of static fragments containing text nodes (#6858)

fix #6852

2 years agofix(hmr/keep-alive): fix error in reload component (#7049)
被雨水过滤的空气(Rairn) [Thu, 10 Nov 2022 10:01:31 +0000 (18:01 +0800)] 
fix(hmr/keep-alive): fix error in reload component (#7049)

fix #7042

2 years agofix(sfc): also generate getter for import bindings during dev
Evan You [Thu, 10 Nov 2022 09:32:06 +0000 (17:32 +0800)] 
fix(sfc): also generate getter for import bindings during dev

2 years agofix(sfc): ensure consistent dev/prod behavior for non-reactive variables declared...
Evan You [Thu, 10 Nov 2022 09:02:45 +0000 (17:02 +0800)] 
fix(sfc): ensure consistent dev/prod behavior for non-reactive variables declared in `<script setup>`

fix #5655

2 years agofix(sfc): ensure `<script setup>` binding behavior consistency on `this` between...
Evan You [Thu, 10 Nov 2022 08:02:45 +0000 (16:02 +0800)] 
fix(sfc): ensure `<script setup>` binding behavior consistency on `this` between prod and dev

close #6248

2 years agofix(v-model): fix incorrect codegen for non-ref bindings
Evan You [Thu, 10 Nov 2022 07:29:17 +0000 (15:29 +0800)] 
fix(v-model): fix incorrect codegen for non-ref bindings

fix #6241

2 years agochore: remove reference to tsd [ci skip]
Evan You [Thu, 10 Nov 2022 07:10:47 +0000 (15:10 +0800)] 
chore: remove reference to tsd [ci skip]

close #7077

2 years agofix(teleport/css-v-bind): fix css v-bind in teleport in child component slot
Evan You [Thu, 10 Nov 2022 07:08:25 +0000 (15:08 +0800)] 
fix(teleport/css-v-bind): fix css v-bind in teleport in child component slot

2 years agofix(teleport/css-v-bind): fix css v-bind for teleported content
Evan You [Thu, 10 Nov 2022 06:29:51 +0000 (14:29 +0800)] 
fix(teleport/css-v-bind): fix css v-bind for teleported content

fix #4605
close #4609 (used tests from this PR)

2 years agochore: fix test
Evan You [Thu, 10 Nov 2022 06:30:50 +0000 (14:30 +0800)] 
chore: fix test

2 years agochore(types): mark more internal component instance properties
Evan You [Thu, 10 Nov 2022 06:11:55 +0000 (14:11 +0800)] 
chore(types): mark more internal component instance properties

2 years agofix(compiler/v-model): catch incorrect v-model usage on prop bindings
Evan You [Thu, 10 Nov 2022 02:42:27 +0000 (10:42 +0800)] 
fix(compiler/v-model): catch incorrect v-model usage on prop bindings

close #5584

2 years agorelease: v3.2.44 v3.2.44
Evan You [Wed, 9 Nov 2022 23:25:22 +0000 (07:25 +0800)] 
release: v3.2.44

2 years agofix(watch): for immediate watch with single source, ensure cb is called with undefine...
Thorsten Lünborg [Wed, 9 Nov 2022 23:19:35 +0000 (00:19 +0100)] 
fix(watch): for immediate watch with single source, ensure cb is called with undefined as oldValue (#7075)

fix: #7074

2 years agodx(runtime-dom): warn when a style value ends in a semicolon (#7062)
skirtle [Wed, 9 Nov 2022 13:16:34 +0000 (13:16 +0000)] 
dx(runtime-dom): warn when a style value ends in a semicolon (#7062)

2 years agochore(compat): change 'vnode-' to 'vue:' in event hooks warning (#7063)
skirtle [Wed, 9 Nov 2022 13:15:41 +0000 (13:15 +0000)] 
chore(compat): change 'vnode-' to 'vue:' in event hooks warning (#7063)

2 years agoworkflow: switch to simple-git-hooks (#7069)
三咲智子 Kevin Deng [Wed, 9 Nov 2022 13:14:59 +0000 (21:14 +0800)] 
workflow: switch to simple-git-hooks (#7069)

2 years agorelease: v3.2.43 v3.2.43
Evan You [Wed, 9 Nov 2022 13:00:57 +0000 (21:00 +0800)] 
release: v3.2.43

2 years agofix(watch): ensure oldValue in multi-source watcher is always an array
Evan You [Wed, 9 Nov 2022 12:50:02 +0000 (20:50 +0800)] 
fix(watch): ensure oldValue in multi-source watcher is always an array

fix #7070

2 years agochore: return early in warn() in prod
Evan You [Wed, 9 Nov 2022 03:48:35 +0000 (11:48 +0800)] 
chore: return early in warn() in prod

2 years agochore: include terser in workspace deps [ci skip]
Evan You [Wed, 9 Nov 2022 03:43:31 +0000 (11:43 +0800)] 
chore: include terser in workspace deps [ci skip]

2 years agobuild: put ssrContext warning behind __DEV__ flag
Evan You [Wed, 9 Nov 2022 03:41:26 +0000 (11:41 +0800)] 
build: put ssrContext warning behind __DEV__ flag

2 years agorelease: v3.2.42 v3.2.42
Evan You [Wed, 9 Nov 2022 03:36:09 +0000 (11:36 +0800)] 
release: v3.2.42

2 years agofix(compiler-sfc): only escape parsing-breaking characters in v-bind css var names...
三咲智子 Kevin Deng [Wed, 9 Nov 2022 03:30:05 +0000 (11:30 +0800)] 
fix(compiler-sfc): only escape parsing-breaking characters in v-bind css var names (#6816)

close #6803

2 years agofix(compiler): avoid namespace collisions when transforming template refs in inline...
白雾三语 [Wed, 9 Nov 2022 03:22:29 +0000 (11:22 +0800)] 
fix(compiler): avoid namespace collisions when transforming template refs in inline mode (#6975)

fix #6964

2 years agofix(compiler-sfc): handle method shorthand syntax in withDefaults (#6972)
三咲智子 Kevin Deng [Wed, 9 Nov 2022 03:12:54 +0000 (11:12 +0800)] 
fix(compiler-sfc): handle method shorthand syntax in withDefaults (#6972)

fix #6971

2 years agofix(compiler-core/v-on): only apply case preservation on native elements (#6902)
白雾三语 [Wed, 9 Nov 2022 02:58:22 +0000 (10:58 +0800)] 
fix(compiler-core/v-on): only apply case preservation on native elements (#6902)

fix #6900

2 years agofix(compiler-sfc): resolve computed object key (#6963)
三咲智子 Kevin Deng [Wed, 9 Nov 2022 02:57:40 +0000 (10:57 +0800)] 
fix(compiler-sfc): resolve computed object key (#6963)

2 years agofix(reactivity-transform): respect user defined symbols that conflict with macros...
三咲智子 Kevin Deng [Wed, 9 Nov 2022 01:26:43 +0000 (09:26 +0800)] 
fix(reactivity-transform): respect user defined symbols that conflict with macros (#6840)

closes #6838

2 years agofix(types): stricter type condition for `EventHandlers` (#6855)
Johnson Chu [Tue, 8 Nov 2022 15:37:37 +0000 (23:37 +0800)] 
fix(types): stricter type condition for `EventHandlers` (#6855)

fix #6899

2 years agofix(compiler-core): fix parsing error on comments between v-if in prod
Evan You [Tue, 8 Nov 2022 15:35:35 +0000 (23:35 +0800)] 
fix(compiler-core): fix parsing error on comments between v-if in prod

close #6843

2 years agofix(transition/keep-alive): fix unmount bug for component with out-in transition...
被雨水过滤的空气(Rairn) [Tue, 8 Nov 2022 15:01:43 +0000 (23:01 +0800)] 
fix(transition/keep-alive): fix unmount bug for component with out-in transition (#6839)

fix #6835

2 years agofix(compiler-core): keep whitespaces between interpolation and comment (#6828)
Rudy [Tue, 8 Nov 2022 14:50:43 +0000 (22:50 +0800)] 
fix(compiler-core): keep whitespaces between interpolation and comment (#6828)

fix #6352

2 years agoci: upgrade node to 18 (#6983)
三咲智子 Kevin Deng [Tue, 8 Nov 2022 14:13:45 +0000 (22:13 +0800)] 
ci: upgrade node to 18 (#6983)

2 years agorefactor(compiler-sfc): optimize import alias check for binding analysis
Evan You [Tue, 8 Nov 2022 09:47:47 +0000 (17:47 +0800)] 
refactor(compiler-sfc): optimize import alias check for binding analysis

2 years agofix(compiler-sfc): fix binding analysis for aliased late import
Evan You [Tue, 8 Nov 2022 09:19:45 +0000 (17:19 +0800)] 
fix(compiler-sfc): fix binding analysis for aliased late import

2 years agofix(compiler-sfc): check import source during binding analysation (#6826)
三咲智子 Kevin Deng [Tue, 8 Nov 2022 09:07:28 +0000 (17:07 +0800)] 
fix(compiler-sfc): check import source during binding analysation (#6826)

fix #6825

2 years agofix(types/reactivity-transform): fix type when initial value is not used (#6821)
三咲智子 Kevin Deng [Tue, 8 Nov 2022 06:38:53 +0000 (14:38 +0800)] 
fix(types/reactivity-transform): fix type when initial value is not used (#6821)

fix #6820

2 years agoci: disable format-check on ci
Evan You [Tue, 8 Nov 2022 06:31:45 +0000 (14:31 +0800)] 
ci: disable format-check on ci

this causes too many unintended fails on PR merges
the task should just be manually run periodically

2 years agochore: remove blank line [ci skip]
Evan You [Tue, 8 Nov 2022 06:29:13 +0000 (14:29 +0800)] 
chore: remove blank line [ci skip]

2 years agofix(hmr): fix hmr for components managed by keep-alive (#6809)
花果山大圣 [Tue, 8 Nov 2022 06:26:56 +0000 (14:26 +0800)] 
fix(hmr): fix hmr for components managed by keep-alive (#6809)

fix #6222

2 years agochore: run prettier
Evan You [Tue, 8 Nov 2022 06:25:48 +0000 (14:25 +0800)] 
chore: run prettier

2 years agoworkflow(sfc-playground): set all scopes to production mode (#6815)
三咲智子 Kevin Deng [Tue, 8 Nov 2022 06:10:56 +0000 (14:10 +0800)] 
workflow(sfc-playground): set all scopes to production mode (#6815)

2 years agofix(types): support inferring injected properties in options api (#6804)
Rudy [Tue, 8 Nov 2022 06:09:53 +0000 (14:09 +0800)] 
fix(types): support inferring injected properties in options api (#6804)

close #3031
close #5931

2 years agofix(compiler/runtime-dom): ignore comments in inline styles (#6808)
Rudy [Tue, 8 Nov 2022 03:42:32 +0000 (11:42 +0800)] 
fix(compiler/runtime-dom): ignore comments in inline styles (#6808)

fix #6807

2 years agochore: fix snapshot
Evan You [Tue, 8 Nov 2022 03:36:16 +0000 (11:36 +0800)] 
chore: fix snapshot

2 years agofix(compiler-sfc): require <template> or <script> in SFC (#6781)
花果山大圣 [Tue, 8 Nov 2022 03:34:39 +0000 (11:34 +0800)] 
fix(compiler-sfc): require <template> or <script> in SFC (#6781)

fix #6676

2 years agofix(shared): fix parsing of multi-line inline style (#6777)
三咲智子 Kevin Deng [Tue, 8 Nov 2022 03:17:50 +0000 (11:17 +0800)] 
fix(shared): fix parsing of multi-line inline style (#6777)

2 years agofix(compiler-sfc): fix macro usage in multi-variable declaration (#6778)
花果山大圣 [Tue, 8 Nov 2022 03:16:21 +0000 (11:16 +0800)] 
fix(compiler-sfc): fix macro usage in multi-variable declaration (#6778)

fix #6757

2 years agofix(compiler-core/v-on): support inline handler with return type annotation (#6769)
Travis [Tue, 8 Nov 2022 03:09:15 +0000 (11:09 +0800)] 
fix(compiler-core/v-on): support inline handler with return type annotation (#6769)

fix #6378

2 years agofix(compiler-core): avoid duplicate keys in codegen with `v-if` (#6689)
被雨水过滤的空气(Rairn) [Tue, 8 Nov 2022 03:04:31 +0000 (11:04 +0800)] 
fix(compiler-core): avoid duplicate keys in codegen with `v-if` (#6689)

fix #6641

2 years agochore: pretty ignore dist files
Evan You [Tue, 8 Nov 2022 03:03:51 +0000 (11:03 +0800)] 
chore: pretty ignore dist files

2 years agochore: prettier
Evan You [Tue, 8 Nov 2022 03:03:27 +0000 (11:03 +0800)] 
chore: prettier

2 years agofix(sfc/types): improve the type inference using withDefaults (#6764)
littleboarx [Tue, 8 Nov 2022 02:59:31 +0000 (10:59 +0800)] 
fix(sfc/types): improve the type inference using withDefaults (#6764)

fix #6552

2 years agofix(ssr): remove css number value check (#6636)
btea [Tue, 8 Nov 2022 02:53:44 +0000 (10:53 +0800)] 
fix(ssr): remove css number value check (#6636)

Previously this prevented custom properties and vendor-prefixed properties to be rendered correctly.

fix #6625

2 years agofix(runtime-core): do not throw on unknown directives (#6671)
Cédric Exbrayat [Tue, 8 Nov 2022 02:49:49 +0000 (03:49 +0100)] 
fix(runtime-core): do not throw on unknown directives (#6671)

fix #6340

This commit improves the case when a directive is not found in a template.
As `resolveDirective` returns `undefined`, some code was failing with the following error:

```
TypeError: Cannot read properties of undefined (reading 'deep')
```