]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoline number is not order.
Alan T. DeKok [Sat, 24 Mar 2018 12:15:00 +0000 (08:15 -0400)] 
line number is not order.

The "users" file may have multiple $INCLUDES.
We DON'T want a "user" entry at line 266 of "$INCLUDE 1" to conflict
with a "DEFAULT" entry at line 266 of "$INCLUDE 2".

So we add an "order", which tracks the entry number.  The "lineno"
is no longer used for ordering comparisons.  Instead, it's only
used for debugging.

8 years agoremove extraneous variable
Alan T. DeKok [Fri, 23 Mar 2018 21:16:13 +0000 (17:16 -0400)] 
remove extraneous variable

8 years agonote recent changes
Alan T. DeKok [Fri, 23 Mar 2018 15:35:59 +0000 (11:35 -0400)] 
note recent changes

8 years agowrap udpfromto_init
Alan T. DeKok [Fri, 23 Mar 2018 15:35:15 +0000 (11:35 -0400)] 
wrap udpfromto_init

8 years agoif we encoded data, it's not an error
Alan T. DeKok [Fri, 23 Mar 2018 15:15:36 +0000 (11:15 -0400)] 
if we encoded data, it's not an error

8 years agoremove unnecessary function, and fix error message
Alan T. DeKok [Fri, 23 Mar 2018 15:13:03 +0000 (11:13 -0400)] 
remove unnecessary function, and fix error message

8 years agouse udpfromto. Which should help.
Alan T. DeKok [Fri, 23 Mar 2018 15:03:56 +0000 (11:03 -0400)] 
use udpfromto.  Which should help.

8 years agodon't munge src/dst IP/port. May help with #2199
Alan T. DeKok [Fri, 23 Mar 2018 15:01:48 +0000 (11:01 -0400)] 
don't munge src/dst IP/port.  May help with #2199

fr_packet_list_find_byreply() already sets the src/dst ip/port
as necessary.

8 years agoset correct src/dst ip/port for TCP, too. May help with #2199
Alan T. DeKok [Fri, 23 Mar 2018 15:01:02 +0000 (11:01 -0400)] 
set correct src/dst ip/port for TCP, too.  May help with #2199

8 years agomake detail writer reopen file if filename no longer exists
Matthew Newton [Mon, 12 Mar 2018 14:03:26 +0000 (14:03 +0000)] 
make detail writer reopen file if filename no longer exists

8 years agoradclient "-i" didn't work, so just remove it to save confusion
Matthew Newton [Mon, 12 Mar 2018 10:37:42 +0000 (10:37 +0000)] 
radclient "-i" didn't work, so just remove it to save confusion

There's no current way to tell fr_packet_list_id_alloc to use a
particular ID, and fr_packet_socket_t isn't available to us to
change the ID after it's been allocated.

If anyone really needs to do this for testing it can be
temporarily hacked into send_one_packet().

8 years agoMerge pull request #2191 from nward/update_erx_dictionary
Alan DeKok [Thu, 8 Mar 2018 16:51:38 +0000 (11:51 -0500)] 
Merge pull request #2191 from nward/update_erx_dictionary

Add new Juniper/ERX/Unisphere VSAs

8 years agoAdd new Juniper/ERX/Unisphere VSAs 2191/head
Nathan Ward [Thu, 8 Mar 2018 12:04:26 +0000 (01:04 +1300)] 
Add new Juniper/ERX/Unisphere VSAs

8 years agoPull fixes from v4 for freeradius.spec
Arran Cudbard-Bell [Wed, 7 Mar 2018 07:13:09 +0000 (13:13 +0600)] 
Pull fixes from v4 for freeradius.spec

8 years agonote recent changes
Alan T. DeKok [Tue, 6 Mar 2018 23:39:50 +0000 (18:39 -0500)] 
note recent changes

8 years agoubuntu Dockerfile fixes/cleanup
Matthew Newton [Tue, 6 Mar 2018 22:42:09 +0000 (22:42 +0000)] 
ubuntu Dockerfile fixes/cleanup

8 years agoBackport Dockerfiles from v4 and simplify (a lot)
Matthew Newton [Tue, 6 Mar 2018 19:53:32 +0000 (19:53 +0000)] 
Backport Dockerfiles from v4 and simplify (a lot)

also see issue #2188

8 years agoMerge pull request #2184 from uobnetops/redhat_systemd_spec
Arran Cudbard-Bell [Tue, 6 Mar 2018 15:20:47 +0000 (21:20 +0600)] 
Merge pull request #2184 from uobnetops/redhat_systemd_spec

Red Hat systemd tmpfile

8 years agoMerge branch 'v3.0.x' into redhat_systemd_spec 2184/head
Arran Cudbard-Bell [Tue, 6 Mar 2018 15:20:35 +0000 (21:20 +0600)] 
Merge branch 'v3.0.x' into redhat_systemd_spec

8 years agoset state correctly
Alan T. DeKok [Tue, 6 Mar 2018 13:34:15 +0000 (08:34 -0500)] 
set state correctly

8 years agoMerge branch 'v3.0.x' into redhat_systemd_spec
Jonathan [Tue, 6 Mar 2018 12:31:29 +0000 (12:31 +0000)] 
Merge branch 'v3.0.x' into redhat_systemd_spec

8 years agovp may be NULL
Alan T. DeKok [Sun, 4 Mar 2018 17:51:42 +0000 (12:51 -0500)] 
vp may be NULL

8 years agoadded softbank dictionary
Alan T. DeKok [Sun, 4 Mar 2018 16:51:48 +0000 (11:51 -0500)] 
added softbank dictionary

8 years agoremove unused typedef
Alan T. DeKok [Fri, 2 Mar 2018 00:41:56 +0000 (19:41 -0500)] 
remove unused typedef

8 years agoMerge pull request #2187 from jimdigriz/issue-2186
Alan DeKok [Wed, 28 Feb 2018 19:03:21 +0000 (14:03 -0500)] 
Merge pull request #2187 from jimdigriz/issue-2186

add missing table name

8 years agoadd missing table name 2187/head
Alexander Clouter [Wed, 28 Feb 2018 18:24:16 +0000 (18:24 +0000)] 
add missing table name

8 years agonote recent changes
Alan T. DeKok [Wed, 28 Feb 2018 14:12:32 +0000 (09:12 -0500)] 
note recent changes

8 years agodon't add stripped-user-name to the reply
Alan T. DeKok [Wed, 28 Feb 2018 13:40:12 +0000 (08:40 -0500)] 
don't add stripped-user-name to the reply

instead, add User-Name

8 years agostat the file to see if it changed under us
Alan T. DeKok [Tue, 27 Feb 2018 13:50:36 +0000 (08:50 -0500)] 
stat the file to see if it changed under us

8 years agodon't lock the file if it has been renamed
Alan T. DeKok [Mon, 26 Feb 2018 19:41:41 +0000 (14:41 -0500)] 
don't lock the file if it has been renamed

8 years agoMerge pull request #2164 from frenche/ssl_read
Alan DeKok [Mon, 26 Feb 2018 19:22:21 +0000 (14:22 -0500)] 
Merge pull request #2164 from frenche/ssl_read

TLS: Treat SSL_read returning zero as an error

8 years agoMerge pull request #2162 from frenche/partial_chain
Alan DeKok [Mon, 26 Feb 2018 19:21:54 +0000 (14:21 -0500)] 
Merge pull request #2162 from frenche/partial_chain

TLS: Allow partial certificate chain to trusted CA

8 years agoMerge branch 'v3.0.x' into redhat_systemd_spec
Jonathan [Mon, 26 Feb 2018 13:30:25 +0000 (13:30 +0000)] 
Merge branch 'v3.0.x' into redhat_systemd_spec

8 years agoTweak paths to deploy to the right place
Jonathan Gazeley [Mon, 26 Feb 2018 13:12:15 +0000 (13:12 +0000)] 
Tweak paths to deploy to the right place

8 years agonote recent changes
Alan T. DeKok [Sat, 24 Feb 2018 16:07:56 +0000 (11:07 -0500)] 
note recent changes

8 years agoallow duplicate "authhost" for duplicate realms.
Alan T. DeKok [Sat, 24 Feb 2018 16:07:07 +0000 (11:07 -0500)] 
allow duplicate "authhost" for duplicate realms.

8 years agonote recent changes
Alan T. DeKok [Fri, 23 Feb 2018 17:50:05 +0000 (12:50 -0500)] 
note recent changes

8 years agocopy tag over from template
Alan T. DeKok [Fri, 23 Feb 2018 14:00:26 +0000 (09:00 -0500)] 
copy tag over from template

8 years agocopy tag over from template
Alan T. DeKok [Fri, 23 Feb 2018 14:00:06 +0000 (09:00 -0500)] 
copy tag over from template

8 years agomore error messages
Alan T. DeKok [Fri, 23 Feb 2018 13:17:11 +0000 (08:17 -0500)] 
more error messages

8 years agoskip empty accounting packets, not all empty packets
Alan T. DeKok [Thu, 22 Feb 2018 14:47:55 +0000 (09:47 -0500)] 
skip empty accounting packets, not all empty packets

8 years agoone last check
Alan T. DeKok [Tue, 13 Feb 2018 00:37:00 +0000 (19:37 -0500)] 
one last check

8 years agoAdd a tmpfiles.d entry on systemd based redhat systems, to stop systemd agressively...
Paul Seward [Mon, 19 Feb 2018 11:08:39 +0000 (11:08 +0000)] 
Add a tmpfiles.d entry on systemd based redhat systems, to stop systemd agressively cleaning up /var/run/radiusd at boot time

8 years agoMerge pull request #2180 from spbnick/double_free_in_acct_redundant
Arran Cudbard-Bell [Tue, 13 Feb 2018 15:08:58 +0000 (15:08 +0000)] 
Merge pull request #2180 from spbnick/double_free_in_acct_redundant

Fix double free in rlm_sql acct_redundant

8 years agoFix double free in rlm_sql acct_redundant 2180/head
Nikolai Kondrashov [Tue, 13 Feb 2018 14:56:10 +0000 (16:56 +0200)] 
Fix double free in rlm_sql acct_redundant

Do not free "expanded" buffer twice in "acct_redundant" in rlm_sql.c.
This fixes a crash in the case of an accounting packet not matching a
Start entry in the database.

See also https://bugzilla.redhat.com/show_bug.cgi?id=1540580

Found and fixed by Benoit Welterlen.

8 years agoclean up fr_pton()
Alan T. DeKok [Mon, 12 Feb 2018 23:49:34 +0000 (18:49 -0500)] 
clean up fr_pton()

strchr() from the previous commit didn't work, because it
ignored inlen.  Instead, walk over the *whole* string, checking
*all* of the characters.  The issue with the earlier code was
that it bailed too early, and forced IPv4 even when the address
was IPv6.

8 years agonote recent changes
Alan T. DeKok [Mon, 12 Feb 2018 22:31:42 +0000 (17:31 -0500)] 
note recent changes

8 years agohoist IPv6 raw checks outside of the look
Alan T. DeKok [Mon, 12 Feb 2018 22:30:14 +0000 (17:30 -0500)] 
hoist IPv6 raw checks outside of the look

"face:i..." is a valid IPv6 address, and the "f" portion
shouldn't cause it to do a DNS lookup.

8 years agoreturn size of *output* data, not input data
Alan T. DeKok [Wed, 7 Feb 2018 19:44:44 +0000 (14:44 -0500)] 
return size of *output* data, not input data

8 years agotypo
Alan T. DeKok [Wed, 7 Feb 2018 15:23:13 +0000 (10:23 -0500)] 
typo

8 years agoadded expected / got text so we know WTF went wrong
Alan T. DeKok [Wed, 7 Feb 2018 15:20:24 +0000 (10:20 -0500)] 
added expected / got text so we know WTF went wrong

8 years agoupdates
Alan T. DeKok [Wed, 7 Feb 2018 14:25:18 +0000 (09:25 -0500)] 
updates

8 years agocast for correct value
Alan T. DeKok [Tue, 6 Feb 2018 19:57:18 +0000 (14:57 -0500)] 
cast for correct value

8 years agocheck prefix length values, too
Alan T. DeKok [Tue, 6 Feb 2018 19:47:38 +0000 (14:47 -0500)] 
check prefix length values, too

8 years agodon't copy short data for complex types
Alan T. DeKok [Tue, 6 Feb 2018 19:42:57 +0000 (14:42 -0500)] 
don't copy short data for complex types

8 years agore-add byte, ipv4prefix, ipv6prefix
Alan T. DeKok [Tue, 6 Feb 2018 19:36:00 +0000 (14:36 -0500)] 
re-add byte, ipv4prefix, ipv6prefix

8 years agonote recent changes.
Alan T. DeKok [Tue, 6 Feb 2018 19:03:20 +0000 (14:03 -0500)] 
note recent changes.

8 years agoleave one byte of room for the trailing zero
Alan T. DeKok [Mon, 5 Feb 2018 21:54:11 +0000 (16:54 -0500)] 
leave one byte of room for the trailing zero

and zero out the array, too

8 years agoRevert "re-add SSL wrappers for freeing VPs and Certs."
Alan T. DeKok [Mon, 5 Feb 2018 20:30:14 +0000 (15:30 -0500)] 
Revert "re-add SSL wrappers for freeing VPs and Certs."

This reverts commit 63559782c19507cbe9e616d783e51b11c9e6dc72.

Now that we've disabled the internal OpenSSL cache, we can
rely on talloc to clean up memory.

It turns out that OpenSSL doesn't call our cleanup handlers
when removing SSL sessions.

8 years agocheck lengths for these, too
Alan T. DeKok [Mon, 5 Feb 2018 19:45:28 +0000 (14:45 -0500)] 
check lengths for these, too

8 years agoallow casting from integer to date
Alan T. DeKok [Mon, 5 Feb 2018 18:52:01 +0000 (13:52 -0500)] 
allow casting from integer to date

8 years agozero out memory, and copy only as much as necessary
Alan T. DeKok [Mon, 5 Feb 2018 18:50:26 +0000 (13:50 -0500)] 
zero out memory, and copy only as much as necessary

8 years agotalloc_free is useful, even for temporary things
Alan T. DeKok [Mon, 5 Feb 2018 12:47:08 +0000 (07:47 -0500)] 
talloc_free is useful, even for temporary things

8 years agoMerge pull request #2177 from qnet-herwin/patch-1
Arran Cudbard-Bell [Mon, 5 Feb 2018 16:14:01 +0000 (16:14 +0000)] 
Merge pull request #2177 from qnet-herwin/patch-1

Typo fix in README

8 years agoTypo fix in README 2177/head
Herwin [Mon, 5 Feb 2018 13:18:50 +0000 (14:18 +0100)] 
Typo fix in README

s/dialip/dialup/

8 years agoMerge pull request #2175 from frenche/may_be_attr
Alan DeKok [Fri, 2 Feb 2018 15:50:54 +0000 (10:50 -0500)] 
Merge pull request #2175 from frenche/may_be_attr

parser: relax may-be-attr logic

8 years agoparser: relax may-be-attr logic 2175/head
Isaac Boukris [Fri, 2 Feb 2018 14:42:58 +0000 (14:42 +0000)] 
parser: relax may-be-attr logic

we check for too many hyphens later

8 years agochange RuntimeDirectory to a location
Alan Buxey [Thu, 1 Feb 2018 12:50:48 +0000 (12:50 +0000)] 
change RuntimeDirectory to a location

as per systemd docs and various other blogs, this value is the directory name relative to the parent path, not the fully defined path
with this change /var/run/radiusd will be created and used

8 years agotypo. fixes #2169
Alan T. DeKok [Wed, 31 Jan 2018 13:22:45 +0000 (08:22 -0500)] 
typo.  fixes #2169

8 years agorhel7 libwbclient RPM dependencies
Matthew Newton [Thu, 25 Jan 2018 20:57:32 +0000 (20:57 +0000)] 
rhel7 libwbclient RPM dependencies

8 years agoadd and use "find home server using src_ip" function
Alan T. DeKok [Tue, 30 Jan 2018 14:31:04 +0000 (09:31 -0500)] 
add and use "find home server using src_ip" function

8 years agoallow stats to specify 'src <ipaddr>'. Helps with #2169
Alan T. DeKok [Tue, 30 Jan 2018 14:19:25 +0000 (09:19 -0500)] 
allow stats to specify 'src <ipaddr>'.  Helps with #2169

The underlying "find home server using src IP" isn't there yet,
but this is the start.

8 years agonote recent changes
Alan T. DeKok [Thu, 25 Jan 2018 22:12:30 +0000 (17:12 -0500)] 
note recent changes

8 years agouse "raw" string values. Fixes #2168
Alan T. DeKok [Thu, 25 Jan 2018 22:10:33 +0000 (17:10 -0500)] 
use "raw" string values.  Fixes #2168

8 years agoMerge pull request #2167 from nchaigne/3.0.x-2018-rest-cainfo
Alan DeKok [Wed, 24 Jan 2018 18:57:27 +0000 (13:57 -0500)] 
Merge pull request #2167 from nchaigne/3.0.x-2018-rest-cainfo

3.0.x - rest - curl option CURLOPT_CAINFO

8 years ago3.0.x - rest - curl option CURLOPT_CAINFO 2167/head
Nicolas C [Wed, 24 Jan 2018 17:53:38 +0000 (18:53 +0100)] 
3.0.x - rest - curl option CURLOPT_CAINFO

As proposed on the ML, this patch adds support for curl option
CURLOPT_CAINFO (through a new parameter "ca_info_file").
This new parameter can be used instead of "ca_file" (which sets curl
option CURLOPT_ISSUERCERT).
(They can also be used both at the same time.)

CURLOPT_CAINFO is useful to validate a chain of certificate authorities.
If this option is not set, curl will try to validate the CA chain using
a default location, and it may fail.

CURLOPT_ISSUERCERT is useful to check the issuer of the server
certificate.

For reference, see:
https://curl.haxx.se/libcurl/c/CURLOPT_ISSUERCERT.html
https://curl.haxx.se/libcurl/c/CURLOPT_CAINFO.html

8 years agohome_server may be NULL
Alan T. DeKok [Wed, 24 Jan 2018 16:08:53 +0000 (11:08 -0500)] 
home_server may be NULL

8 years agonote recent changes
Alan T. DeKok [Mon, 22 Jan 2018 20:21:06 +0000 (15:21 -0500)] 
note recent changes

8 years agoTLS: Treat SSL_read returning zero as an error 2164/head
Isaac Boukris [Sat, 20 Jan 2018 11:26:57 +0000 (11:26 +0000)] 
TLS: Treat SSL_read returning zero as an error

As according to the doc, as well as other usage
of it in our code.

8 years agoTLS: Allow partial certificate chain to trusted CA 2162/head
Isaac Boukris [Fri, 19 Jan 2018 02:23:30 +0000 (02:23 +0000)] 
TLS: Allow partial certificate chain to trusted CA

This lets for example to only trust a local sub CA
without having to trust the whole hierarchy.

8 years agoMerge pull request #2161 from mcnewton/v3.0.x
Alan DeKok [Fri, 19 Jan 2018 01:04:31 +0000 (20:04 -0500)] 
Merge pull request #2161 from mcnewton/v3.0.x

don't call process_proxy_reply twice when proxying to a virtual server

8 years agodon't call process_proxy_reply twice when proxying to a virtual server 2161/head
Matthew Newton [Thu, 18 Jan 2018 23:42:19 +0000 (23:42 +0000)] 
don't call process_proxy_reply twice when proxying to a virtual server

8 years agodon't try to build rlm_eap_fast if it can't be built
Matthew Newton [Tue, 16 Jan 2018 11:41:01 +0000 (11:41 +0000)] 
don't try to build rlm_eap_fast if it can't be built

8 years agoMerge pull request #2158 from mcnewton/gccnodt
Arran Cudbard-Bell [Mon, 15 Jan 2018 23:22:26 +0000 (16:22 -0700)] 
Merge pull request #2158 from mcnewton/gccnodt

autoconf updates

8 years agoautoconf typo 2158/head
Matthew Newton [Mon, 15 Jan 2018 22:59:15 +0000 (22:59 +0000)] 
autoconf typo

8 years agoCheck for -Wno-date-time to pacify ancient compilers
Matthew Newton [Mon, 15 Jan 2018 22:31:37 +0000 (22:31 +0000)] 
Check for -Wno-date-time to pacify ancient compilers

8 years agothese attributes are "string". Fixes #2130
Alan T. DeKok [Fri, 12 Jan 2018 15:34:11 +0000 (10:34 -0500)] 
these attributes are "string".  Fixes #2130

8 years agoremove LN-S from warnings
Alan T. DeKok [Fri, 12 Jan 2018 14:04:36 +0000 (09:04 -0500)] 
remove LN-S from warnings

8 years agobump for 3.0.17
Alan T. DeKok [Thu, 11 Jan 2018 18:22:33 +0000 (13:22 -0500)] 
bump for 3.0.17

8 years agonote recent changes release_3_0_16
Alan T. DeKok [Thu, 11 Jan 2018 16:10:59 +0000 (11:10 -0500)] 
note recent changes

8 years agodon't re-generate `configure` unless asked to
Alan T. DeKok [Wed, 10 Jan 2018 14:58:50 +0000 (09:58 -0500)] 
don't re-generate `configure` unless asked to

8 years agoMerge pull request #2155 from nchaigne/3.0.x-2018-dhcpcli-raw
Alan DeKok [Wed, 10 Jan 2018 13:33:41 +0000 (08:33 -0500)] 
Merge pull request #2155 from nchaigne/3.0.x-2018-dhcpcli-raw

3.0.x - dhcpclient - raw socket fixes

8 years ago3.0.x - dhcpclient - raw socket fixes 2155/head
Nicolas C [Wed, 10 Jan 2018 08:19:43 +0000 (09:19 +0100)] 
3.0.x - dhcpclient - raw socket fixes

Following the commits by Alan to reintroduce the raw socket code to
dhcpclient, I have:
- fixed a few compilation warnings
- added autoconf for HAVE_LINUX_IF_PACKET_H

I'm not so sure of myself for the autoconf part, can you check it's done
properly?
Thanks!

8 years agoinclude dhcpclient binary in freeradius-dhcp debian package
Matthew Newton [Tue, 9 Jan 2018 15:28:53 +0000 (15:28 +0000)] 
include dhcpclient binary in freeradius-dhcp debian package

8 years agodon't fail in removing freeradius-config .deb pkg if dir no longer exists
Matthew Newton [Tue, 9 Jan 2018 12:53:33 +0000 (12:53 +0000)] 
don't fail in removing freeradius-config .deb pkg if dir no longer exists

8 years agoalso don't pull in boiler.mk whilst doing make deb
Matthew Newton [Tue, 9 Jan 2018 11:16:14 +0000 (11:16 +0000)] 
also don't pull in boiler.mk whilst doing make deb

8 years agoallow "make deb" before running "configure"
Alan T. DeKok [Tue, 28 Nov 2017 16:39:42 +0000 (11:39 -0500)] 
allow "make deb" before running "configure"

as "make deb" runs "configure" itself in a fake root

8 years agomake sure install continues even if the daemon isn't running
Matthew Newton [Tue, 9 Jan 2018 10:35:12 +0000 (10:35 +0000)] 
make sure install continues even if the daemon isn't running

First install fails if freeradius package and module packages are
installed at the same time.

8 years agoremove groupname from radacct
Alan T. DeKok [Mon, 8 Jan 2018 01:46:42 +0000 (20:46 -0500)] 
remove groupname from radacct

it's not used, and it was confusing too many people.

8 years agonote recent changes
Alan T. DeKok [Fri, 5 Jan 2018 13:39:59 +0000 (08:39 -0500)] 
note recent changes