Error handling: Use ErrorPresenter.showErrorAlert() instead of per-VC showErrorAlert() methods

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Use WireGuardAppError and WireGuardResult throughout the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Introduce a WireGuardResult type to handle errors in callbacks across the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Introduce a WireGuardAppError protocol to manage errors

The alert strings shall be located next to where the errors are declared.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Cleanup Tunnels Manager errors

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error presenter: Always handle the passed error

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Cell status switch should be toggled only after the alert presentation completes

Signed-off-by: Roopesh Chander <roop@roopc.net>

Refactoring: Consolidate file deletion into a separate function

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Logging: Log file should begin with version numbers and tunnel name

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Logging: Make it clear which calls to wg_log use String and which use StaticString

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Add timestamp to exported log

And remove the exported log afterwards.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Refactor out VPN-handling stuff from tunnels list VC to the main VC

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: Error out when tunnel activation fails because there's no internet

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Export log file

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Write log to file

Signed-off-by: Roopesh Chander <roop@roopc.net>

Info.plist: Add app group id for accessing from both the app and the network extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Xcode: Add app groups capability

Signed-off-by: Roopesh Chander <roop@roopc.net>

It's 'WiFi', not 'Wifi'

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: All DNS queries must first go through the VPN's DNS servers

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: Invalidate the configuration object when updating allowedIPs using the 'Exclude private IPs' switch

Signed-off-by: Roopesh Chander <roop@roopc.net>

Config file parser: Be case-insensitive to attribute keys in the config file

Signed-off-by: Roopesh Chander <roop@roopc.net>

Config file parser: Fix typo

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: Export to zip in a background thread

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: Refactor out zip exporting into a separate class

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: No need to check for duplicate names - we disallow it at creation time itself

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Import from zip in a background thread

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Refactor out zip importing into a separate class

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: After saving after activating on-demand, reload tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: Need to keep VPN-on-demand tunnels's status under observation

Because they can turn on automatically, even while the app is in the foreground.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Show VPN-on-demand information

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: Keep track of NETunnelProviderManager's isOnDemandEnabled property

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: Update for VPN-on-demand changes

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: VPN-on-demand stuff shouldn't be part of the tunnel model

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model, Tunnels manager: Rewrite the model for VPN-on-demand

The VPN-on-demand settings should not be part of the tunnel
configuration. Rather, the onDemandRules stored in the
tunnel provider configuration serve as the one place
where the VPN-on-demand settings are stored.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Support for on-demand rules

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit, Tunnel view model: UI for providing On-Demand activation options

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Add activationType to tunnel configuration

We make sure existing tunnel serializations can be deserialized correctly.

We also bump up the tunnelConfigurationVersion, because the tunnel
configuration contents have changed.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: ActivityType enum to represent VPN-on-demand options

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: TunnelConfiguration: Add explicit conformance to Decodable

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Ensure that a TunnelConfiguration always has a valid array of peers

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: When activating while another tunnel is active, deactivate the other tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: startDeactivation() need not take a completion handler

Because the completion handler pattern doesn't fit in this case.

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: There are no DNS errors to handle in the app now

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Minor refactoring to enable calling startTunnel() with a tunnelConfiguration

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: Refresh tunnel statuses when app gets to the foreground

Because the tunnel could've be activated from iOS Settings now

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove unused code

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Ability to refresh connection statuses

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: When there's an error starting the tunnel, show it to the user using displayMessage()

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove unused file PacketTunnelOptionKey.swift

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Bring up the tunnel from the stored providerConfiguration

Signed-off-by: Roopesh Chander <roop@roopc.net>

DNSResolver: Simplify

Signed-off-by: Roopesh Chander <roop@roopc.net>

DNSResolver: Let's not cache DNS resolution results anymore

Signed-off-by: Roopesh Chander <roop@roopc.net>

DNSResolver: DNS resolution can now happen synchronously

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Endpoint.hostname()

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: NETunnelProviderProtocol extension code should be shared

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Refactor PacketTunnelOptionsGenerator into a PacketTunnelSettingsGenerator

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Move DNSResolver to extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: .resolvingEndpointDomains is not longer a valid status

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: DNS resolution no longer happens in the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Include shared model code when building the extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Move InterfaceConfiguration.publicKey to Curve25519.swift

The code for public key calculation need not be shared with the extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Move PacketTunnelOptionsGenerator to the extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Invoke startTunnel() without any options

Signed-off-by: Roopesh Chander <roop@roopc.net>

Move logic to extension: Move model files to Shared

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: While preparing for reuse, should make onValueBeingEdited nil as well

Signed-off-by: Roopesh Chander <roop@roopc.net>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

iPad: Ensure we set sourceRect for all cases where we use sourceView

Signed-off-by: Roopesh Chander <roop@roopc.net>

Info.plist: Register for handling public.text files for Open-in

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Also support importing public.text files in the file picker

Signed-off-by: Roopesh Chander <roop@roopc.net>

iPad: Set correct sourceRect for the popover anchored on the central 'Add' button

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Return a manager with no tunnels in the simulator

To be able to run at least parts of the app in the simulator.

Signed-off-by: Roopesh Chander <roop@roopc.net>

iPad: Configuring the split-view controller should happen in init(), not loadView()

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: show build id

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Make license consistent

We changed all the files and the README to MIT a long time ago but
forgot to update COPYING.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Importing: simplify

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Importing: Assume imported files without .conf or .zip extensions to be a config file

Signed-off-by: Roopesh Chander <roop@roopc.net>

DNSResolver: No need to resolve if the endpoint is already an IP address

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Endpoint.hasHostAsIPAddress()

Signed-off-by: Roopesh Chander <roop@roopc.net>

PacketTunnelProvider: modernize header

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Not horribly broken

Instead it's just mostly broken. Maybe someday it will only be partially
broken. Then a bit broken. And then maybe not broken at all? Before, of
course, it's broken again.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Global: swiftlint autocorrect --format

Signed-off-by: Roopesh Chander <roop@roopc.net>

Global: swiftlint autocorrect

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Error out on file with unsupported file extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

wireguard-go-bridge: take fd instead of fnptr

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Xcode: enable more warnings

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Tunnel edit: TunnelEditTableViewKeyValueCell need not support a read-only mode now

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: A new cell class for the public key field, to make the value scrollable

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Refactor out the label scrolling into a separate UI class

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: Peers in a configuation may not share the same public key

Signed-off-by: Roopesh Chander <roop@roopc.net>

Parser: Peers in a configuation may not share the same public key

Signed-off-by: Roopesh Chander <roop@roopc.net>

Version bump

We update the build number, not the version number, so that test flight
doesn't need a new review.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Parser: Address, DNS and AllowedIPs can have mutliple entries

Signed-off-by: Roopesh Chander <roop@roopc.net>

QR Code: Dismiss the QR code screen when the name prompt is cancelled

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: No need to save if we already have a validated configuration object

Signed-off-by: Roopesh Chander <roop@roopc.net>

global: convert to Swift 4.2

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

TunnelsManager: account for no or many endpoints

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: work around DWARF generation issue

Golang bug 25148 upstream.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

PacketTunnelProvider: clamp v6 addresses to /120

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Settings: account for bottom padding on iPhone X

Reported-by: Jeffrey A. Donenfeld <jad@runblue.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>