]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agoadd a few things, pretty-print the strings, sort alphabetically
Alan T. DeKok [Fri, 8 Apr 2022 14:00:00 +0000 (10:00 -0400)] 
add a few things, pretty-print the strings, sort alphabetically

3 years agochange error message to match the types that can have explicit length (#4456)
James Jones [Fri, 8 Apr 2022 19:23:44 +0000 (14:23 -0500)] 
change error message to match the types that can have explicit length (#4456)

3 years agoadd APIs to get parent list / vp from an input vp
Alan T. DeKok [Fri, 8 Apr 2022 13:17:00 +0000 (09:17 -0400)] 
add APIs to get parent list / vp from an input vp

which means that the caller has to do less tracking, if it wants

3 years agoRemove unused variable
Nick Porter [Fri, 8 Apr 2022 12:54:10 +0000 (13:54 +0100)] 
Remove unused variable

3 years agoDefine PAIR_VERIFY_WITH_LIST for non WITH_VERIFY_PTR build
Nick Porter [Fri, 8 Apr 2022 10:13:38 +0000 (11:13 +0100)] 
Define PAIR_VERIFY_WITH_LIST for non WITH_VERIFY_PTR build

3 years agodon't "return" in function returning void
Alan T. DeKok [Fri, 8 Apr 2022 01:27:46 +0000 (21:27 -0400)] 
don't "return" in function returning void

3 years agodon't even bother checking for operators
Alan T. DeKok [Fri, 8 Apr 2022 00:19:46 +0000 (20:19 -0400)] 
don't even bother checking for operators

3 years agoargument 2 can be NULL
Alan T. DeKok [Fri, 8 Apr 2022 00:00:04 +0000 (20:00 -0400)] 
argument 2 can be NULL

3 years agoadd NDEBUG_UNUSED
Alan T. DeKok [Thu, 7 Apr 2022 23:04:53 +0000 (19:04 -0400)] 
add NDEBUG_UNUSED

3 years agojust hard-code '=' in output
Alan T. DeKok [Thu, 7 Apr 2022 22:58:00 +0000 (18:58 -0400)] 
just hard-code '=' in output

3 years agoop is always T_OP_EQ
Alan T. DeKok [Thu, 7 Apr 2022 22:09:54 +0000 (18:09 -0400)] 
op is always T_OP_EQ

3 years agono need to set vp->op in map callback functions
Alan T. DeKok [Thu, 7 Apr 2022 22:08:39 +0000 (18:08 -0400)] 
no need to set vp->op in map callback functions

map_to_request() ignores it, and just uses map->op

3 years agoalways print '=' for vp->op
Alan T. DeKok [Thu, 7 Apr 2022 21:59:51 +0000 (17:59 -0400)] 
always print '=' for vp->op

nothing here should need it or use it.

3 years agodon't smash vp->op to T_OP_EQ
Alan T. DeKok [Thu, 7 Apr 2022 21:56:40 +0000 (17:56 -0400)] 
don't smash vp->op to T_OP_EQ

the rest of the code in the server should take care of either
not setting vp->op, or setting it to T_OP_EQ after using the
operator.

3 years agowe don't need to set vp->op
Alan T. DeKok [Thu, 7 Apr 2022 21:56:16 +0000 (17:56 -0400)] 
we don't need to set vp->op

it's set by fr_pair_afrom_da()

3 years agothis is no longer needed
Alan T. DeKok [Thu, 7 Apr 2022 21:52:17 +0000 (17:52 -0400)] 
this is no longer needed

3 years agoimove fr_pair_list_t to use tlists
Alan T. DeKok [Thu, 7 Apr 2022 21:06:59 +0000 (17:06 -0400)] 
imove fr_pair_list_t to use tlists

and do various other cleanups and fixes as necessitated by that.

* doing actual work inside of the dcursor insert/remove callbacks
* adding fr_pair_list_t* to fr_pair_verify()
* adding PAIR_VERIFY_WITH_LIST() to verify that a VP is in a list
* ensure that pair_init_from_da() is always used, instead of
  manually doing things in multiple places

3 years agoremove unnecessary struct/union
Alan T. DeKok [Thu, 7 Apr 2022 20:55:58 +0000 (16:55 -0400)] 
remove unnecessary struct/union

this doesn't change anything other than formatting

3 years agoconvert error-prone code to inline typed functions
Alan T. DeKok [Thu, 7 Apr 2022 20:54:24 +0000 (16:54 -0400)] 
convert error-prone code to inline typed functions

3 years agoAdd VALUEs for Datum in Geoconf-Option and change test to match (#4454)
James Jones [Thu, 7 Apr 2022 20:59:42 +0000 (15:59 -0500)] 
Add VALUEs for Datum in Geoconf-Option and change test to match (#4454)

3 years agoUse SET_FLAG(subtype) rather than explicitly writing the equivalent code (#4453)
James Jones [Thu, 7 Apr 2022 20:35:51 +0000 (15:35 -0500)] 
Use SET_FLAG(subtype) rather than explicitly writing the equivalent code (#4453)

It *may* be that the explicit version is there to avoid the compiler
kvetching about a needless bit++ at the end. If that's the case, one
can switch to initializing bit to -1 and preincrementing rather than
postincrementing.

3 years agoConvert GeoConf-Option (code 123) to struct, with test (#4450)
James Jones [Thu, 7 Apr 2022 20:33:28 +0000 (15:33 -0500)] 
Convert GeoConf-Option (code 123) to struct, with test (#4450)

3 years agoConvert GeoConf-Civic to use struct and add test (#4449)
James Jones [Thu, 7 Apr 2022 20:33:18 +0000 (15:33 -0500)] 
Convert GeoConf-Civic to use struct and add test (#4449)

3 years agoAdd test for RFC 3495; this exercises nested TLVs (#4448)
James Jones [Thu, 7 Apr 2022 20:33:11 +0000 (15:33 -0500)] 
Add test for RFC 3495; this exercises nested TLVs (#4448)

3 years agoTypo
Arran Cudbard-Bell [Thu, 7 Apr 2022 20:28:07 +0000 (15:28 -0500)] 
Typo

3 years agoUse the standard instantiate bootstrap callbacks for proto and proc modules
Arran Cudbard-Bell [Thu, 7 Apr 2022 19:34:27 +0000 (14:34 -0500)] 
Use the standard instantiate bootstrap callbacks for proto and proc modules

3 years agouse offset from value box, not from datum
Alan T. DeKok [Thu, 7 Apr 2022 18:03:58 +0000 (14:03 -0400)] 
use offset from value box, not from datum

3 years agocopy at the correct offset
Alan T. DeKok [Thu, 7 Apr 2022 17:42:58 +0000 (13:42 -0400)] 
copy at the correct offset

3 years agomight as well make this "const"
Alan T. DeKok [Thu, 7 Apr 2022 14:02:49 +0000 (10:02 -0400)] 
might as well make this "const"

3 years agouse API instead of poking fields directly
Alan T. DeKok [Wed, 6 Apr 2022 02:43:31 +0000 (22:43 -0400)] 
use API instead of poking fields directly

3 years agomake the dlist offset point to the parent structure
Alan T. DeKok [Tue, 5 Apr 2022 22:35:29 +0000 (18:35 -0400)] 
make the dlist offset point to the parent structure

instead of pointing to the fr_tlist_t.  That way we can just
use the dlist functions, and get the enclosing structure.

As a bonus, it's also a lot less code.

3 years agoupdate TLIST macro functions
Alan T. DeKok [Tue, 5 Apr 2022 22:26:46 +0000 (18:26 -0400)] 
update TLIST macro functions

3 years agoadd function to get tlist from dlist head
Alan T. DeKok [Tue, 5 Apr 2022 22:25:32 +0000 (18:25 -0400)] 
add function to get tlist from dlist head

because a lot of dlist callbacks give the dlist head, and we
sometimes wish to convert that back to a tlist

3 years agoremove unused / unneeded functions
Alan T. DeKok [Tue, 5 Apr 2022 22:24:52 +0000 (18:24 -0400)] 
remove unused / unneeded functions

3 years agomanually free the pair list, as done in the other test functions.
Alan T. DeKok [Tue, 5 Apr 2022 22:22:27 +0000 (18:22 -0400)] 
manually free the pair list, as done in the other test functions.

otherwise with the new tlist code, the pairs are freed via
the talloc_free_children() callback, and the PAIR_VERIFY() check
fails, because the pair is still in a list.

3 years agoallow "attribute" command to parse/print multiple pairs
Alan T. DeKok [Tue, 5 Apr 2022 15:56:24 +0000 (11:56 -0400)] 
allow "attribute" command to parse/print multiple pairs

3 years agocheck for error before allocating the VP
Alan T. DeKok [Tue, 5 Apr 2022 14:46:15 +0000 (10:46 -0400)] 
check for error before allocating the VP

which also makes the code a little cleaner.

3 years agocan't re-init structural types
Alan T. DeKok [Tue, 5 Apr 2022 14:44:26 +0000 (10:44 -0400)] 
can't re-init structural types

where would the children go?  Be freed?

3 years agoRemove unused variables
Nick Porter [Wed, 6 Apr 2022 11:35:52 +0000 (12:35 +0100)] 
Remove unused variables

3 years agofix relative OIDs here, too
Alan T. DeKok [Tue, 5 Apr 2022 14:27:21 +0000 (10:27 -0400)] 
fix relative OIDs here, too

3 years agofully qualify the dictionary OIDs
Alan T. DeKok [Tue, 5 Apr 2022 14:26:45 +0000 (10:26 -0400)] 
fully qualify the dictionary OIDs

3 years agoadd fr_tlist_talloc_free_to_tail()
Alan T. DeKok [Tue, 5 Apr 2022 14:13:42 +0000 (10:13 -0400)] 
add fr_tlist_talloc_free_to_tail()

similar to fr_dlist_talloc_free_to_tail()

3 years agoadd fr_pair_list_dlist_head()
Alan T. DeKok [Tue, 5 Apr 2022 14:04:09 +0000 (10:04 -0400)] 
add fr_pair_list_dlist_head()

and use it so that no one looks at internal fields

3 years agoremove unused lavel
Alan T. DeKok [Tue, 5 Apr 2022 13:59:36 +0000 (09:59 -0400)] 
remove unused lavel

3 years agoupdate fr_pair_replace() and callers
Alan T. DeKok [Tue, 5 Apr 2022 13:54:13 +0000 (09:54 -0400)] 
update fr_pair_replace() and callers

it was previously never called.  And documented as freeing the
input VP, even though it didn't.  And documented as "finding"
a VP, even though it didn't.

Use fr_pair_replace() in pairmove() functions, instead of having
them poke the dlists themselves.

3 years agouse fewer memset
Alan T. DeKok [Tue, 5 Apr 2022 13:14:20 +0000 (09:14 -0400)] 
use fewer memset

new VPs are always initialized to zero

3 years agoless code == better code
Alan T. DeKok [Tue, 5 Apr 2022 12:54:05 +0000 (08:54 -0400)] 
less code == better code

3 years agofix fr_pair_reinit_from_da()
Alan T. DeKok [Tue, 5 Apr 2022 12:45:44 +0000 (08:45 -0400)] 
fix fr_pair_reinit_from_da()

it may be called with a VP which has been created via
fr_pair_alloc_null(), in which case vp->da is NULL.

3 years agouse fr_pair_init_null() instead of memset()
Alan T. DeKok [Tue, 5 Apr 2022 12:46:40 +0000 (08:46 -0400)] 
use fr_pair_init_null() instead of memset()

3 years agoadd fr_pair_init_null()
Alan T. DeKok [Tue, 5 Apr 2022 12:31:14 +0000 (08:31 -0400)] 
add fr_pair_init_null()

because memset(vp, 0) is no longer appropriate

3 years agouse "free to tail", and don't keep tmp_list
Alan T. DeKok [Tue, 5 Apr 2022 12:24:08 +0000 (08:24 -0400)] 
use "free to tail", and don't keep tmp_list

3 years agoadd "free to tail" function
Alan T. DeKok [Mon, 4 Apr 2022 19:29:23 +0000 (15:29 -0400)] 
add "free to tail" function

3 years agoAdd apt retry configuration to second half of debian CI tests
Nick Porter [Tue, 5 Apr 2022 12:53:11 +0000 (13:53 +0100)] 
Add apt retry configuration to second half of debian CI tests

3 years agoUse correct apt option for retries
Nick Porter [Tue, 5 Apr 2022 11:06:08 +0000 (12:06 +0100)] 
Use correct apt option for retries

3 years agominor typos and fixes
Alan T. DeKok [Mon, 4 Apr 2022 19:07:28 +0000 (15:07 -0400)] 
minor typos and fixes

3 years agoadd dlist_head function
Alan T. DeKok [Mon, 4 Apr 2022 19:00:33 +0000 (15:00 -0400)] 
add dlist_head function

3 years agotypo
Alan T. DeKok [Mon, 4 Apr 2022 18:55:14 +0000 (14:55 -0400)] 
typo

3 years agotypo
Alan T. DeKok [Mon, 4 Apr 2022 13:21:44 +0000 (09:21 -0400)] 
typo

3 years agoremove unused macros
Alan T. DeKok [Mon, 4 Apr 2022 12:43:11 +0000 (08:43 -0400)] 
remove unused macros

3 years agopair dlist functions are internal, not public
Alan T. DeKok [Mon, 4 Apr 2022 12:42:30 +0000 (08:42 -0400)] 
pair dlist functions are internal, not public

in preparation for changing the internal structure of pair lists

3 years agoadd note about variable length time specs
Alan T. DeKok [Fri, 1 Apr 2022 14:52:57 +0000 (10:52 -0400)] 
add note about variable length time specs

3 years agoFix handling of affected_rows for FreeTDS SQL driver
Nick Porter [Fri, 1 Apr 2022 14:31:36 +0000 (15:31 +0100)] 
Fix handling of affected_rows for FreeTDS SQL driver

After all the required calls to ct_results(), the internal counter of
affected rows is reset.  So, retrieve it whilst still available and
store for later use.

3 years agoAdd AcctUpdateTime and AcctInterval to MS SQL accounting tables
Nick Porter [Fri, 1 Apr 2022 14:30:22 +0000 (15:30 +0100)] 
Add AcctUpdateTime and AcctInterval to MS SQL accounting tables

To bring them in line with other databases

3 years agoTry *really* hard to pull down packages
Arran Cudbard-Bell [Fri, 1 Apr 2022 21:13:09 +0000 (15:13 -0600)] 
Try *really* hard to pull down packages

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:16 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:13 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:10 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:07 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:04 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Fri, 1 Apr 2022 09:37:01 +0000 (09:37 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Fri, 1 Apr 2022 09:36:57 +0000 (09:36 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

3 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Fri, 1 Apr 2022 09:36:55 +0000 (09:36 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

3 years agocorrect references and numbers
Alan T. DeKok [Thu, 31 Mar 2022 18:03:33 +0000 (14:03 -0400)] 
correct references and numbers

apparently the formatter isn't quite perfect

3 years agoBump the timeout
Arran Cudbard-Bell [Thu, 31 Mar 2022 17:10:25 +0000 (11:10 -0600)] 
Bump the timeout

This'll temporarily fix CI, but we should try and figure out exactly what's happening.

3 years agoReturn NULL on error
Arran Cudbard-Bell [Thu, 31 Mar 2022 17:09:09 +0000 (11:09 -0600)] 
Return NULL on error

3 years agorun through the formatting script
Alan T. DeKok [Thu, 31 Mar 2022 16:45:43 +0000 (12:45 -0400)] 
run through the formatting script

which updates the copyright date, and changes whitespace

3 years agothis encoded as DNS
Alan T. DeKok [Thu, 31 Mar 2022 16:44:41 +0000 (12:44 -0400)] 
this encoded as DNS

3 years agoCheck for NULL heap pointers
Arran Cudbard-Bell [Thu, 31 Mar 2022 16:35:02 +0000 (10:35 -0600)] 
Check for NULL heap pointers

3 years agoRemove one layer of heap derefs and shrink heaps as elements are removed
Arran Cudbard-Bell [Thu, 31 Mar 2022 16:12:05 +0000 (10:12 -0600)] 
Remove one layer of heap derefs and shrink heaps as elements are removed

3 years agoupdate and rearrange
Alan T. DeKok [Thu, 31 Mar 2022 16:04:29 +0000 (12:04 -0400)] 
update and rearrange

to reset TLV numbers

3 years agothe first 2 fields are mandatory, so we might as well define them :(
Alan T. DeKok [Thu, 31 Mar 2022 14:29:35 +0000 (10:29 -0400)] 
the first 2 fields are mandatory, so we might as well define them :(

3 years agothese are "bool encode=exists", like Rapid-Commit
Alan T. DeKok [Thu, 31 Mar 2022 14:21:52 +0000 (10:21 -0400)] 
these are "bool encode=exists", like Rapid-Commit

3 years agoContinue splitting dictionaries by RFC (#4445)
James Jones [Thu, 31 Mar 2022 14:04:17 +0000 (09:04 -0500)] 
Continue splitting dictionaries by RFC (#4445)

3 years agoRemove prefixes
Matthew Newton [Thu, 31 Mar 2022 09:05:43 +0000 (10:05 +0100)] 
Remove prefixes

3 years agoAdd netelastic dictionary
Matthew Newton [Wed, 30 Mar 2022 20:03:13 +0000 (21:03 +0100)] 
Add netelastic dictionary

3 years agofreeradius-snmp "proxy": Fixes and cleanup (#4446)
Terry Burton [Wed, 30 Mar 2022 12:06:10 +0000 (13:06 +0100)] 
freeradius-snmp "proxy": Fixes and cleanup (#4446)

Accelerate walks with a "next OID" hash.
Enable collection of per-client stats by default.
Populate accounting client table with real data.
Avoid race by hoisting radius_stats_init() out of updater thread.
Have radius_updater thread terminate on SIGINT.
Refresh RADIUS-AUTH-SERVER-MIB and RADIUS-ACC-SERVER-MIBs.
Add IPv6 client support.
Assume default value (0) for non-existent stats attributes.
Whitespace and style.

3 years agoTry and fix the random debian packaging failures
Arran Cudbard-Bell [Mon, 28 Mar 2022 21:19:37 +0000 (15:19 -0600)] 
Try and fix the random debian packaging failures

3 years agoadd back Centos 7 support, apparently that was still passing in the scheduled builds...
Arran Cudbard-Bell [Mon, 28 Mar 2022 21:15:06 +0000 (15:15 -0600)] 
add back Centos 7 support, apparently that was still passing in the scheduled builds somehow

3 years agoTypo
Arran Cudbard-Bell [Mon, 28 Mar 2022 21:08:10 +0000 (15:08 -0600)] 
Typo

3 years agoUse another source of centos stream
Arran Cudbard-Bell [Mon, 28 Mar 2022 21:04:10 +0000 (15:04 -0600)] 
Use another source of centos stream

Strip support for fedora and centos-7

3 years agoSee if this fixes the centos 8 package build...
Arran Cudbard-Bell [Mon, 28 Mar 2022 20:31:36 +0000 (14:31 -0600)] 
See if this fixes the centos 8 package build...

3 years agoFix failures in OpenSSL 3.0 with custom logging BIOs
Arran Cudbard-Bell [Mon, 28 Mar 2022 19:31:42 +0000 (13:31 -0600)] 
Fix failures in OpenSSL 3.0 with custom logging BIOs

Apparently the create callbacks need to call BIO_set_init() otherwise all operations on the BIO will fail.  This isn't documented anywhere.

3 years agoIf we're building OpenSSL make sure it's a debug build
Arran Cudbard-Bell [Mon, 28 Mar 2022 18:21:09 +0000 (12:21 -0600)] 
If we're building OpenSSL make sure it's a debug build

3 years agoWe still need the request for state reset
Arran Cudbard-Bell [Mon, 28 Mar 2022 17:56:08 +0000 (11:56 -0600)] 
We still need the request for state reset

3 years agoHack in stack over-allocation for OpenSSL async contexts
Arran Cudbard-Bell [Mon, 28 Mar 2022 17:28:37 +0000 (11:28 -0600)] 
Hack in stack over-allocation for OpenSSL async contexts

3 years agoBump OpenSSL for alt libs
Arran Cudbard-Bell [Mon, 28 Mar 2022 16:32:24 +0000 (10:32 -0600)] 
Bump OpenSSL for alt libs

3 years agoi->ifa_addr may not be aligned
Alan T. DeKok [Mon, 28 Mar 2022 14:29:27 +0000 (10:29 -0400)] 
i->ifa_addr may not be aligned

on OSX it fails with alignment issues, as apparently the alignment
requirements are different for sockaddr and sockaddr_storage?

Or at least ubsan complains on my Mac.

3 years agomore sanity checks on parsing dates / times
Alan T. DeKok [Mon, 28 Mar 2022 14:55:23 +0000 (10:55 -0400)] 
more sanity checks on parsing dates / times

3 years agomove private macros to private header
Alan T. DeKok [Sat, 26 Mar 2022 13:05:06 +0000 (09:05 -0400)] 
move private macros to private header

3 years agoadd cf_item_has_no_children()
Alan T. DeKok [Sat, 26 Mar 2022 13:04:42 +0000 (09:04 -0400)] 
add cf_item_has_no_children()