global: fix remaining swiftlint violations

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

WireGuardKitGo: get rid of missing -Wno-unused-command-line-argument flag

Recent toolchains error out on it, and it's no longer needed.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

WireGuardKitGo: rebase boottime patch onto Go 1.15.6

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

global: bump year in header

A bit overdue, but better late than never.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

WireGuardApp: Update target membership to exclude sources that are only used in network extensions

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Delegate IPv*Address initialization to self.init

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Remove backend version call in Logger.swift & extract wireguard-go version script from network extension targets

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Log XLAT resolution errors

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Disable SWIFT_PRECOMPILE_BRIDGING_HEADER

Clang automatically picks up module.modulemap files from WireGuardKit directories when precompiling bridging header file, which causes the compiler to fail with obscure error.

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Update swift version from 4.2 to 5.0

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Update checkout path in README

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Keychain: Avoid roundtrip via items when accessing item label (stored in kSecAttrLabel)

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Keychain: Remove unnecessary cast to String in Keychain queries

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Remove WireGuardKit.swift from Xcode source tree

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuadKit: Rename WireGuardAdapter.version -> .backendVersion & remove `var wireGuardVersion` with WireGuardKit.swift

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Add back the wireguard-go version extraction script and use WIREGUARD_GO_VERSION directly

Avoids linking against libwg-go.a in order to access the WireGuard backend version.

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Include headers from WireGuardKitC

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: integrate WireGuardKit sources directly

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Remove Sources/ in project folder names

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Rename WireGuardKitSwift -> WireGuardKit

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Linter: Fix all linter issues across the codebase

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Fix build working dir for go-bridge targets

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardNetworkExtension: Remove wireguard.h from bridging header

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Fix paths pointing to xcconfigs

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add wireguard-go files to exclude list to eliminate SwiftPM warnings

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Set publicHeadersPath = "." to flatten public headers structure

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Fix module map for WireGuardKitC

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Fix import statements

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Move all source files to `Sources/` and rename WireGuardKit targets

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Assert that resolutionResults must not contain failures

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Only assign self.settingsGenerator upon success to set tunnel network settings to avoid inconsistent state

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Remove handleLogLine from WireGuardAdapter

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Remove isStarted: bool from WireGuardAdapter

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Fix docs for WireGuardAdapterError

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Fix docs for WireGuardLogLevel

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Pass logHandler via constructor

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Packet tunnel: Remove last error in the completion handler given to adapter.stop

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Rename cannotLocateSocketDescriptor -> cannotLocateTunnelFileDescriptor in WireGuardAdapterError

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardApp: Switch WireGuardKit to master branch

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add TODO to log the error coming from `withReresolvedIP`

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Change getWireGuardVersion() -> wireGuardVersion

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Update README

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

Packet tunnel: Implement packet tunnel provider using WireGuardAdapter

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add WireGuardAdapter

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add wrappers for PrivateKey, PublicKey, PreSharedKey

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

iOS/macOS: Remove "Extract wireguard-go version" build phase

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

iOS/macOS: Remove main bundle apps dependence on WireGuardgoBridge.

Main bundle apps do not have to depend on WireGuardGoBridge<PLATFORM> as they depend on network extnesions which in turn depend on WireGuardGoBridge<PLATFORM>.

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

iOS/macOS: Integrate WireGuardKit

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

go-bridge: Add context support for wgSetLogger

Cherry picked cda99bf45c3cb95ca56204549689a0ae91ff4813 from jd/loggerCtx with the fix for wgSetLogger signature in the C header file.

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add WireGuardKitCTarget with private C sources

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Set public access level for shared structs

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Move shared structs to WireGuardKit

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

WireGuardKit: Add swift package scaffolding

Signed-off-by: Andrej Mihajlov <and@mullvad.net>

go-bridge: dup tunFd so as to not confuse NetworkExtension

The extension isn't banking on tunFd being closed ever, so dup it before
handing it to the rest of wireguard-go.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Change QoS to .utility

As per comment by eskimo:
https://developer.apple.com/forums/thread/107904?answerId=328525022#328525022

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Make sure that the tunnel and path monitor run on the same serial queue

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fix retain cycle between NWPathMonitor and PacketTunnelProvider

See: https://www.marisibrothers.com/2017/04/memory-leak-in-swift-assigning-function.html

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Refactor interface name query

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Localization: Update Japanese

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Localization: macOS: Add translations for 'Edit' button

By copying the 'macMenuEdit' entries to 'macButtonEdit'.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localization: macOS: Fix localization for 'Edit' button

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localization: Add German translation

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localization: Add Italian translation

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localization: Wire up Japanese translation

By adding the translated Localizable.strings to the Xcode project

Signed-off-by: Roopesh Chander <roop@roopc.net>

highlighter: insist on 256-bit keys, not 257-bit or 258-bit

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Japanese Translation

Translation for wireguard-apple. Checked on Xcode iOS simulator but not
all messages.

Signed-off-by: Eiji Tanioka <tanioka404@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: use C string instead of gostring_t

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Update repo urls

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: style

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

README: specify required version in readme

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

[REVERT ME SOON] TunnelsManager: Workaround for macOS Catalina deleting tunnels arbitrarily

In macOS Catalina, for some users, the tunnels get deleted arbitrarily
by the OS. It's not clear what triggers that.

As a workaround, in macOS Catalina, when we realize that tunnels have
been deleted outside the app, we reinstate those tunnels using the
information in the keychain.

Signed-off-by: Roopesh Chander <roop@roopc.net>

wireguard-go-bridge: update to 1.13.4

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

UI: iOS: more dark mode fixes

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: work around Go 1.13.3 regression

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Revert "NetworkExtension: don't use exit(0) hack on Catalina"

This reverts commit 3619279a65d9a506fb13d7f24909b38a5202fa8f.

Still broken!

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

iOS: UI: Make edit views full screen modal

This might be worse on the iPad. Oh well.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

NetworkExtension: don't use exit(0) hack on Catalina

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

UI: iOS: adjust colors for iOS 13

To be compatible with Dark Mode, we need to change some of our
color references to be "dynamic".

Signed-off-by: Diab Neiroukh <officiallazerl0rd@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

iOS: UI: abort is optimized out in release builds

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Keychain: make verification errors only happen when we're sure it's due to not found

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

ui: add donation link

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: reduce version checks and cleanup

We now rely on -trimpath which restricts us to >= 1.13, and the patch
application should fail too. This has the downside that the user will
need to clean their xcode project when they upgrade go, though.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: update for 1.13

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

UI: iOS: set CFBundleDisplayName to satisfy new ITMS-90783 error

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

WgQuickConfig: Swift treats \r\n as a single character

let blah = "hello\nworld\ndoes\nthis\nwork"
print(blah.split(separator: "\n"))
//output: ["hello", "world", "does", "this", "work"]

let blah2 = "hello\r\nworld\r\ndoes\r\nthis\r\nwork"
print(blah2.split(separator: "\n"))
//output: ["hello\r\nworld\r\ndoes\r\nthis\r\nwork"]
//expected: ["hello\r", "world\r", "does\r", "this\r", "work\r"]

In blah2, the string splitting fails because swift considers \r\n to be
its own character.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

UI: macOS: Show useful error message on .conf import

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

iOS: Importing: If tunnelsManager isn't ready yet, we should wait for it

Signed-off-by: Roopesh Chander <roop@roopc.net>

macOS: Tunnel detail: Handle deletion outside app, again

This was previously done in commit f281b93, but the changes in commit
1507a97 for handling deletion of multiple tunnels undid this capability.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: store UID on macOS for keychain availability

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

TunnelProvider: remove all cleverness

This will cause more socket flaps than necessary but hopefully will fix
some bugs.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

on-demand: iOS: Fix crash on selecting Any SSID when already selected

Signed-off-by: Roopesh Chander <roop@roopc.net>

on-demand: Don't crash on encountering unexpected on-demand rules

Signed-off-by: Roopesh Chander <roop@roopc.net>

macOS: Remove unused strings

Signed-off-by: Roopesh Chander <roop@roopc.net>