]> git.ipfire.org Git - thirdparty/bootstrap.git/log
thirdparty/bootstrap.git
8 years agoUpdate nav and navbar HTML markup
Geremia Taglialatela [Wed, 12 Apr 2017 14:06:52 +0000 (16:06 +0200)] 
Update nav and navbar HTML markup

According to the docs, you just need to apply the `navbar-nav` to an
`<ul>` tag in a list-based navbar. In fact, `navbar-nav` seems to
override all the css properties set by `nav`.

Also, `nav-item` class should be used only for `<li>` tags, or in
conjunction with `<a>` tags to entirely avoid the list-based approach.

This commit removes the redundant `nav` class from `navbar-nav` `<ul>`
tags, moves `nav-item` from `<a>` tags to `<li>` tags and properly
adds `nav-item` class to `<li>` tags where missing.

Refs:

* https://v4-alpha.getbootstrap.com/components/navs/
* https://v4-alpha.getbootstrap.com/components/navbar/#nav

8 years agoRename `$navbar-*-toggler-bg` to `$navbar-*-toggler-icon-bg` since it's placed on...
Patrick Yeo [Sat, 27 May 2017 03:55:07 +0000 (20:55 -0700)] 
Rename `$navbar-*-toggler-bg` to `$navbar-*-toggler-icon-bg` since it's placed on .navbar-toggler-icon (#22564)

8 years agoUpdate migration docs for .has-error rename
Hugh Bellamy [Mon, 22 May 2017 01:53:06 +0000 (08:53 +0700)] 
Update migration docs for .has-error rename

8 years agoDrop CSS icons for SVGs (#22708)
Mark Otto [Sat, 27 May 2017 03:54:12 +0000 (20:54 -0700)] 
Drop CSS icons for SVGs (#22708)

* add the svg icon as a partial so we can include it easily

* add the icon to the homepage

* drop .bd-booticon for svgs here

* rip out the import for .bd-booticon sass file

* Delete _booticon.scss

* indentation

* Update bootstrap-icon.html

* remove those

8 years agobuild
Mark Otto [Sat, 27 May 2017 03:21:29 +0000 (20:21 -0700)] 
build

8 years agoMerge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
Mark Otto [Sat, 27 May 2017 03:20:19 +0000 (20:20 -0700)] 
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev

8 years agobuild
Mark Otto [Sat, 27 May 2017 03:20:10 +0000 (20:20 -0700)] 
build

8 years agoRevert simplified grid column styles from #22376
Mark Otto [Fri, 26 May 2017 19:41:07 +0000 (12:41 -0700)] 
Revert simplified grid column styles from #22376

The premise for #22376 was that if we removed the `max-width` and `flex` properties, we could use the column classes as `width` utilities. The problem that I didn't remember at the time is that column classes have horizontal `padding` on them. This doesn't work for setting `width`. Perhaps more importantly, this causes #22649—the automatic sizing of columns is broken with the absence of `flex` styles.

/cc @sachinsinghi

8 years agoupdate equal-width numbering in docs (#22697)
Mike Cooper [Fri, 26 May 2017 18:06:25 +0000 (04:06 +1000)] 
update equal-width numbering in docs (#22697)

8 years agoAdd box-shadow to .progress-bar (#22579)
Mark Otto [Fri, 26 May 2017 04:32:59 +0000 (21:32 -0700)] 
Add box-shadow to .progress-bar (#22579)

* Add box-shadow to .progress-bar

Puts an unused variable back in use for when folks set `$enable-shadows` to `true`.

8 years agoMerge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
Mark Otto [Fri, 26 May 2017 04:16:31 +0000 (21:16 -0700)] 
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev

8 years agobuild
Mark Otto [Fri, 26 May 2017 04:16:23 +0000 (21:16 -0700)] 
build

8 years agoadd webpack to documentation (#22423)
Idan Cohen [Fri, 26 May 2017 04:01:07 +0000 (07:01 +0300)] 
add webpack to documentation (#22423)

* add webpack to documentation"

implementing PR comments

implementing PR comments

* replace tether with popper

8 years agoFix 22643 - Readme links to vanished file (#22647)
Ayachii [Thu, 25 May 2017 04:50:22 +0000 (00:50 -0400)] 
Fix 22643 - Readme links to vanished file (#22647)

* Fixed dead link to browser list

The link to the list of browsers supported through Autoprefixer was dead, now updated to a working link.

* Updated label to display new file path

Changed the labeling on the updated link to show read as the new updated file path.

8 years agoFix fallbackPlacement default value for Popovers documentation
Johann-S [Wed, 24 May 2017 13:02:27 +0000 (15:02 +0200)] 
Fix fallbackPlacement default value for Popovers documentation

8 years agoUpdate Popper.js to 1.9.9
Johann-S [Wed, 24 May 2017 12:44:16 +0000 (14:44 +0200)] 
Update Popper.js to 1.9.9

8 years agoUpdate documentation for Tooltips/Popovers about auto placement
Johann-S [Wed, 24 May 2017 12:27:15 +0000 (14:27 +0200)] 
Update documentation for Tooltips/Popovers about auto placement

8 years agoPlacement auto for popovers
Johann-S [Wed, 24 May 2017 12:09:36 +0000 (14:09 +0200)] 
Placement auto for popovers

8 years agoPlacement auto for tooltips
Johann-S [Wed, 24 May 2017 11:48:32 +0000 (13:48 +0200)] 
Placement auto for tooltips

8 years agoDocumentation display tooltips/popovers arrows with css for static examples
Johann-S [Tue, 23 May 2017 13:05:26 +0000 (15:05 +0200)] 
Documentation display tooltips/popovers arrows with css for static examples

8 years agoUse Popper.js to manage arrow position
Johann-S [Tue, 23 May 2017 12:17:07 +0000 (14:17 +0200)] 
Use Popper.js to manage arrow position

8 years agoFix (css): force .navbar .dropdown-menu positioning
Catalin Zalog [Mon, 22 May 2017 14:20:58 +0000 (17:20 +0300)] 
Fix (css): force .navbar .dropdown-menu positioning

8 years agoBetter management of dropdown/dropup with alignment
Johann-S [Mon, 22 May 2017 14:14:10 +0000 (16:14 +0200)] 
Better management of dropdown/dropup with alignment

8 years agoUse popper to align dropdown menu instead of using css with important
Johann-S [Wed, 17 May 2017 20:03:11 +0000 (22:03 +0200)] 
Use popper to align dropdown menu instead of using css with important

8 years agofix tooltip documentation page missing classname prefix "bs-" to popover top
Laussel Loïc [Wed, 17 May 2017 14:54:28 +0000 (16:54 +0200)] 
fix tooltip documentation page missing classname prefix "bs-" to popover top

8 years agoUpdate Popper.js 1.9.4
Johann-S [Wed, 17 May 2017 12:09:14 +0000 (14:09 +0200)] 
Update Popper.js 1.9.4

8 years agoForce dropdown to be displayed in position static for navbar, to override Popper css
Johann-S [Tue, 16 May 2017 12:03:14 +0000 (14:03 +0200)] 
Force dropdown to be displayed in position static for navbar, to override Popper css

8 years agobuild
Johann-S [Tue, 16 May 2017 07:59:44 +0000 (09:59 +0200)] 
build

8 years agoChange "Max CDN" to "MaxCDN"
Anand Chowdhary [Sun, 14 May 2017 09:58:26 +0000 (15:28 +0530)] 
Change "Max CDN" to "MaxCDN"

8 years agoUpdate Popper.js 1.9.3
Johann-S [Fri, 12 May 2017 19:44:43 +0000 (21:44 +0200)] 
Update Popper.js 1.9.3

8 years agoChange fallbackPlacement to flip by default for Tooltips/Popovers
Johann-S [Fri, 12 May 2017 19:22:12 +0000 (21:22 +0200)] 
Change fallbackPlacement to flip by default for Tooltips/Popovers

8 years agoFix tooltip margin to be stick at their caller
Johann-S [Fri, 12 May 2017 14:08:51 +0000 (16:08 +0200)] 
Fix tooltip margin to be stick at their caller

8 years agoFix bad position for Tooltips with animation at true
Johann-S [Fri, 12 May 2017 07:39:27 +0000 (09:39 +0200)] 
Fix bad position for Tooltips with animation at true

8 years agoUse _jQueryInterface for Dropdown to call toggle method
Johann-S [Thu, 11 May 2017 09:29:46 +0000 (11:29 +0200)] 
Use _jQueryInterface for Dropdown to call toggle method

8 years agoAdd fallbackPlacement option for Tooltip and Popover
Johann-S [Fri, 5 May 2017 19:22:55 +0000 (21:22 +0200)] 
Add fallbackPlacement option for Tooltip and Popover

8 years agoFix dropdown in scrollspy visual test (add Popper.js)
Johann-S [Thu, 4 May 2017 10:04:29 +0000 (12:04 +0200)] 
Fix dropdown in scrollspy visual test (add Popper.js)

8 years agoUpdate Popper.js 1.9.1 + Update documentation about Dropdown placement
Johann-S [Sat, 29 Apr 2017 14:05:22 +0000 (16:05 +0200)] 
Update Popper.js 1.9.1 + Update documentation about Dropdown placement

8 years agoFix dropdown-menu-right and dropdown-menu-left for Dropdown
Johann-S [Tue, 25 Apr 2017 19:34:06 +0000 (21:34 +0200)] 
Fix dropdown-menu-right and dropdown-menu-left for Dropdown

8 years agoDocumentation - fix examples for Tooltip and Popovers (display arrow)
Johann-S [Mon, 24 Apr 2017 20:56:10 +0000 (22:56 +0200)] 
Documentation - fix examples for Tooltip and Popovers (display arrow)

8 years agoAllow to disable flip behaviour on Dropdown + documentation
Johann-S [Fri, 21 Apr 2017 08:49:04 +0000 (10:49 +0200)] 
Allow to disable flip behaviour on Dropdown + documentation

8 years agoUpdate shrinkwrap.
Bardi Harborow [Thu, 20 Apr 2017 10:16:45 +0000 (10:16 +0000)] 
Update shrinkwrap.

8 years agoUpdate Popper.js 1.8.2
Johann-S [Thu, 20 Apr 2017 08:18:57 +0000 (10:18 +0200)] 
Update Popper.js 1.8.2

8 years agoAdd an update method to allow to update position for Tooltip/Popover/Dropdown manually
Johann-S [Wed, 19 Apr 2017 13:08:06 +0000 (15:08 +0200)] 
Add an update method to allow to update position for Tooltip/Popover/Dropdown manually

8 years agoFix some css for the arrow of Popover/Tooltip + update documentation
Johann-S [Wed, 19 Apr 2017 08:59:10 +0000 (10:59 +0200)] 
Fix some css for the arrow of Popover/Tooltip + update documentation

8 years agoBetter placement for Dropdown + Handle flip of Tooltip/Popover
Johann-S [Wed, 19 Apr 2017 08:20:50 +0000 (10:20 +0200)] 
Better placement for Dropdown + Handle flip of Tooltip/Popover

8 years agoRemove totaly Tether from documentation + dependencies
Johann-S [Tue, 18 Apr 2017 12:02:24 +0000 (14:02 +0200)] 
Remove totaly Tether from documentation + dependencies

8 years agoRemove Tether from package.json + Update Popper
Johann-S [Mon, 17 Apr 2017 13:20:53 +0000 (15:20 +0200)] 
Remove Tether from package.json + Update Popper

8 years agoHandle dropup for Dropdown
Johann-S [Mon, 17 Apr 2017 12:26:40 +0000 (14:26 +0200)] 
Handle dropup for Dropdown

8 years agoFix unit tests + Update Popper to 1.6.0
Johann-S [Fri, 14 Apr 2017 11:30:55 +0000 (13:30 +0200)] 
Fix unit tests + Update Popper to 1.6.0

8 years agoRemove constraints option and check every options
Johann-S [Fri, 14 Apr 2017 10:05:54 +0000 (12:05 +0200)] 
Remove constraints option and check every options

8 years agoBegin to use Popper for Dropdown
Johann-S [Fri, 14 Apr 2017 09:25:53 +0000 (11:25 +0200)] 
Begin to use Popper for Dropdown

8 years agoFix arrow for tooltip and popover
Johann-S [Sat, 8 Apr 2017 19:13:15 +0000 (21:13 +0200)] 
Fix arrow for tooltip and popover

8 years agoAdd attachment classes
Johann-S [Fri, 7 Apr 2017 11:20:34 +0000 (13:20 +0200)] 
Add attachment classes

8 years agoBegin to add arrow to Popover and Tooltip
Johann-S [Fri, 7 Apr 2017 09:12:17 +0000 (11:12 +0200)] 
Begin to add arrow to Popover and Tooltip

8 years agoUse Popper for tooltip and popover
Johann-S [Thu, 6 Apr 2017 21:16:07 +0000 (23:16 +0200)] 
Use Popper for tooltip and popover

8 years agotooltips/popover must be hidden before their corresponding element is removed from... 22598/head
Peter Blazejewicz [Tue, 9 May 2017 08:51:44 +0000 (10:51 +0200)] 
tooltips/popover must be hidden before their corresponding element is removed from the DOM

8 years agoRemoved several unused scss variables (#22539)
Sebastiaan Nijland [Mon, 8 May 2017 00:41:14 +0000 (02:41 +0200)] 
Removed several unused scss variables (#22539)

8 years agoAdd explicit role="main" to <main> elements (#22574)
Patrick H. Lauke [Fri, 5 May 2017 09:22:09 +0000 (10:22 +0100)] 
Add explicit role="main" to <main> elements (#22574)

For compatibility in IE10/IE11 which don't otherwise "know" this element's role/don't expose it to AT

8 years agoAdd missing <main> element to documentation
Laussel Loïc [Fri, 5 May 2017 09:10:28 +0000 (11:10 +0200)] 
Add missing <main> element to documentation

includes explicit `role="main"` for IE10/IE11 compatibility

8 years agoAdd shim for "new" HTML5 structural elements (#22573)
Patrick H. Lauke [Fri, 5 May 2017 08:53:45 +0000 (09:53 +0100)] 
Add shim for "new" HTML5 structural elements (#22573)

For IE10 (and any older browsers) support , so at least the layout doesn't fall apart if author is using them.

8 years agoStyling and accessibility clarification for navs documentation
Patrick H. Lauke [Thu, 4 May 2017 16:07:52 +0000 (17:07 +0100)] 
Styling and accessibility clarification for navs documentation

* Split out/expand mention that base navs lack active styles
* Add accessibility notes for navigation bars vs dynamic tabbed interfaces

8 years agoRemove log from WEBrick during js-test-cloud
Johann-S [Tue, 2 May 2017 13:26:45 +0000 (15:26 +0200)] 
Remove log from WEBrick during js-test-cloud

8 years agoLink to package.json Fixed
Peter Gerdes [Mon, 1 May 2017 20:23:38 +0000 (23:23 +0300)] 
Link to package.json Fixed

The link to package.json in the v4 docs was linking to package.json in the v3 source.  Fixed to point to the correct v4 location.  A change like this will need to be made for all branches on version 4 if you want the docs to be linked correctly (github may be smart enough to follow the link to the current branch if you are on github but it was wrong from the main site).

8 years agoAdd watch-css and watch-js + a global watch command
Johann-S [Fri, 28 Apr 2017 11:43:42 +0000 (13:43 +0200)] 
Add watch-css and watch-js + a global watch command

8 years agodon't prefix docs css, it generates .map files and mucks it all up
Mark Otto [Sat, 22 Apr 2017 06:46:54 +0000 (23:46 -0700)] 
don't prefix docs css, it generates .map files and mucks it all up

8 years agowatch task docs + css
Mark Otto [Sat, 22 Apr 2017 06:35:24 +0000 (23:35 -0700)] 
watch task docs + css

8 years agoFix typo removeData for Tabs plugin
Joyce Babu [Fri, 28 Apr 2017 13:31:35 +0000 (19:01 +0530)] 
Fix typo removeData for Tabs plugin

Should remove `data` not `class` on dispose

8 years agoDocumentation cleanup (inc. use of <input ... readonly> for static form controls...
Patrick H. Lauke [Thu, 27 Apr 2017 22:57:10 +0000 (23:57 +0100)] 
Documentation cleanup (inc. use of <input ... readonly> for static form controls example)

* Fix incorrect code indentation
* Remove unnecessary vendor prefix for `box-sizing` - all modern browsers now support this unprefixed
* Remove incorrect `<label>` and change static controls to readonly inputs
* Allow `<img>` elements without `src` to allow for `holder.js` images used in the docs, which lack `src` and use `data-src` instead

8 years agoRun js-test locally before js-test-cloud
Johann-S [Thu, 27 Apr 2017 21:20:29 +0000 (23:20 +0200)] 
Run js-test locally before js-test-cloud

8 years agoFix build by installing grunt dependencies before js-test-cloud
Johann-S [Thu, 27 Apr 2017 21:03:17 +0000 (23:03 +0200)] 
Fix build by installing grunt dependencies before js-test-cloud

8 years agoFix Toggle buttons don't honor [disabled] or .disabled
Anna [Wed, 26 Apr 2017 16:46:05 +0000 (19:46 +0300)] 
Fix Toggle buttons don't honor [disabled] or .disabled

8 years agoDetach accordion from card without requiring 'data-children'
Pierre Vanduynslager [Tue, 25 Apr 2017 07:32:14 +0000 (03:32 -0400)] 
Detach accordion from card without requiring 'data-children'

8 years agobuild
Mark Otto [Sat, 22 Apr 2017 06:58:09 +0000 (23:58 -0700)] 
build

8 years agoArguably more professional pictures of Rick Ross
Zach Leatherman [Thu, 20 Apr 2017 22:06:06 +0000 (17:06 -0500)] 
Arguably more professional pictures of Rick Ross

8 years agoMore minor build tweaks and docs updates.
Bardi Harborow [Thu, 20 Apr 2017 10:33:51 +0000 (20:33 +1000)] 
More minor build tweaks and docs updates.

8 years agoFix for copy/paste error in iOS hack to tooltips
Patrick H. Lauke [Thu, 20 Apr 2017 13:35:33 +0000 (14:35 +0100)] 
Fix for copy/paste error in iOS hack to tooltips

(with apologies, this slipped through due to build system problems on my
end)

8 years agoTweak iOS hack for dropdown
Patrick H. Lauke [Thu, 20 Apr 2017 13:08:40 +0000 (14:08 +0100)] 
Tweak iOS hack for dropdown

Tweak to https://github.com/twbs/bootstrap/pull/22426, where the wrong selector slipped through the net (selecting all of `<body>`s grand-children rather than children)

8 years agoAdd iOS hack to tooltips
Patrick H. Lauke [Thu, 20 Apr 2017 12:49:35 +0000 (13:49 +0100)] 
Add iOS hack to tooltips

Same hack as in https://github.com/twbs/bootstrap/pull/22426 (modulo the selector, which is wrong in that PR and will be updated in a separate PR) to get tooltips to work correctly on iOS. Dynamically adds/removes empty (`noop`) `touchstart` event handlers to all children of `<body>` in order to coax iOS into proper event delegation/bubbling

8 years agoBuild system overhaul.
Bardi Harborow [Wed, 19 Apr 2017 11:59:12 +0000 (21:59 +1000)] 
Build system overhaul.

8 years agoAdd Johann-S to Core team :fireworks:
Johann-S [Wed, 19 Apr 2017 21:36:03 +0000 (23:36 +0200)] 
Add Johann-S to Core team :fireworks:

8 years agoUpdate NuGet shield link to latest version and bower shield link to
Jesse Mandel [Wed, 22 Mar 2017 23:54:58 +0000 (16:54 -0700)] 
Update NuGet shield link to latest version and bower shield link to
a bower search

8 years agoPort button group accessibility callout from v3 to v4
Patrick H. Lauke [Tue, 18 Apr 2017 14:14:07 +0000 (15:14 +0100)] 
Port button group accessibility callout from v3 to v4

8 years agoFix running test on iOS with Saucelabs
Johann-S [Tue, 18 Apr 2017 09:52:16 +0000 (11:52 +0200)] 
Fix running test on iOS with Saucelabs

8 years agoAdd dropdown menu accessibility callout and fix <a> example
Patrick H. Lauke [Tue, 18 Apr 2017 08:34:55 +0000 (09:34 +0100)] 
Add dropdown menu accessibility callout and fix <a> example

As the question often comes up about why Bootstrap does not do "true"
ARIA menus (with their `role="menu"` etc), add an admittedly lengthy
note (tl;dr because BS is generic, and ARIA menus are specific and quite
limiting).

Additionally, fixes up the `<a>` example for dropdown trigger, with the
missing `role="button"` and neutering the `href` (which would be useless
anyway since BS overrides the link-like nature of the `<a>` so it could
never be triggered/followed anyway)

8 years agoFix carousel "hover" behavior on touch-enabled devices
Patrick H. Lauke [Mon, 17 Apr 2017 12:26:46 +0000 (13:26 +0100)] 
Fix carousel "hover" behavior on touch-enabled devices

* Add carousel mouse listeners even if touch events enabled

- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse

* Restart cycle after touchend

as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.

8 years agoRewrite getting started/accessibility docs
Patrick H. Lauke [Sun, 16 Apr 2017 23:04:49 +0000 (00:04 +0100)] 
Rewrite getting started/accessibility docs

A long overdue rewrite of the accessibility section - instead of the few
snippets of strangely superficial and out-of-context advice (skip links,
use correct heading levels), this tries to answer some of the
fundamental questions about "is Bootstrap accessible", with emphasis on
the fact that the final result will depend in large part on what BS is
applied to/on (since BS relies on the markup etc authored by
developers). This also sets out our ambition to have things work for
keyboard and assistive tech users, and that we strive to make all our
examples etc accessible and semantic.

* Changes based on @mdo's feedback

8 years agoRename variable $input-border-focus to $input-border-color-focus (#22413)
Patrick Yeo [Sun, 16 Apr 2017 22:45:10 +0000 (15:45 -0700)] 
Rename variable $input-border-focus to $input-border-color-focus (#22413)

* Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color

8 years agoPrevent long words in `.card-title`s from breaking auto layout
Mark Otto [Sun, 16 Apr 2017 20:54:48 +0000 (13:54 -0700)] 
Prevent long words in `.card-title`s from breaking auto layout

8 years agoMake "Copy" buttons actual buttons
Patrick H. Lauke [Fri, 14 Apr 2017 19:13:46 +0000 (20:13 +0100)] 
Make "Copy" buttons actual buttons

This makes them keyboard-accessible. For mouse users, the only change
here is that the focus outline will remain on the button once clicked
(in future, this can be solved with :focus-ring, but for now this would
require a polyfill). the tooltip is explicitly hidden on `mouseleave`,
so even though the `<button>` retains focus after clicking, the tooltip
won't stay visible once mouse user moves away.
the mouse hover styles have explicitly not been make to also apply to
:focus, so as to minimise the visual impact for
mouse users (though the tooltip remains visible)
 - but due to the default outline and the custom tooltip, it
should be fairly clear when keyboard users set focus to a copy button
too.

8 years agogrunt
Mark Otto [Sun, 16 Apr 2017 20:54:07 +0000 (13:54 -0700)] 
grunt

8 years agoReplace dropdown backdrop hack with cleaner JS-only hack
Patrick H. Lauke [Fri, 14 Apr 2017 08:19:00 +0000 (09:19 +0100)] 
Replace dropdown backdrop hack with cleaner JS-only hack

* Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices

8 years agoremove dropdown.js reliance on roles and fix keyboard navigation
Patrick H. Lauke [Thu, 13 Apr 2017 23:37:52 +0000 (00:37 +0100)] 
remove dropdown.js reliance on roles and fix keyboard navigation

8 years agoMerge branch 'v4-dev' into dropdown-keyboard 21535/head
Patrick H. Lauke [Thu, 13 Apr 2017 22:41:15 +0000 (23:41 +0100)] 
Merge branch 'v4-dev' into dropdown-keyboard

8 years agoFix popover arrow color for bottom position
Idan Cohen [Thu, 13 Apr 2017 08:52:41 +0000 (11:52 +0300)] 
Fix popover arrow color for bottom position

8 years agoMerge branch 'v4-dev' into dropdown-keyboard
Pierre Vanduynslager [Wed, 12 Apr 2017 20:31:50 +0000 (16:31 -0400)] 
Merge branch 'v4-dev' into dropdown-keyboard

8 years agoReword "mobile" to "touch-enabled"
Patrick H. Lauke [Wed, 12 Apr 2017 17:50:31 +0000 (18:50 +0100)] 
Reword "mobile" to "touch-enabled"

...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency

8 years agoReword "mobile" to "touch-enabled" 22422/head
Patrick H. Lauke [Wed, 12 Apr 2017 12:54:16 +0000 (13:54 +0100)] 
Reword "mobile" to "touch-enabled"

...as touch is not exclusive to "mobile" anymore nowadays. also explicitly clarifies this is a fix for iOS, and that it impacts touch laptops etc as well. lastly, renames the variable from "dropdown" to "backdrop" for clarity/consistency

8 years agoMerge branch 'v4-dev' into dropdown-keyboard
Pierre Vanduynslager [Wed, 12 Apr 2017 14:36:14 +0000 (10:36 -0400)] 
Merge branch 'v4-dev' into dropdown-keyboard

8 years agoIndent
Pierre-Denis Vanduynslager [Wed, 12 Apr 2017 13:41:27 +0000 (09:41 -0400)] 
Indent

8 years agoRemove inappropriate role="listbox" from carousels
Patrick H. Lauke [Tue, 11 Apr 2017 10:23:40 +0000 (11:23 +0100)] 
Remove inappropriate role="listbox" from carousels

Closes #22061

Xref #22365