]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
2 years agostats: Allow empty event exporters when registering metrics
Karl Fleischmann [Thu, 15 Jun 2023 11:32:11 +0000 (13:32 +0200)] 
stats: Allow empty event exporters when registering metrics

2 years agolib-storage: string sort - Write sort extensions in message sequence order
Timo Sirainen [Mon, 12 Jun 2023 14:34:47 +0000 (17:34 +0300)] 
lib-storage: string sort - Write sort extensions in message sequence order

This optimizes CPU usage by changing inserting into the middle of an array
into an append-only operation.

2 years agolib-storage: string sort - Replace array_get_modifiable() with array_get() where...
Timo Sirainen [Mon, 12 Jun 2023 14:33:08 +0000 (17:33 +0300)] 
lib-storage: string sort - Replace array_get_modifiable() with array_get() where possible

2 years agolib-index: mail_index_seq_array_lookup() - Optimize append code path
Timo Sirainen [Mon, 12 Jun 2023 14:33:59 +0000 (17:33 +0300)] 
lib-index: mail_index_seq_array_lookup() - Optimize append code path

2 years agolib-storage: mailbox_search_notify() - Ensure that ioloop_time stays sufficiently...
Marco Bettini [Mon, 5 Jun 2023 15:41:13 +0000 (15:41 +0000)] 
lib-storage: mailbox_search_notify() - Ensure that ioloop_time stays sufficiently up to date

This caters for the cases where the ioloop times is not actively refreshed
inside the processing loops (sort command, index search_next())

2 years agolib-storage: search_more() - Ensure mailbox_search_notify() is invoked
Marco Bettini [Mon, 5 Jun 2023 15:43:42 +0000 (15:43 +0000)] 
lib-storage: search_more() - Ensure mailbox_search_notify() is invoked

2 years agoauth: mech-oauth2 - Always fail with protocol specific error
Aki Tuomi [Mon, 15 May 2023 10:49:58 +0000 (13:49 +0300)] 
auth: mech-oauth2 - Always fail with protocol specific error

2 years agoauth: mech-oauth2 - Look for openid configuration URL if missing
Aki Tuomi [Mon, 15 May 2023 08:51:19 +0000 (11:51 +0300)] 
auth: mech-oauth2 - Look for openid configuration URL if missing

2 years agolib-oauth2: Return failure instead of crash with invalid or missing token
Aki Tuomi [Thu, 4 May 2023 12:44:15 +0000 (15:44 +0300)] 
lib-oauth2: Return failure instead of crash with invalid or missing token

2 years agoauth: db-oauth2 - Add accessor for OpenID configuration URL
Aki Tuomi [Wed, 14 Dec 2022 08:10:12 +0000 (10:10 +0200)] 
auth: db-oauth2 - Add accessor for OpenID configuration URL

2 years agoauth: db-oauth2 - Store request username
Aki Tuomi [Fri, 2 Jun 2023 11:20:08 +0000 (14:20 +0300)] 
auth: db-oauth2 - Store request username

2 years agoauth: Add auth_request_fail_with_reply()
Aki Tuomi [Mon, 15 May 2023 09:41:39 +0000 (12:41 +0300)] 
auth: Add auth_request_fail_with_reply()

2 years agoauth: Pass along final response with failure
Aki Tuomi [Mon, 15 May 2023 10:49:41 +0000 (13:49 +0300)] 
auth: Pass along final response with failure

2 years agolib-auth: Move auth_client_request_continue() lower
Aki Tuomi [Mon, 15 May 2023 09:28:53 +0000 (12:28 +0300)] 
lib-auth: Move auth_client_request_continue() lower

Simplifies next commit

2 years agologin-common: Serve final response for client on failure
Aki Tuomi [Mon, 15 May 2023 11:27:55 +0000 (14:27 +0300)] 
login-common: Serve final response for client on failure

2 years agologin-common: Ignore resp when present
Aki Tuomi [Mon, 15 May 2023 10:49:51 +0000 (13:49 +0300)] 
login-common: Ignore resp when present

2 years agoimap: NOTIFY - Perform MessageNew and MessageExpunge events related checks for all...
sergey.kitov [Thu, 8 Jun 2023 11:10:34 +0000 (14:10 +0300)] 
imap: NOTIFY - Perform MessageNew and MessageExpunge events related checks for all mailbox filters.

2 years agoimap: Introduce cmd_notify_parse_event_list() function.
sergey.kitov [Thu, 8 Jun 2023 10:56:52 +0000 (13:56 +0300)] 
imap: Introduce cmd_notify_parse_event_list() function.

2 years agolib-master: Log more details if stats connection handshake times out
Timo Sirainen [Thu, 8 Jun 2023 13:16:06 +0000 (16:16 +0300)] 
lib-master: Log more details if stats connection handshake times out

2 years agoauth: Only test ldap when it's built in
Aki Tuomi [Thu, 1 Jun 2023 11:13:29 +0000 (14:13 +0300)] 
auth: Only test ldap when it's built in

2 years agovirtual: Switch to VIRTUAL_LIST_CONTEXT_REQUIRE()
Timo Sirainen [Thu, 1 Jun 2023 08:39:26 +0000 (11:39 +0300)] 
virtual: Switch to VIRTUAL_LIST_CONTEXT_REQUIRE()

2 years agofts-solr: Use FTS_SOLR_USER_CONTEXT_REQUIRE() where possible
Timo Sirainen [Thu, 1 Jun 2023 08:38:05 +0000 (11:38 +0300)] 
fts-solr: Use FTS_SOLR_USER_CONTEXT_REQUIRE() where possible

2 years agofts: Use FTS_USER_CONTEXT_REQUIRE() where possible
Timo Sirainen [Thu, 1 Jun 2023 08:36:46 +0000 (11:36 +0300)] 
fts: Use FTS_USER_CONTEXT_REQUIRE() where possible

2 years agoauth: db-lua - Ensure fn gets set in auth_lua_script_init()
Aki Tuomi [Wed, 31 May 2023 07:12:00 +0000 (10:12 +0300)] 
auth: db-lua - Ensure fn gets set in auth_lua_script_init()

Satisfies static analysers

2 years agodoveadm stop: Try to wait shorter time between master process checks
Timo Sirainen [Tue, 30 May 2023 10:36:47 +0000 (13:36 +0300)] 
doveadm stop: Try to wait shorter time between master process checks

Start from 1 ms timeout, but double it until 256 ms.

2 years agodoveadm: Don't connect to stats process for "fast" commands
Timo Sirainen [Tue, 30 May 2023 10:36:08 +0000 (13:36 +0300)] 
doveadm: Don't connect to stats process for "fast" commands

This especially caused "doveadm stop" to unnecessarily connect to stats
process, which prevented master process from immediately shutting down
without 1 second delay.

2 years agoauth: db-ldap - Add %{ldap_multi}
Marco Bettini [Wed, 10 May 2023 15:54:32 +0000 (15:54 +0000)] 
auth: db-ldap - Add %{ldap_multi}

2 years agoauth: db_ldap_set_attrs() - Handle braces nesting while splitting on commas
Marco Bettini [Thu, 11 May 2023 09:24:37 +0000 (09:24 +0000)] 
auth: db_ldap_set_attrs() - Handle braces nesting while splitting on commas

2 years agosubmission: submission-client - Prevent NULL memory access upon early connection...
Stephan Bosch [Tue, 7 Feb 2023 20:18:35 +0000 (21:18 +0100)] 
submission: submission-client - Prevent NULL memory access upon early connection abort.

When the SMTP server connection is aborted early in client_create(), the
smtp_server_connection_abort() function clears client->conn immediately, causing
a later nested call to client_stats() from disconnect callback to access
client->conn == NULL. Early abort currently only happens when an anonymous login
is rejected.

2 years agosubmission: Drop unused anonymous_allowed fields
Marco Bettini [Fri, 19 May 2023 08:42:39 +0000 (08:42 +0000)] 
submission: Drop unused anonymous_allowed fields

2 years agoauth: user_callback() - Check if the user is anonymous
Marco Bettini [Fri, 19 May 2023 09:50:45 +0000 (09:50 +0000)] 
auth: user_callback() - Check if the user is anonymous

2 years agolib: Fix MODULE_CONTEXT_REQUIRE() to always panic if context is unset
Timo Sirainen [Tue, 30 May 2023 20:17:21 +0000 (23:17 +0300)] 
lib: Fix MODULE_CONTEXT_REQUIRE() to always panic if context is unset

Previously panic happened only if the module_contexts array was too small,
not when the element inside the array was NULL.

This required rewriting the macros partially as inline functions, which also
simplifies how they work.

2 years agoimap: Don't try to hibernate when COMPRESS is enabled
Timo Sirainen [Tue, 30 May 2023 08:12:18 +0000 (11:12 +0300)] 
imap: Don't try to hibernate when COMPRESS is enabled

It doesn't work properly. Broken by 5f27e25c64555dcaae6cb00c479cd05bc2638081

2 years agoimap: Fix crash when trying to use COMPRESS multiple times
Timo Sirainen [Tue, 30 May 2023 08:10:39 +0000 (11:10 +0300)] 
imap: Fix crash when trying to use COMPRESS multiple times

Broken by 5f27e25c64555dcaae6cb00c479cd05bc2638081

Fixes:
Panic: file cmd-compress.c: line 104 (cmd_compress): assertion failed: (client->input->v_offset == prev_in_offset)

2 years agolib-oauth2: Do not send empty client_id or client_secret
Aki Tuomi [Fri, 12 May 2023 08:48:25 +0000 (11:48 +0300)] 
lib-oauth2: Do not send empty client_id or client_secret

2 years agolib-oauth2: Do not send client_id and client_secret as parameters in POST queries
Aki Tuomi [Fri, 12 May 2023 08:47:41 +0000 (11:47 +0300)] 
lib-oauth2: Do not send client_id and client_secret as parameters in POST queries

They need to be configured in the URL as Basic auth instead.

2 years agolib-oauth2: Do not send client_id & client_secret as POST parameters when doing intro...
Aki Tuomi [Fri, 12 May 2023 05:59:50 +0000 (08:59 +0300)] 
lib-oauth2: Do not send client_id & client_secret as POST parameters when doing introspection

2 years agoglobal: Add INPROGRESS capability
Marco Bettini [Mon, 3 Apr 2023 08:39:40 +0000 (08:39 +0000)] 
global: Add INPROGRESS capability

2 years agoindexer: Provide progress updates in messages counts rather than just percentage...
Marco Bettini [Wed, 17 May 2023 12:33:16 +0000 (12:33 +0000)] 
indexer: Provide progress updates in messages counts rather than just percentage (client side)

2 years agoindexer: Provide progress updates in messages counts rather than just percentage...
Marco Bettini [Wed, 17 May 2023 08:01:33 +0000 (08:01 +0000)] 
indexer: Provide progress updates in messages counts rather than just percentage (indexer side)

2 years agoindexer: index_mailbox_precache() - Move progress variables definitions closer to...
Marco Bettini [Tue, 16 May 2023 15:12:03 +0000 (15:12 +0000)] 
indexer: index_mailbox_precache() - Move progress variables definitions closer to their usage

2 years agofts: fts_indexer_notify() - Retrofit notify_progress()
Marco Bettini [Thu, 9 Feb 2023 11:20:02 +0000 (11:20 +0000)] 
fts: fts_indexer_notify() - Retrofit notify_progress()

Also change the timeout from INDEXER_NOTIFY_INTERVAL_SECS to
MAIL_STORAGE_NOTIFY_INTERVAL_SECS

2 years agoindexer: index_mailbox_precache() - Ensure updates are sent even with few messages...
Marco Bettini [Mon, 6 Mar 2023 15:34:37 +0000 (15:34 +0000)] 
indexer: index_mailbox_precache() - Ensure updates are sent even with few messages and very slow processing

With the former behavior, if we have 101 messages and they take 30 seconds,
the client sees the progress stuck at 0% for most the processign time, only
to see it jump to 99% a fraction of a second before the competion.

This change ensures that the client sees a timely update every time the
integer percentage actually changes.

2 years agoindexer: index_mailbox_precache() - Uncork the socket before starting to send progres...
Marco Bettini [Mon, 6 Mar 2023 15:34:03 +0000 (15:34 +0000)] 
indexer: index_mailbox_precache() - Uncork the socket before starting to send progress updates to the client

Otherwise the client does not receive the updates timely and has
nothing to propagate to the notify_progress() even if progress happened.

2 years agofts: fts_indexer_input_args() - Fix client-side timeout
Marco Bettini [Wed, 1 Mar 2023 14:18:34 +0000 (14:18 +0000)] 
fts: fts_indexer_input_args() - Fix client-side timeout

Client side timeout now just triggers if there is period long enough
where the server doesn't send updates. This works just because the
server is not pushing the updates properly.

The client must timeout BOTH if the server is unresponsive AND if
the server sends updates but the overall elapsed time exceedes.

2 years agoimap: copy/move - Retrofit notify_progress()
Marco Bettini [Thu, 2 Mar 2023 11:11:06 +0000 (11:11 +0000)] 
imap: copy/move - Retrofit notify_progress()

The replacing code in mailbox-storage uses MAIL_STORAGE_NOTIFY_INTERVAL_SECS
instead of MAIL_STORAGE_STAYALIVE_SECS

2 years agoimap: cmd-copy() - Document why we stop iterating at first expunged message
Marco Bettini [Thu, 16 Feb 2023 10:26:14 +0000 (10:26 +0000)] 
imap: cmd-copy() - Document why we stop iterating at first expunged message

2 years agolib-storage: Add mailbox_search_reset_progress_start()
Marco Bettini [Fri, 10 Mar 2023 14:20:10 +0000 (14:20 +0000)] 
lib-storage: Add mailbox_search_reset_progress_start()

2 years agolib-storage: Add mailbox_search_set_progress_hidden()
Marco Bettini [Wed, 1 Mar 2023 13:35:28 +0000 (13:35 +0000)] 
lib-storage: Add mailbox_search_set_progress_hidden()

2 years agolib-storage: maildir_sync_notify() - Retrofit notify_progress()
Marco Bettini [Thu, 9 Feb 2023 10:01:50 +0000 (10:01 +0000)] 
lib-storage: maildir_sync_notify() - Retrofit notify_progress()

Also change the timeout from MAIL_STORAGE_STAYALIVE_SECS to
MAIL_STORAGE_NOTIFY_INTERVAL_SECS

2 years agolib-storage: mailbox_search_notify() - Check also ctx->search_start_time
Marco Bettini [Mon, 13 Feb 2023 17:25:46 +0000 (17:25 +0000)] 
lib-storage: mailbox_search_notify() - Check also ctx->search_start_time

The original check caused the 1st deadline to miss being notified

2 years agoimap: Propagate cmd_tag to notify_progress()
Marco Bettini [Fri, 24 Feb 2023 09:33:54 +0000 (09:33 +0000)] 
imap: Propagate cmd_tag to notify_progress()

2 years agoglobal: Add notify_progress() to struct mail_storage_callbacks
Marco Bettini [Thu, 2 Mar 2023 11:04:57 +0000 (11:04 +0000)] 
global: Add notify_progress() to struct mail_storage_callbacks

2 years agolib-storage: Move progress notification from search_more_with_mail() to mailbox_searc...
Marco Bettini [Wed, 8 Feb 2023 10:01:04 +0000 (10:01 +0000)] 
lib-storage: Move progress notification from search_more_with_mail() to mailbox_search_next_nonblock()

This allows to cover more cases, notably also the search progress
in FILTER=SIEVE extension

2 years agoimap: Rename global var mail-storage-callbacks to imap-storage-callbacks
Marco Bettini [Thu, 2 Mar 2023 10:22:17 +0000 (10:22 +0000)] 
imap: Rename global var mail-storage-callbacks to imap-storage-callbacks

2 years agoimap: Rename mail-storage-callbacks.c to imap-storage-callbacks.c
Marco Bettini [Thu, 2 Mar 2023 10:18:42 +0000 (10:18 +0000)] 
imap: Rename mail-storage-callbacks.c to imap-storage-callbacks.c

2 years agoimap: SEARCH RELEVANCY - Add stack data frame
Marco Bettini [Wed, 8 Feb 2023 10:42:53 +0000 (10:42 +0000)] 
imap: SEARCH RELEVANCY - Add stack data frame

2 years agolib: event-filter - Support escaping wildcards in values
Timo Sirainen [Tue, 2 May 2023 13:08:13 +0000 (16:08 +0300)] 
lib: event-filter - Support escaping wildcards in values

2 years agolib: Add wildcard_match_escaped*()
Timo Sirainen [Tue, 2 May 2023 11:47:23 +0000 (14:47 +0300)] 
lib: Add wildcard_match_escaped*()

This allows using \* and \? to match wildcard characters as-is instead of
being wildcards.

2 years agolib: event_filter_parse() - Add data stack frame
Timo Sirainen [Wed, 26 Apr 2023 20:25:18 +0000 (23:25 +0300)] 
lib: event_filter_parse() - Add data stack frame

2 years agolib: event filter - strlist comparisons should be case-insensitive
Timo Sirainen [Thu, 4 May 2023 15:22:56 +0000 (18:22 +0300)] 
lib: event filter - strlist comparisons should be case-insensitive

All the other string comparisons are case-insensitive as well.

2 years agoauth: passdb/userdb-lua - Improve initialization errors
Aki Tuomi [Tue, 16 May 2023 05:52:18 +0000 (08:52 +0300)] 
auth: passdb/userdb-lua - Improve initialization errors

2 years agoauth: passdb/userdb-lua - Pass arguments to init script
Aki Tuomi [Tue, 9 May 2023 07:57:08 +0000 (10:57 +0300)] 
auth: passdb/userdb-lua - Pass arguments to init script

2 years agoauth: passdb/userdb-lua - Refactor to use t_split_key_value_eq()
Aki Tuomi [Tue, 16 May 2023 06:06:01 +0000 (09:06 +0300)] 
auth: passdb/userdb-lua - Refactor to use t_split_key_value_eq()

2 years agoauth: db-lua - Allow nil response from Lua
Aki Tuomi [Tue, 9 May 2023 09:00:48 +0000 (12:00 +0300)] 
auth: db-lua - Allow nil response from Lua

2 years agoauth: db-lua - Check for nil in auth_request_lua_password_verify()
Aki Tuomi [Tue, 9 May 2023 08:20:59 +0000 (11:20 +0300)] 
auth: db-lua - Check for nil in auth_request_lua_password_verify()

Avoids crash if script calls the function with nil values.

2 years agoauth: db-lua - Support passing arguments to auth_passdb/userdb_init()
Aki Tuomi [Tue, 9 May 2023 07:56:41 +0000 (10:56 +0300)] 
auth: db-lua - Support passing arguments to auth_passdb/userdb_init()

2 years agoauth: db-lua - Call auth_passdb/userdb_init() on the lua script
Aki Tuomi [Tue, 9 May 2023 07:18:57 +0000 (10:18 +0300)] 
auth: db-lua - Call auth_passdb/userdb_init() on the lua script

This allows the script to prepare itself for these roles.

2 years agoauth: db-lua - Move auth_lua_script_init() later
Aki Tuomi [Tue, 9 May 2023 07:05:01 +0000 (10:05 +0300)] 
auth: db-lua - Move auth_lua_script_init() later

Simplifies next change.

2 years agoauth: db-lua - Use parameters structure to initialize script
Aki Tuomi [Tue, 9 May 2023 07:01:53 +0000 (10:01 +0300)] 
auth: db-lua - Use parameters structure to initialize script

Simplifies next commit.

2 years agolib-lua: Do not expect return value from script_init()
Aki Tuomi [Mon, 15 May 2023 06:23:31 +0000 (09:23 +0300)] 
lib-lua: Do not expect return value from script_init()

This is not really needed. Script can call error() if
they need to fail.

2 years agolib-dict: redis_reply_callback() - Don't crash if there is no callback
Marco Bettini [Tue, 16 May 2023 09:40:55 +0000 (09:40 +0000)] 
lib-dict: redis_reply_callback() - Don't crash if there is no callback

2 years agolib-index: Delete dovecot.index.cache during purging if it becomes too large
Timo Sirainen [Mon, 17 Apr 2023 21:08:40 +0000 (00:08 +0300)] 
lib-index: Delete dovecot.index.cache during purging if it becomes too large

This only happens if the file was already too large before the purging
happens. This mainly fixes assert-crashes caused by old huge >1GB cache
files.

Fixes:
Panic: file mail-index-util.c: line 10 (mail_index_uint32_to_offset): assertion failed: (offset < 0x40000000)

2 years agodict-sql: Fix dict iteration with uuid type
Timo Sirainen [Sun, 14 May 2023 21:17:28 +0000 (00:17 +0300)] 
dict-sql: Fix dict iteration with uuid type

dict_iterate_next() is run in its own data stack frame, so the returned
values must not be allocated from data stack.

Broken by 9e46d634d493e9539b4da635138e7b3670b625f2

2 years agomaster: service_anvil_send_log_fd() - Avoid using global services variable
Timo Sirainen [Fri, 12 May 2023 14:45:32 +0000 (17:45 +0300)] 
master: service_anvil_send_log_fd() - Avoid using global services variable

This just makes the code clearer and less likely to break in the future.

2 years agolib-oauth2: Validate scope when configured
Aki Tuomi [Mon, 8 May 2023 05:38:20 +0000 (08:38 +0300)] 
lib-oauth2: Validate scope when configured

2 years agolib-oauth2: Remove typ check
Aki Tuomi [Mon, 8 May 2023 05:23:39 +0000 (08:23 +0300)] 
lib-oauth2: Remove typ check

It is not really useful. And mostly just keeps breaking when people
invent new kty values.

2 years agolib-oauth2: Ensure aud field has client_id when set.
Aki Tuomi [Mon, 8 May 2023 05:21:43 +0000 (08:21 +0300)] 
lib-oauth2: Ensure aud field has client_id when set.

OpenID Connect 1.0 specification says that "aud" field must contain
OAuth 2.0 client_id of the Relying Party as an audience value.

2 years agolib-storage: Add mail_get_message_id_no_validation()
Marco Bettini [Tue, 9 May 2023 07:22:15 +0000 (07:22 +0000)] 
lib-storage: Add mail_get_message_id_no_validation()

2 years agoimap: NOTIFY delayed notifications sent soon after handling IMAP commands
Timo Sirainen [Mon, 8 May 2023 08:08:51 +0000 (11:08 +0300)] 
imap: NOTIFY delayed notifications sent soon after handling IMAP commands

If a change happened within 1 second after any IMAP command was finished,
the notification wasn't sent until some other change/command occurred.

2 years agoauth: mech_gssapi_unwrap() - Release gss_release_buffe(outbuf) before returning
Marco Bettini [Fri, 5 May 2023 15:20:34 +0000 (15:20 +0000)] 
auth: mech_gssapi_unwrap() - Release gss_release_buffe(outbuf) before returning

2 years agoimap-urlauth: Move imap-urlauth-login to its own directory
Marco Bettini [Tue, 2 May 2023 09:18:57 +0000 (09:18 +0000)] 
imap-urlauth: Move imap-urlauth-login to its own directory

2 years agobuild-aux/git-abi-version-gen: Fail if no version found
Aki Tuomi [Tue, 2 May 2023 08:40:53 +0000 (11:40 +0300)] 
build-aux/git-abi-version-gen: Fail if no version found

2 years agobuild-aux/git-abi-version-gen: Allow .git to just exist
Aki Tuomi [Tue, 2 May 2023 07:55:36 +0000 (10:55 +0300)] 
build-aux/git-abi-version-gen: Allow .git to just exist

Fixes compatibility with monolith.

.git can also be a file, pointing to an external location
for the actual git repository. This usually happens when
code is a subrepository.

2 years agolib: guid - Add guid_uuid4_generate()
Aki Tuomi [Thu, 20 Apr 2023 20:27:57 +0000 (23:27 +0300)] 
lib: guid - Add guid_uuid4_generate()

Generates a UUIDv4 UUID

2 years agodict-sql: Use array for type names
Aki Tuomi [Tue, 25 Apr 2023 12:01:29 +0000 (15:01 +0300)] 
dict-sql: Use array for type names

Ensures that type names match with enum.

2 years agodict-sql: Add support for UUID type
Aki Tuomi [Thu, 20 Apr 2023 13:08:10 +0000 (13:08 +0000)] 
dict-sql: Add support for UUID type

2 years agolib-sql: driver-cassandra - Support binding UUID
Aki Tuomi [Thu, 20 Apr 2023 13:00:54 +0000 (13:00 +0000)] 
lib-sql: driver-cassandra - Support binding UUID

2 years agolib-sql: Add UUID datatype
Aki Tuomi [Thu, 20 Apr 2023 12:45:45 +0000 (12:45 +0000)] 
lib-sql: Add UUID datatype

2 years agoimap: set 'internal' flag for NOTIFY-CALLBACK command.
sergey.kitov [Thu, 20 Apr 2023 07:44:03 +0000 (10:44 +0300)] 
imap: set 'internal' flag for NOTIFY-CALLBACK command.

2 years agoimap: Add 'internal' flag to struct client_command_context.
sergey.kitov [Thu, 20 Apr 2023 07:41:37 +0000 (10:41 +0300)] 
imap: Add 'internal' flag to struct client_command_context.

imap_command_finished event is not issued when the flag is set.

2 years agoautogen: Always overwrite old files
Aki Tuomi [Tue, 25 Apr 2023 07:38:05 +0000 (10:38 +0300)] 
autogen: Always overwrite old files

2 years agobuild-aux: Update version scripts to support rolling releases
Aki Tuomi [Tue, 25 Apr 2023 06:28:06 +0000 (09:28 +0300)] 
build-aux: Update version scripts to support rolling releases

For ABI version, we do the following

2023.1 => 2023.ABIv1
2023.1-1 => 2023.ABIv1
2023.1-1+foo5 => 2023.ABIv1

2.4.0 => 2.4.ABIv0
2.4.0-1 => 2.4.ABIv0
2.4.0-1+foo5 => 2.4.ABIv0

Empty version produces 0.0.ABIv0

2 years agolib-storage: Send mail_user_session_finished via mail_user_unref()
Timo Sirainen [Thu, 20 Apr 2023 08:43:55 +0000 (11:43 +0300)] 
lib-storage: Send mail_user_session_finished via mail_user_unref()

The purpose of mail_user_deinit() is to guarantee that the user gets freed
at that point - there's no requirement to call it instead of
mail_user_unref(). Move the mail_user_session_finished event sending to
mail_user_unref() where the rest of the deinitialization code is as well.

This also fixes mail_user_session_finished event being wrongly sent in some
shared mailbox failure code paths. Potentially it fixes also missing
mail_user_session_finished events in some code paths.

2 years agolazy-expunge: lazy_expunge_mail_is_last_instance() - Don't fail if a backend mailbox...
Marco Bettini [Wed, 19 Apr 2023 14:35:42 +0000 (14:35 +0000)] 
lazy-expunge: lazy_expunge_mail_is_last_instance() - Don't fail if a backend mailbox was deleted under a virtual one

2 years agovirtual - void virtual_box_copy_error() - Wrap src->mailbox_deleted to MAIL_ERROR_EXP...
Marco Bettini [Thu, 20 Apr 2023 08:25:32 +0000 (08:25 +0000)] 
virtual - void virtual_box_copy_error() - Wrap src->mailbox_deleted to MAIL_ERROR_EXPUNGED

2 years agovirtual: virtual_sync_backend_boxes() - Don't fail on deleted backend boxes
Marco Bettini [Wed, 19 Apr 2023 13:38:48 +0000 (13:38 +0000)] 
virtual: virtual_sync_backend_boxes() - Don't fail on deleted backend boxes

2 years agovirtual: virtual_transaction_commit() - Don't fail when a backend box was removed...
Marco Bettini [Thu, 6 Apr 2023 15:07:15 +0000 (15:07 +0000)] 
virtual: virtual_transaction_commit() - Don't fail when a backend box was removed and no changes are pending for it

2 years agovirtual: virtual_transaction_commit() - Propagate error details from commits of under...
Marco Bettini [Thu, 6 Apr 2023 15:03:38 +0000 (15:03 +0000)] 
virtual: virtual_transaction_commit() - Propagate error details from commits of underlying physical boxes

2 years agovirtual: virtual_transaction_commit() - Use array_foreach_elem()
Marco Bettini [Thu, 6 Apr 2023 14:58:30 +0000 (14:58 +0000)] 
virtual: virtual_transaction_commit() - Use array_foreach_elem()