]> git.ipfire.org Git - thirdparty/samba.git/log
thirdparty/samba.git
5 months agolib: Remove unused next_token()
Volker Lendecke [Wed, 19 Feb 2025 06:25:05 +0000 (07:25 +0100)] 
lib: Remove unused next_token()

Replaced by next_token_talloc()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agotorture4: Test next_token_talloc() instead of next_token()
Volker Lendecke [Wed, 19 Feb 2025 06:22:43 +0000 (07:22 +0100)] 
torture4: Test next_token_talloc() instead of next_token()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agonsswitch: Remove next_token() from torture4
Volker Lendecke [Wed, 19 Feb 2025 06:14:22 +0000 (07:14 +0100)] 
nsswitch: Remove next_token() from torture4

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agonsswitch: Remove next_token() from wbinfo
Volker Lendecke [Tue, 18 Feb 2025 15:17:03 +0000 (16:17 +0100)] 
nsswitch: Remove next_token() from wbinfo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agosmbd: Remove unused recursive_rmdir()
Volker Lendecke [Fri, 24 Jan 2025 10:26:32 +0000 (11:26 +0100)] 
smbd: Remove unused recursive_rmdir()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agovfs: Rewrite vfs_streams_depot
Volker Lendecke [Fri, 3 Jan 2025 14:24:01 +0000 (15:24 +0100)] 
vfs: Rewrite vfs_streams_depot

This started when I found vfs_streams_depot() is the last user of
recursive_rmdir() and ended as a pretty complete rewrite. Why? This
new version does not call the path-based NEXT_[L]STAT routines
anymore, it only uses FSTATAT. This is one tiny step towards getting
rid of the path-based calls we still have that implicitly depend on
the current working directory. In some distant future I want to get
rid of our chdir() calls and do everything relative to a O_PATH handle
that we opened on the share root when connecting to a share.

This patch removes a few lines, and I don't see a reasonable way to do
this in micro-steps. Structurally it should be simple though:
Everything works off streams_depot_rootdir_pathref(), which gives a
pathref fsp to the ".streams" directory, stream_dir_pathref() turns
this into a pathref of the actual per-file subdirectory.

We also have to remove the special handling of absolute paths in
vfs_shadow_copy2, streams_depot does not send absolute paths anymore.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agovfs: Slightly simplify streams_depot_fstreaminfo()
Volker Lendecke [Fri, 24 Jan 2025 10:21:32 +0000 (11:21 +0100)] 
vfs: Slightly simplify streams_depot_fstreaminfo()

Use metadata_fsp()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agosmbd: Make recursive_rmdir_fsp() public
Volker Lendecke [Thu, 2 Jan 2025 13:49:30 +0000 (14:49 +0100)] 
smbd: Make recursive_rmdir_fsp() public

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agovfs: We expect sane callers of SMB_VFS_RENAMEAT
Volker Lendecke [Fri, 17 Jan 2025 12:15:26 +0000 (13:15 +0100)] 
vfs: We expect sane callers of SMB_VFS_RENAMEAT

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibsmb: Save lines with a direct variable initialization
Volker Lendecke [Mon, 10 Feb 2025 08:54:52 +0000 (09:54 +0100)] 
libsmb: Save lines with a direct variable initialization

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibsmb: Simplify smbXcli_req_unset_pending()
Volker Lendecke [Mon, 10 Feb 2025 10:08:06 +0000 (11:08 +0100)] 
libsmb: Simplify smbXcli_req_unset_pending()

We have ARRAY_DEL_ELEMENT() for this

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agosmbclient3: Replacing Echos in the cli status check with TCP status check.
Felix Bussmann [Mon, 18 Mar 2024 14:19:18 +0000 (15:19 +0100)] 
smbclient3: Replacing Echos in the cli status check with TCP status check.

Replacing the echoes, which were being sent every 5 seconds by the client for a CLI status check, with a method that checks the status of the file descriptor instead, for a POLLHUP, POLLRDHUP, or a timeout.

Signed-off-by: Felix Bussmann <feb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Wed Mar  5 16:21:34 UTC 2025 on atb-devel-224

5 months agos3:smbd: disable "vfs mkdir use tmp name = auto" on OpenBSD
Ralph Boehme [Tue, 4 Mar 2025 16:33:44 +0000 (17:33 +0100)] 
s3:smbd: disable "vfs mkdir use tmp name = auto" on OpenBSD

This is the simplest way to avoid a regression.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15801

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Mar  5 12:37:40 UTC 2025 on atb-devel-224

5 months agoctdb-utils: Fix incorrect FSF address
Martin Schwenke [Tue, 4 Mar 2025 22:16:20 +0000 (09:16 +1100)] 
ctdb-utils: Fix incorrect FSF address

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15820

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Mar  5 03:40:15 UTC 2025 on atb-devel-224

5 months agoldb: remove unused test-sqlite3.sh
Douglas Bagnall [Tue, 4 Mar 2025 00:00:21 +0000 (13:00 +1300)] 
ldb: remove unused test-sqlite3.sh

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agocodespellrc: remove reference to non-existent file
Douglas Bagnall [Mon, 3 Mar 2025 23:56:39 +0000 (12:56 +1300)] 
codespellrc: remove reference to non-existent file

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agoldb: doxygen: don't mention sqlite
Douglas Bagnall [Mon, 3 Mar 2025 23:54:38 +0000 (12:54 +1300)] 
ldb: doxygen: don't mention sqlite

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agoldb:manpages: ldbedit: update url schemes
Douglas Bagnall [Mon, 3 Mar 2025 23:54:11 +0000 (12:54 +1300)] 
ldb:manpages: ldbedit: update url schemes

no sqlite://, but ldaps:// ldb://, mdb://.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agoldb: remove obsolete copy of https://ldb.samba.org
Douglas Bagnall [Mon, 3 Mar 2025 22:02:57 +0000 (11:02 +1300)] 
ldb: remove obsolete copy of https://ldb.samba.org

lib/ldb/web/index.html used to be the source for
https://ldb.samba.org/, but the web page has continued to evolve in
minor ways without git keeping up.

The current difference is all http:// have been converted to https://
and a few URL domains and paths have changed.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agoldb: remove unused nssldb
Douglas Bagnall [Mon, 3 Mar 2025 22:02:21 +0000 (11:02 +1300)] 
ldb: remove unused nssldb

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agoldb: remove unused sqlite backend
Douglas Bagnall [Mon, 3 Mar 2025 22:02:01 +0000 (11:02 +1300)] 
ldb: remove unused sqlite backend

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
5 months agovfs_ceph_new: use libcephfs nonblocking API for async-io ops
Shachar Sharon [Tue, 1 Oct 2024 09:09:40 +0000 (12:09 +0300)] 
vfs_ceph_new: use libcephfs nonblocking API for async-io ops

Use libcephfs non-blocking API (ceph_ll_nonblocking_readv_writev[1]) in
combination with smb VFS async hooks ({pread,pwrite,fsync}_send/_recv).
Fills libcephfs' struct ceph_ll_io_info with single iovec and
submit/complete the operation asynchronously on libcephfs side, with
corresponding tevent schedule-immediate upon completion on smbd side.

Control nonblocking/normal I/O mode via config parameter. The common
parts of async I/O (with/without HAVE_CEPH_ASYNCIO) are united.
Specifically, use same struct vfs_ceph_aio_state and common code via
helper function for all async I/O hooks. When HAVE_CEPH_ASYNCIO
is True _and_ config option 'asyncio = yes' use libcephfs asynchronous
I/O API. Otherwise, fake async operation using normal blocking APIs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15810

[1] https://github.com/ceph/ceph/commit/b4e39f3eccd6734f1ed13c700c136e3aef1777f8

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Mar  4 16:53:21 UTC 2025 on atb-devel-224

5 months agodocs-xml: Update description of dns hotsname (G)
Pavel Filipenský [Thu, 20 Feb 2025 14:22:36 +0000 (15:22 +0100)] 
docs-xml: Update description of dns hotsname (G)

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Pavel Filipensky <pfilipensky@samba.org>
Autobuild-Date(master): Mon Mar  3 10:36:29 UTC 2025 on atb-devel-224

5 months agos3-waf: Enable build of MO files for localization
Ivan Korytov [Tue, 25 Feb 2025 11:48:51 +0000 (14:48 +0300)] 
s3-waf: Enable build of MO files for localization

waf will now generate .mo files for pam_winbind and net when gettext support is enabled and gettext tools are available

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14491

Signed-off-by: Ivan Korytov <korytovip@basealt.ru>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Fri Feb 28 13:26:45 UTC 2025 on atb-devel-224

5 months agos3:locale:pam_winbind: Update Russian translation
Ivan Korytov [Tue, 25 Feb 2025 11:48:04 +0000 (14:48 +0300)] 
s3:locale:pam_winbind: Update Russian translation

Unused translations are left for reference in future updates

Signed-off-by: Ivan Korytov <korytovip@basealt.ru>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
5 months agobootstrap: remove wintest-only dependency
Douglas Bagnall [Mon, 24 Feb 2025 22:30:03 +0000 (11:30 +1300)] 
bootstrap: remove wintest-only dependency

Nobody has run Wintest in the last 10 years, and we don't need it
in our CI tests.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu Feb 27 01:00:10 UTC 2025 on atb-devel-224

5 months agobootstrap: python-cryptography is not just for tests
Douglas Bagnall [Mon, 24 Feb 2025 22:09:40 +0000 (11:09 +1300)] 
bootstrap: python-cryptography is not just for tests

Relating to, but not fixing, these distro bugs:

https://bugs.launchpad.net/ubuntu/+source/samba/+bug/2099895
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086768

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
5 months agosmbd: avoid work in unix token debug no-op
Douglas Bagnall [Thu, 20 Feb 2025 21:51:33 +0000 (10:51 +1300)] 
smbd: avoid work in unix token debug no-op

When the debug level is too low to print, we don't need to allocate
the strings.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15737

Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Pair-programmed-with: Volker Lendecke <vl@samba.org>

5 months agolibcli: avoid work in security token debug no-op
Volker Lendecke [Mon, 14 Oct 2024 11:29:21 +0000 (13:29 +0200)] 
libcli: avoid work in security token debug no-op

When the debug level is too low to print, we don't need to allocate
the strings.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15737

Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Pair-programmed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

5 months agopython:tdb_util: "samba-tool domain backup offline" hangs
Andrea Venturoli [Wed, 19 Feb 2025 07:51:16 +0000 (08:51 +0100)] 
python:tdb_util: "samba-tool domain backup offline" hangs

GNU getopt(3) is by default non-POSIX compliant and accepts options after
positional arguments (unless forced with POSIXLY_CORRECT). This is not portable,
e..g., on FreeBSD. Put options first and then positional arguments.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15804

Signed-off-by: Andrea Venturoli <ml@netfence.it>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
5 months agos3:torture: report kilobytes per second as kB/s, not kb/s
Douglas Bagnall [Thu, 20 Feb 2025 04:21:11 +0000 (17:21 +1300)] 
s3:torture: report kilobytes per second as kB/s, not kb/s

https://bugzilla.samba.org/show_bug.cgi?id=11023

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
5 months agosmbclient: report kilobytes per second as kB/s, not kb/s
Douglas Bagnall [Thu, 20 Feb 2025 04:20:16 +0000 (17:20 +1300)] 
smbclient: report kilobytes per second as kB/s, not kb/s

https://bugzilla.samba.org/show_bug.cgi?id=11023

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
5 months agobuild: --disable-warnings-as-errors avoids some warning config checks
Douglas Bagnall [Wed, 9 Oct 2024 22:20:28 +0000 (11:20 +1300)] 
build: --disable-warnings-as-errors avoids some warning config checks

This fixes compilation with some versions of Honggfuzz.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
5 months agovfs: Fix vfs_streams_depot's fstatat
Volker Lendecke [Tue, 25 Feb 2025 11:09:58 +0000 (12:09 +0100)] 
vfs: Fix vfs_streams_depot's fstatat

a24c7d566f2 does not cover subdirectories

Bug: https://bugzilla.samba.org/show_bug.cgi?id=15816
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Feb 26 09:00:34 UTC 2025 on atb-devel-224

5 months agopython:tests/krb5: let create_trust() take {ingress,egress}_claims_tf_rules
Stefan Metzmacher [Wed, 5 Feb 2025 08:15:47 +0000 (09:15 +0100)] 
python:tests/krb5: let create_trust() take {ingress,egress}_claims_tf_rules

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Mon Feb 24 10:28:02 UTC 2025 on atb-devel-224

5 months agopython:tests/krb5: let create_trust() take forest_info
Stefan Metzmacher [Tue, 7 Jan 2025 19:14:49 +0000 (20:14 +0100)] 
python:tests/krb5: let create_trust() take forest_info

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: let modified_ticket() to take modify_{tkt,enc}_fn
Stefan Metzmacher [Tue, 3 Dec 2024 15:46:31 +0000 (16:46 +0100)] 
python:tests/krb5: let modified_ticket() to take modify_{tkt,enc}_fn

This makes it possible modify the public ticket part well as the enc part.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: add remove_pac_buffers()
Stefan Metzmacher [Thu, 6 Feb 2025 15:47:30 +0000 (16:47 +0100)] 
python:tests/krb5: add remove_pac_buffers()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: set_pac_claims with claims=[] should be an empty blob
Stefan Metzmacher [Thu, 6 Feb 2025 15:46:44 +0000 (16:46 +0100)] 
python:tests/krb5: set_pac_claims with claims=[] should be an empty blob

Review with: git show -w

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: let set_pac_sids() replace the requester_sid
Stefan Metzmacher [Tue, 3 Dec 2024 11:50:18 +0000 (12:50 +0100)] 
python:tests/krb5: let set_pac_sids() replace the requester_sid

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: add set_pac_names() to modify the names in a pac
Stefan Metzmacher [Tue, 3 Dec 2024 11:03:21 +0000 (12:03 +0100)] 
python:tests/krb5: add set_pac_names() to modify the names in a pac

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: give KerberosTicketCreds a basic __str__() function
Stefan Metzmacher [Tue, 18 Feb 2025 11:13:26 +0000 (12:13 +0100)] 
python:tests/krb5: give KerberosTicketCreds a basic __str__() function

This makes debugging easier...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: let create_ccache[_with_ticket] use the correct crealm
Stefan Metzmacher [Tue, 18 Feb 2025 11:11:58 +0000 (12:11 +0100)] 
python:tests/krb5: let create_ccache[_with_ticket] use the correct crealm

It can be different from the servers realm.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: allow get_service_ticket() to fail with expected_status
Stefan Metzmacher [Mon, 2 Dec 2024 19:05:22 +0000 (20:05 +0100)] 
python:tests/krb5: allow get_service_ticket() to fail with expected_status

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agopython:tests/krb5: add KerberosTicketCreds.set_srealm()
Stefan Metzmacher [Mon, 2 Dec 2024 18:59:57 +0000 (19:59 +0100)] 
python:tests/krb5: add KerberosTicketCreds.set_srealm()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos3:testparm: make it clear that 'client use krb5 netlogon' is experimental
Stefan Metzmacher [Sat, 22 Feb 2025 14:58:51 +0000 (15:58 +0100)] 
s3:testparm: make it clear that 'client use krb5 netlogon' is experimental

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15815

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Feb 24 08:43:55 UTC 2025 on atb-devel-224

5 months agosamba-tool/testparm: make it clear that 'client use krb5 netlogon' is experimental
Stefan Metzmacher [Sat, 22 Feb 2025 14:58:51 +0000 (15:58 +0100)] 
samba-tool/testparm: make it clear that 'client use krb5 netlogon' is experimental

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15815

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
5 months agodocs-xml/smbdotconf: make it clear that 'client use krb5 netlogon' is experimental
Stefan Metzmacher [Sat, 22 Feb 2025 14:58:51 +0000 (15:58 +0100)] 
docs-xml/smbdotconf: make it clear that 'client use krb5 netlogon' is experimental

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15815

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
5 months agos4:kdc: split access check preparation from the actual check in samba_kdc_update_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 20:42:53 +0000 (21:42 +0100)] 
s4:kdc: split access check preparation from the actual check in samba_kdc_update_pac()

This allows us to add more access checks later...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Feb 22 23:04:04 UTC 2025 on atb-devel-224

5 months agos4:kdc: let samba_kdc_get_claims_blob() check msDS-EgressClaimsTransformationPolicy
Stefan Metzmacher [Fri, 14 Feb 2025 23:28:18 +0000 (00:28 +0100)] 
s4:kdc: let samba_kdc_get_claims_blob() check msDS-EgressClaimsTransformationPolicy

For now we only allow the implicit (default) or explicit allow all
policy, as well as a deny all policy.

For all others we return an error in order to indicate the
non-supported configuration.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_get_claims_data() check msDS-IngressClaimsTransformationPolicy
Stefan Metzmacher [Thu, 20 Feb 2025 19:19:48 +0000 (20:19 +0100)] 
s4:kdc: let samba_kdc_get_claims_data() check msDS-IngressClaimsTransformationPolicy

For now we only allow the implicit (default) or explicit deny all
policy.

For all others we return an error in order to indicate the
non-supported configuration.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: also fetch msDS-[In|E]gressClaimsTransformationPolicy
Stefan Metzmacher [Wed, 19 Feb 2025 22:52:57 +0000 (23:52 +0100)] 
s4:kdc: also fetch msDS-[In|E]gressClaimsTransformationPolicy

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:dsdb/common: add dsdb_trust_get_claims_tf_policy()
Stefan Metzmacher [Wed, 19 Feb 2025 23:31:36 +0000 (00:31 +0100)] 
s4:dsdb/common: add dsdb_trust_get_claims_tf_policy()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_update_pac() always call samba_kdc_get_upn_info_blob()
Stefan Metzmacher [Wed, 19 Feb 2025 16:28:42 +0000 (17:28 +0100)] 
s4:kdc: let samba_kdc_update_pac() always call samba_kdc_get_upn_info_blob()

There's no reason not to regenerate it, it makes the code more
consistent.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_update_pac() always call samba_kdc_get_logon_info_blob()
Stefan Metzmacher [Wed, 19 Feb 2025 16:25:51 +0000 (17:25 +0100)] 
s4:kdc: let samba_kdc_update_pac() always call samba_kdc_get_logon_info_blob()

The logic in samba_kdc_get_logon_info_blob() also does
talloc_zero(tmp_ctx, DATA_BLOB) followed by calling
samba_get_logon_info_pac_blob().

So we can always just call samba_kdc_get_logon_info_blob().

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: also pass override_resource_groups to samba_kdc_get_logon_info_blob()
Stefan Metzmacher [Wed, 19 Feb 2025 13:34:14 +0000 (14:34 +0100)] 
s4:kdc: also pass override_resource_groups to samba_kdc_get_logon_info_blob()

This will make the following changes easier...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: move device_{info,claims}_blob generation in samba_kdc_update_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 13:12:27 +0000 (14:12 +0100)] 
s4:kdc: move device_{info,claims}_blob generation in samba_kdc_update_pac()

We should generate the device blobs after generating the client blobs
and also after all access checking.

We also use the samba_kdc_get_claims_blob() helper,
which is currently only a wrapper around
claims_data_encoded_claims_set(), but that will change in future...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: regenerate the client claims blob in samba_kdc_update_pac() if needed
Stefan Metzmacher [Wed, 19 Feb 2025 13:05:51 +0000 (14:05 +0100)] 
s4:kdc: regenerate the client claims blob in samba_kdc_update_pac() if needed

Note that samba_kdc_get_claims_data() already handles the
samba_kdc_entry_pac_issued_by_trust() case to clear the
claims received from a trusted domain.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_get_claims_data() indicate if regeneration is needed
Stefan Metzmacher [Thu, 20 Feb 2025 15:33:59 +0000 (16:33 +0100)] 
s4:kdc: let samba_kdc_get_claims_data() indicate if regeneration is needed

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: rewrite the logic in samba_kdc_get_claims_data()
Stefan Metzmacher [Thu, 20 Feb 2025 15:22:43 +0000 (16:22 +0100)] 
s4:kdc: rewrite the logic in samba_kdc_get_claims_data()

We should also go via samba_kdc_get_claims_data_from_pac()
if the pack was issued by a trust. But for now we still
clear the claims, which is the default if
msDS-IngressClaimsTransformationPolicy is missing
on the trustedDomain object.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_get_claims_data_from_pac() return if a buffer was found
Stefan Metzmacher [Thu, 20 Feb 2025 15:13:44 +0000 (16:13 +0100)] 
s4:kdc: let samba_kdc_get_claims_data_from_pac() return if a buffer was found

This will simplify further changes.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_get_pac() use samba_kdc_get_claims_blob()
Stefan Metzmacher [Wed, 19 Feb 2025 16:38:19 +0000 (17:38 +0100)] 
s4:kdc: let samba_kdc_get_pac() use samba_kdc_get_claims_blob()

We should avoid calling claims_data_encoded_claims_set() directly,
we'll have to do more than claims_data_encoded_claims_set() in future,
so make sure we always go via the common samba_kdc_get_claims_blob()
helper.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_get_claims_blob() take struct claims_data as input.
Stefan Metzmacher [Wed, 19 Feb 2025 12:55:22 +0000 (13:55 +0100)] 
s4:kdc: let samba_kdc_get_claims_blob() take struct claims_data as input.

It means samba_kdc_update_pac() does not call
samba_kdc_get_claims_data_from_db() twice,
as it's already called by samba_kdc_get_claims_data().

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_update_pac() always fetch the user claims
Stefan Metzmacher [Wed, 19 Feb 2025 12:41:50 +0000 (13:41 +0100)] 
s4:kdc: let samba_kdc_update_pac() always fetch the user claims

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let samba_kdc_update_pac() use samba_kdc_entry_pac_valid_principal() to check...
Stefan Metzmacher [Wed, 19 Feb 2025 12:35:51 +0000 (13:35 +0100)] 
s4:kdc: let samba_kdc_update_pac() use samba_kdc_entry_pac_valid_principal() to check delegated_proxy

This might not be needed, but it's more consistent.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: remove useless samba_kdc_get_user_info_dc() from samba_kdc_get_device_info_blob()
Stefan Metzmacher [Wed, 19 Feb 2025 12:28:56 +0000 (13:28 +0100)] 
s4:kdc: remove useless samba_kdc_get_user_info_dc() from samba_kdc_get_device_info_blob()

There's no need to call it again if the caller already did.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: move user_info_dc_shallow_copy variable in samba_kdc_update_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 12:23:55 +0000 (13:23 +0100)] 
s4:kdc: move user_info_dc_shallow_copy variable in samba_kdc_update_pac()

This is only needed as tmp variable in the if block...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: move samba_kdc_get_user_info_dc() for the device in samba_kdc_update_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 12:21:47 +0000 (13:21 +0100)] 
s4:kdc: move samba_kdc_get_user_info_dc() for the device in samba_kdc_update_pac()

We should can already call this in the 'need_device' branch, then
it can be reused later.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: move samba_kdc_get_user_info_dc() up in samba_kdc_update_pac()
Stefan Metzmacher [Tue, 18 Feb 2025 16:00:01 +0000 (17:00 +0100)] 
s4:kdc: move samba_kdc_get_user_info_dc() up in samba_kdc_update_pac()

This will make further changes easier.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: introduce need_device helper variable in samba_kdc_update_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 11:34:12 +0000 (12:34 +0100)] 
s4:kdc: introduce need_device helper variable in samba_kdc_update_pac()

Also use samba_kdc_entry_pac_valid_principal() in order to catch
all conditions for a valid device. For principals issued by
trusted domains there's no device.entry pointer!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: make samba_kdc_get_{user_info_dc,claims_data} static
Stefan Metzmacher [Thu, 20 Feb 2025 15:00:23 +0000 (16:00 +0100)] 
s4:kdc: make samba_kdc_get_{user_info_dc,claims_data} static

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: pass samba_kdc_entry_pac to samba_kdc_check_s4u2proxy_rbcd()
Stefan Metzmacher [Thu, 20 Feb 2025 14:16:19 +0000 (15:16 +0100)] 
s4:kdc: pass samba_kdc_entry_pac to samba_kdc_check_s4u2proxy_rbcd()

This simplifies and unifies the callers.

For the MIT kdc we avoid using via kerberos_pac_to_user_info_dc()
directly.

Now both go via samba_kdc_get_user_info_dc() and MIT also
handles the samba_kdc_get_claims_data() path.

For the MIT kdc it means kerberos_pac_to_user_info_dc() is now
called via samba_kdc_get_user_info_dc() ->
samba_kdc_get_user_info_from_pac() and it is followed by
authsam_update_user_info_dc() consistently.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: move samba_kdc_check_s4u2proxy_rbcd() from db-glue to pac-glue
Stefan Metzmacher [Thu, 20 Feb 2025 14:04:08 +0000 (15:04 +0100)] 
s4:kdc: move samba_kdc_check_s4u2proxy_rbcd() from db-glue to pac-glue

This will allow us to make more functions static in the next steps.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: make a lot of pac-glue.c functions static
Stefan Metzmacher [Wed, 19 Feb 2025 16:00:36 +0000 (17:00 +0100)] 
s4:kdc: make a lot of pac-glue.c functions static

This makes the code base less confusing (at least for me).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: let mit_samba_get_pac() use samba_kdc_get_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 15:32:33 +0000 (16:32 +0100)] 
s4:kdc: let mit_samba_get_pac() use samba_kdc_get_pac()

It means we port commit b42fbc78395870c3caa33aa1c9636a59fde9e867 also to the
MIT kdc and enforce authentication policy service restrictions when getting a PAC

We should have this logic only once in order to avoid getting out of
sync between heimdal and MIT regarding the core logic.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: split out samba_kdc_get_pac() from samba_wdc_get_pac()
Stefan Metzmacher [Wed, 19 Feb 2025 14:15:39 +0000 (15:15 +0100)] 
s4:kdc: split out samba_kdc_get_pac() from samba_wdc_get_pac()

samba_kdc_get_pac() will be re-used by mit_samba_get_pac() in
the next step.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: don't return ENOENT from samba_kdc_get_claims_data[_from_pac]
Stefan Metzmacher [Thu, 20 Feb 2025 13:23:05 +0000 (14:23 +0100)] 
s4:kdc: don't return ENOENT from samba_kdc_get_claims_data[_from_pac]

This will matter in the next commits.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:kdc: use better variable names in samba_wdc_check_client_access()
Stefan Metzmacher [Wed, 19 Feb 2025 10:48:55 +0000 (11:48 +0100)] 
s4:kdc: use better variable names in samba_wdc_check_client_access()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:auth: avoid talloc_reference in claims_data_encoded_claims_set()
Stefan Metzmacher [Wed, 19 Feb 2025 14:25:50 +0000 (15:25 +0100)] 
s4:auth: avoid talloc_reference in claims_data_encoded_claims_set()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agowinbindd: find_auth_domain() and find_lookup_domain_from_name() should handle namespaces
Stefan Metzmacher [Tue, 5 Jun 2018 02:29:07 +0000 (04:29 +0200)] 
winbindd: find_auth_domain() and find_lookup_domain_from_name() should handle namespaces

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Feb 22 17:03:27 UTC 2025 on atb-devel-224

5 months agowinbindd: add find_routing_from_namespace_noinit()
Stefan Metzmacher [Thu, 17 May 2018 08:37:34 +0000 (10:37 +0200)] 
winbindd: add find_routing_from_namespace_noinit()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agowinbindd: remember ForestTrustInformation in routing_domain->fti
Stefan Metzmacher [Fri, 2 Feb 2018 03:09:46 +0000 (04:09 +0100)] 
winbindd: remember ForestTrustInformation in routing_domain->fti

This will be used for sid/name filtering in the following commits.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos3:passdb: add pdb_filter_hints()
Stefan Metzmacher [Fri, 2 Feb 2018 08:43:02 +0000 (09:43 +0100)] 
s3:passdb: add pdb_filter_hints()

This reveals information about our own domain/forest.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:rpc_server/lsa: let dcesrv_lsa_lookup_name_account() handle uPNSuffixes
Stefan Metzmacher [Tue, 5 Jun 2018 03:24:03 +0000 (05:24 +0200)] 
s4:rpc_server/lsa: let dcesrv_lsa_lookup_name_account() handle uPNSuffixes

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/lsarpc: add trust_forest_info_match_tln_namespace()
Stefan Metzmacher [Thu, 17 May 2018 08:37:34 +0000 (10:37 +0200)] 
libcli/lsarpc: add trust_forest_info_match_tln_namespace()

This will be used by the namespace filtering part of
sid filtering...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() check RODC callers check...
Stefan Metzmacher [Fri, 14 Feb 2025 22:22:45 +0000 (23:22 +0100)] 
libcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() check RODC callers check computer_name

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:rpc_server/netlogon: let dcesrv_netr_NTLMv2_RESPONSE_verify do RODC checking
Stefan Metzmacher [Fri, 14 Feb 2025 19:56:31 +0000 (20:56 +0100)] 
s4:rpc_server/netlogon: let dcesrv_netr_NTLMv2_RESPONSE_verify do RODC checking

This implements MS-NRPC 3.5.4.5.1.2 RODC server cachability validation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() return the computer_name
Stefan Metzmacher [Fri, 14 Feb 2025 21:57:20 +0000 (22:57 +0100)] 
libcli/auth: let NTLMv2_RESPONSE_verify_netlogon_creds() return the computer_name

This will be used to implement the MS-NRPC 3.5.4.5.1.2 RODC server cachability validation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/auth: add NTLMv2_RESPONSE_verify_trust() checking
Stefan Metzmacher [Fri, 14 Feb 2025 20:54:46 +0000 (21:54 +0100)] 
libcli/auth: add NTLMv2_RESPONSE_verify_trust() checking

This implements MS-NRPC 3.5.4.5.1.1 Pass-through domain name validation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos3:rpc_server/netlogon: let _netr_NTLMv2_RESPONSE_verify() generate trust_forest_doma...
Stefan Metzmacher [Fri, 14 Feb 2025 19:57:07 +0000 (20:57 +0100)] 
s3:rpc_server/netlogon: let _netr_NTLMv2_RESPONSE_verify() generate trust_forest_domain_info array

MS-NRPC 3.5.4.5.1.1 Pass-through domain name validation,
requires to pass information about the trust topology to
NTLMv2_RESPONSE_verify_netlogon_creds()...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:rpc_server/netlogon: let dcesrv_netr_NTLMv2_RESPONSE_verify generate trust_forest_...
Stefan Metzmacher [Fri, 14 Feb 2025 19:03:56 +0000 (20:03 +0100)] 
s4:rpc_server/netlogon: let dcesrv_netr_NTLMv2_RESPONSE_verify generate trust_forest_domain_info array

MS-NRPC 3.5.4.5.1.1 Pass-through domain name validation,
requires to pass information about the trust topology to
NTLMv2_RESPONSE_verify_netlogon_creds()...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/auth: pass trust_forest_domain_info array to NTLMv2_RESPONSE_verify_netlogon_creds
Stefan Metzmacher [Fri, 14 Feb 2025 19:02:30 +0000 (20:02 +0100)] 
libcli/auth: pass trust_forest_domain_info array to NTLMv2_RESPONSE_verify_netlogon_creds

This will be used in the next commits in order to
implement MS-NRPC 3.5.4.5.1.1 Pass-through domain name validation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos3:rpc_server/netlogon: split out _netr_NTLMv2_RESPONSE_verify()
Stefan Metzmacher [Fri, 14 Feb 2025 16:37:45 +0000 (17:37 +0100)] 
s3:rpc_server/netlogon: split out _netr_NTLMv2_RESPONSE_verify()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:rpc_server/netlogon: split out dcesrv_netr_NTLMv2_RESPONSE_verify()
Stefan Metzmacher [Fri, 14 Feb 2025 16:33:31 +0000 (17:33 +0100)] 
s4:rpc_server/netlogon: split out dcesrv_netr_NTLMv2_RESPONSE_verify()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agolibcli/auth: split out NTLMv2_RESPONSE_verify_workstation()
Stefan Metzmacher [Thu, 13 Feb 2025 17:19:42 +0000 (18:19 +0100)] 
libcli/auth: split out NTLMv2_RESPONSE_verify_workstation()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agodocs-xml/smbdotconf: add ft_scanner to 'server service'
Stefan Metzmacher [Tue, 11 Feb 2025 12:42:15 +0000 (13:42 +0100)] 
docs-xml/smbdotconf: add ft_scanner to 'server service'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:dsdb: add forest trust scanner service
Stefan Metzmacher [Mon, 10 Feb 2025 13:56:15 +0000 (14:56 +0100)] 
s4:dsdb: add forest trust scanner service

See MS-ADTS 3.1.1.6.4 PDC Forest Trust Update

It basically connects to all forest trusts
and searches for crossRef objects with
SYSTEM_FLAG_CR_NTDS_DOMAIN under
CN=Partitions,CN=Configuration.

With this information it add/removes
FOREST_TRUST_SCANNER_INFO records into
the msDS-TrustForestTrustInfo of the local
trustedDomain object.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos3:tldap: add tldap_msg_rc() helper
Stefan Metzmacher [Tue, 11 Feb 2025 11:45:06 +0000 (12:45 +0100)] 
s3:tldap: add tldap_msg_rc() helper

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agowinbindd: make use of lsaR[G|S]etForestTrustInformation2 to allow SCANNER_INFO
Stefan Metzmacher [Wed, 12 Feb 2025 16:09:05 +0000 (17:09 +0100)] 
winbindd: make use of lsaR[G|S]etForestTrustInformation2 to allow SCANNER_INFO

Note that we don't need to handle a fallback to old servers,
because we only talk to ourself here.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 months agos4:rpc_server/lsa: add lsaR[G|S]etForestTrustInformation2 support to allow FOREST_TRU...
Stefan Metzmacher [Thu, 6 Feb 2025 09:28:37 +0000 (10:28 +0100)] 
s4:rpc_server/lsa: add lsaR[G|S]etForestTrustInformation2 support to allow FOREST_TRUST_SCANNER_INFO

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>