Marek Vavruša [Thu, 4 Jan 2018 00:07:35 +0000 (16:07 -0800)]
allow access to cache object through context
this surfaces the struct kr_cache through context variable,
it doesn't implement any API or documented interface for it,
so I just added a tests for the struct presence and introspection
Petr Špaček [Wed, 3 Jan 2018 16:56:39 +0000 (17:56 +0100)]
CI: publish coverage only for master branch (on web)
Non-master branches must not overwrite results from master branch.
From now only master branch publishes results on Gitlab Pages.
Results for other branches can be downloaded from artifacts.
Petr Špaček [Fri, 22 Dec 2017 12:21:24 +0000 (13:21 +0100)]
CI coverage: merge test coverage data from parallel runs
We run tests in paralell so have to make sure that coverage tools
do not overwrite results from each run.
This is hacky because lcov tool insists on having gcno and gcda files
in the same place as original source, so we have to copy files
to workaround this.
Petr Špaček [Thu, 21 Dec 2017 09:09:11 +0000 (10:09 +0100)]
CI coverage: add missing Lua files to the report
Luacov does not know about files which were not loaded at all.
Script luacov_gen_empty.sh generates empty luacov stats for all files
which forces luacov to show all files.
Petr Špaček [Wed, 20 Dec 2017 11:47:10 +0000 (12:47 +0100)]
CI coverage: handle Lua code coverage properly
Luacov statistics contained paths to installed files instead of source
files that it was a mess. The stats are now rewritten using hacky
mapping (created from install commands produced by make).
Also, branch and function coverage for Lua was always zero so now it is
turned off not to confuse users.
kresd config for respdiff now enables luacov as well.
Petr Špaček [Fri, 8 Dec 2017 13:22:15 +0000 (14:22 +0100)]
daemon: add missing RR type definitions
Some RR type definitions present in IANA DNS parameters registry were
missing in kresd. This commit synchronizes the tables with IANA registry
as of 2017-12-08 13:20 UTC.
At the same time, this commit is
fixup! converted constant tables, support kres.type.TYPE1234
The mentioned commit accidentally removed NULL definition which broke TA
signaling module.
Petr Špaček [Thu, 7 Dec 2017 16:45:58 +0000 (17:45 +0100)]
rplan: fix kr_qflags_*() to work with more than 32 flags
Originally division around sizeof(uint32_t) caused silent truncation
for struct kr_qflags with sizes not multiple of 4 bytes.
Attempts to optimize using uint32_t blocks could lead to read/write
beyond end of uint32_t so I'm not willing to risk it.
Also, the code was refactored to avoid duplication between _set and _clear.
Quick look into assembly produced by gcc 7.2.1 with -O2 on x86_64 confirms that
all auxiliary functions got inlined so there are not extra function calls.
Unit tests are attached. These fail on the previous version of _set() and
_clear() and work now.
Petr Špaček [Thu, 7 Dec 2017 08:37:26 +0000 (09:37 +0100)]
CI: use Knot DNS 2.6 instead of master
Hopefully this will make build more reliable because breakage in Knot
DNS master will not affect us. On the other hand, we must not forget to
update Knot DNS in the image!
Vítězslav Kříž [Mon, 4 Dec 2017 14:15:33 +0000 (15:15 +0100)]
hints: server stop when root hints load failed
If user provides custom hints file with config option hints.root_file('file')
resovler fail with error. Before it just silently pass and may fail
when loading defaults file, which leads to confusing error message.
Petr Špaček [Fri, 1 Dec 2017 20:30:58 +0000 (21:30 +0100)]
fixup! client: move sources into separate directory
Previous cleanup attempt broke installation on systems without libedit.
client-install has to be defined at least as .PHONY target.
(I want to avoid if spagethi outside of client.mk.)
Petr Špaček [Fri, 1 Dec 2017 13:00:36 +0000 (14:00 +0100)]
client: move sources into separate directory
Let's not mix daemon and client files as client might grow to multiple
files in future. This will also help with upcomming changes to packaging
scripts.
Petr Špaček [Tue, 28 Nov 2017 10:27:43 +0000 (11:27 +0100)]
scripts: pack all submodules with make-archive.sh
It does not make sense to create "distribution" tarball with dirty
working tree or missing submodules, so this is now forbidden.
make-archive.sh requires clean working tree and all submodules.
Packing all submodules prevents us from releasing incomplete tarball,
especially around release time.
Distributions like Fedora are gradually getting ability to run
integration test suites so it does not hurt to pack everything including
test.
Marek Vavruša [Sun, 26 Nov 2017 00:54:11 +0000 (16:54 -0800)]
build: added `make coverage` to compute C and Lua code coverage
Currently it gathers gcov and luacov code coverage, and merges it
in a single lcov info file. It returns summary at the end which the
CI can parse and interpret. It can build a html report later using
the data.
Marek Vavruša [Sun, 26 Nov 2017 00:23:46 +0000 (16:23 -0800)]
tests/config: added a TAP-based test environment for modules/configs
I moved the test files to module directories because it allows
vendoring of whole modules including tests etc.
The test environment provides convenience functions and produces
test output in TAP format. Ideally all tests should use a common
format, so that CI can parse it provide better test output on PRs.
It seems like Gitlab CI doesn't support anything yet, but there
are two sort-of standards supported in CI tools - TAP and JUnit.
I chose TAP because it's easier to read for humans, cmocka supports it,
and it should be easier to adapt Deckard. There are also tools to
convert TAP into JUnit XML file.
Also added more tests for global functions and variables, and the
test tool now also tracks coverage (if `luacov` is installed).
Also fixed improper promotion of `ffi` to global variable.
```
$ luacheck --codes daemon/lua/
Checking daemon/lua/config.lua OK
Checking daemon/lua/kres-gen.lua OK
Checking daemon/lua/kres.lua OK
Checking daemon/lua/sandbox.lua OK
Checking daemon/lua/trust_anchors.lua OK
Checking daemon/lua/zonefile.lua OK
Marek Vavruša [Fri, 24 Nov 2017 04:32:01 +0000 (20:32 -0800)]
modules/predict: added test for prediction process
this tests that:
* sampling frequent queries works
* the code to find periodic appearences of the same name and type
* resolving predicted queries works
it doesn't test pessimistic cases or failure modes
Marek Vavruša [Fri, 24 Nov 2017 04:30:00 +0000 (20:30 -0800)]
tests/config: added basic assert support (compatible with busted)
There is no dependency on a testing library yet, so I added a
basic interface for mocking and asserting test values to get
something to start with. I'll probably replace it with busted
or telescope later on to get nicer testing output.