]> git.ipfire.org Git - thirdparty/coreutils.git/log
thirdparty/coreutils.git
3 years agobuild: update gnulib submodule to latest
Paul Eggert [Sun, 13 Feb 2022 00:44:54 +0000 (16:44 -0800)] 
build: update gnulib submodule to latest

3 years agodoc: avoid using "[" is URLS in --help output
Pádraig Brady [Sat, 12 Feb 2022 18:43:25 +0000 (18:43 +0000)] 
doc: avoid using "[" is URLS in --help output

* src/system.h (emit_ancillary_info): While supported if entered
  manually, the "[" character is not highlighted as part of a
  URL by default in terminals, so avoid using it.
  Addresses https://bugs.gnu.org/53946

3 years agodoc: adust --help, --version alignment
Pádraig Brady [Sat, 12 Feb 2022 18:23:48 +0000 (18:23 +0000)] 
doc: adust --help, --version alignment

* src/system.h: Adjust the alignment of the --help
and --version option descriptions, to start at column 21.
This better aligns with the descriptions of most commands,
and also aligns with the minimum column a description must
start at to ensure a blank line is not output when a description
follows an option on a line by itself.

3 years agodoc: rmdir: improve --help formatting
Pádraig Brady [Sat, 12 Feb 2022 18:16:10 +0000 (18:16 +0000)] 
doc: rmdir: improve --help formatting

* src/rmdir.c (usage): Move description to column 21,
so that a --long-option on its own line without a
trailing description, doesn't have an erroneous blank
line inserted between the option and description.
Also group descriptions with blank lines rather than indents,
so that man pages don't have erroneous blank lines
added within the description.
Addresses https://bugs.gnu.org/53946

3 years agodoc: ls: reference dircolors(1) from --help
Pádraig Brady [Sat, 12 Feb 2022 18:03:38 +0000 (18:03 +0000)] 
doc: ls: reference dircolors(1) from --help

* src/ls.c (usage): s/dircolors/dircolors(1)/.
* man/ls.x [SEE ALSO]: Reference dircolors(1).
Addresses https://bugs.gnu.org/53946

3 years agodoc: ls: improve --help formatting
Pádraig Brady [Sat, 12 Feb 2022 17:52:32 +0000 (17:52 +0000)] 
doc: ls: improve --help formatting

* src/ls.c (usage): Use blank lines to group multi-line
option descriptions, rather than indenting.
This results in more consistent alignment of descriptions,
and also avoids erroneous new lines in generated in man pages.
Addresses https://bugs.gnu.org/53946

3 years agodoc: improve version-sort doc
Paul Eggert [Tue, 8 Feb 2022 18:52:10 +0000 (10:52 -0800)] 
doc: improve version-sort doc

* doc/coreutils.texi, doc/sort-version.texi:
Capitalize “Coreutils”.
* doc/sort-version.texi: Don’t emphasize natural sort so much,
since Coreutils has just version sort.
Use the term “lexicographic” instead of “alphabetic” or “standard”.
Suggest combining ‘V’ with ‘b’, and show why ‘b’ is needed.
Use shorter titles for sections, as GNU Emacs displays info poorly
when titles are too long to fit in a line.
Use @samp instead of @code for samples of data.
Do not use @samp{@code{...}}; @samp{...} should suffice and
double-nesting looks bad with Emacs.
Omit blank lines in examples that would not be present
in actual shell sessions.
Quote with `` and '', not with " or with '.
Mention dpkg --compare-versions more prominently.
Don’t rely on "\n" being equivalent to "\\n" in shell args.
Prefer Unicode name for hyphen-minus.

3 years agodircolors: highlight .avif as image
Christian Hesse [Tue, 4 Jan 2022 09:56:53 +0000 (10:56 +0100)] 
dircolors: highlight .avif as image

This add highlighting for AV1 Image File Format (AVIF):
https://aomediacodec.github.io/av1-avif/

* src/dircolors.hin: Highlight .avif as image.

Signed-off-by: Christian Hesse <mail@eworm.de>
3 years agodate: test against bug#50115
Paul Eggert [Sat, 5 Feb 2022 21:46:44 +0000 (13:46 -0800)] 
date: test against bug#50115

* tests/misc/date.pl: Add test.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Sat, 5 Feb 2022 19:08:45 +0000 (11:08 -0800)] 
build: update gnulib submodule to latest

3 years agodoc: fix somewhat ambiguous date format representation
Pádraig Brady [Sat, 5 Feb 2022 12:47:33 +0000 (12:47 +0000)] 
doc: fix somewhat ambiguous date format representation

* doc/coreutils.texi (date invocation): Remove @var{...} usage,
as that capitalizes in the representation and thus somewhat
ambiguates the format wrt Month and Minute.  This also avoids
a syntax check failure about redundant capitalization in @var{}.

3 years agodate: improve doc
Paul Eggert [Sat, 5 Feb 2022 02:21:06 +0000 (18:21 -0800)] 
date: improve doc

Problem reported by Dan Jacobson (Bug#51288).
* doc/coreutils.texi (date invocation, Setting the time)
(Options for date):
* src/date.c (usage): Improve doc.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Fri, 4 Feb 2022 22:29:28 +0000 (14:29 -0800)] 
build: update gnulib submodule to latest

3 years agoid: print groups of listed name
Paul Eggert [Fri, 4 Feb 2022 22:43:31 +0000 (14:43 -0800)] 
id: print groups of listed name

Problem reported by Vladimir D. Seleznev (Bug#53631).
* src/id.c (main): Do not canonicalize user name before
deciding what groups the user belongs to.

3 years agodoc: add NEWS entry for recent cksum change
Bernhard Voelker [Tue, 1 Feb 2022 13:11:47 +0000 (13:11 +0000)] 
doc: add NEWS entry for recent cksum change

* NEWS (Changes in behavior): Add entry for commit v9.0-92-ga42a03913.

3 years agomaint: suppress bogus noreturn warnings
Paul Eggert [Tue, 1 Feb 2022 06:08:56 +0000 (22:08 -0800)] 
maint: suppress bogus noreturn warnings

* configure.ac: Move the single-binary code before the
gcc-warnings code, so that the latter can depend on the former.
Suppress -Wsuggest-attribute=noreturn with single binaries,
to avoid diagnostics like the following:
  src/expr.c: In function 'single_binary_main_expr':
  error: function might be candidate for attribute 'noreturn'
Problem reported by Pádraig Brady in:
https://lists.gnu.org/r/coreutils/2022-01/msg00061.html

3 years agotr: pacify -fsanitizer=leak
Paul Eggert [Tue, 1 Feb 2022 03:58:15 +0000 (19:58 -0800)] 
tr: pacify -fsanitizer=leak

* src/tr.c (main): Use main_exit, not return, in a couple of
places missed last time.

3 years agochgrp: fix typo in previous change
Paul Eggert [Tue, 1 Feb 2022 03:57:14 +0000 (19:57 -0800)] 
chgrp: fix typo in previous change

* src/chgrp.c (main): Use main_exit, not exit.

3 years agomaint: mark some _Noreturn functions
Paul Eggert [Tue, 1 Feb 2022 03:55:54 +0000 (19:55 -0800)] 
maint: mark some _Noreturn functions

* src/basenc.c (finish_and_exit, do_encode, do_decode):
* src/comm.c (compare_files):
* src/tsort.c (tsort):
* src/uptime.c (uptime):
Mark with _Noreturn.  Otherwise, unoptimized compilations may warn
that the calling renamed-main function doesn't return a value,
when !lint and when single-binary.

3 years agodf: fix memory leak
Paul Eggert [Tue, 1 Feb 2022 03:52:43 +0000 (19:52 -0800)] 
df: fix memory leak

* src/df.c (devlist_free): Remove.
(filter_mount_list): Free all of devlist, instead of merely
the entries in devlist_table.

3 years agomaint: cut: avoid exporting recently added variable
Pádraig Brady [Mon, 31 Jan 2022 21:59:09 +0000 (21:59 +0000)] 
maint: cut: avoid exporting recently added variable

* src/cut.c: Make output_delimiter_default static,
as identified by `make syntax-check`.

3 years agomaint: pacify gcc -flto -Wmaybe-uninitialized
Paul Eggert [Mon, 31 Jan 2022 18:21:48 +0000 (10:21 -0800)] 
maint: pacify gcc -flto -Wmaybe-uninitialized

* gl/lib/xdectoint.c (__xnumtoint): Tell gcc that ‘error’
does not return here.
* gl/modules/xdectoint (Depends-on): Add stdbool, verify.

3 years agodd: do not access uninitialized
Paul Eggert [Mon, 31 Jan 2022 18:20:21 +0000 (10:20 -0800)] 
dd: do not access uninitialized

* src/dd.c (parse_integer): Avoid undefined behavior
that accesses an uninitialized ‘n’ when e == LONGINT_INVALID.
Return more-accurate error code when INTMAX_MAX < n.

3 years agouptime: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
uptime: simplify -fsanitize=leak pacification

* src/uptime.c (uptime): Exit here ...
(main): ... instead of here.

3 years agouniq: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
uniq: remove IF_LINT

* src/uniq.c (check_file): Remove a no-longer-needed IF_LINT.

3 years agounexpand: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
unexpand: remove IF_LINT

* src/unexpand.c (unexpand): Remove a no-longer-needed IF_LINT.

3 years agopr: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
pr: remove IF_LINT

* src/pr.c (read_line): Remove a no-longer-needed IF_LINT.

3 years agotruncate: simplify
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
truncate: simplify

* src/truncate.c (do_ftruncate): Check != 0 instead of == -1.
Avoid a cast.
(main): Use C99 style decls after statements.
Simplify ‘open’ logic.

3 years agoshred: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
shred: remove IF_LINT

* src/shred.c (dopass): Remove a no-longer-needed IF_LINT.

(read_line): Remove an IF_LINT; no longer needed with
today’s GCC.

3 years agopr: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
pr: simplify -fsanitize=leak pacification

* src/pr.c (main): Remove an IF_LINT.
Use main_exit rather than return.

3 years agopinky: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
pinky: simplify -fsanitize=leak pacification

* src/pinky.c (short_pinky): exit instead of freeing.

3 years agopaste: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
paste: remove IF_LINT

* src/paste.c (paste_parallel): Remove no-longer-needed IF_LINT.

3 years agohostname: simplify
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
hostname: simplify

* src/hostname.c (sethostname): Provide a substitute on all
platforms, to simplify the mainline code.
(main): Simplify.  Remove an IF_LINT.
Use main_exit rather than return.

3 years agofactor: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
factor: remove IF_LINT

* src/factor.c (factor_using_squfof) [USE_SQUFOF]:
Use plain assert (...), not IF_LINT (assert (...)).
This code is currently never compiled or executed,
so this is merely a symbolic cleanup.

3 years agoexpand: remove IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
expand: remove IF_LINT

* src/expand.c (expand): Remove no-longer-needed IF_LINT.

3 years agoenv: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
env: simplify -fsanitize=leak pacification

* src/env.c (unset_envvars): Remove IF_LINT code.
(main): Use main_exit, not return.

3 years agomd5sum: remove IF_LINTs
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
md5sum: remove IF_LINTs

* src/digest.c (digest_check): Remove IF_LINTs that are no longer
needed, as GCC has gotten smarter since 2008.

3 years agodf: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
df: simplify -fsanitize=leak pacification

* src/df.c (print_table, main) [lint]: Omit unnecessary cleanup.
(main): Use main_exit, not return.

3 years agodate: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
date: simplify -fsanitize=leak pacification

* src/date.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agocut: simplify and remove an IF_LINT
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
cut: simplify and remove an IF_LINT

* src/cut.c (enum operating_mode, operating_mode)
(output_delimiter_specified, cut_stream):
Remove; no longer needed.
(output_delimiter_default): New static var.  Code can now
use ‘output_delimiter_string != output_delimiter_default’
instead of ‘output_delimiter_specified’.
(cut_file): New arg CUT_STREAM.  Caller changed.
(main): Simplify.  Coalesce duplicate code.  Redo to avoid need
for IF_LINT, or for the static var.  No need to xstrdup optarg.

3 years agocut: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
cut: simplify -fsanitize=leak pacification

* src/set-fields.c (reset_fields): Remove, as it’s not needed for
-fsanitize=leak even when ‘lint’ is defined.  All uses removed.

3 years agocp: simplify GCC pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
cp: simplify GCC pacification

* src/cp.c (make_dir_parents_private): Remove IF_LINT code that is
no longer needed, as GCC has apparently gotten smarter since 2008.

3 years agochown: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
chown: simplify -fsanitize=leak pacification

* src/chgrp.c, src/chown.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agobasenc: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
basenc: simplify -fsanitize=leak pacification

* src/basenc.c (finish_and_exit): New function.
(do_encode, do_decode): Use it.  Accept new INFILE arg.  Remove
no-longer-needed IF_LINT code.  Exit when done.  Caller changed.

3 years agotest: simplify gcc pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
test: simplify gcc pacification

* src/test.c (get_mtime) [lint]: Omit ifdef lint code that is no
longer needed, as GCC has gotten smarter since 2005.

3 years agotail: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
tail: simplify -fsanitize=leak pacification

Also, close a no-longer-needed file descriptor when falling
back from inotify.
* src/tail.c (tail_forever_inotify): Return void, not bool.  Exit
on fatal error, or on successful completion.  Accept an extra
argument pointing to a hash table that the caller should free on
non-fatal error; this simplifies cleanup.  Don’t bother setting
errno when returning.  Caller changed.
(main): Omit no-longer-needed IF_LINT code.  Close inotify
descriptor if inotify fails; this fixes a file descriptor leak and
means we needn’t call inotify_rm_watch.  Use main_exit, not return.

3 years agotac: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
tac: simplify -fsanitize=leak pacification

* src/tac.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agoshuf: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
shuf: simplify -fsanitize=leak pacification

* src/shuf.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agonumfmt: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
numfmt: simplify -fsanitize=leak pacification

* src/numfmt.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agomktemp: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
mktemp: simplify -fsanitize=leak pacification

* src/mktemp.c (main) [lint]: Omit unnecessary cleanup.
Use main_exit, not return.

3 years agodd: simplify -fsanitize=leak pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
dd: simplify -fsanitize=leak pacification

* src/dd.c (cleanup) [lint]: Omit unnecessary cleanup.
(main): Use main_exit, not return.

3 years agocp: simplify cp/install/ln/mv pacification
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
cp: simplify cp/install/ln/mv pacification

* src/copy.c (dest_info_free, src_info_free) [lint]:
Remove.  All uses removed.
(copy_internal): Pacify only Clang and Coverity; GCC doesn’t need it.
* src/cp-hash.c (forget_all) [lint]: Remove.  All uses removed.
* src/cp.c, src/install.c, src/ln.c, src/mv.c (main):
Use main_exit, not return.

3 years agochmod: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
chmod: pacify -fsanitizer=leak

* src/chmod.c (main): Use main_exit, not return.

3 years agoyes: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
yes: pacify -fsanitizer=leak

* src/yes.c (main): Use main_exit, not return.

3 years agotsort: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
tsort: pacify -fsanitizer=leak

* src/tsort.c (detect_loop): Free removed successor.

3 years agosort: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
sort: pacify -fsanitizer=leak

* src/sort.c (pipe_fork, keycompare, sort, main):
Remove lint code that no longer seems to be needed.
(sort): Unconditionally compile ifdef lint code that is needed
to free storage even when not linting.
(main): Use main_exit, not return.

3 years agosplit: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
split: pacify -fsanitizer=leak

* src/split.c (lines_rr): New arg FILESP.  All uses changed.
(main): Use main_exit, not return.  Omit unnecessary alignfree.

3 years agoptx: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
ptx: pacify -fsanitizer=leak

* src/ptx.c (unescape_string): Rename from copy_unescaped_string,
and unescape the string in place.  Callers changed.  This way,
we needn’t allocate storage and thus needn’t worry about
-fsanitizer=leak.

3 years agoseq: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
seq: pacify -fsanitizer=leak

* src/seq.c (seq_fast): If successful, exit rather than returning true.
Callers changed.
(main): Use main_exit, not return.

3 years agotsort: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
tsort: pacify -fsanitizer=leak

* src/tsort.c (struct item.balance): Now signed char to save space.
(struct item.printed): New member.
(new_item): Initialize k->printed to false.  Simplify via xzalloc.
(scan_zeros): Use k->printed rather than nulling out string.
(tsort): Move exiting code here ...
(main): ... from here.
(tsort) [lint]: Omit no-longer-needed code.  Instead, set head->printed.

3 years agotr: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
tr: pacify -fsanitizer=leak

* src/tr.c (main): Use main_exit, not return.

3 years agostat: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
stat: pacify -fsanitizer=leak

* src/stat.c (main):  Use main_exit, not return.

3 years agocomm: pacify -fsanitizer=leak
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
comm: pacify -fsanitizer=leak

* src/comm.c (compare_files): Move exiting code here ...
(main): ... from here, to pacify gcc -fsanitize=leak.

3 years agoexpr: lint cleanup, and introducing main_exit
Paul Eggert [Mon, 31 Jan 2022 16:42:07 +0000 (08:42 -0800)] 
expr: lint cleanup, and introducing main_exit

This introduces a new macro main_exit, which is useful
for pacifying gcc -fsanitizer=lint and in some cases
means we can remove some ‘IF_LINT’ and ‘ifdef lint’ code.
* src/expr.c (main): Use main_exit, not return.
(docolon): Omit an IF_LINT that GCC no longer needs.
* src/system.h (main_exit): New macro.

3 years agocksum: use more exact selection of digest algorithms
Pádraig Brady [Sun, 30 Jan 2022 20:19:48 +0000 (20:19 +0000)] 
cksum: use more exact selection of digest algorithms

Use more constrained argument matching
to improve forward compatibility and robustness.

For example it's better that `cksum -a sha3` is _not_
equivalent to `cksum -a sha386`, so that a user
specifying `-a sha3` on an older cksum would not be surprised.

Also argmatch() is used when parsing tags from lines like:
SHA3 (filename) = abcedf....
so it's more robust that older cksum instances to fail
earlier in the parsing process, when parsing output from
possible future cksum implementations that might support SHA3.

* src/digest.c (algorithm_from_tag): Use argmatch_exact()
to ensure we don't match abbreviated algorithms.
(main): Likewise.
* tests/misc/cksum-a.sh: Add a test case.

3 years agobuild: update gnulib submodule to latest
Pádraig Brady [Sun, 30 Jan 2022 20:24:27 +0000 (20:24 +0000)] 
build: update gnulib submodule to latest

To provide argmatch_exact() that does not
use abbreviated matching, to be used by cksum.

3 years agomv: when installing to dir use dir-relative names
Paul Eggert [Sat, 29 Jan 2022 19:40:17 +0000 (11:40 -0800)] 
mv: when installing to dir use dir-relative names

When the destination for mv is a directory, use functions like openat
to access the destination files, when such functions are available.
This should be more efficient and should avoid some race conditions.
Likewise for 'install'.
* src/cp.c (must_be_working_directory, target_directory_operand)
(target_dirfd_valid): Move from here ...
* src/system.h: ... to here, so that install and mv can use them.
Make them inline so GCC doesn’t complain.
* src/install.c (lchown) [HAVE_LCHOWN]: Remove; no longer needed.
(need_copy, copy_file, change_attributes, change_timestamps)
(install_file_in_file, install_file_in_dir):
New args for directory-relative names.  All uses changed.
Continue to pass full names as needed, for diagnostics and for
lower-level functions that do not support directory-relative names.
(install_file_in_dir): Update *TARGET_DIRFD as needed.
(main): Handle target-directory in the new, cp-like way.
* src/mv.c (remove_trailing_slashes): Remove static var; now local.
(do_move): New args for directory-relative names.  All uses changed.
Continue to pass full names as needed, for diagnostics and for
lower-level functions that do not support directory-relative names.
(movefile): Remove; no longer needed.
(main): Handle target-directory in the new, cp-like way.
* tests/install/basic-1.sh:
* tests/mv/diag.sh: Adjust to match new diagnostic wording.

3 years agocp: fix comment typo
Paul Eggert [Sat, 29 Jan 2022 19:40:16 +0000 (11:40 -0800)] 
cp: fix comment typo

3 years agodoc: NEWS: explain _why_ copy_file_range() is used
Pádraig Brady [Fri, 28 Jan 2022 15:13:25 +0000 (15:13 +0000)] 
doc: NEWS: explain _why_ copy_file_range() is used

* NEWS: Mention why we're making the change in behavior in cat(1).

3 years agobuild: update gnulib submodule to latest
Pádraig Brady [Fri, 28 Jan 2022 15:07:14 +0000 (15:07 +0000)] 
build: update gnulib submodule to latest

To fix a syntax-check false failure

3 years agodd: synchronize output after write errors
Paul Eggert [Fri, 28 Jan 2022 08:01:07 +0000 (00:01 -0800)] 
dd: synchronize output after write errors

Problem reported by Sworddragon (Bug#51345).
* src/dd.c (cleanup): Synchronize output unless dd has been interrupted.
(synchronize_output): New function, split out from dd_copy.
Update conversions_mask so synchronization is done at most once.
(main): Do not die with the output file open, since we want to be
able to synchronize it before exiting.  Synchronize output before
exiting.

3 years agodd: output final progress before syncing
Paul Eggert [Fri, 28 Jan 2022 02:34:09 +0000 (18:34 -0800)] 
dd: output final progress before syncing

Problem reported by Sworddragon (Bug#51482).
* src/dd.c (reported_w_bytes): New var.
(print_xfer_stats): Set it.
(dd_copy): Print a final progress report if useful before
synchronizing output data.

3 years agocat: prefer copy_file_range to read+write
Paul Eggert [Thu, 27 Jan 2022 21:00:41 +0000 (13:00 -0800)] 
cat: prefer copy_file_range to read+write

* src/cat.c (copy_cat): New function.
(main): Use it.

3 years agocsplit: improve integer overflow checking
Paul Eggert [Thu, 27 Jan 2022 20:06:21 +0000 (12:06 -0800)] 
csplit: improve integer overflow checking

* src/csplit.c: Prefer signed integers to unsigned for sizes
when either will do.  Check for some unlikely overflows.
(INCR_SIZE): Remove; no longer used.
(free_buffer): Also free the arg, simplifying callers.
(get_new_buffer): Use xpalloc instead of computing new
size by hand.  Add ATTRIBUTE_DEALLOC.
(delete_all_files, close_output_file):
If unlink fails with ENOENT, treat it as success.
(close_output_file): If unlink fails, decrement count anyway.
(parse_repeat_count, parse_patterns): Check for int overflow.
(check_format_conv_type): Use signed format.

3 years agomaint: simplify memory alignment
Paul Eggert [Thu, 27 Jan 2022 20:06:21 +0000 (12:06 -0800)] 
maint: simplify memory alignment

Use the new Gnulib modules alignalloc and xalignalloc
to simplify some memory allocation.
Also, fix some unlikely integer overflow problems.
* bootstrap.conf (gnulib_modules): Add alignalloc, xalignalloc.
* src/cat.c, src/copy.c, src/dd.c, src/shred.c, src/split.c:
Include alignalloc.h.
* src/cat.c (main):
* src/copy.c (copy_reg):
* src/dd.c (alloc_ibuf, alloc_obuf):
* src/shred.c (dopass):
* src/split.c (main):
Use alignalloc/xalignalloc/alignfree instead of doing page
alignment by hand.
* src/cat.c (main):
Check for integer overflow in page size calculations.
* src/dd.c (INPUT_BLOCK_SLOP, OUTPUT_BLOCK_SLOP, MAX_BLOCKSIZE):
(real_ibuf, real_obuf) [lint]:
Remove; no longer needed.
(cleanup) [lint]:
(scanargs): Simplify.
* src/ioblksize.h (io_blksize): Do not allow blocksizes largest
than the largest power of two that fits in idx_t and size_t.
* src/shred.c (PAGE_ALIGN_SLOP, PATTERNBUF_SIZE): Remove.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Mon, 24 Jan 2022 05:11:44 +0000 (21:11 -0800)] 
build: update gnulib submodule to latest

3 years agocopy: remove unnecessary ‘free’
Paul Eggert [Sun, 23 Jan 2022 19:24:35 +0000 (11:24 -0800)] 
copy: remove unnecessary ‘free’

* src/copy.c (copy_reg): Remove a ‘free’ call that does nothing
because its argument is always a null pointer, starting with
2007-11-1608:31:15Z!jim@meyering.net.

3 years agodd: simplify conv=swab code
Paul Eggert [Wed, 19 Jan 2022 18:51:25 +0000 (10:51 -0800)] 
dd: simplify conv=swab code

Simplify byte-swapping, so that the code no longer needs to
allocate a page before the input buffer.
* src/dd.c (SWAB_ALIGN_OFFSET, char_is_saved, saved_char): Remove.
All uses removed.
(INPUT_BLOCK_SLOP): Simplify to just page_size.
(alloc_ibuf, dd_copy): Adjust to new swab_buffer API.
(swab_buffer): New arg SAVED_BYTE, taking the place of the old
global variables.  Do not access BUF[-1].

3 years agodd: improve integer overflow checking
Paul Eggert [Tue, 18 Jan 2022 21:22:02 +0000 (13:22 -0800)] 
dd: improve integer overflow checking

* src/dd.c: Prefer signed to unsigned types where either will do,
as this helps improve checking with gcc -fsanitize=undefined.
Limit the signed types to their intended ranges.
(MAX_BLOCKSIZE): Don’t exceed IDX_MAX - slop either.
(input_offset_overflow): Remove; overflow now denoted by negative.
(parse_integer): Return INTMAX_MAX on overflow, instead of unspecified.
Do not falsely report overflow for ‘00x99999999999999999999999999999’.
* tests/dd/misc.sh: New test for 00xBIG.
* tests/dd/skip-seek-past-file.sh: Adjust to new diagnostic wording.
New test for BIGxBIG.

3 years agoshred: fix declaration typo
Paul Eggert [Mon, 17 Jan 2022 03:56:17 +0000 (19:56 -0800)] 
shred: fix declaration typo

* gl/lib/randint.h (randint_all_new):
Do not declare with _GL_ATTRIBUTE_NONNULL (), as
the arg can be a null pointer.  This fixes a typo added in
2021-11-01T05:30:28Z!eggert@cs.ucla.edu.

3 years agocat: prefer signed to unsigned
Paul Eggert [Sun, 16 Jan 2022 20:34:25 +0000 (12:34 -0800)] 
cat: prefer signed to unsigned

* src/cat.c: Prefer signed to unsigned types
where either will do, as they allow for better
overflow checking at runtime.

3 years agocat: improve style
Paul Eggert [Sun, 16 Jan 2022 20:08:04 +0000 (12:08 -0800)] 
cat: improve style

* cat.c: Improve style a bit, mostly by assuming C99-style
declarations after statements

3 years agodoc: csplit: clarify [OFFSET] syntax
Pádraig Brady [Thu, 27 Jan 2022 13:05:39 +0000 (13:05 +0000)] 
doc: csplit: clarify [OFFSET] syntax

* src/csplit.c (usage): Clarify that '+' prefix is optional on OFFSET.
* doc/coreutils.texi (csplit invocation): Likewise.
Fixes https://bugs.gnu.org/53574

3 years agobuild: allow readlinkat calls
Paul Eggert [Sat, 15 Jan 2022 20:12:21 +0000 (12:12 -0800)] 
build: allow readlinkat calls

Problem reported by Bernhard Voelker in:
https://lists.gnu.org/r/coreutils/2022-01/msg00026.html
* cfg.mk (sc_prohibit_readlink): Remove.  It’s OK to call
readlinkat to determine whether a file is a symbolic link.

3 years agocp: rely on Gnulib for copy_file_range workaround
Paul Eggert [Sat, 15 Jan 2022 01:43:52 +0000 (17:43 -0800)] 
cp: rely on Gnulib for copy_file_range workaround

Gnulib now replaces copy_file_range on buggy hosts
so there is no need for Coreutils to worry about the bug.
* src/copy.c: Do not include sys/utsname.h, xstrtol.h.
(functional_copy_file_range): Remove.  All uses now
simply call copy_file_range.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Sat, 15 Jan 2022 01:34:33 +0000 (17:34 -0800)] 
build: update gnulib submodule to latest

3 years agodoc: fix pluralization typo
Paul Eggert [Fri, 14 Jan 2022 23:47:26 +0000 (15:47 -0800)] 
doc: fix pluralization typo

3 years agocp: fix two typos in previous change
Paul Eggert [Fri, 14 Jan 2022 23:17:17 +0000 (15:17 -0800)] 
cp: fix two typos in previous change

Somehow ‘make check’ didn’t catch these the first few times.
* src/copy.c (copy_dir): Don’t pass null pointer to
copy_internal where it now expects non-null if move mode.
* src/cp.c (make_dir_parents_private): Initialize *attr_list
before recentely-added quick return.

3 years agocp: omit unnecessary stat of destination
Paul Eggert [Fri, 14 Jan 2022 16:51:13 +0000 (08:51 -0800)] 
cp: omit unnecessary stat of destination

'cp A B' attempts to open B as a directory, to see whether to
write to B/A instead of to B.  In the common case where the
open fails with ENOENT, do not bother to stat B afterwards
since the stat should also fail with ENOENT.
* src/copy.c (copy_internal, copy): Change bool arg about
nonexistent destination to a 3-way int argument.  All callers changed.
(copy_internal): Do not bother to stat a destination already known
to not exist when following symlinks.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Thu, 13 Jan 2022 19:39:15 +0000 (11:39 -0800)] 
build: update gnulib submodule to latest

3 years agocp: when copying to dir use dir-relative names
Paul Eggert [Wed, 12 Jan 2022 18:57:32 +0000 (10:57 -0800)] 
cp: when copying to dir use dir-relative names

When copying to a directory, use functions like openat to access
the destination files, when such functions are available.  This
should be more efficient and should avoid some race conditions.
* bootstrap.conf (gnulib_modules): Add areadlinkat-with-size,
fchmodat, fchownat, mkdirat, mkfifoat, utimensat.
* src/copy.c (lchown) [!HAVE_LCHOWN]:
* src/copy.c, src/system.h (rpl_mkfifo, mkfifo) [!HAVE_MKFIFO]:
Remove.  All uses removed.
(utimens_symlink): Remove; we shouldn’t have to worry about
those obsolete systems any more.  All uses replaced by utimensat.
* src/copy.c (copy_dir, set_owner, fchmod_or_lchmod, copy_reg)
(same_file_ok, writable_destination, overwrite_ok, abandon_move)
(create_hard_link, src_is_dst_backup, copy_internal, copy):
* src/cp.c (make_dir_parents_private, re_protect):
New args for directory-relative names.  All uses changed.
Continue to pass full names as needed, for diagnostics and for
lower-level functions like qset_acl that do not support
directory-relative names.
* src/copy.c (copy_reg): Prefer readlinkat to lstatat for merely
checking whether a file is a symlink, to avoid EOVERFLOW issues.
(subst_suffix): New function.
(create_hard_link): Accept a null SRC_NAME as meaning that if it
is needed it needs to be constructed from SRC_RELNAME, DST_NAME,
and DST_RELNAME.
(source_is_dst_backup): Use subst_suffix instead of doing it by hand.
(copy_internal): Remember and use directory-relative names instead
of full names.
* src/cp.c (lchown) [!HAVE_LCHOWN]: Remove.  All uses removed.
(must_be_working_directory): New function.
(target_directory_operand): Simply take file name as arg,
and return a file descriptor or negative number on failure;
open with O_DIRECTORY to obtain any file descriptor.
All uses changed.
(target_dirfd_valid): New function.
(do_copy): Use these new functions to obtain a file descriptor
for any target directory, and use directory-relative names
for that directory.
(main): Omit no-longer-needed stat when --target-directory,
as do_copy now does this.
* src/ln.c (O_PATHSEARCH): Move from here ...
* src/system.h: ... to here.
* tests/cp/fail-perm.sh: Adjust to change in diagnostic wording,
and add a test for --no-target-directory.

3 years agocp: tweak internal name
Paul Eggert [Wed, 12 Jan 2022 21:52:23 +0000 (13:52 -0800)] 
cp: tweak internal name

* src/cp.c (do_copy): Omit confusingly-named local new_dest, since
there’s another var new_dst that means something quite different.

3 years agoscripts: fix typo in commit-msg git-hook script
Daniel Knittl-Frank [Wed, 12 Jan 2022 18:30:21 +0000 (19:30 +0100)] 
scripts: fix typo in commit-msg git-hook script

Commit 2f438fa9f53250fb3c8b39a95eedd627b5569ca4 (basenc: A new program
complementary to base64/base32) introduced a typo in the list of allowed
commit message prefixes, accidentally changing "basename" to
"nbasename".  Revert it back to the correct "basename".

3 years agodf: tiny simplification
Paul Eggert [Wed, 5 Jan 2022 22:35:31 +0000 (14:35 -0800)] 
df: tiny simplification

* src/df.c (LOG_EQ): Remove.  All callers replaced by ==.

3 years agomaint: update all copyright year number ranges
Pádraig Brady [Sun, 2 Jan 2022 15:42:45 +0000 (15:42 +0000)] 
maint: update all copyright year number ranges

Run "make update-copyright" and then...

* gnulib: Update to latest with copyright year adjusted.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.

3 years agobuild: update gnulib submodule to latest
Pádraig Brady [Sun, 2 Jan 2022 15:28:34 +0000 (15:28 +0000)] 
build: update gnulib submodule to latest

mainly to get updated copyright year

* doc/fdl.texi: Sync from gnulib.
* .gitignore: Add lib/unictype, as bitmap.h therein is depended on
since gnulib commit f698ea71

3 years agodate: new option --resolution
Paul Eggert [Fri, 31 Dec 2021 08:45:03 +0000 (00:45 -0800)] 
date: new option --resolution

* NEWS, doc/coreutils.texi (Options for date): Mention this.
* src/date.c (RESOLUTION_OPTION): New constant.
(DEBUG_DATE_PARSING_OPTION): Rename from DEBUG_DATE_PARSING.
All uses changed.
(long_options, usage, main): Support --resolution.

3 years agodate: %-N now means suppress extra digits
Paul Eggert [Fri, 31 Dec 2021 08:45:03 +0000 (00:45 -0800)] 
date: %-N now means suppress extra digits

* NEWS, doc/coreutils.texi: Mention this.
* bootstrap.conf (gnulib_modules): Add gettime-res.
* src/date.c (res_width, adjust_resolution): New functions.
(main): Adjust %-N to be %9N, or whatever, before using it.

3 years agobuild: update gnulib submodule to latest
Paul Eggert [Fri, 31 Dec 2021 08:45:03 +0000 (00:45 -0800)] 
build: update gnulib submodule to latest

3 years agodoc: Document , vs . in date --rfc-3339=ns
Paul Eggert [Fri, 31 Dec 2021 08:45:03 +0000 (00:45 -0800)] 
doc: Document , vs . in date --rfc-3339=ns