[466-kea-admin-lease-options-to-be-renamed-to-db] Checkpoint: kea-admin lease-{^dump} -> db-* (src)

[575-cb-cmds-unknown-fields-in-arguments-should-raise-an-error] Added ChangeLog entry for new keyword checks

[575-cb-cmds-unknown-fields-in-arguments-should-raise-an-error] Fixed rebase errors

[575-cb-cmds-unknown-fields-in-arguments-should-raise-an-error] Moved parameters and defaults to simple_parser[46] files

[575-cb-cmds-unknown-fields-in-arguments-should-raise-an-error] Added metadata and fixed server tests

[575-cb-cmds-unknown-fields-in-arguments-should-raise-an-error] Added keyword checks for option def, data, subnet, shared network, (pd)pools

[master] Fixed tabulator in ChangeLog entry for #715.

This is trivial fix. Fixing on my own discretion.

[#715,!411] Added ChangeLog for #715.

[#715,!411] Removed dead code from the mysql_cb_impl.cc

As a result of the review.

[#715] Added support for associating option defs with server tags.

[#714,!409] Added ChangeLog entry.

[#714,!409] Addressed review comments.

Removed unnecessary queries before create/update.

[#714,!409] Corrected a comment in the mysql_cb.

[#714,!409] Only delete dangling global options when server deleted.

[#714,!409] Try to update an option followed by insert.

Previously we'd first fetch the option to check if it exists, then update
or insert but that would always trigger two queries. Now we're down to
one query if the option already exists.

[#714,!409] Associate global options with the server tags.

[#639,!410] updated ChangeLog

[#639,!410] check for null pointer

[#639,!410] clear cache_ptr_ before unloading library

[419-subnet-prefix-subnet-parameter-ambiguity] Added ChangeLog entry for subnet prefix ambiguity

[419-subnet-prefix-subnet-parameter-ambiguity] Added unit tests and updated docs

[690-bad-ip-length-header-error-misformats-number] Added a cast for uint8_t ip_len output

[704-forensic-log-hook-paths-are-incorrect] Fixed forensic/legal paths

[667-remove-obsolete-compatcheck-dir] Added ChangeLog entry for compatcheck dir removal

[667-remove-obsolete-compatcheck-dir] Removed compatcheck more than obsolete directory

[#709,!407] Minor updates to the server unittests as a result of review.

- Fixed a typo in the toElement test name,
- Added missing whitespace
- Fixed a typo in getByTag test description.

[709-cb_cmds-add-support-for-commands-to-manage-the-servers] Added a toElement method to Server

[709-cb_cmds-add-support-for-commands-to-manage-the-servers] Improved server support

[709-cb_cmds-add-support-for-commands-to-manage-the-servers] Added delServerTag

[550-authentication-key-to-text-method-miss-spelled] Added ChangeLog entry for auth key fixes

[550-authentication-key-to-text-method-miss-spelled] Addressed comments

[550-authentication-key-to-text-method-miss-spelled] AuthKey is binary

[705-wipe_data-sh-and-other-upgrade_-scripts-do-not-set-prefix] Revert "[705-wipe_data-sh-and-other-upgrade_-scripts-do-not-set-prefix] Protected dhcp_test_lib.sh against unset ${prefix} and fixed includers"

This reverts commit 7fe457cb301772093ff7002c9a3be12b25f7d73b.

Reviewer asked this to be reverted as overkilling.

[705-wipe_data-sh-and-other-upgrade_-scripts-do-not-set-prefix] Protected dhcp_test_lib.sh against unset ${prefix} and fixed includers

[705-wipe_data-sh-and-other-upgrade_-scripts-do-not-set-prefix] Added prefix=@prefix@ and put shell bang at the right place

[699-kea-s-v6-server-seems-to-be-missing-some-debug-logging-for-dhcp6_packet_send] Added ChangeLog entry for DHCP6_PACKET_SEND

[699-kea-s-v6-server-seems-to-be-missing-some-debug-logging-for-dhcp6_packet_send] Addressed comment

[699-kea-s-v6-server-seems-to-be-missing-some-debug-logging-for-dhcp6_packet_send] Added DHCP6_PACKET_SEND

[#686,!403] Updated ChangeLog

[#686,!403] Addressed review comments

     Fixed cosmetics. Spacing etc...

[686-is-it-necessary-to-run-the-sanity-checker-during-lfc-as-well-as-when-starting-kea] splling * cosmetic

[#686,!403] LFC now sees sanity checking as disabled

Add CfgConsistency defaults to application level parsing

src/lib/dhcpsrv/cfg_consistency.h
    Changed constructor default mode to LEASE_CHECK_NONE

src/lib/dhcpsrv/lease_file_loader.h
    LeaseFileLoader::load() - modified to create and use a
    sanity_checker only if checking is enabled.  This avoids
    senselessly making the same decisions for every lease loaded.

src/lib/dhcpsrv/parsers/simple_parser4.*
src/lib/dhcpsrv/parsers/simple_parser6.*
    Added sanity checks defaults so they can be properly set at
    the application level.

src/lib/dhcpsrv/sanity_checker.h
    SanityChecker::leaseCheckingEnabled() - new static function
    to test if sanity checking for leases is enabled

src/lib/dhcpsrv/tests/sanity_checks_unittest.cc
src/lib/dhcpsrv/tests/srv_config_unittest.cc
    updated tests for new constructor default value

[676-add-support-for-server-tags-in-the-cb_cmds-hooks-library] Better fixes...

[676-add-support-for-server-tags-in-the-cb_cmds-hooks-library] Addressed comments

[676-add-support-for-server-tags-in-the-cb_cmds-hooks-library] spelling

[#676] Modified internal representation of the tags in ServerSelector.

[#651,!384] Updated ChangeLog entry

[#651,!384] Fixed unit test

[#651,!384] Updated ChangeLog entry

[#651,!384] Added ChangeLog entry

[#651,!384] Fix input IAID in postgresql lease6 fetchers

src/lib/dhcpsrv/pgsql_lease_mgr.cc
    PgSqlLease6Exchange::Uiaid - made this public and added function to
    return the int32 bit value as a string

    PgSqlLeaseMgr::getLeases6() - uses Uiaid.dbInputString() now

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
    GenericLeaseMgrTest::testLease6LargeIaidCheck() - new test to
    ensure large value iaids can be stored.

src/lib/dhcpsrv/tests/pgsql_lease_mgr_unittest.cc
    TEST_F(PgSqlLeaseMgrTest, leases6LargeIaidCheck) - new test

src/lib/dhcpsrv/tests/cql_lease_mgr_unittest.cc
    TEST_F(CqlLeaseMgrTest, lease6InvalidHostname) - new test

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
    TEST_F(MySqlLeaseMgrTest, leases6LargeIaidCheck) - new test

[#642] Added ChangeLog for #642.

[#642,!373] Fixed a typo in the mysql_cb.

[#642,!373] Adjusted exceptions' text in the mysql_cb.

Per review comments.

[#642,!373] Delete global parameters as a result of deleting the servers.

[#642,!373] Do not allow to update the logical server 'all'.

[#642,!373] Addressed review comments.

- Don't allow for deleting logical server 'all'.
- Additional tests to make sure that other servers aren't affected by deletion.
- Added note that getAll() doesn't return logical server all.

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Changed new schema to 8.1 (vs 9.0) and addressed trivial comments

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Restored missing space (indent)

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Minor comment fixes in hook header files

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Extra space in indent

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] overriden -> overridden (in src, not fixed in doc

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling

[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling

[#642,!373] Explained how globals are fetched for various selectors.

[#642,!373] Added log messages for functions deleting servers.

[#642,!373] Server tags supported for global params in MySQL CB.

[#642,!373] Extended StampedElement to hold multiple server tags.

[#642,!373] Check that it is possible to delete global param for server tag

[#642,!373] Global parameters may be associated with server tags.

[#642,!373] Updated MySQL Config Backend with simple server mgmt functions.

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Added ChangeLog entry fro better messages on config from CB failure

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Addressed comment

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Split commit block to add CB indication in log/error messages

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Improved messages (but still not found the bug)

[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Removed unused DCTL_CCSESSION_STARTING

Update .gitlab/issue_templates/bug_report.md

[#691,!395] Updated ChangeLog

[#691,!395] More review comments

src/hooks/dhcp/high_availability/ha_messages.mes
    Removed HA_SERVICE_CONNECT_INVALID_SOCKET message

src/hooks/dhcp/high_availability/ha_service.cc
    HAService::clientConnectHandler() - now just avoids registering
    an invalid FD with no log and return(true)

src/lib/http/client.cc
    Added commen in Connection::close()

src/lib/http/tests/server_client_unittests.cc
    Removed invalid FD failure in test

[#691,!395] Fixed a typo in the server_client_unittest.cc for HTTP.

[#691,!395] Removed spurious dot from the test comment.

[#691,!395] Fixed a typo in the IfaceMgr header.

[#691,!395] Fixed a typo in the http client header.

[#691,!395] Removed debug leftovers from ha service.

[#691,!395] Updated copyright date in src/config/timeouts.h.

[#691,!395] Review comments 4

src/lib/http/tests/server_client_unittests.cc
    TEST_F(HttpClientTest, connectCloseCallbacks) - test now
    verifies callback invocations

[#691,!395] Review comments 3

    IfaceMgr and unit tests clean up.

[#691,!395] Review comments 2

src/hooks/dhcp/high_availability/ha_messages.mes
    HA_SERVICE_CONNECT_INVALID_SOCKET - new message

src/hooks/dhcp/high_availability/ha_service.cc
 HAService::clientConnectHandler() - added negative fd logic

src/lib/http/client.cc
    Connection::closeCallback() - new method that wraps invocation
    of close callback in try-catch.

src/lib/http/http_messages.mes
    HTTP_CONNECTION_CLOSE_CALLBACK_FAILED - new message

[#691,!395] Addressed review comments 1

    Added TIMEOUT_DEFAULT_HTTP_CLIENT_REQUEST
    Removed virtual from callback declarations
    Added commentary to http/client.h

Apply suggestion to ChangeLog

[#691,!395] Added ChangeLog entry

[#691,!395] Added bad socket purge to IfaceMgr

src/lib/dhcp/iface_mgr.cc
    IfaceMgr::purgeBadSockets() - new function to validate
    external sockets and unregister any that are invalid.

    IfaceMgr::receive4Indirect()
    IfaceMgr::receive4Direct()
    IfaceMgr::receive6Indirect()
    IfaceMgr::receive6Direct() - added logic to all
    purgeBadSockets() when select fails with EBADF

src/lib/dhcp/tests/iface_mgr_unittest.cc
    TEST_F(IfaceMgrTest, purgeExternalSockets4)
    TEST_F(IfaceMgrTest, purgeExternalSockets6) -  new tests
    to verify bad socket purging

src/lib/http/client.cc
    Move close_callback_ reset back to Connection::close()

[#691,!395] HAService now registers HTTP client sockets with InterfaceMgr

src/hooks/dhcp/high_availability/ha_service.cc

    HAService
        clientConnectHandler() - new client connection connect callback
        clientCloseHandler() - new client connection close callback

        asyncSendLeaseUpdate()
        asyncSendHeartbeat()
        asyncDisableDHCPService()
        asyncEnableDHCPService()
        asyncSyncLeasesInternal() - added new call backs to
        HttpClient::asyncSendRequest() invocation

src/lib/http/client.cc
    Connection::resetState() - added reset of close callback

[#691,!395] Add Connection socket exposure and close_callback handler

Addes close_callback and exposes Connectin's TCP socket to it
and connect_callback.

src/lib/http/client.h b/src/lib/http/client.h
    HttpClient:
        Added second parameter, socket FD, to ConnectHandler
        Added CloseHandler typedef

        asyncSendRequest() - added close_callback parameter

src/lib/http/client.cc
    Connection - added close_callback parameter to all
    methods that accept connect_callback parameter

    Added invocation of close_callback wherever the connection's
    socket is closed.

src/lib/http/tests/server_client_unittests.cc
    TEST_F(HttpClientTest, connectCloseCallbacks) - new test that
    verifies connect and close callback operations

hammer: fixed handling repos over https

[621-pd-pool-fields-are-not-described-in-kea6-all-keys-current-json] Addressed comment

[621-pd-pool-fields-are-not-described-in-kea6-all-keys-current-json] Added description of pd-pool current all keys example

[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Added ChangeLog entry for sanity-checker logs

[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Improved SanityChecker logs