Fix `lxc-create` completion.

Do not append a name of an existing container.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add support for comma as a completion word.

For `lxc-ls --groups` and `lxc-autostart --groups`.
Support leading comma, trailing comma, embedded double comma.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Refactor `__lxc_piped_args`.

Use bash functions for common array operations. Keep code logic somewhat
easy to read for bug hunting.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Fix `lxc-snapshot` completion.

For options `-r,--restore` and `-d,--destroy`, we need the container
name to create the list of completion values.

Therefore, it is needed to scan the current command line to check if
there is a container name available.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Use more bash-like syntax.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add support for container composed names.

When a container name has whitespace in it
(e.g. created by `lxc-create -t download -n "arch linux"` ),
the completion for other commands should be able to work by adding a
backslash to escape it.

Although it may be interesting to support names between quotes, this
would probably means to have to add quotes to all names. Might not be
interesting just due to an edge case.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add completion output for `lxc-ls --fancy-format`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Improve name completion handling.

Use regex to handle short option `-n`, since short options can be
combined (e.g. `-nd`) as long as at max one requires an argument.

Also consider the case when the arg for the long option is not given
together with `--name=`.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Add `compopt` call to `__lxc_piped_args`.

On pair with how other functions do it. Also, be smarter about adding
whitespace when there are no more completions available for the
parameter.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Use `--running` instead of `--active`.

Commands block if container is frozen.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

Fill missing commands on name completion.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>

build: add tools to meson

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add meson skeleton

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: make sure _GNU_SOURCE is set

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc: remove "version.h" inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tests: include "version.h"

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix config.h inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: fix build warnings

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix lxc header inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

caps: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools/lxc_start: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

arguments: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

initutils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

log: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

initutils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

string_utils: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

arguments: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

file_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

monitor: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

nl: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

uuid: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

seccomp: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxcmntent: fix fallthrough

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

netns_ifaddrs: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

terminal: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix public lxc header inclusions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

criu: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix attach header inclusion

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix array initalization

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix struct mount_attr initalization

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

string_utils: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lsm: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: fix helper declarations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: fix integer comparisons

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

syscall_wrapper: fix pivot_root() declaration

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

build: add src/include to build and simplify header inclusions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix build

Fixes: #3960
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

include: make all functions __hidden

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

configure: add sanitizer flags to LDFLAGS as well

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: don't pass NULL pointer

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: fail when container can't be loaded

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: remove useless {}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: use free_disarm() in list_all_containers()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-usernsexec: small tweaks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: fix list_entry()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: Fix -c command

Currently, the -c command (to set the selinux context) seems to be
broken because the passed context is ignored and always overwritten by
the context specified in the config file. The intention behind the -c
imho was to be able to manually overwrite this behavior. This patch
ensures that the selinux context will be set if passed via the command
line.

Signed-off-by: Maximilian Blenk <Maximilian.Blenk@bmw.de>

lxccontainer: tweak some array handling helpers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: improve add_to_clist()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: improve add_to_array()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port groups to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port hooks to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port apparmor to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port mounts to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: fix bpf device list

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: port ipv6 routes to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: port ipv4 routes to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: fix cgroup settings sorting

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: align initialization

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: s/ipv{4,6}_list/ipv{4,6}_addresses/g

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: port ipv6 addresses to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: port ipv4 to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: simplify and port caps to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroup: remove unneeded forward declaration

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

terminal: remove unused struct member

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port environment to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: remove unused variables

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: switch to parse_mount_attrs() even for legacy mount()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: support recursive propagation options properly

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: rework recursive mount option handling

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rootfs: remove "options" member

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: remove unused mountflags nember

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port id_map to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port cgroup settings to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port procs to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port sysctls to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port rlimits to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: port state_clients to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

mainloop: port handlers to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: port bpf devices to new list type

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>