]>
git.ipfire.org Git - thirdparty/freeswitch.git/log
Chris Rienzo [Mon, 24 Nov 2014 17:11:12 +0000 (12:11 -0500)]
FS-7031 [unimrcp] update sofia-sip.m4 so that it can build when relative path is used in configure.gnu --with-sofia-sip
Chris Rienzo [Mon, 24 Nov 2014 15:38:11 +0000 (10:38 -0500)]
FS-7031 [unimrcp] revert configure.gnu change- doesn't work when using non-source build dir.
Anthony Minessale [Mon, 24 Nov 2014 22:32:38 +0000 (16:32 -0600)]
missing deb
Brian West [Thu, 20 Nov 2014 03:51:09 +0000 (21:51 -0600)]
FS-7021 #resolve
Ken Rice [Wed, 19 Nov 2014 22:05:40 +0000 (16:05 -0600)]
FS-6848 #resolve #comment slight tweak to fix the logic and avoid unbalanced parens
Mike Jerris [Wed, 19 Nov 2014 21:32:19 +0000 (15:32 -0600)]
Merge pull request #95 in FS/freeswitch from ~ITALOROSSI/freeswitch:master to master
* commit '
f87c335e8a49da7b0a2b6f19b45f285f6355e2e0 ':
Only waiting for agent channel to hangup.
Mike Jerris [Wed, 19 Nov 2014 21:30:50 +0000 (15:30 -0600)]
Merge pull request #117 in FS/freeswitch from ~UNIXDOG/freeswitch-rneese:bugfix/FS-6848-freesbd10.1-arm-build-failure to master
* commit '
9673cf0acbd7591ce64b46385391dd7feac4c036 ':
Fix for apr build issue fs-6848 freebsd arm
Michael Jerris [Wed, 19 Nov 2014 21:06:42 +0000 (16:06 -0500)]
remove hack breaking some cross compile builds. if you really need this, you should be using new enough glibc anyways
Richard Neese [Wed, 19 Nov 2014 20:00:12 +0000 (14:00 -0600)]
Fix for apr build issue fs-6848 freebsd arm
Anthony Minessale [Fri, 14 Nov 2014 02:51:53 +0000 (20:51 -0600)]
improve timerfd implementation to be more accurate
Anthony Minessale [Tue, 18 Nov 2014 23:00:44 +0000 (17:00 -0600)]
revert
Anthony Minessale [Fri, 14 Nov 2014 02:51:53 +0000 (20:51 -0600)]
improve timerfd implementation to be more accurate
Mike Jerris [Tue, 18 Nov 2014 20:45:53 +0000 (14:45 -0600)]
Merge pull request #114 in FS/freeswitch from ~VIPKILLA/freeswitch-fs-6097:master to master
* commit '
1e926198fab716d62956b8c03aca753eb4d6abe7 ':
FS-6097 - added fifo_position macro
E. Schmidbauer [Tue, 18 Nov 2014 20:42:44 +0000 (15:42 -0500)]
FS-6097 - added fifo_position macro
Chris Rienzo [Tue, 18 Nov 2014 19:28:38 +0000 (14:28 -0500)]
Merge branch 'unimrcp-update-
20141117 '
Chris Rienzo [Mon, 17 Nov 2014 16:37:15 +0000 (11:37 -0500)]
FS-6450 [unimrcp] Update library
[apr] Backport APR_RING_FOREACH and APR_RING_FOREACH_SAFE macros to APR for unimrcp compatibility.
[unimrcp] configure.gnu - need full path, not relative path for library paths
[unimrcp] added uni_revision.h - couldn't get it to autogenerate from build
[mod_unimrcp] add better logging and error checking on module load. Currently dumps core on MRCPv1 TTS attempt
[mod_unimrcp] don't configure MRCPv1 session with a connection agent- causes crash
Brian West [Tue, 18 Nov 2014 16:22:13 +0000 (10:22 -0600)]
FS-7014: [mod_sofia] don't touch the tech_pvt when a call has just ended, leaving us with a null tech_pvt
Brian West [Tue, 18 Nov 2014 15:47:43 +0000 (09:47 -0600)]
FS-6622: [mod_shout] set buffer size for streams based on the number of channels to avoid buffer starvation
Michael Jerris [Mon, 17 Nov 2014 20:25:39 +0000 (15:25 -0500)]
FS-6695: fix build on mips
Brian West [Mon, 17 Nov 2014 16:36:03 +0000 (10:36 -0600)]
FS-6957 fix regression
Michael Jerris [Mon, 17 Nov 2014 16:01:35 +0000 (11:01 -0500)]
FS-5800: [mod_curl] add support for additional curl auth methods
Michael Jerris [Mon, 17 Nov 2014 15:29:39 +0000 (10:29 -0500)]
FS-5666: [mod_redis] add ignore_connect_fail config setting to not kill the call when redis is down when using redis backend for limit
Chris Rienzo [Mon, 17 Nov 2014 14:46:23 +0000 (09:46 -0500)]
iksemel - remove support for SSLv23 in iks_proceed_tls (was a FS addition to iksemel). mod_rayo - updated to no longer support SSLv23
Mike Jerris [Mon, 17 Nov 2014 14:29:08 +0000 (08:29 -0600)]
Merge pull request #113 in FS/freeswitch from ~FLAVIO/freeswitch:bugfix/FS-7004-mod_sndfile_respect_umask to master
* commit '
c73afe1c85f42d076c4b71c80251f7c888d47756 ':
FS-7004 mod_sndfile: respect umask when creating new files
Michael Jerris [Mon, 17 Nov 2014 14:27:22 +0000 (09:27 -0500)]
FS-6996: #resolve fix define change as of glibc 2.20 for _BSD_SOURCE -> _DEFAULT_SOURCE
Flavio Grossi [Mon, 17 Nov 2014 10:11:42 +0000 (11:11 +0100)]
FS-7004 mod_sndfile: respect umask when creating new files
Files created by mod_sndfile use sf_open() which uses hardcoded permissions. To
respect the process' umask, manually open files with the correct permissions
and then call sf_open_fd().
Travis Cross [Sun, 16 Nov 2014 19:20:07 +0000 (19:20 +0000)]
Allow setting CURL timeout from curl API command
Previously the `timeout` option to the curl API command set only
`CURLOPT_CONNECTTIMEOUT` -- the maximum amount of time that curl will
wait to connect to the server. If the server accepted the connection
but then never replied, curl would wait essentially forever. There
was no way to set `CURLOPT_TIMEOUT` -- the maximum amount of time the
entire request operation is allowed to take.
With this change, the `timeout` option sets `CURLOPT_TIMEOUT`. We've
earlier added a `connect-timeout` option to set
`CURLOPT_CONNECTTIMEOUT`.
This is a change to existing behavior. However, it's likely that this
is what people expected it to do all along. The curl application
call, for example, accepts both `curl_connect_timeout` and
`curl_timeout` channel variables, with the latter setting
`CURLOPT_TIMEOUT`.
If people really were relying on this odd behavior, we'll rename the
option with the new behavior to something else and come up with a
transition plan.
Travis Cross [Sun, 16 Nov 2014 19:16:39 +0000 (19:16 +0000)]
Add `connect-timeout` option for curl API command
This option sets the maximum number of seconds that curl will wait to
connect with the server.
Right now this is a synonym for the `timeout` option.
Chris Rienzo [Fri, 14 Nov 2014 19:20:48 +0000 (14:20 -0500)]
FS-7003 #resolve #comment mod_rayo: fix infinite loop when output sent to server without SSML configured and repeat-times=0
Chris Rienzo [Fri, 14 Nov 2014 18:22:53 +0000 (13:22 -0500)]
mod_rayo: new configuration parameter, add-variables-to-offer (default=false). When true, all channel variables are included in the offer to rayo client
Brian West [Fri, 14 Nov 2014 14:37:23 +0000 (08:37 -0600)]
Merge pull request #111 in FS/freeswitch from ~JCHAVANTON/freeswitch-opus:FS-6992 to master
* commit '
826d42874139c59636de234d7021d485f03b81ee ':
FS-6992 [mod_opus] global configuration or maxplaybackrate and maxaveragebitrate from opus.conf.xml
Julien Chavanton [Thu, 13 Nov 2014 12:48:04 +0000 (13:48 +0100)]
FS-6992 [mod_opus] global configuration or maxplaybackrate and maxaveragebitrate
from opus.conf.xml
Chris Rienzo [Thu, 13 Nov 2014 15:20:02 +0000 (10:20 -0500)]
FS-6979 #resolve #comment mod_http_cache: added base-domain config to s3 profiles so mod_http_cache can access self hosted s3 compatible service.
Example configuration:
<profiles>
<profile name="s3">
<!-- Credentials for AWS account. -->
<aws-s3>
<!-- 20 character key identifier -->
<access-key-id><![CDATA[AKIAIOSFODNN7EXAMPLE]]></access-key-id>
<!-- 40 character secret -->
<secret-access-key><![CDATA[wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY]]></secret-access-key>
<base-domain><![CDATA[example.com]]></base-domain>
</aws-s3>
<!-- Domains that this profile applies to -->
<domains>
<domain name="bucket.example.com"/>
<domain name="bucket2.example.com"/>
</domains>
</profile>
</profiles>
Michael Jerris [Thu, 13 Nov 2014 03:55:31 +0000 (21:55 -0600)]
FS-6531: #resolve set to tag on uuid_phone_event notify to make grandstream happy, even tho they could have matched the dialog fine off the from tag like every other phone does.
Michael Jerris [Thu, 13 Nov 2014 03:37:14 +0000 (21:37 -0600)]
FS-6531: #resolve set to tag on auto answer notify to make grandstream happy, even tho they could have matched the dialog fine off the from tag like every other phone does.
Anthony Minessale [Wed, 12 Nov 2014 19:09:23 +0000 (13:09 -0600)]
FS-6890 #comment please test
Anthony Minessale [Wed, 12 Nov 2014 19:07:43 +0000 (13:07 -0600)]
FS-6890 #comment revert
Travis Cross [Thu, 30 Oct 2014 01:24:09 +0000 (01:24 +0000)]
Avoid mod_shout on sid/jessie for now
On sid the build breaks on "undefined reference to symbol
'ogg_sync_init'". We'll just avoid mod_shout on sid/jessie until this
is worked out.
Brian West [Wed, 12 Nov 2014 18:57:31 +0000 (12:57 -0600)]
Merge pull request #110 in FS/freeswitch from ~JCHAVANTON/freeswitch-opus:FS-6947-opus to master
* commit '
0eefdca47b127f8151c9b1a0b12eaf2d7e99def8 ':
FS-6947 Opus RTP payload fmtp settings ( maxaveragebitrate / maxplaybackrate )
Brian West [Wed, 12 Nov 2014 18:49:57 +0000 (12:49 -0600)]
fix a few issues
Julien Chavanton [Wed, 12 Nov 2014 08:06:11 +0000 (09:06 +0100)]
FS-6947 Opus RTP payload fmtp settings ( maxaveragebitrate / maxplaybackrate )
Seven Du [Wed, 12 Nov 2014 05:31:30 +0000 (13:31 +0800)]
fix compiler warning on unmatched return type
Seven Du [Wed, 12 Nov 2014 00:39:35 +0000 (08:39 +0800)]
add external_video_source to media handle and expose switch_core_media_start_video_thread() to start the core video thread for non-rtp based media
Brian West [Wed, 12 Nov 2014 00:18:27 +0000 (18:18 -0600)]
FS-6977 #resolve
Mike Jerris [Wed, 12 Nov 2014 00:16:57 +0000 (18:16 -0600)]
Merge pull request #109 in FS/freeswitch from ~NNEUL/freeswitch:bugfix-fs-6983 to master
* commit '
dbc5571594eeacc4e3c7f2de3c78f8dd5c12f087 ':
FS-6983 wrap new curl TLS macro usage with ifdefs
Mike Jerris [Tue, 11 Nov 2014 22:27:10 +0000 (16:27 -0600)]
Merge pull request #105 in FS/freeswitch from ~SEVEN/freeswitch-verto-spaces-new:master to master
* commit '
eb3a27ccee10f72df4bc237d5254a5c8636f3205 ':
use 4 spaces indent to match the default of jslint
Nathan Neulinger [Tue, 11 Nov 2014 22:26:44 +0000 (16:26 -0600)]
FS-6983 wrap new curl TLS macro usage with ifdefs
Mike Jerris [Tue, 11 Nov 2014 21:19:21 +0000 (15:19 -0600)]
Merge pull request #108 in FS/freeswitch from ~NNEUL/freeswitch:feature-dialplan-tstamps to master
* commit '
f175c7118879b882343da9b6f15075161923fcca ':
FS-6805 add support for logging full timestamps with dialplan, defaults to old behavior unless requested
Anthony Minessale [Tue, 11 Nov 2014 20:51:19 +0000 (14:51 -0600)]
PLIV-13 #resolve
Anthony Minessale [Tue, 11 Nov 2014 19:37:46 +0000 (13:37 -0600)]
FS-6957 #resolve
Nathan Neulinger [Tue, 11 Nov 2014 19:25:47 +0000 (13:25 -0600)]
FS-6805 add support for logging full timestamps with dialplan, defaults to old behavior unless requested
Anthony Minessale [Tue, 11 Nov 2014 18:56:40 +0000 (12:56 -0600)]
FS-6890 #comment please test
Seven Du [Tue, 11 Nov 2014 15:33:03 +0000 (23:33 +0800)]
use 4 spaces indent to match the default of jslint
this is the first step of making the code follow the default jslint behaviour,
I also manually changed some { } to make it reasonable in addition to replacing tabs
Nathan Neulinger [Tue, 11 Nov 2014 15:11:44 +0000 (09:11 -0600)]
reduce logging when level is below 9 for less important messages
Nathan Neulinger [Tue, 11 Nov 2014 14:41:16 +0000 (08:41 -0600)]
FS-5533 fix issue with busy signal being sent back to all shared lines instead of just the calling device
Brian West [Tue, 11 Nov 2014 13:45:50 +0000 (07:45 -0600)]
FS-6980 #resolve don't crash when using native recording on recordstop
Michael Jerris [Mon, 10 Nov 2014 16:12:56 +0000 (11:12 -0500)]
fix mod_say_es_ar Makefile.am
Michael Jerris [Mon, 10 Nov 2014 16:12:15 +0000 (11:12 -0500)]
Revert "Revert "FS-6967 New mod_say_es_AR to support Argentina Spanish variant.""
This reverts commit
d9d9510ce4783879ea10a06114d5695a637dcd87 .
Moises Silva [Sun, 9 Nov 2014 08:50:07 +0000 (03:50 -0500)]
Merge remote-tracking branch 'moystash/em-suspend-support'
Conflicts:
libs/freetdm/src/include/private/ftdm_core.h
Moises Silva [Sun, 9 Nov 2014 08:41:59 +0000 (00:41 -0800)]
freetdm: Fix release guard timer check
Moises Silva [Sun, 9 Nov 2014 08:33:08 +0000 (03:33 -0500)]
OPENZAP-232 #resolve
Patched-By: Florian Richter
Check for digits received on sangoma isdn stack to avoid delaying
moving to the ring state if all digits are received at once in
overlap dialing mode
Ken Rice [Sat, 8 Nov 2014 21:13:05 +0000 (15:13 -0600)]
Revert "FS-6967 New mod_say_es_AR to support Argentina Spanish variant."
This reverts commit
e75d0675afd8974687931143709814544299fadc .
Revert "Add mod_say_es_ar to debian packaging"
This reverts commit
ebb3c8fbfa3ec8b9f4b4a2ef20d62d343c8ff6c4 .
Conflicts:
configure.ac
Brian West [Fri, 7 Nov 2014 23:41:31 +0000 (17:41 -0600)]
Merge branch 'master' of ssh://stash.freeswitch.org:7999/fs/freeswitch
Brian West [Fri, 7 Nov 2014 23:41:29 +0000 (17:41 -0600)]
FS-6973 revert this line
Anthony Minessale [Fri, 7 Nov 2014 23:11:40 +0000 (17:11 -0600)]
fix regression caused by missing ! char in commit:
4eb5b388
Anthony Minessale [Fri, 7 Nov 2014 23:10:53 +0000 (17:10 -0600)]
add command to comppile non-minified js file for testing
Brian West [Fri, 7 Nov 2014 22:45:35 +0000 (16:45 -0600)]
Merge branch 'master' of ssh://stash.freeswitch.org:7999/fs/freeswitch
Brian West [Fri, 7 Nov 2014 22:45:32 +0000 (16:45 -0600)]
FS-6973 #resolve
Travis Cross [Fri, 7 Nov 2014 18:53:46 +0000 (18:53 +0000)]
Add mod_say_es_ar to debian packaging
Travis Cross [Fri, 7 Nov 2014 18:53:33 +0000 (18:53 +0000)]
Add mod_odbc_cdr to debian packaging
Travis Cross [Fri, 7 Nov 2014 18:52:11 +0000 (18:52 +0000)]
Fix placement of build-dep for libsngtc-dev
Since we compare our generated control-modules to the one in tree, we
want to match the exact format we use to generate the file.
Peter Wu [Wed, 30 Jul 2014 17:20:08 +0000 (19:20 +0200)]
debian: Remove duplicate clean command
`dh clean` invokes `dh_testdir`, `dh_auto_clean` and `dh_clean`. We
don't need to invoke dh_clean twice.
Acked-by: Travis Cross <tc@traviscross.com>
Chris Rienzo [Fri, 7 Nov 2014 18:22:22 +0000 (13:22 -0500)]
RPM packaging - add mongo C driver to list of sources
Travis Cross [Fri, 7 Nov 2014 18:17:46 +0000 (18:17 +0000)]
Fix whitespace inconsistency
Peter Wu [Mon, 15 Sep 2014 18:49:42 +0000 (20:49 +0200)]
debian: Allow use of secondary groups
When '-g' is passed, freeswitch drops all other groups except for the
given group. This impacts people who depend on FS having access to
resources that would be allowed by membership to those other groups.
It was possible to override this by setting DAEMON_ARGS in
/etc/default/freeswitch, but we'll go ahead and make this the default.
Since freeswitch uses the primary group of a user when `-g` is
omitted, we'll just omit it, and do similarly when setting the
ownership of our directory in /var/run.
Edited-by: Travis Cross <tc@traviscross.com>
Anthony Minessale [Fri, 7 Nov 2014 14:37:53 +0000 (08:37 -0600)]
FS-6969 #resolve #comment This patch should accomplish the same and handle other platforms, please test
Mike Jerris [Fri, 7 Nov 2014 14:34:55 +0000 (08:34 -0600)]
Merge pull request #49 in FS/freeswitch from ~VIPKILLA/freeswitch-mod_odbc_cdr:master to master
* commit '
544c5faf5e6ce6fe2b87523304d1f00e2d201d90 ':
Add module mod_odbc_cdr
Mike Jerris [Fri, 7 Nov 2014 14:09:05 +0000 (08:09 -0600)]
Merge pull request #68 in FS/freeswitch from ~HRISTO/freeswitch:interrupt-conf-moh to master
* commit '
94278b5e545b58bad784a95da6181fc5f299457f ':
allow enter and exit sounds to interrupt the MOH in a wait_mod conference
Mike Jerris [Fri, 7 Nov 2014 14:06:54 +0000 (08:06 -0600)]
Merge pull request #102 in FS/freeswitch from ~AMARUS_CAMERON/freeswitch:mod_fifo-outbound_per_cycle_min to master
* commit '
1944f9a5ee63ec51bed1bfb900072d168a81d004 ':
FS-6968 Changes to mod_fifo.c to add outbound_per_cycle_min
Brian West [Fri, 7 Nov 2014 13:26:31 +0000 (07:26 -0600)]
Might needs this for testing.
Brian West [Fri, 7 Nov 2014 00:26:28 +0000 (18:26 -0600)]
Merge branch 'master' of ssh://stash.freeswitch.org:7999/fs/freeswitch
Anthony Minessale [Fri, 7 Nov 2014 00:26:16 +0000 (18:26 -0600)]
FS-6954 #resolve #comment please test
Aaron Paolozzi [Fri, 7 Nov 2014 00:21:58 +0000 (19:21 -0500)]
FS-6968 Changes to mod_fifo.c to add outbound_per_cycle_min
Mike Jerris [Thu, 6 Nov 2014 23:21:08 +0000 (17:21 -0600)]
Merge pull request #50 in FS/freeswitch from ~JMESQUITA/freeswitch:mod_say_es_AR to master
* commit '
e75d0675afd8974687931143709814544299fadc ':
FS-6967 New mod_say_es_AR to support Argentina Spanish variant.
Anthony Minessale [Thu, 6 Nov 2014 23:13:02 +0000 (17:13 -0600)]
FS-6890 #comment please test
Joao Mesquita [Tue, 9 Sep 2014 16:44:50 +0000 (13:44 -0300)]
FS-6967 New mod_say_es_AR to support Argentina Spanish variant.
Chris Rienzo [Thu, 6 Nov 2014 19:54:55 +0000 (14:54 -0500)]
mod_rayo: update config to use spandsp_start_tone_detect and spandsp_stop_tone_detect
Chris Rienzo [Thu, 6 Nov 2014 19:46:56 +0000 (14:46 -0500)]
Renaming mod_spandsp's cadence + tone detection APPs and APIs (start_tone_detect / stop_tone_detect) to
spandsp_start_tone_detect and spandsp_stop_tone_detect to resolve conflict with mod_dptools'
tone_detect/stop_tone_detect APPs.
Hristo Trendev [Wed, 24 Sep 2014 12:25:39 +0000 (14:25 +0200)]
allow enter and exit sounds to interrupt the MOH in a wait_mod conference
This patch does the following:
* only starts MOH if no other file (sync or async) is currently playing
* adds a variable "conference_permanent_wait_mod_moh" that controls the
behavior of how the enter and exit sounds interact with the MOH when
wait_mod is set. When the variable is set, the MOH keeps playing and
the enter and exit sounds are mixed with the MOH. When the variable
is unset, then any playing MOH is first stopped, then the enter or
exit sound is played and the MOH is started again.
This functionality is useful in case the enter and exit sounds are
used to announce the name of the caller, who is joining or leaving a
conference.
FS-5159 #resolve
Mike Jerris [Thu, 6 Nov 2014 17:48:12 +0000 (11:48 -0600)]
Merge pull request #57 in FS/freeswitch from ~LEKENSTEYN/freeswitch:fixes to master
* commit '
8e4423f126b9476123c6fa8c41c5f8ebfe1d0cb5 ':
Document Dbh.test_reactive, return saner values
Mike Jerris [Thu, 6 Nov 2014 17:42:35 +0000 (11:42 -0600)]
Merge pull request #101 in FS/freeswitch from ~RAVENOX/freeswitch:fixes_for_pull_request_#93 to master
* commit '
c97c0e8a7805f15fd52e7400b3a984d981e2524a ':
Fix for case-sensitive filesystems
Fixed code formatting. Return ListDelegate
Travis Cross [Thu, 6 Nov 2014 16:30:44 +0000 (16:30 +0000)]
Improve init error message when FS is unconfigured
Depending on which packages are installed, the README.Debian file
might not be there, so we'll spell out the instructions more directly.
Brian West [Thu, 6 Nov 2014 15:47:54 +0000 (09:47 -0600)]
FS-6965 #resolve
Brian West [Thu, 6 Nov 2014 14:55:03 +0000 (08:55 -0600)]
Adding rfc6598.auto and adding rfc6598 space to nat.auto acl, This is the NAT444 carrier grade nat space
Artur Kraev [Thu, 6 Nov 2014 09:36:02 +0000 (12:36 +0300)]
Fix for case-sensitive filesystems
Artur Kraev [Thu, 6 Nov 2014 09:27:34 +0000 (12:27 +0300)]
Fixed code formatting.
Return ListDelegate
Mike Jerris [Wed, 5 Nov 2014 22:25:40 +0000 (16:25 -0600)]
Merge pull request #69 in FS/freeswitch from ~HRISTO/freeswitch:conference-flags to master
* commit '
3695bdd9e4e0d925ab7296d2f4ce120bf656f623 ':
set conference flags from a dial plan variable or via +flags{ }
Mike Jerris [Wed, 5 Nov 2014 22:05:00 +0000 (16:05 -0600)]
Merge pull request #48 in FS/freeswitch from ~ANTONIO/freeswitch-fs-6809:master to master
* commit '
69d5cda6d67074d6e5c1b7038b4dd7cab0adf60f ':
resolve FS-6809
Anthony Minessale [Wed, 5 Nov 2014 17:51:30 +0000 (11:51 -0600)]
FS-6954 #comment we fixed another bug and this is the side effect which is completely valid, too bad you can never fix broken t38 endpoints. Can you please test this patch
Anthony Minessale [Wed, 5 Nov 2014 17:35:13 +0000 (11:35 -0600)]
FS-6890 #comment please test