]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Karel Zak [Fri, 10 Feb 2012 13:47:59 +0000 (14:47 +0100)]
login: add LOGIN_RETRIES, cleanup retries check code
Signed-off-by: Karel Zak <kzak@redhat.com>
Harald Hoyer [Thu, 9 Feb 2012 13:46:26 +0000 (14:46 +0100)]
setsid: add "+" to getopt_long()
otherwise setsid wants to interpret <program> arguments
$ setsid sh -i
setsid: invalid option -- 'i'
Usage:
setsid [options] <program> [arguments ...]
Signed-off-by: Harald Hoyer <harald@redhat.com>
Sami Kerola [Tue, 7 Feb 2012 22:03:55 +0000 (23:03 +0100)]
tunelp: free allocation, use xalloc
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Tue, 7 Feb 2012 22:01:14 +0000 (23:01 +0100)]
switch_root: close open file after usage [cppcheck]
[sys-utils/switch_root.c:159]: (error) Resource leak: cfd
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:55:56 +0000 (22:55 +0100)]
chcpu: use appropriate variable type [cppcheck]
[sys-utils/chcpu.c:251]: (style) Checking if unsigned variable 'maxcpus' is less than zero.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:51:22 +0000 (22:51 +0100)]
taskset: use appropriate variable type [cppcheck]
[schedutils/taskset.c:182]: (style) Checking if unsigned variable 'ncpus' is less than zero.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:31:03 +0000 (22:31 +0100)]
libblkid: verify arroy bound before reference [cppcheck]
[libblkid/src/read.c:428]: (style) Array index end is used before limits check
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:27:24 +0000 (22:27 +0100)]
libblkid: allow return value to indicate error [cppcheck]
[libblkid/src/probe.c:1207]: (style) Checking if unsigned variable 'len' is less than zero.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:14:34 +0000 (22:14 +0100)]
libblkid: clarify operation order [cppcheck]
[libblkid/src/cache.c:265]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 21:01:28 +0000 (22:01 +0100)]
sfdisk: free variable which got the allocation [cppcheck]
[fdisk/sfdisk.c:358]: (error) Memory leak: ss
[kzak@redhat.com: - free after error]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Tue, 7 Feb 2012 20:52:21 +0000 (21:52 +0100)]
fdisk: remove redundant declaration [cppcheck]
fdisk.h:116:12: warning: redundant redeclaration of 'valid_part_table_flag' [-Wredundant-decls]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 20:26:06 +0000 (21:26 +0100)]
raw: remove unnecessary return [cppcheck]
[disk-utils/raw.c:171]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Sami Kerola [Tue, 7 Feb 2012 20:10:33 +0000 (21:10 +0100)]
mkfs.cramfs: check blocksize user input [cppcheck]
Enhance user input checking and error messaging, while fixing
cppcheck warning.
[disk-utils/mkfs.cramfs.c:729]: (style) Checking if unsigned variable 'blksize' is less than zero.
[kzak@redhat.com: fix coding style]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Tue, 7 Feb 2012 20:10:01 +0000 (21:10 +0100)]
mkfs.cramfs: close open file after usage [cppcheck]
[disk-utils/mkfs.cramfs.c:913]: (error) Resource leak: fd
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Karel Zak [Wed, 8 Feb 2012 10:56:38 +0000 (11:56 +0100)]
libblkid: improve reiserfs and btrfs min. size limits
Reported-by: Rogier Goossens <goossens.rogier@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Paul Menzel [Fri, 3 Feb 2012 18:19:39 +0000 (19:19 +0100)]
flock: add missing word »be« to flock.1
Paul Menzel [Fri, 3 Feb 2012 18:18:17 +0000 (19:18 +0100)]
flock: fix flock.1 grammar by removing »s«
Karel Zak [Tue, 7 Feb 2012 10:30:56 +0000 (11:30 +0100)]
tools: use gpg-aggent in ko-release-gen
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 17:28:42 +0000 (18:28 +0100)]
build-sys: release++ (v2.21-rc2)
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 17:27:05 +0000 (18:27 +0100)]
docs: update v2.21-ReleaseNotes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 16:34:18 +0000 (17:34 +0100)]
libblkid: remove >> 9 from GPT code
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 16:00:08 +0000 (17:00 +0100)]
docs: update AUTHORS file
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 15:57:05 +0000 (16:57 +0100)]
po: merge changes
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 15:32:29 +0000 (16:32 +0100)]
tests: add --memcheck to
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 15:02:28 +0000 (16:02 +0100)]
agetty: check localtime() result
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 11:51:55 +0000 (12:51 +0100)]
login: fix leak, improve strtok usage
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 6 Feb 2012 10:22:54 +0000 (11:22 +0100)]
vipw: use xalloc.h
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 3 Feb 2012 11:35:36 +0000 (12:35 +0100)]
libmount: use #ifdef fr selinux specific variables
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 3 Feb 2012 11:35:10 +0000 (12:35 +0100)]
fdisk: remove uneecessary code
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 23:01:32 +0000 (00:01 +0100)]
lsblk: check stat() return code
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 14:43:29 +0000 (15:43 +0100)]
login: allocate buffer with shell name
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 14:34:08 +0000 (15:34 +0100)]
hexdump: make code more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:48:03 +0000 (14:48 +0100)]
lib/loopdev: remove dead assigment and null deference
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:43:07 +0000 (14:43 +0100)]
sfdisk: remove dead assigment
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:39:02 +0000 (14:39 +0100)]
libmount: don't ignore chmod/own errors
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:33:18 +0000 (14:33 +0100)]
blkid: remove dead assigment
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:29:22 +0000 (14:29 +0100)]
lib/loopdev: fix part scan detection code
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:27:48 +0000 (14:27 +0100)]
libmount: remove dead assigment
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:26:04 +0000 (14:26 +0100)]
hwclock: remove never read value
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:23:49 +0000 (14:23 +0100)]
hwclock: clean usage, remove redundat code
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 13:13:45 +0000 (14:13 +0100)]
login: (and chsh) make pw_shell usage more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 11:50:44 +0000 (12:50 +0100)]
findmnt: initialize rc variable
Karel Zak [Thu, 2 Feb 2012 11:49:13 +0000 (12:49 +0100)]
blockdev: make the code more readable for static analysers
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 11:44:27 +0000 (12:44 +0100)]
sfdisk: cleanup fd usage
Karel Zak [Thu, 2 Feb 2012 11:34:53 +0000 (12:34 +0100)]
sfdisk: fix typo in cdrom detection
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 11:32:45 +0000 (12:32 +0100)]
lscpu: fix fd leak
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 2 Feb 2012 11:28:54 +0000 (12:28 +0100)]
sfdisk: fix fd leak
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 23:05:24 +0000 (00:05 +0100)]
findmnt: make --poll more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 22:02:21 +0000 (23:02 +0100)]
lib/sysfs: fix handle leak
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 13:03:20 +0000 (14:03 +0100)]
kill: fix fd leak
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 12:42:08 +0000 (13:42 +0100)]
fdisk: fix cdrom detection
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 12:37:57 +0000 (13:37 +0100)]
newgrp: fix possible FILE leak on error
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 12:06:34 +0000 (13:06 +0100)]
lib/loopdev: fix possible dir leak on error
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 12:03:58 +0000 (13:03 +0100)]
lib/sysfs: fix possible fd leak on error
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 11:41:25 +0000 (12:41 +0100)]
vipw: don't modify environment, check strtok() return value
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 11:26:20 +0000 (12:26 +0100)]
chcpu: check get_max_number_of_cpus() result properly
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 11:05:31 +0000 (12:05 +0100)]
cfdisk: wctomb() returns -1 on error
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 10:53:45 +0000 (11:53 +0100)]
fdisk: don't swap unsigned char
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 1 Feb 2012 08:13:55 +0000 (09:13 +0100)]
partx: fix small leak
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 20:20:55 +0000 (21:20 +0100)]
fsck.cramfs: mark usage() as noreturn
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 20:14:40 +0000 (21:14 +0100)]
chrt: add comment to keep static analysers happy
Karel Zak [Tue, 31 Jan 2012 20:10:13 +0000 (21:10 +0100)]
blkid: add comment to keep static analysers happy
Karel Zak [Tue, 31 Jan 2012 20:07:11 +0000 (21:07 +0100)]
sfdisk: add comment to keep static analysers happy
Karel Zak [Tue, 31 Jan 2012 20:06:42 +0000 (21:06 +0100)]
fdisk: add missing break
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 20:02:51 +0000 (21:02 +0100)]
more: add comment
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 19:59:54 +0000 (20:59 +0100)]
swapon: add break to keep static analysers happy
Karel Zak [Tue, 31 Jan 2012 19:58:30 +0000 (20:58 +0100)]
umount: add missing break
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 14:11:38 +0000 (15:11 +0100)]
libblkid: fix suspicious implicit sign extension [coverity scan]
... thanks to "value preserving rules".
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 14:03:27 +0000 (15:03 +0100)]
libblkid: more robust idx usage [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 14:00:52 +0000 (15:00 +0100)]
lscpu: dereferencing NULL pointer [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:56:34 +0000 (14:56 +0100)]
libblkid: make fd usage in md code more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:50:22 +0000 (14:50 +0100)]
login: comparing an array to null is not useful [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:47:53 +0000 (14:47 +0100)]
libblkid: comparing an array to null is not useful [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:31:09 +0000 (14:31 +0100)]
libmount: consolidate sysconf() usage
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:23:26 +0000 (14:23 +0100)]
login: more robust sysconf() usage [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:19:27 +0000 (14:19 +0100)]
blkid: check fd before use [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 13:04:03 +0000 (14:04 +0100)]
namei: more robust add_it() [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:39:49 +0000 (13:39 +0100)]
libblkid: check for NULL in blkid_flush_cache() [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:35:35 +0000 (13:35 +0100)]
libblkid: fix blkid_do_fullprobe() [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:31:23 +0000 (13:31 +0100)]
libblkid: check blkid_probe_set_magic() return in ultrix code [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:30:03 +0000 (13:30 +0100)]
libblkid: check blkid_probe_set_magic() return in GPT code [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:27:07 +0000 (13:27 +0100)]
partx: check sysfs_init() return value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:25:00 +0000 (13:25 +0100)]
libblkid: check return values in safe_probe code [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:10:58 +0000 (13:10 +0100)]
mkswap: check blkid_probe_lookup_values() return [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 12:00:42 +0000 (13:00 +0100)]
libblkid: check blkid_probe_set_magic() return value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 31 Jan 2012 11:55:36 +0000 (12:55 +0100)]
libblkid: check rename() return value [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 23:10:53 +0000 (00:10 +0100)]
chfn: fix use-after-free [coverity scan]
access FILE pointer after failed fclose() results in undefined behavior
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:55:26 +0000 (23:55 +0100)]
libmount: make iter reset more robust [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:49:00 +0000 (23:49 +0100)]
umount: (new) fix resource leak [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:47:27 +0000 (23:47 +0100)]
findmnt: fix resource leak [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:44:31 +0000 (23:44 +0100)]
mount: (new) fix resource leak [coverity scan]
well, this is free-before-exit, but let's use mount(8) as test
application for libmount and keep it without leaks.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:38:18 +0000 (23:38 +0100)]
libmount: fix resource leak [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:27:23 +0000 (23:27 +0100)]
libmount: fix resource leak [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:22:53 +0000 (23:22 +0100)]
libmount: fix possible null dereferencing [coverity scan]
... let's keep Coverity analyzer happy.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:17:28 +0000 (23:17 +0100)]
libmount: fix negative returns [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 22:02:43 +0000 (23:02 +0100)]
libmount: fix checked-return [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 21:57:42 +0000 (22:57 +0100)]
libblkid: fix use-after-free [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 13:55:58 +0000 (14:55 +0100)]
docs: update TODO
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 12:19:14 +0000 (13:19 +0100)]
whereis: move token assignment into loop syntax
Reported-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 30 Jan 2012 12:00:55 +0000 (13:00 +0100)]
libblkid: fix limit for OCFS check
Rogier Goossens wrote:
While testing KDE partitionmanager, I discovered that blkid did not
detect the test OCFS2 filesystem I created. After some investigation,
it appeared that it will assume the filesystem cannot be OCFS2 if
smaller than 108M. However, mkfs.ocfs2 from ocfs2-tools (1.6.3) will
happily create filesystems that are much smaller, only failing below
approx. 15000 1k blocks, and below approx. 6000 4k blocks.
Reported-by: Rogier Goossens <goossens.rogier@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>