blkid: remove dead assigment

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: fix part scan detection code

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: remove dead assigment

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: remove never read value

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: clean usage, remove redundat code

Signed-off-by: Karel Zak <kzak@redhat.com>

login: (and chsh) make pw_shell usage more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: initialize rc variable

blockdev: make the code more readable for static analysers

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: cleanup fd usage

sfdisk: fix typo in cdrom detection

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: make --poll more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: fix handle leak

Signed-off-by: Karel Zak <kzak@redhat.com>

kill: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: fix cdrom detection

Signed-off-by: Karel Zak <kzak@redhat.com>

newgrp: fix possible FILE leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: fix possible dir leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: fix possible fd leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

vipw: don't modify environment, check strtok() return value

Signed-off-by: Karel Zak <kzak@redhat.com>

chcpu: check get_max_number_of_cpus() result properly

Signed-off-by: Karel Zak <kzak@redhat.com>

cfdisk: wctomb() returns -1 on error

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: don't swap unsigned char

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: fix small leak

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck.cramfs: mark usage() as noreturn

Signed-off-by: Karel Zak <kzak@redhat.com>

chrt: add comment to keep static analysers happy

blkid: add comment to keep static analysers happy

sfdisk: add comment to keep static analysers happy

fdisk: add missing break

Signed-off-by: Karel Zak <kzak@redhat.com>

more: add comment

Signed-off-by: Karel Zak <kzak@redhat.com>

swapon: add break to keep static analysers happy

umount: add missing break

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix suspicious implicit sign extension [coverity scan]

... thanks to "value preserving rules".

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: more robust idx usage [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: dereferencing NULL pointer [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: make fd usage in md code more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

login: comparing an array to null is not useful [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: comparing an array to null is not useful [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: consolidate sysconf() usage

Signed-off-by: Karel Zak <kzak@redhat.com>

login: more robust sysconf() usage [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: check fd before use [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

namei: more robust add_it() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check for NULL in blkid_flush_cache() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix blkid_do_fullprobe() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check blkid_probe_set_magic() return in ultrix code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check blkid_probe_set_magic() return in GPT code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: check sysfs_init() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check return values in safe_probe code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

mkswap: check blkid_probe_lookup_values() return [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check blkid_probe_set_magic() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: check rename() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

chfn: fix use-after-free [coverity scan]

access FILE pointer after failed fclose() results in undefined behavior

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: make iter reset more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

umount: (new) fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (new) fix resource leak [coverity scan]

well, this is free-before-exit, but let's use mount(8) as test
application for libmount and keep it without leaks.

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix possible null dereferencing [coverity scan]

 ... let's keep Coverity analyzer happy.

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix negative returns [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix checked-return [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix use-after-free [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

whereis: move token assignment into loop syntax

Reported-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix limit for OCFS check

Rogier Goossens wrote:

 While testing KDE partitionmanager, I discovered that blkid did not
 detect the test OCFS2 filesystem I created. After some investigation,
 it appeared that it will assume the filesystem cannot be OCFS2 if
 smaller than 108M. However, mkfs.ocfs2 from ocfs2-tools (1.6.3) will
 happily create filesystems that are much smaller, only failing below
 approx. 15000 1k blocks, and below approx. 6000 4k blocks.

Reported-by: Rogier Goossens <goossens.rogier@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: use correct translation project url

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mount: define fallback selinux_warning macro with 2 params

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

docs: remove URL to u-l webpage

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount context utab tests

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix context test logic

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount context tests

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount lock tests

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix leak in tabdiff test

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount tabdiff tests

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount tags eval. tests

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix leak in tab parsing error code

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add valgrind to libmount tab parse test

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix leak in tab_update.c test

tests: call valgrind from libmount utils and update tests

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix buffer overflow and leaks in tests

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: call valgrind from libmount optstr test

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add infrastructure for valgrind

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: don't pass comments=/x-* to mount.<type> helpers

This patch add a new flag MNT_NOHLPS for mount options map, options
with this flag will not be passed to /sbin/mount.<type> helpers.

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: move cache to /run on new systems

 Why?

 * read-only root

 * /etc is pretty bad place for caches

 * all is usually cached by udev in /dev/disk/by-* and libblkid
   is able to use these symlinks

 * boot persistent cache is attractive for very small subset of
   Linux machines (and they already need extra udev tunning otherwise
   udev will probe all block devices during boot)

 * the default is possible to override in /etc/blkid.conf

The systems without /run directory will not be affected by this
change.

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: remove -w option from man page and usage() output

The option does not have any effect, the original functionality was
removed from e2fsprogs in year 2003 by

 commit 50b380b4d4ab668bad45033e3a8aaf93c7f42844
 git://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git

So.. don't propagate the option to users in year 2012 :-)

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (new) add more info about --stab to mount.8

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: remove fstab.d support

If you really need to store your configuration to a alternative files
then you have to explicitly specify the files or directories on
mount(8) command line by --fstab option.

Signed-off-by: Karel Zak <kzak@redhat.com>

Revert "mount: enable fstab.d"

 See discussion at https://lkml.org/lkml/2012/1/20/104

This reverts commit d8ebc83ff2e9f879ac60a663c1685011a048f603.

mount: (new) add --fstab to the man page

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (new) add --fstab <path> option

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: support multiple --tab-file options

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: support dirs for mnt_table_parse_fstab(), add mnt_table_parse_dir()

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix a potential memory leak at mnt_table_parse_dir

mnt_table_parse_dir in libmount/src/tab_parse.c calls
scandir, and then opendir. When the latter one, opendir is failed,
buffers allocated in scandir are not released.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>

libmount: Use filter arg of scandir* to pickup /etc/fstab.d/*.fstab files

This patch is based on my last patch:

     [PATCH 1/2] scandirat based mnt_table_parse_dir implementation

scandir* used in `mnt_table_parse_dir in libmount/src/tab_parse.c
can take filter function as an argument.

`mnt_table_parse_dir' picks up fstab files from namelist returned from
scandir* for itself. However, some parts of picking-up job can be done
in the filter function.

This patch introduces a new function `mnt_table_parse_dir_filter' to
share the code for picking-up job between two implementations of
`mnt_table_parse_dir_filter', scandir based and scandirat based.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>

libmount: scandirat based mnt_table_parse_dir implementation

In comment of `mnt_table_parse_dir' of libmount/src/tab_parse.c:

/* TODO: it would be nice to have a scandir() implementation that
 *       is able to use already opened directory */

Nowadays glibc provides `scandirat'. This patch implements `scandirat'
based `mnt_table_parse_dir'.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>

mount: add info about libmount features to --version output

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: export info about library features

Signed-off-by: Karel Zak <kzak@redhat.com>

umount: (new) use the same exit codes as mount(8)

Note that old umount(8) uses 0 and 1 exit codes, and some
exceptions like 4 or 32.

The new umount(8) cleanups this mess and uses the same exit codes as
mount(8) (see mount(8) man page).

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (new) share exit codes by include/exitcodes.h

Signed-off-by: Karel Zak <kzak@redhat.com>