]> git.ipfire.org Git - thirdparty/knot-resolver.git/log
thirdparty/knot-resolver.git
3 years agoMerge !1303: meson nit: deal with warning about future of run_command obs-knot-resolver-es11k1/deployments/2146 obs-knot-resolver-es11k1/deployments/2147
Vladimír Čunát [Wed, 1 Jun 2022 08:38:50 +0000 (10:38 +0200)] 
Merge !1303: meson nit: deal with warning about future of run_command

3 years agomeson nit: deal with warning about future of run_command
Vladimír Čunát [Mon, 30 May 2022 11:48:16 +0000 (13:48 +0200)] 
meson nit: deal with warning about future of run_command

WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also: https://github.com/mesonbuild/meson/issues/9300

In almost all cases we already check the return code explicitly
and throw a more descriptive message than what would be the default.

3 years agoMerge !1302: renumber: allow renumbering a subnet to a single IP
Vladimír Čunát [Wed, 1 Jun 2022 08:09:42 +0000 (10:09 +0200)] 
Merge !1302: renumber: allow renumbering a subnet to a single IP

3 years agorenumber: named local variables for readability
Oto Šťáva [Wed, 1 Jun 2022 07:49:25 +0000 (09:49 +0200)] 
renumber: named local variables for readability

3 years agorenumber: add test for single IP rewrite
Oto Šťáva [Wed, 1 Jun 2022 07:48:28 +0000 (09:48 +0200)] 
renumber: add test for single IP rewrite

3 years agorenumber: document additions from the parent commit
Vladimír Čunát [Mon, 30 May 2022 09:53:56 +0000 (11:53 +0200)] 
renumber: document additions from the parent commit

3 years agorenumber: allow renumbering a subnet to a single IP
Konstantin Amelichev [Sat, 28 May 2022 11:30:32 +0000 (15:30 +0400)] 
renumber: allow renumbering a subnet to a single IP

https://github.com/CZ-NIC/knot-resolver/pull/77
originally but changed by vcunat quite a bit.

3 years agolib/utils nit: deduplicate one line
Vladimír Čunát [Mon, 30 May 2022 09:13:25 +0000 (11:13 +0200)] 
lib/utils nit: deduplicate one line

3 years agoMerge !1301: lib/cache: handle posix_fallocate returning EOPNOTSUPP
Vladimír Čunát [Sat, 28 May 2022 11:57:49 +0000 (13:57 +0200)] 
Merge !1301: lib/cache: handle posix_fallocate returning EOPNOTSUPP

3 years agolib/cache: handle posix_fallocate returning EOPNOTSUPP (Linux/musl)
Jakub Jirutka [Fri, 27 May 2022 22:37:25 +0000 (00:37 +0200)] 
lib/cache: handle posix_fallocate returning EOPNOTSUPP (Linux/musl)

https://man7.org/linux/man-pages/man3/posix_fallocate.3.html#ERRORS:
> EOPNOTSUPP
> The filesystem containing the file referred to by fd does not support
> this operation.  This error code can be returned by C libraries that
> don't perform the emulation shown in NOTES, such as **musl libc**.

I've encountered this problem on Alpine Linux running inside an LXC
container on Ubuntu with data on ZFS.

3 years agoMerge !1279: daemon/http: HTTP response codes
Vladimír Čunát [Fri, 20 May 2022 08:52:42 +0000 (10:52 +0200)] 
Merge !1279: daemon/http: HTTP response codes

Fixes #728

3 years agodaemon/http: copy headers to streams instead of ownership transfer
Oto Šťáva [Fri, 13 May 2022 08:34:06 +0000 (10:34 +0200)] 
daemon/http: copy headers to streams instead of ownership transfer

3 years agotests/config/tapered: update for difference prints
Vladimír Čunát [Fri, 8 Apr 2022 10:01:16 +0000 (12:01 +0200)] 
tests/config/tapered: update for difference prints

3 years agodaemon/http: documentation
Oto Šťáva [Fri, 8 Apr 2022 09:20:59 +0000 (11:20 +0200)] 
daemon/http: documentation

3 years agoci: ODVR will also need Debian 11
Vladimír Čunát [Thu, 7 Apr 2022 16:46:01 +0000 (18:46 +0200)] 
ci: ODVR will also need Debian 11

Debian 10 could probably get dropped soon, but not yet.

3 years agodaemon/http: move status sends outside nghttp2 callbacks
Oto Šťáva [Wed, 6 Apr 2022 07:56:35 +0000 (09:56 +0200)] 
daemon/http: move status sends outside nghttp2 callbacks

The nghttp2 documentation states that we must not send data from inside
of its callbacks. It may result in crashes.

3 years agodaemon/http: return 400 on failed packet_parse + improved stream handling
Oto Šťáva [Fri, 1 Apr 2022 08:42:36 +0000 (10:42 +0200)] 
daemon/http: return 400 on failed packet_parse + improved stream handling

3 years agodaemon/http: return 400 on stream end with no processed packets
Oto Šťáva [Sat, 26 Mar 2022 08:51:27 +0000 (09:51 +0100)] 
daemon/http: return 400 on stream end with no processed packets

3 years agodaemon/http: add basic HTTP response codes
Oto Šťáva [Fri, 25 Mar 2022 11:21:07 +0000 (12:21 +0100)] 
daemon/http: add basic HTTP response codes

3 years agoMerge !1295: daemon/tls: use GNUTLS_NO_TICKETS_TLS12
Vladimír Čunát [Fri, 20 May 2022 07:39:48 +0000 (09:39 +0200)] 
Merge !1295: daemon/tls: use GNUTLS_NO_TICKETS_TLS12

Closes #742

3 years agodaemon/tls: use GNUTLS_NO_TICKETS_TLS12
Oto Šťáva [Mon, 16 May 2022 12:30:13 +0000 (14:30 +0200)] 
daemon/tls: use GNUTLS_NO_TICKETS_TLS12

3 years agoMerge !1294: lib/dnssec: rewrite most of NSEC validation code
Vladimír Čunát [Wed, 18 May 2022 14:25:22 +0000 (16:25 +0200)] 
Merge !1294: lib/dnssec: rewrite most of NSEC validation code

Closes #443 and #738

3 years agoNEWS for the rewrite of some NSEC validation parts
Vladimír Čunát [Mon, 9 May 2022 11:13:32 +0000 (13:13 +0200)] 
NEWS for the rewrite of some NSEC validation parts

3 years agolib/dnssec: nits
Vladimír Čunát [Thu, 28 Apr 2022 10:37:31 +0000 (12:37 +0200)] 
lib/dnssec: nits

3 years agolib/dnssec: rewrite kr_nsec_ref_to_unsigned()
Vladimír Čunát [Wed, 27 Apr 2022 14:03:06 +0000 (16:03 +0200)] 
lib/dnssec: rewrite kr_nsec_ref_to_unsigned()

- I see no motivation to search for NS records here;
  and I didn't like that loop nesting
- philosophy shift akin to the recent
  replacement of kr_nsec_existence_denial()

3 years agolib/dnssec: drop kr_nsec_name_error_response_check()
Vladimír Čunát [Wed, 27 Apr 2022 11:47:01 +0000 (13:47 +0200)] 
lib/dnssec: drop kr_nsec_name_error_response_check()

Just as with NODATA; basically the same comments
apply here (i.e. for NXDOMAIN) as well.

3 years agolib/dnssec: replace kr_nsec_existence_denial()
Vladimír Čunát [Sat, 23 Apr 2022 15:23:47 +0000 (17:23 +0200)] 
lib/dnssec: replace kr_nsec_existence_denial()

The NSEC validation code has been written very mechanically
according to RFC 4033..4035, but those explain wildcard-related
topics in a way that's hard to understand right.

So here I rewrite it with a different philosophy, so it should be
easier to understand, a bit faster, and less buggy and bug-prone.

3 years agodaemon/lua nit: sort RR rank names in debug logs
Vladimír Čunát [Tue, 26 Apr 2022 12:55:12 +0000 (14:55 +0200)] 
daemon/lua nit: sort RR rank names in debug logs

I was diffing logs from different runs and got annoyed by the shuffles.

3 years agoMerge !1287: tests/dnstap: add missing protobuf dependency
Vladimír Čunát [Wed, 18 May 2022 13:49:00 +0000 (15:49 +0200)] 
Merge !1287: tests/dnstap: add missing protobuf dependency

3 years agotests/dnstap: add missing protobuf dependency
Oto Šťáva [Fri, 22 Apr 2022 05:55:20 +0000 (07:55 +0200)] 
tests/dnstap: add missing protobuf dependency

3 years agoMerge !1286: daemon/network: Use trie_t instead of map_t for network endpoints
Vladimír Čunát [Fri, 13 May 2022 11:30:40 +0000 (13:30 +0200)] 
Merge !1286: daemon/network: Use trie_t instead of map_t for network endpoints

3 years agolib/generic/map: remove
Oto Šťáva [Wed, 11 May 2022 10:19:13 +0000 (12:19 +0200)] 
lib/generic/map: remove

3 years agolib/utils kr_sockaddr_key_same_addr(): more precision
Vladimír Čunát [Fri, 13 May 2022 10:52:20 +0000 (12:52 +0200)] 
lib/utils kr_sockaddr_key_same_addr(): more precision

... in case of IPv6 link-local addresses.
The casting isn't very nice, but we certainly rely on `family` being
always on the same offset anyway (and it's ensured by standards).

3 years agodaemon/network: reintroduce net.close() wildcard semantics
Oto Šťáva [Wed, 11 May 2022 08:10:25 +0000 (10:10 +0200)] 
daemon/network: reintroduce net.close() wildcard semantics

3 years agolib/utils: check for unix socket paths null-termination
Oto Šťáva [Wed, 4 May 2022 05:55:32 +0000 (07:55 +0200)] 
lib/utils: check for unix socket paths null-termination

3 years agodaemon/network: Use trie_t instead of map_t for network endpoints
Oto Šťáva [Wed, 20 Apr 2022 08:08:28 +0000 (10:08 +0200)] 
daemon/network: Use trie_t instead of map_t for network endpoints

3 years agoMerge !1290: modules/stats: use trie_t instead of map_t
Vladimír Čunát [Wed, 11 May 2022 06:23:18 +0000 (08:23 +0200)] 
Merge !1290: modules/stats: use trie_t instead of map_t

3 years agomodules/stats: use trie_t instead of map_t
Oto Šťáva [Wed, 27 Apr 2022 09:14:02 +0000 (11:14 +0200)] 
modules/stats: use trie_t instead of map_t

3 years agolib/generic/trie: add trie_apply_with_key()
Vladimír Čunát [Thu, 28 Apr 2022 11:32:52 +0000 (13:32 +0200)] 
lib/generic/trie: add trie_apply_with_key()

3 years agoMerge !1292: lib/dnssec/ta: use trie_t instead of map_t
Vladimír Čunát [Wed, 4 May 2022 12:15:44 +0000 (14:15 +0200)] 
Merge !1292: lib/dnssec/ta: use trie_t instead of map_t

3 years agolib/dnssec/ta: use trie_t instead of map_t
Oto Šťáva [Wed, 4 May 2022 09:00:46 +0000 (11:00 +0200)] 
lib/dnssec/ta: use trie_t instead of map_t

3 years agoMerge !1288: daemon/worker: Use trie_t instead of map_t for TCP connections
Vladimír Čunát [Mon, 2 May 2022 10:42:47 +0000 (12:42 +0200)] 
Merge !1288: daemon/worker: Use trie_t instead of map_t for TCP connections

3 years agodaemon/worker: Use trie_t instead of map_t for TCP connections
Oto Šťáva [Wed, 27 Apr 2022 07:02:41 +0000 (09:02 +0200)] 
daemon/worker: Use trie_t instead of map_t for TCP connections

3 years agolib/utils: sockaddr key generation
Oto Šťáva [Fri, 29 Apr 2022 06:50:35 +0000 (08:50 +0200)] 
lib/utils: sockaddr key generation

3 years agoMerge branch !1285: daemon/zimport: close transaction after importing batch
Vladimír Čunát [Wed, 13 Apr 2022 08:44:48 +0000 (10:44 +0200)] 
Merge branch !1285: daemon/zimport: close transaction after importing batch

3 years agodaemon/zimport: close transaction after importing batch
Vladimír Čunát [Mon, 11 Apr 2022 10:14:50 +0000 (12:14 +0200)] 
daemon/zimport: close transaction after importing batch

I'm really sorry about this.  It's my regression in 5.5.0 (!1225)

Practical consequence was that the RW transaction was held open
until that instance did something with cache (and thus closed),
so any other instance would be frozen in the meantime if doing
anything non-read-only with cache (e.g. startup).
https://lists.nic.cz/hyperkitty/list/knot-resolver-users@lists.nic.cz/thread/6DOXXOA6ACEUBVYPUY3T2MLGIHWOMV6M/

3 years agoMerge !1283: ci: fix ambiguous tag-sets
Vladimír Čunát [Thu, 7 Apr 2022 08:35:35 +0000 (10:35 +0200)] 
Merge !1283: ci: fix ambiguous tag-sets

3 years agoci: fix ambiguous tag-sets
Vladimír Čunát [Thu, 7 Apr 2022 08:05:34 +0000 (10:05 +0200)] 
ci: fix ambiguous tag-sets

In a few places the tag-set specification for jobs could match
either amd64 or arm64 runners.  That non-determinism is bad,
especially when passing platform-specific artifacts around.

This is just a stop-gap measure.  Later we'll need to rethink our CI
in terms of the two platforms.

I didn't touch tag-sets with `condor`, as that will probably always be
just a single machine (which coordinates scheduling on others).

3 years agoMerge !1282: ci/pkgtest: fix issues with sphinx
Vladimír Čunát [Wed, 6 Apr 2022 08:49:22 +0000 (10:49 +0200)] 
Merge !1282: ci/pkgtest: fix issues with sphinx

3 years agoci/pkgtest: fix issues with sphinx
Vladimír Čunát [Mon, 4 Apr 2022 12:28:06 +0000 (14:28 +0200)] 
ci/pkgtest: fix issues with sphinx

The apkg installation through pip3 was pulling too new jinja2 version,
breaking subsequent usage of sphinx to build docs (in `apkg build`).

3 years agoMerge !1276: xdp: make it work also with libknot 3.1
Vladimír Čunát [Mon, 4 Apr 2022 08:40:28 +0000 (10:40 +0200)] 
Merge !1276: xdp: make it work also with libknot 3.1

Fixes #735

3 years agoxdp nit: utilize freeing API added in libknot 3.1
Vladimír Čunát [Wed, 23 Mar 2022 11:47:14 +0000 (12:47 +0100)] 
xdp nit: utilize freeing API added in libknot 3.1

It's probably a bit more efficient, but this part of code should be
rarely used even on a resolver serving all in XDP.

3 years agoxdp: make it work also with libknot 3.1
Vladimír Čunát [Wed, 23 Mar 2022 11:36:12 +0000 (12:36 +0100)] 
xdp: make it work also with libknot 3.1

Somehow I did this wrong when porting to libknot 3.1.

3 years agoMerge !1281: pkg: update changelogs
Vladimír Čunát [Mon, 4 Apr 2022 08:27:16 +0000 (10:27 +0200)] 
Merge !1281: pkg: update changelogs

3 years agopkg: update changelogs
Jakub Ružička [Tue, 29 Mar 2022 13:28:40 +0000 (15:28 +0200)] 
pkg: update changelogs

* set myself as package maintainer
* use {{ now }} instead of hardcoded datetime
  * bump apkg compat to 2

3 years agorpm: sync from Fedora
Jakub Ružička [Tue, 29 Mar 2022 13:25:33 +0000 (15:25 +0200)] 
rpm: sync from Fedora

This is a no-op as GPG_CHECK is disabled for upstream package but it
keeps the .spec files in sync.

3 years agoMerge !1271: ci/images: add docs obs-knot-resolver-es11k1/deployments/2065 obs-knot-resolver-es11k1/deployments/2067 obs-knot-resolver-es11k1/deployments/2069 obs-knot-resolver-es11k1/deployments/2070 obs-knot-resolver-es11k1/deployments/2071 obs-knot-resolver-es11k1/deployments/2072 obs-knot-resolver-es11k1/deployments/2073 obs-knot-resolver-es11k1/deployments/2074
Vladimír Čunát [Mon, 21 Mar 2022 10:45:23 +0000 (11:45 +0100)] 
Merge !1271: ci/images: add docs

3 years agoci/images: add debian-11-coverity description
Oto Šťáva [Mon, 21 Mar 2022 05:55:06 +0000 (06:55 +0100)] 
ci/images: add debian-11-coverity description

3 years agoci/images: add image description
Tomas Krizek [Wed, 9 Mar 2022 12:07:35 +0000 (13:07 +0100)] 
ci/images: add image description

3 years agoci/images: ensure base image is updated
Tomas Krizek [Wed, 9 Mar 2022 11:59:32 +0000 (12:59 +0100)] 
ci/images: ensure base image is updated

3 years agoMerge !1275: modules/dns64: fix incorrect packet writes for cached packets
Vladimír Čunát [Mon, 21 Mar 2022 10:03:33 +0000 (11:03 +0100)] 
Merge !1275: modules/dns64: fix incorrect packet writes for cached packets

Fixes #727

3 years agomodules/dns64: fix incorrect packet writes for cached packets
Oto Šťáva [Fri, 18 Mar 2022 14:22:08 +0000 (15:22 +0100)] 
modules/dns64: fix incorrect packet writes for cached packets

Also change the return type of kr_pkt_has_dnssec() and lua's :dobit()

3 years agoMerge branch 'release-5-5-0' into 'master' obs-knot-resolver-8xyvhu/deployments/2058 obs-knot-resolver-es11k1/deployments/2060 obs-knot-resolver-es11k1/deployments/2061 obs-knot-resolver-es11k1/deployments/2062 obs-knot-resolver-es11k1/deployments/2063 obs-knot-resolver-es11k1/deployments/2064 obs-knot-resolver-kv62s6/deployments/2057 v5.5.0
Aleš Mrázek [Tue, 15 Mar 2022 10:28:50 +0000 (11:28 +0100)] 
Merge branch 'release-5-5-0' into 'master'

release 5.5.0

See merge request knot/knot-resolver!1272

3 years agoAUTHORS: duplicate alias removed
Aleš Mrázek [Mon, 14 Mar 2022 21:18:58 +0000 (22:18 +0100)] 
AUTHORS: duplicate alias removed

3 years agorelease 5.5.0
Aleš [Mon, 14 Mar 2022 14:22:13 +0000 (15:22 +0100)] 
release 5.5.0

3 years agoMerge !1273: Documentation nits (policy, predict)
Vladimír Čunát [Tue, 15 Mar 2022 06:53:47 +0000 (07:53 +0100)] 
Merge !1273: Documentation nits (policy, predict)

3 years agopredict docs: be more explicit about recommended use
Vladimír Čunát [Mon, 14 Mar 2022 14:27:54 +0000 (15:27 +0100)] 
predict docs: be more explicit about recommended use

We're still run into people who thought that the example config
is a suitable default.  Example where it caused practical issues:
https://lists.nic.cz/hyperkitty/list/knot-resolver-users@lists.nic.cz/thread/WQDJJ3LLEIZ5U3VVSCITW6DZPICW4L7U/

3 years agopolicy docs: explain non-ASCII names
Vladimír Čunát [Mon, 14 Mar 2022 14:19:45 +0000 (15:19 +0100)] 
policy docs: explain non-ASCII names

3 years agoMerge branch 'selection' into 'master' obs-knot-resolver-es11k1/deployments/2056
Tomas Krizek [Mon, 14 Mar 2022 10:17:14 +0000 (11:17 +0100)] 
Merge branch 'selection' into 'master'

lib/selection: fix interaction of timeouts with reboots

Closes #722

See merge request knot/knot-resolver!1269

3 years agoRevert "daemon/worker: add task timeouts for upstream TCP connections"
Vladimír Čunát [Mon, 14 Mar 2022 06:33:05 +0000 (07:33 +0100)] 
Revert "daemon/worker: add task timeouts for upstream TCP connections"

This reverts commit 0c9ea1332e1c4475043eab571f60915b90985999 (!1226).

CI rp:fwd-tls6.udp-asan now repeatedly shows use-after-free.
That could be a serious issue, and this commit's feature
seems less important than the risk.  Let's revert until the issue
gets deeper investigation.

3 years agolib/selection: fix interaction of timeouts with reboots
Vladimír Čunát [Mon, 7 Mar 2022 17:04:05 +0000 (18:04 +0100)] 
lib/selection: fix interaction of timeouts with reboots

We use "monotonic" time-stamps for the dead_since field;
that breaks on system reboots, in which case we reset the stats.
(if the server was categorized as dead)

If the server times out afterwards, we'd fail the condition
`cur_state.consecutive_timeouts == old_state.consecutive_timeouts`
so its stats would not update.  Therefore we'd get stuck forever
in a state where the unusable server has high priority (no_rtt_info).

This commit changes a bit more than was necessary to fix this,
including precision of the stats (in some cases).

3 years agolib/selection: improve randomness of ties
Vladimír Čunát [Fri, 4 Mar 2022 11:55:55 +0000 (12:55 +0100)] 
lib/selection: improve randomness of ties

The approach was dubious: random shuffle, qsort() and choose the first.
The main functional problem was that qsort() isn't a stable sort,
so the effect of pre-shuffling is not reliable, even though I don't have
any evidence of this causing issues in practice.

The new code should also be a bit more efficient in terms of CPU and
consumed randomness, but that probably won't be noticeable.
The arrays passed into select_transport() are now const (no sorting),
which could make the code easier to "understand".

3 years agoMerge branch 'ci-remove-arm' into 'master' obs-knot-resolver-es11k1/deployments/2050 obs-knot-resolver-es11k1/deployments/2051 obs-knot-resolver-es11k1/deployments/2052 obs-knot-resolver-es11k1/deployments/2053 obs-knot-resolver-es11k1/deployments/2054
Tomas Krizek [Wed, 9 Mar 2022 12:19:18 +0000 (13:19 +0100)] 
Merge branch 'ci-remove-arm' into 'master'

ci: remove experimental arm builds

See merge request knot/knot-resolver!1270

3 years agoci: remove experimental arm builds
Tomas Krizek [Wed, 9 Mar 2022 11:39:57 +0000 (12:39 +0100)] 
ci: remove experimental arm builds

These are running on a hardware setup which is hard to maintain. In the
near future, ARM64 should be covered by a dedicated runner.

3 years agoMerge branch 'keyblock-update' into 'master' obs-knot-resolver-es11k1/deployments/2049
Tomas Krizek [Tue, 8 Mar 2022 14:44:16 +0000 (15:44 +0100)] 
Merge branch 'keyblock-update' into 'master'

pgp: remove tkrizek, add amrazek

See merge request knot/knot-resolver!1268

3 years agopgp: remove tkrizek, add amrazek
Tomas Krizek [Mon, 7 Mar 2022 16:11:14 +0000 (17:11 +0100)] 
pgp: remove tkrizek, add amrazek

3 years agoMerge branch 'distrotests-rocky8' into 'master' obs-knot-resolver-es11k1/deployments/2048
Tomas Krizek [Mon, 7 Mar 2022 12:17:16 +0000 (13:17 +0100)] 
Merge branch 'distrotests-rocky8' into 'master'

distro/tests: use rocky8 instead of centos8

See merge request knot/knot-resolver!1267

3 years agodistro/tests: add Rocky support obs-knot-resolver-bs4hbr/deployments/2047
Tomas Krizek [Mon, 7 Mar 2022 09:25:44 +0000 (10:25 +0100)] 
distro/tests: add Rocky support

3 years ago.gitlabci: add some doc comments for distotest job obs-knot-resolver-bs4hbr/deployments/2043
Tomas Krizek [Fri, 4 Mar 2022 13:11:36 +0000 (14:11 +0100)] 
.gitlabci: add some doc comments for distotest job

3 years agodistro/tests: use rocky8 instead of centos8
Tomas Krizek [Fri, 4 Mar 2022 13:11:16 +0000 (14:11 +0100)] 
distro/tests: use rocky8 instead of centos8

3 years agoMerge !1266: Coverity Scan false positives clarifications obs-knot-resolver-es11k1/deployments/2041 obs-knot-resolver-es11k1/deployments/2042 obs-knot-resolver-es11k1/deployments/2044 obs-knot-resolver-es11k1/deployments/2045 obs-knot-resolver-es11k1/deployments/2046
Vladimír Čunát [Tue, 1 Mar 2022 17:46:47 +0000 (18:46 +0100)] 
Merge !1266: Coverity Scan false positives clarifications

3 years agoCoverity Scan false positives clarifications
Oto Šťáva [Mon, 28 Feb 2022 15:00:25 +0000 (16:00 +0100)] 
Coverity Scan false positives clarifications

3 years agoMerge branch 'cache-nit-ttl' into 'master'
Tomas Krizek [Tue, 1 Mar 2022 08:49:15 +0000 (09:49 +0100)] 
Merge branch 'cache-nit-ttl' into 'master'

cache nit: reduce cache.max_ttl limit a bit

See merge request knot/knot-resolver!1265

3 years agocache nit: reduce cache.max_ttl limit a bit
Vladimír Čunát [Mon, 28 Feb 2022 08:33:25 +0000 (09:33 +0100)] 
cache nit: reduce cache.max_ttl limit a bit

The new limit is over 68 years, so still completely meaningless.

3 years agoMerge !1264: Fix defects detected by Coverity Scan obs-knot-resolver-es11k1/deployments/2039
Vladimír Čunát [Mon, 28 Feb 2022 13:34:56 +0000 (14:34 +0100)] 
Merge !1264: Fix defects detected by Coverity Scan

3 years agoFix defects detected by Coverity Scan
Oto Šťáva [Fri, 25 Feb 2022 06:46:13 +0000 (07:46 +0100)] 
Fix defects detected by Coverity Scan

Targeted CIDs: 155456, 155962, 346121, 346123, 346124, 346125,
  346126, 346127, 346130, 346131, 346132, 346134, 346135, 346138,
  346140, 346145, 346146, 346149, 346152, 346154, 346156, 346157

lib/dnssec/nsec3.c change:
  apparently cleaning fallout from my (= vcunat's) commit b5cf61325ae

3 years agoMerge !1256: modules/dnstap: improve UX for common errors
Vladimír Čunát [Mon, 28 Feb 2022 11:08:14 +0000 (12:08 +0100)] 
Merge !1256: modules/dnstap: improve UX for common errors

3 years agomodules/dnstap: improve UX for common errors
Vladimír Čunát [Tue, 8 Feb 2022 11:59:31 +0000 (12:59 +0100)] 
modules/dnstap: improve UX for common errors

The main thing is the "failed to open socket" message.
But let's also elevate other fatal one-off logs to ERROR level.

3 years agomodules/dnstap: don't do anything on loading the module
Vladimír Čunát [Tue, 8 Feb 2022 11:46:55 +0000 (12:46 +0100)] 
modules/dnstap: don't do anything on loading the module

Usually in configuration the module is loaded in a separate command
from passing configuration to it.  For dnstap this loading would
immediately lead to opening the default socket path, even if the
configuration actually specifies (a different) path later.

Users can still force using the default by passing an empty table:
`dnstap.config({})` or `modules = { dnstap = {}}`
(though I doubt the utility of the default /tmp/dnstap.sock anyway)

3 years agoMerge !1257: lib/resolve, modules: NO_ANSWER for not responding to clients
Vladimír Čunát [Mon, 28 Feb 2022 10:58:54 +0000 (11:58 +0100)] 
Merge !1257: lib/resolve, modules: NO_ANSWER for not responding to clients

Implements #432

3 years agolib/resolve, modules: NO_ANSWER for not responding to clients
Oto Šťáva [Tue, 8 Feb 2022 12:46:15 +0000 (13:46 +0100)] 
lib/resolve, modules: NO_ANSWER for not responding to clients

3 years agoMerge !1238: Support for PROXYv2 protocol
Vladimír Čunát [Mon, 28 Feb 2022 10:43:25 +0000 (11:43 +0100)] 
Merge !1238: Support for PROXYv2 protocol

3 years agodaemon, lib: document API changes made due to PROXYv2
Oto Šťáva [Tue, 8 Feb 2022 09:08:05 +0000 (10:08 +0100)] 
daemon, lib: document API changes made due to PROXYv2

3 years agodaemon: add PROXYv2 SSL TLV handling + minor refactoring
Oto Šťáva [Mon, 7 Feb 2022 13:56:33 +0000 (14:56 +0100)] 
daemon: add PROXYv2 SSL TLV handling + minor refactoring

3 years agodaemon: correct PROXYv2 handling for TCP sessions
Oto Šťáva [Mon, 7 Feb 2022 09:08:21 +0000 (10:08 +0100)] 
daemon: correct PROXYv2 handling for TCP sessions

3 years agodaemon/bindings doc: PROXYv2 clarifications
Oto Šťáva [Fri, 4 Feb 2022 08:16:23 +0000 (09:16 +0100)] 
daemon/bindings doc: PROXYv2 clarifications

3 years agodaemon: use flags from proxy header + refactor comm data
Oto Šťáva [Thu, 3 Feb 2022 13:06:01 +0000 (14:06 +0100)] 
daemon: use flags from proxy header + refactor comm data

3 years agodaemon: allow setting zero netmasks for net.proxy_allowed()
Oto Šťáva [Fri, 28 Jan 2022 08:01:50 +0000 (09:01 +0100)] 
daemon: allow setting zero netmasks for net.proxy_allowed()

3 years agotests/config: net.proxy_allowed() support
Tomas Krizek [Wed, 26 Jan 2022 17:02:22 +0000 (18:02 +0100)] 
tests/config: net.proxy_allowed() support

3 years agodaemon/proxyv2.test: deckard test for PROXYv2
Oto Šťáva [Tue, 4 Jan 2022 12:45:29 +0000 (13:45 +0100)] 
daemon/proxyv2.test: deckard test for PROXYv2