]>
git.ipfire.org Git - thirdparty/kea.git/log
Marcin Siodelski [Thu, 8 Nov 2018 13:22:05 +0000 (14:22 +0100)]
[#42, !103] Addressed two review comments.
Commentary for sleep(1) in case of the error condition in the IfaceMgr.
Also fixed one parameter name in the doxygen.
Thomas Markwalder [Thu, 8 Nov 2018 11:43:32 +0000 (06:43 -0500)]
[#42, !103] Additional review fixes
Minor commentary changes.
Thomas Markwalder [Wed, 7 Nov 2018 23:07:34 +0000 (18:07 -0500)]
[#42,!103] Addressed majority of review comments
Most notable change is "queue-control" is now "dhcp-queue-control"
Thomas Markwalder [Tue, 6 Nov 2018 16:22:57 +0000 (11:22 -0500)]
[#42, !103] General clean up
Thomas Markwalder [Tue, 6 Nov 2018 14:42:59 +0000 (09:42 -0500)]
[#42] kea-dhcp4 parsing simplified
kea-dhcp4 parsing now matches kea-dhpc6 in parsing queue-control
as simply a map that must contain "queue-type".
Thomas Markwalder [Tue, 6 Nov 2018 14:31:40 +0000 (09:31 -0500)]
[#42] kea-dhcp6 can now parse and use queue-control
src/bin/dhcp6/ctrl_dhcp6_srv.cc
ControlledDhcpv6Srv::processConfig() - adde packet queue config logic
src/bin/dhcp6/dhcp6_lexer.ll
Added parsing of queue-control
src/bin/dhcp6/dhcp6_messages.mes
Added DHCP6_CONFIG_PACKET_QUEUE message
src/bin/dhcp6/dhcp6_parser.yy
src/bin/dhcp6/json_config_parser.cc
configureDhcp6Server() - now parses "queue-control"
src/bin/dhcp6/parser_context.*
Added QUEUE_CONTROL
src/bin/dhcp6/tests/config_parser_unittest.cc
TEST_F(Dhcp6ParserTest, queueControl)
TEST_F(Dhcp6ParserTest, queueControlInvalid) - new tests
src/lib/dhcpsrv/parsers/queue_control_parser.*
Revamped to construct an ElementPtr rather than QueueControl
Thomas Markwalder [Mon, 5 Nov 2018 20:29:01 +0000 (15:29 -0500)]
[#42] Replaced use of QueueControl with ElementPtr
deleted:
src/lib/dhcp/queue_control.cc
src/lib/dhcp/queue_control.h
src/lib/dhcp/tests/queue_control_unittest.cc
Updates is mulitple files
Thomas Markwalder [Mon, 5 Nov 2018 16:21:29 +0000 (11:21 -0500)]
[#42] Implemented PacketQueueMgr class
New files:
src/lib/dhcp/packet_queue_mgr.h
src/lib/dhcp/packet_queue_mgr4.cc
src/lib/dhcp/packet_queue_mgr4.h
src/lib/dhcp/packet_queue_mgr6.cc
src/lib/dhcp/packet_queue_mgr6.h
src/lib/dhcp/tests/packet_queue_mgr4_unittest.cc
src/lib/dhcp/tests/packet_queue_mgr6_unittest.cc
src/lib/dhcp/tests/packet_queue_testutils.h
src/bin/dhcp4/ctrl_dhcp4_srv.cc
Cleaned up packet queue config block
src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
src/bin/dhcp4/tests/config_parser_unittest.cc
added queue-type
src/bin/dhcp4/dhcp4_messages.mes
added DHCP4_CONFIG_PACKET_QUEUE message
src/lib/dhcp/Makefile.am
packet_queue_mgr.h
packet_queue_mgr4.cc packet_queue_mgr4.h
packet_queue_mgr6.cc packet_queue_mgr6.h
src/lib/dhcp/iface_mgr.*
Replaced packet queue members with PQM members
Added PQM instantion to IfaceMgr ctor
src/lib/dhcp/packet_queue.h
added getInfo,getInfoStr
src/lib/dhcp/tests/Makefile.am
packet_queue_mgr4_unittest.cc
packet_queue_mgr6_unittest.cc
src/lib/dhcpsrv/parsers/queue_control_parser.cc
added queue-type
Thomas Markwalder [Thu, 1 Nov 2018 15:19:55 +0000 (11:19 -0400)]
[#42, !103] Interrim commit, kea-dhcp4 supports "queue-control"
kea-dhcp4 will parse and use "queue-control" to configure ring
buffer size:
"Dhcp4":
{
"queue-control": {
# max number of packets the ring will hold
"capacity" : 100
},
:
This is an interrim commit for testing purposes.
Expect a fair amount of refactoring in subsequent commits.
New files:
src/lib/dhcp/queue_control.cc
src/lib/dhcp/queue_control.h
src/lib/dhcp/tests/queue_control_unittest.cc
src/lib/dhcpsrv/parsers/queue_control_parser.cc
src/lib/dhcpsrv/parsers/queue_control_parser.h
src/bin/dhcp4/ctrl_dhcp4_srv.cc
ControlledDhcpv4Srv::processConfig() -
added logic to set packet queue controller
src/bin/dhcp4/dhcp4_lexer.ll b/src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
src/bin/dhcp4/parser_context.*
Added queue-control parsing
src/bin/dhcp4/json_config_parser.cc
configureDhcp4Server() - recognize and parse "queue-control"
src/bin/dhcp4/tests/config_parser_unittest.cc
TEST_F(Dhcp4ParserTest, queueControl)
TEST_F(Dhcp4ParserTest, queueControlInvalid)
- new tests
src/lib/dhcp/iface_mgr.*
IfaceMgr::getPacketQueueControl4()
IfaceMgr::setPacketQueueControl4()
IfaceMgr::getPacketQueueControl6()
IfaceMgr::setPacketQueueControl6()
src/lib/dhcp/packet_queue.*
Use QueueControl class
src/lib/dhcpsrv/srv_config.*
Added QueueControl member, getter/setter
SrvConfig::toElement() - now emits queue-control if not null
Thomas Markwalder [Mon, 29 Oct 2018 15:27:12 +0000 (11:27 -0400)]
[#42,!103] Initial receiver thread and packet queuing
New files:
src/lib/dhcp -
packet_queue.h - defines packet queuing template classes
socket_info.h - contains existing class extracted iface_mgr.h
tests/packet_queue4_unittest.cc
tests/packet_queue6_unittest.cc
src/lib/dhcp/iface_mgr.*
IfaceMgr:: - new functions
- receiveDHCP<4/6>Packets() - thread worker function which
monitors interface sockets, enqueues packets as they are read
- receiveDHCP<4/6>Packet() - reads a single packet from a socket
- startDHCPReceiver(const uint16_t family) - runs
receiveDHCP<4/6?appropriate worker function in a thread
- stopReceiver() - stops the receiver thread
- setPacketQueue<4/6> - replaces the default packet queue instance
receiveDHCP<4/6>() - modified to monitor receiver watch
socekts rather than interface sockets. Dequeue packets
from packet queue.
src/lib/dhcp/tests/iface_mgr_unittest.cc
TEST_F(IfaceMgrTest, packetQueue4)
TEST_F(IfaceMgrTest, packetQueue6)
src/lib/dhcpsrv/cfg_iface.cc
CfgIface::openSockets() - starts DHCP receiver
CfgIface::closeSockets() - stops DHCP receiver
Francis Dupont [Fri, 19 Oct 2018 21:23:23 +0000 (23:23 +0200)]
[148-lib-process-without-args] Repaired system tests
Tomek Mrugalski [Fri, 19 Oct 2018 15:54:28 +0000 (17:54 +0200)]
[#148,!80] When run without arguments netconf,d2,ca prints out usage.
Tomek Mrugalski [Fri, 19 Oct 2018 14:33:53 +0000 (16:33 +0200)]
[148-lib-process-servers-without-arguments] Added system test
# Conflicts:
# src/bin/netconf/tests/netconf_tests.sh.in
Francis Dupont [Wed, 17 Oct 2018 15:15:24 +0000 (17:15 +0200)]
[148-lib-process-servers-without-arguments] Added unit tests
Francis Dupont [Wed, 17 Oct 2018 14:03:05 +0000 (16:03 +0200)]
[148-lib-process-servers-without-arguments] Bug fixed - need tests
Francis Dupont [Wed, 17 Oct 2018 14:01:13 +0000 (16:01 +0200)]
[148-lib-process-servers-without-arguments] trailing spaces
Francis Dupont [Wed, 17 Oct 2018 13:59:50 +0000 (15:59 +0200)]
[148-lib-process-servers-without-arguments] trailing spaces
Francis Dupont [Fri, 19 Oct 2018 20:57:41 +0000 (22:57 +0200)]
[65-libyang-gcc-requirement] Wrapped long lines
Tomek Mrugalski [Fri, 19 Oct 2018 14:20:36 +0000 (16:20 +0200)]
[#65,!64] Reworked installation notes
- mostly moved to wiki, also cleaned up some text
Francis Dupont [Sun, 14 Oct 2018 08:52:38 +0000 (10:52 +0200)]
[65-libyang-gcc-requirement] typo
Francis Dupont [Sun, 14 Oct 2018 08:43:46 +0000 (10:43 +0200)]
[65-libyang-gcc-requirement] Updated
Francis Dupont [Fri, 19 Oct 2018 14:41:53 +0000 (16:41 +0200)]
[master] spelling
Tomek Mrugalski [Fri, 19 Oct 2018 13:38:44 +0000 (15:38 +0200)]
[#65,!62] Changes after review.
Francis Dupont [Thu, 18 Oct 2018 16:46:26 +0000 (18:46 +0200)]
[65-libyang-adaptors] Addressed comments
Tomek Mrugalski [Thu, 18 Oct 2018 11:12:04 +0000 (13:12 +0200)]
[#65,!62] Added extra explanation how to start sysrepod
- Wlodek was complaining that it was confusing
Tomek Mrugalski [Thu, 18 Oct 2018 11:11:25 +0000 (13:11 +0200)]
[#65,!62] Small clarifications after review.
Francis Dupont [Sun, 7 Oct 2018 21:56:59 +0000 (23:56 +0200)]
[65-libyang-adaptors] Added high level adaptors from lib-yang
Francis Dupont [Thu, 18 Oct 2018 14:24:17 +0000 (16:24 +0200)]
[65-libyang-logger_rebased] Rebased before merging
Francis Dupont [Thu, 18 Oct 2018 14:15:54 +0000 (16:15 +0200)]
[master] unused parameter
Thomas Markwalder [Thu, 18 Oct 2018 13:05:19 +0000 (09:05 -0400)]
[master] kea-dhcp4 server now opens configuration backends
Merge branch '101-cb-add-two-step-configuration-to-the-dhcpv4-server-2'
Marcin Siodelski [Thu, 18 Oct 2018 12:16:27 +0000 (14:16 +0200)]
[master] Added ChangeLog entry for issue #93.
Marcin Siodelski [Thu, 18 Oct 2018 11:06:04 +0000 (13:06 +0200)]
[#93,!63] Added @todo in the ServerSelector header file.
Marcin Siodelski [Thu, 18 Oct 2018 11:00:20 +0000 (13:00 +0200)]
[#93,!63] Added todo to the MySQL query macros.
Marcin Siodelski [Thu, 18 Oct 2018 10:21:58 +0000 (12:21 +0200)]
[#93,!63] Added todo to expand unit test to cover per server config.
Marcin Siodelski [Thu, 18 Oct 2018 10:15:17 +0000 (12:15 +0200)]
[#93,!63] Fixed MySQL macro name.
Marcin Siodelski [Thu, 18 Oct 2018 10:12:25 +0000 (12:12 +0200)]
[#93,!63] Throw exception if the server selector is unassigned.
Marcin Siodelski [Tue, 16 Oct 2018 14:39:50 +0000 (16:39 +0200)]
[#93,!63] Implemented getHost() and getPort() MySQL backend functions.
Marcin Siodelski [Tue, 16 Oct 2018 13:01:02 +0000 (15:01 +0200)]
[#93,!63] Use getServerTag() convenience function.
Marcin Siodelski [Tue, 16 Oct 2018 12:55:16 +0000 (14:55 +0200)]
[#93,!63] Fixed update statement for option definition.
Marcin Siodelski [Tue, 16 Oct 2018 12:44:02 +0000 (14:44 +0200)]
[#93,!63] Server selection is partially supported for options.
Also, MySQL prepared statements are moved to a common header.
Marcin Siodelski [Mon, 15 Oct 2018 11:11:23 +0000 (13:11 +0200)]
[#93,!63] Server selection is partially supported for option definitions.
Marcin Siodelski [Mon, 15 Oct 2018 10:12:49 +0000 (12:12 +0200)]
[#93,!63] Server selection is partially supported for shared networks.
Marcin Siodelski [Sat, 13 Oct 2018 11:21:47 +0000 (13:21 +0200)]
[#93,!63] Resolve conflicts after rebase.
Marcin Siodelski [Wed, 10 Oct 2018 11:23:43 +0000 (13:23 +0200)]
[#93,!63] Server selection partially working for subnets.
Marcin Siodelski [Tue, 9 Oct 2018 18:41:27 +0000 (20:41 +0200)]
[#93,!63] Server selection partially working for global paramneters.
Marcin Siodelski [Tue, 9 Oct 2018 13:24:58 +0000 (15:24 +0200)]
[#93,!63] Removed extraneous constants introduced during rebase.
Marcin Siodelski [Mon, 8 Oct 2018 14:32:16 +0000 (16:32 +0200)]
[#93,!63] Implemented server selection for global parameters in MySQL.
Marcin Siodelski [Mon, 8 Oct 2018 12:46:48 +0000 (14:46 +0200)]
[#93,!63] Added CASCADE delete to MySQL CB schema.
Marcin Siodelski [Mon, 8 Oct 2018 11:13:10 +0000 (13:13 +0200)]
[#93,!63] Added logical servers to dhcp4_server and dhcp6_server MySQL.
Marcin Siodelski [Sun, 7 Oct 2018 17:52:30 +0000 (19:52 +0200)]
[#93,!56] Addressed review comments.
Tomek Mrugalski [Thu, 18 Oct 2018 11:30:32 +0000 (13:30 +0200)]
[#65,!29] Minor clarifications
Francis Dupont [Wed, 17 Oct 2018 19:52:15 +0000 (21:52 +0200)]
[5-netconf-extend-syntax_rebased] Addressed rebase conflicts
Thomas Markwalder [Wed, 17 Oct 2018 19:51:17 +0000 (15:51 -0400)]
[#101,!73] Addressed missed review items
Francis Dupont [Wed, 17 Oct 2018 19:48:00 +0000 (21:48 +0200)]
[5-netconf-extend-syntax] Updated get_config.json
Francis Dupont [Wed, 17 Oct 2018 19:22:33 +0000 (21:22 +0200)]
[5-netconf-extend-syntax] Addressed comments
Thomas Markwalder [Wed, 17 Oct 2018 19:05:27 +0000 (15:05 -0400)]
[#101, !73] Addresses review comments
Francis Dupont [Wed, 17 Oct 2018 17:31:40 +0000 (19:31 +0200)]
[65-libyang-logger_rebased] Addressed rebase conflicts
Francis Dupont [Wed, 17 Oct 2018 16:58:00 +0000 (18:58 +0200)]
[65-libyang-pd-pool_rebased] Addressed rebase conflicts
Francis Dupont [Wed, 17 Oct 2018 16:53:39 +0000 (18:53 +0200)]
[65-libyang-pd-pool] [non-]empty applies to lists
Francis Dupont [Wed, 17 Oct 2018 16:50:58 +0000 (18:50 +0200)]
[65-libyang-pd-pool] Uniformized throw message
Tomek Mrugalski [Wed, 17 Oct 2018 16:19:09 +0000 (18:19 +0200)]
[#65,!45] Added missing unit-test.
Francis Dupont [Wed, 17 Oct 2018 15:55:46 +0000 (17:55 +0200)]
[65-libyang-host_rebased] Rebased before merging
Tomek Mrugalski [Wed, 17 Oct 2018 15:43:01 +0000 (17:43 +0200)]
[#65,!46] Minor clarifications in comments.
Tomek Mrugalski [Wed, 17 Oct 2018 15:42:28 +0000 (17:42 +0200)]
[#65,!46] Missing unit-test added.
Francis Dupont [Wed, 17 Oct 2018 12:29:30 +0000 (14:29 +0200)]
[5-netconf-doc-config] Final changes
Tomek Mrugalski [Wed, 17 Oct 2018 10:19:17 +0000 (12:19 +0200)]
[#5,!53] Updated netconf docs
Francis Dupont [Tue, 16 Oct 2018 21:05:26 +0000 (23:05 +0200)]
[5-netconf-doc-config] Removed to resolved comments
Francis Dupont [Tue, 16 Oct 2018 20:18:58 +0000 (22:18 +0200)]
[5-netconf-doc-config] typo (comment)
Francis Dupont [Tue, 16 Oct 2018 20:16:52 +0000 (22:16 +0200)]
[5-netconf-doc-config] Updated netconf doc
Tomek Mrugalski [Tue, 16 Oct 2018 18:16:37 +0000 (20:16 +0200)]
[#5,!53] Updated user's guide after review.
Francis Dupont [Sun, 14 Oct 2018 17:24:19 +0000 (19:24 +0200)]
[5-netconf-doc-config] More about module change subscriptions
Francis Dupont [Sun, 14 Oct 2018 11:23:44 +0000 (13:23 +0200)]
[5-netconf-doc-config] Updated manual page
Francis Dupont [Sun, 14 Oct 2018 11:09:45 +0000 (13:09 +0200)]
[5-netconf-doc-config] Filled netconf agent doc
Thomas Markwalder [Tue, 16 Oct 2018 17:21:20 +0000 (13:21 -0400)]
[#101,!73] kea-dhcp4 can init CB backends based on config
src/bin/dhcp4/json_config_parser.*
databaseConfigConnect(const SrvConfigPtr& srv_cfg)
databaseConfigFetch(const SrvConfigPtr& srv_cfg, ElementPtr /*global_scope*/)
- new functions
configureDhcp4Server() - modified to call databaseConfigFetch() after
loading hook libs
src/bin/dhcp4/tests/config_parser_unittest.cc
TEST_F(Dhcp4ParserTest, configControlInfoNoFactory) - new test
TEST_F(Dhcp4ParserTest, configControlInfo) - modified to register
dummy backend
src/lib/dhcpsrv/testutils/test_config_backend_dhcp4.*
New files that implement DHPC4 dummy backend for testing
Francis Dupont [Tue, 16 Oct 2018 16:51:38 +0000 (18:51 +0200)]
[5-netconf-extend-syntax] Updated shell tests
Francis Dupont [Tue, 16 Oct 2018 16:43:45 +0000 (18:43 +0200)]
[5-netconf-extend-syntax] Merge branch '5-netconf-extend-syntax' of gitlab.isc.org:isc-projects/kea into 5-netconf-extend-syntax
Francis Dupont [Wed, 10 Oct 2018 10:22:10 +0000 (12:22 +0200)]
[5-netconf-extend-syntax] Extended syntax
Francis Dupont [Tue, 16 Oct 2018 16:39:13 +0000 (18:39 +0200)]
[master] [master] Update git hash
Francis Dupont [Tue, 16 Oct 2018 16:27:24 +0000 (18:27 +0200)]
[153-netconf-control-socket] Addressed review comments
Tomek Mrugalski [Tue, 16 Oct 2018 12:49:56 +0000 (14:49 +0200)]
[#153, !60] Minor changes after review.
Francis Dupont [Thu, 11 Oct 2018 13:58:33 +0000 (15:58 +0200)]
[153-netconf-control-socket] Fixes from Ubuntu
Francis Dupont [Sun, 7 Oct 2018 21:10:09 +0000 (23:10 +0200)]
[153-netconf-control-socket] Added control socket code from kea-yang
Francis Dupont [Sun, 7 Oct 2018 21:09:23 +0000 (23:09 +0200)]
[153-netconf-control-socket] Extended command
Francis Dupont [Tue, 16 Oct 2018 15:46:57 +0000 (17:46 +0200)]
[65-libyang-host_rebased] Addressed rebase conflicts
Francis Dupont [Tue, 16 Oct 2018 15:39:24 +0000 (17:39 +0200)]
[65-libyang-logger_rebased] Addressed rebase conflicts
Francis Dupont [Tue, 16 Oct 2018 15:35:50 +0000 (17:35 +0200)]
[65-libyang-pd-pool_rebased] Rebased after database translator merge
Tomek Mrugalski [Tue, 16 Oct 2018 13:29:52 +0000 (15:29 +0200)]
[#65,!28] Minor comment changes after review.
Francis Dupont [Sun, 14 Oct 2018 08:30:13 +0000 (10:30 +0200)]
[65-libyang-logger_rebased] Addressed rebase conflicts
Francis Dupont [Sun, 14 Oct 2018 08:26:26 +0000 (10:26 +0200)]
[65-libyang-database_rebased] Addressed rebase conflicts
Francis Dupont [Sun, 14 Oct 2018 08:22:52 +0000 (10:22 +0200)]
[65-libyang-host_rebased] Addressed rebase conflicts
Francis Dupont [Sun, 14 Oct 2018 08:17:32 +0000 (10:17 +0200)]
[65-libyang-pd-pool_rebased] Rebased after control socket merge
Francis Dupont [Sat, 13 Oct 2018 08:29:37 +0000 (10:29 +0200)]
[65-libyang-control-socket_rebase] Rebasing before merge
Francis Dupont [Sat, 13 Oct 2018 08:28:20 +0000 (10:28 +0200)]
[65-libyang-control-socket] Note that kea-dhcp-ddns server not yet support it
Thomas Markwalder [Fri, 12 Oct 2018 14:46:30 +0000 (10:46 -0400)]
[master] Added ConfigBackendDHCPv4Mgr
Merge branch '101-cb-add-two-step-configuration-to-the-dhcpv4-server'
Tomek Mrugalski [Fri, 12 Oct 2018 13:24:59 +0000 (15:24 +0200)]
[#65, !27] Minor comments connection.
Thomas Markwalder [Fri, 12 Oct 2018 13:24:49 +0000 (09:24 -0400)]
[#101,!58] Rebased for merge
modified: AUTHORS
modified: doc/guide/netconf.xml
modified: src/bin/netconf/netconf_controller.cc
modified: src/bin/netconf/netconf_controller.h
modified: src/lib/process/Makefile.am
deleted: src/share/database/scripts/mysql/dhcpdb_create.mysql.orig
deleted: src/share/database/scripts/mysql/upgrade_6.0_to_7.0.sh.in.orig
Franciszek Gorski [Fri, 12 Oct 2018 12:30:05 +0000 (14:30 +0200)]
[147-pid-files-dir-error] dhcp_data_dir added to Makefile.am
Thomas Markwalder [Thu, 11 Oct 2018 18:15:25 +0000 (14:15 -0400)]
[#101,!53] Addressed review comments
Thomas Markwalder [Wed, 10 Oct 2018 18:51:59 +0000 (14:51 -0400)]
[#101,!58] Implemented ConfigBackendDhcp4Mgr, mysql backend registers/unregisters
src/hooks/dhcp/mysql_cb/mysql_cb_callouts.cc
load() - added call to register MySQL backend
unload() - added call to unregister MySQL backend
src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.*
MySqlConfigBackendDHCPv4::registerBackendType()
MySqlConfigBackendDHCPv4::unregisterBackendType()
- new static methods for registering/unregistering
src/hooks/dhcp/mysql_cb/tests/Makefile.am
mysql_cb_dhcp4_mgr_unittest.cc - new file
src/lib/config_backend/base_config_backend_mgr.h
bool unregisterBackendFactory(const std::string& db_type)
- new method to unregister factory and delete backends
src/lib/config_backend/base_config_backend_pool.h
void delAllBackends(const std::string& db_type)
- new method to delete all backends of a given type
/src/lib/config_backend/tests/config_backend_mgr_unittest.cc
TEST_F(ConfigBackendMgrTest, unregister) - new test
src/lib/dhcpsrv/Makefile.am
src/lib/dhcpsrv/config_backend_dhcp4.h
src/lib/dhcpsrv/config_backend_dhcp4.cc
New files that implement ConfigBackendDhcp4Mgr
src/lib/dhcpsrv/config_backend_pool_dhcp4.h
Added missing public scope, removed pure virtual function
src/lib/eval/tests/Makefile.am
Added new dependency libkea-cc
Thomas Markwalder [Thu, 11 Oct 2018 18:15:25 +0000 (14:15 -0400)]
[#101,!58] Addressed review comments