]>
git.ipfire.org Git - thirdparty/kea.git/log
Francis Dupont [Tue, 19 Mar 2019 18:24:09 +0000 (19:24 +0100)]
[474-optionally-disable-collection-host-lookups] Addressed comments
Francis Dupont [Thu, 14 Mar 2019 10:43:47 +0000 (11:43 +0100)]
[474-optionally-disable-collection-host-lookups] Removed srandomdev
Francis Dupont [Wed, 27 Feb 2019 10:31:56 +0000 (11:31 +0100)]
[474-optionally-disable-collection-host-lookups] Added a host manager flag to disable getAll() in alloc engine
Francis Dupont [Sun, 17 Mar 2019 09:16:42 +0000 (10:16 +0100)]
[481-er-foreign-duplicate-key-with-child-info] Completed duplicate foreign key errors
Francis Dupont [Fri, 15 Mar 2019 23:00:39 +0000 (00:00 +0100)]
[481-er-foreign-duplicate-key-with-child-info] Made ER_FOREIGN_DUPLICATE_KEY_WITH_CHILD_INFO optional
Michal Nowikowski [Tue, 19 Mar 2019 17:05:45 +0000 (18:05 +0100)]
hammer: added note to hammer guide about ccache limitation to lxc only
Michal Nowikowski [Fri, 15 Mar 2019 14:38:03 +0000 (15:38 +0100)]
added description of ccache feature in hammer in user guide
Michal Nowikowski [Thu, 14 Mar 2019 15:37:12 +0000 (16:37 +0100)]
added CCache support to Hammer
Thomas Markwalder [Mon, 18 Mar 2019 19:37:18 +0000 (15:37 -0400)]
[master] Added entry 1546.
Thomas Markwalder [Mon, 18 Mar 2019 19:36:04 +0000 (15:36 -0400)]
[master] kea-dhcp4 uses options from config backends
Merge branch '401-merge-dhcpv4-options-fetched-from-the-cb-into-the-configuration'
Thomas Markwalder [Mon, 18 Mar 2019 18:31:42 +0000 (14:31 -0400)]
[#401,!254] Further review work.
Removed use of Option::toText from tests:
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, replace)
TEST_F(CfgOptionTest, mergeTo)
TEST_F(CfgOptionTest, createDescriptorOptionValid)
src/lib/dhcpsrv/tests/cfg_subnets4_unittest.cc
TEST(CfgSubnets4Test, mergeSubnets)
Marcin Siodelski [Mon, 18 Mar 2019 16:31:58 +0000 (17:31 +0100)]
[#401,!254] Added space in the error message.
Thomas Markwalder [Mon, 18 Mar 2019 15:30:05 +0000 (11:30 -0400)]
[#401,!254] Addressed more review comments.
Marcin Siodelski [Mon, 18 Mar 2019 11:51:04 +0000 (12:51 +0100)]
[#401,!254] Use three slashes between todo in the SrvConfig.
Francis Dupont [Mon, 18 Mar 2019 10:16:03 +0000 (11:16 +0100)]
[master] Added a ChangeLog entry for data-directory
Francis Dupont [Fri, 15 Mar 2019 23:50:41 +0000 (00:50 +0100)]
[430-configure-location-of-datadir] Fixed another post rebase issue
Francis Dupont [Fri, 15 Mar 2019 23:48:45 +0000 (00:48 +0100)]
[430-configure-location-of-datadir] Better clear in CfgMgrTest
Francis Dupont [Fri, 15 Mar 2019 23:29:39 +0000 (23:29 +0000)]
[#430,!263] regen bison
Francis Dupont [Fri, 15 Mar 2019 23:26:09 +0000 (00:26 +0100)]
[430-configure-location-of-datadir] Updated keywords list
Francis Dupont [Fri, 15 Mar 2019 23:20:34 +0000 (00:20 +0100)]
[430-configure-location-of-datadir] Added some unit tests
Francis Dupont [Fri, 15 Mar 2019 22:31:36 +0000 (23:31 +0100)]
[430-configure-location-of-datadir] Fixed quotes in data-directory example
Francis Dupont [Mon, 11 Mar 2019 17:15:07 +0000 (18:15 +0100)]
[430-configure-location-of-datadir] Reverted to CfgMgr. Made Optional
Francis Dupont [Mon, 11 Mar 2019 15:01:04 +0000 (16:01 +0100)]
[430-configure-location-of-datadir] Forked all-keys.json files into stable and current versions
Francis Dupont [Mon, 11 Mar 2019 13:22:22 +0000 (14:22 +0100)]
[430-configure-location-of-datadir] Do not export data-directory tests
Francis Dupont [Wed, 6 Mar 2019 17:34:22 +0000 (18:34 +0100)]
[430-configure-location-of-datadir] Moved datadir to server config and use it for v6
Francis Dupont [Wed, 6 Mar 2019 11:45:07 +0000 (11:45 +0000)]
[#480,!263] regen flex/bison
Francis Dupont [Wed, 6 Mar 2019 11:39:27 +0000 (12:39 +0100)]
[430-configure-location-of-datadir] Extended syntax
Thomas Markwalder [Fri, 15 Mar 2019 14:34:38 +0000 (10:34 -0400)]
[#401,!254] Implemented CfgOption::replace
src/lib/dhcpsrv/cfg_option.*
CfgOption::replace() - new method to update an OptionDescriptor
CfgOption::createDescriptorOption() - new returns a bool indicating
whether or not the option_ instance was replaced
Thomas Markwalder [Fri, 15 Mar 2019 12:26:35 +0000 (08:26 -0400)]
[#401,!254] Options are now created when merging subnets
src/lib/dhcpsrv/cfg_subnets4.*
CfgSubnets4::merge() - added cfg_def, now
creates options for each subnet and their pools.
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4() - passes merged option defs
into subnets merge.
src/lib/dhcpsrv/subnet.h
Subnet::getPoolsWritable() - changed to public.
Thomas Markwalder [Thu, 14 Mar 2019 17:54:41 +0000 (13:54 -0400)]
[#401,!254] Options are now created when merging shared-network4s
src/lib/dhcpsrv/cfg_option.*
CfgOption::createOptions(CfgOptionDefPtr cfg_def) -
new function which creates options for all of a cfg's
descriptors
CfgOption::merge() - calls createOptions()
src/lib/dhcpsrv/cfg_shared_networks.*
CfgSharedNetworks4::merge() - added cfg_def parameter and
call to populate the "other" networks' options
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4() - passes merged option definitions
into shared network merge.
Marcin Siodelski [Mon, 11 Mar 2019 13:57:58 +0000 (14:57 +0100)]
[#521,!270] Addressed review comments.
Marcin Siodelski [Mon, 11 Mar 2019 10:42:16 +0000 (11:42 +0100)]
[#521,!270] Updated unit tests comment.
Marcin Siodelski [Mon, 11 Mar 2019 10:15:48 +0000 (11:15 +0100)]
[#521,!270] Removed dependency of the MySQL CB on LibDHCP option defs.
Francis Dupont [Wed, 13 Mar 2019 13:26:45 +0000 (14:26 +0100)]
[master] Added ChangeLog entry for --enable-generate-messages
Tomek Mrugalski [Tue, 12 Mar 2019 20:10:41 +0000 (21:10 +0100)]
[#441,!233] Cosmetic change in config.report
Francis Dupont [Tue, 5 Mar 2019 14:14:47 +0000 (15:14 +0100)]
[441-make-distcheck-fails-on-fedora-29-automake-1-16] Fixed some paths
Francis Dupont [Tue, 5 Mar 2019 13:23:43 +0000 (14:23 +0100)]
[441-make-distcheck-fails-on-fedora-29-automake-1-16] Some updates
Francis Dupont [Sat, 9 Feb 2019 00:47:45 +0000 (01:47 +0100)]
[441-make-distcheck-fails-on-fedora-29-automake-1-16] Second attempt to fix automake 1.16 issue; distribute generated file
Francis Dupont [Wed, 13 Mar 2019 10:47:56 +0000 (11:47 +0100)]
[master] Fixed #481 merge error
Francis Dupont [Wed, 13 Mar 2019 10:13:08 +0000 (11:13 +0100)]
[master] Added ChangeLog entry for subnet update by ID or prefix
Marcin Siodelski [Tue, 12 Mar 2019 15:22:05 +0000 (16:22 +0100)]
[#481,!251] Fixed failing unit test as a result of review.
Francis Dupont [Tue, 12 Mar 2019 14:04:29 +0000 (15:04 +0100)]
[481-remote-subnet4-set-inconsistent-work-when-id-subnet-is-duplicated] Addressed comments
Francis Dupont [Fri, 1 Mar 2019 22:55:36 +0000 (23:55 +0100)]
[481-remote-subnet4-set-inconsistent-work-when-id-subnet-is-duplicated] Added tests and updated schema
Francis Dupont [Fri, 1 Mar 2019 13:46:16 +0000 (14:46 +0100)]
[481-remote-subnet4-set-inconsistent-work-when-id-subnet-is-duplicated] Applied Marcin's proposal
Thomas Markwalder [Tue, 12 Mar 2019 19:24:27 +0000 (15:24 -0400)]
[master] Added ChangeLog entry 1542.
Thomas Markwalder [Tue, 12 Mar 2019 19:22:57 +0000 (15:22 -0400)]
[master] MySQL and CQL unit tests now wipe data only by default
Merge branch '526-improve-mysql-unit-test-time'
Thomas Markwalder [Tue, 12 Mar 2019 18:55:17 +0000 (14:55 -0400)]
[#526,!269] Final review changes
Thomas Markwalder [Tue, 12 Mar 2019 17:01:24 +0000 (13:01 -0400)]
[#526,!269] Updated developer's guide.
doc/devel/unit-tests.dox - added
discussion of the env var.
Thomas Markwalder [Tue, 12 Mar 2019 15:52:37 +0000 (11:52 -0400)]
[#526,!269] More clean up
General clean up, changed CQL params to be same order as MySQL.
Francis Dupont [Tue, 12 Mar 2019 15:08:16 +0000 (16:08 +0100)]
[master] Added #510 in RAI fix ChangeLog entry
Thomas Markwalder [Tue, 12 Mar 2019 14:47:57 +0000 (10:47 -0400)]
[#526,!269] Added env var control and CQL symmetry
Data wiping is on by default, for both MySQL and CQL
(not yet implemented for Postgresql) and but can be
overridden by KEA_TEST_DB_WIPE_DATA_ONLY.
src/lib/mysql/testutils/mysql_schema.*
destroyMySQLSchema()
createMySQLSchema() - added check of softWipeEnabled() to
see if env var has turned it OFF.
Changed CQL to work the same way as MySQL:
src/share/database/scripts/cql
wipe_data.sh.in - new file, replaces soft_wipe.cql
src/lib/cql/testutils/cql_schema.*
destroyCqlSchema() - now destroys the schema
if data wipe fails or is disabled
createCqlSchema() - now drops/creates the schema
if data wipe fails or is disabled.
runCqlScript(() - added request-timeout to prevent
timeout errors in slow environments
wipeCqlData(bool show_err) - new function that
attempts to run the wipe shell script
src/lib/dhcpsrv/tests/cql_lease_mgr_unittest.cc
Removed now superflous destroyCqlSchema calls
Francis Dupont [Tue, 12 Mar 2019 09:18:43 +0000 (10:18 +0100)]
[512-fix-TestConfigBackendDHCPv4-deleteSharedNetworkSubnets4] Added a call to delAll() to detach subnets where deleting a shared network
Francis Dupont [Sat, 9 Mar 2019 18:24:07 +0000 (19:24 +0100)]
[519-dhcp-server-response-an-empty-rai-field] Added the bad RAI case
Thomas Markwalder [Mon, 11 Mar 2019 17:50:00 +0000 (13:50 -0400)]
[#526,!269] Addressed more review comments
src/lib/cql/testutils/cql_schema.*
Modified to use common softWipeEnabled(), which
defaults to true
src/lib/database/testutils/schema.*
bool softWipeEnabled() - new function that checks
env varible to determine if DB data wiping is enabled
(default is true/enabled)
src/lib/mysql/testutils/mysql_schema.*
createMySQLSchema()
destroyMySQLSchema()- now softWipeEnabled() to allow
data wiping to be turned on/off
src/share/database/scripts/mysql/wipe_data.sh.in
Added better error messaging
several files:
Removed extraneous calls to destroyMySQLSchema, added
comments
Francis Dupont [Mon, 11 Mar 2019 15:45:07 +0000 (16:45 +0100)]
[master] Added ChangeLog entry for deleteSharedNetworkSubnets4
Francis Dupont [Sat, 9 Mar 2019 00:18:32 +0000 (01:18 +0100)]
[512-remote-network4-del-update] spurious space
Francis Dupont [Sat, 2 Mar 2019 19:16:00 +0000 (20:16 +0100)]
[512-remote-network4-del-update] Added deleteSharedNetworkSubnets4 support
Francis Dupont [Mon, 11 Mar 2019 15:28:41 +0000 (16:28 +0100)]
[master] Added ChangeLog entry dns++.pc removal
Francis Dupont [Sun, 10 Mar 2019 15:55:38 +0000 (16:55 +0100)]
[498-pkg-config-usage-in-kea-libs-is-wrong] Got rid of dns++.pc
Francis Dupont [Mon, 11 Mar 2019 13:07:38 +0000 (13:07 +0000)]
[master] regen all bison files
Francis Dupont [Wed, 6 Mar 2019 18:36:35 +0000 (19:36 +0100)]
[486-no-longer-use-bison-is-yacc-emulation-mode] Changed from AC_PROG_YACC
Francis Dupont [Wed, 6 Mar 2019 17:48:21 +0000 (18:48 +0100)]
[486-no-longer-use-bison-is-yacc-emulation-mode] Improved LEX check
Thomas Markwalder [Sat, 9 Mar 2019 00:37:26 +0000 (19:37 -0500)]
Merge branch '401-merge-dhcpv4-options-fetched-from-the-cb-into-the-configuration' of gitlab.isc.org:isc-projects/kea into 401-merge-dhcpv4-options-fetched-from-the-cb-into-the-configuration
Thomas Markwalder [Fri, 8 Mar 2019 21:39:19 +0000 (16:39 -0500)]
[#401,!24] Addressed most review comments
This commit addresse the more trivial review
comments, it does not include option creation
for networks,subnets, or pools.
Will rebase and address remaining comments.
Thomas Markwalder [Wed, 6 Mar 2019 18:26:01 +0000 (13:26 -0500)]
[#401,!254] kea-dhcp4 now merges in options from config backend
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge() - new function which merges a given set
of option descriports into the existing set
CfgOption::createDescriptorOption - new function that uses an
option definition factory to create a descriptor's option instance
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, validMerge)
TEST_F(CfgOptionTest, invalidMerge) - new tests
Thomas Markwalder [Mon, 4 Mar 2019 15:54:53 +0000 (10:54 -0500)]
[#401,!254] kea-dhcp4 now merges CB options into current config
Basic merging works, need to add validation against definitions.
src/bin/dhcp4/tests/config_backend_unittest.cc
TEST_F(Dhcp4CBTest, mergeOptions) - enabled and updated
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge(CfgOption& other) - new method, conformant
to others, that merges/updates a config option from another
src/lib/dhcpsrv/srv_config.cc
SrvConfig::merge4(SrvConfig& other) - modified to
merge configured options
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, merge) - new test
Thomas Markwalder [Fri, 8 Mar 2019 21:39:19 +0000 (16:39 -0500)]
[#401,!24] Addressed most review comments
This commit addresse the more trivial review
comments, it does not include option creation
for networks,subnets, or pools.
Will rebase and address remaining comments.
Thomas Markwalder [Fri, 8 Mar 2019 17:06:38 +0000 (12:06 -0500)]
[#526,!269] - MySQL unit tests now wipe data, instead of schema
src/share/database/scripts/mysql/wipe_data.sh.in -
New shell script which intelligently deletes data from
the schema IF the schema version matches the expected version
src/lib/mysql/testutils/mysql_schema.*
destroyMySQLSchema() - modfied to default to calling
wipeData(), and only destroying the schema if that fails
or by force flag = true;
createMySQLSchema() - modified to default to calling
wipeData(), and only recreating the schema if that
fails or by force flag = true;
wipeData() - new method which runs the
MySQL wipe_data.sh shell script, passing in the expected
schema version.
src/share/database/scripts/mysql/dhcpdb_create.mysql
createAuditRevisionDHCP4()
createAuditEntryDHCP4()
createAuditRevisionDHCP6()
createAuditEntryDHCP6() - added session variable,
@disable_audit, to allow procedures to be "turned
off" during data wiping.
src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_mgr_unittest.cc
src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
src/lib/dhcpsrv/tests/cfg_db_access_unittest.cc
src/lib/dhcpsrv/tests/host_mgr_unittest.cc
src/lib/dhcpsrv/tests/mysql_host_data_source_unittest.cc
src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
Removed calls to destroy schema from test constructors
Francis Dupont [Sat, 2 Mar 2019 02:12:59 +0000 (03:12 +0100)]
[499-global-keywords-entries] Added global parameter lists
Marcin Siodelski [Thu, 7 Mar 2019 13:51:45 +0000 (14:51 +0100)]
[master] Added ChangeLog entry for #488.
Marcin Siodelski [Wed, 6 Mar 2019 16:29:53 +0000 (17:29 +0100)]
[#488,!259] Updated get_config_unittests for v4.
Marcin Siodelski [Wed, 6 Mar 2019 15:47:00 +0000 (16:47 +0100)]
[#488,!259] Parse siaddr, sname and boot-file-name in shared network parser.
Marcin Siodelski [Wed, 6 Mar 2019 15:44:29 +0000 (16:44 +0100)]
[#488,!259] Rename parameters in the base network parser.
Marcin Siodelski [Wed, 6 Mar 2019 15:44:07 +0000 (16:44 +0100)]
[#488,!259] Test authoritative flag in MySQL CB.
Marcin Siodelski [Wed, 6 Mar 2019 13:31:55 +0000 (14:31 +0100)]
[#488,!259] Added support for boot file, next_server and sname to MySQL CB.
Marcin Siodelski [Wed, 6 Mar 2019 11:26:36 +0000 (12:26 +0100)]
[#488,!259] Added sname, next-server and boot-file-name to MySQL schema.
Marcin Siodelski [Wed, 6 Mar 2019 11:15:04 +0000 (12:15 +0100)]
[#488,!259] Subnet's and Network's toElement do not output optionals.
Marcin Siodelski [Wed, 6 Mar 2019 08:10:19 +0000 (09:10 +0100)]
[#488,!259] Extracted common parsing functions to a new class.
Marcin Siodelski [Tue, 5 Mar 2019 19:43:24 +0000 (20:43 +0100)]
[#488,!259] Regenerated get_config_unittests for v4 and corrected issues.
Marcin Siodelski [Tue, 5 Mar 2019 11:03:45 +0000 (12:03 +0100)]
[#488,!259] Correct unit tests failing after recent code updates.
Marcin Siodelski [Mon, 4 Mar 2019 19:06:04 +0000 (20:06 +0100)]
[#488,!259] Added support for authoritative flag in MySQL CB.
Marcin Siodelski [Mon, 4 Mar 2019 17:33:54 +0000 (18:33 +0100)]
[#488] Shared network parser stores parsed parameters in the object.
Marcin Siodelski [Mon, 4 Mar 2019 11:02:39 +0000 (12:02 +0100)]
[#488] DHCP subnet and network parsers allow unspecified parameters.
Marcin Siodelski [Thu, 7 Mar 2019 12:59:24 +0000 (13:59 +0100)]
[master] Removed trailing comma in the default kea-dhcp-ddns config.
Okayed on jabber.
Michal Nowikowski [Thu, 7 Mar 2019 11:18:03 +0000 (12:18 +0100)]
improved Sandbox class comments
Michal Nowikowski [Thu, 7 Mar 2019 11:08:16 +0000 (12:08 +0100)]
removed unnecessary includes
Marcin Siodelski [Thu, 7 Mar 2019 10:52:08 +0000 (11:52 +0100)]
[#357,!258] Added space after return.
Michal Nowikowski [Thu, 7 Mar 2019 09:56:14 +0000 (10:56 +0100)]
replaced throwing exception in destructor with a trace and exit(1)
Michal Nowikowski [Thu, 7 Mar 2019 09:30:08 +0000 (10:30 +0100)]
changes after review: updated comments and did other small improvements
Michal Nowikowski [Tue, 5 Mar 2019 05:40:15 +0000 (06:40 +0100)]
Changed location of unit socket in unit tests
Previously it was stored in TEST_DATA_BUILDDIR which resides inside repo sources.
Due to the fact that when repo was located in deep patch creating socket was
failing as max socket patch is about 100 characters. Now it is located
in temp folder managed by Sandbox class. The sandbox directory is created
in test constructor and deleted in destructor. As the temp directory
is in form /tmp/kea-XXXXXX the lnegth is always lower than 1000, so running
the unit tests never fails.
Francis Dupont [Wed, 6 Mar 2019 20:24:38 +0000 (21:24 +0100)]
[478-improve-error-message-database-backend-mysql] Reviewed changes and addressed comments
Tomek Mrugalski [Wed, 6 Mar 2019 18:46:59 +0000 (19:46 +0100)]
[#478,!249] Added extra log error message.
Francis Dupont [Thu, 28 Feb 2019 14:44:55 +0000 (15:44 +0100)]
[478-improve-error-message-database-backend-mysql] Better message for not built lease database type
Thomas Markwalder [Wed, 6 Mar 2019 18:26:01 +0000 (13:26 -0500)]
[#401,!254] kea-dhcp4 now merges in options from config backend
src/lib/dhcpsrv/cfg_option.*
CfgOption::merge() - new function which merges a given set
of option descriports into the existing set
CfgOption::createDescriptorOption - new function that uses an
option definition factory to create a descriptor's option instance
src/lib/dhcpsrv/tests/cfg_option_unittest.cc
TEST_F(CfgOptionTest, validMerge)
TEST_F(CfgOptionTest, invalidMerge) - new tests
Tomek Mrugalski [Wed, 6 Mar 2019 11:42:30 +0000 (12:42 +0100)]
[#471] Hammer docs updated
Tomek Mrugalski [Wed, 6 Mar 2019 14:18:53 +0000 (15:18 +0100)]
[#480] ChangeLog updated
Francis Dupont [Wed, 6 Mar 2019 12:10:54 +0000 (13:10 +0100)]
[480-shellcheck] Addressed SC2231 extra warnings
Tomek Mrugalski [Wed, 6 Mar 2019 11:23:19 +0000 (12:23 +0100)]
Fixed execution of find command
Tomek Mrugalski [Wed, 6 Mar 2019 11:09:52 +0000 (12:09 +0100)]
! -z replaced with -n
Tomek Mrugalski [Wed, 6 Mar 2019 11:09:34 +0000 (12:09 +0100)]
Removed SC2046 disables and added nested double quotes instead.