Merge pull request #4554 from facebook/no_legacy

Remove legacy support by default

Merge pull request #4555 from facebook/fix4553

Fix #4553

test: fix versionsTest build for old zstd versions

Summary:
Some old zstd versions (notably v0.6.x) have a bug in fileio.c where header includes check for `ZSTD_LEGACY_SUPPORT==1` but code usage checks for `ZSTD_LEGACY_SUPPORT>=1`. Using value 5 causes compilation failure because headers aren't included but the code tries to use legacy functions.

Changing to `ZSTD_LEGACY_SUPPORT=1` for old version builds fixes the compilation while still enabling legacy format support.

Test Plan:
Run `make versionsTest` or `python3 tests/test-zstd-versions.py` to verify all old versions compile and cross-version decompression works correctly.

Fix #4553

This is a bug in the streaming implementation of the v0.5 decoder.
The bug has always been there.
It requires an uncommon block configuration, which wasn't tested at the time.

v0.5 is deprecated now,
latest version to produce such format is v0.5.1 from February 2016.
It was superceded in April 2016.
So it's both short lived and very old.

Another PR will remove support of this format,
but it will still be possible to explicitely request this support on demand,
so better fix the issue.

test: enable legacy support in version compatibility test

Summary:
The version compatibility test needs to decode legacy frames (v0.5.x - v0.7.x) to verify cross-version interoperability. Since legacy support is now disabled by default (v1.6.0), head must be built with ZSTD_LEGACY_SUPPORT=5 for this test.

Test Plan:
Run `python3 tests/test-zstd-versions.py` to verify cross-version compatibility testing works correctly.

test: update libzstd_builds.sh for disabled legacy default

Summary:
Updates the library build tests to reflect that legacy format support is now disabled by default. Also adds a new test case to verify that legacy support can still be explicitly enabled via ZSTD_LEGACY_SUPPORT=5.

Test Plan:
Run `bash tests/libzstd_builds.sh` on a Linux environment.

build: set ZSTD_LEGACY_SUPPORT=0 in remaining build systems

Summary:
Completes the transition to disabled legacy support by default across all build systems. This follows up on the previous Makefile and CMake changes to ensure consistent default behavior regardless of the build system used.

Updated build configurations: Meson, tests/Makefile, Visual Studio 2008/2010 projects, and BUCK.

Test Plan:
Verified changes compile correctly via `make lib-release`. Build system configurations have been updated consistently across all platforms.

doc: legacy support is now disabled by default

update dev version number to v1.6.0

to reflect the relatively big scope change by removing support of legacy formats.

[cmake] disable legacy support by default

can still be explicitly enabled

Makefile: remove support of legacy formats by default

can still be changed manually by setting `ZSTD_LEGACY_SUPPORT` to a different value

Merge pull request #4545 from facebook/cirrusci_bsd_fix

[ci] update freebsd image

changed to freebsd 15

since the image 16 does not seem to work

Merge pull request #4551 from facebook/dependabot/github_actions/actions/upload-artifact-6.0.0

Bump actions/upload-artifact from 5.0.0 to 6.0.0

Merge pull request #4552 from facebook/dependabot/github_actions/actions/cache-5

Bump actions/cache from 4 to 5

Merge pull request #4550 from facebook/dependabot/github_actions/msys2/setup-msys2-2.30.0

Bump msys2/setup-msys2 from 2.29.0 to 2.30.0

Bump actions/cache from 4 to 5

Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump actions/upload-artifact from 5.0.0 to 6.0.0

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump msys2/setup-msys2 from 2.29.0 to 2.30.0

Bumps [msys2/setup-msys2](https://github.com/msys2/setup-msys2) from 2.29.0 to 2.30.0.
- [Release notes](https://github.com/msys2/setup-msys2/releases)
- [Changelog](https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md)
- [Commits](https://github.com/msys2/setup-msys2/compare/fb197b72ce45fb24f17bf3f807a388985654d1f2...4f806de0a5a7294ffabaff804b38a9b435a73bda)

---
updated-dependencies:
- dependency-name: msys2/setup-msys2
  dependency-version: 2.30.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4544 from facebook/dependabot/github_actions/actions/setup-java-5.1.0

Bump actions/setup-java from 5.0.0 to 5.1.0

[ci] update freebsd image

Bump actions/setup-java from 5.0.0 to 5.1.0

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/dded0888837ed1f317902acf8a20df0ad188d165...f2beeb24e141e01a676f977032f5a29d81c9e27e)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4543 from facebook/dependabot/github_actions/actions/checkout-6.0.1

Bump actions/checkout from 6.0.0 to 6.0.1

Bump actions/checkout from 6.0.0 to 6.0.1

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v6...v6.0.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4525 from Polaris-911/new-feature

Add RISC-V 64-bit architecture detection

Merge pull request #4531 from lukaskollmer/lukas/fix-swift-build

modulemap: remove `config_macros`

Merge pull request #4494 from LecrisUT/maint-cmake

Split lib target types in their own export groups

modulemap: remove `config_macros`

Merge pull request #4529 from facebook/dependabot/github_actions/actions/checkout-6.0.0

Bump actions/checkout from 5.0.0 to 6.0.0

Bump actions/checkout from 5.0.0 to 6.0.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Commits](https://github.com/actions/checkout/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4522 from facebook/dependabot/github_actions/github/codeql-action-4.31.2

Bump github/codeql-action from 3.30.1 to 4.31.2

Add RISC-V 64-bit architecture detection

Bump github/codeql-action from 3.30.1 to 4.31.2

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.1 to 4.31.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f1f6e5f6af878fb37288ce1c627459e94dbf7d01...0499de31b99561a6d14a36a5f662c2a54f91beee)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4519 from facebook/dependabot/github_actions/actions/upload-artifact-5

Bump actions/upload-artifact from 4 to 5

Bump actions/upload-artifact from 4 to 5

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4491 from facebook/cmake_root

[cmake] propose a root wrapper

Merge pull request #4517 from Cyan4973/asyncio_revisit

Remove asyncio from the compression path

syncio interface only enabled when compression is enabled

changed name to syncIO for clarity

minor: use init/destroy pair naming convention

removed asyncio completely for compression path

this does not provide speed benefits,
since most of the leverage happens internally within the library,
and can even become detrimental in certain scenario, due to complex and wasteful memory management.
At a minimum, it makes the logic simpler, easier to debug, at essentially the same performance.

disable asyncio during compression

it's not helpful for performance, and can in some times be detrimental.
the synchronous mode is also much easier to follow and debug.

Merge pull request #4515 from cclauss/patch-1

Fix undefined names in automated_benchmarking.py

Fix undefined names in automated_benchmarking.py

Fix variable name typos in automated_benchmarking.py

% `ruff check`
```
Error: tests/automated_benchmarking.py:237:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:250:21: F821 Undefined name `baseline_label`
Error: tests/automated_benchmarking.py:318:55: F821 Undefined name `frequenc`
Error: Process completed with exit code 1.
```
% [`ruff rule F821`](https://docs.astral.sh/ruff/rules/undefined-name)

Merge pull request #4516 from Cyan4973/mingw_calloc_order

minor: fix mingw warnings: calloc argument order

minor: fix mingw warnings: calloc argument order

Merge pull request #4509 from arpadpanyik-arm/revert_branch_opt

AArch64: Revert previous branch optimization

AArch64: Remove 32-bit code from ZSTD_decodeSequence

Remove the 32-bit code paths from the AArch64 only sections of
ZSTD_decodeSequence.

AArch64: Revert previous branch optimization

Revert a branch optimization that was based on an incorrect
assumption in the AArch64 part of ZSTD_decodeSequence. In extreme
cases the existing implementation could lead to data corruption.

Insert an UNLIKELY hint to guide the compilers toward generating more
efficient machine code.

Merge pull request #4504 from rzikm/asm-conditional

Make ASM language conditional at CMake configure time

Enable ASM language during CMake configure time only when needed

Merge pull request #4502 from zijianli1234/dev

- Modify the GCC version used for CI testing of the RISCV architecture

- Modify the GCC version used for CI testing of the RISCV architecture
- Fix a bug in the ZSTD_row_getRVVMask function
- Improve some performance for ZSTD_copy16()

[cmake] add minimal build test

for CMakeLists.txt at root

[cmake] root wrapper

allow the existence of a `CMakeLists.txt` file at root,
for easier integration with other projects expecting this file at root.

Existing integration point, within `build/cmake/`, still works as expected.

Merge pull request #4500 from facebook/legacy01_init

fix minor initialization warnings

fix minor initialization warnings

Merge pull request #4498 from facebook/contentSize_doc

update documentation of ZSTD_getFrameContentSize()

update documentation of ZSTD_getFrameContentSize()

hopefully answering #4495

Merge pull request #4497 from facebook/legacy_fix

fix minor warning in legacy decoders

fix minor warning in legacy decoders

for mingw + clang CI test

Split lib target types in their own export groups

This allows for the non-primary library to be missing in the Config.cmake file, e.g. if the devel files have a separate static-devel package

Signed-off-by: Cristian Le <git@lecris.dev>

Merge pull request #4490 from facebook/doc_profiling_vs

minor: add profiling notes for Visual Studio

added profiling notes for Visual Studio

Merge pull request #4489 from facebook/doc_install

Added documentation details for Makefile installation and pkg-config.

Added documentation details for Makefile installation and pkg-config.

Merge pull request #4486 from rlefko/fix-pthread-init-memleak

Fix memory leak in pthread init functions on failure

Merge pull request #4487 from neiljohari/adhoc/dictionary-file-counting

make DiB_fileStats skip invalid files (fileSize <= 0) to prevent negative totals and bogus allocation

Merge pull request #4481 from w1m024/support-rvv-getmask

add RVV optimization for ZSTD_row_getMatchMask

Remove debug logging

Fix bug

Add debug logging and simple repro

🔧 Fix memory leak in pthread init functions on failure

When pthread_mutex_init() or pthread_cond_init() fails in the debug
implementation (DEBUGLEVEL >= 1), the previously allocated memory was
not freed, causing a memory leak.

This fix ensures that allocated memory is properly freed when pthread
initialization functions fail, preventing resource leaks in error
conditions.

The issue affects:
- ZSTD_pthread_mutex_init() at lib/common/threading.c:146
- ZSTD_pthread_cond_init() at lib/common/threading.c:167

This is particularly important for long-running applications or
scenarios with resource constraints where pthread initialization
might fail due to system limits.

Refactor ZSTD_row_getMatchMask for RVV optimization

Performance (vs. SWAR)
- 16-byte data: 5.87x speedup
- 32-byte data: 9.63x speedup
- 64-byte data: 17.98x speedup

Co-authored-by: gong-flying <gongxiaofei24@iscas.ac.cn>

add RVV optimization for ZSTD_row_getMatchMask

Co-authored-by: gong-flying <gongxiaofei24@iscas.ac.cn>

Merge pull request #4480 from facebook/dependabot/github_actions/github/codeql-action-3.30.1

Bump github/codeql-action from 3.29.4 to 3.30.1

Merge pull request #4479 from facebook/dependabot/github_actions/msys2/setup-msys2-2.29.0

Bump msys2/setup-msys2 from 2.28.0 to 2.29.0

Bump github/codeql-action from 3.29.4 to 3.30.1

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.4 to 3.30.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/4e828ff8d448a8a6e532957b1811f387a63867e8...f1f6e5f6af878fb37288ce1c627459e94dbf7d01)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump msys2/setup-msys2 from 2.28.0 to 2.29.0

Bumps [msys2/setup-msys2](https://github.com/msys2/setup-msys2) from 2.28.0 to 2.29.0.
- [Release notes](https://github.com/msys2/setup-msys2/releases)
- [Changelog](https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md)
- [Commits](https://github.com/msys2/setup-msys2/compare/40677d36a502eb2cf0fb808cc9dec31bf6152638...fb197b72ce45fb24f17bf3f807a388985654d1f2)

---
updated-dependencies:
- dependency-name: msys2/setup-msys2
  dependency-version: 2.29.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4472 from bgilbert/override_dependency

meson: Call `meson.override_dependency()` if Meson is new enough

Merge pull request #4475 from Cyan4973/default_nbThreads

Default nb threads

fixed minor unused variable warning

in certain compilation modes

benchmark uses 1 thread by default

only display nbThread Msg in nbThreads > 1

specify nb of threads used during benchmarking

used to require `-v` (verbose) modifier

fixed -T# documentation in zstd -H

provide the local value for default nbThreads
which is dynamic and depends on local nb of cores.

Merge pull request #4474 from jlokier/threads-doc-fix

Update manual about the default value of `-T#`/`--threads=#`

Update manual about the default value of `-T#`/`--threads=#`

The section about `ZSTD_NBTHREADS` already explains the default number of
threads, since it changed from 1 (commit 17beeb5).  But the option description
for `-T#`/`--threads=#` incorrectly said the default was still 1.

I noticed this when I found compression slower with `-T1` than without it.

meson: Call meson.override_dependency() if Meson is new enough

This tells Meson that we intend libzstd_dep to be used by a parent project
if the parent looks for a dependency named "libzstd".  Without this, the
mapping from "libzstd" to our variable libzstd_dep must be encoded in the
Meson wrap file or in the parent's meson.build.

Merge pull request #4469 from facebook/dependabot/github_actions/actions/setup-java-5.0.0

Bump actions/setup-java from 4.7.1 to 5.0.0

Bump actions/setup-java from 4.7.1 to 5.0.0

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/c5195efecf7bdfc987ee8bae7a71cb8b11521c00...dded0888837ed1f317902acf8a20df0ad188d165)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #4440 from arpadpanyik-arm/convert_seq_sve2

AArch64: Add SVE2 path for convertSequences_noRepcodes

AArch64: Add SVE2 path for convertSequences_noRepcodes

Add an 8-way vector length agnostic (VLA) SVE2 code path for
convertSequences_noRepcodes. It works with any SVE vector length.

Relative performance to GCC-13 using: `./fullbench -b18 -l5 enwik5`

               Neon      SVE2
Neoverse-V2   before     after    uplift
GCC-13:      100.000%  103.209%   1.032x
GCC-14:      100.309%  134.872%   1.344x
GCC-15:      100.355%  134.827%   1.343x
Clang-18:    123.614%  128.565%   1.040x
Clang-19:    123.587%  132.984%   1.076x
Clang-20:    123.629%  133.023%   1.075x

               Neon      SVE2
Cortex-A720   before     after    uplift
GCC-13:      100.000%  116.032%   1.160x
GCC-14:       99.700%  116.648%   1.169x
GCC-15:      100.354%  117.047%   1.166x
Clang-18:    100.447%  116.762%   1.162x
Clang-19:    100.454%  116.627%   1.160x
Clang-20:    100.452%  116.649%   1.161x

Merge pull request #4463 from brad0/gnu_source_qsort

Check for build environment instead of just _GNU_SOURCE

Merge pull request #4465 from thiru-mcw/arm64_support

WOA_support:: Add CI setup for packaging Windows on ARM artifacts

CI: Enable MSVC ARM64 job using Github WOA runner

- Reintroduce the MSVC ARM64 build configuration with "Visual Studio 17 2022"
- Update runner to `windows-11-arm` (GitHub-hosted Windows on ARM)

CI: Add CI setup for packaging Win-ARM64 artifacts

CI: Update build_package.bat for CMake builds

Merge pull request #4464 from facebook/cli_traces_div0

fixed a potential division by 0 in the cli trace unit

fixed a potential division by 0 in the cli trace unit