]> git.ipfire.org Git - thirdparty/libtool.git/log
thirdparty/libtool.git
12 years agotests: simplify some shell code. gary/reredo-test-operand-order
Gary V. Vaughan [Tue, 2 Oct 2012 13:51:13 +0000 (20:51 +0700)] 
tests: simplify some shell code.

* tests/fail.at: Simplify.
* tests/static.at: Likewise.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: unroll complex nested compound statements
Gary V. Vaughan [Tue, 2 Oct 2012 13:44:54 +0000 (20:44 +0700)] 
libtool: unroll complex nested compound statements

* build-aux/ltmain.m4sh: Use an if statement instead of ugified
compound statements.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: unroll nested if into a single case statement.
Gary V. Vaughan [Tue, 2 Oct 2012 12:39:35 +0000 (19:39 +0700)] 
libtool: unroll nested if into a single case statement.

* build-aux/ltmain.m4sh (func_mode_link): Unroll a hard to
understad nested if statement into a more readable single case
statement.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: simplify $skipped_export blocks
Gary V. Vaughan [Tue, 2 Oct 2012 12:31:49 +0000 (19:31 +0700)] 
libtool: simplify $skipped_export blocks

* build-aux/ltmain.m4sh (func_mode_link): Save an if statement
with '$skipped_export && { block; }' instead of 'if $skipped_export;
then block; fi'.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: simplify an if statement
Gary V. Vaughan [Tue, 2 Oct 2012 12:28:54 +0000 (19:28 +0700)] 
libtool: simplify an if statement

* build-aux/ltmain.m4sh (func_mode_link): Reverse the branch
order for an if statement for readability.
* m4/libtool.m4: Likewise.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: save an if statement, with a compound statement.
Gary V. Vaughan [Tue, 2 Oct 2012 12:25:17 +0000 (19:25 +0700)] 
libtool: save an if statement, with a compound statement.

* build-aux/ltmain.m4sh (func_mode_link): Simplify.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: simplify multiple string tests
Gary V. Vaughan [Tue, 2 Oct 2012 12:09:51 +0000 (19:09 +0700)] 
libtool: simplify multiple string tests

* build-aux/ltmain.m4sh (func_mode_link): Save test invocations
by using 'test x,y = "$a,$b"' instead of 'test x = "$a" && test y
= "$b"'.
* m4/libtool.m4: Likewise.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: fold if into a compound OR statement when more readable
Gary V. Vaughan [Tue, 2 Oct 2012 11:52:40 +0000 (18:52 +0700)] 
libtool: fold if into a compound OR statement when more readable

* build-aux/ltmain.m4sh (func_mode_link): For readability, use
'test string = "$var" || { stuff; }' in preference to
'if test string != "$var"; then stuff; fi'.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $rmforce, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $rmforce, and simplify

* build-aux/ltmain.m4sh (func_mode_uninstall): Save a string
comparison by setting $rmforce to false or : and using it
directly as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $wrappers_required, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $wrappers_required, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $wrappers_required to false or : and using
it directly with a ored block rather than an if statement.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $linkalldeplibs, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $linkalldeplibs, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $linkalldeplibs to false or : and using it
directly as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $valid_a_lib, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $valid_a_lib, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $valid_a_lib to false or : and using it
directly as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $found, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $found, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $found to false or : and using it directly
as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $alldeplibs, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $alldeplibs, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $alldeplibs to false or : and using it
directly as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $preload, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $preload, and simplify

* build-aux/ltmain.m4sh (func_mode_link): Save a string
comparison by setting $preload to false or : and using it directly
instead of if statements.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $my_pic_p, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $my_pic_p, and simplify

* build-aux/ltmain.m4sh (func_generate_dlsyms): Save a string
comparison by setting $my_pic_p to false or : and using it directly
instead of calling if.
Adjust all callers.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $finalize, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $finalize, and simplify

* build-aux/ltmain.m4sh (func_mode_install): Save a string
comparison by setting $finalize to false or : and using it
directly as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: use false or : for $isdir, and simplify
Gary V. Vaughan [Tue, 2 Oct 2012 11:08:29 +0000 (18:08 +0700)] 
libtool: use false or : for $isdir, and simplify

* build-aux/ltmain.m4sh (func_mode_install): Save a string
comparison by setting $isdir to false or : and using it directly
as the first argument to if.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agotests: skip with-pic test when no "real" pic flag is used.
Peter Rosin [Wed, 19 Sep 2012 09:53:02 +0000 (11:53 +0200)] 
tests: skip with-pic test when no "real" pic flag is used.

* tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic
"flag", but never applies it to static libraries. Cater for this
and skip if no "real" pic flag is in use.

Signed-off-by: Peter Rosin <peda@lysator.liu.se>
12 years agosyntax-check: fix texinfo formatting flagged by prohibit_undesirable_word_seq.
Gary V. Vaughan [Sun, 16 Sep 2012 10:43:05 +0000 (17:43 +0700)] 
syntax-check: fix texinfo formatting flagged by prohibit_undesirable_word_seq.

* doc/libtool.text: Fix several misuses of @xref and @pxref so that
the prohibit_undesirable_word_seq syntax check passes again.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agosyntax-check: remove useless_braces_in_variable_derefs.
Gary V. Vaughan [Sun, 16 Sep 2012 10:47:04 +0000 (17:47 +0700)] 
syntax-check: remove useless_braces_in_variable_derefs.

* build-aux/general.m4sh: Remove spurious braces around
${ZSH_VERSION} dereference.
* build-aux/ltmain.m4sh (func_mode_link): Likewise for ${wl}.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agosyntax-check: skip prohibit_strncpy.
Gary V. Vaughan [Sun, 16 Sep 2012 10:23:49 +0000 (17:23 +0700)] 
syntax-check: skip prohibit_strncpy.

* cfg.mk (local-checks-to-skip): sc_prohibit_strncpy.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agosyntax-check: skip prohibit_always_true_header_tests rule.
Gary V. Vaughan [Sun, 16 Sep 2012 10:02:22 +0000 (17:02 +0700)] 
syntax-check: skip prohibit_always_true_header_tests rule.

* cfg.mk (local-checks-to-skip): Add
sc_prohibit_always_true_header_tests.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agoRevert "bootstrap: delete unneeded README-release patch"
Gary V. Vaughan [Sun, 16 Sep 2012 07:35:55 +0000 (14:35 +0700)] 
Revert "bootstrap: delete unneeded README-release patch"

This reverts commit 11cd425e7d47111956381dba28f8c1b34e14653f.

These instructions are hard to find for new maintainers, so it's
good to keep them to hand with the release notes.

And the additional distchecks are important prior to a release.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agomaint: remove unused cvsu script.
Gary V. Vaughan [Sun, 16 Sep 2012 06:17:46 +0000 (13:17 +0700)] 
maint: remove unused cvsu script.

* build-aux/cvsu: Remove. This script is not useful now that
Libtool's repository is hosted in git.
* Makefile.am (build_scripts): Remove cvsu reference.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agomaint: run update-copyright for missing 2011 and 2012 years.
Gary V. Vaughan [Sun, 16 Sep 2012 06:10:09 +0000 (13:10 +0700)] 
maint: run update-copyright for missing 2011 and 2012 years.

See maintain.texi (Copyright Notices) for rules for maintaining
the years in copyright notices.
* All Files (Copyright): Updated with missing 2011 and 2012.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: use gnulib update-copyright script.
Gary V. Vaughan [Sun, 16 Sep 2012 06:04:23 +0000 (13:04 +0700)] 
bootstrap: use gnulib update-copyright script.

See maintain.texi (Copyright Notices) for rules for maintaining
the years in copyright notices.
* bootstrap.conf (gnulib_modules): Add update-copyright.
* cfg.mk (update-copyright-env): Set environment variables for
update-copyright script.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: update bootstrap script to latest upstream.
Gary V. Vaughan [Sun, 16 Sep 2012 04:47:22 +0000 (11:47 +0700)] 
bootstrap: update bootstrap script to latest upstream.

* bootstrap, build-aux/options-parser: apply upstream fixes and
enhancements.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agogit: don't complain about new parallel tests driver and file droppings.
Gary V. Vaughan [Sun, 16 Sep 2012 04:45:04 +0000 (11:45 +0700)] 
git: don't complain about new parallel tests driver and file droppings.

* build-aux/.gitignore: Ignore parallel `test-driver' script.
* tests/.gitignore: Ignore `test-driver' .trs file droppings.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agognulib: update local gnulib patches.
Gary V. Vaughan [Sun, 16 Sep 2012 04:40:16 +0000 (11:40 +0700)] 
gnulib: update local gnulib patches.

* gl/build-aux/announce-gen.diff: Remove hunks adopted upstream.
* gl/build-aux/do-release-commit-and-tag.diff: Refresh this patch
to match current gnulib.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agognulib: update gnulib submodule.
Gary V. Vaughan [Sun, 16 Sep 2012 04:38:50 +0000 (11:38 +0700)] 
gnulib: update gnulib submodule.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: ensure there is a ChangeLog before running automake.
Gary V. Vaughan [Sun, 16 Sep 2012 04:34:19 +0000 (11:34 +0700)] 
bootstrap: ensure there is a ChangeLog before running automake.

Automake refuses to run in GNU-mode unless there is a ChangeLog file
in the top-level directory.
* bootstrap.conf (libtool_force_changelog): Create a dummy ChangeLog.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtoolize: improve verbose mode output.
Gary V. Vaughan [Sun, 11 Dec 2011 11:31:56 +0000 (18:31 +0700)] 
libtoolize: improve verbose mode output.

* libtoolize (func_require_seen_ltdl)
(func_require_seen_libtool): Output success message in verbose
mode.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agoAdd the 'n' to then.
Peter O'Gorman [Wed, 22 Aug 2012 02:06:45 +0000 (21:06 -0500)] 
Add the 'n' to then.

* m4/libtool.m4: fix typo.
Thanks to Brad Smith for pointing it out.

12 years agoPass through -g* so that debugging information is not dropped
Andreas Schwab [Wed, 22 Aug 2012 01:17:04 +0000 (20:17 -0500)] 
Pass through -g* so that debugging information is not dropped

* ltmain.m4sh (func_mode_link): Pass through -g*.

12 years agoAIX PIC shared library support
David Edelsohn [Wed, 22 Aug 2012 01:14:55 +0000 (20:14 -0500)] 
AIX PIC shared library support

* m4/libtool.m4 (_LT_COMPILER_PIC): Add -fPIC to GCC and GXX for AIX.

12 years agoUpdate/simplify OpenBSD support
Brad Smith [Wed, 22 Aug 2012 01:12:01 +0000 (20:12 -0500)] 
Update/simplify OpenBSD support

* m4/libtool.m4: Forget about 11 year old releases.

12 years agolibtool: quote progpath properly
Peter Rosin [Sun, 19 Aug 2012 20:14:13 +0000 (22:14 +0200)] 
libtool: quote progpath properly

Attempt to handle spaces in paths better.

* build-aux/ltmain.m4sh (func_mode_install, func_mode_link): Quote
$progpath.
* THANKS: Update.

12 years agoHandle getconf returning "undefined".
Mike Frysinger [Thu, 19 Apr 2012 04:14:50 +0000 (23:14 -0500)] 
Handle getconf returning "undefined".

* m4/libtool.m4: Check for "undefined" from `getconf`.

12 years agobootstrap: delete unneeded README-release patch
Peter Rosin [Sat, 17 Mar 2012 19:13:53 +0000 (20:13 +0100)] 
bootstrap: delete unneeded README-release patch

* gl/top/README-release.diff: Delete.

12 years agoFix typo that caused sys_lib_search_path_spec to be wrong.
Peter O'Gorman [Fri, 16 Mar 2012 18:23:13 +0000 (13:23 -0500)] 
Fix typo that caused sys_lib_search_path_spec to be wrong.

* m4/libtool.m4: s/lt_fooi/lt_foo/.
Reported by Paul Seidler <sepek@lavabit.com>

12 years agoImprove GNU/Hurd support.
Samuel Thibault [Tue, 21 Feb 2012 14:51:40 +0000 (08:51 -0600)] 
Improve GNU/Hurd support.

* m4/libtool.m4: Add gnu* match where it was missing.

12 years agoAccept clang's -stdlib linker flag.
Titus von Boxberg [Sun, 19 Feb 2012 21:33:48 +0000 (15:33 -0600)] 
Accept clang's -stdlib linker flag.

build-aux/ltmain.m4sh: Don't drop the -stdlib= flag.

12 years agoEnable nagfor fortran compiler support
Juergen Reuter [Tue, 13 Dec 2011 18:18:08 +0000 (19:18 +0100)] 
Enable nagfor fortran compiler support

* build-aux/ltmain.m4sh: nagfor compatible version string.
* m4/libtool.m4: nagfor support.

12 years agoFixing -shared error message for nagfor compiler.
Juergen Reuter [Wed, 1 Feb 2012 00:31:11 +0000 (01:31 +0100)] 
Fixing -shared error message for nagfor compiler.

* m4/libtool.m4: Fix -shared.

12 years agoImprove debug error reporting in ltdl.
Pavel (Pasha) Shamis [Sun, 19 Feb 2012 20:18:19 +0000 (14:18 -0600)] 
Improve debug error reporting in ltdl.

* libltdl/ltdl.c: Print the error message if loading fails.

12 years agoDeleted unneeded gitlog-to-changelog patch
Peter O'Gorman [Sun, 19 Feb 2012 20:16:52 +0000 (14:16 -0600)] 
Deleted unneeded gitlog-to-changelog patch

* gl/build-aux/gitlog-to-changelog.diff: Delete.

12 years agocwrapper: avoid surplus strlen calculations.
Peter Rosin [Mon, 30 Jan 2012 14:49:05 +0000 (15:49 +0100)] 
cwrapper: avoid surplus strlen calculations.

* build-aux/ltmain.m4sh (func_emit_cwrapperexe_src:lt_update_exe_path):
Avoid surplus strlen calculations.

Signed-off-by: Peter Rosin <peda@lysator.liu.se>
12 years agobootstrap: fix Autoconf version typo.
Gary V. Vaughan [Sat, 24 Dec 2011 01:32:47 +0000 (08:32 +0700)] 
bootstrap: fix Autoconf version typo.

* build-aux/options-parses: s/2\.62/2.68/

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agognulib: update gnulib submodule.
Gary V. Vaughan [Sat, 24 Dec 2011 01:30:12 +0000 (08:30 +0700)] 
gnulib: update gnulib submodule.

Among others, this fixes the reference to a local commit.
* gnulib: Updated to todays master HEAD revision.
* gl/top/README-release.diff: Update to account for changes to
gnulib/top/README-release since the last gnulib update.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: make fork minimisation compatible with dash and zsh.
Gary V. Vaughan [Sun, 18 Dec 2011 13:41:10 +0000 (20:41 +0700)] 
libtool: make fork minimisation compatible with dash and zsh.

* build-aub/general.m4sh (lt_HAVE_PLUSEQ_OP): Instead of using
$((..)) arithmetic, which causes an error on dash, use a case
based bash version check.
(lt_HAVE_ARITH_OP, lt_HAVE_XSI_OPS): Also short circuit the
feature probing forks and set these automatically when zsh is
detected.
Reported by Stefano Lattarini.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: adopt autoconf echo normalization code.
Gary V. Vaughan [Sun, 18 Dec 2011 07:32:40 +0000 (14:32 +0700)] 
bootstrap: adopt autoconf echo normalization code.

Dash shipped with Ubutu-11.10 as /bin/sh, among others, still
has a crippled echo builtin that mis-handles backslashes.
* build-aux/options-parser (bs_echo): Adopt the autoconf echo
normalization code to find a suitable replacement for buggy echo
commands.
Adjust all uses of echo to $bs_echo.
* build-aux/extract-trace (func_extract_trace, func_main):
Likewise.
* bootstrap: To retain some execution speed on platforms with
buggy builtin echo, replace most occurrences of `echo' with
`$bs_echo' - except where its arguments will obviously never
contain backslashes or be overly long.
Reported by Reuben Thomas.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtool: minimise forks per invocation under bash.
Gary V. Vaughan [Thu, 8 Dec 2011 10:01:56 +0000 (17:01 +0700)] 
libtool: minimise forks per invocation under bash.

* build-aux/general.m4sh (lt_HAVE_PLUSEQ_OP, lt_HAVE_ARITH_OP)
(lt_HAVE_XSI_OPS): Set these without forking a test script when
running under bash, to avoid a few unnecessary forks.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agoSupport x32.
H.J. Lu [Tue, 13 Dec 2011 03:24:14 +0000 (21:24 -0600)] 
Support x32.

* m4/libtool.m4 (_LT_ENABLE_LOCK): Support x32.

12 years agomaint: disable prohibit_always-defined_macros syntax check.
Gary V. Vaughan [Thu, 8 Dec 2011 14:48:03 +0000 (21:48 +0700)] 
maint: disable prohibit_always-defined_macros syntax check.

Aside from Apple grep silently failing to run this test and
report violations, libtool still uses non-gnulib versions of
dirent.h and argz.h which use the same macros, but are not
always-defined.
* cfg.mk (local-checks-to-fix): Move
sc_prohibit_always-defined_macros from here...
(local-checks-to-skip): ...to here.
Reported by Peter O'Gorman.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agotests: s/snippit/snippet/.
Gary V. Vaughan [Thu, 8 Dec 2011 10:38:13 +0000 (17:38 +0700)] 
tests: s/snippit/snippet/.

* tests/demo/foo.h, tests/pdemo/foo.h: Spell `snippet' correctly.
Reported by Stefano Lattarini.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agotests: make sure file restore traps are called correctly on AIX.
Gary V. Vaughan [Thu, 8 Dec 2011 10:33:28 +0000 (17:33 +0700)] 
tests: make sure file restore traps are called correctly on AIX.

* tests/demo-noinst-link.test (func_save_files): set the restore
trap outside a function, otherwise AIX 5.3 /bin/sh will run the
trap at the end of the function, instead of when the script
exits.
* tests/demo-relink.test (func_save_files): Ditto.
* tests/depdemo-relink.test (func_save_files): Ditto.
Reported by Stefano Lattarini.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: put back missing spaces before parens.
Gary V. Vaughan [Thu, 8 Dec 2011 10:09:02 +0000 (17:09 +0700)] 
bootstrap: put back missing spaces before parens.

* bootstrap (func_require_buildreq_autobuild)
(func_require_buildreq_automake): Vi's delete word command is
too greedy and also eats trailing whitespace before following
non-word-chars. Put back the spaces it ate so that
syntax-checks pass once again.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtoolize: refactor copying filter creation.
Gary V. Vaughan [Sat, 19 Nov 2011 15:33:16 +0000 (22:33 +0700)] 
libtoolize: refactor copying filter creation.

Prevent the various require_filter functions from becoming too
long by factoring common code into new functions.
* libtoolize (func_make_relative_dir_filter)
(func_make_relative_ltdl_filter): New functions. Generalize and
consolidate the various similar snippets for concatenating
together the sed scripts for func_copy filtering.
(require_filter_Makefile_am, require_filter_aclocal_m4)
(require_filter_configure_ac): Simplify.
(require_ltdl_relative_aux_dir): Remove.
(require_ltdl_relative_macro_dir): Ditto.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agomaint: pick XSI funcs at runtime, not configure time.
Gary V. Vaughan [Sat, 19 Nov 2011 13:54:43 +0000 (20:54 +0700)] 
maint: pick XSI funcs at runtime, not configure time.

Determine, on a function by function basis, what XSI features
are available in the shell that is actually running the script,
rather than the one that was picked at configure time by the
re-execution engine.
* m4/libtool.m4 (_LT_PROG_FUNCTION_REPLACE)
(_LT_PROG_REPLACE_SHELLFNS): Remove.
(_LT_CHECK_SHELL_FEATURES): Remove tests for XSI and += support.
* build-aux/general.m4sh (func_append, func_append_quoted)
(func_arith, func_len, func_basename, func_dirname)
(func_dirname_and_basename, func_stripname): List both enhanced
and fallback implementations, and choose one based on whether
the enhanced features required by the fastest version are
available.
* build-aux/getopt.m4sh (func_split_short_opt)
(func_split_long_opt): Ditto.
* build-aux/ltmain.m4sh (func_lo2o, func_xform): Ditto.
* tests/getopt-m4sh.at: Add tests for enhanced and fallback
implementations of func_arith, func_len, func_stripname and
func_dirname_and_basename.
* NEWS: Updated.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agomaint: share useful functions from general.m4sh.
Gary V. Vaughan [Sat, 19 Nov 2011 11:01:28 +0000 (18:01 +0700)] 
maint: share useful functions from general.m4sh.

* build-aux/ltmain.m4sh (func_append, func_append_quoted)
(func_arith, func_len): Removed from here...
* build-aux/general.m4sh (func_append, func_append_quoted)
(func_arith, func_len): ...and added to here.
(func_dirname, func_dirname_and_basename, func_normal_abspath)
(func_relative_path): Use func_append.
* tests/getopt-m4sh.at (_LT_AT_FALLBACK_FUNC_EXTRACT): Removed.
Fallback functions are now in any m4sh generated file
automatically.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtoolize: reorder function definitions to keep func_filter_* together.
Gary V. Vaughan [Thu, 8 Dec 2011 08:34:27 +0000 (15:34 +0700)] 
libtoolize: reorder function definitions to keep func_filter_* together.

* libtoolize: Restore asciibetical order, so that all the
filter function definitions are together.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtoolize: use _filter as a prefix for better ordering.
Gary V. Vaughan [Thu, 8 Dec 2011 08:26:48 +0000 (15:26 +0700)] 
libtoolize: use _filter as a prefix for better ordering.

* libtoolize.m4sh (require_Makefile_am_filter)
(require_ltdl_mk_filter, require_aclocal_m4_filter)
(require_configure_ac_filter): Rename these functions from this...
(require_filter_Makefile_am, require_filter_ltdl_mk)
(require_filter_aclocal_m4, require_filter_configure_ac): ...to
this, respectively.  Adjust all callers.
(Makefile_am_filter, ltdl_mk_filter, aclocal_m4_filter)
(configure_ac_filter): Rename these global variables from this...
(filter_Makefile_am, filter_ltdl_mk, filter_aclocal_m4)
(filter_configure_ac): ...to this, respectively.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agolibtoolize: rename ltdl.mk filter function.
Gary V. Vaughan [Thu, 8 Dec 2011 08:14:44 +0000 (15:14 +0700)] 
libtoolize: rename ltdl.mk filter function.

* libtoolize.m4sh (require_Makefile_inc_filter): Rename from
this...
(require_ltdl_mk_filter): ...to this. Adjust all callers.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: escape quotes properly in generated functions.
Gary V. Vaughan [Thu, 8 Dec 2011 05:24:00 +0000 (12:24 +0700)] 
bootstrap: escape quotes properly in generated functions.

* bootstrap: Although not a real bug, for consistency, be sure
to correctly escape single quotes inside a single quoted
function generator.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: reorder function definitions to keep func_buildreq_* together.
Gary V. Vaughan [Thu, 8 Dec 2011 05:20:47 +0000 (12:20 +0700)] 
bootstrap: reorder function definitions to keep func_buildreq_* together.

* bootstrap: Restore asciibetical order, so that all the
buildreq function definitions are together.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: use _buildreq as a prefix for better ordering.
Gary V. Vaughan [Thu, 8 Dec 2011 05:15:11 +0000 (12:15 +0700)] 
bootstrap: use _buildreq as a prefix for better ordering.

* bootstrap (require_autobuild_buildreq)
(require_autoconf_buildreq, require_automake_buildreq)
(require_autopoint_buildreq, require_libtoolize_buildreq)
(require_patch_buildreq): Rename from these...
(require_buildreq_autobuild, require_buildreq_autoconf)
(require_buildreq_automake, require_buildreq_autopoint)
(require_buildreq_libtoolize, require_buildreq_patch): ...to
these, respectively.  Adjust all callers.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: ensure consistent function header comments.
Gary V. Vaughan [Thu, 8 Dec 2011 05:08:16 +0000 (12:08 +0700)] 
bootstrap: ensure consistent function header comments.

* bootstrap (require_bootstrap_uptodate)
(require_buildtools_uptodate): Use `require_...' in header
comment for these functions to be consistent with the rest,
rather than `func_require_...'.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agobootstrap: make sure patch is available to bootstrap if necessary.
Gary V. Vaughan [Thu, 8 Dec 2011 04:54:40 +0000 (11:54 +0700)] 
bootstrap: make sure patch is available to bootstrap if necessary.

Make sure we're not lacking any functionality provided by the
incumbent gnulib bootstrap script, and where it's easy to do so
(like it is here), provide better functionality!
* bootstrap (require_patch): Make sure that PATCH expands to the
best `patch' command available on the system, honouring
overrides in the users environment.
(require_patch_buildreq): Automatically add a requirement for a
patch command to buildreq when there are diff files in
$local_gl_dir.
(func_require_buildtools_uptodate): Call require_patch_buildreq
before testing build tool versions.
(func_gnulib_tool_copy_file): Make sure PATCH is set before using
gnulib-tool to copy files.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agomaint: Fix generated ChangeLog typos.
Gary V. Vaughan [Sat, 26 Nov 2011 02:09:59 +0000 (09:09 +0700)] 
maint: Fix generated ChangeLog typos.

* build-aux/git-log-fix: Spell Stefano Lattarini's name
correctly.
Don't use my home email address for GNU commits.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agosyntax-check: fix violations and implement sc_prohibit_sed_s_comma.
Gary V. Vaughan [Mon, 21 Nov 2011 11:02:23 +0000 (18:02 +0700)] 
syntax-check: fix violations and implement sc_prohibit_sed_s_comma.

I like to name temporary directories that I will remove shortly
with two leading commas so that they sort lexicographically at
the top of `ls' output.  Now, `./configure
--prefix=`pwd`/,,inst' works again, for the first time in
several years.
* cfg.mk (sc_prohibit_sed_s_comma): Comma is too common a
character to use routinely as the separator for sed
substitutions on file paths and other variables determined by
the user, causing bugs like the one I describe above.  Make sure
we don't accidentally reintroduce any comma separators in
future.
* Makefile.am, bootstrap, bootstrap.conf, build-aux/extract-trace,
build-aux/general.m4sh, build-aux/git-hooks/commit-msg,
build-aux/git-log-fix, build-aux/ltmain.m4sh, libtoolize.m4sh,
m4/libtool.m4, m4/ltdl.m4, tests/cdemo-undef.test,
tests/cmdline_wrap.at, tests/darwin.at, tests/defs.m4sh,
tests/getopt-m4sh.at, tests/install.at, tests/libtoolize.at,
tests/mdemo/Makefile.am, tests/need_lib_prefix.at,
tests/sysroot.at, tests/tagdemo-undef.test, tests/testsuite.at:
Try to use `|' as the default separator wherever possible,
otherwise something else that doesn't occur in the substitution
expression.
* NEWS: Updated.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
12 years agosyntax-check: [REDO] fix violations and implement sc_prohibit_test_const_follows_var.
Gary V. Vaughan [Tue, 2 Oct 2012 02:40:40 +0000 (09:40 +0700)] 
syntax-check: [REDO] fix violations and implement sc_prohibit_test_const_follows_var.

To safely use a non-literal fist argument to 'test', you must
always prepend a literal non-'-' character, but often the second
operand is a constant that doesn't begin with a '-' already, so
always use 'test a = "$b"' instead of the noisy 'test "X$b" = Xa'.
* cf.mk (sc_prohibit_test_const_follws_var): New syntax-check
rule to ensure we don't reintroduce noisy test operands.
bootstrap, build-aux/extract-trace, build-aux/general.m4sh,
build-aux/ltmain.m4sh, configure.ac, doc/libtool.texi, libtoolize.m4sh,
m4/argz.m4, m4/libtool.m4, m4/ltdl.m4, tests/bindir.at, tests/defs.m4sh,
tests/demo-relink.test, tests/demo/configure.ac,
tests/depdemo-relink.test, tests/destdir.at, tests/duplicate_conv.at,
tests/fail.at, tests/getopt-m4sh.at, tests/help.at, tests/libtoolize.at,
tests/link-2.test, tests/link-order2.at, tests/lt_dlopenext.at,
tests/mdemo/configure.ac, tests/mdemo2/configure.ac,
tests/need_lib_prefix.at, tests/nocase.at, tests/pdemo/configure.ac,
tests/pic_flag.at, tests/search-path.at, tests/shlibpath.at,
tests/static.at, tests/sysroot.at, tests/tagtrace.test,
tests/testsuite.at, tests/with-pic.at: Swap operands to avoid useless
noise.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.
Gary V. Vaughan [Sun, 20 Nov 2011 14:08:24 +0000 (21:08 +0700)] 
syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.

Until now, libtool sources have used braced variable names
seemingly at random! Almost always the braces are just noise, so
remove all the unnecessary ones.
* cfg.mk (sc_useless_braces_in_variable_derefs): New syntax
check rule to ensure we only reintroduce braced variable
dereferences if they are followed by a valid variable name
character.
build-aux/general.m4sh, build-aux/git-hooks/commit-msg,
build-aux/ltmain.m4sh, build-aux/options-parser, configure.ac,
libltdl/configure.ac, m4/libtool.m4, m4/ltdl.m4,
m4/ltoptions.m4, tests/defs.m4sh, tests/demo-nopic.test,
tests/depdemo/configure.ac, tests/flags.at, tests/link.test,
tests/objectlist.test, tests/quote.test, tests/static.at: Remove
spurious braces.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and implement sc_prohibit_bare_basename.
Gary V. Vaughan [Sat, 19 Nov 2011 15:53:20 +0000 (22:53 +0700)] 
syntax-check: fix violations and implement sc_prohibit_bare_basename.

* cfg.mk (sc_prohibit_bare_basename, sc_prohibit_basename_with_sed):
Make sure not to go back to using occasional `|$basename' or
`|$dirname' syntax.
* build-aux/git-hooks/commit-msg, build-aux/ltmain.m4sh,
* build-aux/options-parser, tests/fcdemo-conf.test,
* tests/fcdemo-shared.test, tests/fcdemo-static.test,
* tests/libtoolize.at: Fix violations.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agotests: migrate tests/sh.test checks to syntax-checks.
Gary V. Vaughan [Wed, 16 Nov 2011 16:21:18 +0000 (23:21 +0700)] 
tests: migrate tests/sh.test checks to syntax-checks.

Some modernization of the legacy testsuite.
* tests/sh.test: Remove.
* Makefile.am (COMMON_TESTS): Adjust.
* cfg.mk (sc_libtool_m4_cc_basename, sc_prohibit_bracket_as_test)
(sc_prohibit_nested_quotes, sc_prohibit_set_dummy_without_shift)
(sc_prohibit_set_minus_minus, sc_prohibit_test_binary_operators)
(sc_prohibit_test_dollar, sc_prohibit_test_minus_e)
(sc_prohibit_test_unary_operators, sc_prohibit_test_X)
(sc_prohibit_Xsed_withou_X, sc_require_function_nl_brace):
Functionally identical tests to what used to be performed by
sh.test, only with coverage of all files.
* bootstrap, build-aux/edit-readme-alpha,
build-aux/extract-trace, build-aux/getopt.m4sh,
build-aux/ltmain.m4sh, configure.ac, m4/libtool.m4, m4/ltdl.m4,
tests/bindir.at, tests/configure-iface.at, tests/cwrapper.at,
tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test,
tests/dlloader-api.at, tests/exceptions.at,
tests/getopt-m4sh.at, tests/lalib-syntax.at, tests/link-2.test,
tests/link-order2.at, tests/loadlibrary.at,
tests/lt_dladvise.at, tests/lt_dlexit.at, tests/lt_dlopen_a.at,
tests/lt_dlopenext.at, tests/need_lib_prefix.at,
tests/nonrecursive.at, tests/recursive.at, tests/resident.at,
tests/standalone.at, tests/static.at, tests/stresstest.at,
tests/subproject.at, tests/sysroot.at, tests/tagtrace.test,
tests/testsuite.at: Fix violations of the new syntax checks.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and implement sc_useless_quotes_in_assignment.
Gary V. Vaughan [Wed, 16 Nov 2011 11:59:01 +0000 (18:59 +0700)] 
syntax-check: fix violations and implement sc_useless_quotes_in_assignment.

Contrary to popular belief, Bourne shell does not resplit RHS of
assignments after expansion, so if there are no unquoted shell
metacharacters or whitespace, the quotes are useless.
* cfg.mk (_sc_search_regexp_or_exclude): A variation of gnulib's
_sc_search_regexp that also allows individual exclusions at the
site of what would otherwise match by adding a comment.
(sc_useless_quotes_in_assignment): New syntax-check rule to
ensure we don't reintroduce useless quoted assignments.
* bootstrap, bootstrap.conf, build-aux/edit-readme-alpha,
build-aux/general.m4sh, build-aux/getopt.m4sh,
build-aux/ltmain.m4sh, build-aux/options-parser, configure.ac,
doc/libtool.texi, libtoolize.m4sh, m4/libtool.m4, m4/ltdl.m4,
m4/ltoptions.m4, tests/cwrapper.at, tests/defs.m4sh,
tests/lalib-syntax.at, tests/libtoolize.at,
tests/lt_dlopenext.at, tests/mdemo/configure.ac,
tests/mdemo2/configure.ac, tests/need_lib_prefix.at,
tests/no-executables.at, tests/quote.test, tests/suffix.test:
Remove spurious quotes.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and implement sc_useless_quotes_in_case.
Gary V. Vaughan [Wed, 16 Nov 2011 08:00:47 +0000 (15:00 +0700)] 
syntax-check: fix violations and implement sc_useless_quotes_in_case.

Contrary to popular belief, Bourne shell does not resplit case
expressions after expansion, so if there are no unquoted shell
metacharacters or whitespace, the quotes are useless.
* cfg.mk (sc_useless_quotes_in_case): New syntax-check rule to
ensure we don't reintroduce useless quoted case expressions.
* build-aux/ltmain.m4sh, m4/libtool.m4, tests/bindir.at,
tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test,
tests/demo-nopic.test, tests/link-2.test, tests/quote.test,
tests/sysroot.at: Remove spurious quotes.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agomaint: quote $file correctly in bootstrap.
Gary V. Vaughan [Fri, 25 Nov 2011 07:39:57 +0000 (14:39 +0700)] 
maint: quote $file correctly in bootstrap.

* bootstrap (func_insert_sorted_if_absent): Don't forget the
double quotes, since we can't control the content of $file.
Reported by Steffano Lattarini.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agobuild: fix a quoting bug when regenerating with bootstrap_edit.
Gary V. Vaughan [Fri, 25 Nov 2011 07:50:37 +0000 (14:50 +0700)] 
build: fix a quoting bug when regenerating with bootstrap_edit.

* Makefile.am (m4/ltversion.m4, build-aux/ltmain.sh): The
bootstrap_edit make macro already contains double quotes, so
when echoing it, don't surround it with more double quotes since
it is not escaped.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agodist: hook syntax-check into `make distcheck'.
Gary V. Vaughan [Tue, 15 Nov 2011 12:48:16 +0000 (19:48 +0700)] 
dist: hook syntax-check into `make distcheck'.

To make sure we don't accidentally release anything with
failing syntax-checks, have `make distcheck' run the
syntax-checks automatically.
* Makefile.am (distcheck-hook): New rule depending on
syntax-check.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: enable sc_prohibit_always_true_header_tests.
Gary V. Vaughan [Tue, 25 Oct 2011 09:57:21 +0000 (16:57 +0700)] 
syntax-check: enable sc_prohibit_always_true_header_tests.

* cfg.mk (local-checks-to-fix): Remove
sc_prohibit_always_true_header_tests from list of disabled
checks, because it no longer flags any violations.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: enable sc_program_name.
Gary V. Vaughan [Wed, 26 Oct 2011 07:17:34 +0000 (14:17 +0700)] 
syntax-check: enable sc_program_name.

* cfg.mk (local-checks-to-skip): Remove sc_program_name
list of disabled checks.
(exclude_file_name_regexp--sc_program_name): Don't check demo
programs for use of set_program_name.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: enable sc_bindtextdomain.
Gary V. Vaughan [Wed, 26 Oct 2011 12:03:37 +0000 (19:03 +0700)] 
syntax-check: enable sc_bindtextdomain.

* cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain
list of disabled checks.
(exclude_file_name_regexp--sc_bindtextdomain): Don't check demo
programs for use of bindtextdomain.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and implement sc_trailing_blank-non-rfc3676.
Gary V. Vaughan [Tue, 25 Oct 2011 04:16:02 +0000 (11:16 +0700)] 
syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676.

* cfg.mk (local-checks-to-fix): Move sc_trailing_blank from
here...
(local-checks-to-skip): ...to here, because otherwise it flags
valid RFC3676 signature blocks.
(sc_trailing_blank-non-rfc3676): An improved sc_trailing_blank
implementation that doesn't flag signature blocks as violations.
* Makefile.am, bootstrap.conf, doc/PLATFORMS,
libltdl/config/ltmain.m4sh, libltdl/m4/libtool.m4,
libltdl/m4/lt~obsolete.m4, tests/archive-in-archive.at,
tests/convenience.at, tests/darwin.at, tests/depdemo/l1/l1.c,
tests/depdemo/l2/l2.c, tests/depdemo/l3/l3.c,
tests/depdemo/l4/l4.c, tests/f77demo/README,
tests/f77demo/cprogram.c, tests/f77demo/foof.f,
tests/f77demo/foof2.f, tests/f77demo/foof3.f,
tests/f77demo/fprogram.f, tests/fcdemo/README,
tests/fcdemo/cprogram.c, tests/fcdemo/foof.f90,
tests/fcdemo/foof2.f90, tests/fcdemo/foof3.f90,
tests/fcdemo/fprogram.f90, tests/mdemo/README,
tests/mdemo/main.c, tests/mdemo/mlib.c, tests/objectlist.test,
tests/static.at, tests/template.at, tests/testsuite.at: Remove
trailing blanks.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_useless_cpp_parens.
Gary V. Vaughan [Tue, 25 Oct 2011 05:00:58 +0000 (12:00 +0700)] 
syntax-check: fix violations and re-enable sc_useless_cpp_parens.

* cfg.mk (local-checks-to-fix): Remove sc_useless_cpp_parens
from list of disabled checks.
* doc/libtool.texi, libltdl/argz.c, libltdl/argz_.h,
build-aux/ltmain.m4sh, libltdl/libltdl/lt__alloc.h,
libltdl/libltdl/lt__dirent.h, libltdl/libltdl/lt__glibc.h,
libltdl/libltdl/lt__private.h, libltdl/libltdl/lt__strl.h,
libltdl/libltdl/lt_dlloader.h, libltdl/libltdl/lt_error.h,
libltdl/libltdl/lt_system.h, libltdl/libltdl/slist.h,
libltdl/loaders/dld_link.c, libltdl/loaders/dlopen.c,
libltdl/loaders/dyld.c, libltdl/loaders/loadlibrary.c,
libltdl/loaders/shl_load.c, libltdl/lt__dirent.c, libltdl/lt__strl.c,
libltdl/ltdl.c, libltdl/ltdl.h, libltdl/m4/libtool.m4, tests/demo/foo.h,
tests/depdemo/sysdep.h, tests/exceptions.at, tests/export.at,
tests/pdemo/foo.h, tests/stresstest.at: Remove useless parens in cpp
`#if defined(foo)' statements.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_space_tab.
Gary V. Vaughan [Tue, 25 Oct 2011 02:34:11 +0000 (09:34 +0700)] 
syntax-check: fix violations and re-enable sc_space_tab.

* cfg.mk (local-checks-to-fix): Remove sc_space_tab from list of
disabled checks.
(exclude_file_name_regexp--sc_space_tab): Don't flag space-tab
sequences in diff files as an error.
* Makefile.am, build-aux/general.m4sh, build-aux/git-hooks/commit-msg,
build-aux/ltmain.m4sh, libltdl/loaders/dyld.c,
libltdl/loaders/shl_load.c, libltdl/ltdl.h, libltdl/ltdl.mk,
libltdl/slist.c, libtoolize.m4sh, m4/ltoptions.m4, tests/demo/dlmain.c,
tests/depdemo/main.c, tests/libtoolize.at, tests/lt_dladvise.at,
tests/pdemo/longer_file_name_dlmain.c, tests/sh.test, tests/static.at,
tests/stresstest.at, tests/template.at: Fix space-tab sequences by
reversing them in regexps, and deleting leading spaces in indentation.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq.
Gary V. Vaughan [Mon, 24 Oct 2011 15:05:48 +0000 (22:05 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq.

* cfg.mk (local-checks-to-fix): Remove
sc_prohibit_undesirable_word_seq from list of disabled checks.
* doc/libtool.texi, build-aux/ltmain.m4sh,
libltdl/m4/libtool.m4, libtoolize.m4sh: Replace all uses of "can
not" with "cannot".

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_probibit_test_minus_ao.
Gary V. Vaughan [Mon, 24 Oct 2011 14:51:24 +0000 (21:51 +0700)] 
syntax-check: fix violations and re-enable sc_probibit_test_minus_ao.

* cfg.mk (local-checks-to-fix): Remove
sc_probhibit_test_minus_ao from list of disabled checks.
(exclude_file_name_regexp--sc_prohibit_tests_minus_ao): The
matches from this syntax-check in libtool.m4 are all bogus.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_strcmp.
Gary V. Vaughan [Mon, 24 Oct 2011 14:36:27 +0000 (21:36 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_strcmp.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_strcmp
from list of disabled checks.
(exclude_file_name_regexp--sc_prohibit_strcmp): Ignore
violations in libtool.texi and any demo C files.
* libltdl/libltdl/lt__private.h (strneq, streq): Renamed from
this...
(STRNEQ, STREQ): ..to this.  Adjust all callers.
* tests/slist.at: Add STREQ definition. Change all !strcmp calls
to STREQ.
* build-aux/ltmain.m4sh (func_emit_cwrapperexe_src): Add and use
STREQ definition.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_stddef_without_use.
Gary V. Vaughan [Mon, 24 Oct 2011 11:52:57 +0000 (18:52 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_stddef_without_use.

* cfg.mk (local-checks-to-fix): Remove
sc_prohibit_stddef_without_use from list of disabled checks.
* libltdl/argz.c, libltdl/lt__dirent.c, libltdl/slist.c: Remove
spurious stddef.h #include lines.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_magic_number_exit.
Gary V. Vaughan [Mon, 24 Oct 2011 11:42:53 +0000 (18:42 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_magic_number_exit
from list of disabled checks.
* ltmain.c: Removed unused file.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_have_config_h.
Gary V. Vaughan [Mon, 24 Oct 2011 11:35:36 +0000 (18:35 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_have_config_h.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_have_config_h
from list of disabled checks.
* tests/f77demo/foo.h, tests/fcdemo/foo.h: Remove spurious
HAVE_CONFIG_H guards for #include <config.h>.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF.
Gary V. Vaughan [Mon, 24 Oct 2011 11:29:45 +0000 (18:29 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF.

* cfg.mk (local-checks-to-fix): Remove
sc_prohibit_empty_lines_at_EOF from list of disabled checks.
* THANKS, libltdl/argz.c, libltdl/config/getopt.m4sh,
tests/f77demo/README, tests/f77demo/cprogram.c,
tests/f77demo/fprogram.f, tests/fcdemo/README,
tests/fcdemo/cprogram.c, tests/libtoolize.at,
tests/mdemo/README, tests/mdemo2/README, tests/pdemo-inst.test:
Remove spurious empty lines from the end of these files.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_doubled_word.
Gary V. Vaughan [Mon, 24 Oct 2011 11:24:11 +0000 (18:24 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_doubled_word.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_doubled_word
from list of disabled checks.
* build-aux/general.m4sh (func_quote_for_eval): Remove one of a
 pair of "and"s in a comment.
* tests/lt_dladvise.at (hint_global): Remove one of a pair of
consecutive "to"s split across lines in a comment.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_prohibit_cvs_keyword.
Gary V. Vaughan [Mon, 24 Oct 2011 11:20:58 +0000 (18:20 +0700)] 
syntax-check: fix violations and re-enable sc_prohibit_cvs_keyword.

* cfg.mk (local-checks-to-fix): Remove sc_prohibit_cvs_keyword
from list of disabled checks.
* tests/tagdemo/README: Remove spurious CVS keyword.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_makefile_at_at_check.
Gary V. Vaughan [Mon, 24 Oct 2011 11:03:23 +0000 (18:03 +0700)] 
syntax-check: fix violations and re-enable sc_makefile_at_at_check.

At some point we were supporting some undetermined `broken
make', as evidenced by having carried the following code since
2003:
  ## use @LIBLTDL@ because some broken makes do not accept
  ## macros in targets, we can only do this because our LIBLTDL
  ## does not contain $(top_builddir).
  @LIBLTDL@: $(top_distdir)/libtool \
  ...
However, we've also had *many* cases of macros in targets for
just as long, so most likely we never fully supported makes
allegedly broken in this way.  As of this release, we explicitly
no longer support make implementations that do not accept macros
in targets.
* cfg.mk (local-checks-to-fix): Remove sc_makefile_at_at_check
from list of disabled checks.
* configure.ac (order-only prerequisites): Test with the
order-only pipe symbol in a macro.
* Makefile.am, tests/mdemo/Makefile.am: Convert all @FOO@ to
$(FOO).

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation.
Gary V. Vaughan [Mon, 24 Oct 2011 09:35:00 +0000 (16:35 +0700)] 
syntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation.

* cfg.mk (local-checks-to-fix): Remove
sc_makefile_TAB_only_indentation from list of disabled checks.
* Makefile.am (libltdl/Makefile.am): Replace leading spaces with
TABs.
* libltdl/Makefile.am (libltdl_libltdl_la_SOURCES): Ditto.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_m4_quote_check.
Gary V. Vaughan [Mon, 24 Oct 2011 09:29:54 +0000 (16:29 +0700)] 
syntax-check: fix violations and re-enable sc_m4_quote_check.

* cfg.mk (local-checks-to-fix): Remove sc_m4_quote_check from
list of disabled checks.
* libltdl/m4/libtool.m4 (_LT_CHECK_OBJDIR): Quote LT_OBJDIR
correctly.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_file_system.
Gary V. Vaughan [Mon, 24 Oct 2011 09:23:41 +0000 (16:23 +0700)] 
syntax-check: fix violations and re-enable sc_file_system.

* cfg.mk (local-checks-to-fix): Remove sc_file_system from list
of disabled checks.
(VC_LIST_ALWAYS_EXCLUDE_REGEX): Match mail directory correctly
to avoid running its contents through syntax-check.
* build-aux/ltmain.m4sh (func_mode_link): Use correct spelling
for "file system".
* libltdl/ltdl.c (try_dlopen): Ditto.
* tests/dlloader-api.at: Ditto.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
13 years agosyntax-check: fix violations and re-enable sc_error_message_uppercase.
Gary V. Vaughan [Wed, 26 Oct 2011 07:33:45 +0000 (14:33 +0700)] 
syntax-check: fix violations and re-enable sc_error_message_uppercase.

* cfg.mk (local-checks-to-fix): Remove
sc_error_message_uppercase from list of disabled checks.
(exclude_file_name_regexp--sc_error_message_uppercase): Don't
match cvsu, which is not our file to edit.
* doc/libtool.texi: Use lowercase error message in example.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>