]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/log
thirdparty/sqlalchemy/sqlalchemy.git
5 hours agoset PYTHONUTF8=1 for attestation step to fix encoding on Windows main
Mike Bayer [Sat, 27 Jun 2026 20:20:17 +0000 (16:20 -0400)] 
set PYTHONUTF8=1 for attestation step to fix encoding on Windows

pypi_attestations sign writes attestation JSON files using the Windows
default encoding (CP1252) rather than UTF-8, causing twine to fail with
a UnicodeDecodeError when reading them back. PYTHONUTF8=1 forces UTF-8
for all file I/O on Windows.

Change-Id: I0eb7c4fae80eee52a81ed7106c1af699ebf79e21

5 hours agocontinue-on-error for upload-release-assets to handle already_exists on re-runs
Mike Bayer [Sat, 27 Jun 2026 19:59:35 +0000 (15:59 -0400)] 
continue-on-error for upload-release-assets to handle already_exists on re-runs

When re-running the wheel build, wheels already uploaded to the GitHub release
cause upload-release-assets to fail with already_exists. With continue-on-error,
the attestation and PyPI upload steps still proceed since the wheel files remain
in ./wheelhouse/ regardless.

Change-Id: Id2ba96e95dd93b3ba14e9bf117a5d1a057178f37

5 hours agouse python -m pip/twine/pypi_attestations to avoid PATH issues on macOS
Mike Bayer [Sat, 27 Jun 2026 19:50:49 +0000 (15:50 -0400)] 
use python -m pip/twine/pypi_attestations to avoid PATH issues on macOS

On macOS after cibuildwheel runs, bare pip/twine may not be on PATH.
Using python -m ensures the correct interpreter's tools are used.

Change-Id: I658267a4f51343d69cdd930744a4086685b735bf

5 hours agoadd shell: bash to attestations step to fix glob expansion on Windows
Mike Bayer [Sat, 27 Jun 2026 19:50:02 +0000 (15:50 -0400)] 
add shell: bash to attestations step to fix glob expansion on Windows

PowerShell does not expand ./wheelhouse/* globs, causing pypi_attestations
sign to receive a literal asterisk and fail. Explicit bash shell ensures
glob expansion works on all platforms.

Change-Id: I98a2785e5e5ac3cd54db361f990fba32fa819ca5

5 hours agofall back to twine upload without attestations if attestation signing fails
Mike Bayer [Sat, 27 Jun 2026 19:46:41 +0000 (15:46 -0400)] 
fall back to twine upload without attestations if attestation signing fails

On some platforms (e.g. windows-11-arm) pypi-attestations cannot install
due to missing cryptography binary wheels. Use continue-on-error on the
attestation step and conditionally pass --attestations to twine only when
signing succeeded.

Change-Id: Ibc9b5091c0db361f24376a887d6db04b0e32503c

5 hours agofix create-wheels.yaml for cibuildwheel 4.x and release asset upload
Mike Bayer [Sat, 27 Jun 2026 19:17:29 +0000 (15:17 -0400)] 
fix create-wheels.yaml for cibuildwheel 4.x and release asset upload

Remove CIBW_ENABLE cpython-freethreading which is no longer a valid enable
group in cibuildwheel 4.x; free-threaded builds are now included by default
when specifying cp314t-* in CIBW_BUILD.

Change contents permission from read to write so that the upload-release-assets
step can attach wheels to the GitHub release.

Change-Id: I96c6755db1aba38e4eaeebdd2b7b3738a305226c

9 hours agoVersion 2.1.0b4 placeholder
Mike Bayer [Sat, 27 Jun 2026 18:52:49 +0000 (14:52 -0400)] 
Version 2.1.0b4 placeholder

10 hours ago- 2.1.0b3 rel_2_1_0b3
Mike Bayer [Sat, 27 Jun 2026 17:46:45 +0000 (13:46 -0400)] 
- 2.1.0b3

11 hours agofix
Mike Bayer [Sat, 27 Jun 2026 17:03:21 +0000 (13:03 -0400)] 
fix

Change-Id: If46d73e1296c322e94f20083346bce32c0aad636

11 hours agofixes for m2momitjointest
Mike Bayer [Sat, 27 Jun 2026 16:15:59 +0000 (12:15 -0400)] 
fixes for m2momitjointest

in 808fd28297f36bf932443bae77ca5bb16bcbd4dd , the new test suite
created per-column `ForeignKey` constructs instead of composite
ForeignKeyConstraint objects, leading to failures on all backends
other than SQLite.  The test now runs with backend, and also does not
need AssertsCompiledSQL directives.

Change-Id: Ia52172e22a3f8c37e63f60ce0d2d6b4708a2459b

12 hours agomore changelog updates
Mike Bayer [Sat, 27 Jun 2026 16:06:18 +0000 (12:06 -0400)] 
more changelog updates

Change-Id: I182aba53fd92baaa132665b6ea49d882acd3b190

12 hours agorework migration docs a bit, fix issues
Mike Bayer [Sat, 27 Jun 2026 15:11:49 +0000 (11:11 -0400)] 
rework migration docs a bit, fix issues

Change-Id: I0ef6e304e32ee8add3ebc2e325cc7d13e39e38aa

37 hours agowrap before/after_cursor_execute event hooks in error handling
Mike Bayer [Fri, 26 Jun 2026 14:09:38 +0000 (10:09 -0400)] 
wrap before/after_cursor_execute event hooks in error handling

Expanded try/except error handling in _exec_single_context(),
_exec_insertmany_context(), and _cursor_execute() to encompass the
before_cursor_execute and after_cursor_execute event hooks. This
ensures that exceptions raised within these hooks, including
BaseException subclasses such as asyncio.CancelledError, are
properly handled via _handle_dbapi_exception(), providing correct
connection invalidation and pool notification.

Also added a guard in _handle_dbapi_exception to avoid
double-wrapping exceptions that are already StatementError
instances, which could occur when _cursor_execute's error handling
propagates up through _execute_context.

As part of this change, DBAPI errors raised from within these event
hooks will now be wrapped as SQLAlchemy exceptions.

Fixes: #13381
Change-Id: I6df29406f1eed9c318d02b00b999408c1e83535d

3 days agooverride get_select_precolumns() in StrSQLCompiler
Mike Bayer [Wed, 24 Jun 2026 12:49:30 +0000 (08:49 -0400)] 
override get_select_precolumns() in StrSQLCompiler

Fixed issue where :meth:`_sql.Select.get_final_froms` would emit a
deprecation warning when the statement made use of the PostgreSQL-specific
expression argument to :meth:`_sql.Select.distinct`; the same spurious
warning would be emitted when stringifying such a statement without
explicitly using a PostgreSQL dialect.  The fix ensures that this 1.4-era
warning is suppressed under both 2.0 and 2.1.

Note that under SQLAlchemy 2.1, passing an expression to
:meth:`_sql.Select.distinct` is deprecated overall, and is replaced by a
new PostgreSQL-specific construct (see :ticket:`12342`).

Fixes: #13396
Change-Id: I587e24aa7016c56b1d5bfe1048c4b6eb809dfb30

4 days agoMerge "fix catastrophic backtracking in mysql index comment reflection regex" into...
Michael Bayer [Tue, 23 Jun 2026 21:21:29 +0000 (21:21 +0000)] 
Merge "fix catastrophic backtracking in mysql index comment reflection regex" into main

4 days agoMerge "fixes for logging tests" into main
Michael Bayer [Tue, 23 Jun 2026 20:06:02 +0000 (20:06 +0000)] 
Merge "fixes for logging tests" into main

4 days agofix catastrophic backtracking in mysql index comment reflection regex
dxbjavid [Mon, 22 Jun 2026 15:30:40 +0000 (11:30 -0400)] 
fix catastrophic backtracking in mysql index comment reflection regex

Improved the regular expression used to parse index COMMENT clauses
in MySQL SHOW CREATE TABLE reflection to use an unambiguous
single-quoted-string pattern; the previous pattern was theoretically
subject to backtracking on malformed input, though such input is not
producible by MySQL itself.  Fix courtesy of Javid Khan.

Fixes: #13393
Closes: #13394
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13394
Pull-request-sha: 52239d122e937fd6b266ac49fb024063c82c9372

Change-Id: I9174705dd8e1539d8ed7c384b13280bf543d7341

4 days agoMerge "quote driver name and pass-through keys in pyodbc connect string" into main
Michael Bayer [Tue, 23 Jun 2026 18:11:13 +0000 (18:11 +0000)] 
Merge "quote driver name and pass-through keys in pyodbc connect string" into main

4 days agoMerge "Add explicit USING support to DELETE" into main
Michael Bayer [Tue, 23 Jun 2026 18:11:01 +0000 (18:11 +0000)] 
Merge "Add explicit USING support to DELETE" into main

4 days agofixes for logging tests
Mike Bayer [Tue, 23 Jun 2026 17:53:21 +0000 (13:53 -0400)] 
fixes for logging tests

Repair some things that went wrong in 0dcfa5e9ea49e481a7a35130f654cbdd3a8c1405
re #13363

* add "logging.handlers" import
* ensure DB connects before capturing log messages so we skip
  initial connect overhead

Change-Id: I10f3ac06b982633d617ec2d9c2a57371038b5a54

5 days agoAdd explicit USING support to DELETE
cjc0013 [Thu, 11 Jun 2026 21:23:04 +0000 (17:23 -0400)] 
Add explicit USING support to DELETE

Added :meth:`_sql.Delete.using`, allowing explicit FROM expressions such as
joins to be rendered in backend-specific multiple-table DELETE forms
including MySQL/MariaDB ``DELETE .. USING``.  Pull request courtesy
cjc0013.

Fixes: #8130
Closes: #13334
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13334
Pull-request-sha: df5644e96158a2424c85773d335bab6cc0c8c038

Change-Id: I9cadfc7ebb1c8b4f6a7433de3fbddbad205f545d

5 days agouse @classmethod per pytest guidance
Mike Bayer [Mon, 22 Jun 2026 15:36:02 +0000 (11:36 -0400)] 
use @classmethod per pytest guidance

Fixed class-scoped pytest fixtures that were defined as instance methods
using ``self``, which is deprecated as of pytest 9.1 and will be removed in
pytest 10. Fixtures are now decorated with a compatibility ``@classmethod``
decorator and use ``cls`` as the first parameter.

Fixes: #13392
Change-Id: I866de54e22569c9d55eb97dce165670994ec4a57

9 days agoquote driver name and pass-through keys in pyodbc connect string
dxbjavid [Wed, 17 Jun 2026 12:49:06 +0000 (08:49 -0400)] 
quote driver name and pass-through keys in pyodbc connect string

Tightened the construction of the ODBC connection string in the pyodbc
connector (as well as the mssql-python connector in 2.1) so that the
driver name, the names of pass-through connection parameters, and values
containing ``}`` are brace-quoted.  Previously a ``}`` in the driver name
or in a pass-through value, or a ``;`` in the name of a pass-through
parameter, could close the surrounding token early and allow the
remainder of the string to be interpreted as additional connection
attributes.  Pull request courtesy dxbjavid.

Fixes: #13380
Closes: #13379
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13379
Pull-request-sha: 34433408bff86a9044be5d431b31688ab6d7578d

Change-Id: I5a0b522e62d306cf6dc59c7f61fe584df02a948d

9 days agoMerge branch 'dependabot/github_actions/actions/checkout-7'
Mike Bayer [Thu, 18 Jun 2026 18:12:36 +0000 (14:12 -0400)] 
Merge branch 'dependabot/github_actions/actions/checkout-7'

Change-Id: I46dff7c91fd6abef23ef8c76a5ee072176618b99

9 days agoMerge "Improve performance of selectinload result handling by up to ~30%" into main
Michael Bayer [Thu, 18 Jun 2026 17:25:40 +0000 (17:25 +0000)] 
Merge "Improve performance of selectinload result handling by up to ~30%" into main

9 days agoBump actions/checkout from 6 to 7 13387/head
dependabot[bot] [Thu, 18 Jun 2026 15:12:33 +0000 (15:12 +0000)] 
Bump actions/checkout from 6 to 7

Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v6...v7)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
10 days agoFix is_pep695 misidentifying Annotated[TypeAliasType] as PEP 695
Mike Bayer [Wed, 17 Jun 2026 22:06:56 +0000 (18:06 -0400)] 
Fix is_pep695 misidentifying Annotated[TypeAliasType] as PEP 695

The is_pep695() function incorrectly identified
Annotated[TypeAliasType, ...] as a PEP 695 type alias because
Annotated's __origin__ attribute returns the first type argument
(the TypeAliasType) rather than Annotated itself.  This caused
_init_column_for_annotation to crash with AttributeError when
attempting to access __value__ on the Annotated wrapper.

Added a check for is_pep593() before recursing through __origin__
in is_pep695(), so Annotated types are correctly excluded.

Fixes: #13386
Change-Id: I36ef83ebbab5abc08bed0131efb552c3fc001911

10 days agoImprove performance of selectinload result handling by up to ~30%
Oliver Parker [Wed, 17 Jun 2026 15:15:18 +0000 (11:15 -0400)] 
Improve performance of selectinload result handling by up to ~30%

* in selectinloader, dont use Bundle() to represent the PK portion
* use more efficient mapper._state_ident_getter() method in selectinloader
  which pre-resolves keys and only calls upon _get_state_attr_by_column when
  an attribute is not locally present
* removed use of groupby() + lambda against Row objects in subqueryloader; converts
  to tuple and builds lists via append()

Adds tests pinning behavior of the rewritten result handling: the uselist=False multiple-rows warning, and many-to-one loads where the foreign key value matches no row or is NULL.

Benchmarked on an in-memory SQLite database (median of 30 runs, ms):

case | baseline | branch | Δ
-- | -- | -- | --
selectin_m2m | 9.747 | 6.958 | -28.6%
selectin_m2o | 13.761 | 12.538 | -8.9%
selectin_nested | 14.670 | 11.473 | -21.8%
selectin_o2m | 14.686 | 11.823 | -19.5%
selectin_o2m_few_big | 25.771 | 19.787 | -23.2%
subquery_o2m | 15.946 | 15.736 | -1.3%

Fixes: #13363
Closes: #13364
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13364
Pull-request-sha: 3b858fc54bb28f7c44101be5b7fdc6c02dda6c66

Change-Id: I2e772c7ee9fa9e1b50026cab8c7997b861f1acda

12 days agoMerge branch 'dependabot/github_actions/pypa/cibuildwheel-4.1.0'
Mike Bayer [Mon, 15 Jun 2026 20:29:26 +0000 (16:29 -0400)] 
Merge branch 'dependabot/github_actions/pypa/cibuildwheel-4.1.0'

Change-Id: I263869dff37838f9e34e4b6c6641c26aec714374

12 days agoMerge "Fixes: 13363 Process ORM result rows as plain tuples without Row construction...
Michael Bayer [Mon, 15 Jun 2026 20:28:20 +0000 (20:28 +0000)] 
Merge "Fixes: 13363 Process ORM result rows as plain tuples without Row construction" into main

12 days agoFixes: 13363 Process ORM result rows as plain tuples without Row construction
Oliver Parker [Mon, 15 Jun 2026 14:41:06 +0000 (10:41 -0400)] 
Fixes: 13363 Process ORM result rows as plain tuples without Row construction
ORM result row fetching now processes rows as plain tuples rather than
constructing :class:`.Row` objects, as ORM loaders use position-based
access and do not require the :class:`.Row` interface. :class:`.Row`
construction is still used when engine-level debug logging is enabled so
that individual rows can be logged. Benchmarks show a 3-16% improvement in
ORM entity load times depending on query shape.  Pull request courtesy
Oliver Parker.

Adds Result._all_interim_rows(), which returns the remaining rows as processed plain tuples, applying result processors and tuple filters but skipping Row object construction.  ORM loading uses this for its row fetch; its row getters are position-based itemgetters that accept any tuple-like row.  Results that require row logging or have scalar sources fall back to Row construction.

Adds tests covering the new behavior: rows are plain tuples with result processors applied, and Row construction still occurs when engine-level row logging is enabled, at both the Result and ORM loading level.

Benchmarked on an in-memory SQLite database with this change alone (median of 30 runs, ms); this path is used by all ORM entity loads:

    plain_small (500 rows x 5 cols)    2.43 ->  2.28    -6%
    plain_wide (2000 rows x 25 cols)   8.17 ->  7.24   -11%
    joined_o2m (500 x 10)             18.56 -> 16.95    -9%
    selectin_o2m (500 x 10)           18.45 -> 17.79    -4%
    selectin_nested (50 x 10 x 10)    18.67 -> 17.33    -7%
    selectin_m2m (500 x 10)           12.70 -> 11.53    -9%
    selectin_m2o (5000 -> 200)        15.83 -> 15.29    -3%
    selectin_o2m_few_big (20 x 500)   32.96 -> 31.29    -5%
    subquery_o2m (500 x 10)           21.51 -> 18.16   -16%

Fixes: #13363
Closes: #13365
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13365
Pull-request-sha: 46f4125ead7e37b780160ae70e03ec204ecb9617

Change-Id: Ia91a89c8cac78d4790391bc5b171b76d4aaca71b

12 days agocherry-pick changelog update for 2.0.52
Mike Bayer [Mon, 15 Jun 2026 15:41:38 +0000 (11:41 -0400)] 
cherry-pick changelog update for 2.0.52

12 days agocherry-pick changelog from 2.0.51
Mike Bayer [Mon, 15 Jun 2026 15:41:37 +0000 (11:41 -0400)] 
cherry-pick changelog from 2.0.51

12 days agoBump pypa/cibuildwheel from 4.0.0 to 4.1.0 13373/head
dependabot[bot] [Mon, 15 Jun 2026 15:21:14 +0000 (15:21 +0000)] 
Bump pypa/cibuildwheel from 4.0.0 to 4.1.0

Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](https://github.com/pypa/cibuildwheel/compare/v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: pypa/cibuildwheel
  dependency-version: 4.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
12 days agofix backtracking hang in hstore literal parser
dxbjavid [Fri, 12 Jun 2026 11:19:04 +0000 (07:19 -0400)] 
fix backtracking hang in hstore literal parser

Fixed regular expression in the pure Python hstore result processor,
used when ``use_native_hstore=False`` is set, which could hang on
malformed hstore text containing unterminated quoted segments with
backslashes.  Pull request courtesy dxbjavid.

Fixes: #13370
Closes: #13371
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13371
Pull-request-sha: f5eddae11c435c78f326b70a15357cbaf6d09337

Change-Id: I0d2d7565dc88f56a73b41e2ad20ca1c5a6f738bb

2 weeks agoadd row logging tests
Mike Bayer [Fri, 12 Jun 2026 17:33:05 +0000 (13:33 -0400)] 
add row logging tests

ensure all the main result methods as well as the ORM-used
_raw_all_rows() perform equivalent row logging.

Change-Id: Iee0dc3c75a9c71f6d1a73fa058c5edf0b16348ec

2 weeks agobump mssql-python to 1.9.0
Mike Bayer [Fri, 12 Jun 2026 18:13:50 +0000 (14:13 -0400)] 
bump mssql-python to 1.9.0

1.9.0 seems to fix the picklable statement exception fail,
so fix for that test and pin to lower version

Change-Id: Ic561b1a6b688f38b9f5189508d9203bca47fef79

2 weeks agoMerge "factor single-table reflection wrappers into common mixin" into main
Michael Bayer [Fri, 12 Jun 2026 16:12:57 +0000 (16:12 +0000)] 
Merge "factor single-table reflection wrappers into common mixin" into main

2 weeks agochore: improve sqlalchemy maintenance path (#13351)
lphuc2250gma [Thu, 11 Jun 2026 21:19:57 +0000 (17:19 -0400)] 
chore: improve sqlalchemy maintenance path (#13351)

Co-authored-by: Noa Levi <275430404+lphuc2250gma@users.noreply.github.com>
2 weeks agoDocument quoted_name use for PostgreSQL INHERITS (#13342)
CaoRongkai [Thu, 11 Jun 2026 21:19:16 +0000 (05:19 +0800)] 
Document quoted_name use for PostgreSQL INHERITS (#13342)

2 weeks agoBump pypa/cibuildwheel from 3.4.1 to 4.0.0 (#13358)
dependabot[bot] [Thu, 11 Jun 2026 20:57:54 +0000 (22:57 +0200)] 
Bump pypa/cibuildwheel from 3.4.1 to 4.0.0 (#13358)

Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 3.4.1 to 4.0.0.
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](https://github.com/pypa/cibuildwheel/compare/v3.4.1...v4.0.0)

---
updated-dependencies:
- dependency-name: pypa/cibuildwheel
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks agofactor single-table reflection wrappers into common mixin
Mike Bayer [Fri, 5 Jun 2026 20:02:02 +0000 (16:02 -0400)] 
factor single-table reflection wrappers into common mixin

Introduced _BackendsMultiReflection mixin in engine/default.py
that provides the get_columns(), get_pk_constraint(),
get_foreign_keys(), get_indexes(), get_unique_constraints(),
get_check_constraints(), get_table_comment(), and
get_table_options() single-table methods, each delegating to
the corresponding get_multi_* method with
filter_names=[table_name].

PostgreSQL, Oracle, and MSSQL dialects now inherit from this
mixin instead of duplicating the wrapper pattern.  Oracle
retains its _value_or_raise() override which applies
normalize_name() for case-folding.  MSSQL overrides
get_unique_constraints(), get_check_constraints(), and
get_table_options() with NotImplementedError since it has no
native get_multi_* for those yet.

Change-Id: If68bbf94b3956348fc7ae8179ff093d63dcdfbe2

2 weeks agoMerge "allow rollback within _prepare_impl on twophase prepare failure" into main
Michael Bayer [Wed, 10 Jun 2026 13:08:43 +0000 (13:08 +0000)] 
Merge "allow rollback within _prepare_impl on twophase prepare failure" into main

2 weeks agoMerge "repair xid in psycopg" into main
Michael Bayer [Wed, 10 Jun 2026 13:08:10 +0000 (13:08 +0000)] 
Merge "repair xid in psycopg" into main

2 weeks agoallow rollback within _prepare_impl on twophase prepare failure
Mike Bayer [Tue, 9 Jun 2026 18:47:46 +0000 (14:47 -0400)] 
allow rollback within _prepare_impl on twophase prepare failure

When tpc_prepare() raised during SessionTransaction._prepare_impl(),
the error handler's call to self.rollback() was blocked by the
@declare_states decorator, which had set _next_state to
CHANGE_IN_PROGRESS. This caused IllegalStateChangeError to be raised
instead of the original database exception, masking the real error
and preventing proper cleanup.

Used _expect_state(SessionTransactionState.CLOSED) to temporarily
allow the rollback state transition, matching the existing pattern
used in commit() for the close() call.

Fixes: #13356
Change-Id: Ie8212d5b6f8515340cf9d83c56dcbfa5a7415812

2 weeks agoMerge "send execution options to connection also" into main
Michael Bayer [Tue, 9 Jun 2026 18:34:29 +0000 (18:34 +0000)] 
Merge "send execution options to connection also" into main

2 weeks agoMerge "remove legacy include_columns in index reflection" into main
Michael Bayer [Tue, 9 Jun 2026 14:23:36 +0000 (14:23 +0000)] 
Merge "remove legacy include_columns in index reflection" into main

2 weeks agorepair xid in psycopg
Federico Caselli [Fri, 5 Jun 2026 19:51:13 +0000 (21:51 +0200)] 
repair xid in psycopg

Repaired bug introduced in :ticket:`13229` where a two-phase
transaction recovery would not return the correct transaction
identifier when generating the identifiers using the ``xid()``
method of the psycopg connection.

Fixes: #13355
Change-Id: Iffe68c1701afaa678fa7b598559dd396d3f8db41

3 weeks agouse trusted publishing for PyPI wheel uploads
Mike Bayer [Fri, 5 Jun 2026 16:35:35 +0000 (12:35 -0400)] 
use trusted publishing for PyPI wheel uploads

Replace token-based PyPI authentication with OIDC trusted publishing.
Add workflow-level id-token: write permission, generate PEP 740
attestations using pypi-attestations, and upload with
twine --attestations.  Removes the pypi_token secret dependency.

Closes: #13324
Change-Id: I75d8eab7ade7be61ed86d773ea2403cd484c81dd

3 weeks agoMerge "minor code improvement to the mssql multi reflection" into main
Michael Bayer [Fri, 5 Jun 2026 14:25:26 +0000 (14:25 +0000)] 
Merge "minor code improvement to the mssql multi reflection" into main

3 weeks agoMerge "Register func.any(), func.all(), func.some() as collection aggregates" into...
Michael Bayer [Fri, 5 Jun 2026 14:08:03 +0000 (14:08 +0000)] 
Merge "Register func.any(), func.all(), func.some() as collection aggregates" into main

3 weeks agominor code improvement to the mssql multi reflection
Federico Caselli [Thu, 4 Jun 2026 22:47:52 +0000 (00:47 +0200)] 
minor code improvement to the mssql multi reflection

improve caching and remove redundant flag

Change-Id: I46ee752c908227667a281bd4d436fac2b43b0d8e

3 weeks agoremove legacy include_columns in index reflection
Federico Caselli [Thu, 4 Jun 2026 21:23:46 +0000 (23:23 +0200)] 
remove legacy include_columns in index reflection

Removed the legacy ``include_columns`` key from the dictionary returned
by the index reflection methods of some dialects.
This information is now part of the ``dialect_options`` dictionary under the key
``{dialect_name}_include``, such as ``postgresql_include`` or ``mssql_include``.

Fixes: #13350
Change-Id: I9535690350d97e19477f7e9919dc4994b876af47

3 weeks agofix docs lint warning
Federico Caselli [Thu, 4 Jun 2026 21:26:13 +0000 (23:26 +0200)] 
fix docs lint warning

Change-Id: I6c8e38dc663bc0b53ab1259daab50617583ccdbb

3 weeks agoMerge "Implement native multi-table reflection API for the mssql dialect" into main
Federico Caselli [Thu, 4 Jun 2026 21:25:40 +0000 (21:25 +0000)] 
Merge "Implement native multi-table reflection API for the mssql dialect" into main

3 weeks agoImplement native multi-table reflection API for the mssql dialect
Gaurav Sharma [Wed, 3 Jun 2026 12:52:09 +0000 (08:52 -0400)] 
Implement native multi-table reflection API for the mssql dialect

### Description

Adds 5 native `get_multi_*` reflection methods (columns, pk, fk, indexes, table_comment) for the MSSQL dialect, replacing the per-table loop in `_default_multi_reflect`. Single-table methods now delegate to the multi versions (PG/Oracle pattern); legacy per-table SQL is retained as `_internal_get_*` helpers, used only for tempdb reflection.

Not implemented here: `get_multi_unique_constraints`, `get_multi_check_constraints`, `get_multi_table_options` -MSSQL has no single-table counterparts to delegate from. Happy to add as a follow-up.

### Performance

Measured with `test/perf/many_table_reflection.py` against SQL Server 2022 (Docker, localhost, pyodbc + ODBC Driver 18) on a 250-table fixture, 15-50 cols, with PKs/FKs/indexes/comments:

| | single | multi | speedup |
|---|---|---|---|
| `get_columns` | 1.33s | 0.35s | 3.8x |
| `get_pk_constraint` | 1.41s | 0.08s | 18x |
| `get_foreign_keys` | 7.07s | 0.19s | 37x |
| `get_indexes` | 0.80s | 0.09s | 8.6x |
| `get_table_comment` | 0.71s | 0.05s | 14x |
| **MetaData.reflect** | **12.62s** | **1.15s** | **11x** |

### Checklist

This pull request is:

- [x] A new feature implementation
- Fixes: #8430
- Tests added in `test/dialect/mssql/test_reflection.py`
- Changelog entry: `doc/build/changelog/unreleased_21/8430.rst`

Closes: #13297
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13297
Pull-request-sha: 2c6c69f159225f85312e39d99222279ef8cbadd1

Change-Id: I525c60fc5ece94dd250f376b05b64b09e65ca0d7

3 weeks agoRemoved erroneous debug print (#13349)
Bradley Davis [Thu, 4 Jun 2026 19:51:32 +0000 (12:51 -0700)] 
Removed erroneous debug print (#13349)

3 weeks agoMerge "Perf/conditional unique selectinload" into main
Federico Caselli [Thu, 4 Jun 2026 19:50:15 +0000 (19:50 +0000)] 
Merge "Perf/conditional unique selectinload" into main

3 weeks agoimprove typed column migration docs
Federico Caselli [Thu, 4 Jun 2026 19:33:19 +0000 (21:33 +0200)] 
improve typed column migration docs

Change-Id: I402580004d1c0d8583ebc9e2852f38d687ba6ae8

3 weeks agosend execution options to connection also
Mike Bayer [Wed, 3 Jun 2026 13:46:19 +0000 (09:46 -0400)] 
send execution options to connection also

Session level :paramref:`_orm.Session.execution_options` now take
effect for Core level SQL emitted by unit of work operations, in
addition to their existing use within ORM statement executions.
This is to provide for Core options such as
:paramref:`_engine.Connection.execution_options.schema_translate_map`
to be applicable to a :class:`.Session` overall.

Fixes: #13346
Change-Id: Icb453b7925f1bc38f30538d7726d222842bc65bd

3 weeks agoRegister func.any(), func.all(), func.some() as collection aggregates
Mike Bayer [Thu, 4 Jun 2026 14:17:06 +0000 (10:17 -0400)] 
Register func.any(), func.all(), func.some() as collection aggregates

Added CollectionAggregateFunction base class that sets
_is_collection_aggregate = True, and registered any_, all_, some_
as subclasses so that func.any(), func.all(), and func.some() correctly
prevent operator flipping on negation. Previously ~(col == func.any(arr))
would incorrectly compile to col != any(arr) instead of
NOT (col = any(arr)), which has different semantics for collection
aggregate comparison modifiers.

Also extended the _construct_for_op guard to check both left and right
operands for _is_collection_aggregate, since func.any(arr) can appear
on either side of a comparison unlike the standalone any_() construct
which auto-reverses operands.

Fixes: #13343
Change-Id: Id4774938876dc7f1f38cf143dccfe3c8ddba464d

3 weeks agoPerf/conditional unique selectinload
Oliver Parker [Wed, 3 Jun 2026 06:51:13 +0000 (02:51 -0400)] 
Perf/conditional unique selectinload

Optimized :func:`_orm.selectinload` to skip the ``.unique()`` call on inner
result sets when no nested :func:`_orm.joinedload` on a collection is
present.  The uniquing pass is only required when a joined eager load
inflates rows due to a one-to-many or many-to-many JOIN; in the common case
of a leaf selectin load, rows are already unique by construction and the
per-row hashing overhead can be avoided. As a side effect, ``yield_per``
set in a ``do_orm_execute`` event for a :func:`_orm.selectinload`
relationship load no longer raises ``InvalidRequestError`` when no nested
collection joinedload is in effect, since ``.unique()`` is no longer called
in that path. Pull request courtesy Oliver Parker.

`_SelectInLoader._load_via_parent` and `_load_via_child` currently call
`.unique()` unconditionally on the inner `Result`. The uniqueness pass is only
required when a nested `joinedload` on a collection is in effect — in that case
the `JOIN` inflates rows (one row per `(child, grandchild)` instead of one per
child) and the outer `groupby` would produce duplicated entries without dedup.

`loading.instances()` already signals exactly this condition: it sets
`Result._unique_filter_state` to a `require_unique` guard when the inner
compile state has `multi_row_eager_loaders=True`. When that flag is unset (no
nested collection `joinedload`), `_unique_filter_state` stays `None`, meaning
the inner query produces unique rows by construction:

- `omit_join` 1:N — one row per child
- `omit_join` M2O — one row per parent
- `omit_join` M2M — one row per (parent, entity)
- `load_with_join` (non-omit) — one row per (parent, child)

This PR makes the `.unique()` call conditional, via a new `_has_unique_filter`
property on `Result` that exposes this state without reaching into the private
`_unique_filter_state` attribute directly:

```python
if result._has_unique_filter:
    result = result.unique()
```

Per-row hashing in `_iterator_getter` is avoided in the common leaf-load case.
On an in-memory SQLite bench (2000 parents × 5 children + M:N tags, Python
3.14, n=1000 iterations):

| Workload | before avg | after avg | delta | before sd | after sd |
|---|---|---|---|---|---|
| selectin children (1:N) | 56.0 ms | 41.4 ms | **−26%** | 5.2 ms | 1.9 ms |
| selectin tags M2M | 25.6 ms | 20.0 ms | **−22%** | 4.2 ms | 3.1 ms |
| joined children (1:N) | 42.9 ms | 37.6 ms | ~0% | — | — |
| plain parent load | 4.2 ms | 3.6 ms | ~0% | — | — |

**Behaviour change:** `yield_per` set in a `do_orm_execute` event for a
relationship load no longer raises
`InvalidRequestError("Can't use yield_per in conjunction with unique")` for
`selectinload` without a nested collection `joinedload` — because `.unique()`
is no longer called in that path. `immediateload` is unaffected (it still calls
`.unique()` unconditionally).

Fixes: #13339
Closes: #13341
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13341
Pull-request-sha: 980af0383b174271bb602a890f595c26f78ddcee

Change-Id: I12e993f104d354ae894f81f9b09fbcf9a95b0027

3 weeks agoHoist loop-invariant set intersection in _get_display_froms
sebastianbreguel [Sun, 31 May 2026 20:12:19 +0000 (16:12 -0400)] 
Hoist loop-invariant set intersection in _get_display_froms

Fixes #13336.

`SelectState._get_display_froms` recomputed a loop-invariant `_cloned_intersection(...)` once per FROM element in each of the three correlation comprehensions, making each branch O(N²) in the number of FROM elements. This hoists the call so it runs once, which is O(N).

`_cloned_intersection` / `_cloned_difference` are pure and return a set, and neither argument changes during the comprehension, so the result is identical. A function-level benchmark asserts `old == new` at every N (full numbers in #13336), and `test/sql/` plus the ORM compilation/query tests pass: 7442 passed, 359 skipped. Net -14 lines.

Per the issue discussion, no changelog entry is included.

### Checklist

This pull request is:

- [x] A short code fix
  - Issue with a runnable demonstration: #13336
  - Behavior-preserving (no logic change), so it is covered by the existing `test/sql/` and ORM compilation/query suites rather than adding new tests.

Closes: #13337
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13337
Pull-request-sha: beba43e77a773a4d9e9d55cc39c7c85ecda6293e

Change-Id: I95b02ffa66ef709c16bf5275924ec03244c19ecb

4 weeks agoAdd ambiguous column support to SimpleResultMetaData
me-saurabhkohli [Fri, 29 May 2026 20:03:40 +0000 (16:03 -0400)] 
Add ambiguous column support to SimpleResultMetaData

Fixed issue where :meth:`.Result.freeze` would lose track of ambiguous
column names present in the original :class:`.CursorResult`, causing
key-based access on the thawed result to silently return a value instead of
raising :class:`.InvalidRequestError`.  The
:class:`.SimpleResultMetaData` now accepts and propagates ambiguous key
information so that frozen, thawed, and pickled results raise consistently
for duplicate column names.  Pull request courtesy Saurabh Kohli.

Fixes: #9427
Closes: #13335
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13335
Pull-request-sha: c03904ece298493ca69bf6e9cbdae23c7fb6a7b0

Change-Id: Ia184f77b442b069e6f9a4f94a967ead41a1704b6

4 weeks agoMerge "allow backref named 'metadata' to not break _metadata_for_cls" into main
Michael Bayer [Thu, 28 May 2026 16:37:00 +0000 (16:37 +0000)] 
Merge "allow backref named 'metadata' to not break _metadata_for_cls" into main

4 weeks agoallow backref named 'metadata' to not break _metadata_for_cls
Mike Bayer [Thu, 28 May 2026 14:25:39 +0000 (10:25 -0400)] 
allow backref named 'metadata' to not break _metadata_for_cls

Fixed regression caused by :ticket:`8068` where a ``backref``
named ``'metadata'`` on a mapped class would cause an
``AssertionError`` when the class also used string-based
relationship references (e.g. ``secondary="some_table"``).
The ``_metadata_for_cls()`` helper now checks
``isinstance(meta, MetaData)`` as a condition rather than
asserting, falling back to ``registry.metadata`` when the
class attribute has been overwritten by a backref.

A warning is now emitted when a Declarative attribute name is named
``metadata`` or ``registry``.  Previously, no warning was emitted for
``registry``, and using the name ``metadata`` would raise an
InvalidRequestError.   Since these names can be used for attributes
that are mapped as backrefs or using imperative mappings, usage
under Declarative has been relaxed for ``metadata`` but also warns
for both names as they may have unintended interactions with the
Declarative reserved names.

References: https://bugs.launchpad.net/nova/+bug/2154165
References: https://github.com/sqlalchemy/sqlalchemy/discussions/8619

Fixes: #13333
Change-Id: I0f3173bce9c8c8881bd6b8ea75102bb8ec92be8b

4 weeks agoMerge "Fix subqueryload losing .and_() criteria when combined with of_type()" into...
Michael Bayer [Thu, 28 May 2026 14:16:47 +0000 (14:16 +0000)] 
Merge "Fix subqueryload losing .and_() criteria when combined with of_type()" into main

4 weeks agoMerge "Fix lambda statements with non-lambda criteria" into main
Michael Bayer [Thu, 28 May 2026 14:16:16 +0000 (14:16 +0000)] 
Merge "Fix lambda statements with non-lambda criteria" into main

4 weeks agoFix lambda statements with non-lambda criteria
cjc0013 [Mon, 25 May 2026 16:46:50 +0000 (12:46 -0400)] 
Fix lambda statements with non-lambda criteria

Fixed issue where :class:`_sql.StatementLambdaElement` would proxy
attribute access through the cached "expected" expression rather than the
resolved expression, causing stale closure-bound parameter values to be
used when a lambda statement was extended with non-lambda criteria such as
an additional ``.where()`` clause.  Courtesy cjc0013.

Fixes: #10827
Closes: #13327
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13327
Pull-request-sha: ec3e6735bf95d62d768f214dd5a49bbfc4fecaa5

Change-Id: I8a32c11f3da63109cf37c39541df8ebfee52b8c5

4 weeks agoFix subqueryload losing .and_() criteria when combined with of_type()
Arya Rizky [Tue, 12 May 2026 19:08:02 +0000 (15:08 -0400)] 
Fix subqueryload losing .and_() criteria when combined with of_type()

Fixed issue where :func:`_orm.subqueryload` combined with
:meth:`.PropComparator.of_type` and :meth:`.PropComparator.and_` would
silently drop the additional filter criteria, causing all related objects
to be loaded instead of only those matching the filter.  The
:class:`.LoaderCriteriaOption` was being constructed against the base
entity rather than the effective entity indicated by
:meth:`.PropComparator.of_type`.  Pull request courtesy Arya Rizky.

Fixes: #13207
Closes: #13290
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13290
Pull-request-sha: b7a8617cdee3757f4af4abdb4ff0090d69bb1fb5

Change-Id: I2c24652ec112511deaf39dbb9d6197e2097904ed

4 weeks agoomit_join optimization for selectinload on many-to-many relationships
bekapono [Mon, 18 May 2026 16:29:50 +0000 (12:29 -0400)] 
omit_join optimization for selectinload on many-to-many relationships

The :func:`.selectinload` loader strategy now selects the ``omit_join``
optimization for many-to-many non-self-referential relationships, reducing
the number of joins in the secondary SELECT by selecting from the secondary
table directly rather than joining back to the parent entity. ``omit_join``
is enabled automatically when the join condition determines that the
secondary table's foreign keys fully cover the parent's primary key. As
always, ``omit_join`` can be disabled by setting
:paramref:`.relationship.omit_join` to ``False``. Pull request courtesy
bekapono.

Fixes: #5987
Closes: #13278
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13278
Pull-request-sha: fdd9847e7db041be51160853c075b1427f7be051

Change-Id: Ib68f8e2be1399222383cdd7b55793fe88402212c

4 weeks agoFix Session bulk mappings typing for mapped classes
proto-atlas [Mon, 25 May 2026 19:14:40 +0000 (15:14 -0400)] 
Fix Session bulk mappings typing for mapped classes

Fixes #9256.

This updates the annotations for Session.bulk_insert_mappings() and Session.bulk_update_mappings().

The docstrings and runtime behavior already allow either a mapped class or a Mapper object, but the previous annotations only accepted Mapper[Any].

This patch switches those arguments to the existing _EntityBindKey alias, which matches the inputs accepted by _class_to_mapper(): mapped classes and Mapper objects, but not AliasedClass or AliasedInsp.

I also updated the internal _bulk_save_mappings() annotation so the public methods and the private helper stay consistent. The scoped_session proxy output has been kept in sync with tools/generate_proxy_methods.py, and the generator check passes.

I added a typing regression test covering both mapped classes and Mapper objects for the two bulk mapping methods. I confirmed that the mapped-class cases fail with the old annotation and pass with this change.

Checked locally:

python -m pytest -m mypy test/typing/test_mypy.py -k "session.py" -q
python -m mypy ./lib/sqlalchemy
python tools/generate_proxy_methods.py --check
python -m pytest test/orm/dml/test_bulk.py -q
python -m pytest -m mypy test/typing/test_mypy.py -k "not typed_queries.py" -q

I could not run the full typing suite locally because my local Python 3.12 environment does not include string.templatelib. I only skipped typed_queries.py; that file is expected to be covered by SQLAlchemy's Python 3.14 mypy CI job.

Closes: #13322
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13322
Pull-request-sha: bb730f34275a7c40c94e668ecda1131804ba3084

Change-Id: I4c5d516b3933b4e7fae9c844881a61f557a8bb5e

4 weeks agocherry-pick changelog update for 2.0.51
Mike Bayer [Sun, 24 May 2026 19:20:50 +0000 (15:20 -0400)] 
cherry-pick changelog update for 2.0.51

4 weeks agocherry-pick changelog from 2.0.50
Mike Bayer [Sun, 24 May 2026 19:20:49 +0000 (15:20 -0400)] 
cherry-pick changelog from 2.0.50

4 weeks agodont produce side effects for do_orm_execute
Mike Bayer [Fri, 22 May 2026 20:01:10 +0000 (16:01 -0400)] 
dont produce side effects for do_orm_execute

Fixed issue where the presence of a :meth:`.SessionEvents.do_orm_execute`
event hook would cause internal execution options such as ``yield_per`` and
loader-specific state from the first ``orm_pre_session_exec`` pass to leak
into the second pass, leading to errors when using relationship loaders
such as :func:`.selectinload` and :func:`.immediateload`.  The execution
options passed to the second compilation pass are now based on the original
options plus only the explicit updates made via
:meth:`.ORMExecuteState.update_execution_options` within the event hook.

Fixes: #13301
Change-Id: Ide64d7202102930b68a2ab903054d538cd2f99dd

5 weeks agoMerge "user_defined_options returns memoized options" into main
Michael Bayer [Sat, 23 May 2026 01:32:16 +0000 (01:32 +0000)] 
Merge "user_defined_options returns memoized options" into main

5 weeks agouser_defined_options returns memoized options
Federico Caselli [Tue, 19 May 2026 21:39:49 +0000 (23:39 +0200)] 
user_defined_options returns memoized options

Updated the attribute :attr:`_orm.ORMExecuteState.user_defined_options` to
include options that were added to the statement before calling
:meth:`.Select.with_only_columns` or :meth:`_orm.Query.with_entities`.

Fixes: #13309
Change-Id: Ie6e3f46662542010f4d524820ae697638f36d459

5 weeks agoMerge "Fix ExcludeConstraint not forwarding info to parent constructor" into main
Michael Bayer [Wed, 20 May 2026 21:02:33 +0000 (21:02 +0000)] 
Merge "Fix ExcludeConstraint not forwarding info to parent constructor" into main

5 weeks agoMerge "implement _post_inspect for AliasedInsp" into main
Michael Bayer [Wed, 20 May 2026 21:02:02 +0000 (21:02 +0000)] 
Merge "implement _post_inspect for AliasedInsp" into main

5 weeks agoimplement _post_inspect for AliasedInsp
Mike Bayer [Wed, 20 May 2026 19:59:10 +0000 (15:59 -0400)] 
implement _post_inspect for AliasedInsp

Fixed issue where using :func:`_orm.with_polymorphic` on a leaf class (a
subclass with no further descendants) or a non-inherited class would fail
with an ``AttributeError`` when used in an ORM statement, due to
:func:`_orm.configure_mappers` not being triggered implicitly. The fix
ensures that :class:`.AliasedInsp` participates in the ``_post_inspect``
hook, triggering mapper configuration during ORM statement compilation.

Fixes: #13319
Change-Id: Ic5910474676be41f8c815dc72c38fca8e20cdeb9

5 weeks agoFix ExcludeConstraint not forwarding info to parent constructor
WiktorB2004 [Wed, 20 May 2026 20:05:41 +0000 (16:05 -0400)] 
Fix ExcludeConstraint not forwarding info to parent constructor

Fixed issue where the :class:`.ExcludeConstraint` construct did not
correctly forward the :paramref:`.ExcludeConstraint.info` parameter to
the superclass, causing user-defined metadata to be lost. Pull request
courtesy Wiktor Byrka.

Fixes: #13317
Closes: #13316
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13316
Pull-request-sha: be7f4fee2c40d1986519e93145471faad61021af
Change-Id: Idc4846f02127d1d39a8c638cb03b0379932e9fd6

5 weeks agoMerge "Fix joinedload + of_type() + and_() invalid SQL for subclass columns" into...
Michael Bayer [Wed, 20 May 2026 20:02:35 +0000 (20:02 +0000)] 
Merge "Fix joinedload + of_type() + and_() invalid SQL for subclass columns" into main

5 weeks agoMerge "Fix floordiv (//) for float/numeric by int with div_is_floordiv dialects"...
Michael Bayer [Wed, 20 May 2026 19:53:18 +0000 (19:53 +0000)] 
Merge "Fix floordiv (//) for float/numeric by int with div_is_floordiv dialects" into main

5 weeks agoFix joinedload + of_type() + and_() invalid SQL for subclass columns
Joaquin Hui Gomez [Wed, 1 Apr 2026 17:29:38 +0000 (13:29 -0400)] 
Fix joinedload + of_type() + and_() invalid SQL for subclass columns

Fixed issue where using :func:`_orm.joinedload` with
:meth:`.PropComparator.of_type` targeting a joined-table subclass combined
with :meth:`.PropComparator.and_` referencing a column on that subclass
would generate invalid SQL, where the subclass column was not adapted to
the subquery alias.  Pull request courtesy Joaquin Hui Gomez.

Fixes #13203

Closes: #13206
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13206
Pull-request-sha: ba55b0c3e2a8dae28a1c7d7ae646e3480a04425c

Change-Id: I78fe4672649d1d5498e3bc653e5d943ccb55dafd

5 weeks agoFix floordiv (//) for float/numeric by int with div_is_floordiv dialects
OSS Contributor [Mon, 23 Mar 2026 14:44:40 +0000 (10:44 -0400)] 
Fix floordiv (//) for float/numeric by int with div_is_floordiv dialects

Fixed issue where floor division (``//``) between a :class:`.Float` or
:class:`.Numeric` numerator and an :class:`.Integer` denominator would omit
the ``FLOOR()`` SQL wrapper on dialects where
:attr:`.Dialect.div_is_floordiv` is ``True`` (the default, including
PostgreSQL and SQLite).  ``FLOOR()`` is now applied if either the
denominator or the numerator is a non-integer, so that expressions such as
``float_col // int_col`` render as ``FLOOR(float_col / int_col)`` instead
of the incorrect ``float_col / int_col``.  Pull request courtesy r266-tech.

Fixes: #10528
Closes: #13191
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13191
Pull-request-sha: c9cbc47c877e19c91f912556b4ead6cd26e3cfe6

Change-Id: I5f9f02d966aa6ccee214a2c5cc27a73a4292da03

5 weeks agoFix trivial PyPy failures
mattip [Wed, 20 May 2026 17:47:17 +0000 (13:47 -0400)] 
Fix trivial PyPy failures

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description

Fixes: #13274
References: #9154

There were two relatively causes to some of the ~21 failures on PyPy:
- weakrefs may be deleted but the objects not finalized on PyPy. This manifests as `ref.obj() is None` I added a test for the `release()` case that also failed on CPython before the fix.
- a condition added in 2022 for missing sqllite3 behaviour is no longer necessary, and is now causing a failure

In order to run the changes in CI, I added PyPy to the PR CI run. Before merging I will revert that change. There are still a number of failures with PyPy around different error messages, different inspect.signatures and one sticky problem with the pure-python datetime.py that actually comes from CPython. I will continue to work on them, but they are not specific to sqlalchemy.

Note the CI run is ~6 minutes where the CPython ones are ~3 minutes. This is expected, since PyPy's JIT does not kick in on short tests, and the base compiler is about 2x slower.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed
- [x] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #13276
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13276
Pull-request-sha: 00472f32f64827325f071150e8b6ecf1fbe9f22e

Change-Id: Id5d4ba37cf8db2345a948f973d7b1710910359a1

5 weeks agoMerge "document postgresql_nulls_not_distinct" into main
Michael Bayer [Wed, 20 May 2026 14:05:36 +0000 (14:05 +0000)] 
Merge "document postgresql_nulls_not_distinct" into main

5 weeks agoAdjust TypeError message to Python 3.15
Karolina Surma [Tue, 19 May 2026 14:20:38 +0000 (10:20 -0400)] 
Adjust TypeError message to Python 3.15

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
The `.fromisoformat()` error message tested in `test_no_string()` changed in Python 3.15, this fixes the test.

See #13308 for the `rel_2_0` branch.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed
- [x] A short code fix (in a test, therefore I didn’t create an issue)
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #13307
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13307
Pull-request-sha: 90bc13fc416ea45ba5429d5f8ecffc24b108c1b1

Change-Id: I461d71b0fad18fa4f108102bb1c22c0e980fc70e

5 weeks agorobustly handle reconnect param across all pymysql variants
Mike Bayer [Tue, 19 May 2026 13:40:01 +0000 (09:40 -0400)] 
robustly handle reconnect param across all pymysql variants

Fixed issue in aiomysql and asyncmy dialects that appears as of using
pymysql 1.2.0; the dialects were not properly taking into account logic
that detects the argument signature of pymysql's ``ping()`` method which
was added as part of :ticket:`10492`.

We add a "does ping have reconnect" check for all three DBAPIs
individually.  To suit asyncmy's use of cython we also needed to
adjust vendored getargspec() routines.

Fixes: #13306
Change-Id: Iad90ec6cfe9ee3b99736dd2153264090e7f76be1

5 weeks agoMerge "Postgresql default to no backslash escaping" into main
Michael Bayer [Mon, 18 May 2026 16:31:37 +0000 (16:31 +0000)] 
Merge "Postgresql default to no backslash escaping" into main

5 weeks agoMerge "resolve table names using MetaData.schema default in declarative registry...
Michael Bayer [Mon, 18 May 2026 16:11:48 +0000 (16:11 +0000)] 
Merge "resolve table names using MetaData.schema default in declarative registry" into main

5 weeks agoresolve table names using MetaData.schema default in declarative registry
Mike Bayer [Thu, 30 Apr 2026 19:13:39 +0000 (15:13 -0400)] 
resolve table names using MetaData.schema default in declarative registry

Also resolved class-level MetaData not being consulted by the
declarative class registry when resolving string-based table
references.  The registry now uses the same metadata resolution
logic as table creation, checking for a class-specific ``metadata``
attribute before falling back to ``registry.metadata``.  The
``_metadata_for_cls`` function was factored into ``orm/util.py``
for shared use by both ``decl_base.py`` and ``clsregistry.py``.

Fixes: #8068
Fixes: #13291
Change-Id: Ib846be0267f9295a5fee945dc6cf0a72c237bd2c

5 weeks agoMerge "Block Result.unique() with Result.yield_per() for ORM results" into main
Michael Bayer [Mon, 18 May 2026 12:24:26 +0000 (12:24 +0000)] 
Merge "Block Result.unique() with Result.yield_per() for ORM results" into main

5 weeks agodocument postgresql_nulls_not_distinct
David Lord [Sun, 17 May 2026 20:09:16 +0000 (16:09 -0400)] 
document postgresql_nulls_not_distinct

<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
<!-- Describe your changes in detail -->

https://github.com/sqlalchemy/sqlalchemy/issues/8240 and https://github.com/sqlalchemy/sqlalchemy/pull/9834 added support for `NULLS NOT DISTINCT` to the PostgreSQL dialect, but didn't add it to the docs (only the change log). This adds a section to the "Constraint Options" section of the PostgreSQL dialect docs.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [x] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #13279
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/13279
Pull-request-sha: cdc858cd88fbf86661662147210f9587117aa593

Change-Id: I3f2c8fe346d3235fa8ba12c4d9ab712ddb840230

5 weeks agoadd update to black 26.3.1 commit to blame ignore
Federico Caselli [Sun, 17 May 2026 20:05:26 +0000 (22:05 +0200)] 
add update to black 26.3.1 commit to blame ignore

Change-Id: I98dbccf0b60d7672627736bbc20a7a6a27fba22a

5 weeks agoremove redundant deserializer assignment from asyncpg dialect (#13287)
Henry Cai [Sun, 17 May 2026 20:02:37 +0000 (13:02 -0700)] 
remove redundant deserializer assignment from asyncpg dialect (#13287)

6 weeks agoBlock Result.unique() with Result.yield_per() for ORM results
Mike Bayer [Tue, 12 May 2026 18:30:37 +0000 (14:30 -0400)] 
Block Result.unique() with Result.yield_per() for ORM results

The unique() + yield_per combination was only blocked when yield_per
was set via execution_options(yield_per=N); calling these as methods
on the result (e.g. result.unique().yield_per(N)) bypassed the check
and silently produced incorrect results.

Restructured _unique_filters on SimpleResultMetaData to be a callable
_create_unique_filters that receives the Result, allowing it to check
the yield_per state regardless of how it was activated.

Fixes: #13293
Change-Id: I7e6a5e5b2e1d4c8f9a0b3d6e7f1c2a4d5b8e9f0a

6 weeks agoMerge "populate existing can be in exec option in session.get" into main
Michael Bayer [Tue, 12 May 2026 13:03:37 +0000 (13:03 +0000)] 
Merge "populate existing can be in exec option in session.get" into main

6 weeks agoupdate to black 26.3.1
Federico Caselli [Fri, 8 May 2026 20:48:58 +0000 (22:48 +0200)] 
update to black 26.3.1

Closes: #13280
Change-Id: Ifbb77dd6d2a1c228ae97fcf8160f40e975edc57c

6 weeks agopopulate existing can be in exec option in session.get
Federico Caselli [Wed, 29 Apr 2026 21:09:57 +0000 (23:09 +0200)] 
populate existing can be in exec option in session.get

The ``populate_existing`` execution option is now honored when passed
in the :paramref:`.Session.get.execution_options` dict by the method
:meth:`.Session.get` and analogous in other session kinds. The current
:paramref:`.Session.get.populate_existing` parameter will takes precedence
if specified, overriding the value of the execution options.

Fixes: #10610
Change-Id: I4ddc9a7c6dda8f31f4dd413b49a9196efb3edaa6