tests/string.c: add test function for time formatting

Signed-off-by: Rico Hoppe <rico.hoppe@ipfire.org>

src/string: implement macro for function pakfire_format_speed

Signed-off-by: Rico Hoppe <rico.hoppe@ipfire.org>

tests/string.c: implemented a test for the pakfire_format_speed function

Signed-off-by: Rico Hoppe <rico.hoppe@ipfire.org>

archive: Increase the block size

This will use a little bit more memory per opened archive, but will make
extraction somewhat faster. Extracting the snapshot shrinks from about
25 to 23 seconds on my system.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Don't try to set fadvise() on an invalid fd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Ensure r is always set correctly

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fix setting the error message

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Ensure we are only opening regular files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

key: Make dumping a key less braindead

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Remove function to read file contents into a buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Map JSON strings into memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

keys: Map them into memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Map scripts instead of reading them

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

PTY: Check if we have a file descriptor before reading from it

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Don't try to sync installed packages

There should never be any installed packages here.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Rename to self

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Return pointer without touching the reference counter

Hopefully this will make the static analyzer happier.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Ignore locked snapshots and keep cleaning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Fix logic error and process directories

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Always try to clean up after we created a new snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Only consider directories or symlinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Only use snapshots when they are not older than 24 hrs

The chosen age might be a little bit short, but we can try...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Clang does not seem to like if we are checking for NULL

The function is delcared with nonnull(), and therefore Clang complains
that we are actually checking this again. Probably fair.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Sanitize format strings for the format function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Always require a configuration

It is pretty pointless to run Pakfire without configuration and so we
can keep the code a bit more tidy.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Reset umask to 022

Fixes: #13806
Reported-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Don't overwrite package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Allow creating a package without returning it

This is useful when we simply want to add the package to a repository.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Rename push to add

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Refactor using binary search

This will keep the list sorted at all times and inserts will be a lot
faster than using the iteration over the linked lists.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Make conversion to package list static

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Simplify adding all build packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Refactor copying packages after the build

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Drop the package list and iterate over the repo instead

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Add convenience function to iterate over all packages in a repo

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Free namespaces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Return an archive

This is an attempt to have the packager return an object instead of a
loose path so that we can do more things with the result.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fail if we were not given a package pointer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Add function to unlink an archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Add function to format a path and normalize it straight away

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Refactor composing the filename

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Stop expanding variables if the string becomes empty

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Always copy the namespace to the stack

This avoids using strdupa() which will result in those functions not
being possible to be inlined.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Simplify declaration matching

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parsers: Statically allocate the namespace

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Slightly improve expanding variables

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor stripping namespaces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Don't try to expand empty strings

This is just a fast path to avoid doing unnecessary work.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Cleanup expanding variables

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Compile regular expressions only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Remove a dead assignment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Write a better implementation to replace newlines

This performs the operating on the existing buffer and should be more
straight forward than the previous one.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Use existing string functions for copying strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Avoid a potential double-free on early exits

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Fix return code handling when merging parsers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor reading from file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Map the data into buffer to read it faster

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Create a convenience function to map files into memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor listing namespaces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add a function to search for a match in string array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Use string functions to manage filelists

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Minor cleanup when searching for a template

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor creating declarations

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Tidy up for finding declarations

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor joining strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor creating a new parser

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Free the context after reading the makefile

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix the parser tester

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Free transaction after performing the install check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Release the context after we are done

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Fail if the context wasn't freed in the end

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Make the buffers significantly smaller

We don't really need that much buffer space here and it probably allows
for better CPU caching if the entire struct is smaller.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Refactor processing Perl dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Implement to stream a filelist into stdin

This is an improved implementation that even supports writing some data
if there is not enough buffer space to write the full filename at once.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify mounting the ccache

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Only copy regular source files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: In build mode, always install the best set of packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Allow uninstalling and downgrading packages

This is required if we want to be able to obsolete things here.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Don't try to perform ELF checks on start files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Package /usr/lib*/cmake in development packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Support stripping binaries without a Build ID

We should not have these in practise, but there might be cases where we
cannot extract the ID correctly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify error message when build dependencies cannot be installed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add a function to dump a string array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Don't uninstall source packages by accident

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Call pool_setarchpolicy() directly

This will avoid any builtin logic from libsolv which considers ix86
alternatives which we don't support here.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Skip any invalid DWARF sections

On some start files in glibc, this error is thrown and I think it is
safe to just ignore it.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Actually return NULL if there is no Build ID

Before, we allocated an empty string which is unnecessary and confused
me further down the line.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Ensure to register SIGWINCH in the parent process

This makes the entire terminal resizing work again...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progressbar: Fix integer underflow

It could happen that we required more space than had and then the
expandable part of the progressbar became negative.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Add the debuglink only when we have extracted the debuginfo

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add function to merge multiple strings into an array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Create directories where we are creating the files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Rename functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Don't try to extract debuginfo from *.o files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Strip any LTO information

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Rename to self

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip script interpreter check for ELF files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip linting kernel modules

There is pretty much nothing we can do with them.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Move skipping files we never want to lint

This saves us from initializing the linter and reading the entire
payload.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Remove extra step when installing any custom packages

Since there is only one place where this happens, we can also add this
all to the existing large transaction.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>