]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agoHave all operand tokenization and casting occur within the tmpl code xlat_expr_tmpl_only
Arran Cudbard-Bell [Fri, 28 Jan 2022 22:25:51 +0000 (16:25 -0600)] 
Have all operand tokenization and casting occur within the tmpl code

The idea here is we do conversions later in resolution functions and convert all the tmpl types back into specialised xlat node types at that point.   After resolution is complete we're in a much better situation to know whether we'll have to do runtime casting or not.

3 years agoStill needs linking to the normal libraries apparently
Arran Cudbard-Bell [Fri, 28 Jan 2022 22:11:47 +0000 (16:11 -0600)] 
Still needs linking to the normal libraries apparently

3 years agotmpl rules can be NULL
Arran Cudbard-Bell [Fri, 28 Jan 2022 22:04:37 +0000 (16:04 -0600)] 
tmpl rules can be NULL

3 years agoAdd support for floats as barewords
Arran Cudbard-Bell [Fri, 28 Jan 2022 21:35:10 +0000 (15:35 -0600)] 
Add support for floats as barewords

3 years agoOnly allow things which look like enums during tokenization
Arran Cudbard-Bell [Thu, 27 Jan 2022 18:30:01 +0000 (12:30 -0600)] 
Only allow things which look like enums during tokenization

3 years agore-arrange structures to help with packing
Arran Cudbard-Bell [Fri, 28 Jan 2022 21:09:37 +0000 (15:09 -0600)] 
re-arrange structures to help with packing

3 years agoAllow tmpl rules commands to work with bitfields
Arran Cudbard-Bell [Fri, 28 Jan 2022 21:08:53 +0000 (15:08 -0600)] 
Allow tmpl rules commands to work with bitfields

3 years agoAdd binary to print out structure sizes
Arran Cudbard-Bell [Fri, 28 Jan 2022 21:08:28 +0000 (15:08 -0600)] 
Add binary to print out structure sizes

3 years agoScheduled fuzzing: More typos (#4382)
Terry Burton [Fri, 28 Jan 2022 13:56:12 +0000 (13:56 +0000)] 
Scheduled fuzzing: More typos (#4382)

3 years agoCI MacOS: Enable trunk tests (#4383)
Terry Burton [Fri, 28 Jan 2022 13:55:48 +0000 (13:55 +0000)] 
CI MacOS: Enable trunk tests (#4383)

3 years agoFix typo
Arran Cudbard-Bell [Thu, 27 Jan 2022 20:00:39 +0000 (14:00 -0600)] 
Fix typo

3 years agoJust ommit the table completely
Arran Cudbard-Bell [Thu, 27 Jan 2022 17:37:15 +0000 (11:37 -0600)] 
Just ommit the table completely

3 years agoRevert "Maybe the logging bio is stuck in an infinite loop?"
Arran Cudbard-Bell [Thu, 27 Jan 2022 17:37:07 +0000 (11:37 -0600)] 
Revert "Maybe the logging bio is stuck in an infinite loop?"

This reverts commit e745f820543f940393f8e8b3ab31d278032ce2dc.

3 years agoFix ODR violation
Arran Cudbard-Bell [Thu, 27 Jan 2022 17:23:16 +0000 (11:23 -0600)] 
Fix ODR violation

3 years agoeap-tls test: Builds using clang analyzers are slow (#4381)
Terry Burton [Thu, 27 Jan 2022 15:07:08 +0000 (15:07 +0000)] 
eap-tls test: Builds using clang analyzers are slow (#4381)

3 years agoMaybe the logging bio is stuck in an infinite loop?
Arran Cudbard-Bell [Thu, 27 Jan 2022 14:07:37 +0000 (08:07 -0600)] 
Maybe the logging bio is stuck in an infinite loop?

Given we can only reproduce this issue in CI, this is the only way to check...

3 years agonot a string
Arran Cudbard-Bell [Wed, 26 Jan 2022 19:33:42 +0000 (13:33 -0600)] 
not a string

3 years agoScheduled fuzzing: Typo (#4380)
Terry Burton [Thu, 27 Jan 2022 14:00:10 +0000 (14:00 +0000)] 
Scheduled fuzzing: Typo (#4380)

3 years agoadd target-specific rules, and a "help" line
Alan T. DeKok [Wed, 26 Jan 2022 19:36:19 +0000 (14:36 -0500)] 
add target-specific rules, and a "help" line

3 years agoMinor documentation fixes. Closes #4301
Arran Cudbard-Bell [Wed, 26 Jan 2022 19:29:49 +0000 (13:29 -0600)] 
Minor documentation fixes.  Closes #4301

3 years agorlm_python: Strip out -ffat-lto-objects (#4373)
Jorge Pereira [Wed, 26 Jan 2022 19:28:17 +0000 (16:28 -0300)] 
rlm_python: Strip out -ffat-lto-objects (#4373)

3 years agoSame deal with fr_value_box_memdup
Arran Cudbard-Bell [Wed, 26 Jan 2022 19:25:19 +0000 (13:25 -0600)] 
Same deal with fr_value_box_memdup

3 years agoChanges to make test_requeue_on_reconnect() work (#4372)
James Jones [Wed, 26 Jan 2022 19:04:27 +0000 (13:04 -0600)] 
Changes to make test_requeue_on_reconnect() work (#4372)

* Can't free preq until the end along with everything else, since
  otherwise, a later demux will look at it at least to validate
  talloc type and thus do a use after free, so we don't free
  separately and give it the appropriate talloc context
* Setting preq->treq after fr_trunk_request_enqueue() was missing.
* In some cases, it takes longer for the trunk request to make it
  to a stop state than the test author expected, because the trunk
  is given a request_cancel_mux function. If we should instead be
  hurrying test time along faster, we can make that change.

3 years agoExplicitly document and test for NULL input case.
Arran Cudbard-Bell [Wed, 26 Jan 2022 18:55:37 +0000 (12:55 -0600)] 
Explicitly document and test for NULL input case.

3 years agoString input for fr_value_box_bstrndup maye be NULL
Arran Cudbard-Bell [Wed, 26 Jan 2022 18:50:16 +0000 (12:50 -0600)] 
String input for fr_value_box_bstrndup maye be NULL

3 years agoCheck the result of fr_sbuff_out_aunescape_until correctly
Arran Cudbard-Bell [Wed, 26 Jan 2022 17:15:50 +0000 (11:15 -0600)] 
Check the result of fr_sbuff_out_aunescape_until correctly

3 years agoPrint functions return signed values
Arran Cudbard-Bell [Wed, 26 Jan 2022 15:27:56 +0000 (09:27 -0600)] 
Print functions return signed values

3 years agoScheduled fuzzing: Clone with greater depth to find last corpus update (#4377)
Terry Burton [Wed, 26 Jan 2022 14:47:47 +0000 (14:47 +0000)] 
Scheduled fuzzing: Clone with greater depth to find last corpus update (#4377)

3 years agoFix more warnings
Arran Cudbard-Bell [Wed, 26 Jan 2022 14:45:25 +0000 (08:45 -0600)] 
Fix more warnings

3 years agoMark more box functions up as non-null
Arran Cudbard-Bell [Wed, 26 Jan 2022 01:24:53 +0000 (19:24 -0600)] 
Mark more box functions up as non-null

3 years agoMore scan fixes
Arran Cudbard-Bell [Wed, 26 Jan 2022 00:33:50 +0000 (18:33 -0600)] 
More scan fixes

3 years agoPrint the error...
Arran Cudbard-Bell [Tue, 25 Jan 2022 23:19:28 +0000 (17:19 -0600)] 
Print the error...

3 years agoRemove bad asserts
Arran Cudbard-Bell [Tue, 25 Jan 2022 23:11:03 +0000 (17:11 -0600)] 
Remove bad asserts

3 years agoTypo
Arran Cudbard-Bell [Tue, 25 Jan 2022 23:01:56 +0000 (17:01 -0600)] 
Typo

3 years agoStupid compiler
Arran Cudbard-Bell [Tue, 25 Jan 2022 22:59:33 +0000 (16:59 -0600)] 
Stupid compiler

3 years agoQuiet compiler
Arran Cudbard-Bell [Tue, 25 Jan 2022 22:54:48 +0000 (16:54 -0600)] 
Quiet compiler

3 years agolet's try to shut up clang scan even more
Alan T. DeKok [Tue, 25 Jan 2022 22:12:09 +0000 (17:12 -0500)] 
let's try to shut up clang scan even more

it would be greatly appreciated if the same version of clang
produced the same errors on different platforms.

3 years agoFix more build errors in sigtran
Arran Cudbard-Bell [Tue, 25 Jan 2022 21:56:18 +0000 (15:56 -0600)] 
Fix more build errors in sigtran

3 years agoBreak out MEMCMP_RETURN into an inline function
Arran Cudbard-Bell [Tue, 25 Jan 2022 15:49:05 +0000 (09:49 -0600)] 
Break out MEMCMP_RETURN into an inline function

makes debugging easier

3 years agotry to quiet clang scan
Alan T. DeKok [Tue, 25 Jan 2022 21:22:52 +0000 (16:22 -0500)] 
try to quiet clang scan

we might not want to mark up each function with CC_HINT(nonnull),
but it might be worth it.

3 years agoallow for casts, even if we have type hints on input
Alan T. DeKok [Tue, 25 Jan 2022 19:48:05 +0000 (14:48 -0500)] 
allow for casts, even if we have type hints on input

and automatically upcase ipv4 / ipv6 addresses when doing network
comparisons

3 years agoparse enum names when they're known
Alan T. DeKok [Tue, 25 Jan 2022 19:25:19 +0000 (14:25 -0500)] 
parse enum names when they're known

until such time as the rest of the parser is fixed.

3 years agoRevert "remove unused function"
Alan T. DeKok [Tue, 25 Jan 2022 19:16:54 +0000 (14:16 -0500)] 
Revert "remove unused function"

This reverts commit 8a5c44eaf76c5184874a0c63e330b33fbb226ab8.

3 years agotypo
Alan T. DeKok [Tue, 25 Jan 2022 19:15:19 +0000 (14:15 -0500)] 
typo

3 years agore-enable casts in all expressions
Alan T. DeKok [Tue, 25 Jan 2022 15:21:30 +0000 (10:21 -0500)] 
re-enable casts in all expressions

3 years agoremove unused function
Alan T. DeKok [Tue, 25 Jan 2022 15:20:51 +0000 (10:20 -0500)] 
remove unused function

3 years agotry to shut up clang
Alan T. DeKok [Tue, 25 Jan 2022 15:20:39 +0000 (10:20 -0500)] 
try to shut up clang

3 years agotry to shut up clang
Alan T. DeKok [Tue, 25 Jan 2022 15:20:29 +0000 (10:20 -0500)] 
try to shut up clang

3 years agoadd "has_pure_children" flag
Alan T. DeKok [Tue, 25 Jan 2022 14:05:29 +0000 (09:05 -0500)] 
add "has_pure_children" flag

so that when we're purifying functions, if the current node is not
pure, AND the node has no pure children, then we can short-circuit
the walk, and ignore this node.

3 years agomake xlat_expr use new tmpl functions
Alan T. DeKok [Tue, 25 Jan 2022 14:03:40 +0000 (09:03 -0500)] 
make xlat_expr use new tmpl functions

along with other cleanups, which removed some bad functionality
in preparation for rewrites.  This means temporarily removing some
tests, too

3 years agoProcess casts during tokenization for single and double quoted strings
Arran Cudbard-Bell [Tue, 25 Jan 2022 13:37:16 +0000 (07:37 -0600)] 
Process casts during tokenization for single and double quoted strings

3 years agoExplicitly print casts for both sides of the map
Arran Cudbard-Bell [Tue, 25 Jan 2022 13:27:36 +0000 (07:27 -0600)] 
Explicitly print casts for both sides of the map

3 years agoone more...
Arran Cudbard-Bell [Tue, 25 Jan 2022 01:22:04 +0000 (19:22 -0600)] 
one more...

3 years agoreturn the value we parsed
Alan T. DeKok [Tue, 25 Jan 2022 00:00:48 +0000 (19:00 -0500)] 
return the value we parsed

3 years agouse the correct sbuff
Alan T. DeKok [Mon, 24 Jan 2022 23:59:51 +0000 (18:59 -0500)] 
use the correct sbuff

3 years agotypo
Alan T. DeKok [Mon, 24 Jan 2022 23:45:54 +0000 (18:45 -0500)] 
typo

3 years agocorrect spelling mistake. Fixes #4374
Alan T. DeKok [Mon, 24 Jan 2022 23:42:02 +0000 (18:42 -0500)] 
correct spelling mistake.  Fixes #4374

3 years agoTry attribute references and xlats first... oops
Arran Cudbard-Bell [Mon, 24 Jan 2022 22:41:25 +0000 (16:41 -0600)] 
Try attribute references and xlats first... oops

3 years agoAdd support for explicit casts for barewords
Arran Cudbard-Bell [Mon, 24 Jan 2022 22:39:56 +0000 (16:39 -0600)] 
Add support for explicit casts for barewords

3 years agoUse more type specific type printing parsing functions
Arran Cudbard-Bell [Mon, 24 Jan 2022 22:20:54 +0000 (16:20 -0600)] 
Use more type specific type printing parsing functions

3 years agohandle the cast of XLAT_TMPL being data
Alan T. DeKok [Mon, 24 Jan 2022 22:02:07 +0000 (17:02 -0500)] 
handle the cast of XLAT_TMPL being data

3 years agoallow (foo) in a cast, too.
Alan T. DeKok [Mon, 24 Jan 2022 19:30:11 +0000 (14:30 -0500)] 
allow (foo) in a cast, too.

3 years agonotes for DHCPv4 encodings
Alan T. DeKok [Sun, 23 Jan 2022 14:02:16 +0000 (09:02 -0500)] 
notes for DHCPv4 encodings

3 years agoAdd fr_type_from_str and fr_type_to_str
Arran Cudbard-Bell [Mon, 24 Jan 2022 22:01:21 +0000 (16:01 -0600)] 
Add fr_type_from_str and fr_type_to_str

Which more than halves the length of the function call...

3 years ago.git/HEAD doesn't exist for submodules
Arran Cudbard-Bell [Mon, 24 Jan 2022 21:26:53 +0000 (15:26 -0600)] 
.git/HEAD doesn't exist for submodules

3 years agoApply validation to enum value names
Arran Cudbard-Bell [Mon, 24 Jan 2022 21:25:41 +0000 (15:25 -0600)] 
Apply validation to enum value names

3 years agoMove sbuff talloc wrappers to using fr_slen_t
Arran Cudbard-Bell [Mon, 24 Jan 2022 21:25:23 +0000 (15:25 -0600)] 
Move sbuff talloc wrappers to using fr_slen_t

If something breaks then we'll need to fix the wrapped functions...

3 years agoFix build issue in rlm_sigtran
Arran Cudbard-Bell [Mon, 24 Jan 2022 20:14:34 +0000 (14:14 -0600)] 
Fix build issue in rlm_sigtran

Seems like it was missed in the module call refactoring

3 years agoUse new libkqueue EVFILT_LIBKQUEUE version interface
Arran Cudbard-Bell [Mon, 24 Jan 2022 18:20:34 +0000 (12:20 -0600)] 
Use new libkqueue EVFILT_LIBKQUEUE version interface

This lets us retrieve the real version at runtime.

3 years agonotes for option 119
Alan T. DeKok [Sun, 23 Jan 2022 13:53:38 +0000 (08:53 -0500)] 
notes for option 119

3 years agobetter handling of casts
Alan T. DeKok [Sat, 22 Jan 2022 13:48:28 +0000 (08:48 -0500)] 
better handling of casts

3 years agoallow for non-socket listeners
Alan T. DeKok [Fri, 21 Jan 2022 15:49:03 +0000 (10:49 -0500)] 
allow for non-socket listeners

which have no app_io->open, but do have app_io->event_list_set

3 years agohave only one return point from tokenize_expression()
Alan T. DeKok [Thu, 20 Jan 2022 21:25:57 +0000 (16:25 -0500)] 
have only one return point from tokenize_expression()

which may make it easier to groupify things.

3 years agogroupify arguments to functions
Alan T. DeKok [Thu, 20 Jan 2022 21:23:21 +0000 (16:23 -0500)] 
groupify arguments to functions

for now, we create the arguments and then groupify them if necessary.

The alternative is to always create grouping nodes, and then
remove / reparent them if they're not necessary.

3 years agoskip work if we're already in the network thread
Alan T. DeKok [Thu, 20 Jan 2022 20:50:36 +0000 (15:50 -0500)] 
skip work if we're already in the network thread

3 years agoRemove Ubuntu 18.04 from build matrix (#4366)
Nick Porter [Fri, 21 Jan 2022 14:49:55 +0000 (14:49 +0000)] 
Remove Ubuntu 18.04 from build matrix (#4366)

Ubuntu 18.04 uses OpenSSL 1.1.1 which lacks the OPENSSL_INIT_NO_ATEXIT
option used to control cleanup sequence.

Also, 18.04 is likely to be end of life by the time FreeRADIUS v4 is
production ready.

3 years agoApply tmpl rules split to rlm_mruby (#4365)
Nick Porter [Fri, 21 Jan 2022 14:04:13 +0000 (14:04 +0000)] 
Apply tmpl rules split to rlm_mruby (#4365)

3 years agoremove hacks
Alan T. DeKok [Thu, 20 Jan 2022 17:30:54 +0000 (12:30 -0500)] 
remove hacks

3 years agoall children are groups
Alan T. DeKok [Thu, 20 Jan 2022 17:29:55 +0000 (12:29 -0500)] 
all children are groups

don't bother doing casts here, as it's not necessary

3 years agono need to pass "func" to xlat_purify_expr()
Alan T. DeKok [Thu, 20 Jan 2022 16:34:14 +0000 (11:34 -0500)] 
no need to pass "func" to xlat_purify_expr()

3 years agomore upcast fixes, and fixes for left / right shift
Alan T. DeKok [Thu, 20 Jan 2022 16:14:23 +0000 (11:14 -0500)] 
more upcast fixes, and fixes for left / right shift

3 years agoone more attempt to shut up clang
Alan T. DeKok [Thu, 20 Jan 2022 15:48:07 +0000 (10:48 -0500)] 
one more attempt to shut up clang

3 years agoconvert code to being table driven
Alan T. DeKok [Thu, 20 Jan 2022 14:12:17 +0000 (09:12 -0500)] 
convert code to being table driven

3 years agoinitialize the output box only as the last step before returning
Alan T. DeKok [Thu, 20 Jan 2022 14:09:54 +0000 (09:09 -0500)] 
initialize the output box only as the last step before returning

3 years agoadd upcasting from string/octets for operations, too
Alan T. DeKok [Thu, 20 Jan 2022 13:59:57 +0000 (08:59 -0500)] 
add upcasting from string/octets for operations, too

3 years agoadd more casting for booleans
Alan T. DeKok [Thu, 20 Jan 2022 13:53:06 +0000 (08:53 -0500)] 
add more casting for booleans

3 years agoadd xlat_purify and tests
Alan T. DeKok [Thu, 20 Jan 2022 00:08:35 +0000 (19:08 -0500)] 
add xlat_purify and tests

which for now only handle xlat_expr, but that's a good enough
test to catch things which had previously been missed.

3 years agoadd automatic casting for comparisons, too.
Alan T. DeKok [Thu, 20 Jan 2022 00:01:33 +0000 (19:01 -0500)] 
add automatic casting for comparisons, too.

because fr_value_box_cmp() only handles the case where the types
on LHS and RHS are exactly the same.  As a result, we have to do
various kinds of promotion here.

3 years agouse the correct variable
Alan T. DeKok [Wed, 19 Jan 2022 20:41:36 +0000 (15:41 -0500)] 
use the correct variable

3 years agofirst pass of xlat_purify_expr()
Alan T. DeKok [Wed, 19 Jan 2022 20:39:38 +0000 (15:39 -0500)] 
first pass of xlat_purify_expr()

which only works on expressions and comparisons, and then only
some of the time.  And then only if it's asked to.

3 years agofix for new tmpl_rules_t
Alan T. DeKok [Wed, 19 Jan 2022 19:35:12 +0000 (14:35 -0500)] 
fix for new tmpl_rules_t

3 years agoNeed to gether up more events before servicing the I/O callbacks
Arran Cudbard-Bell [Wed, 19 Jan 2022 19:28:39 +0000 (14:28 -0500)] 
Need to gether up more events before servicing the I/O callbacks

3 years agoReduce spurious rebalancing in the trunk
Arran Cudbard-Bell [Wed, 19 Jan 2022 19:23:58 +0000 (14:23 -0500)] 
Reduce spurious rebalancing in the trunk

3 years agoDon't crash if the first atexit handler is a global atexit handler
Arran Cudbard-Bell [Wed, 19 Jan 2022 19:14:26 +0000 (14:14 -0500)] 
Don't crash if the first atexit handler is a global atexit handler

3 years agoadd XOR
Alan T. DeKok [Wed, 19 Jan 2022 16:28:07 +0000 (11:28 -0500)] 
add XOR

3 years agomore notes
Alan T. DeKok [Wed, 19 Jan 2022 16:27:04 +0000 (11:27 -0500)] 
more notes

3 years agotypo
Alan T. DeKok [Wed, 19 Jan 2022 16:23:33 +0000 (11:23 -0500)] 
typo

3 years agotypo
Alan T. DeKok [Wed, 19 Jan 2022 16:18:16 +0000 (11:18 -0500)] 
typo

3 years agoshut up clang analyzer
Alan T. DeKok [Wed, 19 Jan 2022 16:14:00 +0000 (11:14 -0500)] 
shut up clang analyzer

3 years agoremove string/octets prepend.
Alan T. DeKok [Wed, 19 Jan 2022 16:11:00 +0000 (11:11 -0500)] 
remove string/octets prepend.

It's not really needed, and it interferes with the ability to
add XOR