]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/log
thirdparty/foundation/foundation-sites.git
6 years agofix: prevent/enforce color adjustment according to "$print-transparent-backgrounds" 11565/head
Nicolas Coden [Fri, 26 Oct 2018 19:53:36 +0000 (21:53 +0200)] 
fix: prevent/enforce color adjustment according to "$print-transparent-backgrounds"

6 years agofix: print readable text on background #11546
Martin [Fri, 19 Oct 2018 10:17:22 +0000 (12:17 +0200)] 
fix: print readable text on background #11546

When background is printed, text should keep it's original color to stay readable.
Only set color to black if background is printed tranparent.

6 years agoMerge pull request #11530 from ncoden/fix/tabs-accordion-deep-linking-11527
Nicolas Coden [Thu, 11 Oct 2018 20:17:57 +0000 (22:17 +0200)] 
Merge pull request #11530 from ncoden/fix/tabs-accordion-deep-linking-11527

fix: fix various bugs in Tabs & Accordion deep linking #11527

6 years agotest: add visual test for Tabs deep-linking 11530/head
Nicolas Coden [Thu, 11 Oct 2018 19:52:43 +0000 (21:52 +0200)] 
test: add visual test for Tabs deep-linking

6 years agoMerge pull request #11430 from ncoden/fix/close-on-tap-11423
Nicolas Coden [Tue, 9 Oct 2018 22:45:07 +0000 (00:45 +0200)] 
Merge pull request #11430 from ncoden/fix/close-on-tap-11423

fix: fix various bugs with "Tap" events and "closeOnClick" options #11423

6 years agofix: ensure Tab deep-linking to redirect to hash with "#"
Nicolas Coden [Tue, 9 Oct 2018 22:36:54 +0000 (00:36 +0200)] 
fix: ensure Tab deep-linking to redirect to hash with "#"

Related to https://github.com/zurb/foundation-sites/issues/11527

6 years agofix: prevent Tabs/Accordion to scroll to others components' anchors
Nicolas Coden [Tue, 9 Oct 2018 22:35:17 +0000 (00:35 +0200)] 
fix: prevent Tabs/Accordion to scroll to others components' anchors

Related to https://github.com/zurb/foundation-sites/issues/11527

6 years agofix: fix scroll to deep-linking default anchor on initialization in Tabs/Accordion
Nicolas Coden [Tue, 9 Oct 2018 21:49:11 +0000 (23:49 +0200)] 
fix: fix scroll to deep-linking default anchor on initialization in Tabs/Accordion

Related to https://github.com/zurb/foundation-sites/issues/11527

6 years agoMerge pull request #11529 from peterquentin/peterquentin-patch-1
Nicolas Coden [Tue, 9 Oct 2018 17:52:50 +0000 (19:52 +0200)] 
Merge pull request #11529 from peterquentin/peterquentin-patch-1

Fix interchange parsing rules, allow filename to contain brackets

6 years agoMerge pull request #11528 from ncoden/chore/update-foundation-docs
Nicolas Coden [Tue, 9 Oct 2018 17:45:58 +0000 (19:45 +0200)] 
Merge pull request #11528 from ncoden/chore/update-foundation-docs

chore: update "foundation-docs" dependency

6 years agoFix parsing rules, allow filename to contain brackets 11529/head
Peter Quentin [Tue, 9 Oct 2018 16:05:09 +0000 (18:05 +0200)] 
Fix parsing rules, allow filename to contain brackets

This regular expression fix makes parsing the interchange rules more explicit by looking for the complete pattern.

6 years agochore: update lockfiles 11528/head
Nicolas Coden [Mon, 8 Oct 2018 22:48:59 +0000 (00:48 +0200)] 
chore: update lockfiles

6 years agochore: update "foundation-docs" dependency
Nicolas Coden [Mon, 8 Oct 2018 22:39:32 +0000 (00:39 +0200)] 
chore: update "foundation-docs" dependency

6 years agoMerge pull request #11525 from ncoden/docs/dropdown-menu-events-doc
Nicolas Coden [Mon, 8 Oct 2018 21:37:03 +0000 (23:37 +0200)] 
Merge pull request #11525 from ncoden/docs/dropdown-menu-events-doc

docs: fix DropdownMenu events namespace

6 years agodocs: update namespace for DropdownMenu events 11525/head
Nicolas Coden [Sun, 7 Oct 2018 20:45:58 +0000 (22:45 +0200)] 
docs: update namespace for DropdownMenu events

Since https://github.com/zurb/foundation-sites/pull/10965, DrodpdownMenu events are in CamelCase.

6 years agodocs: add missing @fire for the "hide" event in DropdownMenu.hide
Nicolas Coden [Sun, 7 Oct 2018 20:44:01 +0000 (22:44 +0200)] 
docs: add missing @fire for the  "hide" event in DropdownMenu.hide

6 years agodocs: fix various typo in Touch methods and Reveal tests 11430/head
Nicolas Coden [Sat, 6 Oct 2018 21:51:39 +0000 (23:51 +0200)] 
docs: fix various typo in Touch methods and Reveal tests

6 years agoMerge pull request #11519 from ncoden/fix/clean-smoothscroll-events-on-destroy
Nicolas Coden [Sat, 29 Sep 2018 20:09:17 +0000 (22:09 +0200)] 
Merge pull request #11519 from ncoden/fix/clean-smoothscroll-events-on-destroy

fix: clean SmoothScroll listeners on destroy

6 years agodocs: fix typo in SmoothScroll click handler 11519/head
Nicolas Coden [Fri, 28 Sep 2018 21:01:00 +0000 (23:01 +0200)] 
docs: fix typo in SmoothScroll click handler

6 years agofix: clean SmoothScroll events when destroyed
Nicolas Coden [Fri, 28 Sep 2018 20:50:10 +0000 (22:50 +0200)] 
fix: clean SmoothScroll events when destroyed

6 years agorefactor: move SmoothScroll click event handling to its own function
Nicolas Coden [Fri, 28 Sep 2018 20:47:22 +0000 (22:47 +0200)] 
refactor: move SmoothScroll click event handling to its own function

6 years agorefactor: move SmoothScroll to ES6+ and fix linting issues
Nicolas Coden [Fri, 28 Sep 2018 20:46:23 +0000 (22:46 +0200)] 
refactor: move SmoothScroll to ES6+ and fix linting issues

6 years agoMerge pull request #11518 from ncoden/docs/typos-in-javascript-doc
Nicolas Coden [Thu, 27 Sep 2018 21:59:00 +0000 (23:59 +0200)] 
Merge pull request #11518 from ncoden/docs/typos-in-javascript-doc

docs: fix various spelling mistakes in Javascript doc and deploy scripts

6 years agodocs: fix various spelling mistakes in Javascript doc and deploy scripts 11518/head
Nicolas Coden [Thu, 27 Sep 2018 21:56:17 +0000 (23:56 +0200)] 
docs: fix various spelling mistakes in Javascript doc and deploy scripts

Reviewed in https://github.com/zurb/foundation-sites/pull/11516

6 years agoMerge pull request #11508 from ncoden/chore/transpiled-esm-entry-11502
Nicolas Coden [Mon, 24 Sep 2018 19:37:01 +0000 (21:37 +0200)] 
Merge pull request #11508 from ncoden/chore/transpiled-esm-entry-11502

chore: provide CJS, ESM and ES6+ bundles

6 years agoMerge pull request #11512 from ncoden/chore/update-dependencies-2018-09-22
Nicolas Coden [Mon, 24 Sep 2018 19:36:46 +0000 (21:36 +0200)] 
Merge pull request #11512 from ncoden/chore/update-dependencies-2018-09-22

chore: update dependencies (2018-09-22)

6 years agochore: update foundation-docs 11512/head
Nicolas Coden [Sun, 23 Sep 2018 21:20:02 +0000 (23:20 +0200)] 
chore: update foundation-docs

6 years agochore: update dependencies (2018-09-22)
Nicolas Coden [Sat, 22 Sep 2018 13:20:09 +0000 (15:20 +0200)] 
chore: update dependencies (2018-09-22)

| Package                         | From        | To          |
| :------------------------------ | :---------- | :---------- |
| @babel/core                     |       7.0.0 |       7.1.0 |
| @babel/preset-env               |       7.0.0 |       7.1.0 |
| @commitlint/cli                 |       7.1.1 |       7.1.2 |
| @commitlint/config-conventional |       7.1.1 |       7.1.2 |
| autoprefixer                    |       9.1.3 |       9.1.5 |
| husky                           | 1.0.0-rc.13 | 1.0.0-rc.15 |
| sinon                           |       6.1.5 |       6.3.4 |
| webpack                         |      4.17.2 |      4.19.1 |
| what-input                      |       5.1.1 |       5.1.2 |
| yargs                           |      12.0.1 |      12.0.2 |

6 years agoMerge pull request #11510 from ncoden/fix/smooth-scroll-absolute-links-11506
Nicolas Coden [Fri, 21 Sep 2018 21:39:12 +0000 (23:39 +0200)] 
Merge pull request #11510 from ncoden/fix/smooth-scroll-absolute-links-11506

fix: follow relative and absolute links in SmoothScroll #11506

6 years agodocs: add the package.json entry in Javascript documentation 11508/head
Nicolas Coden [Fri, 21 Sep 2018 21:31:55 +0000 (23:31 +0200)] 
docs: add the package.json entry in Javascript documentation

6 years agodocs: improve title of section about bundle format in Javascript doc
Nicolas Coden [Thu, 20 Sep 2018 21:56:58 +0000 (23:56 +0200)] 
docs: improve title of section about bundle format in Javascript doc

6 years agofix: follow relative and absolute links in SmoothScroll #11506 11510/head
Nicolas Coden [Thu, 20 Sep 2018 21:46:56 +0000 (23:46 +0200)] 
fix: follow relative and absolute links in SmoothScroll #11506

Closes https://github.com/zurb/foundation-sites/issues/11506

6 years agodocs: add description of bundle formats in the Javascript doc
Nicolas Coden [Thu, 20 Sep 2018 21:07:09 +0000 (23:07 +0200)] 
docs: add description of bundle formats in the Javascript doc

6 years agochore: provide CJS, ESM and ES2015+ bundles
Nicolas Coden [Tue, 18 Sep 2018 20:34:22 +0000 (22:34 +0200)] 
chore: provide CJS, ESM and ES2015+ bundles

Changes:
- generate transpiled ES5 (CJS, ESM) and ES6 bundles at deploiement.
- expose the transpiled ES5 bundle to module / jspm / jsnext:main entries.
- expose the non-transpiled ES6 bundle to "esnext".

See https://github.com/zurb/foundation-sites/pull/11445#issuecomment-416346441

6 years agoMerge pull request #11500 from chrisdfe/patch-1
Nicolas Coden [Thu, 13 Sep 2018 18:47:58 +0000 (20:47 +0200)] 
Merge pull request #11500 from chrisdfe/patch-1

Update prototyping-utilities.md

6 years agoUpdate prototyping-utilities.md 11500/head
Christopher Ferris [Thu, 13 Sep 2018 16:43:39 +0000 (09:43 -0700)] 
Update prototyping-utilities.md

Removed 'hi-fi'

6 years agoUpdate prototyping-utilities.md
Christopher Ferris [Wed, 12 Sep 2018 23:04:02 +0000 (16:04 -0700)] 
Update prototyping-utilities.md

Reworded part of the description

6 years agoMerge pull request #11418 from ncoden/refactor/mouseleave-special-case
Nicolas Coden [Wed, 12 Sep 2018 20:02:47 +0000 (22:02 +0200)] 
Merge pull request #11418 from ncoden/refactor/mouseleave-special-case

fix: factorize mouseleave on browser UI fix and expand it to Dropdown & Tooltip

6 years agoUpdate prototyping-utilities.md
Christopher Ferris [Wed, 12 Sep 2018 20:02:26 +0000 (13:02 -0700)] 
Update prototyping-utilities.md

Removed an unnecessary apostrophe in the description there

6 years agoMerge pull request #11477 from ncoden/fix/initial-tab-deep-linking-11100
Nicolas Coden [Wed, 12 Sep 2018 18:57:44 +0000 (20:57 +0200)] 
Merge pull request #11477 from ncoden/fix/initial-tab-deep-linking-11100

fix: return to initial state when reseting hash in Accordion & Tabs #11100

6 years agoMerge pull request #11388 from DanielRuf/docs/add-pnpm
Nicolas Coden [Tue, 11 Sep 2018 21:26:09 +0000 (23:26 +0200)] 
Merge pull request #11388 from DanielRuf/docs/add-pnpm

docs: add pnpm

6 years agochore: add npm script to generate all lockfiles 11388/head
Nicolas Coden [Tue, 11 Sep 2018 20:51:51 +0000 (22:51 +0200)] 
chore: add npm script to generate all lockfiles

6 years agochore: add pnpm lockfile
Nicolas Coden [Tue, 11 Sep 2018 20:51:25 +0000 (22:51 +0200)] 
chore: add pnpm lockfile

6 years agoMerge branch 'develop' into DanielRuf/docs/add-pnpm
Nicolas Coden [Tue, 11 Sep 2018 20:29:27 +0000 (22:29 +0200)] 
Merge branch 'develop' into DanielRuf/docs/add-pnpm

6 years agoMerge branch 'develop' into refactor/mouseleave-special-case 11418/head
Nicolas Coden [Mon, 10 Sep 2018 20:37:41 +0000 (22:37 +0200)] 
Merge branch 'develop' into refactor/mouseleave-special-case

6 years agostyle: remove extranous linebreak in Touch
Nicolas Coden [Sun, 9 Sep 2018 21:51:25 +0000 (23:51 +0200)] 
style: remove extranous linebreak in Touch

6 years agoMerge pull request #11491 from ncoden/chore/fix-gulp-sass-watch
Nicolas Coden [Sun, 9 Sep 2018 18:59:11 +0000 (20:59 +0200)] 
Merge pull request #11491 from ncoden/chore/fix-gulp-sass-watch

chore: update docs styles when SCSS change

6 years agoMerge pull request #11497 from ncoden/docs/js-tree-shaking-path
Harry Manchanda [Sun, 9 Sep 2018 18:45:46 +0000 (00:15 +0530)] 
Merge pull request #11497 from ncoden/docs/js-tree-shaking-path

docs: use named imports in javascript documentation

6 years agodocs: use named import for javascript "direct import" fallback 11497/head
Nicolas Coden [Sun, 9 Sep 2018 18:15:14 +0000 (20:15 +0200)] 
docs: use named import for javascript "direct import" fallback

6 years agodocs: fix "zplugin" typo in Accordion & Tabs events 11477/head
Nicolas Coden [Sun, 9 Sep 2018 16:35:23 +0000 (18:35 +0200)] 
docs: fix "zplugin" typo in Accordion & Tabs events

6 years agofix: close the active Tab when going back to a "tab-less" history state
Nicolas Coden [Sun, 9 Sep 2018 16:33:17 +0000 (18:33 +0200)] 
fix: close the active Tab when going back to a "tab-less" history state

See https://github.com/zurb/foundation-sites/pull/11477#issuecomment-419678146

6 years agorefactor: clean up the Tab initialization
Nicolas Coden [Sun, 9 Sep 2018 16:31:54 +0000 (18:31 +0200)] 
refactor: clean up the Tab initialization

6 years agofeat: add "Tabs._collapse()" to collapse the active tab
Nicolas Coden [Sun, 9 Sep 2018 16:30:21 +0000 (18:30 +0200)] 
feat: add "Tabs._collapse()" to collapse the active tab

6 years agoMerge pull request #11445 from ncoden/chore/tree-shaking
Nicolas Coden [Sat, 8 Sep 2018 21:59:34 +0000 (23:59 +0200)] 
Merge pull request #11445 from ncoden/chore/tree-shaking

chore: improve "tree shaking" support and documentation

6 years agoRevert "chore: add default export as it may be sometimes required for tree-shaking" 11445/head
Nicolas Coden [Sat, 8 Sep 2018 21:16:17 +0000 (23:16 +0200)] 
Revert "chore: add default export as it may be sometimes required for tree-shaking"

This reverts commit 5d9373b3dce67e29769a7afd73598dc609dc7dc1.

6 years agoMerge pull request #11495 from gforcada/patch-1
Nicolas Coden [Fri, 7 Sep 2018 21:55:20 +0000 (23:55 +0200)] 
Merge pull request #11495 from gforcada/patch-1

Fix swipe docs

6 years agoFix swipe docs 11495/head
Gil Forcada Codinachs [Fri, 7 Sep 2018 20:10:48 +0000 (22:10 +0200)] 
Fix swipe docs

See discussion on https://github.com/zurb/foundation-sites/issues/11490

6 years agochore: update docs styles when SCSS change 11491/head
Nicolas Coden [Tue, 4 Sep 2018 21:09:07 +0000 (23:09 +0200)] 
chore: update docs styles when SCSS change

Documentation styles uses the SCSS mixins/functions, so they must be recompiled when the SCSS change.

Introduced in https://github.com/zurb/foundation-sites/pull/11454

6 years agoMerge pull request #11488 from ncoden/chore/update-dependencies-2018-09-03
Nicolas Coden [Tue, 4 Sep 2018 21:01:06 +0000 (23:01 +0200)] 
Merge pull request #11488 from ncoden/chore/update-dependencies-2018-09-03

chore: update dependencies (2018-09-03)

6 years agochore: update dependencies (2018-09-03) 11488/head
Nicolas Coden [Mon, 3 Sep 2018 21:15:11 +0000 (23:15 +0200)] 
chore: update dependencies (2018-09-03)

Major bump:

| Package                         | From          | To     |
| :------------------------------ | :------------ | :----- |
| gulp-postcss                    | 7.0.0         | 8.0.0  |
| gulp-babel                      | 8.0.0-beta.2  | 8.0.0  |
| @babel/core                     | 7.0.0-beta.54 | 7.0.0  |
| babel-loader                    | 8.0.0-beta.0  | 8.0.2  |
| @babel/preset-env               | 7.0.0-beta.54 | 7.0.0  |
| browserstack-runner             | 0.7.0         | 0.9.0  |

Minor bump:

| Package                         | From          | To     |
| :------------------------------ | :------------ | :----- |
| @commitlint/cli                 | 7.0.0         | 7.1.1  |
| @commitlint/config-conventional | 7.0.1         | 7.1.1  |
| autoprefixer                    | 9.0.1         | 9.1.3  |
| browser-sync                    | 2.24.6        | 2.24.7 |
| gulp-cache-bust                 | 1.3.0         | 1.4.0  |
| gulp-clean-css                  | 3.9.4         | 3.10.0 |
| gulp-prompt                     | 1.0.1         | 1.1.0  |
| gulp-zip                        | 4.1.0         | 4.2.0  |
| inquirer                        | 6.0.0         | 6.2.0  |
| sinon                           | 6.1.4         | 6.1.5  |
| webpack                         | 4.16.2        | 4.17.2 |
| webpack-stream                  | 5.0.0         | 5.1.1  |

6 years agoMerge pull request #11485 from ncoden/fix/tabs-deep-link-custom-target-11484
Nicolas Coden [Mon, 3 Sep 2018 19:56:09 +0000 (21:56 +0200)] 
Merge pull request #11485 from ncoden/fix/tabs-deep-link-custom-target-11484

fix: use data-tabs-target to update history in Tabs deep-linking #11484

6 years agoMerge pull request #11486 from cyChop/develop
Nicolas Coden [Sun, 2 Sep 2018 20:51:07 +0000 (22:51 +0200)] 
Merge pull request #11486 from cyChop/develop

Fix a bug in tab changing

6 years agofix: use a safer selector for targetted tab title in "Tabs.selectTab" 11486/head
Nicolas Coden [Sun, 2 Sep 2018 20:32:25 +0000 (22:32 +0200)] 
fix: use a safer selector for targetted tab title in "Tabs.selectTab"

See https://github.com/zurb/foundation-sites/pull/11486

6 years agoMerge pull request #11487 from palicko/develop
Nicolas Coden [Sun, 2 Sep 2018 20:08:40 +0000 (22:08 +0200)] 
Merge pull request #11487 from palicko/develop

Fix wrong responsive spacing prototype classes

6 years agodocs: improve "tree shaking" documentation to promote named imports
Nicolas Coden [Sun, 2 Sep 2018 19:54:45 +0000 (21:54 +0200)] 
docs: improve "tree shaking" documentation to promote named imports

6 years agochore: remove redundant "pkg.browser" field
Nicolas Coden [Sun, 2 Sep 2018 19:42:27 +0000 (21:42 +0200)] 
chore: remove redundant "pkg.browser" field

According to the specification for `pkg.browser`, there is no reason for us to use this field as the package itself it only for browsers (or any environement with a DOM). Without the field, ESM-compliant transpilers/bundlers will pick `module`, and the others will pick `main`.

https://github.com/defunctzombie/package-browser-field-spec

6 years agoFix wrong responsive spacing classes #11236 11487/head
Pavol Caban [Sun, 2 Sep 2018 19:32:40 +0000 (21:32 +0200)] 
Fix wrong responsive spacing classes #11236

6 years agoFix a bug in tab changing
Cyrille Chopelet [Sat, 1 Sep 2018 13:04:16 +0000 (15:04 +0200)] 
Fix a bug in tab changing

When using deepLink options, the handleTabChange will fail if using a non-standard markup (if there are DOM levels between the `.tabs-title` and the `a`).

This commit fixes precisely that.

6 years agofix: use data-tabs-target to update history in Tabs deep-linking #11484 11485/head
Nicolas Coden [Fri, 31 Aug 2018 21:40:57 +0000 (23:40 +0200)] 
fix: use data-tabs-target to update history in Tabs deep-linking #11484

Closes https://github.com/zurb/foundation-sites/issues/11484

6 years agodocs: remove outdated comments in Accordion related to the initial state
Nicolas Coden [Thu, 30 Aug 2018 22:06:29 +0000 (00:06 +0200)] 
docs: remove outdated comments in Accordion related to the initial state

6 years agorefactor: move "init only" Accordion logic to its own methods
Nicolas Coden [Thu, 30 Aug 2018 22:00:02 +0000 (00:00 +0200)] 
refactor: move "init only" Accordion logic to its own methods

6 years agorefactor: split DOM operations from logics in Accordion
Nicolas Coden [Thu, 30 Aug 2018 21:42:48 +0000 (23:42 +0200)] 
refactor: split DOM operations from logics in Accordion

Split DOM operations from logics in Accordion "up" and "down" methods

6 years agofix: fix initial state for Accordion without any panel active
Nicolas Coden [Wed, 29 Aug 2018 21:57:57 +0000 (23:57 +0200)] 
fix: fix initial state for Accordion without any panel active

When going back in history, the Accordion without any panel active is still considered as in its "initial state".

6 years agofix: return to initial state when reseting hash in Accordion & Tabs #11100
Nicolas Coden [Sun, 26 Aug 2018 21:35:54 +0000 (23:35 +0200)] 
fix: return to initial state when reseting hash in Accordion & Tabs #11100

When deep-linking is enabled and the user goes back in the history up to when no hash is set, display the initially-selected content/tab instead of staying with the content/tab that was selected the first.

Closes https://github.com/zurb/foundation-sites/issues/11100
Replaces https://github.com/zurb/foundation-sites/issues/11101

Co-authored-by: Jamie Chong <jamie@hippocurious.com>
6 years agoMerge pull request #11466 from ncoden/chore/simplify-github-template
Nicolas Coden [Sun, 26 Aug 2018 19:54:14 +0000 (21:54 +0200)] 
Merge pull request #11466 from ncoden/chore/simplify-github-template

chore: simplify GitHub templates

6 years agoMerge pull request #11475 from Harmageddon/patch-1
Nicolas Coden [Sun, 26 Aug 2018 19:52:02 +0000 (21:52 +0200)] 
Merge pull request #11475 from Harmageddon/patch-1

fix: Added missing quotation mark in documentation

6 years agoAdded missing quotation mark. 11475/head
Constantin Romankiewicz [Sun, 26 Aug 2018 16:59:39 +0000 (18:59 +0200)] 
Added missing quotation mark.

6 years agoMerge pull request #11472 from ncoden/fix/xy-grid-offset-zero-margin-11471
Nicolas Coden [Sun, 26 Aug 2018 13:55:36 +0000 (15:55 +0200)] 
Merge pull request #11472 from ncoden/fix/xy-grid-offset-zero-margin-11471

fix: fix offset when gutters are 0 in "xy-cell-offset" #11471

6 years agofix: fix offset calculation in "xy-cell-offset" 11472/head
Nicolas Coden [Sun, 26 Aug 2018 10:24:58 +0000 (12:24 +0200)] 
fix: fix offset calculation in "xy-cell-offset"

6 years agofix: fix generated offset for zero gutters in "xy-cell-offset" #11471
Nicolas Coden [Sat, 25 Aug 2018 21:53:49 +0000 (23:53 +0200)] 
fix: fix generated offset for zero gutters in "xy-cell-offset" #11471

Closes https://github.com/zurb/foundation-sites/issues/11471

6 years agoMerge pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467
Nicolas Coden [Fri, 24 Aug 2018 21:22:56 +0000 (23:22 +0200)] 
Merge pull request #11469 from ncoden/fix/clear-nest-submenu-classes-11467

fix: clean submenu items classes in Nest #11467

6 years agoMerge pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879
Nicolas Coden [Thu, 23 Aug 2018 21:54:52 +0000 (23:54 +0200)] 
Merge pull request #11462 from ncoden/fix/reveal-mobile-full-height-10879

fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879

6 years agodocs: make "direct import" for tree shaking sounds less imperative
Nicolas Coden [Thu, 23 Aug 2018 21:47:40 +0000 (23:47 +0200)] 
docs: make "direct import" for tree shaking sounds less imperative

6 years agochore: add missing "sideEffects" flag to ensure tree shaking with webpack
Nicolas Coden [Thu, 23 Aug 2018 21:46:09 +0000 (23:46 +0200)] 
chore: add missing "sideEffects" flag to ensure tree shaking with webpack

6 years agoMerge pull request #11454 from ncoden/fix/split-gulp-tasks-11452
Nicolas Coden [Thu, 23 Aug 2018 21:38:26 +0000 (23:38 +0200)] 
Merge pull request #11454 from ncoden/fix/split-gulp-tasks-11452

chore: use split gulp tasks instead of the unsuitable "finish" event #11452

6 years agofix: clear submenu item classe in Nest #11467 11469/head
Nicolas Coden [Wed, 22 Aug 2018 20:05:11 +0000 (22:05 +0200)] 
fix: clear submenu item classe in Nest #11467

Closes https://github.com/zurb/foundation-sites/issues/11467

6 years agoMerge pull request #11465 from ncoden/fix/avoid-stop-propagation-11457
Nicolas Coden [Tue, 21 Aug 2018 21:07:00 +0000 (23:07 +0200)] 
Merge pull request #11465 from ncoden/fix/avoid-stop-propagation-11457

fix: avoid stopping propagation when not necessary #11457

6 years agochore: simplify GitHub issue templates 11466/head
Nicolas Coden [Mon, 20 Aug 2018 22:49:52 +0000 (00:49 +0200)] 
chore: simplify GitHub issue templates

6 years agochore: simplify the GitHub pull request template
Nicolas Coden [Mon, 20 Aug 2018 21:50:20 +0000 (23:50 +0200)] 
chore: simplify the GitHub pull request template

6 years agofix: fix DropdownMenu body handler check to ignore the element itself 11465/head
Nicolas Coden [Mon, 20 Aug 2018 20:54:18 +0000 (22:54 +0200)] 
fix: fix DropdownMenu body handler check to ignore the element itself

> `andSelf()` is deprecated and should be replaced with `addBack()`
> -- @SassNinja

Also, `andSelf` cannot be used that way. This commit replace it with the opposite approach: checking if the target is the child of the element or the element itself using `closest()`.

6 years agoMerge pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463
Nicolas Coden [Mon, 20 Aug 2018 19:27:51 +0000 (21:27 +0200)] 
Merge pull request #11464 from ncoden/docs/remove-vertical-block-grid-11463

docs: remove mentions of unsupported Y Grid from block grids section

6 years agoMerge pull request #11458 from SassNinja/docs/foundation-cli
Nicolas Coden [Mon, 20 Aug 2018 13:30:18 +0000 (15:30 +0200)] 
Merge pull request #11458 from SassNinja/docs/foundation-cli

foundation-cli docs for windows users

6 years agofix: avoid stopping event propagation when not necessary
Nicolas Coden [Sun, 19 Aug 2018 21:50:03 +0000 (23:50 +0200)] 
fix: avoid stopping event propagation when not necessary

Stopping the event propagation prevent the user to watch for the event at an higher level. If it was needed to prevent a duplicate behavior in a component, others methods should be used like debouncing the event.

Changes:
- Remove `stopPropagation` and `stopImmediatePropagation` from everywhere we do not want to cancel the event (AccordionMenu, Drilldown, DropdownMenu, Tabs, Tooltip).
- Update `DropdownMenu._removeBodyHandler` to also ignore click events on the element itself.

Others changes:
- Clean up `DropdownMenu._events` a bit.
- Add explainaitions where `stopPropagation` is still used (Triggers).

See https://github.com/zurb/foundation-sites/issues/11457

6 years agofix: prevent double Keyboard events handling without stopping propagation
Nicolas Coden [Sun, 19 Aug 2018 21:41:23 +0000 (23:41 +0200)] 
fix: prevent double Keyboard events handling without stopping propagation

Stopping the event propagation prevent the user to watch for the event at an higher level. If it was needed to prevent a duplicate behavior in a component, others methods should be used like debouncing the event.

Changes:
- Save and check for `event.zfIsKeyHandled` in Keyboard utility to prevent to handle twice the same event in different components.
- Remove `event.stopPropagation` from components' keyboard handlers (Accordion, DropdownMenu, OffCanvas and Tabs).

See https://github.com/zurb/foundation-sites/issues/11457

6 years agodocs: add docs about "mobile scroll" bug #9707 in OffCanvas
Nicolas Coden [Sun, 19 Aug 2018 21:33:22 +0000 (23:33 +0200)] 
docs: add docs about "mobile scroll" bug #9707 in OffCanvas

Add documentation for the OffCanvas private methods `_recordScrollable` and `_stopScrollPropagation` to explicitely justify the need for `stopPropagation`.

See #9707

6 years agodocs: remove mentions of unsupported Y Grid from block grids section 11464/head
Nicolas Coden [Sun, 19 Aug 2018 15:43:46 +0000 (17:43 +0200)] 
docs: remove mentions of unsupported Y Grid from block grids section

Block Grid is not supported for Y Grid and will not be implemented. It would add too much code for a feature that is will not be used in most projects.

Plus, Block Grid classes are not namespaced for the horizontal or vertical grid. Adding block grid classes for the vertical grid would lead of inconstencies or backward incompatibility and increased specificity.

Closes https://github.com/zurb/foundation-sites/issues/11463

6 years agoMerge pull request #11434 from ncoden/feat/orbit-slide-active-state-attribute
Nicolas Coden [Sat, 18 Aug 2018 21:59:36 +0000 (23:59 +0200)] 
Merge pull request #11434 from ncoden/feat/orbit-slide-active-state-attribute

feat: add Orbit element "data-slide-active-label" to target the bullet span to move

6 years agofix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879 11462/head
Nicolas Coden [Sat, 18 Aug 2018 21:45:12 +0000 (23:45 +0200)] 
fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879

The CSS viewport is the larger possible view height and does not change with the visible area height. This is an intended behavior for optimization reason. See this article:

See: https://nicolas-hoizey.com/2015/02/viewport-height-is-taller-than-the-visible-part-of-the-document-in-some-mobile-browsers.html
See: https://github.com/zurb/foundation-sites/issues/10879#issuecomment-414087274

Closes https://github.com/zurb/foundation-sites/issues/10879

6 years agoMerge pull request #11461 from DanielRuf/fix/interchange-remove-extraneous-regular...
Nicolas Coden [Fri, 17 Aug 2018 20:33:01 +0000 (22:33 +0200)] 
Merge pull request #11461 from DanielRuf/fix/interchange-remove-extraneous-regular-expression-11460

fix: remove extraneous regular expression in interchange, closes #11460

6 years agofix: remove extraneous regular expression in interchange, closes #11460 11461/head
Daniel Ruf [Fri, 17 Aug 2018 19:40:36 +0000 (21:40 +0200)] 
fix: remove extraneous regular expression in interchange, closes #11460