Nicolas Coden [Mon, 12 Nov 2018 19:41:41 +0000 (20:41 +0100)]
Use pull request #11579 from ncoden/fix/accordion-menu-is-active-on-close-11383 for v6.5.1
54785ea7f fix: clear "is-active" class when menu is closed in AccordionMenu 5b105ac8e test: add tests to check attributes when AccordionMenu is opened/closed a221e8ae4 refactor: simplify AccordionMenu "up" and "down" methods
Nicolas Coden [Mon, 12 Nov 2018 19:41:40 +0000 (20:41 +0100)]
Use pull request #11573 from ncoden/fix/dropdown-aria-missing-id-11572 for v6.5.1
5ddb04b6e fix: ensure Dropdown aria-labelledby to have an ID #11572 adce39107 fix: revert inadvertent substitution of Dropdown "aria-labelledby" attribute
Nicolas Coden [Sun, 11 Nov 2018 21:36:45 +0000 (22:36 +0100)]
Use pull request #11418 from ncoden/refactor/mouseleave-special-case for v6.5.1
9bd7f933c refactor: move dropdownMenu mouseleave special case to its own utility function 8f2470c28 docs: add doc for core utility onLeaveElement 90de67a17 refactor: make the magic mouseleave utility a simple event filter adeee972d docs: add some doc in the magic mouseleave utility "ignoreMousedisappear" f46e78bd1 fix: prevent Dropdown and Tooltip to hide when moving mouse to browser UI elements 5bdec3a3c tests: add visual test for the Dropdown magic mousleave bug f0168bb9f style: fix incorrectly named variable in ignoreMousedisappear utility 1847f6c9b fix: make the "ignoreMousedisappear()" handler called before mouseenter 3ec791559 docs: improve doc in "ignoreMousedisappear()"
Note: this commit has the same purpose of 55e60ee86 but includes the commits
from 8f2470c28 to 3ec791559 that missed in the previous merge commit.
Nicolas Coden [Thu, 11 Oct 2018 20:49:56 +0000 (22:49 +0200)]
Use pull request #11530 from ncoden/fix/tabs-accordion-deep-linking-11527 for v6.5.0
33c55db80 fix: fix scroll to deep-linking default anchor on initialization in Tabs/Accordion 8d4a13ead fix: prevent Tabs/Accordion to scroll to others components' anchors 7bccec66f fix: ensure Tab deep-linking to redirect to hash with # 9fbc2eeb5 test: add visual test for Tabs deep-linking
Nicolas Coden [Wed, 10 Oct 2018 17:27:41 +0000 (19:27 +0200)]
fix: keep the original event datas in Touch tap/swipe events (v6.5)
Keep the `touchstart`/`touchmove`/`touchend` datas (like `target`) for the events that are manually triggered: `tap` and `swipe`.
This resolve a bug in "Reveal" when a `touchend` event inside the reveal modal is transformed to a `tap` event on the overlay because the original `target` is lost when triggered the event on the overlay.
Nicolas Coden [Wed, 10 Oct 2018 17:20:24 +0000 (19:20 +0200)]
fix: fix "tap" event triggering in Touch (v6.5)
The current implementation actually never triggers the "tap" event. This commit refactor its handling to triggers it when the screen is touched without sliding.
Changes:
- Register the `tap` event in jQuery
- Triggers the `tap` event on `mouseend` if no moves were recorded before.
Nicolas Coden [Sun, 7 Oct 2018 20:38:17 +0000 (22:38 +0200)]
docs: use event namespace instead of Class name for event doc #11523
Document events with the namespace of the triggered event instead of the class name. There is not ideal but this is better than having a documentation that doesn't match the described event.
This fix is compatible with Foundation <= v6.5.0
Closes https://github.com/zurb/foundation-sites/issues/11523
Nicolas Coden [Sat, 29 Sep 2018 20:10:57 +0000 (22:10 +0200)]
Use pull request #11519 from ncoden/fix/clean-smoothscroll-events-on-destroy for v6.5.0
7d717bfb2 refactor: move SmoothScroll to ES6+ and fix linting issues fd14999f1 refactor: move SmoothScroll click event handling to its own function e0fbd09c8 fix: clean SmoothScroll events when destroyed 65c26b102 docs: fix typo in SmoothScroll click handler
Nicolas Coden [Tue, 25 Sep 2018 21:44:24 +0000 (23:44 +0200)]
Use pull request #11508 from ncoden/chore/transpiled-esm-entry-11502 for v6.5.0
d03b2256a chore: provide CJS, ESM and ES2015+ bundles abcd7c465 docs: add description of bundle formats in the Javascript doc 795047f10 docs: improve title of section about bundle format in Javascript doc 8d94eb7fb docs: add the package.json entry in Javascript documentation
Nicolas Coden [Wed, 12 Sep 2018 20:25:53 +0000 (22:25 +0200)]
Use pull request #11418 from ncoden/refactor/mouseleave-special-case for v6.5.0
9bd7f933c refactor: move dropdownMenu mouseleave special case to its own utility function 8f2470c28 docs: add doc for core utility onLeaveElement 90de67a17 refactor: make the magic mouseleave utility a simple event filter adeee972d docs: add some doc in the magic mouseleave utility "ignoreMousedisappear" f46e78bd1 fix: prevent Dropdown and Tooltip to hide when moving mouse to browser UI elements 5bdec3a3c tests: add visual test for the Dropdown magic mousleave bug f0168bb9f style: fix incorrectly named variable in ignoreMousedisappear utility 1847f6c9b fix: make the "ignoreMousedisappear()" handler called before mouseenter 3ec791559 docs: improve doc in "ignoreMousedisappear()"
Nicolas Coden [Wed, 12 Sep 2018 20:20:54 +0000 (22:20 +0200)]
Use pull request #11477 from ncoden/fix/initial-tab-deep-linking-11100 for v6.5.0
5ea51f3b9 fix: return to initial state when reseting hash in Accordion & Tabs #11100 314b4ee53 fix: fix initial state for Accordion without any panel active abbbdbff6 refactor: split DOM operations from logics in Accordion e26190579 refactor: move "init only" Accordion logic to its own methods b819fafba docs: remove outdated comments in Accordion related to the initial state 7307c4395 feat: add "Tabs._collapse()" to collapse the active tab 012db1077 refactor: clean up the Tab initialization c6d37c42e fix: close the active Tab when going back to a "tab-less" history state 267356747 docs: fix "zplugin" typo in Accordion & Tabs events
Nicolas Coden [Mon, 10 Sep 2018 20:57:40 +0000 (22:57 +0200)]
Use pull request #11445 from ncoden/chore/tree-shaking for v6.5.0
ff937ead3 chore: use a more tree-shaking compliant ESM entry file 83c90b089 fix: add missing export of "Move" in "foundation-plugins" entry 5d9373b3d chore: add default export as it may be sometimes required for tree-shaking 7326c38fd docs: add "Tree Shaking" section in javascript documentation 8e44c64fd chore: remove unrecommended "grouped" default exports d44a7a0f5 chore: add missing "sideEffects" flag to ensure tree shaking with webpack 680ed6a03 docs: make "direct import" for tree shaking sounds less imperative 17b3cd1f8 chore: remove redundant "pkg.browser" field 89e66da32 docs: improve "tree shaking" documentation to promote named imports 45e990c1c Revert "chore: add default export as it may be sometimes required for tree-shaking"
Nicolas Coden [Sat, 25 Aug 2018 20:34:54 +0000 (22:34 +0200)]
Use pull request #11454 from ncoden/fix/split-gulp-tasks-11452 for v6.5.0
6c45b451e fix: remove broken Sass linting from Sass compilation task and move it to build task 80c6def1f refactor: split the docs build task to `docs:pages` and `docs:search` 6b12883d6 refactor: move the customizer ZIPing to `customizer:zip` and `customizer:clean`
Nicolas Coden [Sat, 25 Aug 2018 20:33:41 +0000 (22:33 +0200)]
Use pull request #11425 from ncoden/fix/drilldown-submenu-height-11416 for v6.5.0
c7ce8d5b9 fix: set the Drilldown height for on the currently opened (sub)menu #11416 43c1fac65 test: add unit tests for Drilldown resizing on toggling 7f7dfd83a test: check the Drilldrown wrapper height instead of the element height 90c4e45f8 fix: set a default for the current menu in Drilldown before it is used 1db6a1f2a test: add unit test for the Drilldown height when reopened from a submenu #11416 d4617ac08 clean: remove infinite timeout used for development in Drilldown tests
Nicolas Coden [Fri, 6 Jul 2018 20:31:56 +0000 (22:31 +0200)]
Use pull request #11346 from ncoden/fix/gulp-deploy-task-multiple-completion-callback for v6.5.0
6cb873365 fix: fix completion callback called too many time in deploy task 9a9f0c197 style: remove unused "done" in "dist:deploy" gulp task dcd3ab813 fix: remove run-sequence from gulp `deploy:dist` task to detect its end
projects / thirdparty / foundation / foundation-sites.git / log
