patch 9.0.1637: compiler warning for uninitialized variable
Problem: Compiler warning for uninitialized variable.
Solution: Move the variable to an inner block and initialize it. (Christian
Brabandt, closes #12549)
Ben Jackson [Wed, 14 Jun 2023 14:10:02 +0000 (15:10 +0100)]
patch 9.0.1630: "make clean" at the toplevel fails
Problem: "make clean" at the toplevel fails.
Solution: Clean the indent and syntax directories in a sub-shell. (Ben
Jackson, closes #12536, closes #12526)
Bram Moolenaar [Sat, 10 Jun 2023 18:40:30 +0000 (19:40 +0100)]
patch 9.0.1626: Visual area not shown when using 'showbreak'
Problem: Visual area not shown when using 'showbreak' and start of line is
not visible. (Jaehwang Jung)
Solution: Adjust "fromcol" for the space taken by 'showbreak'.
(closes #12514)
Bram Moolenaar [Thu, 8 Jun 2023 21:16:23 +0000 (22:16 +0100)]
patch 9.0.1621: FILETYPE_FILE is defined to the same value multiple times
Problem: FILETYPE_FILE is defined to the same value multiple times. Same
for a few similar macros.
Solution: Define FILETYPE_FILE and others in feature.h only
Bram Moolenaar [Thu, 8 Jun 2023 17:44:01 +0000 (18:44 +0100)]
patch 9.0.1619: the focus gained/lost escape sequences cause trouble
Problem: The focus gained/lost escape sequences cause trouble for a
terminal where Vim does not expect them.
Solution: Always recognize the codes for focus gained/lost. (closes #12499)
patch 9.0.1617: charidx() result is not consistent with byteidx()
Problem: charidx() and utf16idx() result is not consistent with byteidx().
Solution: When the index is equal to the length of the text return the
lenght of the text instead of -1. (Yegappan Lakshmanan,
closes #12503)
zeertzjq [Mon, 5 Jun 2023 17:41:35 +0000 (18:41 +0100)]
patch 9.0.1610: display is wrong when 'smoothscroll' is set
Problem: Display is wrong when 'smoothscroll' is set and scrolling multiple
lines.
Solution: Redraw with UPD_NOT_VALID when "skipcol" is or was set.
(closes #12490, closes #12468)
zeertzjq [Sun, 4 Jun 2023 18:29:22 +0000 (19:29 +0100)]
patch 9.0.1607: screenpos() returns wrong row with diff filler lines
Problem: screenpos() returns wrong row with diff filler lines.
Solution: Only add filler lines when appropriate. Also don't add the
'smoothscroll' marker when w_skipcol is zero. (closes #12485,
closes #12484)
Ernie Rael [Sun, 4 Jun 2023 17:11:35 +0000 (18:11 +0100)]
patch 9.0.1605: crash when calling method on super in child constructor
Problem: Crash when calling method on super in child constructor. (Israel
Chauca Fuentes)
Solution: Clear the type list. (Ernie Rael, closes #12489, closes #12471)
Bram Moolenaar [Sun, 4 Jun 2023 15:55:27 +0000 (16:55 +0100)]
patch 9.0.1604: errors from the codestyle test are a bit confusing
Problem: Errors from the codestyle test are a bit confusing.
Solution: Use assert_report() with a clearer message. Avoid a warning for
an existing swap file.
zeertzjq [Sat, 3 Jun 2023 18:45:06 +0000 (19:45 +0100)]
patch 9.0.1602: stray character visible if marker on top of double-wide char
Problem: Stray character is visible if 'smoothscroll' marker is displayed
on top of a double-wide character.
Solution: When overwriting a double-width character with the 'smoothscroll'
marker clear the second half. (closes #12469)
zeertzjq [Sat, 3 Jun 2023 16:56:30 +0000 (17:56 +0100)]
patch 9.0.1601: filetype detection fails for *.conf file without comments
Problem: Filetype detection fails for *.conf file without comments.
(Dmitrii Tcyganok)
Solution: Use "conf" filetype as a fallback for an empty .conf file.
(closes #12487, closes #12483)
Luuk van Baal [Fri, 2 Jun 2023 13:16:35 +0000 (14:16 +0100)]
patch 9.0.1599: Cursor not adjusted when 'splitkeep' is not "cursor"
Problem: Cursor not adjusted when near top or bottom of window and
'splitkeep' is not "cursor".
Solution: Move boundary checks to outer cursor move functions, inner
functions should only return valid cursor positions. (Luuk van
Baal, closes #12480)
zeertzjq [Thu, 1 Jun 2023 19:26:55 +0000 (20:26 +0100)]
patch 9.0.1598: screenchar() and others are wrong with DBCS 'encoding'
Problem: screenchar(), screenchars() and screenstring() do not work
properly when 'encoding' is set to a double-byte encoding.
Solution: Fix the way the bytes of the characters are obtained.
(issue #12469)
Omar El Halabi [Mon, 29 May 2023 18:59:45 +0000 (19:59 +0100)]
patch 9.0.1591: some "gomod" files are not recognized
Problem: Some "gomod" files are not recognized.
Solution: Check for "go.mod" file name before checking out the contents.
(Omar El Halabi, closes #12462)
K.Takata [Mon, 29 May 2023 15:08:08 +0000 (16:08 +0100)]
patch 9.0.1588: Incsearch not triggered when pasting clipboard register
Problem: Incsearch not triggered when pasting clipboard register on the
command line.
Solution: Also set "literally" when using a clipboard register. (Ken Takata,
closes #12460)
Bram Moolenaar [Sun, 28 May 2023 17:39:55 +0000 (18:39 +0100)]
patch 9.0.1586: error for using two messages with ngettext() differing in "%"
Problem: Checking translations gives an error for using two messages with
ngettext() that differ in "%" items.
Solution: Adjust the check script to tolerate omitting one "%" item.
Luuk van Baal [Sat, 27 May 2023 21:22:10 +0000 (22:22 +0100)]
patch 9.0.1585: weird use of static variables for spell checking
Problem: Weird use of static variables for spell checking.
Solution: Move the variables to a structure and pass them from win_update()
to win_line(). (Luuk van Baal, closes #12448)
Bram Moolenaar [Sat, 27 May 2023 17:02:55 +0000 (18:02 +0100)]
patch 9.0.1583: get E304 when using 'cryptmethod' "xchacha20v2"
Problem: Get E304 when using 'cryptmethod' "xchacha20v2". (Steve Mynott)
Solution: Add 4th crypt method to block zero ID check. Avoid syncing a swap
file before reading the file. (closes #12433)
zeertzjq [Sat, 27 May 2023 13:10:08 +0000 (14:10 +0100)]
patch 9.0.1582: :stopinsert may not work in a popup close handler
Problem: :stopinsert may not work in a popup close handler. (Ben Jackson)
Solution: Restore stop_insert_mode when appropriate. (closes #12452,
closes #12434)
Luuk van Baal [Thu, 25 May 2023 16:14:42 +0000 (17:14 +0100)]
patch 9.0.1578: SpellCap highlight not always updated when needed
Problem: SpellCap highlight not always updated when needed.
Solution: Handle updating line below closed fold and other situations where
only part of the window is redrawn. (Luuk van Baal, closes #12428,
closes #12420)
K.Takata [Thu, 25 May 2023 15:43:27 +0000 (16:43 +0100)]
patch 9.0.1577: MS-Windows: context menu translations may be wrong
Problem: MS-Windows: context menu translations may be wrong.
Solution: Set the encoding before using gettext(). (Ken Takata,
closes #12441, closes #12431)
Bram Moolenaar [Sat, 20 May 2023 13:07:00 +0000 (14:07 +0100)]
patch 9.0.1571: RedrawingDisabled not used consistently
Problem: RedrawingDisabled not used consistently.
Solution: Avoid RedrawingDisabled going negative. Set RedrawingDisabled in
win_split_ins(). (closes #11961)
h-east [Fri, 19 May 2023 18:01:17 +0000 (19:01 +0100)]
patch 9.0.1569: cannot use "this.member" in lambda in class method
Problem: Cannot use "this.member" in lambda in class method.
Solution: Adjust check for reserved keyword. (Hirohito Higashi,
closes #12416, closes #12076, closes #12336)
Luuk van Baal [Fri, 19 May 2023 13:04:47 +0000 (14:04 +0100)]
patch 9.0.1568: with 'smoothscroll' cursor may move below botline
Problem: With 'smoothscroll' cursor may move below botline.
Solution: Call redraw_later() if needed, Compute cursor row with adjusted
condition. (Luuk van Baal, closes #12415)
Luuk van Baal [Thu, 18 May 2023 12:26:57 +0000 (13:26 +0100)]
patch 9.0.1564: display moves up and down with 'incsearch' and 'smoothscroll'
Problem: Display moves up and down with 'incsearch' and 'smoothscroll'.
Solution: Do not check if w_skipcol changed. (Luuk van Baal, closes #12410,
closes #12409)
Bram Moolenaar [Tue, 16 May 2023 21:15:51 +0000 (22:15 +0100)]
patch 9.0.1563: GTK3: window manager resize hints are incomplete
Problem: GTK3: window manager resize hints are incomplete.
Solution: Use NULL for second argument of gtk_window_set_geometry_hints().
(Kenny Stauffer closes #11055)
Luuk van Baal [Mon, 15 May 2023 17:17:43 +0000 (18:17 +0100)]
patch 9.0.1561: display wrong when moving cursor to above the top line
Problem: Display wrong when moving cursor to above the top line and
'smoothscroll' is set.
Solution: Call adjust_skipcol() in more places and make it work better.
(Luuk van Baal, closes #12395)
K.Takata [Mon, 15 May 2023 15:41:40 +0000 (16:41 +0100)]
patch 9.0.1560: Win32: When 'encoding' is set $PATH has duplicate entries
Problem: Win32: When 'encoding' is set $PATH has duplicate entries.
Solution: Only append the directory if it is not there yet. (Ken Takata,
closes #12400, closes #12372)
Bram Moolenaar [Mon, 15 May 2023 15:22:38 +0000 (16:22 +0100)]
patch 9.0.1559: function argument types not always checked
Problem: Function argument types not always checked and using v:none may
cause an error.
Solution: Check argument types once the function type is known. Do not give
an error for using v:none as an argument. (closes #12200)
Luuk van Baal [Sat, 13 May 2023 13:12:15 +0000 (14:12 +0100)]
patch 9.0.1551: position of marker for 'smoothscroll' not computed correctly
Problem: Position of marker for 'smoothscroll' not computed correctly.
Solution: Take 'list' and other options into account. (Luuk van Baal,
closes #12393)
patch 9.0.1548: CI: check in sound-dummy module may throw an error
Problem: CI: check in sound-dummy module may throw an error.
Solution: Check whether apt-cache can show the package description.
(Christian Brabandt, closes #12390)
patch 9.0.1546: some commands for opening a file don't use 'switchbuf'
Problem: Some commands for opening a file don't use 'switchbuf'.
Solution: Use 'switchbuf' for more commands. (Yegappan Lakshmanan,
closes #12383, closes #12381)
Luuk van Baal [Thu, 11 May 2023 18:24:20 +0000 (19:24 +0100)]
patch 9.0.1543: display errors when making topline shorter
Problem: Display errors when making topline shorter and 'smoothscroll' is
set.
Solution: Reset w_skipcol when the topline becomes shorter than its current
value. (Luuk van Baal, closes #12367)