]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
2 years agoPrep for rec-4.9.2 13457/head
Otto Moerbeek [Mon, 6 Nov 2023 11:59:39 +0000 (12:59 +0100)] 
Prep for rec-4.9.2

2 years agoMerge pull request #13446 from omoerbeek/rec-slogging-port
Otto Moerbeek [Mon, 6 Nov 2023 10:21:48 +0000 (11:21 +0100)] 
Merge pull request #13446 from omoerbeek/rec-slogging-port

rec: for structured logging always log addresses including port

2 years agoMerge pull request #13445 from rgacogne/ddist-dolog-forward
Remi Gacogne [Mon, 6 Nov 2023 09:36:05 +0000 (10:36 +0100)] 
Merge pull request #13445 from rgacogne/ddist-dolog-forward

dnsdist: Fix Coverity CID 1523748: Performance inefficiencies in dolog.hh

2 years agoMerge pull request #13438 from omoerbeek/rec-conf-cargo
Otto Moerbeek [Mon, 6 Nov 2023 08:54:57 +0000 (09:54 +0100)] 
Merge pull request #13438 from omoerbeek/rec-conf-cargo

rec: Teach configure to check for cargo version and require >= 1.64

2 years agoTypo in comment 13446/head
Otto Moerbeek [Mon, 6 Nov 2023 08:44:55 +0000 (09:44 +0100)] 
Typo in comment

Co-authored-by: Remi Gacogne <github@coredump.fr>
2 years agodnsdist: Better fix for CID 1523748, args does not have to be mutable 13445/head
Remi Gacogne [Mon, 6 Nov 2023 08:22:49 +0000 (09:22 +0100)] 
dnsdist: Better fix for CID 1523748, args does not have to be mutable

2 years agoMerge pull request #13342 from rgacogne/ddist-dbrg-remove-range
Remi Gacogne [Fri, 3 Nov 2023 14:32:43 +0000 (15:32 +0100)] 
Merge pull request #13342 from rgacogne/ddist-dbrg-remove-range

dnsdist: Add a DynBlockRulesGroup:removeRange() binding

2 years agoMerge pull request #13344 from rgacogne/ddist-doc-stek-rotation-frontends
Remi Gacogne [Fri, 3 Nov 2023 14:32:34 +0000 (15:32 +0100)] 
Merge pull request #13344 from rgacogne/ddist-doc-stek-rotation-frontends

dnsdist: More words on TLS session encryption keys setup and rotation

2 years agoMerge pull request #13226 from fredmorcos/ueberbackend-cleanup
Fred Morcos [Fri, 3 Nov 2023 11:02:33 +0000 (12:02 +0100)] 
Merge pull request #13226 from fredmorcos/ueberbackend-cleanup

Cleanup `ueberbackend.cc` a bit

2 years agorec: for structured logging always log addresses including port
Otto Moerbeek [Fri, 3 Nov 2023 08:42:06 +0000 (09:42 +0100)] 
rec: for structured logging always log addresses including port

As documented. The way this is done is by defined a specific
log function if SL is used. Could potentially be used for other
cases.

2 years agoMerge pull request #13443 from omoerbeek/rec-coverity-20231101
Otto Moerbeek [Fri, 3 Nov 2023 07:38:57 +0000 (08:38 +0100)] 
Merge pull request #13443 from omoerbeek/rec-coverity-20231101

rec: fix coverity 1523746 and 1523745

2 years agoMerge pull request #13442 from omoerbeek/warning-cleanup
Otto Moerbeek [Fri, 3 Nov 2023 07:38:42 +0000 (08:38 +0100)] 
Merge pull request #13442 from omoerbeek/warning-cleanup

Kill a bunch of warnings emitted by clang

2 years agoMerge pull request #13405 from rgacogne/update-slsa-generator
Remi Gacogne [Thu, 2 Nov 2023 10:02:26 +0000 (11:02 +0100)] 
Merge pull request #13405 from rgacogne/update-slsa-generator

build-packages: Update the version of the generic SLSA generator

2 years agodnsdist: Fix Coverity CID 1523748: Performance inefficiencies in dolog.hh
Remi Gacogne [Thu, 2 Nov 2023 08:40:21 +0000 (09:40 +0100)] 
dnsdist: Fix Coverity CID 1523748: Performance inefficiencies in dolog.hh

Coverity reports:
```
Performance inefficiencies (COPY_INSTEAD_OF_MOVE): "args" is
passed-by-value as parameter to "dolog" when it could be moved instead.
```
This PR implements perfect forwarding for the variadic template parameters
of DNSdist's logging methods to address it, even though the performance of
these functions should not matter much.

2 years agorec: fix coverity 1523746 and 1523745 13443/head
Otto Moerbeek [Wed, 1 Nov 2023 15:07:11 +0000 (16:07 +0100)] 
rec: fix coverity 1523746 and 1523745

Fixing a use_after_move and a copy_instead_of_move

2 years agoTidy 13442/head
Otto Moerbeek [Wed, 1 Nov 2023 14:55:57 +0000 (15:55 +0100)] 
Tidy

2 years agoKill a bunch of warnings emitted by clang
Otto Moerbeek [Wed, 1 Nov 2023 12:24:55 +0000 (13:24 +0100)] 
Kill a bunch of warnings emitted by clang

A few are coming from boost, I disabled those by adding #pragma's

2 years agoMerge pull request #13439 from Habbie/auth-py-pytest
Peter van Dijk [Wed, 1 Nov 2023 09:24:43 +0000 (10:24 +0100)] 
Merge pull request #13439 from Habbie/auth-py-pytest

auth-py tests: switch to pytest

2 years agoMerge pull request #13385 from omoerbeek/assorted-delint20231017
Otto Moerbeek [Tue, 31 Oct 2023 15:19:10 +0000 (16:19 +0100)] 
Merge pull request #13385 from omoerbeek/assorted-delint20231017

Assorted delinting, mark do while loops as ok

2 years agoauth-py tests: switch to pytest 13439/head
Peter van Dijk [Tue, 31 Oct 2023 14:43:19 +0000 (15:43 +0100)] 
auth-py tests: switch to pytest

2 years agorec: Teach configure to check for cargo version and require >= 1.64 13438/head
Otto Moerbeek [Tue, 31 Oct 2023 11:07:33 +0000 (12:07 +0100)] 
rec: Teach configure to check for cargo version and require >= 1.64

2 years agoMerge pull request #13435 from rgacogne/coverity-fixes
Remi Gacogne [Tue, 31 Oct 2023 11:02:34 +0000 (12:02 +0100)] 
Merge pull request #13435 from rgacogne/coverity-fixes

Fix a few coverity warnings

2 years agoMerge pull request #13414 from rgacogne/clang-tidy-with-codeql
Remi Gacogne [Tue, 31 Oct 2023 11:01:24 +0000 (12:01 +0100)] 
Merge pull request #13414 from rgacogne/clang-tidy-with-codeql

CI: Move clang-tidy checks to the CodeQL workflow

2 years agoMark function argument using in DLOG() call as maybe_unused 13226/head
Fred Morcos [Tue, 31 Oct 2023 10:38:20 +0000 (11:38 +0100)] 
Mark function argument using in DLOG() call as maybe_unused

2 years agorec: Fix a warning from Coverity (CID 1522877) 13435/head
Remi Gacogne [Tue, 31 Oct 2023 09:45:23 +0000 (10:45 +0100)] 
rec: Fix a warning from Coverity (CID 1522877)

2 years agodnsdist: Silence a false positive reported by Coverity as CID 404742
Remi Gacogne [Tue, 31 Oct 2023 09:44:00 +0000 (10:44 +0100)] 
dnsdist: Silence a false positive reported by Coverity as CID 404742

2 years agoixfrdist: Default initialize the 'not implemented' metrics
Remi Gacogne [Tue, 31 Oct 2023 09:32:23 +0000 (10:32 +0100)] 
ixfrdist: Default initialize the 'not implemented' metrics

Reported by Coverity as CID 1504405.

2 years agoMerge pull request #13392 from omoerbeek/rec-sl-dict
Otto Moerbeek [Tue, 31 Oct 2023 09:25:43 +0000 (10:25 +0100)] 
Merge pull request #13392 from omoerbeek/rec-sl-dict

rec: Describe the keys and values produced by structured logging in more detail

2 years agoMerge pull request #13410 from omoerbeek/rec-cache-tidy
Otto Moerbeek [Tue, 31 Oct 2023 08:54:50 +0000 (09:54 +0100)] 
Merge pull request #13410 from omoerbeek/rec-cache-tidy

rec: tidy cache and only copy values if non-expired entry was found

2 years agoFix a few whitespace consistency issues 13392/head
Otto Moerbeek [Tue, 31 Oct 2023 08:35:20 +0000 (09:35 +0100)] 
Fix a few whitespace consistency issues

2 years agoMerge pull request #13409 from omoerbeek/rec-rootnxtrust-serve-stale
Otto Moerbeek [Tue, 31 Oct 2023 08:03:31 +0000 (09:03 +0100)] 
Merge pull request #13409 from omoerbeek/rec-rootnxtrust-serve-stale

rec: handle serve stale logic in getRootNXTrust()

2 years agotypo in comment 13410/head
Otto Moerbeek [Tue, 31 Oct 2023 07:59:40 +0000 (08:59 +0100)] 
typo in comment

Co-authored-by: Remi Gacogne <github@coredump.fr>
2 years agoMerge pull request #13381 from rgacogne/ddist-clean-up-nghttp2-no-doh
Remi Gacogne [Tue, 31 Oct 2023 07:34:55 +0000 (08:34 +0100)] 
Merge pull request #13381 from rgacogne/ddist-clean-up-nghttp2-no-doh

dnsdist: Fix the case where nghttp2 is available but DoH is disabled

2 years agoUse unique_ptr to backend in remotebackend tests
Fred Morcos [Mon, 30 Oct 2023 11:51:52 +0000 (12:51 +0100)] 
Use unique_ptr to backend in remotebackend tests

2 years agoGet rid of manual deletion of backends in UeberBackend
Fred Morcos [Sun, 29 Oct 2023 16:47:38 +0000 (17:47 +0100)] 
Get rid of manual deletion of backends in UeberBackend

2 years agoMerge pull request #13432 from omoerbeek/rec-mtasker-cet-followup
Otto Moerbeek [Mon, 30 Oct 2023 14:15:10 +0000 (15:15 +0100)] 
Merge pull request #13432 from omoerbeek/rec-mtasker-cet-followup

rec: Followup to #13430: also define CET_ENDBR on !amd64

2 years agotasks: Refactoring to abstract away the env variables 13414/head
Remi Gacogne [Mon, 30 Oct 2023 10:58:04 +0000 (11:58 +0100)] 
tasks: Refactoring to abstract away the env variables

2 years agoFollowup to #13430: also define CET_ENDBR on !amd64 13432/head
Otto Moerbeek [Mon, 30 Oct 2023 12:38:22 +0000 (13:38 +0100)] 
Followup to #13430: also define CET_ENDBR on !amd64

2 years agoMerge pull request #13430 from omoerbeek/rec-mtasker-cet
Otto Moerbeek [Mon, 30 Oct 2023 12:25:50 +0000 (13:25 +0100)] 
Merge pull request #13430 from omoerbeek/rec-mtasker-cet

rec: Add endbr64 instructions in the right spots for OpenBSD/amd64

2 years agoCleanup UeberBackend::searchRecords and ::searchResources
Fred Morcos [Sun, 29 Oct 2023 16:13:27 +0000 (17:13 +0100)] 
Cleanup UeberBackend::searchRecords and ::searchResources

This required more changes in other places to change maxResults from int to size_t.

2 years agoSome final UeberBackend cleanups
Fred Morcos [Sun, 29 Oct 2023 14:35:04 +0000 (15:35 +0100)] 
Some final UeberBackend cleanups

2 years agoAdd endbr64 instructions in the right spots for OpenBSD/amd64 13430/head
Otto Moerbeek [Mon, 30 Oct 2023 09:37:10 +0000 (10:37 +0100)] 
Add endbr64 instructions in the right spots for OpenBSD/amd64

OpenBSD has IBT (aka control flow enforcement) on amd64, for processor
models that support it. But it turns out that the existing endbr64
instructions in the boost assembly for context switching are not
enough: there needs to be endbr64 instructions right after the
jump_fcontext() call, as indirect branches end up there.

2 years agoMerge pull request #13416 from jsoref/doc-dnssec
Peter van Dijk [Mon, 30 Oct 2023 09:29:33 +0000 (10:29 +0100)] 
Merge pull request #13416 from jsoref/doc-dnssec

Minor doc tweaks

2 years agoMerge pull request #13421 from jsoref/resolve-list-completeness
Peter van Dijk [Mon, 30 Oct 2023 09:06:21 +0000 (10:06 +0100)] 
Merge pull request #13421 from jsoref/resolve-list-completeness

acknowledge everyone

2 years agoMerge pull request #13428 from zeha/catalog-doc-draft
Peter van Dijk [Mon, 30 Oct 2023 08:58:44 +0000 (09:58 +0100)] 
Merge pull request #13428 from zeha/catalog-doc-draft

auth doc: catalog: replace the word "draft"

2 years agoMerge pull request #13402 from rgacogne/ddist-coverity-install-quiche
Peter van Dijk [Mon, 30 Oct 2023 08:53:01 +0000 (09:53 +0100)] 
Merge pull request #13402 from rgacogne/ddist-coverity-install-quiche

misc-dailies: Install quiche for Coverity's DNSdist analysis

2 years agotasks: Apply another suggestion
Remi Gacogne [Mon, 30 Oct 2023 08:26:18 +0000 (09:26 +0100)] 
tasks: Apply another suggestion

2 years agotasks: Apply Fred's suggestion
Remi Gacogne [Mon, 30 Oct 2023 08:18:40 +0000 (09:18 +0100)] 
tasks: Apply Fred's suggestion

2 years agotasks: Apply Fred's suggestion (thanks!)
Remi Gacogne [Mon, 30 Oct 2023 08:12:57 +0000 (09:12 +0100)] 
tasks: Apply Fred's suggestion (thanks!)

Co-authored-by: Fred Morcos <fm@fredmorcos.com>
2 years agoClang-tidy: Document the workflow
Remi Gacogne [Mon, 23 Oct 2023 14:28:00 +0000 (16:28 +0200)] 
Clang-tidy: Document the workflow

2 years agoclang-tidy: Add markdown summary
Remi Gacogne [Mon, 23 Oct 2023 12:46:16 +0000 (14:46 +0200)] 
clang-tidy: Add markdown summary

2 years agoUse our own clang-tidy-diff.py
Remi Gacogne [Mon, 23 Oct 2023 09:44:01 +0000 (11:44 +0200)] 
Use our own clang-tidy-diff.py

2 years agoclang-tidy: Use --noprefix
Remi Gacogne [Mon, 23 Oct 2023 07:13:12 +0000 (09:13 +0200)] 
clang-tidy: Use --noprefix

2 years agoFix clang-tidy analysis
Remi Gacogne [Fri, 20 Oct 2023 15:32:10 +0000 (17:32 +0200)] 
Fix clang-tidy analysis

2 years agoLimit concurrency
Remi Gacogne [Fri, 13 Oct 2023 15:16:05 +0000 (17:16 +0200)] 
Limit concurrency

2 years agoCodeQL: Fix analysis
Remi Gacogne [Fri, 13 Oct 2023 11:22:14 +0000 (13:22 +0200)] 
CodeQL: Fix analysis

2 years agotasks: gcc 11.4 doesn't support `-Wstring-plus-int`
Remi Gacogne [Fri, 13 Oct 2023 10:37:27 +0000 (12:37 +0200)] 
tasks: gcc 11.4 doesn't support `-Wstring-plus-int`

2 years agotasks: Handle an empty sanitizers list
Remi Gacogne [Fri, 13 Oct 2023 10:30:08 +0000 (12:30 +0200)] 
tasks: Handle an empty sanitizers list

2 years agoCodeQL workflow: Upgrade to 22.04, clang-tidy 15
Remi Gacogne [Fri, 13 Oct 2023 10:08:41 +0000 (12:08 +0200)] 
CodeQL workflow: Upgrade to 22.04, clang-tidy 15

2 years agoMove clang-tidy analysis to the CodeQL workflow
Remi Gacogne [Fri, 13 Oct 2023 09:42:55 +0000 (11:42 +0200)] 
Move clang-tidy analysis to the CodeQL workflow

2 years agoRefactor UeberBackend::getAuth
Fred Morcos [Thu, 26 Oct 2023 13:12:07 +0000 (15:12 +0200)] 
Refactor UeberBackend::getAuth

2 years agoRefactor UeberBackend::getAuth: foundTarget
Fred Morcos [Thu, 26 Oct 2023 12:50:20 +0000 (14:50 +0200)] 
Refactor UeberBackend::getAuth: foundTarget

2 years agoRefactor UeberBackend::getAuth: findBestMatchingBackend
Fred Morcos [Thu, 26 Oct 2023 12:45:41 +0000 (14:45 +0200)] 
Refactor UeberBackend::getAuth: findBestMatchingBackend

2 years agoRefactor UeberBackend::getAuth: UeberBackend::fillSOAFromCache
Fred Morcos [Thu, 26 Oct 2023 12:38:28 +0000 (14:38 +0200)] 
Refactor UeberBackend::getAuth: UeberBackend::fillSOAFromCache

2 years agoCleanup UeberBackend::lookup
Fred Morcos [Thu, 26 Oct 2023 12:31:06 +0000 (14:31 +0200)] 
Cleanup UeberBackend::lookup

2 years agoRefactor UeberBackend::cacheHas and introduce UeberBackend::CacheResult
Fred Morcos [Thu, 26 Oct 2023 12:27:28 +0000 (14:27 +0200)] 
Refactor UeberBackend::cacheHas and introduce UeberBackend::CacheResult

2 years agoRefactor UeberBackend::getAuth: UeberBackend::fillSOAFromZoneRecord
Fred Morcos [Thu, 26 Oct 2023 12:09:33 +0000 (14:09 +0200)] 
Refactor UeberBackend::getAuth: UeberBackend::fillSOAFromZoneRecord

2 years agoCleanup UeberBackend::getAuth
Fred Morcos [Thu, 26 Oct 2023 11:19:18 +0000 (13:19 +0200)] 
Cleanup UeberBackend::getAuth

2 years agoCleanup UeberBackend::getSOAUncached
Fred Morcos [Fri, 13 Oct 2023 13:09:18 +0000 (15:09 +0200)] 
Cleanup UeberBackend::getSOAUncached

2 years agoDisable lint for call to dlerror()
Fred Morcos [Fri, 13 Oct 2023 13:08:34 +0000 (15:08 +0200)] 
Disable lint for call to dlerror()

2 years agoVarious UeberBackend cleanups
Fred Morcos [Sun, 29 Oct 2023 14:09:36 +0000 (15:09 +0100)] 
Various UeberBackend cleanups

2 years agoCleanup UeberBackend TSIG Key handling methods
Fred Morcos [Sun, 29 Oct 2023 14:04:44 +0000 (15:04 +0100)] 
Cleanup UeberBackend TSIG Key handling methods

2 years agoCleanup UeberBackend cache handling methods
Fred Morcos [Fri, 27 Oct 2023 22:05:16 +0000 (00:05 +0200)] 
Cleanup UeberBackend cache handling methods

2 years agoMerge pull request #13425 from omoerbeek/rec-docs-ws-loglevel
Otto Moerbeek [Fri, 27 Oct 2023 15:08:16 +0000 (17:08 +0200)] 
Merge pull request #13425 from omoerbeek/rec-docs-ws-loglevel

rec: correct webserver-loglevel docs.

2 years agoCleanup UeberBackend constructor
Fred Morcos [Fri, 27 Oct 2023 13:53:47 +0000 (15:53 +0200)] 
Cleanup UeberBackend constructor

2 years agoCleanup UeberBackend::getSOAUncached
Fred Morcos [Fri, 27 Oct 2023 13:53:30 +0000 (15:53 +0200)] 
Cleanup UeberBackend::getSOAUncached

2 years agoauth doc: catalog: replace the word "draft" 13428/head
Chris Hofstaedtler [Fri, 27 Oct 2023 13:29:33 +0000 (15:29 +0200)] 
auth doc: catalog: replace the word "draft"

Improves PR #13000.

2 years agoCleanup various UeberBackend methods
Fred Morcos [Fri, 27 Oct 2023 10:31:25 +0000 (12:31 +0200)] 
Cleanup various UeberBackend methods

2 years agoCleanup UeberBackend::inTransaction
Fred Morcos [Fri, 27 Oct 2023 10:30:26 +0000 (12:30 +0200)] 
Cleanup UeberBackend::inTransaction

2 years agoCleanup UeberBackend includes
Fred Morcos [Fri, 27 Oct 2023 10:12:03 +0000 (12:12 +0200)] 
Cleanup UeberBackend includes

2 years agoCleanup UeberBackend domain key management methods
Fred Morcos [Fri, 27 Oct 2023 10:10:37 +0000 (12:10 +0200)] 
Cleanup UeberBackend domain key management methods

2 years agoCleanup UeberBackend::doesDNSSEC
Fred Morcos [Fri, 27 Oct 2023 10:09:19 +0000 (12:09 +0200)] 
Cleanup UeberBackend::doesDNSSEC

2 years agoCleanup UeberBackend::getDomainInfo
Fred Morcos [Fri, 27 Oct 2023 10:08:27 +0000 (12:08 +0200)] 
Cleanup UeberBackend::getDomainInfo

2 years agorec: correct webserver-loglevel docs. 13425/head
Otto Moerbeek [Fri, 27 Oct 2023 10:07:38 +0000 (12:07 +0200)] 
rec: correct webserver-loglevel docs.

Fixes #13325

2 years agoCleanup UeberBackend::loadModules
Fred Morcos [Fri, 27 Oct 2023 09:52:37 +0000 (11:52 +0200)] 
Cleanup UeberBackend::loadModules

2 years agoFormatting: ueberbackend.hh
Fred Morcos [Fri, 8 Sep 2023 12:00:44 +0000 (14:00 +0200)] 
Formatting: ueberbackend.hh

2 years agoFormatting: ueberbackend.cc
Fred Morcos [Fri, 8 Sep 2023 11:56:34 +0000 (13:56 +0200)] 
Formatting: ueberbackend.cc

2 years agoacknowledge everyone 13421/head
Josh Soref [Wed, 25 Oct 2023 18:26:42 +0000 (14:26 -0400)] 
acknowledge everyone

2 years agoMerge pull request #13376 from b1tw0rker/master
Otto Moerbeek [Wed, 25 Oct 2023 07:15:02 +0000 (09:15 +0200)] 
Merge pull request #13376 from b1tw0rker/master

fix: added missing underscore

2 years agoTweaks for DNSSEC docs 13416/head
Josh Soref [Tue, 24 Oct 2023 15:54:26 +0000 (11:54 -0400)] 
Tweaks for DNSSEC docs

* powerdnssec.org was discontinued a while ago
* rst tweaks
* there do not appear to be tutorials available

2 years agoFix stale rst references
Josh Soref [Tue, 24 Oct 2023 16:14:10 +0000 (12:14 -0400)] 
Fix stale rst references

2 years agoThis ship has sailed
Josh Soref [Tue, 24 Oct 2023 15:58:58 +0000 (11:58 -0400)] 
This ship has sailed

2 years agoUse more rst markup
Josh Soref [Tue, 24 Oct 2023 15:58:48 +0000 (11:58 -0400)] 
Use more rst markup

2 years agoMerge pull request #13413 from omoerbeek/dnsdist-boringssl
Otto Moerbeek [Tue, 24 Oct 2023 09:27:38 +0000 (11:27 +0200)] 
Merge pull request #13413 from omoerbeek/dnsdist-boringssl

dnsdist: Allow building of dnsdist against boringssl on OpenBSD

2 years agoTidy 13413/head
Otto Moerbeek [Tue, 24 Oct 2023 08:29:04 +0000 (10:29 +0200)] 
Tidy

2 years agoAllow building of dnsdist against boringssl.
Otto Moerbeek [Mon, 23 Oct 2023 15:18:44 +0000 (17:18 +0200)] 
Allow building of dnsdist against boringssl.

DISABLE_OCSP_STAPLING has to be defined as well, since boring does not
seem to have it.

2 years agodnsdist: Better message when outgoing DoH is not available 13381/head
Remi Gacogne [Tue, 24 Oct 2023 07:11:17 +0000 (09:11 +0200)] 
dnsdist: Better message when outgoing DoH is not available

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
2 years agoOnly assign to the arguments of get if the entry is not expired.
Otto Moerbeek [Mon, 23 Oct 2023 09:48:54 +0000 (11:48 +0200)] 
Only assign to the arguments of get if the entry is not expired.

Callers of get() *must* ensure they onluy look at the args if get() returned > 0

Implements #12612 for the record cache. Negcache fill follow later.

2 years agoMove preRemoval() to MapCombo::LockedContent
Otto Moerbeek [Mon, 23 Oct 2023 09:10:47 +0000 (11:10 +0200)] 
Move preRemoval() to MapCombo::LockedContent

Simplifies a few things, and gets rid of the clang-tidy "method can be static"
comment.

2 years agorec: tidy recursor_cache.??
Otto Moerbeek [Mon, 23 Oct 2023 08:39:08 +0000 (10:39 +0200)] 
rec: tidy recursor_cache.??

Two warnings remain