]> git.ipfire.org Git - thirdparty/zstd.git/log
thirdparty/zstd.git
6 years agofixed static analyzer warnings 1348/head
Yann Collet [Tue, 2 Oct 2018 22:59:11 +0000 (15:59 -0700)] 
fixed static analyzer warnings

note : for some reason,
scan-build version on my laptop found problems within fastcover.c
that scan-build on travisCI does not flag.

They are, as usual, false positive :
the analyzer does not understand that a table (`offset`) is correctly filled before usage.

6 years agorestored backtrace on failure
Yann Collet [Tue, 2 Oct 2018 00:50:16 +0000 (17:50 -0700)] 
restored backtrace on failure

for Linux and Mac OS-X.

Note : the backtraces fires up through a trap
before the sanitizer get a chance to report.
There are situations where the sanitizer report is actually preferable.

It might be good to consider a kind of build macro
which can disable backtrace
when sanitizer is enabled.

6 years ago./zstd -f do no longer overwrite destination file
Yann Collet [Tue, 2 Oct 2018 00:16:34 +0000 (17:16 -0700)] 
./zstd -f do no longer overwrite destination file

if source file does not exist (#1082)

6 years agozstd -d -f do no longer erase destination file
Yann Collet [Mon, 1 Oct 2018 21:04:00 +0000 (14:04 -0700)] 
zstd -d -f do no longer erase destination file

when source file does not exist (#1082)

6 years agoregroup name creation logic into its own function
Yann Collet [Sat, 29 Sep 2018 01:19:23 +0000 (18:19 -0700)] 
regroup name creation logic into its own function

for a cleaner main file decompression loop

6 years agochanged macro name
Yann Collet [Fri, 28 Sep 2018 23:04:00 +0000 (16:04 -0700)] 
changed macro name

from EXIT_IF() to RETURN_IF()

EXIT could be misunderstood as exit(), which terminates program execution.
But the macro only leaves the function, not the program.

6 years agominor improvement in the multi-format suffix selection
Yann Collet [Fri, 28 Sep 2018 22:57:35 +0000 (15:57 -0700)] 
minor improvement in the multi-format suffix selection

6 years agofixed unreachable section warning on Visual
Yann Collet [Fri, 28 Sep 2018 16:34:16 +0000 (09:34 -0700)] 
fixed unreachable section warning on Visual

6 years agoMerge branch 'dev' into donotdelete
Yann Collet [Fri, 28 Sep 2018 02:23:55 +0000 (19:23 -0700)] 
Merge branch 'dev' into donotdelete

6 years agoMerge pull request #1345 from facebook/fixLegacy
Yann Collet [Fri, 28 Sep 2018 02:23:27 +0000 (19:23 -0700)] 
Merge pull request #1345 from facebook/fixLegacy

fixed legacy compilation tests

6 years agofixed minor Visual conversion warnings
Yann Collet [Fri, 28 Sep 2018 01:29:15 +0000 (18:29 -0700)] 
fixed minor Visual conversion warnings

6 years agofixed longmatch test too 1345/head
Yann Collet [Fri, 28 Sep 2018 01:24:41 +0000 (18:24 -0700)] 
fixed longmatch test too

6 years agofixed legacy compilation tests
Yann Collet [Fri, 28 Sep 2018 01:15:14 +0000 (18:15 -0700)] 
fixed legacy compilation tests

for some reason, these tests started failing recently on CircleCI

6 years agoMerge pull request #1344 from terrelln/grub-fixes
Yann Collet [Fri, 28 Sep 2018 00:36:54 +0000 (17:36 -0700)] 
Merge pull request #1344 from terrelln/grub-fixes

Fixes for GRUB

6 years agominor refactoring of --list
Yann Collet [Thu, 27 Sep 2018 23:49:08 +0000 (16:49 -0700)] 
minor refactoring of --list

trying to reduce recurrent patterns.

6 years agoRestore ZSTD_noCompressBlock() for clarity 1344/head
Nick Terrell [Thu, 27 Sep 2018 23:06:02 +0000 (16:06 -0700)] 
Restore ZSTD_noCompressBlock() for clarity

6 years agoChange byte to value to avoid a GRUB typedef
Nick Terrell [Thu, 27 Sep 2018 22:23:20 +0000 (15:23 -0700)] 
Change byte to value to avoid a GRUB typedef

6 years agoInclude stddef.h for size_t
Nick Terrell [Thu, 27 Sep 2018 22:22:34 +0000 (15:22 -0700)] 
Include stddef.h for size_t

6 years ago[zstd] Add -Wmissing-prototypes
Nick Terrell [Thu, 27 Sep 2018 22:13:43 +0000 (15:13 -0700)] 
[zstd] Add -Wmissing-prototypes

6 years agoMerge pull request #1342 from facebook/fixcatyd
Yann Collet [Thu, 27 Sep 2018 17:20:14 +0000 (10:20 -0700)] 
Merge pull request #1342 from facebook/fixcatyd

fix : huge (>4GB) chain of blocks

6 years agomoved again overflow correction 1342/head
Yann Collet [Thu, 27 Sep 2018 01:06:53 +0000 (18:06 -0700)] 
moved again overflow correction

cannot work from within ZSTD_compressBlock()

6 years agoMerge pull request #1340 from terrelln/generate-artifacts
Yann Collet [Wed, 26 Sep 2018 22:52:23 +0000 (15:52 -0700)] 
Merge pull request #1340 from terrelln/generate-artifacts

Publish artifacts with CircleCI

6 years agochanged overflow correction place
Yann Collet [Wed, 26 Sep 2018 22:35:38 +0000 (15:35 -0700)] 
changed overflow correction place

keep one in compress_frameChunk(),
so that it's tested at every loop
in case some user simply some large mulit-GB input in a single invocation.

Add one in ZSTD_compressBlock(),
since compressBlock() explicitly skips frameChunk().

6 years agoMerge pull request #1339 from facebook/grep_colors
Yann Collet [Wed, 26 Sep 2018 21:39:20 +0000 (14:39 -0700)] 
Merge pull request #1339 from facebook/grep_colors

fixed usage of grep in Makefile

6 years agoMerge pull request #1327 from facebook/adapt
Yann Collet [Wed, 26 Sep 2018 21:39:08 +0000 (14:39 -0700)] 
Merge pull request #1327 from facebook/adapt

Adaptive compression

6 years agofix : huge (>4GB) stream of blocks
Yann Collet [Wed, 26 Sep 2018 21:24:28 +0000 (14:24 -0700)] 
fix : huge (>4GB) stream of blocks

experimental function ZSTD_compressBlock() is designed for very small data in mind,
for situation where saving the ~12 bytes of frame header can actually make a difference.

Some systems though may have to deal with small and large data entangled.
If it's larger than a block (> 128KB), compressBlock() cannot compress them in one round.

That's why it's possible to compress in multiple rounds.
This is a chain of compressed blocks.

Some users push this capability to the limit, encoding gigantic chain of blocks.
On crossing the 4GB limit, some internal overflow occurs.

This fix moves the overflow correction mechanism higher in the call chain,
so that it's applied also to gigantic chains of blocks.

Added a test case in fuzzer.c, which crashes before the fix, and pass now.

6 years agoMerge pull request #1338 from facebook/rfc
Yann Collet [Wed, 26 Sep 2018 20:40:35 +0000 (13:40 -0700)] 
Merge pull request #1338 from facebook/rfc

updated format documentation

6 years agoMerge pull request #1337 from facebook/test_failure
Yann Collet [Wed, 26 Sep 2018 20:40:20 +0000 (13:40 -0700)] 
Merge pull request #1337 from facebook/test_failure

fixed `!` tests

6 years agoMerge pull request #1329 from facebook/v04isout
Yann Collet [Wed, 26 Sep 2018 20:39:05 +0000 (13:39 -0700)] 
Merge pull request #1329 from facebook/v04isout

 Changed default legacy support to v0.5+

6 years agoPublish artifacts with CircleCI 1340/head v0.0.29
Nick Terrell [Tue, 25 Sep 2018 23:10:17 +0000 (16:10 -0700)] 
Publish artifacts with CircleCI

* Updates CircleCI to use workflows.
  We can now specify any number of test jobs to run in parallel.
* Switch the image to `buildpack-deps:trusty` which is only 500 MB
  instead of 7 GB, so that saves 7 minutes to download it if it isn't
  already cached on the host.
* Publish the source tarball and sha256sum as artifacts.
* If the `GITHUB_TOKEN` environment variable is set, we will also
  add the tarball + sha256sum to the tagged release, after manual
  approval.

6 years agofixed usage of grep in Makefile 1339/head
Yann Collet [Tue, 25 Sep 2018 23:56:53 +0000 (16:56 -0700)] 
fixed usage of grep in Makefile

when terminal uses colors
as suggested by @danielshir (#1294)

6 years agoupdated format documentation 1338/head
Yann Collet [Tue, 25 Sep 2018 23:34:26 +0000 (16:34 -0700)] 
updated format documentation

to match last edits of RFC8478.

6 years agobounds for --adapt mode 1327/head
Yann Collet [Tue, 25 Sep 2018 01:16:08 +0000 (18:16 -0700)] 
bounds for --adapt mode

can supply min and max compression level through advanced command :
--adapt=min=#,max=#

6 years agofixed `!` tests 1337/head
Yann Collet [Tue, 25 Sep 2018 22:57:28 +0000 (15:57 -0700)] 
fixed `!` tests

Sometimes, it's necessary to test that a certain command fail, as expected.
Such failure is actually a success, and must not stop the flow of tests.

Several tests were prefixed with `!` to invert return code.
This does not work : it effectively makes the tests pass no matter what.

Use instead function die(), which is meant to trap successes, and transform them into errors.

6 years agoMerge branch 'dev' into adapt
Yann Collet [Mon, 24 Sep 2018 23:56:45 +0000 (16:56 -0700)] 
Merge branch 'dev' into adapt

6 years agoMerge pull request #1332 from facebook/minclevel
Yann Collet [Mon, 24 Sep 2018 23:01:13 +0000 (16:01 -0700)] 
Merge pull request #1332 from facebook/minclevel

defined a minimum negative level

6 years agoMerge pull request #1336 from facebook/scanbuild
Yann Collet [Mon, 24 Sep 2018 21:49:16 +0000 (14:49 -0700)] 
Merge pull request #1336 from facebook/scanbuild

fixed minor scan-build warnings

6 years agoMerge pull request #1335 from facebook/limits
Yann Collet [Mon, 24 Sep 2018 21:49:03 +0000 (14:49 -0700)] 
Merge pull request #1335 from facebook/limits

added some tests based on limits.h

6 years agofixed minor scan-build warnings 1336/head
Yann Collet [Mon, 24 Sep 2018 07:52:19 +0000 (00:52 -0700)] 
fixed minor scan-build warnings

6 years agoadded some tests based on limits.h 1335/head
Yann Collet [Mon, 24 Sep 2018 06:57:30 +0000 (23:57 -0700)] 
added some tests based on limits.h

in order to ensure proper type mapping
when not using stdint.h

6 years agofixed zstd-decompress 1332/head
Yann Collet [Sun, 23 Sep 2018 00:21:39 +0000 (17:21 -0700)] 
fixed zstd-decompress

which cannot support ZSTD_minCLevel()

6 years agoMerge pull request #1331 from facebook/mingw
Yann Collet [Sat, 22 Sep 2018 23:11:55 +0000 (16:11 -0700)] 
Merge pull request #1331 from facebook/mingw

fix mingw compatibility

6 years agoenforce minimum compression level limit
Yann Collet [Sat, 22 Sep 2018 23:10:10 +0000 (16:10 -0700)] 
enforce minimum compression level limit

using ZSTD_minCLevel()

6 years agofixed constant comparison on 32-bits systems
Yann Collet [Sat, 22 Sep 2018 01:23:32 +0000 (18:23 -0700)] 
fixed constant comparison on 32-bits systems

6 years agoavoid recompiling dll every time under mingw 1331/head
Yann Collet [Sat, 22 Sep 2018 00:40:30 +0000 (17:40 -0700)] 
avoid recompiling dll every time under mingw

6 years agofix pzstd compatibility with mingw
Yann Collet [Sat, 22 Sep 2018 00:36:00 +0000 (17:36 -0700)] 
fix pzstd compatibility with mingw

some details changed with introduction of gcc7

6 years agofix constant redeclaration in paramgrill
Yann Collet [Sat, 22 Sep 2018 00:28:37 +0000 (17:28 -0700)] 
fix constant redeclaration in paramgrill

6 years agosimplified "slows down when compression blocked"
Yann Collet [Fri, 21 Sep 2018 23:35:43 +0000 (16:35 -0700)] 
simplified "slows down when compression blocked"

6 years agoMerge branch 'mingw' into adapt
Yann Collet [Fri, 21 Sep 2018 23:00:46 +0000 (16:00 -0700)] 
Merge branch 'mingw' into adapt

6 years agoensure all writes to job->cSize are mutex protected
Yann Collet [Fri, 21 Sep 2018 22:37:30 +0000 (15:37 -0700)] 
ensure all writes to job->cSize are mutex protected

even when reporting errors,
using a macro for code brevity, as suggested by @terrelln,

6 years agofixed tautological tests
Yann Collet [Fri, 21 Sep 2018 22:04:43 +0000 (15:04 -0700)] 
fixed tautological tests

involving ZSTD_TARGETLENGTH_MIN (== 0)

6 years agoMerge branch 'mingw' into minclevel
Yann Collet [Fri, 21 Sep 2018 21:56:57 +0000 (14:56 -0700)] 
Merge branch 'mingw' into minclevel

6 years agofix mingw compatibility
Yann Collet [Fri, 21 Sep 2018 21:46:09 +0000 (14:46 -0700)] 
fix mingw compatibility

only enable backtraces for platforms we know support it
aka mac OS-X and Linux.
can be extended later.

6 years agoMerge pull request #1318 from felixhandte/shadow-dict-matches
Yann Collet [Fri, 21 Sep 2018 19:15:33 +0000 (12:15 -0700)] 
Merge pull request #1318 from felixhandte/shadow-dict-matches

Don't Search Dictionary Context When Working Context Search Resulted in Mismatch

6 years agodefined a minimum negative level
Yann Collet [Thu, 20 Sep 2018 23:17:49 +0000 (16:17 -0700)] 
defined a minimum negative level

which can be probed using new function ZSTD_minCLevel().

Also : redefined ZSTD_TARGETLENGTH_MIN/MAX for consistency

used the opportunity to bump version number to v1.3.6

6 years agofixed versions-test to only test v0.5+ 1329/head
Yann Collet [Thu, 20 Sep 2018 21:59:11 +0000 (14:59 -0700)] 
fixed versions-test to only test v0.5+

since zstd_devel is no longer compatible with v0.4+

6 years agoChanged default legacy support to v0.5+
Yann Collet [Thu, 20 Sep 2018 21:24:23 +0000 (14:24 -0700)] 
Changed default legacy support to v0.5+

thus dropping read support for v0.4.

It's always possible to re-enable it, by changing build macro ZSTD_LEGACY_SUPPORT to 4.

6 years agofixed complex tsan issue
Yann Collet [Thu, 20 Sep 2018 20:47:31 +0000 (13:47 -0700)] 
fixed complex tsan issue

when job->consumed == job->src.size , compression job is presumed completed,
so it must be the very last action done in worker thread.

6 years agofixed minor gcc warning on a unused variable
Yann Collet [Thu, 20 Sep 2018 20:00:11 +0000 (13:00 -0700)] 
fixed minor gcc warning on a unused variable

6 years agoupdated man page
Yann Collet [Thu, 20 Sep 2018 00:37:22 +0000 (17:37 -0700)] 
updated man page

and added `--adapt` test in `playTests.sh`

6 years agofixed minor reporting discrepancy in MT mode
Yann Collet [Wed, 19 Sep 2018 23:30:55 +0000 (16:30 -0700)] 
fixed minor reporting discrepancy in MT mode

6 years agoremoved static variables
Yann Collet [Wed, 19 Sep 2018 22:09:45 +0000 (15:09 -0700)] 
removed static variables

so that --adapt can work on multiple input files too

6 years agoerror out when --adapt is associated with --single-thread
Yann Collet [Wed, 19 Sep 2018 21:49:13 +0000 (14:49 -0700)] 
error out when --adapt is associated with --single-thread

since they are not compatible

6 years agoMerge branch 'dev' into adapt
Yann Collet [Wed, 19 Sep 2018 19:43:42 +0000 (12:43 -0700)] 
Merge branch 'dev' into adapt

6 years agoMerge pull request #1326 from facebook/refPrefix
Yann Collet [Tue, 18 Sep 2018 22:28:34 +0000 (15:28 -0700)] 
Merge pull request #1326 from facebook/refPrefix

updated documentation of *refPrefix()

6 years agoupdated documentation of *refPrefix() 1326/head
Yann Collet [Tue, 18 Sep 2018 20:07:08 +0000 (13:07 -0700)] 
updated documentation of *refPrefix()

indicating the equivalence with `diff` operation.

6 years agoMerge pull request #1321 from bket/non-portable
Nick Terrell [Mon, 17 Sep 2018 21:40:27 +0000 (14:40 -0700)] 
Merge pull request #1321 from bket/non-portable

'head -c BYTES' is non-portable.

6 years agoMerge pull request #1324 from ko-zu/fixclangcode
Yann Collet [Mon, 17 Sep 2018 21:10:17 +0000 (14:10 -0700)] 
Merge pull request #1324 from ko-zu/fixclangcode

Fix largeNbDicts bench for clangbuild

6 years ago'head -c BYTES' is non-portable. 1321/head
Björn Ketelaars [Sat, 30 Jun 2018 13:42:42 +0000 (15:42 +0200)] 
'head -c BYTES' is non-portable.

tests/playTests.sh uses 'head -c' in a couple of tests to truncate the
last byte of a file. The '-c' option is non-portable (not in POSIX).
Instead use a wrapper around dd (truncateLastByte).

6 years agoMerge pull request #1322 from azat-archive/seekable-fixes-pull
Nick Terrell [Mon, 17 Sep 2018 18:04:51 +0000 (11:04 -0700)] 
Merge pull request #1322 from azat-archive/seekable-fixes-pull

Fixes read write past end of input buffer.

6 years agoFix largeNbDicts bench for clangbuild 1324/head
ko-zu [Mon, 17 Sep 2018 04:09:08 +0000 (13:09 +0900)] 
Fix largeNbDicts bench for clangbuild

Remove unsigned to size_t promotion to fix implicit down conversion errors in clangbuild target.

6 years agoseekable_decompression: support offset greater then UNIT_MAX 1322/head
Azat Khuzhin [Sun, 16 Sep 2018 15:04:43 +0000 (18:04 +0300)] 
seekable_decompression: support offset greater then UNIT_MAX

6 years agozstdseek_decompress: fix decompression with data left in input buffer
Azat Khuzhin [Sun, 16 Sep 2018 15:04:43 +0000 (18:04 +0300)] 
zstdseek_decompress: fix decompression with data left in input buffer

6 years agoMerge pull request #1319 from ko-zu/fixclangbuild
Yann Collet [Sun, 16 Sep 2018 02:31:42 +0000 (19:31 -0700)] 
Merge pull request #1319 from ko-zu/fixclangbuild

Fix clang build

6 years agoFix clang build 1319/head
ko-zu [Sun, 16 Sep 2018 01:27:02 +0000 (10:27 +0900)] 
Fix clang build

Fix dixygen comment
Fix clang binary path

6 years agominor code comment update
Yann Collet [Fri, 14 Sep 2018 23:06:35 +0000 (16:06 -0700)] 
minor code comment update

6 years agoMerge pull request #1295 from felixhandte/hdr-intro-comment-negative-lvls
Yann Collet [Fri, 14 Sep 2018 22:29:19 +0000 (15:29 -0700)] 
Merge pull request #1295 from felixhandte/hdr-intro-comment-negative-lvls

Proposed Update to Zstd.h Introduction Comment

6 years agoZSTD_dfast: Don't Search Dict Context When Mismatch Was Found 1318/head
W. Felix Handte [Fri, 14 Sep 2018 22:24:25 +0000 (15:24 -0700)] 
ZSTD_dfast: Don't Search Dict Context When Mismatch Was Found

6 years agoZSTD_fast: Don't Search Dict Context When Mismatch Was Found
W. Felix Handte [Fri, 14 Sep 2018 22:23:35 +0000 (15:23 -0700)] 
ZSTD_fast: Don't Search Dict Context When Mismatch Was Found

6 years agoMerge pull request #1316 from facebook/coldDict
Yann Collet [Fri, 14 Sep 2018 17:37:46 +0000 (10:37 -0700)] 
Merge pull request #1316 from facebook/coldDict

Cold dictionary mitigation

6 years agoupdated code comments, based on @terrelln review 1316/head
Yann Collet [Thu, 13 Sep 2018 23:44:04 +0000 (16:44 -0700)] 
updated code comments, based on @terrelln review

6 years agofixed msan error
Yann Collet [Thu, 13 Sep 2018 19:29:52 +0000 (12:29 -0700)] 
fixed msan error

cold dictionary is detected through a comparison with dictEnd,
which was not initialized at the beginning of first DCtx usage.

6 years agofinal parameter tuning
Yann Collet [Wed, 12 Sep 2018 23:54:57 +0000 (16:54 -0700)] 
final parameter tuning

6 years agoclean traces
Yann Collet [Wed, 12 Sep 2018 23:40:28 +0000 (16:40 -0700)] 
clean traces

6 years agofixed PREFETCH() macro
Yann Collet [Wed, 12 Sep 2018 23:15:37 +0000 (16:15 -0700)] 
fixed PREFETCH() macro

for corner cases and platforms without this instruction

6 years agoMerge pull request #1315 from cmcginty/dev
Yann Collet [Wed, 12 Sep 2018 23:12:00 +0000 (16:12 -0700)] 
Merge pull request #1315 from cmcginty/dev

Add build define to manually enable -rdynamic LD flag

6 years agoconditional dict content prefetching
Yann Collet [Wed, 12 Sep 2018 22:35:21 +0000 (15:35 -0700)] 
conditional dict content prefetching

based on nbSeq.

6 years agoAdd build define to manually enable -rdynamic LD flag 1315/head
Casey McGinty [Wed, 12 Sep 2018 21:00:08 +0000 (14:00 -0700)] 
Add build define to manually enable -rdynamic LD flag

6 years agoMerge pull request #1314 from terrelln/cpuid
Yann Collet [Wed, 12 Sep 2018 20:30:16 +0000 (13:30 -0700)] 
Merge pull request #1314 from terrelln/cpuid

[libzstd] Fix cpu for MSFT ARM

6 years agoadjust heuristic decisions
Yann Collet [Wed, 12 Sep 2018 19:32:09 +0000 (12:32 -0700)] 
adjust heuristic decisions

6 years agoAlso allow x86 1314/head
Nick Terrell [Wed, 12 Sep 2018 19:05:32 +0000 (12:05 -0700)] 
Also allow x86

6 years agolargeNbDicts : can select a nb of blocks
Yann Collet [Wed, 12 Sep 2018 18:28:45 +0000 (11:28 -0700)] 
largeNbDicts : can select a nb of blocks

will automatically truncate or repeat input as needed,
to create the requested nb of blocks.
default: nb of files, eventually increased appropriately if blockSize is set

6 years ago[libzstd] Fix cpu for MSFT ARM
Nick Terrell [Wed, 12 Sep 2018 17:35:16 +0000 (10:35 -0700)] 
[libzstd] Fix cpu for MSFT ARM

The `__cpuid()` and `__cpuidex()` intrinsics are only available
on x86 and x86_64.

6 years agoadded conditional prefetch
Yann Collet [Wed, 12 Sep 2018 17:29:47 +0000 (10:29 -0700)] 
added conditional prefetch

depending on amount of work to do.

6 years agoMerge pull request #1311 from cmcginty/dev
Yann Collet [Wed, 12 Sep 2018 17:13:23 +0000 (10:13 -0700)] 
Merge pull request #1311 from cmcginty/dev

Print a stack trace on unexpected term signal (e.g. SIGABRT)

6 years agoimplemented first prefetch
Yann Collet [Wed, 12 Sep 2018 00:23:44 +0000 (17:23 -0700)] 
implemented first prefetch

based on dictID.
dictContent is prefetched up to 32 KB
(no contentSize adaptation)

6 years agoDisable -rdynamic LD option on Windows 1311/head
Casey McGinty [Tue, 11 Sep 2018 23:19:34 +0000 (16:19 -0700)] 
Disable -rdynamic LD option on Windows

6 years agoUpdate comments, and LD flag usage in Make
Casey McGinty [Tue, 11 Sep 2018 21:49:47 +0000 (14:49 -0700)] 
Update comments, and LD flag usage in Make

6 years agoRemove dead code and method name typo
Casey McGinty [Tue, 11 Sep 2018 18:56:50 +0000 (11:56 -0700)] 
Remove dead code and method name typo

6 years agoMove ABRThandler func out of internal lib
Casey McGinty [Tue, 11 Sep 2018 18:39:49 +0000 (11:39 -0700)] 
Move ABRThandler func out of internal lib