Instead of messing with the internals of argparse, let's implement
proper configuration file parsing.
- Parsing classes and functions are located in a new file config.py
- Configuration settings are split up from CLI settings in a list of
the new ConfigSetting dataclass
- The CLI options for configuration settings now share the same
argparse setting which simply delegates parsing to the corresponding
configuration setting parser.
- We add support for [Match] sections to enable conditionally including
configuration files. Currently Match support is implemented for
Distribution= and Release=.
- Configuration file searching is reworked. In mkosi.conf.d/, we parse
all files ending with ".conf" and directories. If a directory is parsed,
we parse mkosi.conf, mkosi.conf.d/ and all mkosi specific paths in it.
All paths are interpreted relative to the directory that we're parsing.
Remove build phases docs as we only have a single phase these days
and update the caching section docs to take the new build overlay
approach into account.
Daan De Meyer [Thu, 30 Mar 2023 12:00:34 +0000 (14:00 +0200)]
qemu: Don't write any log messages when running qemu
The running command message can get huge depending on which credentials
you're using so let's not write it by default (can still get it with
--debug run). And the swtpm message isn't super useful either so let's
drop it as well.
Daan De Meyer [Thu, 30 Mar 2023 11:56:53 +0000 (13:56 +0200)]
qemu: Use virtconsole serial console instead of regular serial console
With --qemu-headless, qemu stops working when latest systemd is not
available because smbios provided kernel cmdline arguments are ignored.
This includes "console=ttyS0" meaning we don't get any output on the
serial console when booting in qemu.
As a workaround, let's use qemu's virtconsole instead. This means the
serial console will be available in the VM as /dev/hvc0, on which
systemd will automatically spawn a serial getty. This means we'll
eventually get a login prompt, even if latest systemd is not used.
One caveat is that EDK2 doesn't seem to support virtio-serial with
virtconsole. To get around this limitation, we keep a regular serial
console around as well, which can be used by the bootloader to log
its output.
Daan De Meyer [Wed, 29 Mar 2023 08:50:14 +0000 (10:50 +0200)]
Drop --netdev
Let's not configure systemd-networkd in mkosi, but leave this up
to users instead. As our SSH support now works on top of vsock, we
don't need this option anymore to make the SSH support work.
When booting, containers are started without a network device (trivial
to add one by adding --network-veth) and VMs are started with a network
device. We don't want one for containers so that they can just reuse the
network namespace of the host instead of having to start networkd to get
internet access within the container. For VMs, there's no disadvantage to
adding a network device, so we add one by default.
Daan De Meyer [Sun, 19 Mar 2023 11:30:45 +0000 (12:30 +0100)]
Replace --qemu-headless with --qemu-gui
We add extra kernel command line arguments that configure term and
the tty size at runtime. We start qemu in the terminal on a serial tty
by default now as well.
We introduce --qemu-gui to still allow booting qemu in a graphical
interface
We also pass the host environment to qemu and nspawn to mimick what
we do with ssh and because qemu needs the host environment to
initialize gtk properly.
Daan De Meyer [Mon, 27 Mar 2023 08:55:16 +0000 (10:55 +0200)]
Add --acl option
Let's make the usage of ACLs opt-in since they leak into the final
image if the directory output is used.
We move the call to print_output_size() so its executed inside the
user namespace, which is required because we might not have permissions
to read some of the image's directories outside the user namespace.
Luca Boccassi [Fri, 24 Mar 2023 01:04:05 +0000 (01:04 +0000)]
overlayfs: avoid userxattr if kernel version is < 5.11
userxattr was added as a mount option for overlayfs only in kernel 5.11,
so avoid it on older versions (like Debian stable):
‣ Running build script…
mount: /home/bluca/git/systemd/.mkosi.tmpzt2q0dyp/root: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error.
umount: /home/bluca/git/systemd/.mkosi.tmpzt2q0dyp/root: not mounted
Daan De Meyer [Mon, 20 Mar 2023 16:33:15 +0000 (17:33 +0100)]
SSH fixes
- Disable UsePAM to avoid a slow reverse DNS lookup
- Pass environ when runnning ssh to pass SSH_AUTH_SOCK
- Don't use a random CID, instead hash the machine name and take
the first 4 bytes as the CID
- Pull in sshd-keygen.target so the ssh key gets generated on boot.
Daan De Meyer [Sun, 19 Mar 2023 13:50:18 +0000 (14:50 +0100)]
Fix caching behavior of several functions
Follow up for cee0b1b. Forgot to add checking of state.for_cache.
Also configure_dracut() needs to stay cached since we have an option
to cache the initrd.
Daan De Meyer [Fri, 17 Mar 2023 14:45:14 +0000 (15:45 +0100)]
Reimplement Ssh option on top of VSock and credentials
SSH key generation is currently broken under unprivileged mkosi.
Instead of trying to make this work, let's rework the SSH feature
entirely.
First, we only really need the SSH option for getting additional
login shells in VMs, so if we drop the requirement that this works
for containers (which can already be accessed with machinectl), we
can use VSock instead of TUN/TAP to get rid of a ton of code.
We also have a much better way of provisioning the public key these
days, add a script "ssh.authorized_keys.root" to mkosi.credentials/
with the following contents:
```
\#!/bin/sh
ssh-add -L
```
So we don't need to do SSH key generation ourselves anymore, we can
just let the user provide their own SSH key via a credential.
Daan De Meyer [Fri, 17 Mar 2023 12:46:52 +0000 (13:46 +0100)]
centos: Add missing base features for ext4 on c8s
Accidentally only added the ext4 specific features and none of the
base features, let's make sure we add the base features as well,
especially sparse_super is important to make repart's minimize
guessing logic work properly.
Daan De Meyer [Thu, 16 Mar 2023 07:33:15 +0000 (08:33 +0100)]
Replace QemuSMBIOS option with KernelCommandLineExtra
We only really added the QemuSMBIOS option to be able to set stub
option for adding extra command line options. Let's replace it by
a less generic option to make it less verbose to use and to allow
passing the added kernel command line arguments to systemd running
in nspawn as well.
Daan De Meyer [Sun, 12 Mar 2023 17:23:01 +0000 (18:23 +0100)]
Extend credentials support
We now also read credentials from mkosi.credentials/. If a file in
mkosi.credentials/ is executable, we run the file and use its output
as the credential.
Daan De Meyer [Sun, 12 Mar 2023 15:54:00 +0000 (16:54 +0100)]
Stop mounting package caches into images when running scripts
The package manager in the container might be a very different
version than the one running on the host which could cause all
sorts of caching issues. Since we don't need the caches in the
image anymore as we run the package managers outside of the image,
let's stop mounting the cache directory into the image when running
scripts as well.
Daan De Meyer [Wed, 15 Feb 2023 17:09:29 +0000 (18:09 +0100)]
Add --initrd option
--initrd allows users to provide their own initrds. When used, we'll
automatically create another initrd per kernel containing just the
kernel modules and all the initrds to ukify.
We don't compress the kernel modules initrd as the kernel modules
should be compressed themselves already.
Daan De Meyer [Mon, 6 Mar 2023 10:09:31 +0000 (11:09 +0100)]
Use an overlay for the build image instead of a full image
Instead of building a second image for the build image, let's just
make it an overlay for the final image since the only difference
between the two is the list of installed packages. This speeds up
image builds and allows us to simplify the internal logic as well.
Daan De Meyer [Mon, 6 Mar 2023 09:32:55 +0000 (10:32 +0100)]
Packages related refactors
- Use Sequence as the type for passing package lists around
- Add install_packages() method to DistributionInstaller
- Remove install_packages_rpm() and use invoke_dnf() directly
Daan De Meyer [Fri, 3 Mar 2023 20:10:01 +0000 (21:10 +0100)]
Add fallback paths to PATH in run_workspace_command()
Some distros don't configure the appropriate default PATH for their
shell when executed non-interactively, so let's add some fallback
entries ourselves to make sure we can always find the executables we
need.
Franck Bui [Thu, 16 Feb 2023 10:50:32 +0000 (11:50 +0100)]
opensuse: 'leap' as release name is now an alias for 'stable'
Previously using 'leap' would have installed Leap 15.1 which doesn't make sense
since this version of Leap is obsolete and no more supported. Install the latest
stable version instead.