]> git.ipfire.org Git - thirdparty/unbound.git/log
thirdparty/unbound.git
5 years agoAdded view_local_datas_remove description to documentation 156/head
Alexander Berkes [Wed, 29 Jan 2020 14:32:55 +0000 (15:32 +0100)] 
Added view_local_datas_remove description to documentation

5 years agoAdded unbound-control view_local_datas_remove command
Alexander Berkes [Wed, 29 Jan 2020 01:28:00 +0000 (02:28 +0100)] 
Added unbound-control view_local_datas_remove command

5 years ago- Fix to silence the tls handshake errors for broken pipe and reset
W.C.A. Wijngaards [Tue, 28 Jan 2020 13:32:06 +0000 (14:32 +0100)] 
- Fix to silence the tls handshake errors for broken pipe and reset
  by peer, unless verbosity is set to 2 or higher.

5 years ago- Add PR#147 merge to changelog
Ralph Dolmans [Tue, 28 Jan 2020 12:41:26 +0000 (13:41 +0100)] 
- Add PR#147 merge to changelog

5 years agoMerge pull request #147 from mnach/minor-rfc-comment
Ralph Dolmans [Tue, 28 Jan 2020 12:39:18 +0000 (13:39 +0100)] 
Merge pull request #147 from mnach/minor-rfc-comment

minor #1344 change rfc reference for reserved top level dns names

5 years ago- iana portlist updated.
W.C.A. Wijngaards [Tue, 28 Jan 2020 11:25:37 +0000 (12:25 +0100)] 
- iana portlist updated.

5 years agominor #1344 change rfc reference for reserved top level dns names 147/head
Mikhail Nacharov [Tue, 21 Jan 2020 12:13:50 +0000 (17:13 +0500)] 
minor #1344 change rfc reference for reserved top level dns names

5 years ago- Add changelog entry for PR#148.
Ralph Dolmans [Mon, 27 Jan 2020 15:06:06 +0000 (16:06 +0100)] 
- Add changelog entry for PR#148.

5 years agoMerge pull request #148 from pettai/morestats
Ralph Dolmans [Mon, 27 Jan 2020 15:04:00 +0000 (16:04 +0100)] 
Merge pull request #148 from pettai/morestats

Add some TLS stats to unbound_munin_

5 years ago- Add changelog entry for RP#154
Ralph Dolmans [Mon, 27 Jan 2020 14:50:12 +0000 (15:50 +0100)] 
- Add changelog entry for RP#154
- autoconf after PR#154

5 years agoMerge pull request #154 from edmonds/edmonds/libbsd-support
Ralph Dolmans [Mon, 27 Jan 2020 14:44:32 +0000 (15:44 +0100)] 
Merge pull request #154 from edmonds/edmonds/libbsd-support

Allow use of libbsd functions with configure option --with-libbsd

5 years agoMerge branch 'master' into edmonds/libbsd-support 154/head
Ralph Dolmans [Mon, 27 Jan 2020 14:37:33 +0000 (15:37 +0100)] 
Merge branch 'master' into edmonds/libbsd-support

5 years ago- Fix #153: Disable validation for DSA algorithms. RFC 8624
W.C.A. Wijngaards [Mon, 27 Jan 2020 08:40:18 +0000 (09:40 +0100)] 
- Fix #153: Disable validation for DSA algorithms.  RFC 8624
  compliance.

5 years agoChangelog note for PR#155.
W.C.A. Wijngaards [Mon, 27 Jan 2020 08:31:07 +0000 (09:31 +0100)] 
Changelog note for PR#155.
- Merge PR#155 from Rober Edmonds: contrib/libunbound.pc.in: Fixes
  to Libs/Requires for crypto library dependencies.

5 years agoMerge branch 'master' of github.com:NLnetLabs/unbound
W.C.A. Wijngaards [Mon, 27 Jan 2020 08:29:18 +0000 (09:29 +0100)] 
Merge branch 'master' of github.com:NLnetLabs/unbound

5 years agoMerge pull request #155 from edmonds/edmonds/pkg-config/libs-fixes
Wouter Wijngaards [Mon, 27 Jan 2020 08:28:53 +0000 (09:28 +0100)] 
Merge pull request #155 from edmonds/edmonds/pkg-config/libs-fixes

contrib/libunbound.pc.in: Fixes to Libs/Requires for crypto library dependencies

5 years agocontrib/libunbound.pc.in: Embed the correct crypto dependencies 155/head
Robert Edmonds [Mon, 27 Jan 2020 03:23:53 +0000 (22:23 -0500)] 
contrib/libunbound.pc.in: Embed the correct crypto dependencies

This commit removes the hardcoded dependency in the libunbound
pkg-config .pc file on the libcrypto and libssl modules and instead
populates the .pc file based on which crypto library was selected at
configure time.

Note that the .pc file specifies pkg-config module names for the
"Requires" line and this can vary from the library filename (e.g. "nss"
is the pkg-config module name vs. "nss3" being the library name).

5 years agocontrib/libunbound.pc.in: Only specify -lunbound for Libs
Robert Edmonds [Mon, 27 Jan 2020 03:01:38 +0000 (22:01 -0500)] 
contrib/libunbound.pc.in: Only specify -lunbound for Libs

According to the pkg-config manpage, the "Libs" line in a .pc file
should give the link flags "specific to your package", and specifically
says not to include link flags for dependencies:

    Libs:  This line should give the link flags specific to your
           package.  Don't add any flags for required packages;
           pkg-config will add those automatically.

5 years agoAllow use of libbsd functions with configure option --with-libbsd
Steven Chamberlain [Thu, 16 Feb 2017 12:37:41 +0000 (12:37 +0000)] 
Allow use of libbsd functions with configure option --with-libbsd

Add a new configure option `--with-libbsd', which allows to use libbsd's
portable implementations of:

    strlcpy strlcat arc4random arc4random_uniform reallocarray

instead of the embedded code copies in contrib/, which will be
difficult to maintain in the long term.

Also patch util/random.c so that, when building with libbsd and without
OpenSSL, arc4random can still be used as the PRNG.  Otherwise, building
with libnettle would need a kernel-specific getentropy implementation,
and libbsd does not export one.

[edmonds@debian.org: Imported patch description from BTS, refreshed
patch against Unbound 1.9.6.]

5 years agoChangelog and contrib/README note for PR#150.
W.C.A. Wijngaards [Thu, 23 Jan 2020 15:16:52 +0000 (16:16 +0100)] 
Changelog and contrib/README note for PR#150.
- Merge PR#150 from Frzk: Systemd unit without chroot.  It add
  contrib/unbound_nochroot.service.in, a systemd file for use with
  chroot: "", see comments in the file, it uses systemd protections
  instead.

5 years agoMerge pull request #150 from Frzk/systemd_unit_without_chroot
Wouter Wijngaards [Thu, 23 Jan 2020 15:14:17 +0000 (16:14 +0100)] 
Merge pull request #150 from Frzk/systemd_unit_without_chroot

Systemd unit without chroot

5 years agoPatch configure.ac file to take the new contrib/unbound_nochroot.service unit file... 150/head
François KUBLER [Thu, 23 Jan 2020 14:51:07 +0000 (15:51 +0100)] 
Patch configure.ac file to take the new contrib/unbound_nochroot.service unit file in consideration.

All props to Wouter Wijngaards for this work.

5 years agoAdded a new unit file to run unbound with systemd and without chroot.
François KUBLER [Thu, 23 Jan 2020 14:46:53 +0000 (15:46 +0100)] 
Added a new unit file to run unbound with systemd and without chroot.

See https://github.com/NLnetLabs/unbound/pull/149

5 years agoUpdate unbound_munin_ 148/head
frpet [Thu, 23 Jan 2020 07:23:16 +0000 (08:23 +0100)] 
Update unbound_munin_

Add TLS (DoT) counters

5 years ago- Fix auth zone support for NSEC3 records without salt.
W.C.A. Wijngaards [Tue, 14 Jan 2020 15:03:29 +0000 (16:03 +0100)] 
- Fix auth zone support for NSEC3 records without salt.

5 years ago- Fix for memory leak when edns subnet config options are read when
W.C.A. Wijngaards [Tue, 14 Jan 2020 14:48:27 +0000 (15:48 +0100)] 
- Fix for memory leak when edns subnet config options are read when
  compiled without edns subnet support.

5 years ago- Fix crash after reload where a stats lookup could reference old key
W.C.A. Wijngaards [Tue, 14 Jan 2020 14:18:52 +0000 (15:18 +0100)] 
- Fix crash after reload where a stats lookup could reference old key
  cache and neg cache structures.

5 years ago- Removed the dnscrypt_queries and dnscrypt_queries_chacha tests,
W.C.A. Wijngaards [Tue, 14 Jan 2020 13:40:44 +0000 (14:40 +0100)] 
- Removed the dnscrypt_queries and dnscrypt_queries_chacha tests,
  because dnscrypt-proxy (2.0.36) does not support the test setup
  any more, and also the config file format does not seem to have
  the appropriate keys to recreate that setup.

5 years ago- Fix unreachable code in ssl set options code.
W.C.A. Wijngaards [Fri, 10 Jan 2020 10:28:01 +0000 (11:28 +0100)] 
- Fix unreachable code in ssl set options code.

5 years ago- Fix the relationship between serve-expired and prefetch options,
W.C.A. Wijngaards [Fri, 10 Jan 2020 09:04:50 +0000 (10:04 +0100)] 
- Fix the relationship between serve-expired and prefetch options,
  patch from Saksham Manchanda from Secure64.

5 years ago- Add changelog entry for fix #138 (stop binding pidfile inside chroot dir in
Ralph Dolmans [Wed, 8 Jan 2020 15:36:18 +0000 (16:36 +0100)] 
- Add changelog entry for fix #138 (stop binding pidfile inside chroot dir in
  systemd service file).

5 years agoMerge pull request #142 from Maryse47/patch-1
Ralph Dolmans [Wed, 8 Jan 2020 15:23:23 +0000 (16:23 +0100)] 
Merge pull request #142 from Maryse47/patch-1

unbound.service.in: stop binding pidfile inside chroot dir

5 years agounbound.service.in: stop binding pidfile inside chroot dir 142/head
Maryse47 [Wed, 8 Jan 2020 15:21:22 +0000 (15:21 +0000)] 
unbound.service.in: stop binding pidfile inside chroot dir

Apparently pidfile isn't used inside chroot and binding it may cause some weird failures with older systemd.

Fixes https://github.com/NLnetLabs/unbound/issues/138

5 years ago- And update for more spare space.
W.C.A. Wijngaards [Wed, 8 Jan 2020 11:58:07 +0000 (12:58 +0100)] 
- And update for more spare space.

5 years ago- Updated sldns_bget_token_par fix for also space for the zero
W.C.A. Wijngaards [Wed, 8 Jan 2020 10:55:42 +0000 (11:55 +0100)] 
- Updated sldns_bget_token_par fix for also space for the zero
  delimiter after the character.

5 years ago- Fix out-of-bounds null-byte write in sldns_bget_token_par while
W.C.A. Wijngaards [Wed, 8 Jan 2020 10:08:16 +0000 (11:08 +0100)] 
- Fix out-of-bounds null-byte write in sldns_bget_token_par while
  parsing type WKS, reported by Luis Merino from X41 D-Sec.

5 years ago- Fix 'make test' to work for --disable-sha1 configure option.
W.C.A. Wijngaards [Wed, 8 Jan 2020 08:23:46 +0000 (09:23 +0100)] 
- Fix 'make test' to work for --disable-sha1 configure option.

5 years ago- Changes to compat/getentropy_solaris.c for,
George Thessalonikefs [Tue, 7 Jan 2020 13:19:15 +0000 (15:19 +0200)] 
- Changes to compat/getentropy_solaris.c for,
  ifdef stdint.h inclusion for older systems.
  ifdef sha2.h inclusion for older systems.

5 years ago- Downgrade compat/getentropy_solaris.c to version 1.4 from OpenBSD.
George Thessalonikefs [Tue, 7 Jan 2020 13:06:14 +0000 (15:06 +0200)] 
- Downgrade compat/getentropy_solaris.c to version 1.4 from OpenBSD.
  The dl_iterate_phdr() function introduced in newer versions raises
  compilation errors on solaris 10.

5 years ago- Fix #140: Document slave not downloading new zonefile upon update.
W.C.A. Wijngaards [Mon, 6 Jan 2020 15:36:44 +0000 (16:36 +0100)] 
- Fix #140: Document slave not downloading new zonefile upon update.

5 years ago(Changelog note for #135).
W.C.A. Wijngaards [Mon, 6 Jan 2020 15:18:46 +0000 (16:18 +0100)] 
(Changelog note for #135).
- Merge #135 from Florian Obser: Use passed in neg and key cache
  if non-NULL.

5 years agoMerge pull request #135 from fobser/pass-in-neg-key-cache
Wouter Wijngaards [Mon, 6 Jan 2020 15:17:16 +0000 (16:17 +0100)] 
Merge pull request #135 from fobser/pass-in-neg-key-cache

Use passed in neg and key cache if non-NULL.

5 years agoUse passed in neg and key cache if non-NULL. 135/head
Florian Obser [Thu, 19 Dec 2019 12:20:34 +0000 (13:20 +0100)] 
Use passed in neg and key cache if non-NULL.

With this the neg and key caches can be shared between multiple
libunbound contexts.

The msg and rrset caches already allowed this since context_finalize()
did not touch those if they are already available and have the correct
size.

Care must be taken to properly unhook the caches from the validator
environment before calling ub_ctx_delete() otherwise one risks double
free or use after free bugs.

5 years ago- Update mailing list URL.
George Thessalonikefs [Mon, 16 Dec 2019 15:03:31 +0000 (16:03 +0100)] 
- Update mailing list URL.

5 years agoFixup 1.9.7 version commit in configure.ac.
W.C.A. Wijngaards [Thu, 12 Dec 2019 14:52:21 +0000 (15:52 +0100)] 
Fixup 1.9.7 version commit in configure.ac.

5 years ago- Fix typo to let serve-expired-ttl work with ub_ctx_set_option(), by
Ralph Dolmans [Thu, 12 Dec 2019 12:05:09 +0000 (13:05 +0100)] 
- Fix typo to let serve-expired-ttl work with ub_ctx_set_option(), by
  Florian Obser

5 years agoMerge pull request #129 from fobser/serve-expired-ttl-typo
Ralph Dolmans [Thu, 12 Dec 2019 11:59:28 +0000 (12:59 +0100)] 
Merge pull request #129 from fobser/serve-expired-ttl-typo

Fix typo to let serve-expired-ttl work with ub_ctx_set_option().

5 years agoMake master 1.9.7 in development.
Ralph Dolmans [Thu, 12 Dec 2019 11:48:29 +0000 (12:48 +0100)] 
Make master 1.9.7 in development.

5 years agoFix typo to let serve-expired-ttl work with ub_ctx_set_option(). 129/head
Florian Obser [Tue, 10 Dec 2019 17:03:21 +0000 (18:03 +0100)] 
Fix typo to let serve-expired-ttl work with ub_ctx_set_option().

5 years ago- Fix to make auth zone IXFR to fallback to AXFR if a single
W.C.A. Wijngaards [Tue, 10 Dec 2019 12:09:50 +0000 (13:09 +0100)] 
- Fix to make auth zone IXFR to fallback to AXFR if a single
  response RR is received over TCP with the SOA in it.

5 years ago- Fix Makefile.in for ipset module compile, from Adi Prasaja. release-1.9.6
W.C.A. Wijngaards [Fri, 6 Dec 2019 10:31:34 +0000 (11:31 +0100)] 
- Fix Makefile.in for ipset module compile, from Adi Prasaja.

5 years ago- Fix ipsecmod compile.
W.C.A. Wijngaards [Fri, 6 Dec 2019 06:59:55 +0000 (07:59 +0100)] 
- Fix ipsecmod compile.

5 years ago- tag for 1.9.6rc1. release-1.9.6rc1
W.C.A. Wijngaards [Thu, 5 Dec 2019 10:21:46 +0000 (11:21 +0100)] 
- tag for 1.9.6rc1.

5 years ago- unbound-fuzzers.tar.bz2: three programs for fuzzing, that are 1:1
W.C.A. Wijngaards [Thu, 5 Dec 2019 08:10:49 +0000 (09:10 +0100)] 
- unbound-fuzzers.tar.bz2: three programs for fuzzing, that are 1:1
  replacements for unbound-fuzzme.c that gets created after applying
  the contrib/unbound-fuzzme.patch.  They are contributed by
  Eric Sesterhenn from X41 D-Sec.

5 years ago- Fix Make Test Fails when Configured With --enable-alloc-nonregional,
W.C.A. Wijngaards [Wed, 4 Dec 2019 15:23:52 +0000 (16:23 +0100)] 
- Fix Make Test Fails when Configured With --enable-alloc-nonregional,
  reported by X41 D-Sec.

5 years ago- update contrib/fastrpz.patch to apply more cleanly.
W.C.A. Wijngaards [Wed, 4 Dec 2019 10:41:13 +0000 (11:41 +0100)] 
- update contrib/fastrpz.patch to apply more cleanly.

5 years ago- Fix testbound for alloccheck runs, memory purify and lock checks.
W.C.A. Wijngaards [Wed, 4 Dec 2019 10:37:24 +0000 (11:37 +0100)] 
- Fix testbound for alloccheck runs, memory purify and lock checks.

5 years ago- Fix lock type for memory purify log lock deletion.
W.C.A. Wijngaards [Wed, 4 Dec 2019 08:44:31 +0000 (09:44 +0100)] 
- Fix lock type for memory purify log lock deletion.

5 years ago- make depend
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:28:51 +0000 (17:28 +0100)] 
- make depend

5 years ago- Fix Hardcoded Constant, reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:23:38 +0000 (17:23 +0100)] 
- Fix Hardcoded Constant, reported by X41 D-Sec.

5 years ago- Fix _vfixed not Used, removed from sbuffer code,
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:07:35 +0000 (17:07 +0100)] 
- Fix _vfixed not Used, removed from sbuffer code,
  reported by X41 D-Sec.

5 years ago- Fix compile error in dnscrypt.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:44:24 +0000 (16:44 +0100)] 
- Fix compile error in dnscrypt.

5 years ago- Fix Client NONCE Generation used for Server NONCE,
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:42:14 +0000 (16:42 +0100)] 
- Fix Client NONCE Generation used for Server NONCE,
  reported by X41 D-Sec.

5 years ago- Fix Bad Indentation, in dnscrypt.c,
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:34:53 +0000 (16:34 +0100)] 
- Fix Bad Indentation, in dnscrypt.c,
  reported by X41 D-Sec.

5 years ago- Fix snprintf() supports the n-specifier,
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:29:18 +0000 (16:29 +0100)] 
- Fix snprintf() supports the n-specifier,
  reported by X41 D-Sec.

5 years agoNote what it did, lower to 256 max count.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:21:04 +0000 (16:21 +0100)] 
Note what it did, lower to 256 max count.

5 years ago- Fix Hang in sldns_wire2str_pkt_scan(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:20:24 +0000 (16:20 +0100)] 
- Fix Hang in sldns_wire2str_pkt_scan(),
  reported by X41 D-Sec.

5 years ago- Fix Out of Bound Write Compressed Names in rdata_copy(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:18:47 +0000 (16:18 +0100)] 
- Fix Out of Bound Write Compressed Names in rdata_copy(),
  reported by X41 D-Sec.

5 years ago- Fix Insufficient Handling of Compressed Names in dname_pkt_copy(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:17:03 +0000 (16:17 +0100)] 
- Fix Insufficient Handling of Compressed Names in dname_pkt_copy(),
  reported by X41 D-Sec.

5 years ago- Fix Out of Bounds Write in sldns_b64_pton(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:10:34 +0000 (16:10 +0100)] 
- Fix Out of Bounds Write in sldns_b64_pton(),
  fixed by check in sldns_str2wire_int16_data_buf(),
  reported by X41 D-Sec.

5 years ago- Fix Out of Bounds Write in sldns_str2wire_str_buf(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:01:31 +0000 (16:01 +0100)] 
- Fix Out of Bounds Write in sldns_str2wire_str_buf(),
  reported by X41 D-Sec.

5 years ago- Fix OOB Read in sldns_wire2str_dname_scan(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:42:34 +0000 (15:42 +0100)] 
- Fix OOB Read in sldns_wire2str_dname_scan(),
  reported by X41 D-Sec.

5 years ago- Fix Assert Causing DoS in dname_pkt_copy(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:20:48 +0000 (15:20 +0100)] 
- Fix Assert Causing DoS in dname_pkt_copy(),
  reported by X41 D-Sec.

5 years ago- Fix similar code in auth_zone synth cname to add the extra checks.
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:11:22 +0000 (15:11 +0100)] 
- Fix similar code in auth_zone synth cname to add the extra checks.

5 years ago- Fix Assert Causing DoS in synth_cname(),
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:10:36 +0000 (15:10 +0100)] 
- Fix Assert Causing DoS in synth_cname(),
  reported by X41 D-Sec.

5 years ago- Fix text around serial arithmatic used for RRSIG times to refer
W.C.A. Wijngaards [Tue, 3 Dec 2019 11:58:09 +0000 (12:58 +0100)] 
- Fix text around serial arithmatic used for RRSIG times to refer
  to correct RFC number.

5 years agoChangelog entry for merge of #124.
W.C.A. Wijngaards [Tue, 3 Dec 2019 09:03:44 +0000 (10:03 +0100)] 
Changelog entry for merge of #124.
- Merge pull request #124 from rmetrich: Changed log lock
  from 'quick' to 'basic' because this is an I/O lock.

5 years agoMerge pull request #124 from rmetrich/basic_loglock
Wouter Wijngaards [Tue, 3 Dec 2019 09:03:24 +0000 (10:03 +0100)] 
Merge pull request #124 from rmetrich/basic_loglock

Changed log lock from 'quick' to 'basic' because this is an I/O lock.

5 years agoChangelog entry for #122.
W.C.A. Wijngaards [Mon, 2 Dec 2019 12:59:43 +0000 (13:59 +0100)] 
Changelog entry for #122.
- Merge pull request #122 from he32: In tcp_callback_writer(),
  don't disable time-out when changing to read.

5 years agoMerge pull request #122 from he32/timeout-fix
Wouter Wijngaards [Mon, 2 Dec 2019 12:59:13 +0000 (13:59 +0100)] 
Merge pull request #122 from he32/timeout-fix

In tcp_callback_writer(), don't disable time-out when changing to read.

5 years agoChanged log lock from 'quick' to 'basic' because this is an I/O lock. 124/head
Renaud Métrich [Tue, 26 Nov 2019 15:32:03 +0000 (16:32 +0100)] 
Changed log lock from 'quick' to 'basic' because this is an I/O lock.

We cannot use a 'quick' lock (i.e. lock spinning on the CPU) for the log
lock because it can wait a lot on I/Os. Using a 'quick' lock leads to
eating the CPU for no good reason.

Example of 'pidstat' output when using various locks for log_lock:

- 'quick' lock and slow log file system (tail -f on the log file on XFS on RHEL 8)

04:15:11 PM   UID      TGID       TID    %usr %system    %CPU CPU  Command
04:15:21 PM   998     16431         -  100.00    4.20  100.00   2  unbound
04:15:21 PM   998         -     16431   31.00    1.00   32.00   2  |__unbound
04:15:21 PM   998         -     16432   31.30    0.80   32.10   0  |__unbound
04:15:21 PM   998         -     16433   30.20    1.40   31.60   1  |__unbound
04:15:21 PM   998         -     16434   30.70    1.00   31.70   3  |__unbound

- 'quick' lock and log file system being fast

04:15:40 PM   UID      TGID       TID    %usr %system   %CPU CPU  Command
04:15:50 PM   998     16431         -   10.00    1.60  11.60   1  unbound
04:15:50 PM   998         -     16431    2.50    0.50   3.00   1  |__unbound
04:15:50 PM   998         -     16432    2.30    0.40   2.70   3  |__unbound
04:15:50 PM   998         -     16433    2.70    0.30   3.00   0  |__unbound
04:15:50 PM   998         -     16434    2.60    0.40   3.00   2  |__unbound

- 'basic' lock (this commit) and slow log file system (tail -f on the log file on XFS on RHEL 8)

04:29:48 PM   UID      TGID       TID    %usr %system   %CPU CPU  Command
04:29:58 PM   998     11632         -    7.10   14.10  21.20   3  unbound
04:29:58 PM   998         -     11632    1.70    3.20   4.90   3  |__unbound
04:29:58 PM   998         -     11633    1.60    3.30   4.90   1  |__unbound
04:29:58 PM   998         -     11634    2.00    4.10   6.10   1  |__unbound
04:29:58 PM   998         -     11635    1.90    3.50   5.40   1  |__unbound

We can see in the above example, when 'basic' lock is used, that CPU
isn't consumed when log file system is slow.

Another reproducer scenario: put the log file on a NFS share with 'sync'
option.

5 years agoIn tcp_callback_writer(), don't disable time-out when changing to read. 122/head
Havard Eidnes [Mon, 25 Nov 2019 23:02:34 +0000 (00:02 +0100)] 
In tcp_callback_writer(), don't disable time-out when changing to read.

5 years ago- Add make distclean that removes everything configure produced,
W.C.A. Wijngaards [Fri, 22 Nov 2019 14:10:02 +0000 (15:10 +0100)] 
- Add make distclean that removes everything configure produced,
  and make maintainer-clean that removes bison and flex output.

5 years agoFix compiler warnings.
George Thessalonikefs [Fri, 22 Nov 2019 13:30:56 +0000 (14:30 +0100)] 
Fix compiler warnings.

5 years ago- Fix dname loop maximum, reported by Eric Sesterhenn from X41 D-Sec.
W.C.A. Wijngaards [Fri, 22 Nov 2019 13:23:00 +0000 (14:23 +0100)] 
- Fix dname loop maximum, reported by Eric Sesterhenn from X41 D-Sec.

5 years ago- Fix comments for doxygen in dns64.
W.C.A. Wijngaards [Wed, 20 Nov 2019 14:22:20 +0000 (15:22 +0100)] 
- Fix comments for doxygen in dns64.

5 years ago- Fix python examples/calc.py for eval, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 14:07:09 +0000 (15:07 +0100)] 
- Fix python examples/calc.py for eval, reported by X41 D-Sec.

5 years ago- Fix Bad Randomness in Seed, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:40:50 +0000 (14:40 +0100)] 
- Fix Bad Randomness in Seed, reported by X41 D-Sec.

5 years ago- Fix NULL Pointer Dereference via Control Port,
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:37:13 +0000 (14:37 +0100)] 
- Fix NULL Pointer Dereference via Control Port,
  reported by X41 D-Sec.

5 years agoReview fix of space.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:24:31 +0000 (14:24 +0100)] 
Review fix of space.

5 years ago- Fix Enum Name not Used, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:22:06 +0000 (14:22 +0100)] 
- Fix Enum Name not Used, reported by X41 D-Sec.

5 years ago- Fix Unrequired Checks, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:05:54 +0000 (14:05 +0100)] 
- Fix Unrequired Checks, reported by X41 D-Sec.

5 years ago- Fix Useless memset() in validator, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:02:58 +0000 (14:02 +0100)] 
- Fix Useless memset() in validator, reported by X41 D-Sec.

5 years ago- Fix Terminating Quotes not Written, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:01:01 +0000 (14:01 +0100)] 
- Fix Terminating Quotes not Written, reported by X41 D-Sec.

5 years ago- Fix compile with --enable-alloc-checks, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:51:10 +0000 (13:51 +0100)] 
- Fix compile with --enable-alloc-checks, reported by X41 D-Sec.

5 years ago- Fixed Compat Code Diverging from Upstream, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:30:27 +0000 (13:30 +0100)] 
- Fixed Compat Code Diverging from Upstream, reported by X41 D-Sec.

5 years ago- Changes to compat/getentropy files for,
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:28:49 +0000 (13:28 +0100)] 
- Changes to compat/getentropy files for,
  no link to openssl if using nettle, and hence config.h for
  HAVE_NETTLE variable.
  compat definition of MAP_ANON, for older systems.
  ifdef stdint.h inclusion for older systems.
  ifdef sha2.h inclusion for older systems.

5 years ago- Upgrade compat/getentropy_osx.c to version 1.12 from OpenBSD.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:12:36 +0000 (13:12 +0100)] 
- Upgrade compat/getentropy_osx.c to version 1.12 from OpenBSD.

5 years ago- Upgrade compat/getentropy_solaris.c to version 1.13 from OpenBSD.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:11:05 +0000 (13:11 +0100)] 
- Upgrade compat/getentropy_solaris.c to version 1.13 from OpenBSD.

5 years ago- Synchronize compat/getentropy_win.c with version 1.5 from
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:08:43 +0000 (13:08 +0100)] 
- Synchronize compat/getentropy_win.c with version 1.5 from
  OpenBSD, no changes but makes the file, comments, identical.