Switch TestRuleMetricsDefault to pass

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16471 from PowerDNS/dependabot/pip/builder-support/requests-2.32.4

chore(deps): bump requests from 2.32.3 to 2.32.4 in /builder-support

Merge pull request #16476 from omoerbeek/contrib-followup

contrib/ProtobufLogger.py: Fix syntax error that crept in with 16458

Merge pull request #16077 from omoerbeek/c++20-for-real

Prep, but do not actually move to C++20

Merge pull request #16283 from sndrsmnk/docupd2

dnsdist downstream-timeouts documentation update

Merge pull request #16473 from miodvallat/spanish_cow

auth, rec: typos

Fix syntax error that crept in with 16458

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16362 from omoerbeek/rec-ottrace-conditions

rec: implement new feature to only generate OpenTelemetry Traces on certain conditions

Fix grammar in error messages.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

chore(deps): bump requests from 2.32.3 to 2.32.4 in /builder-support

Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](https://github.com/psf/requests/compare/v2.32.3...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #16464 from romeroalx/fix-upload-pkgs-pattern

build-packages.yml: update workflow after changes in the download-artifacts action

Merge pull request #16425 from pieterlexis/dnsdist-cov-parentSpanID

fix(protozero): Always initialize SpanID and TraceID to zero

Refactor common code in tests and add a few tests

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16467 from miodvallat/tiptoeing

auth: bunch of boring idempotent commits

fix(protozero): Keep the SpanID and TraceID ctors `constexpr`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Appease clang-tidy

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Better commments in spec files

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Revert the actual move to C++, but keep all the other changes

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

USe C++ style includes for C header files

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Various fixes to make dnsdist and auth work on el-8

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Use gnu++20 instead of c++20, according to Habbie it makes porting to e.g. Suse and Haiku easier.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Fix two more cases of ambiguous operator calls

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Tidy

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Missing include

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Bump minimal c++ version to c++20

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Avoid two cases of too early instantation of a member of a vector of an incomplete class

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

c++20 does not allow implicit capture of this

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Avoid a few cases of warning: C++20 says that these are ambiguous, even though the second is reversed

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Remove commented out crude debug/log code.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Replace commented out logging code with #if 0 sections. NFCI

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Remove undocumented {new,dup}DNSPacket from Lua.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Prepare qthread() for its catch block to be able to access its locals. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Simplify Bind2Backend::handle. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16343 from miodvallat/bacf'

auth rfc2136: more churning

Merge pull request #16427 from omoerbeek/rec-print-settings

rec: rec_control get-parameter: print runtime settings in YAML format if YAML config is active

Process review comments

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16300 from FalkoFlessner/falko-NOISSUE-fix-docs-realremote

Fix[docs]: "real-remote" is always a CIDR-netmask

Merge pull request #16398 from Habbie/sdist-files

auth sdist: copy files as files, not as new dirs

Merge pull request #16456 from jsoref/codeql-quality-unreachable-dnsdist

Clean up unreachable code for dnsdist

Merge pull request #16361 from miodvallat/chording

lmdb: allow different mapsize values for main and shards

Merge pull request #16370 from miodvallat/secondary_considerations

auth: xfr churning

Merge pull request #16399 from Habbie/auth-upgrade-master

auth upgrade notes: stop confusing people with future version numbers

Merge pull request #16454 from jsoref/codeql-quality-unused-local-variable

chore: Clean up unused variables

build-packages.yml: update for changes in download-packages action

Merge pull request #16457 from jsoref/codeql-quality-unreachable

Clean up unreachable code

Merge pull request #16459 from jsoref/fix-checkDump-try-except

Fix try/except/as notation

Process docs review comments from Pieter

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Tidy

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Spell-check found typos

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Typo's from miod's review

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Docs and bit of a dirty hack: flush protobuf queue immediately in test mode

Saves 50s on a Protobuf test run (180s before)

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Rewrite tests using reloading of config in place of several test classes with different configs

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Fix test with new semantics of TraceIDOnly

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Generate TraceID and SpanID later (and only if needed)

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Fix qtype test (and fix an existing class/type confusion while there)

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add a few OT Conditional trace tests

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

extend test to cover both incoming UDP and TCP

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

regression test: adapt to new OT conditionals regime

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Handle traceid_only and other conditions correctly

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add TCP case, do early match when we know the source

One case goes wrong: old-style tracing enabled and OT tracing enabled, but traceid_only is set

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Matching logic

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Housekeeping of global and thread-local data of OT conditions

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add struct for specifying conditions for OpenTelemetry Tracing

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16451 from Habbie/luajit-thread-aargh64itizer

luawrapper: on luajit+arm64+tsan, retry allocs harder

Merge pull request #16460 from jsoref/use-map-for-getHTTPCounter

Avoid warning about mixed explicit/implicit returns

Fix reference to class variable

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16395 from pieterlexis/dnsdist-ot-settraceid

dnsdist: Add option to use incoming OpenTelemetry Trace ID

Take @rgacogne's suggestion and provide ct for initializer list

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16440 from omoerbeek/endian-janitor

Cleanup endianness determining code

Merge pull request #16458 from jsoref/use-map-for-getAppliedPolicyTypeAsString

Use map for getAppliedPolicyTypeAsString

luawrapper: on luajit+arm64+tsan, retry allocs harder

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Peter van Dijk <peter.van.dijk@powerdns.com>

Merge pull request #16461 from omoerbeek/rec-ws-loglevel

rec: fix parsing of webserver loglevel "none"

Merge pull request #16452 from miodvallat/distraction

dnsdist: evil code which will hurt your eyesight

Merge pull request #16453 from jsoref/codeql-quality-unused-local-variable-dnsdist

chore: Clean up unused variables (dnsdist)

Merge pull request #16450 from rgacogne/ddist-fix-format-type-in-regression-tests

chores(dnsdist): Replace '%s' with '%d' when formatting integers in our tests

Add two missing dependencies

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

rec: fix webserver loglevel from config

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Use map (and KeyError) to avoid warning about mixed explicit/implicit returns

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Fix try/except/as notation

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use map for getAppliedPolicyTypeAsString

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Use finally for cleanup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unreachable cleanup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Reach logging before raising

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Clean up unreachable code for dnsdist

- Remove unreachable cleanup
- Use finally for cleanup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Clean up unused variables

- Change get_rust_struct_fields_from_definition to use `indent`

  All callers were maintaining it, get_rust_struct_from_definition had updated it but left it unused...

- Fix type annotations
- Remove dead code for `response`
- Remove dead code for `url`
- Remove dead code for `wire`
- Remove unused timing
- Remove unused variable `data`
- Remove unused variable `dropped`
- Remove unused variable `fileContent`
- Remove unused variable `message`
- Remove unused variable `method`
- Remove unused variable `name`
- Remove unused variable `numberOfQueries`
- Remove unused variable `output`
- Remove unused variable `pbMessageType`
- Remove unused variable `rcode`
- Remove unused variable `secondSerial`
- Remove unused variable `total`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Alter the qname bpf filter to make it const.

This program needs to use a runtime value (a file descriptor), so in its
current form it is a non-const HUGE initializer, and causes the compiler
to emit a lot of code to initialize the local variable with the program
data, eating a lot of memory while there.

By changing the program to use a value of zero for the file descriptor,
the initializer becomes const; we need however to search for that
instruction and pach it before using the program, and this is not the
code I am most proud of... but when life gives you lemons, etc.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

chore: Use variable `rets`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Unshadow domain and store domainObject

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Test `wire_message`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `search`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `res`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `rdataset`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `r`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `payload`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `name`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `ixfr`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `h`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `expectedCNAME`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `expected`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore: Remove unused variable `data`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>