Fix `with open(...) as f:`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16484 from jsoref/codeql-confusing-operator-precedence

Improve reading of operator expression

Merge pull request #16503 from rgacogne/dnsheader_aligned_no_copy

`dnsheader_aligned`: Prevent copies

Merge pull request #16504 from rgacogne/ddist-doq-handle-response

dnsdist: Clarify that our DoQ's `handleResponse` consumes the response

Merge pull request #16505 from rgacogne/ddist-modernize-pc-code

dnsdist: Apply clang-tidy recommendations to the packet cache code

dnsdist: Clarify that our DoQ's `handleResponse` consumes the response

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsheader_aligned: Prevent copies

The `dnsheader_aligned` object contains a pointer that references
either the `dnsheader` passed to the constructor if it is properly
aligned, or the internal `dnsheader` member. In the second case,
making a copy would mean we can reference an object that has been
destructed, which is a serious problem.

This commit also ensures copy elision is done `DNSQuestion:getHeader`,
as otherwise the compiler might refuse to compile.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Apply clang-tidy recommendations to the packet cache code

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16500 from jsoref/codeql-use-with-open-as-file-to-ensure-file-is-always-closed

Use `with open(...) as f:` to ensure file is always closed

Merge pull request #16501 from jsoref/codeql-explicitly-return

Stop mixing implicit and explicit returns

Change `to_wire` to not mix explicit and implicit returns

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Return void

And omit `;` as python does not really believe in them

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Return void

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use `with open(...) as f:` to ensure file is always closed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16494 from jsoref/codeql-unused-loop-iterator-name

Codeql unused loop iterator name

Merge pull request #16497 from omoerbeek/rec-coverity-20251113

rec: fix coverity 1635199, 1643012, 1643013

Merge pull request #16498 from jsoref/codeql-use-identifiers

Codeql use identifiers

Merge pull request #16490 from jsoref/codeql-do-not-mutate-default-values

Do not mutate default values

Merge pull request #16491 from jsoref/codeql-only-import-module-once

Only import doqclient once

Merge pull request #16493 from jsoref/codeql-unused-argument-to-format

Drop unused format argument

Merge pull request #16492 from jsoref/codeql-imprecise-assert-not-equal

Use assertNotEqual

Merge pull request #16489 from jsoref/codeql-ignore-keyboardexception-and-sysexit

Do not catch `KeyboardInterrupt` or `SystemExit`

Merge pull request #16488 from jsoref/codeql-do-not-exit-with-void-return

Do not call `sys.exit` with a void return

Remove duplicated function

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Check results

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Disambiguate test functions in class

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Only assign to response once

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Only assign to _tlsServerPort once

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Fix dnssec handling of `required_fields`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Only assign to name once

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Ignore return from `requests.get`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Validate greeting from pipe caller

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use `_` to hint that the value does not matter

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Declare variable outside loop to clarify that its use extends beyond loop

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Fix iteration variable name to match consumer

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Drop unused format argument

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertNotEqual

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertNotEqual

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Only import doqclient once

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rec: fix coverity 1635199, 1643012, 1643013

First two are simple optimizatios.
1643013 is: Check of thread-shared field evades lock acquisition

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Do not mutate default values

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Do not catch KeyboardInterrupt or SystemExit

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Do not call `sys.exit` with a void return

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16108 from karelbilek/kb/shuffle

dnsdist: implement simple packet shuffle in cache

Merge pull request #16462 from rgacogne/ddist-fix-crash-missing-selector-name

dnsdist: Fix a crash when a selector or policy cannot be found

Merge pull request #16401 from Habbie/auth-meson-names-dumb-rename

auth meson: reset binary names to original

Merge pull request #16479 from jsoref/metrics-table-module

Convert metrics_table.py to a module

Merge pull request #16480 from jsoref/test-metrics-ineffectual-statement

Switch TestRuleMetricsDefault to pass

Merge pull request #16481 from jsoref/codeql-imprecise-assert

Codeql imprecise assert

Merge pull request #16483 from jsoref/codeql-unnecessary-lambda

Drop useless lambda

Improve reading of operator expression

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Drop useless lambda

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertNotIn

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertNotIn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertNotEqual

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertNotEqual
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertLessEqual

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertLessEqual
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertLess

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertLess
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertIn

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertIn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertGreaterEqual

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertGreaterEqual
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertGreater

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertGreater
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use assertEqual

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertEqual
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16478 from jsoref/fix-duplicate-key-in-dict-literal

Fix duplicate key in dict literal

Show previous `versionchanged` for `logging.structured_logging`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Split `recursor.cpu_map` `doc`/`doc-new`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Switch TestRuleMetricsDefault to pass

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Convert metrics_table.py to a module

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16471 from PowerDNS/dependabot/pip/builder-support/requests-2.32.4

chore(deps): bump requests from 2.32.3 to 2.32.4 in /builder-support

Merge pull request #16476 from omoerbeek/contrib-followup

contrib/ProtobufLogger.py: Fix syntax error that crept in with 16458

Merge pull request #16077 from omoerbeek/c++20-for-real

Prep, but do not actually move to C++20

Merge pull request #16283 from sndrsmnk/docupd2

dnsdist downstream-timeouts documentation update

Merge pull request #16473 from miodvallat/spanish_cow

auth, rec: typos

dnsdist: more thorough packet cache shuffle test

Signed-off-by: Karel Bilek <kb@karelbilek.com>

Fix syntax error that crept in with 16458

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16362 from omoerbeek/rec-ottrace-conditions

rec: implement new feature to only generate OpenTelemetry Traces on certain conditions

dnsdist: Add a test for unknown policy name from Yaml

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix a typo when a Yaml-originated selector name does not exist

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Fix grammar in error messages.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

chore(deps): bump requests from 2.32.3 to 2.32.4 in /builder-support

Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](https://github.com/psf/requests/compare/v2.32.3...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #16464 from romeroalx/fix-upload-pkgs-pattern

build-packages.yml: update workflow after changes in the download-artifacts action

Merge pull request #16425 from pieterlexis/dnsdist-cov-parentSpanID

fix(protozero): Always initialize SpanID and TraceID to zero

Refactor common code in tests and add a few tests

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16467 from miodvallat/tiptoeing

auth: bunch of boring idempotent commits

fix(protozero): Keep the SpanID and TraceID ctors `constexpr`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Appease clang-tidy

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Better commments in spec files

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Revert the actual move to C++, but keep all the other changes

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

USe C++ style includes for C header files

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Various fixes to make dnsdist and auth work on el-8

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Use gnu++20 instead of c++20, according to Habbie it makes porting to e.g. Suse and Haiku easier.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Fix two more cases of ambiguous operator calls

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Tidy

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Missing include

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Bump minimal c++ version to c++20

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Avoid two cases of too early instantation of a member of a vector of an incomplete class

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

c++20 does not allow implicit capture of this

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Avoid a few cases of warning: C++20 says that these are ambiguous, even though the second is reversed

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Remove commented out crude debug/log code.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Replace commented out logging code with #if 0 sections. NFCI

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Remove undocumented {new,dup}DNSPacket from Lua.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Prepare qthread() for its catch block to be able to access its locals. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Simplify Bind2Backend::handle. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

auth meson build: restore original binary names