Drop shell workaround in bwrap() and run_workspace_command()
Let's use --perms and --chmod to fix the permissions of /tmp, /var/tmp
and /dev/shm instead of our hacky shell workaround. Let's also drop
all usage of shlex.join() in run() since it doesn't really by us anything.
Daan De Meyer [Tue, 27 Jun 2023 11:40:43 +0000 (13:40 +0200)]
Gentoo fixes
- Use boot use flag for systemd instead of gnuefi
- Add --deep to emerge invocation to fix dep resolution failures
- Use curl to download stage3 tarball so we get a progress bar
- Do not exclude dev, proc and sys directories when extracting tarball
(only exclude their contents)
- Copy pkgmngr/ directory into stage3/ directory wholesale instead of
individual files
- Various coding style fixes
- Stop using Repositories= to specify binary package repositories as it
is not its intended purpose. Instead, pass configured environment
variables to emerge so users can set PORTAGE_BINHOST instead.
Daan De Meyer [Tue, 27 Jun 2023 14:04:58 +0000 (16:04 +0200)]
Use systemd-repart's new --offline argument
When building images, we never want to use loop devices, so use
--offline=yes in that case. When booting images, we know that
systemd-nspawn requires loop devices, so require them for
systemd-repart as well using --offline=no.
Paymon MARANDI [Tue, 20 Jun 2023 15:41:05 +0000 (11:41 -0400)]
gentoo: hardcode stage3 path
2 more things:
- bring back cache_clean so we extract stage3 once. that also means
configure pkgmngr once
- add ./proc to exclusion list during extraction
Paymon MARANDI [Thu, 25 May 2023 13:19:34 +0000 (09:19 -0400)]
gentoo: default to btrfs
Given that mkosi is *bespoken* and since it leverages features from
btrfs in some configurations we switch to btrfs by default.
Gentoo doesn't actually care one way or the other what the undelying fs
is and ext4, previous default, was in fact an arbitrarily choice (a
copy-pasted from some other distro's module).
Marius Schiffer [Fri, 16 Jun 2023 10:00:53 +0000 (10:00 +0000)]
Add support for ukify config at /etc/kernel/uki.conf.
This allows specifying further options, e.g. a splash image for the
generated UKI file, given to ukify.
Ukify is run from the same working directory as mkosi itself,
so given paths in the ukify config can be relative to this.
config: reword help message for --root-{password,shell}
"system root" doesn't seem right, because it sounds like we're talking about
the file system. We would often say just "root password", but that's nor
gramatically correct. "root's password" would be correct, but seems strange.
So let's rephase this to avoid the awkwardness.
@@ -85,6 +85,6 @@
- --bootable [FEATURE] Generate ESP partition with systemd-boot and UKIs for
- installed kernels
--kernel-command-line OPTIONS
Set the kernel command line (only bootable images)
+ --bootable [FEATURE] Generate ESP partition with systemd-boot and UKIs for
+ installed kernels
Daan De Meyer [Tue, 20 Jun 2023 15:40:49 +0000 (17:40 +0200)]
Add "none" output format
This is a re-implementation of the --skip-final-phase option, but
instead of doing it via an option, we do it via a new output format,
which feels much more natural. In combination with mounting the
staging directory into the build script, this allows using mkosi to
produce arbitrary artifacts using the build script.
Daan De Meyer [Tue, 20 Jun 2023 15:24:12 +0000 (17:24 +0200)]
Mount staging directory into build script
The build script might produce additional outputs, so let's allow
the user to funnel those out of the container by mounting the staging
directory and setting the OUTPUTDIR environment variable.
Daan De Meyer [Tue, 20 Jun 2023 14:07:49 +0000 (16:07 +0200)]
Remove --install-directory= option
We don't benefit from the caching anymore since we started emptying
the directory completely on reuse as otherwise old leftover files
might get installed. Without the caching, the option does not have
a ton of use anymore, so let's remove it.
Daan De Meyer [Wed, 14 Jun 2023 15:41:32 +0000 (17:41 +0200)]
Run systemd-repart before booting image with systemd-nspawn
To match the behavior when running in qemu, let's run systemd-repart
on the image before running it in systemd-nspawn to make sure that
all the necessary partitions are added if the image has repart
definition files included.
Daan De Meyer [Tue, 13 Jun 2023 13:45:11 +0000 (15:45 +0200)]
qemu: Use SOCK_STREAM for notify socket
The CentOS 8 Stream kernel does not support SOCK_SEQPACKET for
AF_VSOCK so let's use SOCK_STREAM instead and explicitly instruct
systemd running in the VM to use SOCK_STREAM as well.
Daan De Meyer [Mon, 12 Jun 2023 13:12:01 +0000 (15:12 +0200)]
Ensure we return the same exit code in debug mode
When running in debug mode, we shouldn't return a different exit
code compared to when we run outside of debug mode.
A trivial example is when running the boot or qemu verbs where we
exit with the exit code of the container/VM by raising an instance
of CalledProcessError. In --debug mode, this exception is handled
as an unhandled exception by the python runtime which always exits
with 1 when an unhandled exception is encountered, whereas outside
of debug mode we exit with the value contained in
CalledProcessError.returncode.
With this commit, we'll always exit with the return value in
CalledProcessError.returncode.
Daan De Meyer [Sun, 11 Jun 2023 19:55:06 +0000 (21:55 +0200)]
apt: Set "Dir" instead of "Dir::Etc" and set it via APT_CONFIG
We need to use APT_CONFIG to set "Dir" as otherwise the value of "Dir"
won't be taken into account by apt when looking for configuration files
as options set via the CLI are applied last after parsing the apt
configuration files.
Daan De Meyer [Sun, 11 Jun 2023 18:24:10 +0000 (20:24 +0200)]
dnf: Write repos to /etc/yum.repos.d/<distribution>.repo
Let's allow providing a config file for dnf without also overriding
all the default repositories by writing the default repositories to
a file in /etc/yum.repos.d/.
Daan De Meyer [Sun, 11 Jun 2023 18:10:53 +0000 (20:10 +0200)]
Do not overwrite package manager config files if they exist
Let's allow users to override mkosi's default package manager
settings by providing their own package manager config file. This
is especially important for distributions built using dnf as dnf
does not yet have support for dropins.
Daan De Meyer [Sun, 11 Jun 2023 18:03:30 +0000 (20:03 +0200)]
arch: Drop useless options from config
CheckSpace isn't really useful as we'll just fail a little later
while unpacking or installing packages. HoldPkg isn't useful either
as there's no chance of breaking the system by uninstalling packages
when we're just building an image.
Daan De Meyer [Thu, 8 Jun 2023 15:42:35 +0000 (17:42 +0200)]
Prefer configuration via CLI over configuration via config file
This makes it easier to debug things with --debug as all the options
used will be logged instead of having to go and figure out what's in
the config file.
Daan De Meyer [Wed, 7 Jun 2023 14:40:04 +0000 (16:40 +0200)]
Install dmsetup in the initrd on Debian/Ubuntu
On other distros, just installing systemd and udev is sufficient to
make verity work. On Debian and Ubuntu, we need to explicitly install
dmsetup as well to make sure verity works, so let's do that.
Daan De Meyer [Tue, 6 Jun 2023 09:59:55 +0000 (11:59 +0200)]
Make matches work more like systemd conditions
Let's make matches behave like systemd conditions. We drop support
for list matches. Instead, we add support for match negation and
trigger matches. A match is a trigger match if it's prefixed with
the pipe symbol (|). A match is satisfied if all its regular matches
and one of its trigger matches are satisfied.