]> git.ipfire.org Git - thirdparty/zstd.git/log
thirdparty/zstd.git
6 years agofix gitignore errors 1677/head
LeeYoung624 [Tue, 9 Jul 2019 10:00:17 +0000 (18:00 +0800)] 
fix gitignore errors

6 years agoMerge pull request #1671 from ephiepark/dev
Yann Collet [Thu, 4 Jul 2019 00:47:44 +0000 (17:47 -0700)] 
Merge pull request #1671 from ephiepark/dev

Adding targetCBlockSize param

6 years agoAdding targetCBlockSize param 1671/head
Ephraim Park [Mon, 24 Jun 2019 20:40:52 +0000 (13:40 -0700)] 
Adding targetCBlockSize param

6 years ago[fuzz] Add a compression fuzzer with randomly sized output buffer (#1670)
Nick Terrell [Wed, 3 Jul 2019 05:05:07 +0000 (22:05 -0700)] 
[fuzz] Add a compression fuzzer with randomly sized output buffer (#1670)

6 years agoZSTD_compressSequences_internal assert op <= oend (#1667)
Nick Terrell [Tue, 2 Jul 2019 22:45:47 +0000 (15:45 -0700)] 
ZSTD_compressSequences_internal assert op <= oend (#1667)

When we wrote one byte beyond the end of the buffer for RLE
blocks back in 1.3.7, we would then have `op > oend`. That is
a problem when we use `oend - op` for the size of the destination
buffer, and allows further writes beyond the end of the buffer for
the rest of the function. Lets assert that it doesn't happen.

6 years agoMerge pull request #1658 from facebook/memset
Yann Collet [Mon, 1 Jul 2019 22:01:43 +0000 (15:01 -0700)] 
Merge pull request #1658 from facebook/memset

memset() rather than reduceIndex()

6 years agoMerge pull request #1664 from ephiepark/dev
Yann Collet [Mon, 1 Jul 2019 21:13:49 +0000 (14:13 -0700)] 
Merge pull request #1664 from ephiepark/dev

decodecorpus

6 years agoMerge pull request #7 from ephiepark/decodecorpus 1664/head
Ephraim Park [Mon, 1 Jul 2019 17:18:59 +0000 (10:18 -0700)] 
Merge pull request #7 from ephiepark/decodecorpus

reflect code review comments

6 years agoreflect code review comments
Ephraim Park [Mon, 1 Jul 2019 17:17:30 +0000 (10:17 -0700)] 
reflect code review comments

6 years agoMerge pull request #1665 from lzutao/meson-deprecated-warnings
Yann Collet [Sun, 30 Jun 2019 18:36:35 +0000 (11:36 -0700)] 
Merge pull request #1665 from lzutao/meson-deprecated-warnings

meson: Fix deprecated build warnings on build options

6 years agomeson: Always build gen_html on build machine 1665/head
Lzu Tao [Fri, 28 Jun 2019 19:05:05 +0000 (02:05 +0700)] 
meson: Always build gen_html on build machine

Because we use gen_html as a generator instead of a binary to
run on host machine.

6 years agomeson: Fix deprecated build warnings on build options
Lzu Tao [Fri, 28 Jun 2019 18:59:57 +0000 (01:59 +0700)] 
meson: Fix deprecated build warnings on build options

Meson now reserves the `build_` prefix for options

6 years agomeson: Beautify travis config
Lzu Tao [Fri, 28 Jun 2019 18:42:17 +0000 (01:42 +0700)] 
meson: Beautify travis config

6 years agoMerge pull request #6 from ephiepark/decodecorpus
Ephraim Park [Fri, 28 Jun 2019 00:38:50 +0000 (17:38 -0700)] 
Merge pull request #6 from ephiepark/decodecorpus

Add test case for short bistream

6 years agoAdd test case for short bistream
Ephraim Park [Fri, 28 Jun 2019 00:27:29 +0000 (17:27 -0700)] 
Add test case for short bistream

6 years agoAdding shrinking flag for cover and fastcover (#1656)
Tyler-Tran [Thu, 27 Jun 2019 23:26:57 +0000 (16:26 -0700)] 
Adding shrinking flag for cover and fastcover (#1656)

* Changed ERROR(GENERIC) excluding inits

* editing git ignore

* Edited init functions to size_t returns

* moved declarations earlier

* resolved issues with changes to init functions

* fixed style and an error check

* attempting to add tests that might trigger changes

* added && die to cases expecting to fail

* resolved no die on expected failed command

* fixed accel to be incorrect value

* Adding an automated shrinking option

* Fixing build

* finalizing fixes

* fix?

* Removing added comment in cover.h

* Styling fixes

* Merging with fb dev

* removing megic number for default regression

* Requested revisions

* fixing support for fast cover

* fixing casting errors

* parenthesis fix

* fixing some build nits

* resolving travis ci syntax

* might resolve all compilation issues

* removed unused variable

* remodeling the selectDict function

* fixing bad memory access

* fixing error checks

* fixed erroring check in selectDict

* fixing mixed declarations

* modify mixed declaration

* fixing nits and adding test cases

* Adding requested changes + fixed bug for error checking

* switched double comparison from != to <

* fixed declaration typing

* refactoring COVER_best_finish() and changing shrinkDict

* removing the const's

* modifying ZDICT_optimizeTrainFromBuffer_cover functions

* fixing potential bad memcpy

* fixing the error function for dict size

6 years agoMerge pull request #5 from ephiepark/decodecorpus
Ephraim Park [Thu, 27 Jun 2019 22:02:48 +0000 (15:02 -0700)] 
Merge pull request #5 from ephiepark/decodecorpus

Decodecorpus

6 years agoFix a constraint stricter than the spec 1663/head
Ephraim Park [Wed, 26 Jun 2019 23:43:37 +0000 (16:43 -0700)] 
Fix a constraint stricter than the spec

6 years agoenable repeat mode on rle
Ephraim Park [Wed, 26 Jun 2019 23:39:00 +0000 (16:39 -0700)] 
enable repeat mode on rle

6 years agochanged naming to ZSTD_indexTooCloseToMax() 1658/head
Yann Collet [Mon, 24 Jun 2019 21:39:29 +0000 (14:39 -0700)] 
changed naming to ZSTD_indexTooCloseToMax()

Also : minor speed optimization :
shortcut to ZSTD_reset_matchState() rather than the full reset process.
It still needs to be completed with ZSTD_continueCCtx() for proper initialization.

Also : changed position of LDM hash tables in the context,
so that the "regular" hash tables can be at a predictable position,
hence allowing the shortcut to ZSTD_reset_matchState() without complex conditions.

6 years agoMerge pull request #1659 from terrelln/big-dict
Nick Terrell [Mon, 24 Jun 2019 19:40:58 +0000 (12:40 -0700)] 
Merge pull request #1659 from terrelln/big-dict

Fix data corruption in niche use case

6 years ago[tests] Add tests for big dictionaries 1659/head
Nick Terrell [Sat, 22 Jun 2019 00:35:43 +0000 (17:35 -0700)] 
[tests] Add tests for big dictionaries

6 years agoprefer memset() rather than reduceIndex() when close to index range limit
Yann Collet [Fri, 21 Jun 2019 23:19:21 +0000 (16:19 -0700)] 
prefer memset() rather than reduceIndex() when close to index range limit

by disabling continue mode when index is close to limit.

6 years agobenchfn : added macro macro CONTROL()
Yann Collet [Fri, 21 Jun 2019 22:58:55 +0000 (15:58 -0700)] 
benchfn : added macro macro CONTROL()

like assert() but cannot be disabled.
proper separation of user contract errors (CONTROL())
and invariant verification (assert()).

6 years ago[zstd] Fix data corruption in niche use case
Nick Terrell [Fri, 21 Jun 2019 22:39:43 +0000 (15:39 -0700)] 
[zstd] Fix data corruption in niche use case

* Extract the overflow correction into a helper function.
* Load the dictionary `ZSTD_CHUNKSIZE_MAX = 512 MB` bytes at a time
  and overflow correct between each chunk.

Data corruption could happen when all these conditions are true:

* You are using multithreading mode
* Your overlap size is >= 512 MB (implies window size >= 512 MB)
* You are using a strategy >= ZSTD_btlazy
* You are compressing more than 4 GB

The problem is that when loading a large dictionary we don't do
overflow correction. We can only load 512 MB at a time, and may
need to do overflow correction before each chunk.

6 years ago[zstdmt] Update assert to use ZSTD_WINDOWLOG_MAX
Nick Terrell [Fri, 21 Jun 2019 22:39:33 +0000 (15:39 -0700)] 
[zstdmt] Update assert to use ZSTD_WINDOWLOG_MAX

6 years ago[opt] Add asserts for corruption in ZSTD_updateTree()
Nick Terrell [Fri, 21 Jun 2019 22:22:29 +0000 (15:22 -0700)] 
[opt] Add asserts for corruption in ZSTD_updateTree()

6 years agoMerge pull request #1626 from LeeYoung624/dev
Yann Collet [Wed, 19 Jun 2019 20:35:33 +0000 (13:35 -0700)] 
Merge pull request #1626 from LeeYoung624/dev

add cmake lz4 support

6 years agoMerge pull request #1655 from terrelln/regression-test
Nick Terrell [Mon, 17 Jun 2019 18:57:41 +0000 (11:57 -0700)] 
Merge pull request #1655 from terrelln/regression-test

[regression] Update results for small wlog patch PR#1624

6 years ago[regression] Update results for small wlog patch PR#1624 1655/head
Nick Terrell [Mon, 17 Jun 2019 17:40:33 +0000 (10:40 -0700)] 
[regression] Update results for small wlog patch PR#1624

6 years agoMerge pull request #1647 from LeeYoung624/cmake_bug_fix
Yann Collet [Sat, 15 Jun 2019 00:32:05 +0000 (17:32 -0700)] 
Merge pull request #1647 from LeeYoung624/cmake_bug_fix

CMake bug fix: didn't install zstdless and zstdgrep.

6 years agoMerge pull request #1640 from felixhandte/lstat-macro-guard
Yann Collet [Sat, 15 Jun 2019 00:30:03 +0000 (17:30 -0700)] 
Merge pull request #1640 from felixhandte/lstat-macro-guard

Protect lstat() With Better Macro Guard

6 years agoMerge pull request #1624 from facebook/smallwlog
Yann Collet [Sat, 15 Jun 2019 00:28:21 +0000 (17:28 -0700)] 
Merge pull request #1624 from facebook/smallwlog

Improves compression ratio for small windowLog

6 years agoMerge pull request #1650 from scharan/RemoveExportsForStaticLibrary
Yann Collet [Sat, 15 Jun 2019 00:09:00 +0000 (17:09 -0700)] 
Merge pull request #1650 from scharan/RemoveExportsForStaticLibrary

Remove ZSTD_DLL_EXPORT=1 for static lib

6 years agoMerge pull request #1644 from chungy/chmod_600
Yann Collet [Fri, 14 Jun 2019 00:25:31 +0000 (17:25 -0700)] 
Merge pull request #1644 from chungy/chmod_600

[programs] set chmod 600 after opening destination file

6 years agoRemove ZSTD_DLL_EXPORT=1 for static lib 1650/head
Sai Charan Koduru [Wed, 12 Jun 2019 19:26:36 +0000 (12:26 -0700)] 
Remove ZSTD_DLL_EXPORT=1 for static lib

As a principle, static libs should not dllexport methods, that should only be used when building DLLs.

Case in point: when static libs with dllexport directives are linked into DLLs created with a .def file, the VC++ compiler exports the dllexported methods into the DLL, in addition to the exports listed in the .def file. This will result in undesired link dependencies and is not the correct thing to do.

6 years agoInstall zstdless & zstdgrep as 'PROGRAMS' in CMake 1647/head
LeeYoung624 [Tue, 11 Jun 2019 03:29:18 +0000 (11:29 +0800)] 
Install zstdless & zstdgrep as 'PROGRAMS' in CMake

6 years agoMerge pull request #1620 from michaelforney/test-no-threads
Felix Handte [Tue, 11 Jun 2019 19:05:25 +0000 (15:05 -0400)] 
Merge pull request #1620 from michaelforney/test-no-threads

Skip --adapt and --rsyncable tests when built without thread support

6 years agoMerge pull request #1646 from terrelln/oss-fuzz
Nick Terrell [Tue, 11 Jun 2019 05:13:16 +0000 (22:13 -0700)] 
Merge pull request #1646 from terrelln/oss-fuzz

[fuzz] Remove max_len from the options

6 years agoMerge pull request #4 from facebook/dev 1626/head
Lee [Tue, 11 Jun 2019 03:25:26 +0000 (11:25 +0800)] 
Merge pull request #4 from facebook/dev

merge

6 years agoMerge pull request #1619 from j301scott/dev
Yann Collet [Mon, 10 Jun 2019 18:56:49 +0000 (11:56 -0700)] 
Merge pull request #1619 from j301scott/dev

CMake: Check for existing custom target 'uninstall'

6 years ago[fuzz] Remove max_len from the options 1646/head
Nick Terrell [Mon, 10 Jun 2019 18:05:45 +0000 (11:05 -0700)] 
[fuzz] Remove max_len from the options

6 years agoAdd Contbuild Test for C99 Build 1640/head
W. Felix Handte [Mon, 10 Jun 2019 15:21:28 +0000 (11:21 -0400)] 
Add Contbuild Test for C99 Build

6 years agoMerge pull request #1642 from Absotively/dev
Felix Handte [Mon, 10 Jun 2019 14:39:25 +0000 (10:39 -0400)] 
Merge pull request #1642 from Absotively/dev

VS2010 project settings improvements

6 years ago[programs] Don’t try to chmod a dst file if it can’t be opened 1644/head
Mike Swanson [Sun, 9 Jun 2019 08:52:45 +0000 (01:52 -0700)] 
[programs] Don’t try to chmod a dst file if it can’t be opened

Repairs an oversight in my last commit, thanks @Cyan4973

6 years ago[programs] set chmod 600 after opening destination file
Mike Swanson [Sun, 9 Jun 2019 04:54:02 +0000 (21:54 -0700)] 
[programs] set chmod 600 after opening destination file

This resolves a race condition where zstd or unzstd may expose read
permissions beyond the original file allowed.  Mode 600 is used
temporarily during the compression and decompression write stage
and the new file inherits the original file’s mode at the end.

Fixes #1630

6 years agoIn VS2010+, turn off assembler output for libzstd & libzstd-dll, and don't export... 1642/head
Jen Pollock [Fri, 7 Jun 2019 23:21:51 +0000 (17:21 -0600)] 
In VS2010+, turn off assembler output for libzstd & libzstd-dll, and don't export functions from libzstd

6 years agoSwitch Macro Guarding lstat()
W. Felix Handte [Fri, 7 Jun 2019 19:31:33 +0000 (15:31 -0400)] 
Switch Macro Guarding lstat()

6 years agoClean Up Temp Files Produced By playTests.sh
W. Felix Handte [Fri, 7 Jun 2019 19:30:30 +0000 (15:30 -0400)] 
Clean Up Temp Files Produced By playTests.sh

6 years agoMerge pull request #1635 from terrelln/opt-opt
Nick Terrell [Thu, 6 Jun 2019 20:15:23 +0000 (13:15 -0700)] 
Merge pull request #1635 from terrelln/opt-opt

[libzstd] Optimize ZSTD_insertBt1() for repetitive data

6 years ago[regression] Update results.csv 1635/head
Nick Terrell [Thu, 6 Jun 2019 03:40:52 +0000 (20:40 -0700)] 
[regression] Update results.csv

6 years ago[libzstd] Optimize ZSTD_insertBt1() for repetitive data
Nick Terrell [Thu, 6 Jun 2019 03:20:55 +0000 (20:20 -0700)] 
[libzstd] Optimize ZSTD_insertBt1() for repetitive data

We would only skip at most 192 bytes at a time before this diff.
This was added to optimize long matches and skip the middle of the
match. However, it doesn't handle the case of repetitive data.

This patch keeps the optimization, but also handles repetitive data
by taking the max of the two return values.

```
> for n in $(seq 9); do echo strategy=$n; dd status=none if=/dev/zero bs=1024k count=1000 | command time -f %U ./zstd --zstd=strategy=$n >/dev/null; done
strategy=1
0.27
strategy=2
0.23
strategy=3
0.27
strategy=4
0.43
strategy=5
0.56
strategy=6
0.43
strategy=7
0.34
strategy=8
0.34
strategy=9
0.35
```

At level 19 with multithreading the compressed size of `silesia.tar` regresses 300 bytes, and `enwik8` regresses 100 bytes.
In single threaded mode `enwik8` is also within 100 bytes, and I didn't test `silesia.tar`.

Fixes Issue #1634.

6 years agoMerge pull request #1632 from ephiepark/dev
Yann Collet [Wed, 5 Jun 2019 19:30:21 +0000 (12:30 -0700)] 
Merge pull request #1632 from ephiepark/dev

CircleCI : use custom Docker Image with pre-installed dependencies

6 years agoMerge pull request #1633 from yk-tanigawa/patch-1
Felix Handte [Wed, 5 Jun 2019 18:55:19 +0000 (14:55 -0400)] 
Merge pull request #1633 from yk-tanigawa/patch-1

Update README.md

6 years agoUpdate README.md 1633/head
Yosuke Tanigawa [Wed, 5 Jun 2019 16:11:21 +0000 (09:11 -0700)] 
Update README.md

Fix minor typo in the documentation.

6 years agoMerge branch 'dev' of https://github.com/ephiepark/zstd into dev 1632/head
Ephraim Park [Wed, 5 Jun 2019 04:14:20 +0000 (21:14 -0700)] 
Merge branch 'dev' of https://github.com/ephiepark/zstd into dev

6 years agocircleci : remove install dependencies command from config.yml
Ephraim Park [Tue, 4 Jun 2019 19:18:33 +0000 (12:18 -0700)] 
circleci : remove install dependencies command from config.yml

6 years agocircleci : use custom docker image with installations
Ephraim Park [Tue, 4 Jun 2019 18:04:51 +0000 (11:04 -0700)] 
circleci : use custom docker image with installations

6 years agoMerge pull request #2 from ephiepark/circleci
Ephraim Park [Wed, 5 Jun 2019 03:53:29 +0000 (20:53 -0700)] 
Merge pull request #2 from ephiepark/circleci

CircleCI : use custom Docker Image with pre-installed dependencies

6 years agoMerge pull request #1631 from ephiepark/dev
Yann Collet [Tue, 4 Jun 2019 22:14:35 +0000 (15:14 -0700)] 
Merge pull request #1631 from ephiepark/dev

zstdcli : expose cpu load indicator for each file on -vv mode

6 years agoMerge pull request #1629 from facebook/streamSize
Yann Collet [Tue, 4 Jun 2019 19:38:43 +0000 (12:38 -0700)] 
Merge pull request #1629 from facebook/streamSize

Added comments on I/O buffer sizes for streaming

6 years agocircleci : remove install dependencies command from config.yml
Ephraim Park [Tue, 4 Jun 2019 19:18:33 +0000 (12:18 -0700)] 
circleci : remove install dependencies command from config.yml

6 years agocircleci : use custom docker image with installations
Ephraim Park [Tue, 4 Jun 2019 18:04:51 +0000 (11:04 -0700)] 
circleci : use custom docker image with installations

6 years agobetter title formatting for html documentation 1629/head
Yann Collet [Tue, 4 Jun 2019 17:35:40 +0000 (10:35 -0700)] 
better title formatting for html documentation

must pay attention to /** and /*! patterns.

6 years agoAdded comments on I/O buffer sizes for streaming
Yann Collet [Tue, 4 Jun 2019 17:26:16 +0000 (10:26 -0700)] 
Added comments on I/O buffer sizes for streaming

It seems this is still a confusing topic,
as in https://github.com/klauspost/compress/issues/109 .

6 years agozstdcli : align output message with previous message 1631/head
Ephraim Park [Tue, 4 Jun 2019 16:42:18 +0000 (09:42 -0700)] 
zstdcli : align output message with previous message

6 years agozstdcli : remove extra semicolon
Ephraim Park [Tue, 4 Jun 2019 16:25:16 +0000 (09:25 -0700)] 
zstdcli : remove extra semicolon

6 years agozstdcli : trying to fix declaration after statement
Ephraim Park [Tue, 4 Jun 2019 16:23:49 +0000 (09:23 -0700)] 
zstdcli : trying to fix declaration after statement

6 years agozstdcli : moving cpu load calculation from FIO_compressFilename_dstFile to FIO_compre...
Ephraim Park [Tue, 4 Jun 2019 16:04:35 +0000 (09:04 -0700)] 
zstdcli : moving cpu load calculation from FIO_compressFilename_dstFile to FIO_compressFilename_internal

6 years agozstdcli : fixing mixed declarations and code error
Ephraim Park [Tue, 4 Jun 2019 00:36:09 +0000 (17:36 -0700)] 
zstdcli : fixing mixed declarations and code error

6 years agozstdcli : moving start time and cpu initialization after potential prompt
Ephraim Park [Tue, 4 Jun 2019 00:31:14 +0000 (17:31 -0700)] 
zstdcli : moving start time and cpu initialization after potential prompt

6 years agozstdcli : exposing cpu load indicator for each file on -vv mode
Ephraim Park [Mon, 3 Jun 2019 21:38:40 +0000 (14:38 -0700)] 
zstdcli : exposing cpu load indicator for each file on -vv mode

6 years agoadd cmake lz4 support
l00292966 [Mon, 3 Jun 2019 10:19:59 +0000 (18:19 +0800)] 
add cmake lz4 support
add some instructions for build/cmake/README.md

6 years agoremoved UINT32_MAX 1624/head
Yann Collet [Sat, 1 Jun 2019 00:27:07 +0000 (17:27 -0700)] 
removed UINT32_MAX

apparently not guaranteed on all platforms,
replaced by UINT_MAX.

6 years agofixed wrong assert in double_fast
Yann Collet [Sat, 1 Jun 2019 00:06:28 +0000 (17:06 -0700)] 
fixed wrong assert in double_fast

6 years agominor code cleaning for new index invalidation strategy
Yann Collet [Fri, 31 May 2019 23:52:37 +0000 (16:52 -0700)] 
minor code cleaning for new index invalidation strategy

6 years agomake double_fast compatible with new index invalidation strategy
Yann Collet [Fri, 31 May 2019 23:50:04 +0000 (16:50 -0700)] 
make double_fast compatible with new index invalidation strategy

6 years agoMade fast strategy compatible with new offset validation strategy
Yann Collet [Fri, 31 May 2019 23:34:55 +0000 (16:34 -0700)] 
Made fast strategy compatible with new offset validation strategy

fast mode does the same thing as before :
it pre-emptively invalidates any index that could lead to offset > maxDistance.
It's supposed to help speed.

But this logic is performed inside zstd_fast,
so that other strategies can select a different behavior.

6 years agoextended exact window size to greedy/lazy modes
Yann Collet [Fri, 31 May 2019 23:08:48 +0000 (16:08 -0700)] 
extended exact window size to greedy/lazy modes

6 years agofirst implementation of small window size for btopt
Yann Collet [Fri, 31 May 2019 22:55:12 +0000 (15:55 -0700)] 
first implementation of small window size for btopt

noticeably improves compression ratio
when window size is small (< 18).

enwik7 level 19

windowLog `dev` `smallwlog` improvement
23 3.577 3.577 0.02%
22 3.536 3.538 0.06%
21 3.462 3.467 0.14%
20 3.364 3.377 0.39%
19 3.244 3.272 0.86%
18 3.110 3.166 1.80%
17 2.843 3.057 7.53%
16 2.724 2.943 8.04%
15 2.594 2.822 8.79%
14 2.456 2.686 9.36%
13 2.312 2.523 9.13%
12 2.162 2.361 9.20%
11 2.003 2.182 8.94%

6 years agoMerge pull request #1623 from facebook/fullbench
Yann Collet [Fri, 31 May 2019 21:40:19 +0000 (14:40 -0700)] 
Merge pull request #1623 from facebook/fullbench

fullbench minor improvements

6 years agoconsistency : changed constant name to kSampleSizeDefault 1623/head
Yann Collet [Thu, 30 May 2019 17:13:56 +0000 (10:13 -0700)] 
consistency : changed constant name to kSampleSizeDefault

as suggested by @terrelln.

added <assert.h> include

6 years agodefine CONTROL, to ensure check cannot be disabled
Yann Collet [Wed, 29 May 2019 23:18:22 +0000 (16:18 -0700)] 
define CONTROL, to ensure check cannot be disabled

assert() can be disabled with NDEBUG

6 years agofullbench : minor refactoring, for readability
Yann Collet [Wed, 29 May 2019 23:08:49 +0000 (16:08 -0700)] 
fullbench : minor refactoring, for readability

6 years agofullbench: pass proper parameters in scenario 43
Yann Collet [Wed, 29 May 2019 22:26:06 +0000 (15:26 -0700)] 
fullbench: pass proper parameters in scenario 43

6 years agoMerge pull request #1622 from facebook/nextToUpdate3
Yann Collet [Wed, 29 May 2019 01:26:21 +0000 (18:26 -0700)] 
Merge pull request #1622 from facebook/nextToUpdate3

nextToUpdate3 does not need to be maintained outside of zstd_opt.c

6 years agofullbench 43: ensure context is freed after each usage
Yann Collet [Wed, 29 May 2019 00:27:52 +0000 (17:27 -0700)] 
fullbench 43: ensure context is freed after each usage

6 years agofullbench: added streaming with fresh CCtx scenario
Yann Collet [Tue, 28 May 2019 23:50:49 +0000 (16:50 -0700)] 
fullbench: added streaming with fresh CCtx scenario

worst case situation, where context must be recreated every time
but without knowledge of the input size
thus sizing the context for some large input.

6 years agofullbench can now select sample size with command `-B#`
Yann Collet [Tue, 28 May 2019 23:37:03 +0000 (16:37 -0700)] 
fullbench can now select sample size with command `-B#`

6 years agoremoved nextToUpdate3 from ZSTD_window 1622/head
Yann Collet [Tue, 28 May 2019 23:18:12 +0000 (16:18 -0700)] 
removed nextToUpdate3 from ZSTD_window

it's now a local variable of ZSTD_compressBlock_opt()

6 years agoget bt matches : made it a bit clearer which parameters are input and output
Yann Collet [Tue, 28 May 2019 23:11:32 +0000 (16:11 -0700)] 
get bt matches : made it a bit clearer which parameters are input and output

6 years agonextToUpdate3 does not need to be maintained outside of zstd_opt.c
Yann Collet [Tue, 28 May 2019 22:26:52 +0000 (15:26 -0700)] 
nextToUpdate3 does not need to be maintained outside of zstd_opt.c

It's re-synchronized with nextToUpdate at beginning of each block.
It only needs to be tracked from within zstd_opt block parser.

Made the logic clear, so that no code tried to maintain this variable.

An even better solution would be to make nextToUpdate3
an internal variable of ZSTD_compressBlock_opt_generic().
That would make it possible to remove it from ZSTD_matchState_t,
thus restricting its visibility to only where it's actually useful.

This would require deeper changes though,
since the matchState is the natural structure to transport parameters into and inside the parser.

6 years agocomplementary code comments
Yann Collet [Tue, 28 May 2019 21:12:16 +0000 (14:12 -0700)] 
complementary code comments

on variables used / impacted during maxDist check

6 years agoadded comments to better understand enforceMaxDist()
Yann Collet [Tue, 28 May 2019 20:15:48 +0000 (13:15 -0700)] 
added comments to better understand enforceMaxDist()

6 years agoSkip --adapt and --rsyncable tests when built without thread support 1620/head
Michael Forney [Sun, 26 May 2019 10:18:39 +0000 (03:18 -0700)] 
Skip --adapt and --rsyncable tests when built without thread support

These options require ZSTD_MULTITHREAD.

6 years agoCMake: Check for existing custom target 'uninstall' 1619/head
Jonathan Scott [Sun, 26 May 2019 00:29:04 +0000 (17:29 -0700)] 
CMake: Check for existing custom target 'uninstall'

6 years agoMerge pull request #1618 from felixhandte/zstgrep-f-flag
Felix Handte [Sat, 25 May 2019 00:59:11 +0000 (20:59 -0400)] 
Merge pull request #1618 from felixhandte/zstgrep-f-flag

Handle `-f` Flag in `zstgrep`

6 years agoAdd Test 1618/head
W. Felix Handte [Fri, 24 May 2019 21:21:44 +0000 (17:21 -0400)] 
Add Test

6 years agozstdgrep: Handle -f Flag
W. Felix Handte [Fri, 24 May 2019 20:55:59 +0000 (16:55 -0400)] 
zstdgrep: Handle -f Flag

6 years agoBuild Manual
W. Felix Handte [Fri, 24 May 2019 20:55:43 +0000 (16:55 -0400)] 
Build Manual