storage: handle overlay for stable 2.0

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all dir paths"

This reverts commit 276fb978ee319c690e6c9ce9df16fb7a21953d2d.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add lxc_storage_get_path()"

This reverts commit ef72d7d681c49c008bf9da2522c7ef436cf78f46.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all btrfs paths"

This reverts commit f405c0c5cadbadf5b0beb42a346ca52f593777d3.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all lvm paths"

This reverts commit 6be74c07d0328f0d7b053524626bc83ae2b2276f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: check whether lxc.bdev.lvm.vg is set"

This reverts commit 0790b49260cbb48833367f3357b067fb851419cc.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: fix check"

This reverts commit 63539ebf3425fa62bbcfda60e7ea1bc7dedef9ef.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all nbd paths"

This reverts commit bdca6500054d3df9f704bcc5fe5d66f3837cce1b.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all rbd paths"

This reverts commit 2e0e18cca610359ae132452bc3b190f3d0335688.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all zfs paths"

This reverts commit aa7802e1095d19388b7b406c03e91a73d53a0b42.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: handle prefixed rootfs paths"

This reverts commit 84ae4b69653268029206317aabd5aaefa1f6a590.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify + bugfix"

This reverts commit 874a329ca6fd92057a3d243bfa6200906051393a.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: non-functional changes"

This reverts commit 7a8d7de2476b61005d80503ab8c816809bbc2d89.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "overlay: simplify and adapt to "overlay""

This reverts commit 7f79cc4c3457459dc20c4e40398395c5150618a9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "tools: remove empty snap directory"

This reverts commit d51915386e22a19da131a578330ab1115905c326.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: non-functional changes"

This reverts commit fb49a3cbebd4cf6433517f8550528ecf2a8aceb9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: export btrfs_snapshot_wrapper()"

This reverts commit 707f3fff59abe5db1033b4676e0063b35cfedd7b.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: enable unprivileged snapshots"

This reverts commit 2d66f57109b542b7a7a4882db74658374d2b5745.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: non-functional changes"

This reverts commit 8e295bc1a95441ddcf5290153322b8ca78971d8f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: only chown_mapped_root() if not btrfs"

This reverts commit d848b631492434985ffc5de9bbd7c631101077cb.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify"

This reverts commit 1aa0201f1446f1387c649467d86e923c9e9ecccf.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify"

This reverts commit 36c55bf31c67d5048b6dd7f85ac425f3b2e22fd3.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add create_{clone,snapshot}()"

This reverts commit 667fa8cef1afc88bbe20c04523521556cb2946ac.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: switch to btrfs_create_{clone,snapshot}()"

This reverts commit 618b655b4ed187b4853841813f9831b85987339a.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add arg to create_snapshot()"

This reverts commit a3e85dae4e02ad9d3b8fcf6bf301907ef55a7c01.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: rework lvm backend"

This reverts commit 9a534c222664cb3b2705fcf523d67de8522011d1.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "dir: non-functional changes"

This reverts commit 8f2896da31e7822eb7894a5ade9e11652fe75f7f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "dir: improvements"

This reverts commit 23eb8575d414d8b448398e9ed45d83741296a1ca.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "bdev: non-functional changes"

This reverts commit 8608cb0bd3b4ecd8bdf57a397b43ee9f344b8870.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "rsync: add new rsync functions"

This reverts commit 2ea2f3c8a6509cddbeebab92a0d3c56d4bf48be9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: switch to new rsync functions"

This reverts commit a493a694166e65edbf412433a605042cc0ac3d0e.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: switch to new rsync helpers"

This reverts commit d8bb582ae3ffd1864f20bd0a9548b2a06ded66c0.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "loop: rework loop storage driver"

This reverts commit 85914b6775afbf5598ea0cf8e342237f1da7c6d4.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "rbd: rbd non-functional changes"

This reverts commit 162a857a5811ff343146401cf6dde482158ae665.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "rbd: rework rbd storage driver"

This reverts commit 93b8f59a889d72b863c9fd225ebe3694feb6a0d1.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rbd: rework rbd storage driver

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rbd: rbd non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

loop: rework loop storage driver

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: switch to new rsync helpers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: switch to new rsync functions

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rsync: add new rsync functions

We will fade out the old helpers soon.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

bdev: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

dir: improvements

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

dir: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: rework lvm backend

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: add arg to create_snapshot()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: switch to btrfs_create_{clone,snapshot}()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: add create_{clone,snapshot}()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: simplify

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: simplify

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: only chown_mapped_root() if not btrfs

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: enable unprivileged snapshots

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: export btrfs_snapshot_wrapper()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: remove empty snap directory

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

overlay: simplify and adapt to "overlay"

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lvm: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

btrfs: simplify + bugfix

Closes #1698.
Closes #1703.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: use snprintf()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: default to orig type on identical paths

otherwise default to "dir"

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Use "rsync -SHaAX" to copy the cached rootfs into place

(updated by Serge to also handle hte new lxc-fedora{-legacy{.in
templates)

Signed-off-by: Harald Dunkel <harri@afaics.de>
Signed-off-by: Serge Hallyn <serge@hallyn.com>
Acked-by: Serge Hallyn <serge@hallyn.com>

lvm: fix check

Signed-off-by: Thomas Hipp <thipp@suse.de>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: use tight scoping

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lvm: check whether lxc.bdev.lvm.vg is set

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgroups: handle hybrid cgroup layouts

Closes #1669.
Closes #1678.
Relates to https://github.com/systemd/systemd/issues/6408.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: move helpers from cgfsng.c to utils.{c,h}

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: lxc_setup() after unshare(CLONE_NEWCGROUP)

When the running kernel supports cgroup namespaces and users want to manually
set up cgroups via lxc.hook.mount before the init binary starts the cgroup
namespace needs to be already unshared. Otherwise the view on the cgroup mounts
is wrong. This commit places the call to lxc_setup() after the
LXC_SYNC_POST_CGROUP barrier.

Before this commit, the tty fds we allocate from a fresh devpts instance in the
container's namespaces before the init binary starts were referring to the
host's cgroup namespace since lxc_setup() was called before
unshare(CLONE_NEWCGROUP). Although not a security risk at this point since
setns() restricts its calls to /proc/<self>/ns files it's still better to do it
*after* the cgroup namespace has been unshared.

Adding a Suggested-by line for the lxc.mount.hook fix for Quentin.

Closes #1597.

Suggested-by: Quentin Dufour <quentin@dufour.tk>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

 Using 'add-required_remount_flags' function to add required flags

Signed-off-by: Li Feng <lifeng68@huawei.com>

Add test script to test the ro option of lxc.rootfs.options

Signed-off-by: Li Feng <lifeng68@huawei.com>

Fix issue #1702, do remount with the MS_REMOUNT flag when mounts with MS_RDONLY

Signed-off-by: Li Feng <lifeng68@huawei.com>

Fix syntax error in lxc-download

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Sanitize lxc-download script with shellcheck

Fix potential CVE when using spaces in LXC names

Signed-off-by: William Gathoye <william@gathoye.be>

tests: remove the temp container directory

c->destory() will not remove the temp container directory.
This patch fix that.

Signed-off-by: Long Wang <w@laoqinren.net>

fix some cppcheck warnings

use cppcheck tools `cppcheck --enable=warning  .` on lxc source directory.

This patch fix the following warnning

```
[src/lxc/cgroups/cgfs.c:794]: (warning) %ld in format string (no. 3) requires 'long' but the argument type is 'unsigned long'.
[src/lxc/confile.c:4441]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lxc/confile.c:4502]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lxc/confile_legacy.c:921]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lxc/confile_legacy.c:938]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'.
[src/lxc/lxclock.c:63]: (warning) %zd in format string (no. 1) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'.
[src/lxc/tools/lxc_info.c:118]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_info.c:118]: (warning) %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_info.c:123]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_info.c:127]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_info.c:130]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_top.c:212]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_top.c:212]: (warning) %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_top.c:217]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_top.c:221]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
[src/lxc/tools/lxc_top.c:224]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
```

Signed-off-by: Long Wang <w@laoqinren.net>

storage: handle prefixed rootfs paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all zfs paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all rbd paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all nbd paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all lvm paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all btrfs paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: prefix all dir paths

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: add lxc_storage_get_path()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: add storage_utils.{c.h}

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

testcase: define a network before checks

Signed-off-by: 0x0916 <w@laoqinren.net>

confile: free netdev->downscript

Signed-off-by: 0x0916 <w@laoqinren.net>

cgroups: workaround gcc-7 bug

Also: LOL

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

doc: Untabify Japanese lxc.container.conf(5)

Tab and white space is mixed in Japanese lxc.container.conf(5), so
unify into the white space.

Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>

Merge pull request #1707 from brauner/2017-07-17/additional_stable_cherry_picks

stable-2.0: bugfixes

confile: clear vlan id

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: clear macvlan mode

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: clear network flags

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: clear ipv{4,6} gateway

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgfsng: only output debug info when we set cgroup data

Only output debug info `cgroup 'xxxx' set to 'yyyy'` when we set
cgroup data.

Signed-off-by: Long Wang <w@laoqinren.net>

utils: set_stdfds()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

start: dup std{in,out,err} to pty slave

In the case the container has a console with a valid slave pty file descriptor
we duplicate std{in,out,err} to the slave file descriptor so console logging
works correctly. When the container does not have a valid slave pty file
descriptor for its console and is started daemonized we should dup to
/dev/null.

Closes #1646.

Signed-off-by: Li Feng <lifeng68@huawei.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: use access instead of stat

we shoud test whether the file exists and grants
execute permissions.

Signed-off-by: Long Wang <w@laoqinren.net>

commonds: fix typo

Signed-off-by: Long Wang <w@laoqinren.net>

commands: delete meaningless comments

Signed-off-by: Long Wang <w@laoqinren.net>

commands: handle EINTR

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>