network: non-functional changes

This moves all of the network handling code into network.{c,h}. This makes what
is going on much clearer. Also it's easier to find relevant code if it is all
in one place.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: increase lxc-user-nic buffer

This will allow us log more detailed failures.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: check db before trying to delete

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: delete ovs for unprivileged networks

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: log ifindex

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: send ifindex for unpriv networks

We use the ifindex as an indicator that liblxc created the network so let's
record it for the unprivileged case as well.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: rework renaming net devices

This should make things a little less convoluted.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: adapt to lxc-user-nic usage

- lxc-user-nic gains the subcommands {create,delete}
- dup2() STDERR_FILENO as well so that we can show helpful messages in our logs
  on failure
- initialize output buffer so that we don't print garbage

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tests: adapt lxc-user-nic tests to new syntax

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: add new {create,delete} subcommands

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: fix memleak

get_new_nicname() calls lxc_mkifname() which allocates memory and returns it to
the caller. The way get_new_nicname() and get_nic_if_avail() were implemented
they hid that fact by returning a boolean. That doesn't make sense. Let's
rather have them return a pointer to the allocated nic name which the caller
needs to free.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxc-user-nic: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

cgfsng: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: do not deref null pointer

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

attach: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: do not check union on wrong net type

This will obviously not work.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: refactor network deletion

I'm ashamed at how aweful my previous code was.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

openvswitch: delete ports intelligently

So far, when creating veth devices attached to openvswitch bridges we used to
fork() off a thread on container startup. This thread was kept around until the
container shut down. I have no good explanation why we did it that why but it's
certainly not necessary. Instead, let's fork() off the thread on container
shutdown to delete the veth.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

templates/ubuntu: conditionally move upstart ssh job, as it is now optional.

Mimic the code from the debian template.

Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>

arguments: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

af_unix: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

rtnl: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: log lxc-user-nic output

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

network: log cleanup thread pid for openswitch

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Use deb.debian.org as the default Debian mirror

The httpredir.debian.org service has been discontinued in favour of
deb.debian.org and httpredir.debian.org now redirects to deb.debian.org.

https://lists.debian.org/debian-mirrors/2017/02/msg00000.html
https://wiki.debian.org/DebianGeoMirror#httpredir.debian.org_.2F_http.debian.net

Cf. https://bugs.debian.org/872719

Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>

cgroups: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: non-functional fixup

Surfaced while building lxc-2.0.8 on e2k architecture with lcc,
looks like its -Wall is more pedantic than gcc's:

lcc: "conf.c", line 1514: error: unrecognized character escape sequence
          [-Werror]
        DEBUG("created directory for console and tty devices at \%s\"", path);
                                                                ^
 in expansion of macro "DEBUG" at line 1514

Another byte is a leading whitespace fix while at that.

Signed-off-by: Michael Shigorin <mike@altlinux.org>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: add additional cgroup checks

- list all cgroup v1 mountpoints
- list all cgroup v2 mountpoints
- report "missing" when no mountpoint for the systemd controller was found
- report "missing" when no mountpoint for the freezer controller was found

Closes https://github.com/lxc/lxd/issues/3687.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: use "which"

Somehow "type" doesn't really work.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Add CONFIG_NETFILTER_XT_MATCH_COMMENT to lxc-checkconfig

Closes https://github.com/lxc/lxd/issues/3685

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

confile: lxc_listconfigs -> lxc_list_config_items

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

confile: non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "debian: jessie and stretch keyring support"

This reverts commit 87eacd4d49033d38d7e3257046079a77fd60e588.

While that commit looks right, the actual signing key doesn't match and
debootstrap therefore fails to bootstrap, as can be seen here:

https://jenkins.linuxcontainers.org/view/All/job/lxc-template-debian/

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Fix mem leak with realpath

Signed-off-by: Shukui Yang <yangshukui@huawei.com>

android: fix includes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: remove 5s timeout

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

debian: jessie and stretch keyring support

Signed-off-by: feng xiahou xiahoufeng@yahoo.com

debian: Add buster as a valid release

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

start: ensure cgroups are cleaned up

When a container is marked as being in STOPPED state it is possible for another
thread to start it again even though not all cleanup operations for that
container have finished. This is not a problem for most things like sockets and
friends which are unique to the container. It is however a problem for cgroups
which are named after that container in that we cause our cgroup driver to
waste cpu cycles finding a new cgroup name.

Closes  #1726.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

travis: fix builds

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

userns.conf: remove obsolete bind-mounts

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: NOTICE() on mounts on container's /dev

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: lxc_fill_autodev()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: switch to has_fs_type()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

utils: add has_fs_type() + is_fs_type()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_autodev()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: lxchook_names

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_entry()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: cull_mntent_opt()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_entry_create_dir_file()

bugfixes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

android: include custom mntent

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_entry_on_generic()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_entry_on_systemfs()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_entry_on_absolute_rootfs()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: setup_mount_entries()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: make_anonymous_mount_file()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: setup_mount()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

conf: mount_file_entries()

non-functional changes

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

templates/opensuse: support leap 42.3

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

templates/opensuse: getty.target.wants does not always exists

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

templates/opensuse: fix tumbleweed software selection

tumbleweed needs a newer version for a few packages, namely:
* liblua5_3
* bncurses6
* breadline7

As Leap it also has no dhcpd, but udhcp which gets pulled in already.
Further iproute2 and net-tools need manual instalation.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

templates/opensuse: tumbleweed has no update repo

As tumbleweed is a rolling release it has not update repository.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

utils: rework lxc_deslashify()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tree-wide: struct bdev -> struct lxc_storage

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

storage: rename files "bdev" -> "storage"

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Merge pull request #1747 from brauner/2017-08-15/stable_2_0_cherry_picks

stable 2.0: revert a bunch of cherry picks

storage: handle overlay for stable 2.0

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all dir paths"

This reverts commit 276fb978ee319c690e6c9ce9df16fb7a21953d2d.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add lxc_storage_get_path()"

This reverts commit ef72d7d681c49c008bf9da2522c7ef436cf78f46.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all btrfs paths"

This reverts commit f405c0c5cadbadf5b0beb42a346ca52f593777d3.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all lvm paths"

This reverts commit 6be74c07d0328f0d7b053524626bc83ae2b2276f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: check whether lxc.bdev.lvm.vg is set"

This reverts commit 0790b49260cbb48833367f3357b067fb851419cc.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: fix check"

This reverts commit 63539ebf3425fa62bbcfda60e7ea1bc7dedef9ef.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all nbd paths"

This reverts commit bdca6500054d3df9f704bcc5fe5d66f3837cce1b.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all rbd paths"

This reverts commit 2e0e18cca610359ae132452bc3b190f3d0335688.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: prefix all zfs paths"

This reverts commit aa7802e1095d19388b7b406c03e91a73d53a0b42.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: handle prefixed rootfs paths"

This reverts commit 84ae4b69653268029206317aabd5aaefa1f6a590.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify + bugfix"

This reverts commit 874a329ca6fd92057a3d243bfa6200906051393a.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "lvm: non-functional changes"

This reverts commit 7a8d7de2476b61005d80503ab8c816809bbc2d89.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "overlay: simplify and adapt to "overlay""

This reverts commit 7f79cc4c3457459dc20c4e40398395c5150618a9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "tools: remove empty snap directory"

This reverts commit d51915386e22a19da131a578330ab1115905c326.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: non-functional changes"

This reverts commit fb49a3cbebd4cf6433517f8550528ecf2a8aceb9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: export btrfs_snapshot_wrapper()"

This reverts commit 707f3fff59abe5db1033b4676e0063b35cfedd7b.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: enable unprivileged snapshots"

This reverts commit 2d66f57109b542b7a7a4882db74658374d2b5745.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: non-functional changes"

This reverts commit 8e295bc1a95441ddcf5290153322b8ca78971d8f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: only chown_mapped_root() if not btrfs"

This reverts commit d848b631492434985ffc5de9bbd7c631101077cb.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify"

This reverts commit 1aa0201f1446f1387c649467d86e923c9e9ecccf.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: simplify"

This reverts commit 36c55bf31c67d5048b6dd7f85ac425f3b2e22fd3.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add create_{clone,snapshot}()"

This reverts commit 667fa8cef1afc88bbe20c04523521556cb2946ac.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "btrfs: switch to btrfs_create_{clone,snapshot}()"

This reverts commit 618b655b4ed187b4853841813f9831b85987339a.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: add arg to create_snapshot()"

This reverts commit a3e85dae4e02ad9d3b8fcf6bf301907ef55a7c01.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: rework lvm backend"

This reverts commit 9a534c222664cb3b2705fcf523d67de8522011d1.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "dir: non-functional changes"

This reverts commit 8f2896da31e7822eb7894a5ade9e11652fe75f7f.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "dir: improvements"

This reverts commit 23eb8575d414d8b448398e9ed45d83741296a1ca.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "bdev: non-functional changes"

This reverts commit 8608cb0bd3b4ecd8bdf57a397b43ee9f344b8870.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "rsync: add new rsync functions"

This reverts commit 2ea2f3c8a6509cddbeebab92a0d3c56d4bf48be9.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Revert "storage: switch to new rsync functions"

This reverts commit a493a694166e65edbf412433a605042cc0ac3d0e.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>