]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
9 years agoFix typos and option 82 handling in DHCP sort changes 1852/head
Philippe Wooding [Mon, 21 Nov 2016 11:07:24 +0000 (12:07 +0100)] 
Fix typos and option 82 handling in DHCP sort changes

9 years agoremove unused macro
Alan T. DeKok [Sun, 20 Nov 2016 15:31:49 +0000 (10:31 -0500)] 
remove unused macro

9 years agonote TODOs
Alan T. DeKok [Sun, 20 Nov 2016 03:35:35 +0000 (22:35 -0500)] 
note TODOs

9 years agoadded replies to RADIUS tracking table
Alan T. DeKok [Sun, 20 Nov 2016 03:20:01 +0000 (22:20 -0500)] 
added replies to RADIUS tracking table

9 years agoSimple RADIUS packet tracking API
Alan T. DeKok [Sun, 20 Nov 2016 02:49:39 +0000 (21:49 -0500)] 
Simple RADIUS packet tracking API

9 years agofix APi for fr_message_localize
Alan T. DeKok [Sun, 20 Nov 2016 02:09:44 +0000 (21:09 -0500)] 
fix APi for fr_message_localize

9 years agoadded fr_ring_buffer_start()
Alan T. DeKok [Sun, 20 Nov 2016 01:52:45 +0000 (20:52 -0500)] 
added fr_ring_buffer_start()

Which gets "pointer + size" to the data at the start of the
ring buffer.

9 years agocleanups, and fr_message_done() doesn't need ms
Alan T. DeKok [Sun, 20 Nov 2016 01:43:38 +0000 (20:43 -0500)] 
cleanups, and fr_message_done() doesn't need ms

9 years agom_* -> mr_*
Alan T. DeKok [Sun, 20 Nov 2016 01:34:05 +0000 (20:34 -0500)] 
m_* -> mr_*

which is a better name

9 years agodocument -t
Alan T. DeKok [Sun, 20 Nov 2016 01:33:55 +0000 (20:33 -0500)] 
document -t

9 years agoAssignment to tmp not used
Arran Cudbard-Bell [Sat, 19 Nov 2016 18:58:29 +0000 (13:58 -0500)] 
Assignment to tmp not used

9 years agoAdd fr_message_alloc_reserve()
Alan T. DeKok [Sat, 19 Nov 2016 15:26:39 +0000 (10:26 -0500)] 
Add fr_message_alloc_reserve()

For protocols like TCP, where we reserve a large chunk of memory,
and then read multiple packets into it.  If we want to have a
unique messages for each unique packet, we need to be able to
allocate a message, while reserving the rest of the buffer.

9 years ago%zd -> %zu
Alan T. DeKok [Sat, 19 Nov 2016 15:03:23 +0000 (10:03 -0500)] 
%zd -> %zu

9 years agouse src_type. src->type isn't (yet) used everywhere.
Alan T. DeKok [Sat, 19 Nov 2016 15:00:24 +0000 (10:00 -0500)] 
use src_type.  src->type isn't (yet) used everywhere.

clang complains about this, and src_type is used everywhere else
in this function, so we should probably use it here

9 years agoremove unused variable
Alan T. DeKok [Sat, 19 Nov 2016 14:57:48 +0000 (09:57 -0500)] 
remove unused variable

9 years agoFix typo
Alan T. DeKok [Sat, 19 Nov 2016 14:55:55 +0000 (09:55 -0500)] 
Fix typo

9 years agoReduce scope of custom in fr_vasprintf
Arran Cudbard-Bell [Sat, 19 Nov 2016 14:21:51 +0000 (09:21 -0500)] 
Reduce scope of custom in fr_vasprintf

9 years agotravis warnings
Alan T. DeKok [Sat, 19 Nov 2016 03:32:00 +0000 (22:32 -0500)] 
travis warnings

9 years agosplit out allocate message from allocate ring buffer
Alan T. DeKok [Sat, 19 Nov 2016 02:08:30 +0000 (21:08 -0500)] 
split out allocate message from allocate ring buffer

9 years agofix comparison checks. Fixes #1851
Alan T. DeKok [Sat, 19 Nov 2016 01:58:19 +0000 (20:58 -0500)] 
fix comparison checks.  Fixes #1851

9 years agoFix initialization errors
Alan T. DeKok [Sat, 19 Nov 2016 01:55:36 +0000 (20:55 -0500)] 
Fix initialization errors

9 years agofix inner-tunnel policy
Alan T. DeKok [Sat, 19 Nov 2016 00:35:13 +0000 (19:35 -0500)] 
fix inner-tunnel policy

This policy replaces "use_tunneled_reply".  It's better to use
if (0) { ...} to disable blocks of code, instead of commenting it out.

Also, update the local reply before copying it to the outer
session-state list.  That makes a lot more sense.

9 years agoset reserved
Alan T. DeKok [Sat, 19 Nov 2016 00:20:28 +0000 (19:20 -0500)] 
set reserved

9 years agoadd fr_ring_buffer_reserve_split()
Alan T. DeKok [Fri, 18 Nov 2016 23:41:58 +0000 (18:41 -0500)] 
add fr_ring_buffer_reserve_split()

Which lets the caller fix a partial packet, and move it to
a new ring buffer.

9 years agoOverload %p printk style
Arran Cudbard-Bell [Fri, 18 Nov 2016 23:24:14 +0000 (18:24 -0500)] 
Overload %p printk style

9 years agoAdd custom fprintf style function for talloc binary buffers and value boxes
Arran Cudbard-Bell [Fri, 18 Nov 2016 22:57:05 +0000 (17:57 -0500)] 
Add custom fprintf style function for talloc binary buffers and value boxes

9 years agoFix previous commit
Arran Cudbard-Bell [Fri, 18 Nov 2016 18:27:18 +0000 (13:27 -0500)] 
Fix previous commit

9 years agoFix DHCP attribute ordering
Arran Cudbard-Bell [Fri, 18 Nov 2016 18:17:17 +0000 (13:17 -0500)] 
Fix DHCP attribute ordering

9 years agoExtra space between cache options and colon
Arran Cudbard-Bell [Thu, 17 Nov 2016 17:53:31 +0000 (12:53 -0500)] 
Extra space between cache options and colon

9 years agoset reply code
Alan T. DeKok [Fri, 18 Nov 2016 17:01:29 +0000 (12:01 -0500)] 
set reply code

9 years agoreject on no auth-type
Alan T. DeKok [Fri, 18 Nov 2016 16:18:59 +0000 (11:18 -0500)] 
reject on no auth-type

9 years agoadded "todo" note about UDP protocols
Alan T. DeKok [Fri, 18 Nov 2016 14:35:28 +0000 (09:35 -0500)] 
added "todo" note about UDP protocols

9 years agoAdded "protocol" field to each message.
Alan T. DeKok [Fri, 18 Nov 2016 14:26:31 +0000 (09:26 -0500)] 
Added "protocol" field to each message.

9 years agoDon't copy the entire datum union
Arran Cudbard-Bell [Thu, 17 Nov 2016 17:49:00 +0000 (12:49 -0500)] 
Don't copy the entire datum union

9 years agoFormatting
Arran Cudbard-Bell [Thu, 17 Nov 2016 17:48:29 +0000 (12:48 -0500)] 
Formatting

9 years agore-order fields in value_box to match PW_TYPE
Arran Cudbard-Bell [Thu, 17 Nov 2016 13:04:50 +0000 (08:04 -0500)] 
re-order fields in value_box to match PW_TYPE

9 years agoAdd missing field sizes
Arran Cudbard-Bell [Thu, 17 Nov 2016 01:45:45 +0000 (20:45 -0500)] 
Add missing field sizes

9 years agoCorrect src offset in _tmpl_to_atype
Arran Cudbard-Bell [Thu, 17 Nov 2016 12:55:28 +0000 (07:55 -0500)] 
Correct src offset in _tmpl_to_atype

9 years agoFormatting
Arran Cudbard-Bell [Thu, 17 Nov 2016 13:55:26 +0000 (08:55 -0500)] 
Formatting

9 years agoFormatting
Arran Cudbard-Bell [Wed, 16 Nov 2016 22:05:49 +0000 (17:05 -0500)] 
Formatting

9 years agoUse the correct source fields in value_box_hton
Arran Cudbard-Bell [Wed, 16 Nov 2016 22:05:34 +0000 (17:05 -0500)] 
Use the correct source fields in value_box_hton

9 years agoRename cond tokenization and cond evaluation functions
Arran Cudbard-Bell [Wed, 16 Nov 2016 20:21:49 +0000 (15:21 -0500)] 
Rename cond tokenization and cond evaluation functions

parser.c and evaluate.c really‽

9 years agos/tmpl_data/tmpl_value_box/g
Arran Cudbard-Bell [Wed, 16 Nov 2016 17:18:47 +0000 (12:18 -0500)] 
s/tmpl_data/tmpl_value_box/g

9 years agoDon't use an anonymous union inside value_box_t
Arran Cudbard-Bell [Tue, 15 Nov 2016 23:02:56 +0000 (18:02 -0500)] 
Don't use an anonymous union inside value_box_t

Too many other things in there now...

9 years agoRevert "s/tmpl_data_value/tmpl_data_box/g"
Arran Cudbard-Bell [Wed, 16 Nov 2016 16:39:48 +0000 (11:39 -0500)] 
Revert "s/tmpl_data_value/tmpl_data_box/g"

So i can apply the large patch set I was working on cleanly...

9 years agoMerge pull request #1848 from herwinw/rlm_winbind_const_fixes
Alan DeKok [Wed, 16 Nov 2016 16:16:35 +0000 (11:16 -0500)] 
Merge pull request #1848 from herwinw/rlm_winbind_const_fixes

Use const consistently in rlm_winbind

9 years agoUse const consistently in rlm_winbind 1848/head
Herwin Weststrate [Wed, 16 Nov 2016 15:27:32 +0000 (16:27 +0100)] 
Use const consistently in rlm_winbind

This saves us a compiler warning.

9 years agos/tmpl_data_value/tmpl_data_box/g
Alan T. DeKok [Wed, 16 Nov 2016 14:59:13 +0000 (09:59 -0500)] 
s/tmpl_data_value/tmpl_data_box/g

9 years agodoxygen
Alan T. DeKok [Tue, 15 Nov 2016 22:52:06 +0000 (17:52 -0500)] 
doxygen

9 years agoadd context pointer to event list status function
Alan T. DeKok [Tue, 15 Nov 2016 21:22:58 +0000 (16:22 -0500)] 
add context pointer to event list status function

In preparation for scheduler idle loop work.

9 years agoRename value_data_t to value_box_t
Arran Cudbard-Bell [Tue, 15 Nov 2016 21:27:43 +0000 (16:27 -0500)] 
Rename value_data_t to value_box_t

9 years agovalue_data_hton() should take value_data_t for src
Alan T. DeKok [Tue, 15 Nov 2016 20:44:19 +0000 (15:44 -0500)] 
value_data_hton() should take value_data_t for src

9 years agoadd priority to request messages
Alan T. DeKok [Tue, 15 Nov 2016 20:20:17 +0000 (15:20 -0500)] 
add priority to request messages

so that the worker knows how to prioritize them

9 years agomove the union back to the start of value_data_t
Alan T. DeKok [Tue, 15 Nov 2016 20:18:07 +0000 (15:18 -0500)] 
move the union back to the start of value_data_t

because it's just too hard to separate the pointers to the data
from the pointers to the value_data_t.

9 years agouse union.datum as a generic pointer
Alan T. DeKok [Tue, 15 Nov 2016 20:16:10 +0000 (15:16 -0500)] 
use union.datum as a generic pointer

9 years agotrack pointer instead of complex struct
Alan T. DeKok [Tue, 15 Nov 2016 20:15:50 +0000 (15:15 -0500)] 
track pointer instead of complex struct

9 years agopass the contents, not the value_data_t
Alan T. DeKok [Tue, 15 Nov 2016 19:28:43 +0000 (14:28 -0500)] 
pass the contents, not the value_data_t

9 years agomark value_data as tainted on copy / steal
Alan T. DeKok [Tue, 15 Nov 2016 19:25:28 +0000 (14:25 -0500)] 
mark value_data as tainted on copy / steal

9 years agodon't assume that the struct is packed in any particular order
Alan T. DeKok [Tue, 15 Nov 2016 19:21:38 +0000 (14:21 -0500)] 
don't assume that the struct is packed in any particular order

Part 2.

LOTS of references to &vp->data.  Some of which are to the union,
and some of which are to the data inside of the union.

Separating them isn't trivial.

9 years agoinclude linked list and worker stats into time tracking.
Alan T. DeKok [Tue, 15 Nov 2016 19:10:25 +0000 (14:10 -0500)] 
include linked list and worker stats into time tracking.

So we have one API call to track time && yielded list,
instead of two.

9 years agodon't assume that the struct is packed in any particular order
Alan T. DeKok [Tue, 15 Nov 2016 18:35:44 +0000 (13:35 -0500)] 
don't assume that the struct is packed in any particular order

i.e. if we need sub-element "foo", refer to sub-element "foo".

9 years agofilters might as well be uint8_t.
Alan T. DeKok [Tue, 15 Nov 2016 18:32:48 +0000 (13:32 -0500)] 
filters might as well be uint8_t.

We don't access them as anything else.

9 years agopass the correct length to hex2bin
Alan T. DeKok [Tue, 15 Nov 2016 17:31:20 +0000 (12:31 -0500)] 
pass the correct length to hex2bin

9 years agoset all of the message to zero on allocation
Alan T. DeKok [Tue, 15 Nov 2016 16:24:54 +0000 (11:24 -0500)] 
set all of the message to zero on allocation

9 years agoDon't create the symlink every time we run make
Alan T. DeKok [Tue, 15 Nov 2016 16:11:55 +0000 (11:11 -0500)] 
Don't create the symlink every time we run make

9 years agomark User-Name from EAP packets as tainted
Alan T. DeKok [Tue, 15 Nov 2016 16:11:40 +0000 (11:11 -0500)] 
mark User-Name from EAP packets as tainted

9 years agoVPs coming from packets are tainted
Alan T. DeKok [Tue, 15 Nov 2016 15:56:52 +0000 (10:56 -0500)] 
VPs coming from packets are tainted

9 years agoVPs coming from packets are tainted
Alan T. DeKok [Tue, 15 Nov 2016 15:56:44 +0000 (10:56 -0500)] 
VPs coming from packets are tainted

9 years agoVPs coming from external programs are tainted.
Alan T. DeKok [Tue, 15 Nov 2016 15:49:52 +0000 (10:49 -0500)] 
VPs coming from external programs are tainted.

9 years agoVPs coming from packets are tainted
Alan T. DeKok [Tue, 15 Nov 2016 15:49:36 +0000 (10:49 -0500)] 
VPs coming from packets are tainted

9 years agofunction to mark VPs as tainted
Alan T. DeKok [Tue, 15 Nov 2016 15:49:22 +0000 (10:49 -0500)] 
function to mark VPs as tainted

9 years agoMove fields around, and add "type" and "tainted" flags.
Alan T. DeKok [Tue, 15 Nov 2016 15:41:08 +0000 (10:41 -0500)] 
Move fields around, and add "type" and "tainted" flags.

So that value_data_t becomes a bit more like a real boxed value
structure

9 years agoMerge pull request #1844 from herwinw/rlm_rest_json_prefix_buf
Alan DeKok [Tue, 15 Nov 2016 15:50:18 +0000 (10:50 -0500)] 
Merge pull request #1844 from herwinw/rlm_rest_json_prefix_buf

Use stack based char array to generate JSON keys

9 years agoUse stack based char array to generate JSON keys 1844/head
Herwin Weststrate [Sat, 12 Nov 2016 17:02:19 +0000 (18:02 +0100)] 
Use stack based char array to generate JSON keys

This saves us from having to allocate memory in a loop. It simplifies
the code a little bit too, by removing an if statement that was far away
from the code that generated the requirement to call it.

9 years agoallow us to put the channel into the message
Alan T. DeKok [Mon, 14 Nov 2016 21:46:28 +0000 (16:46 -0500)] 
allow us to put the channel into the message

9 years agoclean up link and order dependencies
Alan T. DeKok [Mon, 14 Nov 2016 21:41:34 +0000 (16:41 -0500)] 
clean up link and order dependencies

9 years agoCase
Arran Cudbard-Bell [Mon, 14 Nov 2016 21:19:36 +0000 (16:19 -0500)] 
Case

9 years agoNO is 0. YES is 1.
Alan T. DeKok [Mon, 14 Nov 2016 19:30:10 +0000 (14:30 -0500)] 
NO is 0. YES is 1.

9 years agoreturn good value
Alan T. DeKok [Mon, 14 Nov 2016 19:29:50 +0000 (14:29 -0500)] 
return good value

9 years agopreliminary code for new / close channel
Alan T. DeKok [Mon, 14 Nov 2016 19:08:44 +0000 (14:08 -0500)] 
preliminary code for new / close channel

9 years agoreturn which channel needs servicing
Alan T. DeKok [Mon, 14 Nov 2016 18:05:10 +0000 (13:05 -0500)] 
return which channel needs servicing

9 years agonames are better than magic numbers
Alan T. DeKok [Mon, 14 Nov 2016 17:57:31 +0000 (12:57 -0500)] 
names are better than magic numbers

9 years agoerrno is already defined, and CANNOT be re-defined
Alan T. DeKok [Mon, 14 Nov 2016 17:54:34 +0000 (12:54 -0500)] 
errno is already defined, and CANNOT be re-defined

9 years agodon't put business logic into an assertion
Alan T. DeKok [Mon, 14 Nov 2016 17:54:02 +0000 (12:54 -0500)] 
don't put business logic into an assertion

9 years agotweak signal logic
Alan T. DeKok [Mon, 14 Nov 2016 17:37:59 +0000 (12:37 -0500)] 
tweak signal logic

9 years agotravis fix
Alan T. DeKok [Mon, 14 Nov 2016 17:36:34 +0000 (12:36 -0500)] 
travis fix

9 years agotry to build rlm_lua, too
Alan T. DeKok [Mon, 14 Nov 2016 15:59:48 +0000 (10:59 -0500)] 
try to build rlm_lua, too

9 years agoMerge pull request #1842 from herwinw/gendh_dhparam
Alan DeKok [Mon, 14 Nov 2016 15:35:59 +0000 (10:35 -0500)] 
Merge pull request #1842 from herwinw/gendh_dhparam

Use 'openssl dhparam' to create DH-params

9 years agoconst-ify it
Alan T. DeKok [Mon, 14 Nov 2016 15:32:04 +0000 (10:32 -0500)] 
const-ify it

9 years agodon't need this
Alan T. DeKok [Mon, 14 Nov 2016 13:49:38 +0000 (08:49 -0500)] 
don't need this

9 years agoUse 'openssl dhparam' to create DH-params 1842/head
Herwin Weststrate [Sat, 12 Nov 2016 15:13:50 +0000 (16:13 +0100)] 
Use 'openssl dhparam' to create DH-params

'openssl gendh' is removed in newer version of OpenSSL, and using
dhparam appears to work since at least release 0.9.8

9 years agoLink libfreeradius-util to dependencies
Arran Cudbard-Bell [Sun, 13 Nov 2016 13:25:13 +0000 (08:25 -0500)] 
Link libfreeradius-util to dependencies

Else it doesn't link to kevent

9 years agoFix doxygen and argument order for module_find_with_method
Arran Cudbard-Bell [Sat, 12 Nov 2016 20:34:11 +0000 (15:34 -0500)] 
Fix doxygen and argument order for module_find_with_method

9 years agoSplit out virtual_server functions from modules.c
Arran Cudbard-Bell [Sat, 12 Nov 2016 20:27:50 +0000 (15:27 -0500)] 
Split out virtual_server functions from modules.c

9 years agoConstify more inst and ctx pointers
Arran Cudbard-Bell [Sat, 12 Nov 2016 15:02:53 +0000 (10:02 -0500)] 
Constify more inst and ctx pointers

Add thread pointer for thread specific instances

9 years agodoxygen for kev
Alan T. DeKok [Sat, 12 Nov 2016 15:14:30 +0000 (10:14 -0500)] 
doxygen for kev

9 years agocomments
Alan T. DeKok [Sat, 12 Nov 2016 14:53:13 +0000 (09:53 -0500)] 
comments

9 years agoMerge pull request #1841 from herwinw/cppcheck
Alan DeKok [Sat, 12 Nov 2016 14:48:55 +0000 (09:48 -0500)] 
Merge pull request #1841 from herwinw/cppcheck

Fixed some cppcheck warnings

9 years agofr_redis_cluster_node_addr_by_role returns an ssize_t 1841/head
Herwin Weststrate [Sat, 12 Nov 2016 13:12:02 +0000 (14:12 +0100)] 
fr_redis_cluster_node_addr_by_role returns an ssize_t

9 years agoRemoved impossible to reach else statements
Herwin Weststrate [Sat, 12 Nov 2016 13:10:35 +0000 (14:10 +0100)] 
Removed impossible to reach else statements

We had "if (<int> < 0)" else "else if (<int> >= 0)", which cover all
possibilities